Re: Review Request: plasmoid qalculate - menu button
On Dec. 9, 2011, 2:53 p.m., Aaron J. Seigo wrote: we tried the plasmoid with a couple of people here at the house and comments included: * the history should be remembered between restarts (e.g.: save to config) * instead of showing the result in a tooltip, it should be shown in the plasmoid itself (as if you had typed in the equation; would also make it easy to go back to an older equation and re-edit it) * the history button should be enabled only when there are items in the history * the answer should be selectable for copy/past purposes (that's not the fault of your patch, of course :) very nice improvement already though .. due to feature freeze this can't go in until 4.9 devel opens up (in january), so there remains time to improve this further. thanks for the patch, i look forward to seeing further improvements! :) great feedback! I'll see what I can do! - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8821 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/ --- (Updated Dec. 8, 2011, 8:48 p.m.) Review request for Plasma. Description --- Hey dudes, I implemented a little menu that displays the last 10 results. improvement ideas? I found this task in the plasma task list: http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid Diffs - applets/qalculate/qalculate_applet.h aee14c0 applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 10, 2011, 11:39 a.m.) Review request for kwin and Plasma. Changes --- wrong bug number Description --- Rework of sliding popups effect based on change to use -1 as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 287602. http://bugs.kde.org/show_bug.cgi?id=287602 Diffs - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Blur behind animated sliding popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103375/ --- Review request for kwin and Plasma. Description --- Title says it all. This change allows to have the background of sliding popups blurred. Tested, no artifacts on panels, also not with hard cases such as Yakuake. Requires the other sliding popup related patches. As far as my system is concerned it has no impact on performance. Nevertheless I will try to make it work with the cached blur version. As it might impact performance, I'm not sure whether this is 4.8 material. I let Aaron decide :-) Diffs - kwin/effects/blur/blur.cpp c566e34 kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103375/diff/diff Testing --- Screenshots --- Kickoff with blur during animation http://git.reviewboard.kde.org/r/103375/s/358/ Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/#review8850 --- Ship it! Works for yakuake, no glitch Plasma certainly requires the other patch applied (the extender thingies aren't catched at all here) - Thomas Lübking On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 10, 2011, 11:39 a.m.) Review request for kwin and Plasma. Description --- Rework of sliding popups effect based on change to use -1 as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 287602. http://bugs.kde.org/show_bug.cgi?id=287602 Diffs - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 1/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103366/#review8862 --- This review has been submitted with commit 5960ae9846c333ef381a817af9d63776c4ddc201 by Martin Gräßlin to branch KDE/4.7. - Commit Hook On Dec. 9, 2011, 5:18 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103366/ --- (Updated Dec. 9, 2011, 5:18 p.m.) Review request for kwin and Plasma. Description --- When the offset was not explicitly specified, the actual distance of the window to the nearest screen edge should be used as offset. This was calculated incorrectly resulting in broken code in the kwin effect. With this change a new default is introduced as -1 which is interpreted by kwin as kwin has to calculate the correct offset. Now it would be possible to do this in the library and pass the correct offset, but the library would have to create a QDesktopWidget just to calculate the screen geometry. KWin on the other hand knows the screen size, so having the default is IMHO better. Adjustments to kwin come in next patch for kde-workspace This addresses bug 287602. http://bugs.kde.org/show_bug.cgi?id=287602 Diffs - plasma/windoweffects.cpp ce41176 Diff: http://git.reviewboard.kde.org/r/103366/diff/diff Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Blur behind animated sliding popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103375/#review8863 --- This review has been submitted with commit cd78335fef23c290a09fec29d7d9600f0076d63a by Martin Gräßlin to branch master. - Commit Hook On Dec. 10, 2011, 12:43 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103375/ --- (Updated Dec. 10, 2011, 12:43 p.m.) Review request for kwin and Plasma. Description --- Title says it all. This change allows to have the background of sliding popups blurred. Tested, no artifacts on panels, also not with hard cases such as Yakuake. Requires the other sliding popup related patches. As far as my system is concerned it has no impact on performance. Nevertheless I will try to make it work with the cached blur version. As it might impact performance, I'm not sure whether this is 4.8 material. I let Aaron decide :-) Diffs - kwin/effects/blur/blur.cpp c566e34 kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103375/diff/diff Testing --- Screenshots --- Kickoff with blur during animation http://git.reviewboard.kde.org/r/103375/s/358/ Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/#review8864 --- This review has been submitted with commit cbdd7295d100b19ec55d4b88f2a8113095439e26 by Martin Gräßlin to branch master. - Commit Hook On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 10, 2011, 11:39 a.m.) Review request for kwin and Plasma. Description --- Rework of sliding popups effect based on change to use -1 as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 287602. http://bugs.kde.org/show_bug.cgi?id=287602 Diffs - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
