[KDE Bugtracking System] REMINDER: current Plasma regressions

2012-06-28 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma

  This search was scheduled by myr...@kde.org.


Plasma regressions
--
Bug 300885:
  https://bugs.kde.org/show_bug.cgi?id=300885
  Priority: NOR  Severity: critical  Platform: Ubuntu Packages
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Weather widget does not work anymore with bbcuk or wetter.com 
provider
Bug 301424:
  https://bugs.kde.org/show_bug.cgi?id=301424
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Cannot open battery monitor applet if set to hidden in systray
Bug 301459:
  https://bugs.kde.org/show_bug.cgi?id=301459
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: plasma-b...@kde.org
Status: UNCONFIRMED
   Summary: Categories button should reflect the category being filtered on
Bug 301460:
  https://bugs.kde.org/show_bug.cgi?id=301460
  Priority: NOR  Severity: normal  Platform: Other
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Switching activities became really slow
Bug 301533:
  https://bugs.kde.org/show_bug.cgi?id=301533
  Priority: NOR  Severity: normal  Platform: Other
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Option Show Multiple Batteries does nothing
Bug 302331:
  https://bugs.kde.org/show_bug.cgi?id=302331
  Priority: NOR  Severity: normal  Platform: Ubuntu Packages
  Assignee: ignat.seme...@blue-systems.com
Status: UNCONFIRMED
   Summary: [post 4.9beta2] Folderview does not show any to activity linked 
files


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Adding an image to slideshow.

2012-06-28 Thread Varun Herale
Hello,

This is regarding bug#302612 https://bugs.kde.org/show_bug.cgi?id=302612.

When a URL is added using setUrls(url), the path is temporarily added to
the m_slideshowBackgrounds list. But when the next slide is rendered this
member doesn't remember the path added. It goes back to only containing the
paths of images in the slideshow folder. So it is a good thing to copy the
image into the slideshow folder in this case ?

--
Varun Herale
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Plasma Bug Workflow BOF

2012-06-28 Thread Sebastian Kügler
On Friday, June 22, 2012 15:11:42 Myriam Schweingruber wrote:
 What needs to be understood is that all code can have bugs, that is
 only natural and nobody will deny that. But that also means that we
 should thrive to make the code better, and IMHO to some extend a
 developer should feel responsible for the code s/he commits and also
 take care of the bugs that are found.
 
 While I understand that nobody likes pressure it should also be
 understood the perception from the other side: developers not even
 looking at bugs in their own code are perceived as arrogant and
 uncooperative. With the current situation the politics of putting the
 head in the ground or just walking away with the I don't have time
 wave is not going to help, so efforts need to be done on all sides.

You seem to be implying that putting pressure onto people is going to change 
this: a fallacy. It actually works the other way round. If you put this kind 
of pressure onto people, they'll turn around and go elsewhere, so you're 
actually decreasing the resources available to fix bugs. It's counter-
intuitive, so easy to make this mistake. Yet, it's still a mistake.

I agree with your goals, I disagree with put pressure onto people being a 
valid way to deal with that -- it's detrimental to motivation and counter-
productive to our shared goal, which is improving the quality of our software.

I've elaborated on ways to make developers care, but now I doubt that message 
actually got through, so let me try to repeat it as concise as possible:

- respect and being friendly are paramoumt to everything
- don't put blame or extra pressure onto the people who are already doing the 
  work
- don't try making decisions about priorities for others, instead provide 
  information that makes it easier to prioritize, but accept others priorities
- developers handle chopped up pieces better than drinking from the firehose 
  (your regression lists are awesome in that respect, also aids prioritizing)
- bug squashing, like most other activities in Free software needs to happen 
  bottom-up
- we collaborate instead of dictating and blaming

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Raj change

2012-06-28 Thread Sebastian Kügler
On Wednesday, June 20, 2012 18:01:54 Swapnil Bhartiya wrote:
  I think the mistake we made was to go for 300€ with no explanation,
  just
  changing it to 60€ sounds like repeating the same mistake.
 
 When I left home and moved to Delhi to prepare for my mass communication
 and journalism degree I was getting around 50€-60€ per month. 300€ is
 more than my first salary as a journalist ;-)
 
 So, I think 60€ is closer to reality.

I'll change it, and will add a note to prevent confusion (it has created 
enough already).
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Re: Team meeting today

2012-06-28 Thread Sebastian Kügler
On Thursday, June 21, 2012 16:49:42 Mark wrote:
 I'm not sure about this but someone with in depth git knowledge can
 probably clarify on this. I think git has an option to at least show
 which people commited to which file. If you simply do that for all of

git log .

in a given directory helps.
-- 
sebas, might be stating the obvious here :)

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where I can find api documents of qml?

2012-06-28 Thread qasdfgtyuiop
The problem has been solved.  Thank you.

2012/6/28 Shaun Reich sre...@kde.org:
 The best way right now is to use org.kde.qtextracomponents and use QIconItem
 and set the icon property to e.g. dialog-warning.

 Its the equivalent to kdes kicon and what not.

 And you can discover which icon you want by using kdialog --geticon actions.


 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


How to access calendar using javascript?

2012-06-28 Thread qasdfgtyuiop
I want to let my widget add some events to the calendar.  But I can
not find the api doc, where can I find them?
I have read these tutorials/documentations but I find nothing helpful:

http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API-DataEnginesServices
http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Martin Gräßlin
On Thursday 28 June 2012 08:56:21 Michail V. wrote:
 Is there a way to have windows previews in a qml plasmoid?
You can have that with declarative KWin scripts:
http://techbase.kde.org/Development/Tutorials/KWin/WindowSwitcher
http://techbase.kde.org/Development/Tutorials/KWin/Scripting

But it's not possible to use inside a Plasmoid. With some hacks something 
could be implemented in Plasma, but I would highly recommend to not do it :-)

Cheers
Martin
 
 For example is a tasks qml plasmoid possible?
 
 Regards,
 Michail


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop qasdfgtyu...@gmail.com wrote:
 The problem has been solved.  Thank you.

It's not really resolved the original problem of any missing docs.

qasdfgtyuiop, if you encounter issues like this where you can't find
the documentation and someone helps you please could you update
techbase.kde.org so as to help the next person.
Or at least make a list of everything you struggled to find so we know
what to update. (from my POV ideally in the form of bug reports,
component qml-components).

You're in the position of someone using the docs but not hacking on
kde-runtime, so you're actually the best person to do this out of any
of us.

Thanks in advance.

Dave


 2012/6/28 Shaun Reich sre...@kde.org:
 The best way right now is to use org.kde.qtextracomponents and use QIconItem
 and set the icon property to e.g. dialog-warning.

 Its the equivalent to kdes kicon and what not.

 And you can discover which icon you want by using kdialog --geticon actions.


 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where I can find api documents of qml?

2012-06-28 Thread gaoxiang
Ok, after I finish my program, I will look at the problem I met and write 
something
On Thursday 28 June 2012 10:09:19 David Edmundson wrote:
 On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop qasdfgtyu...@gmail.com 
wrote:
  The problem has been solved.  Thank you.
 
 It's not really resolved the original problem of any missing docs.
 
 qasdfgtyuiop, if you encounter issues like this where you can't find
 the documentation and someone helps you please could you update
 techbase.kde.org so as to help the next person.
 Or at least make a list of everything you struggled to find so we know
 what to update. (from my POV ideally in the form of bug reports,
 component qml-components).
 
 You're in the position of someone using the docs but not hacking on
 kde-runtime, so you're actually the best person to do this out of any
 of us.
 
 Thanks in advance.
 
 Dave
 
  2012/6/28 Shaun Reich sre...@kde.org:
  The best way right now is to use org.kde.qtextracomponents and use
  QIconItem and set the icon property to e.g. dialog-warning.
  
  Its the equivalent to kdes kicon and what not.
  
  And you can discover which icon you want by using kdialog --geticon
  actions.
  
  
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
  
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where I can find api documents of qml?

2012-06-28 Thread David Edmundson
On Thu, Jun 28, 2012 at 10:30 AM, gaoxiang qasdfgtyu...@gmail.com wrote:
 Ok, after I finish my program, I will look at the problem I met and write
 something

Awesome

Thanks.

 On Thursday 28 June 2012 10:09:19 David Edmundson wrote:
 On Thu, Jun 28, 2012 at 8:42 AM, qasdfgtyuiop qasdfgtyu...@gmail.com
 wrote:
  The problem has been solved.  Thank you.

 It's not really resolved the original problem of any missing docs.

 qasdfgtyuiop, if you encounter issues like this where you can't find
 the documentation and someone helps you please could you update
 techbase.kde.org so as to help the next person.
 Or at least make a list of everything you struggled to find so we know
 what to update. (from my POV ideally in the form of bug reports,
 component qml-components).

 You're in the position of someone using the docs but not hacking on
 kde-runtime, so you're actually the best person to do this out of any
 of us.

 Thanks in advance.

 Dave

  2012/6/28 Shaun Reich sre...@kde.org:
  The best way right now is to use org.kde.qtextracomponents and use
  QIconItem and set the icon property to e.g. dialog-warning.
 
  Its the equivalent to kdes kicon and what not.
 
  And you can discover which icon you want by using kdialog --geticon
  actions.
 
 
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma applets inside QML applet

2012-06-28 Thread Marco Martin
On Monday 25 June 2012, Dmitry wrote:
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 
 Hello!
 
 I'm using C++ as a plugin for QML applet, not C++ applet with UI in QML.
 As for now it [systray applet] contains applets (but it isn't a good
 way) mixed with icons of other applications. I'm trying to find better
 way to place applets into tray.
 
 Thank you, Martin, for your help.
 

would be interesting an eventual future integration in the default plasmoids, 
since the plasma systemtray will have to be rewritten in qml as well

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Where can I define my widget's preference?

2012-06-28 Thread gaoxiang
I think I'm having trouble with documentions.  These documentations gives 
little information.  I have not find any tutorials or documentations on where 
and how my widget's preference should be defined so I have to ask here.
Please give some links or hints on how I should do these things. After my 
program finish, I will write something about the help I got to enrich our 
documentations.
Thanks.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Plasma Bug Workflow BOF

2012-06-28 Thread David Edmundson
On Mon, Jun 25, 2012 at 8:18 AM, Sebastian Kügler se...@kde.org wrote:
 On Friday, June 22, 2012 15:11:42 Myriam Schweingruber wrote:
 What needs to be understood is that all code can have bugs, that is
 only natural and nobody will deny that. But that also means that we
 should thrive to make the code better, and IMHO to some extend a
 developer should feel responsible for the code s/he commits and also
 take care of the bugs that are found.

 While I understand that nobody likes pressure it should also be
 understood the perception from the other side: developers not even
 looking at bugs in their own code are perceived as arrogant and
 uncooperative. With the current situation the politics of putting the
 head in the ground or just walking away with the I don't have time
 wave is not going to help, so efforts need to be done on all sides.

 You seem to be implying that putting pressure onto people is going to change
 this: a fallacy. It actually works the other way round. If you put this kind
 of pressure onto people, they'll turn around and go elsewhere, so you're
 actually decreasing the resources available to fix bugs.

This pressure can be in the form of encouragement, organisation and
good examples.  This has to come from the top-down of the project, as
everyone respects (and therefore copies) their elders.

It's counterintuitive, so easy to make this mistake. Yet, it's still a mistake.

 I agree with your goals, I disagree with put pressure onto people being a
 valid way to deal with that -- it's detrimental to motivation and counter-
 productive to our shared goal, which is improving the quality of our software.

 I've elaborated on ways to make developers care, but now I doubt that message
 actually got through, so let me try to repeat it as concise as possible:

 - respect and being friendly are paramoumt to everything
 - don't put blame or extra pressure onto the people who are already doing the
  work
 - don't try making decisions about priorities for others, instead provide
  information that makes it easier to prioritize, but accept others priorities
 - developers handle chopped up pieces better than drinking from the firehose
  (your regression lists are awesome in that respect, also aids prioritizing)
 - bug squashing, like most other activities in Free software needs to happen
  bottom-up
 - we collaborate instead of dictating and blaming


I trust you'll be at the BOF? Martin G is doing an amazing job with a
very difficult product with regards to bugs and is clearly a
bug-wizard. We've adopted several of Martin's suggestions in KTp along
with some of our own ideas (which I'll be happy to share) and for us
bugs aren't a chore, they're a useful part of the workflow.

No point discussing this on the mailing list anymore - see you in 2 days :)

 Cheers,
 --
 sebas

 http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where can I define my widget's preference?

2012-06-28 Thread Tomaz Canabrava
On Thu, Jun 28, 2012 at 6:49 AM, gaoxiang qasdfgtyu...@gmail.com wrote:
 I think I'm having trouble with documentions.  These documentations gives
 little information.  I have not find any tutorials or documentations on where
 and how my widget's preference should be defined so I have to ask here.
 Please give some links or hints on how I should do these things. After my
 program finish, I will write something about the help I got to enrich our
 documentations.

Usually our documentation is in two places:
api.kde.org and techbase.kde.org,
if you find something somewhere else, it should be put in one of those two.

techbase is the place for all tutorials and tech-related stuff, and
api.kde.org is the documentation of the api.


 Thanks.
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where can I define my widget's preference?

2012-06-28 Thread Michail V.

Στις 28/06/2012 12:49 μμ, ο/η gaoxiang έγραψε:

I think I'm having trouble with documentions.  These documentations gives
little information.  I have not find any tutorials or documentations on where
and how my widget's preference should be defined so I have to ask here.
Please give some links or hints on how I should do these things. After my
program finish, I will write something about the help I got to enrich our
documentations.
Thanks.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
.


There are some tutorials here:
http://techbase.kde.org/Development/Tutorials#Managing_Configuration_Data_With_KConfig

http://techbase.kde.org/Special:MyLanguage/Development/Tutorials/KConfig
http://techbase.kde.org/Special:MyLanguage/Development/Tutorials/Using_KConfig_XT
http://techbase.kde.org/Special:MyLanguage/Development/Tutorials/Updating_KConfig_Files

I found them very helpful
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Johannes Tröscher

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/
---

Review request for Plasma and Aaron J. Seigo.


Description
---

this is mostly visible with dark-themes only.
as of now the text color got only changed when the hover-element was fully 
visible. this looked a bit weird.
this patch adds a ColorAnimation with the same duration as the 
opacity-animation on the hover-element as Behavior for the Label.
now the color changes fluently on hovering the ToolButton


Diffs
-

  plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 

Diff: http://git.reviewboard.kde.org/r/105375/diff/


Testing
---

tested, works


Thanks,

Johannes Tröscher

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: change default config of taskmanager

2012-06-28 Thread Greg T

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/
---

Review request for Plasma.


Description
---

libtaskmanager can't remove those (browser, preferred://browser, , , ) 
entrys, so I moved them to the Items list. I don't know why they were separated 
in the first place. That's why I'm opening this review request.


This addresses bug 278724.
http://bugs.kde.org/show_bug.cgi?id=278724


Diffs
-

  
plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
 afd1f2c 

Diff: http://git.reviewboard.kde.org/r/105374/diff/


Testing
---

no regressions noted.


Thanks,

Greg T

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where can I define my widget's preference?

2012-06-28 Thread Shaun Reich
Well, what's more important probably, is if this is qml or not. Because
that changes some things.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix the minimum size of some applets

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review15224
---


patch seems broken, perhaps was not made against current master. can you 
re-send the patch?

- Aaron J. Seigo


On June 22, 2012, 6:17 a.m., Maarten De Meyer wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105234/
 ---
 
 (Updated June 22, 2012, 6:17 a.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 This fixes the minimum size of the following applets: showdashboard, 
 systemloadviewer, pastebin, weatherstation and timer.
 Some sizes were to small, so there were visual glitches and some applets had 
 no minimum value set.
 
 I have no commit rights.
 
 
 Diffs
 -
 
   applets/pastebin/pastebin.cpp 208e6a3 
   applets/showdashboard/showdashboard.h 695347f 
   applets/showdashboard/showdashboard.cpp 1c2f623 
   applets/systemloadviewer/systemloadviewer.cpp b852256 
   applets/timer/timer.cpp ba5ee66 
   applets/weatherstation/weatherstation.h 6d4ae24 
   applets/weatherstation/weatherstation.cpp 8ada9c2 
 
 Diff: http://git.reviewboard.kde.org/r/105234/diff/
 
 
 Testing
 ---
 
 Run the applets with their new minimum size, and minimized.
 
 
 Thanks,
 
 Maarten De Meyer
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Use common plasma components Tooltip in battery monitor

2012-06-28 Thread Aaron J. Seigo


 On June 18, 2012, 3:37 p.m., Viranch Mehta wrote:
  The button size and the hover appearance is different from the original 
  one. The IconButton component was made to keep the look of the buttons 
  consistent with the original version of the applet. Do we want to change 
  this?
 
 David Edmundson wrote:
 Valid argument for now, won't be valid when everything moves to 
 QML/Plasma Components.
 
 You're maintainer, you have final say.
 If you want me to wait till 4.10 when more applets are QML based I will 
 do.
 
 Viranch Mehta wrote:
 Well after a second thought, I think its a better idea to use plasma 
 components for consistency over plasma rather than maintaining consistency 
 with previous versions. but the original button for some reason looks 
 *really* better in visual terms to me (in fact, the button is also used in 
 some other plasmoids including the network manager). so...
 
 to plasma components dev: can we have an option in the button of what 
 background svg is used? may be a switch between the current one and the one 
 in this plasmoid (widgets/viewitem)?
 
 if that may take time to come up, or is not desired, we can have this 
 patch shipped right in!
 
 Viranch Mehta wrote:
 david, please ship this patch for now. thanks!

i don't think we want to allow defining which SVG is used, but it could make 
sense to have a property that can be set to adjust the look based on where/how 
the button is used.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105283/#review14839
---


On June 17, 2012, 7:52 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105283/
 ---
 
 (Updated June 17, 2012, 7:52 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 Current battery monitor implements it's own Button class, this previously 
 broke styles with theme text and overloads icon sizes and such.
 
 It's bad for applets to implement their own version of common classes as it 
 prevents consistency.
 
 (will fix the whitespace addition before commit)
 
 
 Diffs
 -
 
   plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml d4454c6 
   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a 
 
 Diff: http://git.reviewboard.kde.org/r/105283/diff/
 
 
 Testing
 ---
 
 Checked applet looked ok.
 
 
 Thanks,
 
 David Edmundson
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: DBus-interface for changing wallpapers

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15226
---



plasma/desktop/shell/plasmaapp.cpp
http://git.reviewboard.kde.org/r/105319/#comment11903

i would prefer it if the plugin name and mode were not exposed. the use 
case is setting a wallpaper image so let's implement that. 

the main problem with being able to set the name and mode is that not only 
are most of the plugins optional (just asking for fun breakage) but also 
require configuration.

so i would recommend a rather simpler setWallpaperImage(const QString url).

it should probably do similar to what the drag and drop support does and if 
the url is not local then try to fetch it using KIO.



plasma/desktop/shell/plasmaapp.cpp
http://git.reviewboard.kde.org/r/105319/#comment11905

this will fail for per-virtual-desktop-containments. you need to also pass 
in the current desktop (KWindowSystem has a method for getting that)



plasma/desktop/shell/plasmaapp.cpp
http://git.reviewboard.kde.org/r/105319/#comment11904

must check that currentContainment is not null. containmentForScreen 
returns null on failure.



- Aaron J. Seigo


On June 24, 2012, 3:47 p.m., Varun Herale wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105319/
 ---
 
 (Updated June 24, 2012, 3:47 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 This patch is for hosting a dbus-interface that can be used to load any 
 installed wallpaper plugin onto current desktop containment. In case of 
 default image plugin, the path to the image can also be sent which will 
 change the wallpaper.  
 
 
 Diffs
 -
 
   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
   plasma/desktop/shell/plasmaapp.h 6ae0c89 
   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
 
 Diff: http://git.reviewboard.kde.org/r/105319/diff/
 
 
 Testing
 ---
 
 Tested on different activities and made sure it works for per-virtual desktop 
 containment.
 
 Haven't tested on a system with multiple screens though, as I don't have 
 access to one. Could someone please test for that ?
 
 
 Thanks,
 
 Varun Herale
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: ksysguard.deskstop shoud not use generic name System Monitor for its Name key

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105338/#review15227
---

Ship it!


Ship It!

- Aaron J. Seigo


On June 24, 2012, 7:39 a.m., Jekyll Wu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105338/
 ---
 
 (Updated June 24, 2012, 7:39 a.m.)
 
 
 Review request for Plasma and John Tapsell.
 
 
 Description
 ---
 
 Currently, ksysguard.desktop contains Name=System Monitor and 
 GenericName=System Monitor. 
 
 FOD specification[1] writes:
 
 NameSpecific name of the application, for example Mozilla.
 GenericName Generic name of the application, for example Web Browser.
 
 So I think using a generic name like System Monitor for Name is 
 problematic. The current situation of using the same generic name for both 
 Name and GenericName is also questionable.
 
 The patch simply uses KSysGuard for the Name key . 
 
 [1] 
 http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
 
 
 Diffs
 -
 
   ksysguard/gui/ksysguard.desktop 7e8ff32 
 
 Diff: http://git.reviewboard.kde.org/r/105338/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jekyll Wu
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105340/#review15228
---


for the activity manager this can make sense since interaction with the desktop 
is not particularly important.

but this behaviour is intentional for the add widget interface since moving 
things around on the desktop while it is shown is common. so this should not 
happen when the window is showing the widget explorer.

- Aaron J. Seigo


On June 26, 2012, 12:29 p.m., Reza Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105340/
 ---
 
 (Updated June 26, 2012, 12:29 p.m.)
 
 
 Review request for Plasma and Marco Martin.
 
 
 Description
 ---
 
 There is a bug which prevent widget explorer or activity manager not closed 
 when clicking desktop area above panel.
 
 Steps to reproduce:
 - after login and with no window appear (we can see desktop area clearly).
 - open widget explorer from panel
 - then click at desktop area somewhere above the panel.
 
 The expected result is widget explorer or activity manager will be closed.
 
 
 Diffs
 -
 
   plasma/desktop/shell/controllerwindow.cpp 306a152 
 
 Diff: http://git.reviewboard.kde.org/r/105340/diff/
 
 
 Testing
 ---
 
 test against master branch.
 
 
 Thanks,
 
 Reza Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: make content margin of widget explorer similar to activity manager

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105361/#review15229
---

Ship it!


Ship It!

- Aaron J. Seigo


On June 26, 2012, 1:53 p.m., Reza Shah wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105361/
 ---
 
 (Updated June 26, 2012, 1:53 p.m.)
 
 
 Review request for Plasma and Marco Martin.
 
 
 Description
 ---
 
 This patch changes content margins of widget explorer similar to activity 
 manager, which is has better layout in my opinion.
 I attached the screenshot for comparison between previous,after and reference.
 
 
 Diffs
 -
 
   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 06f0766 
 
 Diff: http://git.reviewboard.kde.org/r/105361/diff/
 
 
 Testing
 ---
 
 tested against master
 
 
 Screenshots
 ---
 
 before-after
   http://git.reviewboard.kde.org/r/105361/s/612/
 
 
 Thanks,
 
 Reza Shah
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: change default config of taskmanager

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---


Items= is no longer used. individual entries are. so this review is not correct.

the prefered items are also indeed removable. that was fixed a while back.

are you using kde-workspace from master or some older branch or...?

- Aaron J. Seigo


On June 28, 2012, 3:48 p.m., Greg T wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105374/
 ---
 
 (Updated June 28, 2012, 3:48 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 libtaskmanager can't remove those (browser, preferred://browser, , , ) 
 entrys, so I moved them to the Items list. I don't know why they were 
 separated in the first place. That's why I'm opening this review request.
 
 
 This addresses bug 278724.
 http://bugs.kde.org/show_bug.cgi?id=278724
 
 
 Diffs
 -
 
   
 plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
  afd1f2c 
 
 Diff: http://git.reviewboard.kde.org/r/105374/diff/
 
 
 Testing
 ---
 
 no regressions noted.
 
 
 Thanks,
 
 Greg T
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
---

Ship it!


Ship It!

- Aaron J. Seigo


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma applets inside QML applet

2012-06-28 Thread Aaron J. Seigo
On Sunday, June 24, 2012 13:11:46 David Edmundson wrote:
 What about the case of the calendar in the digital clock?

the calendar in the clock (and it's the same in all clocks, not just the 
digital clock) is not an applet. the calender applet instantiates the same 
calendar object that the clocks do.

-- 
Aaron Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Aaron J. Seigo
On Thursday, June 28, 2012 08:56:21 Michail V. wrote:
 Is there a way to have windows previews in a qml plasmoid?

the ToolTip QML item (which isn't documented on api.kde.org with the other QML 
elements since it is written in C++ *sigh*) does not expose the requisite 
property in Plasma::ToolTipContent: windowsToPreview.

there are two ways to address this:

* add this functionality to the existing ToolTip element in kde-
runtime/plasma/declarativeimports/core/tooltip.cpp

* include a bit of C++ with the QML task manager applet which exposes this 

the two methods are essentially identical with one important difference: 
patching the tooltip.cpp in kde-runtime exposes this to *all* users of the QML 
elements ... and i don't think we want to do that as we could not take that 
API back later and this is one area that is likely to see some re-design in 
libplasma2.

so including a bit of C++ that bridges between Plasma::ToolTipContent and QML 
which does expose the windowsToPreview API would probably be best. you could 
even start by just copying over those files from kde-runtime and modifying as 
needed.

cheers.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: change default config of taskmanager

2012-06-28 Thread Greg T


 On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote:
  Items= is no longer used. individual entries are. so this review is not 
  correct.
  
  the prefered items are also indeed removable. that was fixed a while back.
  
  are you using kde-workspace from master or some older branch or...?

ah, I see.

Nope, I'm using plain master and that bug is definitely *not* fixed. The 
preferred filemanager and browser icons keep reappaering on login. The function 
GroupManagerPrivate::unsaveLauncher can't remove that config entrys because the 
name of the launcher is i.e. 'firefox' but never 'browser'


- Greg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---


On June 28, 2012, 3:48 p.m., Greg T wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105374/
 ---
 
 (Updated June 28, 2012, 3:48 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 libtaskmanager can't remove those (browser, preferred://browser, , , ) 
 entrys, so I moved them to the Items list. I don't know why they were 
 separated in the first place. That's why I'm opening this review request.
 
 
 This addresses bug 278724.
 http://bugs.kde.org/show_bug.cgi?id=278724
 
 
 Diffs
 -
 
   
 plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
  afd1f2c 
 
 Diff: http://git.reviewboard.kde.org/r/105374/diff/
 
 
 Testing
 ---
 
 no regressions noted.
 
 
 Thanks,
 
 Greg T
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15236
---


This review has been submitted with commit 
a48391afd249c04c559c57e3ff4e461f7b1a3757 by Johannes Tröscher to branch master.

- Commit Hook


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Johannes Tröscher


 On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
  Ship It!

i'm not that experienced with git.. i've pushed it to master, could you 
backport it to 4.9? i don't know how to push single commits


- Johannes


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
---


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Michail Vourlakos

Στις 28/06/2012 08:19 μμ, ο/η Aaron J. Seigo έγραψε:

On Thursday, June 28, 2012 08:56:21 Michail V. wrote:

Is there a way to have windows previews in a qml plasmoid?

the ToolTip QML item (which isn't documented on api.kde.org with the other QML
elements since it is written in C++ *sigh*) does not expose the requisite
property in Plasma::ToolTipContent: windowsToPreview.

there are two ways to address this:

* add this functionality to the existing ToolTip element in kde-
runtime/plasma/declarativeimports/core/tooltip.cpp

* include a bit of C++ with the QML task manager applet which exposes this

the two methods are essentially identical with one important difference:
patching the tooltip.cpp in kde-runtime exposes this to *all* users of the QML
elements ... and i don't think we want to do that as we could not take that
API back later and this is one area that is likely to see some re-design in
libplasma2.

so including a bit of C++ that bridges between Plasma::ToolTipContent and QML
which does expose the windowsToPreview API would probably be best. you could
even start by just copying over those files from kde-runtime and modifying as
needed.

cheers.



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Aaron thanks for the reply,

the plasmoid is already a hybrid one (backend in c++and qml ui) but I 
dont know
if I have the skills to implement this task. I would definitely give it 
a try in the feature.


If I understood correct, you propose to take the QML ToolTip Item c++ 
code in my
plasmoid and change it in order to use the Plasma::ToolTipContent, 
windowsPreview

in a way to use it in QML.

Being honest I have already tried to use QML ToolTip in my plasmoid with 
no success,
I couldnt find any documentation  but I will give it a second try by 
examining the

relevant source code...

cheers.



___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: change default config of taskmanager

2012-06-28 Thread Greg T

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/
---

(Updated June 28, 2012, 7:03 p.m.)


Review request for Plasma.


Changes
---

Entirely new patch...that preferred application stuff feels like a hack.


Description
---

libtaskmanager can't remove those (browser, preferred://browser, , , ) 
entrys, so I moved them to the Items list. I don't know why they were separated 
in the first place. That's why I'm opening this review request.


This addresses bug 278724.
http://bugs.kde.org/show_bug.cgi?id=278724


Diffs (updated)
-

  libs/taskmanager/groupmanager.cpp 5ca0159 

Diff: http://git.reviewboard.kde.org/r/105374/diff/


Testing
---

no regressions noted.


Thanks,

Greg T

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Greg T


 On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
  Ship It!
 
 Johannes Tröscher wrote:
 i'm not that experienced with git.. i've pushed it to master, could you 
 backport it to 4.9? i don't know how to push single commits

I suggest you to use 'git cherry-pick' for that task.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
---


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: use window role to detect the dashboard

2012-06-28 Thread Thomas Lübking

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/
---

Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.


Description
---

see bug. i guess the window role is the natural and more distinct hint.


This addresses bug 302523.
http://bugs.kde.org/show_bug.cgi?id=302523


Diffs
-

  kwin/effects/dashboard/dashboard.cpp bb803a9 
  plasma/desktop/shell/dashboardview.cpp d6762b6 

Diff: http://git.reviewboard.kde.org/r/105382/diff/


Testing
---

yes, dashboard still triggers the effect, renamed xterm no longer


Thanks,

Thomas Lübking

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Marco Martin
On Thursday 28 June 2012, Aaron J. Seigo wrote:
 On Thursday, June 28, 2012 08:56:21 Michail V. wrote:
  Is there a way to have windows previews in a qml plasmoid?
 
 the ToolTip QML item (which isn't documented on api.kde.org with the other
 QML elements since it is written in C++ *sigh*) does not expose the
 requisite property in Plasma::ToolTipContent: windowsToPreview.

those c++ elements do have api docs, what's necessary to make it indexed?

 there are two ways to address this:
 
 * add this functionality to the existing ToolTip element in kde-
 runtime/plasma/declarativeimports/core/tooltip.cpp
 
 * include a bit of C++ with the QML task manager applet which exposes this

i'm for the second, i'm not tooo happy about exposing thumbnails in the import


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/#review15245
---


Nice catch!
I do not have a printer that supports reporting ink levels, so I cannot test 
whether it causes unexpected behavior, but I don’t think so.
Daniel should look over this anyway.
Thanks for the patch! :)

- Kai Uwe Broulik


On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105382/
 ---
 
 (Updated June 28, 2012, 7:42 p.m.)
 
 
 Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
 
 
 Description
 ---
 
 see bug. i guess the window role is the natural and more distinct hint.
 
 
 This addresses bug 302523.
 http://bugs.kde.org/show_bug.cgi?id=302523
 
 
 Diffs
 -
 
   kwin/effects/dashboard/dashboard.cpp bb803a9 
   plasma/desktop/shell/dashboardview.cpp d6762b6 
 
 Diff: http://git.reviewboard.kde.org/r/105382/diff/
 
 
 Testing
 ---
 
 yes, dashboard still triggers the effect, renamed xterm no longer
 
 
 Thanks,
 
 Thomas Lübking
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik


 On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote:
  Nice catch!
  I do not have a printer that supports reporting ink levels, so I cannot 
  test whether it causes unexpected behavior, but I don’t think so.
  Daniel should look over this anyway.
  Thanks for the patch! :)

Sorry, Wrong Review! :D


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/#review15245
---


On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105382/
 ---
 
 (Updated June 28, 2012, 7:42 p.m.)
 
 
 Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
 
 
 Description
 ---
 
 see bug. i guess the window role is the natural and more distinct hint.
 
 
 This addresses bug 302523.
 http://bugs.kde.org/show_bug.cgi?id=302523
 
 
 Diffs
 -
 
   kwin/effects/dashboard/dashboard.cpp bb803a9 
   plasma/desktop/shell/dashboardview.cpp d6762b6 
 
 Diff: http://git.reviewboard.kde.org/r/105382/diff/
 
 
 Testing
 ---
 
 yes, dashboard still triggers the effect, renamed xterm no longer
 
 
 Thanks,
 
 Thomas Lübking
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15248
---


This review has been submitted with commit 
09e3005b190fc1dea8df06a2fee62be7d0b94938 by Johannes Tröscher to branch KDE/4.9.

- Commit Hook


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Johannes Tröscher


 On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
  Ship It!
 
 Johannes Tröscher wrote:
 i'm not that experienced with git.. i've pushed it to master, could you 
 backport it to 4.9? i don't know how to push single commits
 
 Greg T wrote:
 I suggest you to use 'git cherry-pick' for that task.

thanks, submitted


- Johannes


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
---


On June 28, 2012, 3:40 p.m., Johannes Tröscher wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105375/
 ---
 
 (Updated June 28, 2012, 3:40 p.m.)
 
 
 Review request for Plasma and Aaron J. Seigo.
 
 
 Description
 ---
 
 this is mostly visible with dark-themes only.
 as of now the text color got only changed when the hover-element was fully 
 visible. this looked a bit weird.
 this patch adds a ColorAnimation with the same duration as the 
 opacity-animation on the hover-element as Behavior for the Label.
 now the color changes fluently on hovering the ToolButton
 
 
 Diffs
 -
 
   plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 
 
 Diff: http://git.reviewboard.kde.org/r/105375/diff/
 
 
 Testing
 ---
 
 tested, works
 
 
 Thanks,
 
 Johannes Tröscher
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Windows previews in qml plasmoid?

2012-06-28 Thread Martin Gräßlin
On Thursday 28 June 2012 22:14:29 Marco Martin wrote:
  there are two ways to address this:
  
  * add this functionality to the existing ToolTip element in kde-
  runtime/plasma/declarativeimports/core/tooltip.cpp
  
  * include a bit of C++ with the QML task manager applet which exposes this
 
 i'm for the second, i'm not tooo happy about exposing thumbnails in the
 import
I'm against exposing the thumbnails at all. This has severe impact on KWin's 
rendering performance. The taskbar thumbnail effect is designed for the usage 
in the thumbnail were a few assumptions hold, mainly the fact that the window 
is on top of all windows. Adding a plasmoid on the desktop rendering a 
thumbnail could crawl kwin down completely.

So what's actually the use case of Thumbnails is Plasmoids? Remember a 
thumbnail has to be of at least 200x200 pixels to be of use.

Cheers
Martin



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Michail Vourlakos

Στις 29/06/2012 12:25 πμ, ο/η Martin Grδίlin έγραψε:

On Thursday 28 June 2012 22:14:29 Marco Martin wrote:

there are two ways to address this:

* add this functionality to the existing ToolTip element in kde-
runtime/plasma/declarativeimports/core/tooltip.cpp

* include a bit of C++ with the QML task manager applet which exposes this

i'm for the second, i'm not tooo happy about exposing thumbnails in the
import

I'm against exposing the thumbnails at all. This has severe impact on KWin's
rendering performance. The taskbar thumbnail effect is designed for the usage
in the thumbnail were a few assumptions hold, mainly the fact that the window
is on top of all windows. Adding a plasmoid on the desktop rendering a
thumbnail could crawl kwin down completely.

So what's actually the use case of Thumbnails is Plasmoids? Remember a
thumbnail has to be of at least 200x200 pixels to be of use.

Cheers
Martin



The use case exists. It's about the WorkFlow plasmoid in which I am 
facing this issue:

http://opentoolsandspace.org/en/projects/development/plasmoid-workflow

Concerning the focus that the window effect is on top of all
the other windows, an assumption can be made that the plasmoid is going 
to be used
as a popupapplet in a panel or in the dashboard. I also believe that in 
the future
the tasks plasmoid is going to use QML. It may be too early for that 
discussion but

until then the issue is going to exist.

For a start, I would be happy if I could take some screenshots(QPixmaps) 
from

the kwin effect whenever the QML UI needs them. Instead of live preview,
tasks screenshots in every 500ms for example.

Cheers,
Michail


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: Windows previews in qml plasmoid?

2012-06-28 Thread Martin Gräßlin
On Friday 29 June 2012 01:00:06 Michail Vourlakos wrote:
 The use case exists. It's about the WorkFlow plasmoid in which I am
 facing this issue:
 http://opentoolsandspace.org/en/projects/development/plasmoid-workflow
consider using a declarative KWin script. For example have a look at:
https://github.com/ghinda/arctos-dashboard
 For a start, I would be happy if I could take some screenshots(QPixmaps)
 from
 the kwin effect whenever the QML UI needs them. Instead of live preview,
 tasks screenshots in every 500ms for example.
This would be even worse than exposing the thumbnail from a KWin perspective. 
Please do not even think about it :-)

And please give a try to the declarative KWin scripts. We have there a 
thumbnail item and this is properly integrated into the compositor.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Windows previews in qml plasmoid?

2012-06-28 Thread Michail Vourlakos

Στις 29/06/2012 01:16 πμ, ο/η Martin Grδίlin έγραψε:

On Friday 29 June 2012 01:00:06 Michail Vourlakos wrote:

The use case exists. It's about the WorkFlow plasmoid in which I am
facing this issue:
http://opentoolsandspace.org/en/projects/development/plasmoid-workflow

consider using a declarative KWin script. For example have a look at:
https://github.com/ghinda/arctos-dashboard

For a start, I would be happy if I could take some screenshots(QPixmaps)
from
the kwin effect whenever the QML UI needs them. Instead of live preview,
tasks screenshots in every 500ms for example.

This would be even worse than exposing the thumbnail from a KWin perspective.
Please do not even think about it :-)

And please give a try to the declarative KWin scripts. We have there a
thumbnail item and this is properly integrated into the compositor.

Cheers
Martin



Dear Martin,

declarative kwin scripting is more challenging than plasmoids. I am 
almost sure that a hybrid
situation is needed with C++ and QML for the spesific use case(either 
way the plasmoid
supports all the needed functionality right now except the windows 
thumbnails).


I dont know if this is possible with KWIn scripting, is it possible that 
maybe a KWin effect can do this?

(backend in C++ and QML the ui?)
(for example the plasmoid currently uses atoms from Xlib in order to move
a task from activity to activity, I dont think scripting can do this 
right now)


Cheers,
Michail

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where can I define my widget's preference?

2012-06-28 Thread gaoxiang
On Thursday 28 June 2012 12:38:27 Shaun Reich wrote:

Well, what's more important probably, is if this is qml or not. Because that 
changes some things.


Yes, I'm creating a plasma widget with QML___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Where can I define my widget's preference?

2012-06-28 Thread gaoxiang
On Thursday 28 June 2012 17:49:30 gaoxiang wrote:
 I think I'm having trouble with documentions.  These documentations gives
 little information.  I have not find any tutorials or documentations on
 where and how my widget's preference should be defined so I have to ask
 here. Please give some links or hints on how I should do these things.
 After my program finish, I will write something about the help I got to
 enrich our documentations.
 Thanks.

I downloaded the project kdeplasma-addons's source code for a reference and 
created my contents/ui/config.ui now.  But I don't know how to access the value 
of configs througt javascript.  Could anyone give me some help?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: DBus-interface for changing wallpapers

2012-06-28 Thread Varun Herale


 On June 28, 2012, 4:48 p.m., Aaron J. Seigo wrote:
  plasma/desktop/shell/plasmaapp.cpp, line 397
  http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397
 
  i would prefer it if the plugin name and mode were not exposed. the use 
  case is setting a wallpaper image so let's implement that. 
  
  the main problem with being able to set the name and mode is that not 
  only are most of the plugins optional (just asking for fun breakage) but 
  also require configuration.
  
  so i would recommend a rather simpler setWallpaperImage(const QString 
  url).
  
  it should probably do similar to what the drag and drop support does 
  and if the url is not local then try to fetch it using KIO.

Doesn't the Image plugin support fetching url if it is not local ? So it is not 
needed for this function right ?

Also what about exposing the mode also - to be able to change between 
SingleImage and Slideshow mode ? Or should we make this just SingleImage ?


- Varun


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15226
---


On June 24, 2012, 3:47 p.m., Varun Herale wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105319/
 ---
 
 (Updated June 24, 2012, 3:47 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 This patch is for hosting a dbus-interface that can be used to load any 
 installed wallpaper plugin onto current desktop containment. In case of 
 default image plugin, the path to the image can also be sent which will 
 change the wallpaper.  
 
 
 Diffs
 -
 
   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
   plasma/desktop/shell/plasmaapp.h 6ae0c89 
   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
 
 Diff: http://git.reviewboard.kde.org/r/105319/diff/
 
 
 Testing
 ---
 
 Tested on different activities and made sure it works for per-virtual desktop 
 containment.
 
 Haven't tested on a system with multiple screens though, as I don't have 
 access to one. Could someone please test for that ?
 
 
 Thanks,
 
 Varun Herale
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel