[KDE Bugtracking System] REMINDER: current Plasma regressions

2012-07-05 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Plasma

  This search was scheduled by myr...@kde.org.


Plasma regressions
--
Bug 291676:
  https://bugs.kde.org/show_bug.cgi?id=291676
  Priority: NOR  Severity: normal  Platform: Gentoo Packages
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Device Items resize on hover due to visibility change of the status 
text
Bug 300885:
  https://bugs.kde.org/show_bug.cgi?id=300885
  Priority: NOR  Severity: critical  Platform: Ubuntu Packages
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Weather widget does not work anymore with bbcuk or wetter.com 
provider
Bug 301424:
  https://bugs.kde.org/show_bug.cgi?id=301424
  Priority: NOR  Severity: normal  Platform: openSUSE RPMs
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Cannot open battery monitor applet if set to hidden in systray
Bug 301533:
  https://bugs.kde.org/show_bug.cgi?id=301533
  Priority: NOR  Severity: normal  Platform: Other
  Assignee: plasma-b...@kde.org
Status: NEW
   Summary: Option Show Multiple Batteries does nothing
Bug 302331:
  https://bugs.kde.org/show_bug.cgi?id=302331
  Priority: NOR  Severity: normal  Platform: Ubuntu Packages
  Assignee: ignat.seme...@blue-systems.com
Status: UNCONFIRMED
   Summary: [post 4.9beta2] Folderview does not show any to activity linked 
files


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-05 Thread Andriy Gapon

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105432/
---

(Updated July 5, 2012, 6:44 a.m.)


Review request for Plasma and Solid.


Changes
---

Add a snippet of `solid-hardware list details` output that hopefully 
demonstrates the problem better than my original verbiage.


Description
---

Currently the code in SolidDeviceEngine::populateDeviceData sets volume's 
Removable property in straightforward fashion:
- tries to cast volume's (immediate) parent device to Solid::StorageDrive
- if that succeeds, checks isHotpluggable() and isRemovable() properties of the 
parent
The problem is that there could be intermediate devices in solid device 
hierarchy between the volume and its Solid::StorageDrive ancestor, for example 
partition-type devices.

The proposed code walks up the hierarchy to try harder to find 
Solid::StorageDrive ancestor of a given device.

BTW, I think that getAncestorOfType() helper function introduced in the 
proposed change can be useful for other code too, so it might make sense to 
nominate it for inclusion into Solid API.


Diffs
-

  plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 608da25 

Diff: http://git.reviewboard.kde.org/r/105432/diff/


Testing
---


Thanks,

Andriy Gapon

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-05 Thread Andriy Gapon


 On July 4, 2012, 10:19 p.m., Alex Fiestas wrote:
  The patch may make sense but, what does it fix exactly?

Detection of my USB stick when used with FreeBSD as removable media.


- Andriy


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105432/#review15388
---


On July 5, 2012, 6:44 a.m., Andriy Gapon wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105432/
 ---
 
 (Updated July 5, 2012, 6:44 a.m.)
 
 
 Review request for Plasma and Solid.
 
 
 Description
 ---
 
 Currently the code in SolidDeviceEngine::populateDeviceData sets volume's 
 Removable property in straightforward fashion:
 - tries to cast volume's (immediate) parent device to Solid::StorageDrive
 - if that succeeds, checks isHotpluggable() and isRemovable() properties of 
 the parent
 The problem is that there could be intermediate devices in solid device 
 hierarchy between the volume and its Solid::StorageDrive ancestor, for 
 example partition-type devices.
 
 The proposed code walks up the hierarchy to try harder to find 
 Solid::StorageDrive ancestor of a given device.
 
 BTW, I think that getAncestorOfType() helper function introduced in the 
 proposed change can be useful for other code too, so it might make sense to 
 nominate it for inclusion into Solid API.
 
 
 Diffs
 -
 
   plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 608da25 
 
 Diff: http://git.reviewboard.kde.org/r/105432/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Andriy Gapon
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Pop-up dialog of embedded applets

2012-07-05 Thread Dmitry

03.07.2012 16:44, Dmitry ?:

Hello, Marco!

I'm implementing system tray in QML. I've found a solution how to 
place embedded applet into pop-up window of tray. But there is one 
difference between my system tray [in QML] and your current system 
tray [in pure C++]. If some embedded applet is placed in pop-up window 
of system tray (pop-up part of the tray) and user clicks on it 
[embedded applet] then the pop-up dialog of embedded applet will arise 
at the cursor coordinates and either it looks like separated window or 
it overlaps the panel. It looks weird. If user clicks on an applet 
embedded in pop-up window of current C++ system tray then pop-up 
window of the embedded applet arises docked to the panel and never 
overlap it. Do You know what is a reason of such strange behaviour?


Thank you!



Hello!

It seems that PopupApplet uses global coordinates to place popup dialog. 
If applet is located outside of a panel then its popup dialog won't be 
docked to the panel (will be shown like a separate window). I think the 
current system tray in C++ doesn't have such problem because an order of 
actions is next:


1. User clicks on embedded applet
2. Embedded applet changes its status
3. Previous action causes system tray in C++ to move embedded applet
   from popup dialog to panel part
4. Embedded applet shows its pop-up window docked to panel because it
   is located in panel.

So, I've found next solution to described problem:

 * First of all, I handle mouse click event.  If user clicks on
   embedded applet then I check if this applet is a pop-up applet like
   this:

   Plasma::PopupApplet *popup = qobject_castPlasma::PopupApplet*(applet)
   if (popup) { /* Applet is a pop-up applet */}

 * Next I hide applet to disable its redrawing:

   popup-hide();

 * Reparent popup. It becomes located in panel:

   popup-setParentItem(panel); // panel is a panel part of system tray

 * Show pop-up of embedded applet:

   popup-showPopup();

I think that this way isn't good, but it is only one way I have found to 
solve the problem. What do you think about solution? Maybe do you have 
another ideas?


Thank you.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Fix position of widget explorer tooltip

2012-07-05 Thread Aurélien Gâteau

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105447/
---

Review request for Plasma, KDE Usability and Marco Martin.


Description
---

When the widget explorer is oriented vertically, applet tooltips shows on top 
of other applets instead of showing on the right or on the left. This patch 
fixes it in a not-too intrusive way (original patch affected kdelibs and 
kde-runtime as well). If possible I would like this bug to be applied to the 
KDE/4.9 branch as well.


Diffs
-

  libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml cc84e6c 
  libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h 31308d2 
  libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 9b19f88 

Diff: http://git.reviewboard.kde.org/r/105447/diff/


Testing
---

Tested with panels on all edges.


Screenshots
---

before-after
  http://git.reviewboard.kde.org/r/105447/s/616/


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix position of widget explorer tooltip

2012-07-05 Thread Aurélien Gâteau

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105447/
---

(Updated July 5, 2012, 9:05 a.m.)


Review request for Plasma, KDE Usability and Marco Martin.


Description (updated)
---

When the widget explorer is oriented vertically, applet tooltips shows on top 
of other applets instead of showing on the right or on the left. This patch 
fixes it in a not-too intrusive way (original patch affected kdelibs and 
kde-runtime as well). If possible I would like this patch to be applied to the 
KDE/4.9 branch as well.


Diffs
-

  libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml cc84e6c 
  libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h 31308d2 
  libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 9b19f88 

Diff: http://git.reviewboard.kde.org/r/105447/diff/


Testing
---

Tested with panels on all edges.


Screenshots
---

before-after
  http://git.reviewboard.kde.org/r/105447/s/616/


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix position of widget explorer tooltip

2012-07-05 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105447/#review15421
---

Ship it!


yes, i think right now is the least painful way to have it right.

the code is ok.
 what we have to remember is for plasma2 we may want to not have to do that 
again, so api in libplasma may heve to be retought.

but +1 for doing this way for now

- Marco Martin


On July 5, 2012, 9:05 a.m., Aurélien Gâteau wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105447/
 ---
 
 (Updated July 5, 2012, 9:05 a.m.)
 
 
 Review request for Plasma, KDE Usability and Marco Martin.
 
 
 Description
 ---
 
 When the widget explorer is oriented vertically, applet tooltips shows on top 
 of other applets instead of showing on the right or on the left. This patch 
 fixes it in a not-too intrusive way (original patch affected kdelibs and 
 kde-runtime as well). If possible I would like this patch to be applied to 
 the KDE/4.9 branch as well.
 
 
 Diffs
 -
 
   libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml 
 cc84e6c 
   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.h 31308d2 
   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 9b19f88 
 
 Diff: http://git.reviewboard.kde.org/r/105447/diff/
 
 
 Testing
 ---
 
 Tested with panels on all edges.
 
 
 Screenshots
 ---
 
 before-after
   http://git.reviewboard.kde.org/r/105447/s/616/
 
 
 Thanks,
 
 Aurélien Gâteau
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: use window role to detect the dashboard

2012-07-05 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/#review15436
---


This review has been submitted with commit 
ee14781eefc60a2584636742a6bb843a3a8625d8 by Thomas Lübking to branch KDE/4.9.

- Commit Hook


On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105382/
 ---
 
 (Updated June 28, 2012, 7:42 p.m.)
 
 
 Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
 
 
 Description
 ---
 
 see bug. i guess the window role is the natural and more distinct hint.
 
 
 This addresses bug 302523.
 http://bugs.kde.org/show_bug.cgi?id=302523
 
 
 Diffs
 -
 
   kwin/effects/dashboard/dashboard.cpp bb803a9 
   plasma/desktop/shell/dashboardview.cpp d6762b6 
 
 Diff: http://git.reviewboard.kde.org/r/105382/diff/
 
 
 Testing
 ---
 
 yes, dashboard still triggers the effect, renamed xterm no longer
 
 
 Thanks,
 
 Thomas Lübking
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel