[KDE Bugtracking System] REMINDER: current Plasma regressions
Please find below a list of the current regressions reported for Plasma This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 291676: https://bugs.kde.org/show_bug.cgi?id=291676 Priority: NOR Severity: normal Platform: Gentoo Packages Assignee: plasma-b...@kde.org Status: NEW Summary: Device Items resize on hover due to visibility change of the status text Bug 301424: https://bugs.kde.org/show_bug.cgi?id=301424 Priority: NOR Severity: normal Platform: openSUSE RPMs Assignee: plasma-b...@kde.org Status: NEW Summary: Cannot open battery monitor applet if set to hidden in systray Bug 301533: https://bugs.kde.org/show_bug.cgi?id=301533 Priority: NOR Severity: normal Platform: Other Assignee: plasma-b...@kde.org Status: NEW Summary: Option Show Multiple Batteries does nothing ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
PlasmaCore.ToolTip
Hello! Does PlasmaCore.ToolTip support icons specified as QIcon (not by name of icon) ? Thank you! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PlasmaCore.ToolTip
On Monday 30 July 2012, Dmitry wrote: Hello! Does PlasmaCore.ToolTip support icons specified as QIcon (not by name of icon) ? Thank you! no, at the moment only icon name. i guess is to support both types of systray icons? it should be possible to change it to a variant making it accept multiple data types in 4.10 maintaining compatibility Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PlasmaCore.ToolTip
30.07.2012 13:33, Marco Martin пишет: On Monday 30 July 2012, Dmitry wrote: Hello! Does PlasmaCore.ToolTip support icons specified as QIcon (not by name of icon) ? Thank you! no, at the moment only icon name. i guess is to support both types of systray icons? it should be possible to change it to a variant making it accept multiple data types in 4.10 maintaining compatibility Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel At the moment I know workaround for this problem. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
Dnia niedziela, 29 lipca 2012 o 17:05:24 Kevin Krammer napisał(a): On Saturday, 2012-07-28, Michał 'rysiek' Woźniak wrote: I get: The module 'org.kde' is not installed Any hints? Not being able to save the tasks between Plasma sessions is a bit of a dealbreaker for a ToDo plasmoid... ;) I think some of those are part of the kdeqmlplugin which is part of kdepim- runtime. Maybe it wasn't built or installed properly. Apparently, I would need to have 4.8 installed here, I only have 4.7. For now implemented saving task status to config with a nasty JSON.stringify() call. It works and it's not even that costly, performance-wise. Anyway, the Tasker aka Perfect ToDo-oid is now published and online, comments and suggestions welcome: http://kde-look.org/content/show.php?content=152988 Thanks for all your help. -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Nepomuk2 port of Kactivities
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105790/ --- Review request for Plasma and Ivan Čukić. Description --- this is the diff from master of the branch mart/nepomuk2 in kactivities (the branch has a more comprehensible history of changes ;). it ports all the nepomuk usage to nepomuk2 Diffs - src/service/CMakeLists.txt f6d7f9c src/service/NepomukActivityManager.h ba6e75b src/service/NepomukActivityManager.cpp e06ded3 src/service/jobs/nepomuk/Move.h 23db0b7 src/service/jobs/nepomuk/Move.cpp 8342aef src/service/plugins/sqlite/CMakeLists.txt 1664630 src/service/plugins/sqlite/NepomukCommon.h c3ecacf src/workspace/CMakeLists.txt 2fcd194 src/workspace/kio/CMakeLists.txt 7dfb50c src/workspace/kio/kio_activities.cpp 8ef1f7b Diff: http://git.reviewboard.kde.org/r/105790/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Nepomuk2 port of Kactivities
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105790/#review16639 --- src/service/NepomukActivityManager.h http://git.reviewboard.kde.org/r/105790/#comment12981 This is the only probable potential problem: should it still have a retrocompatibility method returning a Nepomuk::Resource? - Marco Martin On July 30, 2012, 12:02 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105790/ --- (Updated July 30, 2012, 12:02 p.m.) Review request for Plasma and Ivan Čukić. Description --- this is the diff from master of the branch mart/nepomuk2 in kactivities (the branch has a more comprehensible history of changes ;). it ports all the nepomuk usage to nepomuk2 Diffs - src/service/CMakeLists.txt f6d7f9c src/service/NepomukActivityManager.h ba6e75b src/service/NepomukActivityManager.cpp e06ded3 src/service/jobs/nepomuk/Move.h 23db0b7 src/service/jobs/nepomuk/Move.cpp 8342aef src/service/plugins/sqlite/CMakeLists.txt 1664630 src/service/plugins/sqlite/NepomukCommon.h c3ecacf src/workspace/CMakeLists.txt 2fcd194 src/workspace/kio/CMakeLists.txt 7dfb50c src/workspace/kio/kio_activities.cpp 8ef1f7b Diff: http://git.reviewboard.kde.org/r/105790/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
On Monday, 2012-07-30, Michał 'rysiek' Woźniak wrote: Dnia niedziela, 29 lipca 2012 o 17:05:24 Kevin Krammer napisał(a): On Saturday, 2012-07-28, Michał 'rysiek' Woźniak wrote: I get: The module 'org.kde' is not installed Any hints? Not being able to save the tasks between Plasma sessions is a bit of a dealbreaker for a ToDo plasmoid... ;) I think some of those are part of the kdeqmlplugin which is part of kdepim- runtime. Maybe it wasn't built or installed properly. Apparently, I would need to have 4.8 installed here, I only have 4.7. This is strange, the directory was added in April 2010, so it should even be part of kdepim-runtime 4.6 More interestingly I have it in my install from source prefix but not in the one from packages (4.8) so it could be a packaging problem. Could be the same for you, maybe contact the distributor's KDE team. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
On Monday, 2012-07-30, Kevin Krammer wrote: On Monday, 2012-07-30, Michał 'rysiek' Woźniak wrote: Dnia niedziela, 29 lipca 2012 o 17:05:24 Kevin Krammer napisał(a): On Saturday, 2012-07-28, Michał 'rysiek' Woźniak wrote: I get: The module 'org.kde' is not installed Any hints? Not being able to save the tasks between Plasma sessions is a bit of a dealbreaker for a ToDo plasmoid... ;) I think some of those are part of the kdeqmlplugin which is part of kdepim- runtime. Maybe it wasn't built or installed properly. Apparently, I would need to have 4.8 installed here, I only have 4.7. This is strange, the directory was added in April 2010, so it should even be part of kdepim-runtime 4.6 More interestingly I have it in my install from source prefix but not in the one from packages (4.8) so it could be a packaging problem. Actually I was wrong on this one, I have kdepim-runtime 4.4 (Debian/Unstable), so it can't have that plugin yet. Could be the same for you, maybe contact the distributor's KDE team. Unless you are also on Debian this still stands though. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Files, config, and welcome (again)
Dnia poniedziałek, 30 lipca 2012 o 14:49:03 Kevin Krammer napisał(a): On Monday, 2012-07-30, Kevin Krammer wrote: On Monday, 2012-07-30, Michał 'rysiek' Woźniak wrote: Dnia niedziela, 29 lipca 2012 o 17:05:24 Kevin Krammer napisał(a): On Saturday, 2012-07-28, Michał 'rysiek' Woźniak wrote: I get: The module 'org.kde' is not installed Any hints? Not being able to save the tasks between Plasma sessions is a bit of a dealbreaker for a ToDo plasmoid... ;) I think some of those are part of the kdeqmlplugin which is part of kdepim- runtime. Maybe it wasn't built or installed properly. Apparently, I would need to have 4.8 installed here, I only have 4.7. This is strange, the directory was added in April 2010, so it should even be part of kdepim-runtime 4.6 More interestingly I have it in my install from source prefix but not in the one from packages (4.8) so it could be a packaging problem. Actually I was wrong on this one, I have kdepim-runtime 4.4 (Debian/Unstable), so it can't have that plugin yet. Could be the same for you, maybe contact the distributor's KDE team. Unless you are also on Debian this still stands though. Yes, Debian Unstable (or, to be precise, Aptosid). I would also love any comments on the plasmoid itself, if you had a chance of testing it. -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Nepomuk runner forward all the nie:urls
On July 27, 2012, 11:46 a.m., Torgny Nyblom wrote: My vote is for ship it but it is Albert who is doing the release and he is away for a few days more. Perhaps better wait for him. Albert Astals Cid wrote: To be honest this looks like a long running bug (reported during 4.8 beta 1?), so i don't see why it's critical to get it in, though i'm open to explanations of why we really need to include it. I thought the tarballs had not been spun. Since they have been spun, we can ignore this. It can go in 4.9.1. - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/#review16520 --- On July 26, 2012, 5:25 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/ --- (Updated July 26, 2012, 5:25 p.m.) Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg. Description --- Not just the ones that are local files. This fixes opening of emails, and other akonadi resources directly from the runner. @Release Team: It would be nice to have in 4.9 :) This addresses bug 287470. http://bugs.kde.org/show_bug.cgi?id=287470 Diffs - plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d Diff: http://git.reviewboard.kde.org/r/105738/diff/ Testing --- Yup. Emails open up with KMail. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Nepomuk runner forward all the nie:urls
On July 27, 2012, 11:46 a.m., Torgny Nyblom wrote: My vote is for ship it but it is Albert who is doing the release and he is away for a few days more. Perhaps better wait for him. To be honest this looks like a long running bug (reported during 4.8 beta 1?), so i don't see why it's critical to get it in, though i'm open to explanations of why we really need to include it. - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/#review16520 --- On July 26, 2012, 5:25 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/ --- (Updated July 26, 2012, 5:25 p.m.) Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg. Description --- Not just the ones that are local files. This fixes opening of emails, and other akonadi resources directly from the runner. @Release Team: It would be nice to have in 4.9 :) This addresses bug 287470. http://bugs.kde.org/show_bug.cgi?id=287470 Diffs - plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d Diff: http://git.reviewboard.kde.org/r/105738/diff/ Testing --- Yup. Emails open up with KMail. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make the Nepomuk runner forward all the nie:urls
On July 27, 2012, 11:46 a.m., Torgny Nyblom wrote: My vote is for ship it but it is Albert who is doing the release and he is away for a few days more. Perhaps better wait for him. Albert Astals Cid wrote: To be honest this looks like a long running bug (reported during 4.8 beta 1?), so i don't see why it's critical to get it in, though i'm open to explanations of why we really need to include it. Vishesh Handa wrote: I thought the tarballs had not been spun. Since they have been spun, we can ignore this. It can go in 4.9.1. Awesome, let's do the same than with the other request (close to get it off the queue and commit on wednesday after the release) - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/#review16520 --- On July 26, 2012, 5:25 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105738/ --- (Updated July 26, 2012, 5:25 p.m.) Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg. Description --- Not just the ones that are local files. This fixes opening of emails, and other akonadi resources directly from the runner. @Release Team: It would be nice to have in 4.9 :) This addresses bug 287470. http://bugs.kde.org/show_bug.cgi?id=287470 Diffs - plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d Diff: http://git.reviewboard.kde.org/r/105738/diff/ Testing --- Yup. Emails open up with KMail. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
PlasmaComponents ScrollBar is broken
Hi, I've been trying to get two applications to work properly that use the PlasmaComponents: the QuickChat plasmoid (ktp-text-ui) and muon discover. On both of them I've had big problems while using Flickable elements programatically (that is, playing with the contentY property) while having a scrollbar. Note that the test case attached works without a scrollbar, but with the scrollbar it starts to do weird stuff. I've been looking through the code, and to me it seems like the RangeModel is messing the whole implementations. There are two important properties there value and position. And changing any of those make the other change so we enter quite some big loops of changes that are a bit annoying. I've been thinking of rewriting the ScrollBar without this RangeModel, but maybe that's only because I don't understand it enough. Can anybody look into this and give me a hand? I think it would be really interesting to sort this one out! Aleix testcase.qml Description: Binary data ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PlasmaComponents ScrollBar is broken
On Monday 30 July 2012, Aleix Pol wrote: Hi, I've been trying to get two applications to work properly that use the PlasmaComponents: the QuickChat plasmoid (ktp-text-ui) and muon discover. On both of them I've had big problems while using Flickable elements programatically (that is, playing with the contentY property) while having a scrollbar. Note that the test case attached works without a scrollbar, but with the scrollbar it starts to do weird stuff. I've been looking through the code, and to me it seems like the RangeModel is messing the whole implementations. There are two important properties there value and position. And changing any of those make the other change so we enter quite some big loops of changes that are a bit annoying. I've been thinking of rewriting the ScrollBar without this RangeModel, but maybe that's only because I don't understand it enough. Can anybody look into this and give me a hand? I think it would be really interesting to sort this one out! Aleix yep, i see the binding loops, i can look into it. (daker, are you still there? ;) are you experiencing also problems in the behavior? the testcase seems to behave fine here -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PlasmaComponents ScrollBar is broken
Hi Aleix, I'll take a look a creafull look this night. Cheers, Daker Fernandes Pinheiro 2012/7/30 Marco Martin notm...@gmail.com On Monday 30 July 2012, Aleix Pol wrote: Hi, I've been trying to get two applications to work properly that use the PlasmaComponents: the QuickChat plasmoid (ktp-text-ui) and muon discover. On both of them I've had big problems while using Flickable elements programatically (that is, playing with the contentY property) while having a scrollbar. Note that the test case attached works without a scrollbar, but with the scrollbar it starts to do weird stuff. I've been looking through the code, and to me it seems like the RangeModel is messing the whole implementations. There are two important properties there value and position. And changing any of those make the other change so we enter quite some big loops of changes that are a bit annoying. I've been thinking of rewriting the ScrollBar without this RangeModel, but maybe that's only because I don't understand it enough. Can anybody look into this and give me a hand? I think it would be really interesting to sort this one out! Aleix yep, i see the binding loops, i can look into it. (daker, are you still there? ;) are you experiencing also problems in the behavior? the testcase seems to behave fine here -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
LinuxCon Barcelona
Hi all, Albert just mentioned me https://events.linuxfoundation.org/events/linuxcon-europe/cfp deadline of cfp is midnight 31 lug - 1aug, so very short notice. anybody wanting to give it a try? (maybe ale.* that you are from barcelona? ;) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: LinuxCon Barcelona
On Mon, Jul 30, 2012 at 10:56 PM, Marco Martin notm...@gmail.com wrote: Hi all, Albert just mentioned me https://events.linuxfoundation.org/events/linuxcon-europe/cfp deadline of cfp is midnight 31 lug - 1aug, so very short notice. anybody wanting to give it a try? (maybe ale.* that you are from barcelona? ;) Cheers, Marco Martin ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active Yes, I could do that probably. We already discussed it, but we didn't find an what subject to talk about, I'm unsure where KDE fits in this conference. If somebody has a good idea, please contact us (here or in private) so that we can discuss it ASAP. Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: LinuxCon Barcelona
On Mon, Jul 30, 2012 at 3:19 PM, Aleix Pol aleix...@kde.org wrote: On Mon, Jul 30, 2012 at 10:56 PM, Marco Martin notm...@gmail.com wrote: Hi all, Albert just mentioned me https://events.linuxfoundation.org/events/linuxcon-europe/cfp deadline of cfp is midnight 31 lug - 1aug, so very short notice. anybody wanting to give it a try? (maybe ale.* that you are from barcelona? ;) Cheers, Marco Martin ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active Yes, I could do that probably. We already discussed it, but we didn't find an what subject to talk about, I'm unsure where KDE fits in this conference. If somebody has a good idea, please contact us (here or in private) so that we can discuss it ASAP. Aleix Here's what I sent to LinuxCon USA Also could do some combination of the presentations from Akademy by aseigo, sebas, eva thomas pfeiffer LinuxConPresentation.odt Description: application/vnd.oasis.opendocument.text ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Logout QML dialog theming and Caledonia
Hi Plasma, I've been discussing with Caledonia's [1] designer recently, he has told me that he can't theme that dialog that used to integrate properly, he sent me this screenshot [2]. Does anybody have an idea of what is Caledonia theme missing? It seems like it used to work. It would be interesting if we had ways to ensure that this won't happen: tools to make sure themes are ok, don't break backwards compatibility if it's not extremely necessary. Aleix [1] http://kde-help.org/content/show.php/Caledonia?content=142424 http://ext4.wordpress.com/2012/04/08/disponible-caledonia-1-0-mira-tu-kde-con-otros-ojos/ [2] https://lh3.googleusercontent.com/-1nBvlC03n7g/UBZl92ZW2BI/A4c/T_qjFZmF-_o/s607/KDE+QML+logout.png ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Clean up rtm headers and move private data from Auth and Request classes into private classes.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105734/ --- (Updated July 31, 2012, 4:16 a.m.) Review request for Plasma and Andrew Stromme. Changes --- Now I've moved the KWebView out of the rtm library and into the applet config dialog where I believe it belongs. Let me know if you disagree, or if I've done something here I should/could have done in a better way. Description --- rtm: Move Request private data into RequestPrivate class in .cpp file. rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h and request.h files. rtm: Clean up rtm header files. Add #include rtm/task.h since we use Task * (and session.h has been cleaned up). Diffs (updated) - applets/rememberthemilk/CMakeLists.txt 18424ead610b78710fa896a4ea3986fcd7e2f364 applets/rememberthemilk/authenticate.ui cf7b9330d6d8f834225878f24eeb9be90651dbef applets/rememberthemilk/rememberthemilk-plasmoid.h cf02fbad4ab3e46d051d26b2de55c2ff01fb00b8 applets/rememberthemilk/rememberthemilk-plasmoid.cpp 3413e59c69c079480efb2ba37e63927ad45df56e dataengines/rememberthemilk/authservice.h 31f44284422ea4ffdcc7631b5b321a1785480cdb dataengines/rememberthemilk/authservice.cpp c75e6cb6414920871358982aa226b3cbab1ca02f dataengines/rememberthemilk/rtmauth.operations 155a8ae6bdfde4d4fa1056ba0cc750ea6b9214e1 dataengines/rememberthemilk/taskservice.cpp d738093ffd7c5183cf24f9f932d0c7f934b6634b libs/rtm/CMakeLists.txt 58ab4939812bbce07068a6da8c1a1194f6377595 libs/rtm/auth.h 5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1 libs/rtm/auth.cpp 16fd5f0c28004dcc12140556e8d6727c483c2ed9 libs/rtm/note.h af4cfd20c6ddaf1a4943f76f148c79918b5ec633 libs/rtm/request.h d371714c144bf9bc6c7304a861840334f0846cdb libs/rtm/request.cpp 1304cb5d1a547d08b7f82e44cd319097991c8425 libs/rtm/rtm.h 1a542f6007c63df13b79dd60da0cfcfe294f8e16 libs/rtm/session.h aad145c44c70fb28fe1496b93d991667e918f630 libs/rtm/session.cpp 051838f58c8f7a6b6aea9511f1d455197fafb08b libs/rtm/xmlreaders.h b9ea78ca567e32aceb70361a2735b7b005d15777 Diff: http://git.reviewboard.kde.org/r/105734/diff/ Testing --- It builds and runs ok here (the rtm applet logs in and loads data ok). Thanks, Jeremy Paul Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Clean up rtm headers and move private data from Auth and Request classes into private classes.
On July 26, 2012, 2:44 p.m., Andrew Stromme wrote: libs/rtm/auth.h, line 40 http://git.reviewboard.kde.org/r/105734/diff/1/?file=74814#file74814line40 Is there a reason why Auth is no longer exported with RTM_EXPORT? I figured nobody outside session used Auth, but maybe I'm wrong. I took it off of Request also, but it probably is needed on at least Request, since Request objects are returned by session::request() method. - Jeremy Paul --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105734/#review16486 --- On July 31, 2012, 4:16 a.m., Jeremy Paul Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105734/ --- (Updated July 31, 2012, 4:16 a.m.) Review request for Plasma and Andrew Stromme. Description --- rtm: Move Request private data into RequestPrivate class in .cpp file. rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h and request.h files. rtm: Clean up rtm header files. Add #include rtm/task.h since we use Task * (and session.h has been cleaned up). Diffs - applets/rememberthemilk/CMakeLists.txt 18424ead610b78710fa896a4ea3986fcd7e2f364 applets/rememberthemilk/authenticate.ui cf7b9330d6d8f834225878f24eeb9be90651dbef applets/rememberthemilk/rememberthemilk-plasmoid.h cf02fbad4ab3e46d051d26b2de55c2ff01fb00b8 applets/rememberthemilk/rememberthemilk-plasmoid.cpp 3413e59c69c079480efb2ba37e63927ad45df56e dataengines/rememberthemilk/authservice.h 31f44284422ea4ffdcc7631b5b321a1785480cdb dataengines/rememberthemilk/authservice.cpp c75e6cb6414920871358982aa226b3cbab1ca02f dataengines/rememberthemilk/rtmauth.operations 155a8ae6bdfde4d4fa1056ba0cc750ea6b9214e1 dataengines/rememberthemilk/taskservice.cpp d738093ffd7c5183cf24f9f932d0c7f934b6634b libs/rtm/CMakeLists.txt 58ab4939812bbce07068a6da8c1a1194f6377595 libs/rtm/auth.h 5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1 libs/rtm/auth.cpp 16fd5f0c28004dcc12140556e8d6727c483c2ed9 libs/rtm/note.h af4cfd20c6ddaf1a4943f76f148c79918b5ec633 libs/rtm/request.h d371714c144bf9bc6c7304a861840334f0846cdb libs/rtm/request.cpp 1304cb5d1a547d08b7f82e44cd319097991c8425 libs/rtm/rtm.h 1a542f6007c63df13b79dd60da0cfcfe294f8e16 libs/rtm/session.h aad145c44c70fb28fe1496b93d991667e918f630 libs/rtm/session.cpp 051838f58c8f7a6b6aea9511f1d455197fafb08b libs/rtm/xmlreaders.h b9ea78ca567e32aceb70361a2735b7b005d15777 Diff: http://git.reviewboard.kde.org/r/105734/diff/ Testing --- It builds and runs ok here (the rtm applet logs in and loads data ok). Thanks, Jeremy Paul Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
