Review Request: plasma calendar - disable event system config
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- Review request for Plasma and Anne-Marie Mahfouf. Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma calendar - event system config option
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- (Updated Aug. 8, 2012, 7:35 a.m.) Review request for Plasma and Anne-Marie Mahfouf. Summary (updated) - plasma calendar - event system config option Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma calendar - event system config option
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/#review17095 --- Sorry, but I disagree. The separate config settings are for specific technical reasons, due to previous user feedback, and for backwards compatibility purposes. We have two config settings for Events and Holidays due to Events turning on Akonadi which many people don't want to use but still want to have Holidays displayed. Until we have a proper solution to the Akonadi problem we have to retain the separate config options. In any case, the solution would be in modifying the behaviour of the GUI, not in changing the backend config. We used to have separate tick-boxes in the GUI directly mapped to the config options, but I changed the Holidays tick-box to the multiple holidays selection widget and had to retain the backwards compatible behaviour of respecting any existing config setting. You also have the usability issue of people ticking the Holiday options but not the Event box and wondering why the Holidays don't show, you would need to change the GUI to make this obvious. Also, you seem to have other unrelated code fixes included in the review? - John Layt On Aug. 8, 2012, 7:35 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- (Updated Aug. 8, 2012, 7:35 a.m.) Review request for Plasma and Anne-Marie Mahfouf. Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: plasma calendar - event system config option
On Aug. 8, 2012, 8:30 a.m., John Layt wrote: Sorry, but I disagree. The separate config settings are for specific technical reasons, due to previous user feedback, and for backwards compatibility purposes. We have two config settings for Events and Holidays due to Events turning on Akonadi which many people don't want to use but still want to have Holidays displayed. Until we have a proper solution to the Akonadi problem we have to retain the separate config options. In any case, the solution would be in modifying the behaviour of the GUI, not in changing the backend config. We used to have separate tick-boxes in the GUI directly mapped to the config options, but I changed the Holidays tick-box to the multiple holidays selection widget and had to retain the backwards compatible behaviour of respecting any existing config setting. You also have the usability issue of people ticking the Holiday options but not the Event box and wondering why the Holidays don't show, you would need to change the GUI to make this obvious. Also, you seem to have other unrelated code fixes included in the review? Well, of course we could grey out the holiday selection, if display events is unticked. In the current implementation I think it's awkward that you have to scroll through the entire list and disable every region to hide all events. Maybe a extra tick-box for that really would be better. In this case we could also split up the pim event box into options for every kind of event (todos, events, journals). Actually I don't understand why there is this holiday setting in the widget at all. This holiday calender needs to be merged into akonadi, so the widget show exactly the same events like i.e. korganizer. We have already a Birthday akonadi ressource. Why not simply create a holiday ressource? I could do that, I suppose. What dou you think? That unrelated code is from https://git.reviewboard.kde.org/r/105779/ feel free to review it :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/#review17095 --- On Aug. 8, 2012, 7:35 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105924/ --- (Updated Aug. 8, 2012, 7:35 a.m.) Review request for Plasma and Anne-Marie Mahfouf. Description --- This patch addresses an usuability issue. The config option 'display events' enables/disables now all events/holidays. The user doesn't distinguish between them and it must be possible to turn off that feature with just one click. This addresses bug 281464. http://bugs.kde.org/show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Current state of System Monitor
On Tue, Aug 7, 2012 at 12:55 PM, Dmitry dmitry.ashka...@rosalab.ru wrote: 07.08.2012 13:16, Marco Martin пишет: On Tuesday 07 August 2012, Dmitry wrote: Hello! I'm working on my new system monitor applet. I hate current default C++ applet. So, I've decided to implement my simple system monitor in pure QML (no C++ code at all). At the same time I don't know would KDE team include my applet in the future. i would like to replace the current c++ applet(s) however to make a painless transition for users it should look as similar as possible to the current ones (and then make eventual visual modifications a second time) I don't really need graphical visualization of history of values (plotter). Current monitor applet acquires too many space on panel and at the same time it shows current value incorrectly. So, I don't want to replace current system monitor because it is intended to be placed on a desktop and I need more simple monitor applet on panel. I usually don't see my desktop (and never place applets on it) and I think it is better that system monitor applet is placed on panel. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel My advice would be to use the current KDE Plasma ported components [1] in QML. You can find the documentation of each of those bindings in the C++ docs [2] note that you also need to look at the header files to figure out which values are usable in QML (Q_PROPERTY and Q_INVOKABLE) If you need a canvas, make a QML wrapper around the Plasma::SignalPlotter component that implements the same functions as [3]. It's a bit of a hassle and not optimal, but it will make your code ready to port to Qt5 thus makes your life a lot easier + doing that also - likely - allows your plasmoid to be accepted in KDE. (no guarantees!) [1] http://quickgit.kde.org/index.php?p=kde-runtime.gita=blobh=6cc3011319d750cb70c4cb98eb5290bf042c4d78hb=944cbca008962f41c33c994ef320771ec7fed161f=plasma%2Fdeclarativeimports%2Fgraphicswidgets%2Fgraphicswidgetsbindingsplugin.cpp [2] http://api.kde.org/4.8-api/kdelibs-apidocs/plasma/html/namespacePlasma.html [3] http://doc-snapshot.qt-project.org/5.0/qml-qtquick2-context2d.html ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fix calculation of notification timeout
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105858/#review17103 --- Ship it! Oups, good catch! - Aurélien Gâteau On Aug. 4, 2012, 8:33 p.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105858/ --- (Updated Aug. 4, 2012, 8:33 p.m.) Review request for Plasma and Aurélien Gâteau. Description --- In checking the above bug, I found that the calculation of the timeout of a notification has a nice idea implemented, but it does not work due to a bug. The code should create longer timeouts for longer texts, but have at least 5 seconds. Due to using 2000 + qMin(timeout, 3000), the result will be maximum 5 seconds. This patch changes this to qMax so that we really get longer timeouts than 5 seconds. This addresses bug 178411. http://bugs.kde.org/show_bug.cgi?id=178411 Diffs - plasma/generic/dataengines/notifications/notificationsengine.cpp caaca27 Diff: http://git.reviewboard.kde.org/r/105858/diff/ Testing --- notify-send with very long text and debugging output of timeout Thanks, Martin Koller ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fix calculation of notification timeout
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105858/#review17127 --- This review has been submitted with commit 8821ecc876a420a7a4a637e749da809ce8ba39a6 by Martin Koller to branch master. - Commit Hook On Aug. 4, 2012, 8:33 p.m., Martin Koller wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105858/ --- (Updated Aug. 4, 2012, 8:33 p.m.) Review request for Plasma and Aurélien Gâteau. Description --- In checking the above bug, I found that the calculation of the timeout of a notification has a nice idea implemented, but it does not work due to a bug. The code should create longer timeouts for longer texts, but have at least 5 seconds. Due to using 2000 + qMin(timeout, 3000), the result will be maximum 5 seconds. This patch changes this to qMax so that we really get longer timeouts than 5 seconds. This addresses bug 178411. http://bugs.kde.org/show_bug.cgi?id=178411 Diffs - plasma/generic/dataengines/notifications/notificationsengine.cpp caaca27 Diff: http://git.reviewboard.kde.org/r/105858/diff/ Testing --- notify-send with very long text and debugging output of timeout Thanks, Martin Koller ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Mouse hover effect on ListItem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/ --- Review request for Plasma, Marco Martin and Daker Pinheiro. Description --- Reduce opacity of the ListItem's background decoration when it's hovered and the item is enabled. It's interesting because it improves the GUI responsiveness when using a mouse. Of course this 0.5 can be changed/discussed :) Diffs - plasma/declarativeimports/plasmacomponents/qml/ListItem.qml 8511a26 Diff: http://git.reviewboard.kde.org/r/105939/diff/ Testing --- played with muon discover a bit Screenshots --- a hovered item http://git.reviewboard.kde.org/r/105939/s/668/ Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
