[KDE Bugtracking System] REMINDER: current Plasma regressions
Please find below a list of the current regressions reported for Plasma. This is a weekly reminder. This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 290018: https://bugs.kde.org/show_bug.cgi?id=290018 Priority: NOR Severity: normal Platform: Ubuntu Packages Assignee: plasma-b...@kde.org Status: REOPENED Summary: Add Widgets strip and Activity Manager no longer slide in Bug 290239: https://bugs.kde.org/show_bug.cgi?id=290239 Priority: NOR Severity: normal Platform: openSUSE RPMs Assignee: plasma-b...@kde.org Status: NEW Summary: [Regression] Comic icons in tab view drawn outside the widget ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDEREVIEW: share like connect and plasmate
Hi, Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them to their more permanent homes in a couple of weeks. Most of the apps in the plasmate repo have actually been in past SC releases; it's just the main app, plasmate, that is still fairly new. Regarding plasmate: I fixed earlier a number of i18n issues (ugh...), and the layout of two .ui files. On the other hand, there are still the following issues I found looking around: - there are some dialogs being done as QDialog: what about converting them to KDialog, for a common look'n'feel with the rest of KDE apps, and a bit less layouting code? - PasswordAsker sounds like could be implemented on top of KPasswordDialog - BranchDialog sounds like could be replaced with KInputDialog::getText with a custom validator - CommitDialog, other than being a KDialog, should better be use layouts instead of placing widgets manually - a numer of .ui files sets bold/bigger texts, but using a qt rich text which forces a font size (and in few cases also the font face) - metadata.ui has an error message whose color is forced as red; please use KMessageWidget or at least use KColorScheme to get the fore-/back- ground colors for errors - RemoteInstaller uses /var/tmp/plasmaremoteinstaller/ as destination directory, which is a bit too generic (at least appending the user name and chmod'ing it 600 would help); also there is a race between the KIO exists and the mkdir calls - TimeLine::loadTimeLine does a funky job in putting translated bits among the git output; a better way would be parsing the output extracting the various details, and composing a new ad-hoc string (and the date would need localization, as the FIXME say) - main installs a message handler which makes MainWindow emit a signal... which is caught by itself: why not just put it in main.cpp, and in case there is a main window notify it to write to the konsole widget? also, such handler currently writes to /var/tmp/plasmatepreviewerlog.txt, which is not a good thing to do... - StartPage::saveNewProjectPreferences saves the status of all the js/py/etc radio buttons separately... saving the index or the name of the active one would be much easier - EditPage::showTreeContextMenu uses the internalPointer() of the model, which makes it prone to break if the model changes implementation internally - KonsolePreviewer (ab)uses /var/tmp/plasmatepreviewerlog.txt as temporary file name, please use KTemporaryFile - wrt Publisher::doCMake: - should check that `cmake` exists (see KStandardDirs::findExe) prior to do all the work - $KDEDIRS is not set by default by KDE, but only by the user - check the return value of a command invocation, before starting the next command - when commands fail, instead of a generic failure error, what about showing the output+error log? - SigningDialog::validateParams could use some already existing email validation method (iirc there is a basic one in kdelibs and a better one in kdepimlibs) - why ImageLoader::run forces the formats? - KConfigXtEditor writes/replaces XML by hand... is that really a good thing to do (think about proper escaping, etc)? consider just using QDom/QXml for the job - why KConfigXtWriter writes kcfg prologue/epilogue by hand? - TextEditor::modifyToolBar does a big no-no job in looking for actions (never ever compare to translated strings, especially when coming from other components) I think that's enough for now. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix bold text in battery-monitor tooltip
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107173/ --- (Updated Nov. 3, 2012, 5:23 p.m.) Review request for Plasma. Description --- Makes usage of bold text in the tooltip consistent with the widget. This addresses bug 306903. http://bugs.kde.org/show_bug.cgi?id=306903 Diffs (updated) - plasma/generic/applets/batterymonitor/contents/code/logic.js b5c0d21 Diff: http://git.reviewboard.kde.org/r/107173/diff/ Testing --- Patch tried in real system, all messages are displayed correctly at the right moment Thanks, Michele Gastaldo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21387 --- Ship it! If kickoff doesn't fade, kickoff-qml shouldn't fade too - Greg T On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Kickoff-qml fixes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/#review21398 --- This review has been submitted with commit 7ead86e6621de733f590ceff7ee14efa03806e89 by David Edmundson to branch kickoff-qml. - Commit Hook On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107026/ --- (Updated Oct. 24, 2012, 6:20 p.m.) Review request for Plasma. Description --- If an application has no generic name return the application name as the title. In this case we return nothing as the subtitle. If the subtitle is the same as the new title, hide the subtitle. This fixes a bug in which Find Files would show with a subtitle but no title as well as Utilities having a pointless subtitle -- Use standard desktop scrolling -- Always show application subtitle. This makes it the same as previous kickoff. This subtitle is quite important when you have two web browsers (for example) -- Increase padding on LHS between icon and text Diffs - plasma/desktop/applets/kickoff/core/applicationmodel.cpp fa5ceea58c4e7e27df1a65d5278510b2d0225ffa plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml 4488f2eaea0bc7447318ca341c5b27d6a4eee700 plasma/desktop/applets/kickoff/package/contents/ui/BaseView.qml 2b1e598cc72a84639ecd467ed558276e972a3510 plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml 9d468b2e596410eae18aba357bd6307b70758e33 Diff: http://git.reviewboard.kde.org/r/107026/diff/ Testing --- Screenshots --- After http://git.reviewboard.kde.org/r/107026/s/799/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
