Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32437 --- This isn't a call to reject this patch (which I think is a nice idea), but FWIW: The Task Manager widget is still intended to be replaced by a QML rewrite before feature freeze, and the QML bindings to Plasma's tooltip primitive currently don't allow for a lot in the way of layouting custom content, so I might not be able to recreate this too easily there, specifally having a line break between the two bits of info (unless the tooltip subtext prop accepts rich text). That said since I already had to fork the QML ToolTip component to get window preview thumbnails in there, I guess I could always fork my way further out of that dilemma. In libplasma2 QML ToolTips are fortunately going to be much more flexible, ending the need for a fork. - Eike Hein On May 13, 2013, 11:10 a.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
if i define a function testfunc() in plasmoid /contents/main.js, when user add two instances of my plasmoid to taskbar, in these two instances, is function testfunc() a same object?
if i define testfunc.PROPERTY1=1, is it a same property? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
On May 13, 2013, 11:18 a.m., Eike Hein wrote: This isn't a call to reject this patch (which I think is a nice idea), but FWIW: The Task Manager widget is still intended to be replaced by a QML rewrite before feature freeze, and the QML bindings to Plasma's tooltip primitive currently don't allow for a lot in the way of layouting custom content, so I might not be able to recreate this too easily there, specifally having a line break between the two bits of info (unless the tooltip subtext prop accepts rich text). That said since I already had to fork the QML ToolTip component to get window preview thumbnails in there, I guess I could always fork my way further out of that dilemma. In libplasma2 QML ToolTips are fortunately going to be much more flexible, ending the need for a fork. Turns out that throwing a br/ in there is no problem, so this is easy to sync up with after all. - Eike --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32437 --- On May 13, 2013, 11:10 a.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: if i define a function testfunc() in plasmoid /contents/main.js, when user add two instances of my plasmoid to taskbar, in these two instances, is function testfunc() a same object?
Hello, your function will be a function in all the instances of your plasmoid, but it won't live in the same memory. What exactly do you want to do? On 13 May 2013 14:22, bruce bruce...@gmail.com wrote: if i define testfunc.PROPERTY1=1, is it a same property? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110413: Show in the tasks applet the activities a task is available on
On May 13, 2013, 11:18 a.m., Eike Hein wrote: This isn't a call to reject this patch (which I think is a nice idea), but FWIW: The Task Manager widget is still intended to be replaced by a QML rewrite before feature freeze, and the QML bindings to Plasma's tooltip primitive currently don't allow for a lot in the way of layouting custom content, so I might not be able to recreate this too easily there, specifally having a line break between the two bits of info (unless the tooltip subtext prop accepts rich text). That said since I already had to fork the QML ToolTip component to get window preview thumbnails in there, I guess I could always fork my way further out of that dilemma. In libplasma2 QML ToolTips are fortunately going to be much more flexible, ending the need for a fork. Eike Hein wrote: Turns out that throwing a br/ in there is no problem, so this is easy to sync up with after all. If that's the case, I suppose I should do a commit which includes the changes in TaskItem but not the changes in WindowTaskItem. Am I right? - José --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/#review32437 --- On May 13, 2013, 11:10 a.m., José Millán Soto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110413/ --- (Updated May 13, 2013, 11:10 a.m.) Review request for Plasma. Description --- This patch adds information about the activities on which a task is available to the tooltip. Two methods to obtain information about the activities a task is available, activities and activityNames, where added to TaskManager::TaskItem. Depending whether the applet is configured to show tasks which are not available in the current activity or not, the information displayed will be different. If the applet is configured to show only tasks in current activity, only the tasks which are also available in other activities will have this information in the tooltip. This addresses bug 307163. http://bugs.kde.org/show_bug.cgi?id=307163 Diffs - libs/taskmanager/taskitem.h 35606e2 libs/taskmanager/taskitem.cpp c9613c9 plasma/desktop/applets/tasks/windowtaskitem.cpp f840076 Diff: http://git.reviewboard.kde.org/r/110413/diff/ Testing --- In order to test this patch, three activities (called Activity 1, Activity 2 and Activity 3) were created. Various instances of KDialog were created, all of them in desktop 1, and they were assigned to various activities (The title of the dialog was set to AxDi, where x are the activities on which the dialog will be available). All screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the configuration to show tasks only in current activity. Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. Screenshot 8 was created with the taskbar configured to group elements by program (activity information is not yet available). File Attachments Screenshot 1 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png Screenshot 2 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png Screenshot 3 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png Screenshot 4 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png Screenshot 5 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png Screenshot 6 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png Screenshot 7 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png Screenshot 8 http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png Thanks, José Millán Soto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kde-workspace and plasma2
Hi all, besides having plasma2 pieces in the plasma-workspace repository, there will be the need of components in kde-workspace as well. there has been some work on there already: there is: * a qml2 desktop containment * a qml desktop (and now panel too) toolboxes * a kded that says what formfactor we are running on in the end the plasma part of kde-workspace should look like http://community.kde.org/Plasma/KdeWorkspaceRepoStructure (at least so was discussed in nuremberg) since i wanted to start on porting the good ol' image wallpaper (mostly to fuigure out what we need on workpace-side for doing all the wallpapers we need), i think is good for it to stay in kde-workpace. I would propose to make the branch plasma/sebas/desktop-qml-plasma2 that is now hosting the desktop containment and the toolboxes to host the refactor of the filesystem as well (and there the only buildable part for now would be under plasma/ the part that have been ported) then the other parts (like kwin, ksysguard etc) can work on ports in their own branches (or own repo, their choice) and merge when is ready (or stay on different repo) features on plsma2 porting would be branches of this branch derived from plasma/sebas/desktop-qml-plasma2 and merged when the author of the task feels is ready to be tested by others. If people agrees i can do right away this branch with a beginning of the porting of the filesystem structure to what's in the wiki page Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: if i define a function testfunc() in plasmoid /contents/main.js, when user add two instances of my plasmoid to taskbar, in these two instances, is function testfunc() a same object?
在 2013年5月13日 星期一 15:57:16，Giorgos Tsiapaliokas 写道： Hello, your function will be a function in all the instances of your plasmoid, but it won't live in the same memory. What exactly do you want to do? On 13 May 2013 14:22, bruce bruce...@gmail.com[1] wrote: if i define testfunc.PROPERTY1=1, is it a same property?___Plasma-devel mailing list Plasma-devel@kde.org[2] https://mail.kde.org/mailman/listinfo/plasma-devel[3] -- Giorgos Tsiapaliokas (terietor) terietor.org[4] my purpose is finding a variable or anything similar which exists in different instances of a plasmoid, similar with shared memory between processes, shared object between java threads, etc. [1] mailto:bruce...@gmail.com [2] mailto:Plasma-devel@kde.org [3] https://mail.kde.org/mailman/listinfo/plasma-devel [4] http://terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
there seems to be no dataengines or datasources can provide harddisk's temperature, right?
so all i have to do is install hddtemp or smartctl? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
UI refactor
Hi Fabian, I finally got some time to look at the refactored branch, and it does look good :) Especially the keyboard working in music mode. Awesome work! However, I guess we made quite a lot of changes to master and I am guessing it will take some effort. Have you tried merging master into your branch? If not, lets decide on a common time and get this done :) -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: if i define a function testfunc() in plasmoid /contents/main.js, when user add two instances of my plasmoid to taskbar, in these two instances, is function testfunc() a same object?
On Monday 13 May 2013, bruce wrote: if i define testfunc.PROPERTY1=1, is it a same property?___Plasma-devel mailing list Plasma-devel@kde.org[2] https://mail.kde.org/mailman/listinfo/plasma-devel[3] my purpose is finding a variable or anything similar which exists in different instances of a plasmoid, similar with shared memory between processes, shared object between java threads, etc. plasmoids are supposed to be at least a bit sandboxed and not supposed to shareglobal statics or stuff like that. on the other hand dataengines have usually only one instance for each, regardless how many plasmoids are using them as usual what should be done is to step back and look exactly what you want to do, what your final result in terms of functionality should be, rather than starting from a possible solution -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:22 a.m.) Review request for kde-workspace and Plasma. Changes --- Added kde-workspace group Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple one-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup goes away when it loses focus. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:56 a.m.) Status -- This change has been discarded. Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple one-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup goes away when it loses focus. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
