Re: Help with fixing a notifications issue
On Thursday, May 16, 2013 21:44:02 Daniel Vrátil wrote: So...ideas? :-) imho, in the 4.x libraries, we simply have to rely on applications to get it right: if you have actions in your notification, make them persistent. the notification applet could probably be improved to hide the actions once the notification has expired. there is an expireTimeout member in the model. for Frameworks 5, KNotificatio is set for a re-vamp anyways. things that were proposed have included: * getting rid of the knotify daemon and moving everything in-process * fix the situation with actions (as you've found for yourself :) * add categories and urgencies so they can be sorted (as seen in the latest revision of the galago spec; no point in diverging at this point) I know that Sune Vuorela was going to be (or is?) working on this at some point, so maybe you could catch up with him and discuss further .. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32683 --- the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not the goal. i'd be fine a change that makes it a passive popup when the user purposefully opens it up themselves (so, the default can be passive) but when the window is automatically shown then it should *not* be a passive popup but instead keep showing until it times out and automatically retracts or the user closes it purposefully. (at which point it could go back to being a passive popup) - Aaron J. Seigo On May 16, 2013, 4:56 p.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 16, 2013, 4:56 p.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup hides when it goes out of focus when no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
On May 17, 2013, 7:33 a.m., Aaron J. Seigo wrote: the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not the goal. i'd be fine a change that makes it a passive popup when the user purposefully opens it up themselves (so, the default can be passive) but when the window is automatically shown then it should *not* be a passive popup but instead keep showing until it times out and automatically retracts or the user closes it purposefully. (at which point it could go back to being a passive popup) I'll confirm that when I get home, but the patch changes the behavior of the notifications history (i.e., the thing that appears when we click the notifications icon), not that of the notifications popup. Well, I wrote popup in the testing done section, so, my bad for confusing things. I'll try to make it clearer. - Romário --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32683 --- On May 16, 2013, 4:56 p.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 16, 2013, 4:56 p.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup hides when it goes out of focus when no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and Plasma. Changes --- Clearer description. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing (updated) --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
On May 17, 2013, 7:33 a.m., Aaron J. Seigo wrote: the point of notifications are, obviously, to inform the user. if it hides as soon as something else is interacted with, the user will miss many (even most) notifications that appear while they are using the computer. obviously not the goal. i'd be fine a change that makes it a passive popup when the user purposefully opens it up themselves (so, the default can be passive) but when the window is automatically shown then it should *not* be a passive popup but instead keep showing until it times out and automatically retracts or the user closes it purposefully. (at which point it could go back to being a passive popup) Romário Rios wrote: I'll confirm that when I get home, but the patch changes the behavior of the notifications history (i.e., the thing that appears when we click the notifications icon), not that of the notifications popup. Well, I wrote popup in the testing done section, so, my bad for confusing things. I'll try to make it clearer. Just checked and now I can confirm that the popup behavior remains inaltered. - Romário --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32683 --- On May 17, 2013, 8:26 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32694 --- Ship it! this is fine by me then ... cheers. - Aaron J. Seigo On May 17, 2013, 8:26 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
On May 17, 2013, 12:10 p.m., Aaron J. Seigo wrote: this is fine by me then ... cheers. Should it be backported to 4.10? - Romário --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32694 --- On May 17, 2013, 8:26 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/#review32696 --- This review has been submitted with commit 71fc7c112076ac2eb83146e58167d95bf04d8f5f by Luiz Romário Santana Rios to branch master. - Commit Hook On May 17, 2013, 8:26 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 8:26 a.m.) Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110420: Bugfix for bug #311364
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 17, 2013, 12:57 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Description --- Fixes bug #311364. I'm not entirely sure if that's a bug or a feature, but since it's a simple two-liner, I figured I'd just drop the diff and let you decide. This addresses bug 311364. http://bugs.kde.org/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- After the notifications icon is clicked and the history pops up, it hides when it goes out of focus if no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.
Ok I will commit it. About the comment, if you go by that reasoning, the code will become full of unnecessary comments. So unless absolutely necessary, you don't want to do that. If someone wants it back, there is git ;) On Thu, May 16, 2013 at 10:52 PM, Akshay Ratan akshayra...@gmail.comwrote: Hi, Yes I think it would be perfect if you commit it for me. I dont yet have KDE Developers Right. Also, my reason for commenting the line was if in future somebody wants to code some added feature regarding the playlist, the line might be of some help. Anyways, should I remove it if you say ? Cheers, Akshay Ratan On Thu, May 16, 2013 at 10:45 PM, Shantanu Tushar shant...@kde.orgwrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110475/ Ship it! Looks good. Should I commit this for you? mediaelements/playlist/PlaylistDelegate.qmlhttp://git.reviewboard.kde.org/r/110475/diff/1/?file=144360#file144360line59 (Diff revision 1)58 visible: listViewItem.ListView.isCurrentItem 59 // visible: listViewItem.ListView.isCurrentItem don't use comments, just remove the line - Shantanu On May 16th, 2013, 5:07 p.m. UTC, Akshay Ratan wrote: Review request for Plasma, Marco Martin, Shantanu Tushar, and Sinny Kumari. By Akshay Ratan. *Updated May 16, 2013, 5:07 p.m.* Description Fixed bug 319626 ( https://bugs.kde.org/show_bug.cgi?id=319626) . Now, in the media playlist, remove sign is shown on every song , so the user has to just click that sign instead of clicking the song which earlier stopped the media. So basically now the current media is not stopped when deleting an item from a playlist. Testing Yes *Bugs: * https://bugs.kde.org/show_bug.cgi?id=319626http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=319626 Diffs - mediaelements/playlist/PlaylistDelegate.qml (449a0aa) View Diff http://git.reviewboard.kde.org/r/110475/diff/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Akshay -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110475/ --- (Updated May 17, 2013, 5:38 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Marco Martin, Shantanu Tushar, and Sinny Kumari. Description --- Fixed bug 319626 ( https://bugs.kde.org/show_bug.cgi?id=319626) . Now, in the media playlist, remove sign is shown on every song , so the user has to just click that sign instead of clicking the song which earlier stopped the media. So basically now the current media is not stopped when deleting an item from a playlist. This addresses bug https://bugs.kde.org/show_bug.cgi?id=319626. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=319626 Diffs - mediaelements/playlist/PlaylistDelegate.qml 449a0aa Diff: http://git.reviewboard.kde.org/r/110475/diff/ Testing --- Yes Thanks, Akshay Ratan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/#review32711 --- This review has been submitted with commit 8a6f783dfd6f021173f5d3b47772b0fc320eba31 by Vishesh Handa to branch KDE/4.10. - Commit Hook On May 16, 2013, 9:57 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/ --- (Updated May 16, 2013, 9:57 a.m.) Review request for Plasma. Description --- Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo 1. The Xesam width and height properties are never returned by strigi and haven't been returned for a very very long time. It currently returns the nfo:width and nfo:height property instead. 2. KFileMetadataWidget is blocking and blocks while it is calculating the height and width. It is better to open the file and calculate it in another thread as done by the ImageSizeFinder 3. QImage in more reliable and actively maintained in contrast to strigi. Diffs - plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110467/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/ --- (Updated May 17, 2013, 6:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Description --- Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo 1. The Xesam width and height properties are never returned by strigi and haven't been returned for a very very long time. It currently returns the nfo:width and nfo:height property instead. 2. KFileMetadataWidget is blocking and blocks while it is calculating the height and width. It is better to open the file and calculate it in another thread as done by the ImageSizeFinder 3. QImage in more reliable and actively maintained in contrast to strigi. Diffs - plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110467/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110465: Plasma Wallpaper BackgroundListModel: Remember to clear the caches
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110465/#review32712 --- This review has been submitted with commit e57a7dd679521d384fceff734f8dc4eaf2e2e928 by Vishesh Handa to branch KDE/4.10. - Commit Hook On May 16, 2013, 9:57 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110465/ --- (Updated May 16, 2013, 9:57 a.m.) Review request for Plasma. Description --- Don't just clear m_packages, clear the m_sizeCache and m_previews as well Diffs - plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110465/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110465: Plasma Wallpaper BackgroundListModel: Remember to clear the caches
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110465/ --- (Updated May 17, 2013, 6:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Description --- Don't just clear m_packages, clear the m_sizeCache and m_previews as well Diffs - plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110465/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Can i get some pointers for this bug? (widgets can not be moved to the utmost top of the display)
Hi, I've been teased by this bug [1] for years but never bothered to look into it. I'm browsing through dozens of files, enabling debug output as i go.. but nothing extra gets printed. I used qDebug() just to be sure that i didn't an oops ;) Anyway, since the plasma code is completely new for me i'm kinda hoping that someone can briefly explain how the run chain is going from plasma startup till drawing the applets on the screen. I guess i can find my way with that bit of information. Right now i'm not even sure if i need to be looking in the plasma/desktop/shell/ folder, or in plasma/generic.. Or if i'm even in the right repository (kde-workspace). Cheers, Mark [1] https://bugs.kde.org/show_bug.cgi?id=301225 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
