Re: qml trash

2013-06-09 Thread Heena Mahour
Hey all ,one more query is that  in order to open trash:/ what should I
write in engine: and connectedSources
  here :
PlasmaCore.DataSource {
   id: dataEngine
  engine://what should be I include here among the data engine
   connectedSources: [??] }



On Sun, Jun 9, 2013 at 12:06 AM, Kai Uwe Broulik k...@privat.broulik.dewrote:

 Also use openUrl instead of LaunchApplication
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel




-- 
-Heena
Season of kde'12 participant
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Sunday, June 9, 2013 16:23:31 Heena Mahour wrote:
 Hey all ,one more query is that  in order to open trash:/ what should I
 write in engine: and connectedSources

you should not be using a DataEngine for this, but rather plasmoid.openUrl.

here's the good news: it works perfectly here. i start the plasmoid, click on 
it and sure enough - the trash folder opens in dolphin.

so i'm not sure why it is not working for you. what version of KDE SC are you 
using? (e.g. what does this say when run from a console: kde4-config --version)

also, please be careful with the formating of the source code. i see you are 
mixing tabs and spaces, not indenting things consistently, etc. we can not 
merge the code until it is consistent and follows the coding standards.

for reference:

http://community.kde.org/Plasma/QMLStyle
http://techbase.kde.org/Policies/Kdelibs_Coding_Style


-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Saturday, June 8, 2013 23:50:31 Heena Mahour wrote:
 Hi , I am trying to implement qml plasmoid of trash , in the action menu
 for statement  KRun::runUrl(KUrl(trash:/), inode/directory, 0); I
 implemented it is qml like this :http://pastebin.com/raw.php?i=266L3Hx0 but
 it is not opening trash could you tell what modifications are needed here ?
 regards

I see the problem now .. there was a synxtax error in the 
Component.onCompleted handler. instead of i18n you had written il8n (an 
'L' instead of a '1').

when i started the plasmoid using plasmoidviewer from the console, this error 
was immediately visible in the debug output. if you are not using 
plasmoidviewer to test with, i strongly recommend doing so. it makes finding 
these kinds of problems easy.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Saturday, June 8, 2013 23:50:31 Heena Mahour wrote:
 Hi , I am trying to implement qml plasmoid of trash , in the action menu
 for statement  KRun::runUrl(KUrl(trash:/), inode/directory, 0); I
 implemented it is qml like this :http://pastebin.com/raw.php?i=266L3Hx0 but
 it is not opening trash could you tell what modifications are needed here ?
 regards

.. and more problems :)

the open and empty functions need to be call action_trash and action_empty. 
they must match the name of the actions you create, prepended with action_. 
again, running it with plasmoidviewer in a konsole window, when selecting 
open from the context menu i saw this:

QMetaObject::invokeMethod: No such method 
QDeclarativeFlow_QML_0::action_trash()

there were other errors in there as well. all are visible by using 
plasmoidviewer. i'll push some fixes in a moment that you can look at.

-- 
Aaron J. Seigo

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Dan Vrátil

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110476/
---

(Updated June 9, 2013, 3:11 p.m.)


Review request for Plasma.


Description
---

Call KNotification::close() when user clicks the 'X' button in the 
Notifications applet.

This prevents leaking persistent notifications and allows applications to 
depend on KNotification::closed() signal.


Diffs
-

  
plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml
 64d9298 
  plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 
  plasma/generic/dataengines/notifications/notificationaction.cpp 397073e 
  plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb 

Diff: http://git.reviewboard.kde.org/r/110476/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Marco Martin
On Sunday 09 June 2013, Aaron J. Seigo wrote:
 QMetaObject::invokeMethod: No such method
 QDeclarativeFlow_QML_0::action_trash()
 
 there were other errors in there as well. all are visible by using
 plasmoidviewer. i'll push some fixes in a moment that you can look at.

i guess that for emptying the trash a c++ service will have to be created?


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Heena Mahour
@Aaron .Yes,it is working on left clicking on it :P but on right click in
the original c++ trash can there is a pop up menu which contains open trash
and empty trash option ,So,for that open trash it is not working ,isn't it?
Regards
@Marco,
Yes,And what about open trash option?
Regards


On Sun, Jun 9, 2013 at 6:42 PM, Marco Martin notm...@gmail.com wrote:

 On Sunday 09 June 2013, Aaron J. Seigo wrote:
  QMetaObject::invokeMethod: No such method
  QDeclarativeFlow_QML_0::action_trash()
 
  there were other errors in there as well. all are visible by using
  plasmoidviewer. i'll push some fixes in a moment that you can look at.

 i guess that for emptying the trash a c++ service will have to be created?


 --
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel




-- 
-Heena
Season of kde'12 participant
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Lamarque Souza

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110476/#review33981
---



plasma/generic/dataengines/notifications/notificationaction.cpp
http://git.reviewboard.kde.org/r/110476/#comment25016

This change seems unneeded.



plasma/generic/dataengines/notifications/notificationsengine.cpp
http://git.reviewboard.kde.org/r/110476/#comment25018

I think immediately is better than directly here. I still do not fully 
understand this comment, deleting a service before it finishes sounds like a 
bug to me.


- Lamarque Souza


On June 9, 2013, 1:11 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/110476/
 ---
 
 (Updated June 9, 2013, 1:11 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 Call KNotification::close() when user clicks the 'X' button in the 
 Notifications applet.
 
 This prevents leaking persistent notifications and allows applications to 
 depend on KNotification::closed() signal.
 
 
 Diffs
 -
 
   
 plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml
  64d9298 
   plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 
   plasma/generic/dataengines/notifications/notificationaction.cpp 397073e 
   plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb 
 
 Diff: http://git.reviewboard.kde.org/r/110476/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Marco Martin
On Sunday 09 June 2013, Heena Mahour wrote:
 @Aaron .Yes,it is working on left clicking on it :P but on right click in
 the original c++ trash can there is a pop up menu which contains open trash
 and empty trash option ,So,for that open trash it is not working ,isn't it?
 Regards

setAction(String name, String text, String icon, String shortcut)

then implementing functions called

function action_name(){}

in the qml root item should work

 @Marco,
 Yes,And what about open trash option?

opening the trash is easy, it is already working with left click no?

 Regards
 
 On Sun, Jun 9, 2013 at 6:42 PM, Marco Martin notm...@gmail.com wrote:
  On Sunday 09 June 2013, Aaron J. Seigo wrote:
   QMetaObject::invokeMethod: No such method
   QDeclarativeFlow_QML_0::action_trash()
   
   there were other errors in there as well. all are visible by using
   plasmoidviewer. i'll push some fixes in a moment that you can look at.
  
  i guess that for emptying the trash a c++ service will have to be
  created?
  
  
  --
  Marco Martin
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Kevin Krammer
On Sunday, 2013-06-09, Marco Martin wrote:
 On Sunday 09 June 2013, Aaron J. Seigo wrote:
  QMetaObject::invokeMethod: No such method
  QDeclarativeFlow_QML_0::action_trash()
  
  there were other errors in there as well. all are visible by using
  plasmoidviewer. i'll push some fixes in a moment that you can look at.
 
 i guess that for emptying the trash a c++ service will have to be created?

Unless you have the option to run an executable with arguments, in which case 
you could run
ktrash --empty

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: qml trash

2013-06-09 Thread Heena Mahour
Hey ,
okay ,now the thing left here is empty trash in which I am not getting how
to implement :
 KStandardDirs::findExe(ktrash)  --empty;

m_emptyProcess-start();

in javascript (or c++ ? )

I will push the rest of the changes I made in some time as it is
giving an error of remote rejected .


Regards



On Sun, Jun 9, 2013 at 8:20 PM, Kevin Krammer kram...@kde.org wrote:

 On Sunday, 2013-06-09, Marco Martin wrote:
  On Sunday 09 June 2013, Aaron J. Seigo wrote:
   QMetaObject::invokeMethod: No such method
   QDeclarativeFlow_QML_0::action_trash()
  
   there were other errors in there as well. all are visible by using
   plasmoidviewer. i'll push some fixes in a moment that you can look at.
 
  i guess that for emptying the trash a c++ service will have to be
 created?

 Unless you have the option to run an executable with arguments, in which
 case
 you could run
 ktrash --empty

 Cheers,
 Kevin

 --
 Kevin Krammer, KDE developer, xdg-utils developer
 KDE user support, developer mentoring

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel




-- 
-Heena
Season of kde'12 participant
Delhi College of Engineering(COE),India
http://about.me/heena.mahour
http://heenamahour.blogspot.in
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 110917: Remove usage of (fake) Amarok-Mockup theme

2013-06-09 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110917/
---

Review request for Amarok, Plasma and Aaron J. Seigo.


Description
---

This is due to https://bugs.kde.org/show_bug.cgi?id=320855
Amarok-Mockup is unused, as far i can see, and also makes Amarok crash with 
kdelibs master/4.11
If it is still needed, or there is a better solution, i'll discard the review...


Diffs
-

  src/context/ContextView.cpp f61518f 

Diff: http://git.reviewboard.kde.org/r/110917/diff/


Testing
---

Compiled, no crash, no (yet at least) side-effects.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel