Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40498 --- File Attachment: files http://git.reviewboard.kde.org//r/112888/#fcomment106 Show extension or not? - Bhushan Shah On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40499 --- File Attachment: folders http://git.reviewboard.kde.org//r/112888/#fcomment107 Will fix this - Bhushan Shah On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40500 --- File Attachment: icons as launcher http://git.reviewboard.kde.org//r/112888/#fcomment108 I am missing glow as of older icons.. how to get it? - Bhushan Shah On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- plasma/generic/applets/icon/package/contents/ui/main.qml http://git.reviewboard.kde.org/r/112888/#comment29818 For license, we prefer the GPL with KDE e.V. exception. I'll leave this up to you whether you think this is OK for this code or not. (As long as it's GPL or LGPL (or more liberal), we'll accept it.) The preferred one would be the second option here: http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header plasma/generic/applets/icon/package/contents/ui/main.qml http://git.reviewboard.kde.org/r/112888/#comment29819 Use 16 here, I'd say. 1x1 icons don't make sense. plasma/generic/applets/icon/package/contents/ui/main.qml http://git.reviewboard.kde.org/r/112888/#comment29821 This will not work well for iconswithlongnamebutwithoutspacesinthename.extension. :) plasma/generic/applets/icon/package/metadata.desktop http://git.reviewboard.kde.org/r/112888/#comment29817 This should probably be 32,32 or 48,48. 100 is not among the standard icon sizes. plasma/generic/applets/icon/plugin/icon_p.h http://git.reviewboard.kde.org/r/112888/#comment29822 Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem more declarative. This would also make the remote case easier, when you have to stat a remote file asynchronously and only know details after the network request. plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29829 m_ is for members plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29824 url.fileName(); is not enough here? plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29828 m_ is for members, use icon or iconName here. plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29823 trailing whitespace plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29825 } else ... (no new line) plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29827 m_ prefix is used for member variables. Rename it to genericName for example. plasma/generic/applets/icon/plugin/icon_p.cpp http://git.reviewboard.kde.org/r/112888/#comment29826 no new line Definitely going in the right direction. Let's get a few issues I've pointed out inside fixed, then merge it into frameworks-scratch and finish it up there. - Sebastian Kügler On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 8:28 a.m., Bhushan Shah wrote: File Attachment: files http://git.reviewboard.kde.org/r/112888/#fcomment110 Show extension or not? This is a bit of a complicated topic, actually. Quick explanation. Not showing the extension bears some security risk. You could have a nasty executable, that uses an image as icon. When clicking on it, you're running a programme, rather than opening an image. (Now this is not downloaded content, so it's not *that* bad, but we'll probably still need to take this into account. Have you looked at the original Icon widget what it does here? - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40498 --- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: plasma/generic/applets/icon/plugin/icon_p.cpp, line 76 http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line76 no new line ?? - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: plasma/generic/applets/icon/plugin/icon_p.h, line 31 http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31 Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem more declarative. This would also make the remote case easier, when you have to stat a remote file asynchronously and only know details after the network request. Passing url is my main problem here.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 8:30 a.m., Bhushan Shah wrote: File Attachment: icons as launcher http://git.reviewboard.kde.org/r/112888/#fcomment109 I am missing glow as of older icons.. how to get it? I think we had custom painting routine for that. This most likely will need to be rethought for Plasma 2. Maybe add a rounded lozenge around the text for now? You could also ask Eike Hein (Sho on IRC) what he used for the text in the taskbar. - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40500 --- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
plasma/generic/applets/icon/plugin/icon_p.h, line 31
http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31
Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors).
That would seem more declarative.
This would also make the remote case easier, when you have to stat a
remote file asynchronously and only know details after the network request.
Bhushan Shah wrote:
Passing url is my main problem here..
I'd add a writable property url, which then updates all the other properties
via property bindings.
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
plasma/generic/applets/icon/plugin/icon_p.cpp, line 76
http://git.reviewboard.kde.org/r/112888/diff/1/?file=191269#file191269line76
no new line
Bhushan Shah wrote:
??
} else {
not
}
else {
- Sebastian
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---
On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---
(Updated Sept. 23, 2013, 8:26 a.m.)
Review request for Plasma, Marco Martin and Sebastian Kügler.
Description
---
Port Icon applet to plasma2
Some issues..
- Can be resized to 1x1.
- Still doesn't work for folder, and external URLs.
- Configuration dialog
Diffs
-
plasma/generic/applets/CMakeLists.txt 4ace449
plasma/generic/applets/icon/CMakeLists.txt 1094666
plasma/generic/applets/icon/icon.h 45fa07c
plasma/generic/applets/icon/icon.cpp 8288850
plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION
plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION
plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION
plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd
plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION
plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION
plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION
plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION
plasma/generic/applets/icon/plugin/qmldir PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112888/diff/
Testing
---
1) Compiles
2) Installs
3) Loads
- Dropping application icon from KickOff - creates icon
- Dropping files from Dolphin, both executable and normal files - creates
icon
- Dropping folder from Dolphin - creates icon applet but neither icon nor
text because folder handling is not added yet.
4) Opens URL - Clicking on the icon applet opens url with kfmclient
File Attachments
icons in panel
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
Thanks,
Bhushan Shah
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: plasma/generic/applets/icon/plugin/icon_p.h, line 31 http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31 Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem more declarative. This would also make the remote case easier, when you have to stat a remote file asynchronously and only know details after the network request. Bhushan Shah wrote: Passing url is my main problem here.. Sebastian Kügler wrote: I'd add a writable property url, which then updates all the other properties via property bindings. But I don't have url at the time of applet creation.. keeping it for later.. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 8:26 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 12:37 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Changes --- fix issues, license Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs (updated) - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: plasma/generic/applets/icon/plugin/icon_p.h, line 31 http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31 Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That would seem more declarative. This would also make the remote case easier, when you have to stat a remote file asynchronously and only know details after the network request. Bhushan Shah wrote: Passing url is my main problem here.. Sebastian Kügler wrote: I'd add a writable property url, which then updates all the other properties via property bindings. Bhushan Shah wrote: But I don't have url at the time of applet creation.. keeping it for later.. That's fine. As soon as you have it, you can set it, and thanks to property bindings, all users will update automatically. :) - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 --- On Sept. 23, 2013, 12:37 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 12:37 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40557 --- plasma/generic/applets/icon/package/contents/ui/main.qml http://git.reviewboard.kde.org/r/112888/#comment29879 spaces around == and || make it more readable - Sebastian Kügler On Sept. 23, 2013, 12:37 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 12:37 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/icon.h 45fa07c plasma/generic/applets/icon/icon.cpp 8288850 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDE framework 5 - a humble idea
hello, is there a preferred way to share documents in the mailing list? is an ubuntu one link an acceptable option? Thank you, 2013/9/21 Michele Kipiel michele.kip...@gmail.com Il giorno sab, 21/09/2013 alle 01.51 +0200, Sebastian Kügler ha scritto: Hi Michele, A few thoughts inline. I've also explained a bit of the technical underpinnings of the ideas you propose, just to give you a general understanding of how the system is handling these things, and how the concepts could be described technically. On Wednesday, September 18, 2013 11:26:21 Michele Andrea Kipiel wrote: hello everybody, the following message is part of an email i sent a few days ago to Marco Martin, who then asked me to share my thoughts on this mailng list. *** my name is michele kipiel and i am a ux designer. I currently work for the Kering luxury group, where i design and user test the checkout processes and the overall UX of the luxury sites. i recently came across a video showing the new KDE framework 5 improvements (the one posted by phoronics, in case you were wondering). watching that video reminded me of what immediately struck me when i first tried KDE 4: the apparent lack of a true purpose for the plasmoids. as a ux designer i constantly strive towards simplification and rationalization of the user experience, and the first thing i noticed about the plasmoids was that they didn't improve my experience in any relevant way, while taking up lots of space on my small 13 laptop screen. I think others have already pointed it out, but let me clarify that. The video (it was probably me who took it) shows test and demo code. The goal here is to exercise all kinds of graphical objects on the screen. This helps us in porting a whole bunch of other widgets to Plasma 2. They're basically just UI tests and examples and have zero purpose for an actual user. That is to say that we're getting closer to having the basic components in place to make Plasma 2 actually useful, and it's certainly a good point in time to think about higher level ideas such as workflows between these components. i asked myself a simple question: what do i need on my desktop? what i came to realize is that i could really use a desktop which acts as a connection point between the hundreds of apps that live on my hard drive. current plasmoids act as discrete information bubbles (weather, rss, im, social feeds etc..) and threy don't communicate with each other, which in my opinion hampers their usefulness. in other words: what would happen if KDE added a common backend to connect all the plasmoids (i'm thinking of something similar to what elementary OS is doing with contractor)? imagine this scenario: i have a file manager plasmoid open on my desktop, along with other ones. i want to share one of my pictures to facebook. i drag and drop the picture from the file manager plasmoid onto the facebook feed plasmoid, which in turn activates the sharing feature, allowing me to add a caption, tag my friends and eventually share the picture. This gets me thinking that we can use Share-Like-Connect for this, in a sligthly different manner. Many widgets and a handful of applications publish their current document (url, or link to a file on the filesystem) to other apps. The Share-Like-Connect widget uses this to offer sharing options for this. I imagine, that a gimp plasmoid could use this same information to offer a bunch of image transformations. You pick one, and the published document becomes that newly transformed image, then you head over to the share-like-connect widget to post it. This is just an example, but would be entirely possible with how Plasma works today. now imagine i want to turn the picture in b/w before sharing it: i just drag and drop the picture onto the gimp plasmoid, which shows me a preview of the picture and lets me select an action form a pool of simple, predefined functions. once my picture is rendered, i just have to drag it from the gimp plasmoid onto the facebook one to share it. Let's look into what we have for drag and drop support, in more detail. Widgets can offer themselves for a certain mimetype being dropped onto the Desktop (the containment in technical terms). We have applets which can handle images for example. The picture frame registers itself as being able to handle images (it doesn't tell what it does with it), so when you drop an image onto the desktop, you get offered the picture frame widget. Additionally, for images, you can set them as wallpapers. For text, you'll get a Notes widget, etc. A widget defines what it can handle in its metadata, those can be two things: - a number of mimetypes (Picture frame has image/png, for example) - a regular expression to match a url What happens when
[PMC] Review of major refactoring around All Music mode
Hi, * tl;dr * There is new refactored code in fabian-refactoring-shantanu which should be functionally same as master. Please take some time, test it and report if it works fine, or if a major feature is broken. * Long version * Thanks to Fabian, we had started refactoring Plasma Media Center's media browsing code so as to create more reusable components. Finally this is complete with all major functionality working. The code for this lies in the branch fabian-refactoring-shantanu . The salient features are- 1. Backends can now expose multiple models instead of just one. The media browser is smart enough to understand how to display these. See #2. There is 100% backwards compatibility in the sense that older backends with only one model will continue to work, internally stored as a list of just one model. 2. We now have the following reusable components throughout PMC- * GridBrowser - as the name says, give it a backend/model and it will show items in a grid * ListBrowser - same as above, but a list * SplitBrowser - can show two browsers side-by-side for two models * TabBrowser - takes a backend and list of models and shows a browser for each model in tabs * SmartBrowser - give it a model or a list of models, and it figures out which of the above browsers to use 3. Due to these changes, method calls like expand, search etc now take a parameter to the model on which they need to operate. There is 100% backwards compatibility where if the parameter is not present, the first model is picked up. 4. Search can now operate on individual models, giving you support to search any model in your backend. See #3 5. *Best of all* We can throw all the custom/duplicated code for All Music backend as generic browsers in #2 take care of that. (1006 less lines of code!) What do we need? Well if you get some time, please checkout the branch fabian-refactoring-shantanu , test it to make sure no major features are broken. Note, there are still few minor keyboard/UI issues which I will create bug reports for once merged to master. What next? I eagerly wait for comments on how the new browsers work, and unless some major feature is broken, I will go ahead and merge with master this weekend, or earlier if people try out and find no issues. Thanks! -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
On Sept. 23, 2013, 3:49 p.m., Sebastian Kügler wrote: plasma/generic/applets/icon/package/contents/ui/main.qml, line 86 http://git.reviewboard.kde.org/r/112888/diff/5/?file=191523#file191523line86 You can remove / comment the print statements here I think keeping it for now. - Bhushan --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40580 --- On Sept. 23, 2013, 3:39 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:39 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40584 --- This review has been submitted with commit 86473b939a8a485ab6f34e6cbdee916b5fd40c3c by Bhushan Shah to branch frameworks-scratch. - Commit Hook On Sept. 23, 2013, 3:39 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:39 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112888: Roughly port icon applet to plasma2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/ --- (Updated Sept. 23, 2013, 3:39 p.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Description --- Port Icon applet to plasma2 Some issues.. - Can be resized to 1x1. - Still doesn't work for folder, and external URLs. - Configuration dialog Diffs (updated) - plasma/generic/applets/CMakeLists.txt 4ace449 plasma/generic/applets/icon/CMakeLists.txt 1094666 plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION plasma/generic/applets/icon/plugin/qmldir PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112888/diff/ Testing --- 1) Compiles 2) Installs 3) Loads - Dropping application icon from KickOff - creates icon - Dropping files from Dolphin, both executable and normal files - creates icon - Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet. 4) Opens URL - Clicking on the icon applet opens url with kfmclient File Attachments icons in panel http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png icons as launcher http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png files http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png folders http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 4.11 is out .. kde-workspace to qt5?
On Monday 23 September 2013 19:58:08 Martin Graesslin wrote: Switch tasks: * merge the frameworks branch into master Martin volunteered to do this, planned for next Monday. blocked by pre-switch task I just tried to merge master into frameworks-scratch but gave up due to changes in taskmanager where I have no idea how to do the merges. @Eike: can we try to do that together, tomorrow? Cheers Martin P.S.: this is a clear sign to me that we should split the kde-workspace repo. It would make the merging way easier. signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 4.11 is out .. kde-workspace to qt5?
On Monday 16 September 2013 16:35:58 Sebastian Kügler wrote: * the CMakeLists.txt needs to output a usefully verbose error message when it only finds kdelibs 4.x and not kf5. * we need to test with the latest version of kdesrc-build and make it do the right thing by choosing the 4.11 branch by default Those two tasks are on my list for this week. what's the state on this? I cannot find an update to CMakeLists.txt which would print out a warning ;-) Switch tasks: * merge the frameworks branch into master Martin volunteered to do this, planned for next Monday. blocked by pre-switch task Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 4.11 is out .. kde-workspace to qt5?
On Monday, September 23, 2013 19:58:08 Martin Graesslin wrote: On Monday 16 September 2013 16:35:58 Sebastian Kügler wrote: * the CMakeLists.txt needs to output a usefully verbose error message when it only finds kdelibs 4.x and not kf5. * we need to test with the latest version of kdesrc-build and make it do the right thing by choosing the 4.11 branch by default Those two tasks are on my list for this week. what's the state on this? I cannot find an update to CMakeLists.txt which would print out a warning ;-) My bad. I've talked to dfaure, and he said that the obvious error that it doesn't build against Qt5 is clear enough -- that's the status quo, so no change needed. So pre-merge tasks are cleared. Sorry for not communicating this pro-actively. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112723: add a visible property in the toolBox
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/
---
(Updated Sept. 23, 2013, 3:32 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Description
---
The toolBox should have a visible property in order to be
possible to do
property Item toolBox
onToolBoxChanged: {
visible: false
}
Diffs
-
src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9
Diff: http://git.reviewboard.kde.org/r/112723/diff/
Testing
---
the default value of the visible property is true,
so the existing behavior doesn't change.
Thanks,
Giorgos Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KDE framework 5 - a humble idea
On Monday, September 23, 2013 14:45:53 Michele Andrea Kipiel wrote: is there a preferred way to share documents in the mailing list? is an ubuntu one link an acceptable option? as long as it is available without requiring special software installed or an account, it doesn’t particularly matter where it is stored. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
