Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
On Oct. 31, 2013, 3:27 p.m., Kevin Funk wrote: Bump. Can we have this fixed soonish? Nicolas, can you push? Bump again -- Without this fix, controlling volume in KMix via the mouse wheel is close to impossible. Can someone push? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review42747 --- On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Oct. 6, 2013, 7:36 p.m.) Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review43878 --- Ship it! Ship It! - Sebastian Kügler On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Oct. 6, 2013, 7:36 p.m.) Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 113919: Killing the unassigned containments
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Removing the legacy migration code which guesses what to do with containments that are not assigned to an activity. Diffs - src/shell/shellcorona.cpp 1e42e38 Diff: http://git.reviewboard.kde.org/r/113919/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113919: Killing the unassigned containments
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/#review43885 --- Ship it! Ship It! - Marco Martin On Nov. 18, 2013, 10:43 a.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/ --- (Updated Nov. 18, 2013, 10:43 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Removing the legacy migration code which guesses what to do with containments that are not assigned to an activity. Diffs - src/shell/shellcorona.cpp 1e42e38 Diff: http://git.reviewboard.kde.org/r/113919/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113919: Killing the unassigned containments
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/ --- (Updated Nov. 18, 2013, 11:57 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Removing the legacy migration code which guesses what to do with containments that are not assigned to an activity. Diffs - src/shell/shellcorona.cpp 1e42e38 Diff: http://git.reviewboard.kde.org/r/113919/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113919: Killing the unassigned containments
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/#review43886 --- This review has been submitted with commit 3dbb992e6170f4fd7d2e6bcd94ab3fa36c4195ab by Ivan Čukić to branch master. - Commit Hook On Nov. 18, 2013, 10:43 a.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113919/ --- (Updated Nov. 18, 2013, 10:43 a.m.) Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Removing the legacy migration code which guesses what to do with containments that are not assigned to an activity. Diffs - src/shell/shellcorona.cpp 1e42e38 Diff: http://git.reviewboard.kde.org/r/113919/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
plasma-shell startup problems
alohas, plasma-shell doesn't start for me in a VM using project-neon5 (kubuntu) it fails an assert in plasma-framework http://i.imgur.com/norAnRC.png - that is including 3dbb992 which according to sebas should have helped with that particular assert thoughts? HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-shell startup problems
You are fast dude :) Can you do the following? qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities On 18 November 2013 14:11, Harald Sitter sit...@kde.org wrote: alohas, plasma-shell doesn't start for me in a VM using project-neon5 (kubuntu) it fails an assert in plasma-framework http://i.imgur.com/norAnRC.png - that is including 3dbb992 which according to sebas should have helped with that particular assert thoughts? HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-shell startup problems
On Mon, Nov 18, 2013 at 2:16 PM, Ivan Čukić ivan.cu...@gmail.com wrote: You are fast dude :) Can you do the following? qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities me@me-VirtualBox:~$ qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities 98f08df4-6d60-408f-bfaf-703002547224 HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-shell startup problems
On Monday 18 November 2013 14:20:10 Harald Sitter wrote: On Mon, Nov 18, 2013 at 2:16 PM, Ivan Čukić ivan.cu...@gmail.com wrote: You are fast dude :) Can you do the following? qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities me@me-VirtualBox:~$ qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities 98f08df4-6d60-408f-bfaf-703002547224 :) That means I'm an idiot - should be fixed in master now (was asserting on something that should be false) -- So remember when you're feeling very small and insecure How amazingly unlikely is your birth And pray that there's intelligent life somewhere up in space Because there's bugger all down here on earth. -- Monty Python ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
minutes Monday Plasma hangout
Plasma 2 meeting, 18th November 2013 Present: Giorgos, Ivan, Martin, Marco, Sebastian - Martin worked on nasty kwin bugs, - one down in kwindowsystem, - one in opengl / sandybridge - virtual machines and openGL behave erratic, depending on host system - Discussion on Wayland list about windecos going on - Bugtracker for immediate plasma bugs - Giorgos is working on plasmoidviewer - controls are starting to work (Location, Formfactor) - screenshot feature - js console can't be made to work until Qt 5.3 - filedialog styling problem, being worked on - resizing plasmoids is broken right now - email about features coming to plasma-devel - Ivan is working on QML models in dataengines - services and called functions unsolved at the moment, - could possibly be done with QFuture - Marco has worked on Blur contrast improvements - first patches up for review, likely to need improvements -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
minutes Monday Plasma hangout
Plasma 2 meeting, 18th November 2013 Present: Giorgos, Ivan, Martin, Marco, Sebastian - Martin worked on nasty kwin bugs, - one down in kwindowsystem, - one in opengl / sandybridge - virtual machines and openGL behave erratic, depending on host system - Discussion on Wayland list about windecos going on - Bugtracker for immediate plasma bugs - Giorgos is working on plasmoidviewer - controls are starting to work (Location, Formfactor) - screenshot feature - js console can't be made to work until Qt 5.3 - filedialog styling problem, being worked on - resizing plasmoids is broken right now - email about features coming to plasma-devel - Ivan is working on QML models in dataengines - services and called functions unsolved at the moment, - could possibly be done with QFuture - Marco has worked on Blur contrast improvements - first patches up for review, likely to need improvements -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-shell startup problems
On Mon, Nov 18, 2013 at 2:25 PM, Ivan Čukić ivan.cu...@kde.org wrote: On Monday 18 November 2013 14:20:10 Harald Sitter wrote: On Mon, Nov 18, 2013 at 2:16 PM, Ivan Čukić ivan.cu...@gmail.com wrote: You are fast dude :) Can you do the following? qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities me@me-VirtualBox:~$ qdbus org.kde.ActivityManager /ActivityManager/Activities ListActivities 98f08df4-6d60-408f-bfaf-703002547224 :) That means I'm an idiot - should be fixed in master now (was asserting on something that should be false) Actually ... it is true now :P No clue why but after a reboot ListActivities isEmpty()==true, also I cannot make it fill up again, other than starting plasma-desktop. Randomly guessing I'd say that the plasma-shell init is not working as supposedly one would have at least one Activity (Desktop), except that appears to not be created ... reliably. HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma-shell startup problems
Actually ... it is true now :P Then, it is a bug :) No clue why but after a reboot ListActivities isEmpty()==true, also I cannot make it fill up again, other than starting plasma-desktop. Randomly guessing I'd say that the plasma-shell init is not working as supposedly one would have at least one Activity (Desktop), except that appears to not be created ... reliably. Are the activities missing from the service (the qdbus command from earlier) or only in plasma? Can you test when the activities disappear? (manually starting / stopping plasma and kactivitymanagerd and checking the kactivitymanagerdrc) Cheers -- There are no such things as applied sciences, only applications of science. -- Louis Pasteur ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Panel desktop scripting
On Saturday, November 16, 2013 20:10:13 Eike Hein wrote: Thoughts on a clean(er) fix? call flushPendingConstraintsEvents this kind of use case is exactly why it is a public slot :) -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/ --- Review request for Plasma. Repository: plasma-framework Description --- Stop using classes from kde4support: - KComponentData is deprecated, it will be using QCoreApplication::applicationName() and QCoreApplication::applicationVersion(). Of course this means that the existing shells will have to be ported. I have no problem with doing that port myself, if I'm told where to look into. - Drop usage of KLocale, ported to QLocale - Drop usage of KStandardDirs, ported to QStandardPaths - Drop usage of KIcon, ported to QIcon Furthermore, there's a module in src/declarativeimports/locale that IIUC exposes KLocale bindings to QML. A specific plan to port it should happen as well. Diffs - CMakeLists.txt a9da457 src/declarativeimports/core/tests/CMakeLists.txt da0dbc5 src/declarativeimports/core/tests/sortfiltermodeltest.cpp 93ffba4 src/declarativeimports/locale/CMakeLists.txt 6aecb84 src/declarativeimports/qtextracomponents/tests/CMakeLists.txt 2c64b7f src/plasma/CMakeLists.txt c227a15 src/plasma/private/dataenginemanager.cpp 1c235e0 src/shell/CMakeLists.txt c19dbd2 src/shell/activity.cpp 2523397 src/shell/scripting/appinterface.cpp 63196f9 src/shell/scripting/scriptengine.cpp 1250c20 src/shell/shellcorona.cpp 2519e29 Diff: http://git.reviewboard.kde.org/r/113920/diff/ Testing --- Builds, tests pass. I'm unsure what else to test. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113920: Remove KDE4Support dependency from plasma-frameworks (almost)
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113920/#review43907
---
src/shell/activity.cpp
http://git.reviewboard.kde.org/r/113920/#comment31532
QDir::separator() instead of QChar('/') here to avoid unixism.
src/shell/scripting/scriptengine.cpp
http://git.reviewboard.kde.org/r/113920/#comment31534
Also here, qApp-applicationName()?
src/shell/shellcorona.cpp
http://git.reviewboard.kde.org/r/113920/#comment31533
Shouldn't this rather be qApp-applicationName()?
- Sebastian Kügler
On Nov. 18, 2013, 5:17 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113920/
---
(Updated Nov. 18, 2013, 5:17 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
---
Stop using classes from kde4support:
- KComponentData is deprecated, it will be using
QCoreApplication::applicationName() and
QCoreApplication::applicationVersion(). Of course this means that the
existing shells will have to be ported. I have no problem with doing that
port myself, if I'm told where to look into.
- Drop usage of KLocale, ported to QLocale
- Drop usage of KStandardDirs, ported to QStandardPaths
- Drop usage of KIcon, ported to QIcon
Furthermore, there's a module in src/declarativeimports/locale that IIUC
exposes KLocale bindings to QML. A specific plan to port it should happen as
well.
Diffs
-
CMakeLists.txt a9da457
src/declarativeimports/core/tests/CMakeLists.txt da0dbc5
src/declarativeimports/core/tests/sortfiltermodeltest.cpp 93ffba4
src/declarativeimports/locale/CMakeLists.txt 6aecb84
src/declarativeimports/qtextracomponents/tests/CMakeLists.txt 2c64b7f
src/plasma/CMakeLists.txt c227a15
src/plasma/private/dataenginemanager.cpp 1c235e0
src/shell/CMakeLists.txt c19dbd2
src/shell/activity.cpp 2523397
src/shell/scripting/appinterface.cpp 63196f9
src/shell/scripting/scriptengine.cpp 1250c20
src/shell/shellcorona.cpp 2519e29
Diff: http://git.reviewboard.kde.org/r/113920/diff/
Testing
---
Builds, tests pass.
I'm unsure what else to test.
Thanks,
Aleix Pol Gonzalez
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
PIM Sprint (The bits relevant to Plasma)
To plasma-devel, CC'ing KDE PIM. Preparing for Plasma 2: - KDE PIM is currently used in kde-workspace for: - an Akonadi dataengine - showing events in the calendar (which was C++ without the dataengine in Plasma 1) - various runners - Tentative timeline for PIM: - Plan is to start porting to Qt5/Frameworks /after/ frameworks is done (so we may have a kdepimlibs-transitional in ~ 6months) - Components will then be split off and put into Frameworks one by one, under normal frameworks rules. - Proper notes will be on kde-pim ML soon. - Annoyingly (from a Plasma perspective) kcalcore is going to be one of the hardest (and therefore slowest) to port as it uses KDateTime a lot. (probably nearer to 12 months) - Given Plasma's release schedule plans, this may be problematic. We /could/ look at workarounds in which we have a dataengine that talks over DBus/a socket to a small Qt4 application with KDE PIM4libs. Shame to have to write throwaway code though. - Using PIM from Plasma: - Nothing in kde-workspace uses the Akonadi dataengine - Dataengine's aren't powerful enough for things like KMail Active - PIM want to make a QML import API - possibly for use in the desktop apps too - making use of PIM's entity tree model directly - There's no point having multiple ways to do the same thing - it will be better to have one API to rule them all, not tied to any UI, that anyone can use. Other discussions: - Can we make it so that loading the plasma clock/calendar doesn't start Akonadi if you don't use Akonadi? - According to Dan, the only way to check if anything is in Akonadi is to start Akonadi. Dan tends to know what he's talking about. - One discussion was to have a first run wizard which shows web accounts to raise awareness of PIM/super cool IM clients, over web applications (gmail + FB etc) [having a first run wizard] is Plasma's call, but if there is one, this is what we want to add - John Layt. - David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PIM Sprint (The bits relevant to Plasma)
On 18 November 2013 20:53, David Edmundson da...@davidedmundson.co.uk wrote: To plasma-devel, CC'ing KDE PIM. A few small clarifications, for more details see some initial documentation at http://community.kde.org/Frameworks/Epics/kdepimlibs Preparing for Plasma 2: - KDE PIM is currently used in kde-workspace for: - an Akonadi dataengine - showing events in the calendar (which was C++ without the dataengine in Plasma 1) - various runners There are 3 data engines and 2 runners which link to kdepimlibs. The Akonadi and RSS data engines are not used anywhere in the kde repos, only the Calendar Engine is used in the calendar plasmoid. The 2 runners are for contacts and events and link directly to kdepimlibs and not via the data engines. Full details are on the wiki. There was some discussion that KPeople would remove the need for the contacts runner to link to kdepimlibs? - Tentative timeline for PIM: - Plan is to start porting to Qt5/Frameworks /after/ frameworks is done (so we may have a kdepimlibs-transitional in ~ 6months) We're tentatively aiming to fork a frameworks branch in about 3 months once the KF5 split is done, then perhaps 3 months of basic Qt5/KF5 porting and re-arranging before we split, then each library will be released as it is ready over the following 6 months. We're reluctant to throw too many resources at it too soon that are needed to bug fix KDEPIM 4. - Annoyingly (from a Plasma perspective) kcalcore is going to be one of the hardest (and therefore slowest) to port as it uses KDateTime a lot. (probably nearer to 12 months) We'll be trying to prioritise the libraries used by Plasma, and it could be ready sooner, but we're very reluctant to give a time frame before anyone's had a look at it. The other main library used is KHolidays which will be available very quickly. - One discussion was to have a first run wizard which shows web accounts to raise awareness of PIM/super cool IM clients, over web applications (gmail + FB etc) [having a first run wizard] is Plasma's call, but if there is one, this is what we want to add - John Layt. The idea being that if the user didn't configure any calendars on first run, then we would know to disable events and so never wake Akonadi up. The alternative is that we ship with events turned off by default, which is what most distros do now. Cheers! John. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review43917 --- I'd rather not commit something like this that compares pointers when Nicolás has already pointed out that its very posible for addresses to be reused, maybe someone can do some work with the event accepted flag? If it's the same object we can just set it to accepted the first time and then ignore the others? - Albert Astals Cid On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Oct. 6, 2013, 7:36 p.m.) Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
On Oct. 31, 2013, 12:27 p.m., Kevin Funk wrote: Bump. Can we have this fixed soonish? Nicolas, can you push? Kevin Funk wrote: Bump again -- Without this fix, controlling volume in KMix via the mouse wheel is close to impossible. Can someone push? See https://bugs.kde.org/show_bug.cgi?id=316546#c21 - Nicolás --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review42747 --- On Oct. 6, 2013, 4:36 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Oct. 6, 2013, 4:36 p.m.) Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Panel desktop scripting
On Monday 18 November 2013 16:49:57 Aaron J. Seigo wrote: call flushPendingConstraintsEvents this kind of use case is exactly why it is a public slot :) Thanks, I missed that bit of API :) I've added the flush to the implementation of setLocation() in the scripting wrapper, and committed to KDE/4.11. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
On Oct. 31, 2013, 12:27 p.m., Kevin Funk wrote: Bump. Can we have this fixed soonish? Nicolas, can you push? Kevin Funk wrote: Bump again -- Without this fix, controlling volume in KMix via the mouse wheel is close to impossible. Can someone push? Nicolás Alvarez wrote: See https://bugs.kde.org/show_bug.cgi?id=316546#c21 It turns out the bug(s) I saw related to mouse click events happen even without this patch (I can't believe I didn't test that), so this patch doesn't make things any worse in that aspect, *and* it fixes the mouse wheel problem in KMix. Pushing now. - Nicolás --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/#review42747 --- On Oct. 6, 2013, 4:36 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Oct. 6, 2013, 4:36 p.m.) Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113124/ --- (Updated Nov. 18, 2013, 8:40 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 316546 http://bugs.kde.org/show_bug.cgi?id=316546 Repository: kde-runtime Description --- MouseEventListener: Don't process event from children multiple times. If an event passed through multiple visually-overlapping children of MouseEventListener, the event filter was processing the event every time. For example, this caused problems for the KMix icon in the tray, which would trigger volume changes three times for every mouse wheel event. BUG:316546 Diffs - plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 36530e075dc52348f32032c32457a090b904c3b9 Diff: http://git.reviewboard.kde.org/r/113124/diff/ Testing --- The KMix problem is gone, each mouse wheel step now changes the volume by the appropriate amount. Thanks, Nicolás Alvarez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
On Nov. 7, 2013, 12:19 a.m., Teemu Rytilahti wrote: I'm not actually sure whether is okay to force focus after any key is being released... Christoph Feck wrote: Bug 319935 is probably the same issue, and also contains a patch at comment #1 for the onReleased function, so it seems there is no other way to fix it. Teemu Rytilahti wrote: Yup, seems to be the same there, added to the list. Teemu, if there are no objections within the next three days, please commit it to 4.11 branch. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/#review43193 --- On Nov. 7, 2013, 12:27 a.m., Teemu Rytilahti wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113697/ --- (Updated Nov. 7, 2013, 12:27 a.m.) Review request for Plasma. Bugs: 314720, 316084, 319935, and 324821 http://bugs.kde.org/show_bug.cgi?id=314720 http://bugs.kde.org/show_bug.cgi?id=316084 http://bugs.kde.org/show_bug.cgi?id=319935 http://bugs.kde.org/show_bug.cgi?id=324821 Repository: kde-workspace Description --- The focus is being stolen from the input field when alt is being pressed in order to make it possible to use keyboard to do unlocking. Unfortunately this causes the focus never to be returned to the input field. This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 is also partially related. Diffs - ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 66a3bb4 Diff: http://git.reviewboard.kde.org/r/113697/diff/ Testing --- Tested on recent git installation. Thanks, Teemu Rytilahti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Panel desktop scripting
On Tuesday, November 19, 2013 00:06:11 Eike Hein wrote: On Monday 18 November 2013 16:49:57 Aaron J. Seigo wrote: call flushPendingConstraintsEvents this kind of use case is exactly why it is a public slot :) Thanks, I missed that bit of API :) i carefully hid it ;) I've added the flush to the implementation of setLocation() in the scripting wrapper, and committed to KDE/4.11. awesome :) the same fix is probably also needed in the Plasma2 desktop scripting. along with the additions for panel min/max size setting i made the other day as well. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
