Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote:
mediaelements/mediawelcome/HomeScreenFooter.qml, line 42
http://git.reviewboard.kde.org/r/114428/diff/2/?file=224654#file224654line42
The PMC time doesn't get synced with desktop time. Can you tune this
further to get it synced?
Also, this is the matter of #114429 . This review should only be about Text -
Label. Heena can you update the diff?
- Shantanu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---
On Dec. 13, 2013, 7:24 a.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 7:24 a.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- (Updated Dec. 13, 2013, 7:53 a.m.) Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to 1 but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
On Dec. 13, 2013, 2:40 a.m., Martin Gräßlin wrote: This looks like the wrong approach to me. The shadow gets installed by the widget style, but lancelot does not use a normal Qt style, but a Plasma style. Because of that it would need to use the plasma shadow (e.g. panel shadow). The idea of having the shadow being controlled by the style was to not use a generic shadow for any window as before, but to allow windows to use a shadow matching the window content. This would fall back to a generic approach. Please also add ivan to the review. I actually agree ... and I remember the time when almost all shadows in plasma are broken (4.10 last rc or sth like that?). What was the soluction at that time? Is the best solution copying the plasma shadow code to here again? - Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- (Updated Dec. 13, 2013, 7:53 a.m.) Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to 1 but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114429: use of time data engine - less code
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/#review45637
---
mediaelements/mediawelcome/CategoriesListDelegate.qml
http://git.reviewboard.kde.org/r/114429/#comment32598
if the component is not visible, then this shouldn't be a necessary change:
it just makes it more heavyweight.
the real problem here is using a visual item to store data at all.
apparently this is just to bind a value to an alias (currentCategory); i
would suggest tracking down where that is used and coming up with a different
solution
mediaelements/mediawelcome/HomeScreenFooter.qml
http://git.reviewboard.kde.org/r/114429/#comment32597
this is incorrect; if you are using a DataEngine with an interval, then you
let the DataEngine update you.
so the Timer here should just go away and the label with the text should be
bound to the results of the DataSource.
- Aaron J. Seigo
On Dec. 13, 2013, 7:07 a.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/
---
(Updated Dec. 13, 2013, 7:07 a.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text{} by Label {}
Time Data engine instead of creating Date() and hours - less code !
text color is predefined in Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114429/diff/
Testing
---
yeah ,works fine ,displays days as well now.
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: activities and scripting
neat. 2013/12/12 Aaron J. Seigo ase...@kde.org: On Monday, December 9, 2013 14:09:40 Nowardev-Team wrote: and when you get the whole desktop filled by the png file you get a wrong resolution in a series of commits today, all the issues noted are resolve in the KDE/4.11 branch of kde-workspace. there is 0d905f02297db568af19d4a07a09fd3b7e556285 in libs/plasmagenericshell/scripting which fixes an issue where the repaint requests from the wallpaper were not making it to Plasma::Applet due to the order of initialization. this was the main problem for this issue. meanwhile in the image plugin there were also the following commits which provide various cleanups and some significant performance improvements: 393b77f9fe5c1685c61cf71e29d04743eca82a2d d240a694e8a8d99f915bc7858aa9877d55d250e9 be3869e93b38d7b0dfb17892b84ed69ae5e91441 637e11259552b4fd34078d16ca8b814bad48d22e 547c5694a1acb7a503730cc3a545d1269054906e e7d6fef977bc123acad5d257ef0eb31a977987b4 now on startup and esp at new activity creation reading in and rendering of incorrectly sized wallpapers (because the size changes almost immediately after that) is now skipped. delayed init of some heavyweight objects also occurs, making startup a little bit faster and less memory usage in the common case (SingleImage). also, the animation to switch between wallpapers was tweaked to feel more swift and pretty. for the Plasma 2 version of the image wallpaper plugin, i’m guessing it probably could use similar work. the fix in the scripting should not be needed for Plasma 2, however. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114429: use of time data engine - less code
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/
---
(Updated Dec. 13, 2013, 2:11 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Changes
---
time is now synced :-)
Repository: plasma-mediacenter
Description
---
Replaced Text{} by Label {}
Time Data engine instead of creating Date() and hours - less code !
text color is predefined in Label {}
Diffs (updated)
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114429/diff/
Testing
---
yeah ,works fine ,displays days as well now.
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 2:20 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs (updated)
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote:
Synced with desktop time now :-)
- Heena
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---
On Dec. 13, 2013, 2:20 p.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 2:20 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114429: use of time data engine - less code
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/
---
(Updated Dec. 13, 2013, 2:57 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text{} by Label {}
Time Data engine instead of creating Date() and hours - less code !
text color is predefined in Label {}
Diffs (updated)
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
Diff: http://git.reviewboard.kde.org/r/114429/diff/
Testing
---
yeah ,works fine ,displays days as well now.
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114429: use of time data engine - less code
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/
---
(Updated Dec. 13, 2013, 3:01 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text{} by Label {}
Time Data engine instead of creating Date() and hours - less code !
text color is predefined in Label {}
Diffs (updated)
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
Diff: http://git.reviewboard.kde.org/r/114429/diff/
Testing
---
yeah ,works fine ,displays days as well now.
File Attachments
screenshot
http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/dfae9d60-ef6f-4562-a7e3-8f6c0d97a99e__pmc1.png
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45662
---
Ship it!
Ship It!
- Shantanu Tushar
On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 3:05 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
