Review Request 115990: Follow Qt's OpenGL compile flags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/ --- Review request for Plasma. Repository: plasma-framework Description --- Follow Qt's OpenGL compile flags Only link against OpenGL if Qt links against OpenGL. This ensures that we don't run into issues if Qt links GLES and plasma links GL because that's found. Diffs - CMakeLists.txt a1b39f09540984307ca1a6ad02aa388a0f3207ba src/declarativeimports/core/CMakeLists.txt dadd350f54972b7f3d56b1d4b931373a3f3e2696 Diff: https://git.reviewboard.kde.org/r/115990/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Problems in building
Awesome, can you share how you fixed it? Will help if someone else has the same issues in the future. On Mon, Feb 24, 2014 at 12:50 PM, Devanshu Jain devanshu.jain...@gmail.comwrote: i got it solved. thanks! On Mon, Feb 24, 2014 at 12:40 PM, Shantanu Tushar Jha shant...@kde.orgwrote: Hi Devanshu, Did you get the problem solved or does it still exist? Cheers, On Sun, Feb 23, 2014 at 12:36 PM, Sinny Kumari ksi...@gmail.com wrote: On Sun, Feb 23, 2014 at 12:28 PM, Devanshu Jain devanshu.jain...@gmail.com wrote: Hi! I am using Kubuntu 13.10. But, I don't understand the 3rd question! I was referring to git. You can check which branch currently you are on by running git branch command inside a git project. Since, Plasma Media Center uses git version control system, you can check there too. Anyway, mostly you would be on master branch. In case you are attending conf.kde.in conference, please meet me during break so that I can help you faster else I will reply to this email regarding what you need to do On Sun, Feb 23, 2014 at 10:55 AM, Sinny Kumari ksi...@gmail.comwrote: Hey, In order to know what is the reason of failing build, I need few information: 1. What distribution you are using ? 2. Which version of your distribution? 3. Are you building master or some other branch? Thanks On Sat, Feb 22, 2014 at 11:51 PM, Devanshu Jain devanshu.jain...@gmail.com wrote: Hi! I was going through the build instructions for plasma media center and am finding some trouble in doing so. The make instruction is throwing some errors. /*- [ 1%] Built target plasmamediacenter_automoc [ 1%] Building CXX object libs/mediacenter/CMakeFiles/plasmamediacenter.dir/plasmamediacenter_automoc.o In file included from /home/devanshu/kde/pmc/plasma-mediacenter/build/libs/mediacenter/../../../libs/mediacenter/mediacenter_export.h:24:0, from /home/devanshu/kde/pmc/plasma-mediacenter/build/libs/mediacenter/../../../libs/mediacenter/playlistmodel.h:26, from /home/devanshu/kde/pmc/plasma-mediacenter/build/libs/mediacenter/moc_playlistmodel.cpp:9, from /home/devanshu/kde/pmc/plasma-mediacenter/build/libs/mediacenter/plasmamediacenter_automoc.cpp:4: /usr/include/kpluginfactory.h:263:5: error: 'Q_DECL_CONSTRUCTOR_DEPRECATED' does not name a type KDE_CONSTRUCTOR_DEPRECATED explicit KPluginFactory(const KAboutData *aboutData, QObject *parent = 0); ^ /usr/include/kpluginfactory.h:270:14: error: 'Q_DECL_CONSTRUCTOR_DEPRECATED' does not name a type explicit KDE_CONSTRUCTOR_DEPRECATED KPluginFactory(QObject *parent); ^ make[2]: *** [libs/mediacenter/CMakeFiles/plasmamediacenter.dir/plasmamediacenter_automoc.o] Error 1 make[1]: *** [libs/mediacenter/CMakeFiles/plasmamediacenter.dir/all] Error 2 make: *** [all] Error 2 /--- It would be really helpful, if somebody could help me, how to solve this issue. Thanks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- http://www.sinny.in ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- http://www.sinny.in ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115990: Follow Qt's OpenGL compile flags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/#review50639 --- Ship it! Ship It! - Marco Martin On Feb. 24, 2014, 8:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/ --- (Updated Feb. 24, 2014, 8:45 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Follow Qt's OpenGL compile flags Only link against OpenGL if Qt links against OpenGL. This ensures that we don't run into issues if Qt links GLES and plasma links GL because that's found. Diffs - CMakeLists.txt a1b39f09540984307ca1a6ad02aa388a0f3207ba src/declarativeimports/core/CMakeLists.txt dadd350f54972b7f3d56b1d4b931373a3f3e2696 Diff: https://git.reviewboard.kde.org/r/115990/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115910: Screenedge show support for Clients
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115910/ --- (Updated Feb. 24, 2014, 11:16 a.m.) Review request for kwin and Plasma. Changes --- Ensured that multiple clients do not trigger at the same time at an edge. This is achieved by updating the trigger time and trigger pos for each edge with a Client once we have found an edge which triggers for a Client. Thus the next check on time and/or position will just fail and we have the normal reactivation treshhold for the edge. Repository: kde-workspace Description --- Screenedge show support for Clients This provides a new protocol intended to be used by auto-hiding panels to make use of the centralized screen edges. To use it a Client can set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin. As value it takes: * 0: top edge * 1: right edge * 2: bottom edge * 3: left edge KWin will hide the Client (hide because unmap or minimize would break it) and create an Edge. If that Edge gets triggered the Client is shown again and the property gets deleted. If the Client doesn't border the specified screen edge the Client gets shown immediately so that we never end in a situation that we cannot unhide the auto-hidden panel again. The exact process is described in the documentation of ScreenEdges. The Client can request to be shown again by deleting the property. If KWin gets restarted the state is read from the property and it is tried to create the edge as described. As this is a KWin specific extension we need to discuss what it means for Clients using this feature with other WMs: it does nothing. As the Client gets hidden by KWin and not by the Client, it just doesn't get hidden if the WM doesn't provide the feature. In case of an auto-hiding panel this seems like a good solution given that we don't want to hide it if we cannot unhide it. Of course there's the option for the Client to provide that feature itself and if that's wanted we would need to announce the feature in the _NET_SUPPORTED atom. At the moment that doesn't sound like being needed as Plasma doesn't want to provide an own implementation. The implementation comes with a small test application showing how the feature is intended to be used. Diffs (updated) - kwin/atoms.h 1690067c5d1da59f38f9e77ef64eacfbc1faa0cf kwin/atoms.cpp 904f5efe4a32e3673dae9e6da92bf4336def660d kwin/client.h 6a0dbe4f45f9bb6c58de8c045488cec990e95118 kwin/client.cpp 36431bfc33418a207de12fa8cc95a35539256366 kwin/events.cpp 1fa6e425d4dac7d661612e5d090c3c9c8f4b1a18 kwin/manage.cpp 3e385cd6aeceee3c3bff4e09be2aee130856201f kwin/screenedge.h 60f5fd669ccc5eb627feffa460552558d1765b31 kwin/screenedge.cpp 04cf0d6d5262ab84d88559b6dc85e099efec77bf kwin/tests/CMakeLists.txt 3fa16f21c617a8f4b39b2bbd39b534b6a11e8d14 kwin/tests/screenedgeshowtest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115910/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115990: Follow Qt's OpenGL compile flags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/ --- (Updated Feb. 24, 2014, 10:40 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Follow Qt's OpenGL compile flags Only link against OpenGL if Qt links against OpenGL. This ensures that we don't run into issues if Qt links GLES and plasma links GL because that's found. Diffs - CMakeLists.txt a1b39f09540984307ca1a6ad02aa388a0f3207ba src/declarativeimports/core/CMakeLists.txt dadd350f54972b7f3d56b1d4b931373a3f3e2696 Diff: https://git.reviewboard.kde.org/r/115990/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115990: Follow Qt's OpenGL compile flags
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/#review50688 --- This review has been submitted with commit 1249e5bfc15d525a04cb2b588c34bbca42472ae4 by Martin Gräßlin to branch master. - Commit Hook On Feb. 24, 2014, 8:45 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115990/ --- (Updated Feb. 24, 2014, 8:45 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Follow Qt's OpenGL compile flags Only link against OpenGL if Qt links against OpenGL. This ensures that we don't run into issues if Qt links GLES and plasma links GL because that's found. Diffs - CMakeLists.txt a1b39f09540984307ca1a6ad02aa388a0f3207ba src/declarativeimports/core/CMakeLists.txt dadd350f54972b7f3d56b1d4b931373a3f3e2696 Diff: https://git.reviewboard.kde.org/r/115990/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem
On Monday 24 February 2014, Marco Martin wrote: here the main problem seems that is broken the rendering of a single svg element. so for things like the expander arrows in the taskbar, the whole svg is rendered and the sizes of the items seems also to be reported incorrectly (so for instance my panel toolbox isn't usable because has size 0 that's what's happening in native_render_frame (note the dolphin entry) http://wstaw.org/m/2014/02/24/plasma-desktopQt1685.png does anybody encountered it as well? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem
On Feb. 21, 2014, 11:18 p.m., Sebastian Kügler wrote: I've run your native_render_frame branch for a bit, some observations on my system: - It mostly works - taskbar doesn't find some elements in the svg, leading to lots of messages like this: plasma_shell(11872)/default QSvgTinyDocument::draw: Couldn't find node normalbottomright. Skipping rendering. - we seem to be hitting a few slow code pathes, which mean that I'm getting some smaller and longer freezes - memory usage has gone up quite a bit, from 178MB to 328MB - I'm seeing lots of threads of plasma-shell in ps I like the idea, though, and I think those issues are something that can be sorted out. Looking at the code, it looks pretty clean so far, so nice work! Aye, it turns out there's a reason Plasma::FrameSVG is really big; and I'm basically recreating the most complex method inside that branch. Note that branch contains a lot more stuff than that's in this review. I need to fold back the things I've improved/learned from this review into that frame branch. I'm going to try to IconItem next I think, it's less menacing, but contains an animation which is exciting. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review50494 --- On Feb. 21, 2014, 3:32 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 21, 2014, 3:32 p.m.) Review request for Plasma. Repository: plasma-framework Description --- The rationale behind this patch is on the mailing list in the thread Minutes Monday This doesn't boost performance or save memory much, but it paves the way for texture sharing, faster resizing, and plenty of other things. Based on Frederick's comment I have reverted my changes to use QImage everywhere, otherwise we lose out on the local QPixmap cache in KImageCache. Changes to plasmacore are minimal. I'm currently porting FrameSVG which is where we should see more gains, but I thought I should get this reviewed/merged in parallel. I have only seen one regression which is in the analog clock. Some odd code in the analog clock (by me apparently!) means the width is dependent on the current width, which due to some changes in this patch ends up in a constant spiral getting to infinitely sized and explode. Changelog (in reverse order): Remove manual isDirty tracking in SvgItem Always resize the node geometry on resizes Update to paint to fill the size of the object, not the size of texture Fix leaking texture Add convenient QImage image() getter in SVG Avoid repainting if node is not changed Render SvgItem natively rather than going through QQuickPaintedItem Diffs - src/declarativeimports/core/svgitem.h c8be7cc src/declarativeimports/core/svgitem.cpp e90751a src/plasma/svg.h 01d98f8 src/plasma/svg.cpp 9ec2aa5 Diff: https://git.reviewboard.kde.org/r/115923/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Minutes Monday Plasma hangout
Minutes Monday Meeting 24.2.2014 Present: Antonis Tsiapaliokas, David Edmundson, Giorgos Tsiapaliokas, Ivan Cukic, Marco Martin, Martin Gräßlin, Jens Reuterberg, Sebastian Kügler Antonis: - Merged branch of Plasmoidviewer into frameworks branch - Has work on the startpage up his sleeve David: - Will followup by email Giorgos - Freed plasmate from KDE4Support Ivan: - Worked on issues rgd. threading in KAMD - Issue w/ activitie switching hanging in ksmserver (?) - Working on switcher, plan to ready left bar for first release - Working on getting wallpaper previews in Activity Manager Jens: - Work on new theming is going - Some issues wrt workflow need discussing Marco: - Worked towards finishing panel management: - resizing and restoring works with different settings - panel controller widget - Needs integration with new screenedges for autohode - Some more work on hi-dpi branch shadows above panel during hiding Martin K: - worked on notifications positioning - created KWindowSystem declarative plugin (will finish next) - Frameworks Alpha 2 is looming: to finish KNotifications framework - To work on OSD after Martin G: - Worked on statusnotifieritem support in Qt (Qt 5.4 material) - Ported KInfoCenter, - added Wayland module to KInfoCenter - Fixed appmenu for Qt4 (broken for Qt5) - Wants to remove Motif hints from NETWM implementation Sebastian - Fixed flickering in kwin effects icm backgound contrast effect - Fixed flickering in slidingpopups animation - Fixed Kickoff: - search bar, - search now returns results - ported locations, places and services runner (all confirmed working) - ported bookmarks partly (WIP, chromium bookmarks missing right now) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma hangout
I've been working on: https://git.reviewboard.kde.org/r/115923/ which as far as I know is now done. Next up (in planned chronological order): - IconItem - Frames - Sharing QSGTexture objects David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- Review request for Plasma. Summary (updated) - Port IconItem to native QSGTexture Repository: plasma-framework Description (updated) --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs (updated) - src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing (updated) --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review50716 --- I haven't runtime-tested it yet, but this is something I was hoping we'd get around to doing, and from what I can see the chosen approach seems sound. Yay! - Eike Hein On Feb. 24, 2014, 4:09 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 24, 2014, 4:09 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma hangout
On Monday 24 February 2014, Sebastian Kügler wrote: Marco: - Worked towards finishing panel management: - resizing and restoring works with different settings - panel controller widget - Needs integration with new screenedges for autohode - Some more work on hi-dpi branch shadows above panel during hiding ah, i forgotted a point i worked on: - now the slideshow wallpaper is done -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review50720 --- not sure how much will be visible in the end result. tough if i understood correctly how it works, it does the animation by animating the opacity of the old image from 1 to 0, and the opacity of the new one from 0 to 1. This is not the same thing as a crossfade, that's what it was doing. I fear it will be visible the opacity of the whole result go down and then up again, especially when animating with an highlight effect (that is the same icon) - Marco Martin On Feb. 24, 2014, 4:09 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 24, 2014, 4:09 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
On Feb. 24, 2014, 4:55 p.m., Marco Martin wrote: not sure how much will be visible in the end result. tough if i understood correctly how it works, it does the animation by animating the opacity of the old image from 1 to 0, and the opacity of the new one from 0 to 1. This is not the same thing as a crossfade, that's what it was doing. I fear it will be visible the opacity of the whole result go down and then up again, especially when animating with an highlight effect (that is the same icon) I think it should be possible to keep that behaviour, with something like this patch. I would need to create a QSGMaterialShader then copy and paste the relevant fragmentShader from qtgraphicseffects. I can then put the shader directly on my texture, rather than needing the extra node. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review50720 --- On Feb. 24, 2014, 4:09 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 24, 2014, 4:09 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116027: High dpi support for Svg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116027/ --- Review request for Plasma. Repository: plasma-framework Description --- This gives support in Svg for devicePixelRatio, just exposed in the api from Svg side. on the component side, it sets the devicepixelratio of the svg and framesvg with units. devicepixelratio is always set integer in the svg, so needs at least 192dpi to double up. (it needs to be integer to have lines contained inside a svg piece to keep being pixel aligned) Diffs - src/declarativeimports/core/framesvgitem.h e348c4c src/declarativeimports/core/framesvgitem.cpp 1826d88 src/declarativeimports/core/svgitem.h c8be7cc src/declarativeimports/core/svgitem.cpp e90751a src/declarativeimports/plasmacomponents/qml/ToolButton.qml 2319879 src/plasma/framesvg.h 482956d src/plasma/framesvg.cpp 9e1a53e src/plasma/private/framesvg_p.h 1bbc744 src/plasma/private/svg_p.h 332efda src/plasma/svg.h 01d98f8 src/plasma/svg.cpp 9ec2aa5 Diff: https://git.reviewboard.kde.org/r/116027/diff/ Testing --- unfortunately i can only test by hardcoding different values and check if the layout of the widgets stays correct, and is fine, it would be needed somebody with a retina screen to see it really in action Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116032/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The media window was stopping on the last frame of the video whenever a video was played from the local drive. Ideally it should go back to the last video listing window at the completion of the video-play. This has been implemented now. Diffs - shells/newshell/package/contents/ui/mediacenter.qml b6cb87c Diff: https://git.reviewboard.kde.org/r/116032/diff/ Testing --- Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116032/ --- (Updated Feb. 24, 2014, 10:29 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- The media window was stopping on the last frame of the video whenever a video was played from the local drive. Ideally it should go back to the last video listing window at the completion of the video-play. This has been implemented now. Diffs - shells/newshell/package/contents/ui/mediacenter.qml b6cb87c Diff: https://git.reviewboard.kde.org/r/116032/diff/ Testing (updated) --- It has been tested on multiple machines, and through commandline also. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ideas Critical to PMC
This is not exactly a critical idea, but I would like the opinion of people working in this project before deciding upon it's implementation. Does the Plasma Media Center needs to have changing backgrounds? We can implement it as an option (user-select) in the settings menu. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.comwrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ideas Critical to PMC
Hi Harish, We did discuss some ideas and will be putting it on the ideas list asap. Feel free to propose your ideas as well :) On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.comwrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)
Hi Harshit, First of all, just a note, whenever you have a new thing to discuss, it is a bad idea to reply to an existing thread which is not directly related (this is popularly known as hacking others' threads :P) To the topic, I personally don't think it is a good idea to let the user change the background of the media center. The rationale behind this is that the background is part of our UI so changing it can lead to visual inconsistency. I'll love to hear from others' views on this, especially our Usability folks. Cheers, On Tue, Feb 25, 2014 at 4:21 AM, Harshit Agarwal see.hars...@gmail.comwrote: This is not exactly a critical idea, but I would like the opinion of people working in this project before deciding upon it's implementation. Does the Plasma Media Center needs to have changing backgrounds? We can implement it as an option (user-select) in the settings menu. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.comwrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)
Apologies. I wasn't aware of the thread hacking act. My rationale behind changing the background is to enable the user to customize the Media Center to his/her own will. If they see something which is customized as their own, they would automatically spend more time on it, thus using and depending upon it's features more. A better alternative for achieving the same goal is most welcome! Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 10:48 AM, Shantanu Tushar Jha shant...@kde.orgwrote: Hi Harshit, First of all, just a note, whenever you have a new thing to discuss, it is a bad idea to reply to an existing thread which is not directly related (this is popularly known as hacking others' threads :P) To the topic, I personally don't think it is a good idea to let the user change the background of the media center. The rationale behind this is that the background is part of our UI so changing it can lead to visual inconsistency. I'll love to hear from others' views on this, especially our Usability folks. Cheers, On Tue, Feb 25, 2014 at 4:21 AM, Harshit Agarwal see.hars...@gmail.comwrote: This is not exactly a critical idea, but I would like the opinion of people working in this project before deciding upon it's implementation. Does the Plasma Media Center needs to have changing backgrounds? We can implement it as an option (user-select) in the settings menu. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Tue, Feb 25, 2014 at 12:07 AM, R.Harish Navnit harishnav...@gmail.com wrote: Hello all, I was unfortunate not to be there with you all for the conf.kde.in, which as I've been hearing was a huge success. I feel really gutted about the same. I'd have so dearly loved to have attended a few workshops on programming with Qt and KDE API's(if there were any). But another important thing that was mentioned to me was that during the conf.kde.in the ideas critical to PMC would be mentioned. I hope that there has been some resolution on the same. I'm starting this thread, hoping to hear some of the ideas that you may have. It'd be great if someone could spread some light on the current scenario on regarding the same. Maybe the next critical Idea stems from this thread :) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
