Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115657/#review51004 --- This review has been submitted with commit ff7760fc1291d0f5f479f66d76b86de928b7bd1d by Martin Gräßlin to branch master. - Commit Hook On Feb. 11, 2014, 1:23 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115657/ --- (Updated Feb. 11, 2014, 1:23 p.m.) Review request for Plasma. Repository: kde-workspace Description --- Ensure kcm cursor doesn't crash when started on Wayland Unfortunately this means at the moment that it doesn't list any cursor themes at all as the only available cursor theme backend is XCursor based. But the app design should allow to implement a Wayland backend without the need of large redesign. Diffs - kcontrol/input/xcursor/themepage.cpp 6610ef299a545dcff7fc5e38d137f3bbca81954d kcontrol/input/xcursor/thememodel.cpp 9f86fc910dafb445449c01bc9980eec92708cb84 Diff: https://git.reviewboard.kde.org/r/115657/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115657: Ensure kcm cursor doesn't crash when started on Wayland
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115657/ --- (Updated Feb. 27, 2014, 9:31 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kde-workspace Description --- Ensure kcm cursor doesn't crash when started on Wayland Unfortunately this means at the moment that it doesn't list any cursor themes at all as the only available cursor theme backend is XCursor based. But the app design should allow to implement a Wayland backend without the need of large redesign. Diffs - kcontrol/input/xcursor/themepage.cpp 6610ef299a545dcff7fc5e38d137f3bbca81954d kcontrol/input/xcursor/thememodel.cpp 9f86fc910dafb445449c01bc9980eec92708cb84 Diff: https://git.reviewboard.kde.org/r/115657/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Review Request 116076: Hide the OnAllDesktops button if there is only one virtual desktop
On Wednesday 26 February 2014 16:42:56 Thomas Lübking wrote: On Mittwoch, 26. Februar 2014 16:27:47 CEST, Hugo Pereira Da Costa wrote: Note: a disable state could be quite easily added to oxygen. I would reuse the same appearance as for inactive windows, except that the button would stay 'inactive' even for active windows, and would of course not highlight on mouse-over. That's quite easy to implement, also. What do you think ? It's been one of the major religious wars about titlebars: what to do with (temporarily) unsupported buttons. Personally, i LARGELY favor the approach where the button layout remains the same and a unusable button (cannot eg. maximize/minimize) is simply represented deactivated, but KDE has by default always done different (more like Windows, less like MacOS) Arguments are that there's no point in crowding the titlebar with a UI element that will likely never activate and on the other hand the stable layout is more reliable for the user (the outer right button is always maximize and not suddenly close) I'm extending the discussion to the complete desktop to get some further ideas on whether we should change the behavior in 5.0. For the Plasma devs: if a window is not closeable (or minimizeable or whatever) KWin is currently hiding the button. The alternative would be to have it always present but disabled if the action is not available. Personally I think it's highly questionable that we remove the buttons as that means the UI is inconsistent. On some windows there is one, on others there is none which can result in incorrect clicks and unexpected behavior. It's also very uncommon with respect to other elements. We don't hide the Apply button if there is nothing to Apply, instead we deactivate it. So IMHO we should use the chance of the major release and change our behavior to not hide the buttons but disable them with the exception of the help button which would just clutter the UI. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
PMC crashes when running for the first time
Hello all, I'm facing this issue in starting/running the PMC in Kubuntu 13.10. Every time I open the PMC it leads to a crash reporter. I'm posting the error log here : http://paste.kde.org/plys8qlsv and http://paste.kde.org/potuefig3 I don't quite understand what's happening over here. I'd be grateful if someone could help me with this issue. Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 27, 2014, 12:19 p.m.) Review request for Plasma. Changes --- Perform the animation as a fragment shader. I've done it as a separate class because I know Eike wants to fade between prefixes in FrameSVG. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs (updated) - CMakeLists.txt 4bc47bf src/declarativeimports/core/CMakeLists.txt 97e9283 src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
It means that OpenGL won't work for you (GLX), so try plasma-mediacenter --disable-opengl On Thu, Feb 27, 2014 at 5:47 PM, R.Harish Navnit harishnav...@gmail.comwrote: Hello all, I'm facing this issue in starting/running the PMC in Kubuntu 13.10. Every time I open the PMC it leads to a crash reporter. I'm posting the error log here : http://paste.kde.org/plys8qlsv and http://paste.kde.org/potuefig3 I don't quite understand what's happening over here. I'd be grateful if someone could help me with this issue. Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 27, 2014, 1:44 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs (updated) - CMakeLists.txt 4bc47bf src/declarativeimports/core/CMakeLists.txt 97e9283 src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
On Thu, Feb 27, 2014 at 6:27 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: It means that OpenGL won't work for you (GLX), so try plasma-mediacenter --disable-opengl Oh my Goodness ! It worked :) But running without OpenGL everytime won't be an issue right ? Moreover why has it stopped working now all of a sudden ? It was working till I faced the issue of an infinite login loop. Thanks a lot :) Warm Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
Its not a big issue, just that the graphics/animations might be laggy. About it stopping to work all of a sudden, how would I know? It would've mostly been due to something you did (or maybe a rat chewed up your graphics card) ;) On Thu, Feb 27, 2014 at 7:20 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Thu, Feb 27, 2014 at 6:27 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: It means that OpenGL won't work for you (GLX), so try plasma-mediacenter --disable-opengl Oh my Goodness ! It worked :) But running without OpenGL everytime won't be an issue right ? Moreover why has it stopped working now all of a sudden ? It was working till I faced the issue of an infinite login loop. Thanks a lot :) Warm Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
Hey, On Thu, Feb 27, 2014 at 8:13 PM, Shantanu Tushar Jha shaan...@gmail.com wrote: Its not a big issue, just that the graphics/animations might be laggy. About it stopping to work all of a sudden, how would I know? It would've mostly been due to something you did (or maybe a rat chewed up your graphics card) ;) Are you loading into fallback session from lightdm? or normal Plasma Workspace session? -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
On Thu, Feb 27, 2014 at 8:17 PM, Bhushan Shah bhus...@gmail.com wrote: Are you loading into fallback session from lightdm? or normal Plasma Workspace session? I no longer use lightdm. I installed kdm and it worked out for me :) I don't think it's going to the fallback session. I am able to use the plasma-workspace without any issue minus the one mentioned in this thread :\ R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: PMC crashes when running for the first time
On Thu, Feb 27, 2014 at 8:13 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: Its not a big issue, just that the graphics/animations might be laggy. About it stopping to work all of a sudden, how would I know? It would've mostly been due to something you did (or maybe a rat chewed up your graphics card) ; Well, That explains it all ! Thanks ;) Warm Regards. Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Issues with PMC
Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
Multiple additions should have happened. Okay i'll look into it. Thanks for informing! Kudos for correcting the clock! :) Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 12:48 AM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.com wrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
*Should not Apologies. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 1:17 AM, Harshit Agarwal see.hars...@gmail.comwrote: Multiple additions should have happened. Okay i'll look into it. Thanks for informing! Kudos for correcting the clock! :) Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Fri, Feb 28, 2014 at 12:48 AM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.com wrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review51129 --- src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment35847 Despite my code being clearly right this doesn't work. (according to apitrace and then qDebug) oldState is always 0 This means we are binding textures every frame, which is what we wanted to avoid. I'm quite confused as to why. - David Edmundson On Feb. 27, 2014, 1:44 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 27, 2014, 1:44 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - CMakeLists.txt 4bc47bf src/declarativeimports/core/CMakeLists.txt 97e9283 src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
On Feb. 27, 2014, 8:17 p.m., David Edmundson wrote: src/declarativeimports/core/fadingnode.cpp, line 85 https://git.reviewboard.kde.org/r/116024/diff/3/?file=246683#file246683line85 Despite my code being clearly right this doesn't work. (according to apitrace and then qDebug) oldState is always 0 This means we are binding textures every frame, which is what we wanted to avoid. I'm quite confused as to why. I understand it now (I think) If I have 2 icons, I will have 2 materials, but still only 1 shader. oldState is used so that when SG batches operations I don't have to update all my uniforms if properties are the same between different materials being rendered in different nodes. It is not the previous state of the current material being updated. Sorry for the noise. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review51129 --- On Feb. 27, 2014, 1:44 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated Feb. 27, 2014, 1:44 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - CMakeLists.txt 4bc47bf src/declarativeimports/core/CMakeLists.txt 97e9283 src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 26ee410 src/declarativeimports/core/iconitem.cpp fed2f9b Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Issues with PMC
On Fri, Feb 28, 2014 at 12:48 AM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi Harshit, Thanks for the guidance while going through this i observed two more thing that is after creating playlist if you browse music and click on '+' sign on a thumbnail of a song multiple times it is adding same song multiple time in playlist. Its a feature, not a defect ;) i tried to figure it out in source code but no luck. And the clock in footer shows 0:00AM in mid-night instead of 12:00AM that i figured out and solved. --- Thanks Regards Maulik Kotadia On Thu, Feb 27, 2014 at 11:57 PM, Harshit Agarwal see.hars...@gmail.comwrote: Please check inline. Regards, Harshit Agarwal. 3rd Year, Computer Science and Engineering, National Institute of Technology, Durgapur. Ph. No.: +91-8942031165 On Thu, Feb 27, 2014 at 11:34 PM, Maulik Kotadia maulikkota...@gmail.com wrote: Hi All, I'm facing several issues with application *[1]* same issue faced by Harish. whenever i try to close the application it opens up the crash reporter. i tried disabling opengl but it didn't help.my backtrace is on http://paste.kde.org/pbzs8fdjw *[2] *-Opened the application - Browse Music - Selected music folder - clicked on Play All but it didn't play anything On selecting Play All, the application adds all the files to the playlist, but the autorun option from the first song doesn't seem to work. I'll be working on fixing this soon. You would have to go to the playlist, select the first song, and then it works fine as excepted. *[3]* After browsing music i played one song and then clicked on forward button that also didn't work giving this error in console On playing one song it treats is as a separate instance and not as the playlist. Therefore the playlist that you created earlier won't work in this case. * file:///usr/share/kde4/apps/plasma/packages/org.kde.plasma.mediacenter/contents/ui/mediacenter.qml:90: TypeError: Result of expression 'playlistInstance' [null] is not an object.* --- Thanks Regards *Maulik Kotadia * ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- --- Thanks Regards *Maulik Kotadia * Mail to : maulikkota...@gmail.com Conatct : +91-972-768-6244 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/#review51289 --- However I am not sure why we have formatting logic in the application? Can't we use Qt.formatDateTime or others? @Shaan7 ? mediaelements/mediawelcome/HomeScreenFooter.qml https://git.reviewboard.kde.org/r/116460/#comment36121 Remove White space here and at other parts. For future if you are using Kate, Set Settings Configure Kate Open/Save Remove trailing spaces to on modified lines. - Bhushan Shah On Feb. 28, 2014, 2:42 a.m., Maulik Kotadia wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ --- (Updated Feb. 28, 2014, 2:42 a.m.) Review request for Plasma, R.Harish Navnit, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- The footer clock in PMC is set to 12Hr format and it was showing 0:00 AM instead of 12:00 AM Diffs - mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 Diff: https://git.reviewboard.kde.org/r/116460/diff/ Testing --- I've tested the diff and its working correctly Thanks, Maulik Kotadia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
