KActivities/master is now KF5/Qt5
Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so I'm CC-ing him even though he is a member of every list I'm sending this to :) ) The only things left to do are (I'm looking at Ben or Albert with hope in my eyes): - update kde:kde-build-metadata - I don't dare to do this myself. It should use KDE/4.13 branch for Qt4, and master for Qt5. - blacklist and delete the frameworks branch Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Selecting wallpaper during Activity creation
I've not seen much of Plasma Active but that idea certainly does look sensible. It's the first thing I change when I make an activity, as it's one of the easiest ways to tell activities apart. Our current inline editing of the activity name and icon could certainly be improved; being a larger more in your face dialog will make everything less cramped and allow us to put in some labels explain the config a lot better. From the technical side, the wallpaper config comes from a plugin system anyway, so adding it here wouldn't duplicate much code. The containment exists at the point where you're editing an activity even for a new activity, but right now I don't think the activity manager UI can access it. Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Selecting wallpaper during Activity creation
On Friday 28 February 2014 13:22:59 David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. one thing is that it would pretty much require to use the wallpaper config dialog (both for technical reasons and because having another ui for the same thing-evil) don't know, maybe just opening the containment config automatically with a random wallpaper preselected.. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Selecting wallpaper during Activity creation
On 28.02.2014 13:22, David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. Good point, though in Plasma Active, from what I've learned from watching people use it, this does not happen. There are other factors which certainly influence the perception of Activities in Plasma Active more than the creation dialog (the example Activity with all sorts of stuff in it, the big Add Items button which allows to link all kinds of stuff to it, ...), but overall, people get pretty quickly that Activities are not mostly about wallpapers and widgets in Plasma Active. Actually I think that whether people can set wallpapers immediately or not doesn't influence their mental model of what Activities are very much. It's more of a convenience thing and helps people to distinguish between Activities more easily. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Selecting wallpaper during Activity creation
On 28.02.2014 13:31, Marco Martin wrote: On Friday 28 February 2014 13:22:59 David Edmundson wrote: Possible downside is it ties in the notion that activities are just about wallpapers and widgets which isn't really the case, and not something we want people to think. one thing is that it would pretty much require to use the wallpaper config dialog (both for technical reasons and because having another ui for the same thing-evil) don't know, maybe just opening the containment config automatically with a random wallpaper preselected.. That's pretty much what Plasma Active does, isn't it? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
Hey, On Fri, Feb 28, 2014 at 7:04 PM, Maulik Kotadia maulikkota...@gmail.comwrote: Hi, First of all apologies for the mistakes . I've started contributing to KDE very recently and it was my first patch. I'll keep this thing in mind in future. - Thanks Regards However its easy fix.. just remove timer code and set text property of the headerTimeText to relevant Qt.formatDateTime call. Regards! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51343 --- This review has been submitted with commit 66bac622b4e2a268098d59b3ab708b18634a362a by David Edmundson to branch master. - Commit Hook On Feb. 21, 2014, 3:32 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 21, 2014, 3:32 p.m.) Review request for Plasma. Repository: plasma-framework Description --- The rationale behind this patch is on the mailing list in the thread Minutes Monday This doesn't boost performance or save memory much, but it paves the way for texture sharing, faster resizing, and plenty of other things. Based on Frederick's comment I have reverted my changes to use QImage everywhere, otherwise we lose out on the local QPixmap cache in KImageCache. Changes to plasmacore are minimal. I'm currently porting FrameSVG which is where we should see more gains, but I thought I should get this reviewed/merged in parallel. I have only seen one regression which is in the analog clock. Some odd code in the analog clock (by me apparently!) means the width is dependent on the current width, which due to some changes in this patch ends up in a constant spiral getting to infinitely sized and explode. Changelog (in reverse order): Remove manual isDirty tracking in SvgItem Always resize the node geometry on resizes Update to paint to fill the size of the object, not the size of texture Fix leaking texture Add convenient QImage image() getter in SVG Avoid repainting if node is not changed Render SvgItem natively rather than going through QQuickPaintedItem Diffs - src/declarativeimports/core/svgitem.h c8be7cc src/declarativeimports/core/svgitem.cpp e90751a src/plasma/svg.h 01d98f8 src/plasma/svg.cpp 9ec2aa5 Diff: https://git.reviewboard.kde.org/r/115923/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/#review51342 --- [16:00] notmart so, if you are sure nothing is leaking (ii still not have 100% how is supposed to be).. then ship it for me - David Edmundson On Feb. 21, 2014, 3:32 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 21, 2014, 3:32 p.m.) Review request for Plasma. Repository: plasma-framework Description --- The rationale behind this patch is on the mailing list in the thread Minutes Monday This doesn't boost performance or save memory much, but it paves the way for texture sharing, faster resizing, and plenty of other things. Based on Frederick's comment I have reverted my changes to use QImage everywhere, otherwise we lose out on the local QPixmap cache in KImageCache. Changes to plasmacore are minimal. I'm currently porting FrameSVG which is where we should see more gains, but I thought I should get this reviewed/merged in parallel. I have only seen one regression which is in the analog clock. Some odd code in the analog clock (by me apparently!) means the width is dependent on the current width, which due to some changes in this patch ends up in a constant spiral getting to infinitely sized and explode. Changelog (in reverse order): Remove manual isDirty tracking in SvgItem Always resize the node geometry on resizes Update to paint to fill the size of the object, not the size of texture Fix leaking texture Add convenient QImage image() getter in SVG Avoid repainting if node is not changed Render SvgItem natively rather than going through QQuickPaintedItem Diffs - src/declarativeimports/core/svgitem.h c8be7cc src/declarativeimports/core/svgitem.cpp e90751a src/plasma/svg.h 01d98f8 src/plasma/svg.cpp 9ec2aa5 Diff: https://git.reviewboard.kde.org/r/115923/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115923: Render SvgItem natively rather than going through QQuickPaintedItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115923/ --- (Updated Feb. 28, 2014, 3:23 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- The rationale behind this patch is on the mailing list in the thread Minutes Monday This doesn't boost performance or save memory much, but it paves the way for texture sharing, faster resizing, and plenty of other things. Based on Frederick's comment I have reverted my changes to use QImage everywhere, otherwise we lose out on the local QPixmap cache in KImageCache. Changes to plasmacore are minimal. I'm currently porting FrameSVG which is where we should see more gains, but I thought I should get this reviewed/merged in parallel. I have only seen one regression which is in the analog clock. Some odd code in the analog clock (by me apparently!) means the width is dependent on the current width, which due to some changes in this patch ends up in a constant spiral getting to infinitely sized and explode. Changelog (in reverse order): Remove manual isDirty tracking in SvgItem Always resize the node geometry on resizes Update to paint to fill the size of the object, not the size of texture Fix leaking texture Add convenient QImage image() getter in SVG Avoid repainting if node is not changed Render SvgItem natively rather than going through QQuickPaintedItem Diffs - src/declarativeimports/core/svgitem.h c8be7cc src/declarativeimports/core/svgitem.cpp e90751a src/plasma/svg.h 01d98f8 src/plasma/svg.cpp 9ec2aa5 Diff: https://git.reviewboard.kde.org/r/115923/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116460: Footer clock fix
Hi Maulik, Let me try to elaborate what's being mentioned here, just in case things weren't clear( I had to discuss the issue with sebas later on in the IRC to really get a grip of what was going here). On Fri, Feb 28, 2014 at 6:41 PM, Sebastian Kügler se...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116460/ This fix is wrong, it's merely trying to handle a symptom. The root cause of this erratic behavior is that we're making up our own time formatting code. The time format in the place where you and I live(assuming India) is in AM/PM, but is not necessarily the same elsewhere. I too had sent(as sebas mentioned) the a patch not considering the differing time formats in different locations. That has to be taken care of :) The right approach would entail: - Getting the right timezone (The time dataengine knows it) - Using a correct timeformatting function, such as Qt.formatDateTime or one in the org.kde.klocale import (as Bhushan notes) There is already a review request for this, you've probably seen it as you've CC:ed the author of that patch. You should, however, also have read the comments, as this solution is the exact same as in that patch. I'm not sure what's going on here, but you should try not to step on each others toes. Thanks for mentioning that :) I'm also working on the fix for the same issue :P Cheers Thanking You, R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115475: Split KRunner out of plasma-framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115475/ --- (Updated Feb. 28, 2014, 4:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Splitted out KRunner so we can use it from any solution and eventually move out from it, if required. It can be found now in kde:scratch/apol/krunner. Diffs - src/plasma/includes/Plasma/RunnerScript f078d03 src/plasma/pluginloader.cpp 4d8633c src/plasma/private/abstractrunner_p.h ada3222 src/plasma/private/runnerjobs.cpp 880a3c5 src/plasma/private/runnerjobs_p.h 43c6da2 src/plasma/private/storage.cpp c9d7100 src/plasma/querymatch.h 7fe66fb src/plasma/querymatch.cpp 8353e8f src/plasma/runnercontext.h 97d654a src/plasma/runnercontext.cpp 8b74614 src/plasma/runnermanager.h 1963f66 src/plasma/runnermanager.cpp 69f8ef4 src/plasma/runnersyntax.h 63a2624 src/plasma/runnersyntax.cpp 2984d7a src/plasma/scripting/runnerscript.h 1175d25 src/plasma/scripting/runnerscript.cpp 366d3ef src/plasma/scripting/scriptengine.h 013e983 src/plasma/scripting/scriptengine.cpp 2a0dfd9 src/scriptengines/python/CMakeLists.txt 2bd980b src/plasma/includes/Plasma/RunnerContext 0c0d283 src/plasma/includes/Plasma/RunnerManager 95e00ec src/declarativeimports/krunnermodel/qmldir 6e4fe5b src/declarativeimports/krunnermodel/runnermodelplugin.h 65d2faa src/declarativeimports/krunnermodel/runnermodelplugin.cpp 3b466bf src/plasma/CMakeLists.txt 064d3cc src/plasma/abstractrunner.h 219fa05 src/plasma/abstractrunner.cpp c01ac18 src/plasma/autotests/CMakeLists.txt 06c3d15 src/plasma/autotests/runnercontexttest.h 1c6feb7 src/plasma/autotests/runnercontexttest.cpp bb38d3e src/plasma/data/servicetypes/plasma-runner.desktop 08cd066 src/plasma/includes/Plasma/AbstractRunner fbc77e8 src/plasma/includes/Plasma/QueryMatch d6fc700 examples/runner/homefilesrunner.cpp 39d0205 examples/runner/plasma-runner-example-homefiles.desktop 296d1d0 src/declarativeimports/CMakeLists.txt db88828 src/declarativeimports/core/corebindingsplugin.cpp 1ce43d4 src/declarativeimports/core/runnermodel.h bd21c21 src/declarativeimports/core/runnermodel.cpp 170f511 src/declarativeimports/core/tests/CMakeLists.txt b49f91d src/declarativeimports/core/tests/main.cpp 1feee19 src/declarativeimports/krunnermodel/CMakeLists.txt f7405b6 examples/runner/CMakeLists.txt b9c1511 examples/runner/Messages.sh 4fb602e examples/runner/homefilesrunner.h c535380 Diff: https://git.reviewboard.kde.org/r/115475/diff/ Testing --- Everything still builds. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KActivities/master is now KF5/Qt5
On Fri, Feb 28, 2014 at 9:50 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so I'm CC-ing him even though he is a member of every list I'm sending this to :) ) The only things left to do are (I'm looking at Ben or Albert with hope in my eyes): - update kde:kde-build-metadata - I don't dare to do this myself. It should use KDE/4.13 branch for Qt4, and master for Qt5. - blacklist and delete the frameworks branch The metadata has now been sorted. Cheerio, Ivan Regards, Ben -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KActivities/master is now KF5/Qt5
The metadata has now been sorted Thanks man! On 28 February 2014 21:59, Ben Cooksley bcooks...@kde.org wrote: On Fri, Feb 28, 2014 at 9:50 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi all, Now that the 4.13 has been branched out, the master branch of KActivities is for Qt5/KF5 development. I have updated the branch name in kf5-frameworks-build-include (I guess David had something else in mind, so I'm CC-ing him even though he is a member of every list I'm sending this to :) ) The only things left to do are (I'm looking at Ben or Albert with hope in my eyes): - update kde:kde-build-metadata - I don't dare to do this myself. It should use KDE/4.13 branch for Qt4, and master for Qt5. - blacklist and delete the frameworks branch The metadata has now been sorted. Cheerio, Ivan Regards, Ben -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun -- Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115764: Make playlist model aware of currently playing media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/#review51403 --- This review has been submitted with commit 93a7fd6b58371b81c3a3b30c7829c8bcfbc6d498 by Shantanu Tushar to branch master. - Commit Hook On Feb. 26, 2014, 4:07 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ --- (Updated Feb. 26, 2014, 4:07 p.m.) Review request for Plasma, Sinny Kumari and Sujith Haridasan. Repository: plasma-mediacenter Description --- We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous. This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 mediaelements/playlist/MultiplePlaylists.qml d94fe6e mediaelements/playlist/Playlist.qml fd83c21 mediaelements/playlist/PlaylistDelegate.qml e1bd31d shells/newshell/application.cpp adc95dc shells/newshell/mainwindow.h d918e3d shells/newshell/mainwindow.cpp 7f7f31d shells/newshell/package/contents/ui/mediacenter.qml b6cb87c libs/mediacenter/multipleplaylistmodel.h 06b64df libs/mediacenter/multipleplaylistmodel.cpp f2c9246 libs/mediacenter/playlistmodel.h f79f814 Diff: https://git.reviewboard.kde.org/r/115764/diff/ Testing --- Tested with usual playback and with passing multiple files as command line parameters. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- Review request for Plasma. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from the terminal, use git diff patchname.diff which will save the exact diff to patchname.diff which you can then upload.) - Shantanu Tushar On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:11 a.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from the terminal, use git diff patchname.diff which will save the exact diff to patchname.diff which you can then upload.) sorry for that. But i have chnged some things in the metadataupdater.cpp to support my ubuntu version. So i cant change those. what should i do? - Rukshan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:11 a.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from the terminal, use git diff patchname.diff which will save the exact diff to patchname.diff which you can then upload.) Rukshan Chathuranga wrote: sorry for that. But i have chnged some things in the metadataupdater.cpp to support my ubuntu version. So i cant change those. what should i do? ah, you can just use git diff filename to show diff only for a particular file (the qml one in your case) - Shantanu --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:11 a.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 1, 2014, 7:16 a.m., Shantanu Tushar wrote: Your diff contains commented out changes to metadataupdater.cpp which I think you don't need. Please revert changes to that file and post a fresh diff. (Also, you even copied (END) which mostly happened while copy-pasting from the terminal, use git diff patchname.diff which will save the exact diff to patchname.diff which you can then upload.) Rukshan Chathuranga wrote: sorry for that. But i have chnged some things in the metadataupdater.cpp to support my ubuntu version. So i cant change those. what should i do? Shantanu Tushar wrote: ah, you can just use git diff filename to show diff only for a particular file (the qml one in your case) ok. Thanks. I upload the new version. - Rukshan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- On March 1, 2014, 7:27 a.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:27 a.m.) Review request for Plasma. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/ --- (Updated March 1, 2014, 7:27 a.m.) Review request for Plasma. Changes --- updated diff file for MediaController.qml. Repository: plasma-mediacenter Description --- Implement change volume on mouse wheel when top of the voulume icon. Diffs (updated) - mediaelements/mediacontroller/MediaController.qml 968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
