Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
---

(Updated March 5, 2014, 6:15 a.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

The previous patch didn't show the complete highlighted item (when it is cut 
off by the screen at the end).
Now it does.


Repository: plasma-mediacenter


Description
---

Before this patch it was not possible to delete media (only using mouse) from a 
playlist without playing the media, as reported in Bug 329168 : 
https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to 
navigate the playlist then before.


Diffs (updated)
-

  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
  mediaelements/playlist/Playlist.qml fd83c21 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
---

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

KDE Books

[Valorie Zimmerman]

Hi folks, some months ago Mario Fux spoke to me about heading up a
book sprint at the Randa meeting this summer [1]. Some of you might be
aware of the KDE Developer book which we wrote a couple of years ago
at a book sprint hosted by Google.

You can read it or download it as a PDF or ebook here:
http://flossmanuals.net/kde-guide/

We'll be updating that book, but we'd like to produce a new book if
any teams in KDE feel that would be useful. Of course, if your team
wants a book, you will be writing it! With our help, of course.

I've addressed some lists which might be interested in writing and
using such a book; feel free to forward it to others who might be
interested.

Please speak up soon, so we can begin to make sure that all necessary
resources will be available that week.

All the best,

Valorie

1. http://randa-meetings.ch/2014/02/19/randa-meetings-2014-the-date-is-set-
please-register/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review52002
---



mediaelements/playlist/Playlist.qml


I suggest using ListView.Contain instead.


- Shantanu Tushar


On March 4, 2014, 7:28 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> ---
> 
> (Updated March 4, 2014, 7:28 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Before this patch it was not possible to delete media (only using mouse) from 
> a playlist without playing the media, as reported in Bug 329168 : 
> https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to 
> navigate the playlist then before.
> 
> 
> Diffs
> -
> 
>   mediaelements/playlist/Playlist.qml fd83c21 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> ---
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

[Kevin Ottens]

> On Feb. 26, 2014, 9:41 a.m., Kevin Krammer wrote:
> > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 78
> > 
> >
> > I see lambdas being using later on, in which case this looks like a 
> > candidate for std::find_if() with a lambda predicate

Good catch. Indeed, what about switching to find_if here?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/#review50909
---


On March 3, 2014, 8:36 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116075/
> ---
> 
> (Updated March 3, 2014, 8:36 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Add menu support to KDEPlatformSystemTrayIcon
> 
> Uses new QPA API which got introduced in Qt 5.3.
> 
> Provide an implementation for QPlatformSystemTrayIcon
> 
> The idea is to force all QSystemTrayIcon to use our status notifiers
> as we don't want to provide an xembed based system tray in the next
> iteration of the Plasma desktop shell anymore.
> 
> The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement
> the system tray icon. Unfortunately a complete wrapping is not yet
> possible as we cannot create a menu. We do not want to provide a
> QPlatformMenu in our PlatformTheme and thus the menu used by
> QSystemTrayIcon does not have a QPlatformMenu.
> 
> This is adressed in Qt 5.3 which extends the QPA API.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformtheme.cpp 
> a5d86c27385447b7744cb8bca0cf65889872fb0b 
>   autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be 
>   src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c 
>   src/platformtheme/kdeplatformtheme.h 
> f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION 
>   src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116075/diff/
> 
> 
> Testing
> ---
> 
> Using systray from qtbase/examples/widgets/desktop/systray
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
---

(Updated March 4, 2014, 7:28 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

The previous patch made the view to scroll like "crazy" (as pointed out by 
Shantanu) when mouse pointer reached somewhat near the end of the view.
Fixed by making a little change to Playlist.qml


Repository: plasma-mediacenter


Description
---

Before this patch it was not possible to delete media (only using mouse) from a 
playlist without playing the media, as reported in Bug 329168 : 
https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to 
navigate the playlist then before.


Diffs (updated)
-

  mediaelements/playlist/Playlist.qml fd83c21 
  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
---

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116085: welcome back the javascript interactive console

[Marco Martin]

> On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote:
> > src/shell/CMakeLists.txt, line 20
> > 
> >
> > This would mean:
> > a) propagate KTextEditor to part of the KF5 releases (that was not the 
> > case with TP1 & alpha1)
> > b) move the console or shell altogether to a different repo
> > c) rewrite it without this framework
> 
> Marco Martin wrote:
> ah.
> is ok to depend from it from other projects?
> We tought about moving the whole shell subdirectory to kde-workspace, 
> looks like we have to do it sooner.
> 
> Hrvoje Senjan wrote:
> it 'can' depend atm - but alpha2 is scheduled for weekend =) (personally, 
> i'd love to have KTextEditor there, but that's something for release & kate 
> guys ;-)
> 
> Marco Martin wrote:
> since unfortunately it has been already merged,
> would be a branch (or just a tag) from before this branch was merged be 
> ok for alpha2?
> 
> David Faure wrote:
> Guys, you're not making it easy for me to make releases, with deps to 
> unreleased stuff committed at the time of making the release
> 
> "Just a tag" doesn't work, I needed to upgrade the version number of the 
> framework (which is pushed now).
> Plus it would just postpone the problem 
> 
> So I'll just revert the commit that adds the dependencies, since 
> apparently KTextEditor is not meant to be part of 5.0.
> 
> David Faure wrote:
> Couldn't simply revert a merge :)
> So I did this instead:
> 
> commit 4f784339b6b5f7236b057a68e7240a1a36dd7ef7
> Author: David Faure 
> Date:   Sat Mar 1 18:47:00 2014 +0100
> 
> Make ktexteditor an optional dependency
> 
>  src/shell/CMakeLists.txt | 21 +
>  src/shell/config-ktexteditor.h.cmake |  2 ++
>  src/shell/shellcorona.cpp| 10 ++
>  3 files changed, 29 insertions(+), 4 deletions(-)
> 
>

I didn't realize the problem at the time of the merge, sorry for the problems 
it caused :/


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116085/#review50965
---


On Feb. 26, 2014, 5:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116085/
> ---
> 
> (Updated Feb. 26, 2014, 5:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports the js interactive console from plasma1 and ports it way from 
> kde4support
> 
> ui-wise it should look the same
> 
> 
> Diffs
> -
> 
>   src/shell/CMakeLists.txt db0e569 
>   src/shell/interactiveconsole.h PRE-CREATION 
>   src/shell/interactiveconsole.cpp PRE-CREATION 
>   src/shell/packages.h 999b4c9 
>   src/shell/packages.cpp 0b2aa3f 
>   src/shell/scripting/layouttemplatepackagestructure.h abc5562 
>   src/shell/scripting/layouttemplatepackagestructure.cpp bc1d0ca 
>   src/shell/scripting/scriptengine.cpp 29735a0 
>   src/shell/shellcorona.cpp e84e0bf 
>   src/shell/shellpluginloader.cpp c57b348 
> 
> Diff: https://git.reviewboard.kde.org/r/116085/diff/
> 
> 
> Testing
> ---
> 
> tried to add plasmoids from the console
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Move plasmate to git-next?

[Giorgos Tsiapaliokas]

Hello,

if nobody hasn't any objections I would like to
move plasmate to git-next.kde.org.

Any objections?

thanks,

--
Giorgos Tsiapaliokas (terietor)

terietor.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116032/#review51916
---


This review has been submitted with commit 
0758059de49d68184cd5aaeab8be9646d4b14b3f by Shantanu Tushar on behalf of Sinny 
Kumari to branch shantanu-qxorm.

- Commit Hook


On Feb. 25, 2014, 5:55 p.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116032/
> ---
> 
> (Updated Feb. 25, 2014, 5:55 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> The media window was stopping on the last frame of the video whenever a video 
> was played from the local drive. Ideally it should go back to the last video 
> listing window at the completion of the video-play. This has been implemented 
> now.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml b6cb87c 
> 
> Diff: https://git.reviewboard.kde.org/r/116032/diff/
> 
> 
> Testing
> ---
> 
> It has been tested on multiple machines, and through commandline also.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116063: Implementation of the backspace key as an option to go back to the previous window.

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116063/#review51917
---


This review has been submitted with commit 
e29e564c29cb20131fe3a98b6534f6ae9fd68f95 by Shantanu Tushar on behalf of 
Harshit Agarwal to branch shantanu-qxorm.

- Commit Hook


On Feb. 27, 2014, 4:52 a.m., Harshit Agarwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116063/
> ---
> 
> (Updated Feb. 27, 2014, 4:52 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Through this patch, the user can go to the previous window through the 
> backspace key also. The issue with the focus on the Search Bar has been 
> solved. The backspace option works only when the search bar is not in focus.
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116063/diff/
> 
> 
> Testing
> ---
> 
> It has been tested.
> 
> 
> Thanks,
> 
> Harshit Agarwal
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328653] Backspace is totally broken in kickoff

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=328653

Sebastian Kügler  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Sebastian Kügler  ---
Fixed as of last week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328651] Theme is not updated when composite changes

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=328651

Sebastian Kügler  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Sebastian Kügler  ---
Fixed with theme updates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116117: Place new panels to bottom by default

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/#review51915
---


This review has been submitted with commit 
f3b9bb2b46236683186cf5b92de383c968d51f81 by Jan Grulich to branch KDE/4.11.

- Commit Hook


On March 4, 2014, 5:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116117/
> ---
> 
> (Updated March 4, 2014, 5:07 p.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and 
> Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> When adding a new empty panel, it's placed at top by default, but it should 
> be placed to bottom, when it's possible. Also when adding a new "Default 
> Panel" to second screen without any panel and you already have one on your 
> first screen, then it's also placed to top instead of bottom. This is just a 
> simple fix, which changes order of checking free edges for empty panels and 
> adds a check for screenId when executing a script for default panel layout. 
> I'm not much sure with the javascript part, but it works.
> 
> 
> Diffs
> -
> 
>   
> plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
>  356e689 
> 
> Diff: https://git.reviewboard.kde.org/r/116117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116117: Place new panels to bottom by default

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/
---

(Updated March 4, 2014, 5:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and 
Sebastian Kügler.


Repository: kde-workspace


Description
---

When adding a new empty panel, it's placed at top by default, but it should be 
placed to bottom, when it's possible. Also when adding a new "Default Panel" to 
second screen without any panel and you already have one on your first screen, 
then it's also placed to top instead of bottom. This is just a simple fix, 
which changes order of checking free edges for empty panels and adds a check 
for screenId when executing a script for default panel layout. I'm not much 
sure with the javascript part, but it works.


Diffs
-

  
plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
 356e689 

Diff: https://git.reviewboard.kde.org/r/116117/diff/


Testing
---


Thanks,

Jan Grulich

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116117: Place new panels to bottom by default

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/#review51913
---

Ship it!


Ship It!

- Sebastian Kügler


On March 4, 2014, 5:07 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116117/
> ---
> 
> (Updated March 4, 2014, 5:07 p.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and 
> Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> When adding a new empty panel, it's placed at top by default, but it should 
> be placed to bottom, when it's possible. Also when adding a new "Default 
> Panel" to second screen without any panel and you already have one on your 
> first screen, then it's also placed to top instead of bottom. This is just a 
> simple fix, which changes order of checking free edges for empty panels and 
> adds a check for screenId when executing a script for default panel layout. 
> I'm not much sure with the javascript part, but it works.
> 
> 
> Diffs
> -
> 
>   
> plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
>  356e689 
> 
> Diff: https://git.reviewboard.kde.org/r/116117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116117: Place new panels to bottom by default

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/
---

(Updated March 4, 2014, 5:07 p.m.)


Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and 
Sebastian Kügler.


Changes
---

It looks that previous script didn't work correctly, because I always assumed 
when there is some panel, it's placed to bottom. Now I'm checking free edges 
and placing a new panel according to which one is free.


Repository: kde-workspace


Description
---

When adding a new empty panel, it's placed at top by default, but it should be 
placed to bottom, when it's possible. Also when adding a new "Default Panel" to 
second screen without any panel and you already have one on your first screen, 
then it's also placed to top instead of bottom. This is just a simple fix, 
which changes order of checking free edges for empty panels and adds a check 
for screenId when executing a script for default panel layout. I'm not much 
sure with the javascript part, but it works.


Diffs (updated)
-

  
plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
 356e689 

Diff: https://git.reviewboard.kde.org/r/116117/diff/


Testing
---


Thanks,

Jan Grulich

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Bug 322820 - Playlist is not reachable from home screen

[Shantanu Tushar Jha]

Hi Ashish,

Solution 1 isn't very good because it brings unnecessary clutter to the
home screen. Solution 2 is what we should be going for, however to get a
menu item you'll have to create a new backend and this backend will need to
run some QML code to bring up the playlist. Right now backends cannot do
this, so in order to do this you'll have to add this capability to the
backend system.

Cheers,


On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti  wrote:

> In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820
>
> I have two solutions to the problem.
>
> 1. We can show the mediaController even on home screen (welcome screen).
> It will have an added advantage (can be implemented in near future) of
> directly playing the last selected playlist by clicking the play button on
> welcome screen.
>
> 2. We can add a menu item for "Browse Playlists" on welcome screen for
> music and videos.
>
> I will try to implement whichever is better.
>
> --
> *Ashish Madeti*
> 2nd Year
> Computer Science & Engineering
> The LNM Institute of Information Technology
> Jaipur, Rajasthan
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/#review51911
---


Thanks for the patch, this does fix it to the expected behavior. However, if 
you move your mouse pointer to items near the end of the view, it starts to 
scroll like crazy. You might want to look at Playlist.qml line 130 and see if 
you can make this better.

- Shantanu Tushar


On March 4, 2014, 3:17 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116596/
> ---
> 
> (Updated March 4, 2014, 3:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Before this patch it was not possible to delete media (only using mouse) from 
> a playlist without playing the media, as reported in Bug 329168 : 
> https://bugs.kde.org/show_bug.cgi?id=329168
> 
> Now not only can you delete the media without playing it, it is easier to 
> navigate the playlist then before.
> 
> 
> Diffs
> -
> 
>   mediaelements/playlist/PlaylistDelegate.qml e1bd31d 
> 
> Diff: https://git.reviewboard.kde.org/r/116596/diff/
> 
> 
> Testing
> ---
> 
> 1.Deleted a song from a playlist without playing it.
> 2.Traversed the playlist without using keyboard or mouse scroll button.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/
---

(Updated March 4, 2014, 4:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Repository: plasma-mediacenter


Description
---

This signal is never emitted and never used and pulling extra plasma dep in the 
picasa backend. It will depend upon Plasma anyway but at runtime.


Diffs
-

  browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a 

Diff: https://git.reviewboard.kde.org/r/116597/diff/


Testing
---

Yeah, works.

- compiles
- builds
- links
- works


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/#review51908
---


This review has been submitted with commit 
8866b18867a071b0bf4c4c15163250d853f0d8ca by Bhushan Shah to branch master.

- Commit Hook


On March 4, 2014, 4:09 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116597/
> ---
> 
> (Updated March 4, 2014, 4:09 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This signal is never emitted and never used and pulling extra plasma dep in 
> the picasa backend. It will depend upon Plasma anyway but at runtime.
> 
> 
> Diffs
> -
> 
>   browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a 
> 
> Diff: https://git.reviewboard.kde.org/r/116597/diff/
> 
> 
> Testing
> ---
> 
> Yeah, works.
> 
> - compiles
> - builds
> - links
> - works
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116599: Set minimum version of Wayland to 1.2

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/#review51905
---

Ship it!


I guess it's part of what's not even needed in kinfocenter, but yeah makes 
sense to raise the version. Maybe one could go directly to 1.4

- Martin Gräßlin


On March 4, 2014, 4:56 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116599/
> ---
> 
> (Updated March 4, 2014, 4:56 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Latest code in infocenter requires Wayland 1.2 because it uses new fields 
> from the wl_output_listener which were introduced in 1.2.
> 
> This only works when https://git.reviewboard.kde.org/r/116598/ is applied.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 41923b6 
> 
> Diff: https://git.reviewboard.kde.org/r/116599/diff/
> 
> 
> Testing
> ---
> 
> Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no 
> libwayland-egl)
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/#review51903
---

Ship it!


Ship It!

- Shantanu Tushar


On March 4, 2014, 4:09 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116597/
> ---
> 
> (Updated March 4, 2014, 4:09 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> This signal is never emitted and never used and pulling extra plasma dep in 
> the picasa backend. It will depend upon Plasma anyway but at runtime.
> 
> 
> Diffs
> -
> 
>   browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a 
> 
> Diff: https://git.reviewboard.kde.org/r/116597/diff/
> 
> 
> Testing
> ---
> 
> Yeah, works.
> 
> - compiles
> - builds
> - links
> - works
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/
---

(Updated March 4, 2014, 9:39 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Repository: plasma-mediacenter


Description
---

This signal is never emitted and never used and pulling extra plasma dep in the 
picasa backend. It will depend upon Plasma anyway but at runtime.


Diffs
-

  browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a 

Diff: https://git.reviewboard.kde.org/r/116597/diff/


Testing
---

Yeah, works.

- compiles
- builds
- links
- works


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116597: Remove unneeded signal from the plasma mediacenter picasa backend

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116597/
---

Review request for Plasma and Sinny Kumari.


Repository: plasma-mediacenter


Description
---

This signal is never emitted and never used and pulling extra plasma dep in the 
picasa backend. It will depend upon Plasma anyway but at runtime.


Diffs
-

  browsingbackends/onlineservices/picasa/picasamodel.h 4a1ca4a 

Diff: https://git.reviewboard.kde.org/r/116597/diff/


Testing
---

Yeah, works.

- compiles
- builds
- links
- works


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116599: Set minimum version of Wayland to 1.2

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116599/
---

Review request for Plasma and Martin Gräßlin.


Repository: kde-workspace


Description
---

Latest code in infocenter requires Wayland 1.2 because it uses new fields from 
the wl_output_listener which were introduced in 1.2.

This only works when https://git.reviewboard.kde.org/r/116598/ is applied.


Diffs
-

  CMakeLists.txt 41923b6 

Diff: https://git.reviewboard.kde.org/r/116599/diff/


Testing
---

Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl)


Thanks,

Aurélien Gâteau

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328597] Context menu and toolbox have an empty action

[Alex Fiestas]

https://bugs.kde.org/show_bug.cgi?id=328597

Alex Fiestas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
---

(Updated March 4, 2014, 3:17 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Before this patch it was not possible to delete media (only using mouse) from a 
playlist without playing the media, as reported in Bug 329168 : 
https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to 
navigate the playlist then before.


Diffs
-

  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
---

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116596: Fix for "Bug 329168 - It is impossible to remove a media from playlist without playing it first"

[Ashish Madeti]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116596/
---

Review request for Plasma.


Repository: plasma-mediacenter


Description
---

Before this patch it was not possible to delete media (only using mouse) from a 
playlist without playing the media, as reported in Bug 329168 : 
https://bugs.kde.org/show_bug.cgi?id=329168

Now not only can you delete the media without playing it, it is easier to 
navigate the playlist then before.


Diffs
-

  mediaelements/playlist/PlaylistDelegate.qml e1bd31d 

Diff: https://git.reviewboard.kde.org/r/116596/diff/


Testing
---

1.Deleted a song from a playlist without playing it.
2.Traversed the playlist without using keyboard or mouse scroll button.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel