Re: Review Request 116599: Set minimum version of Wayland to 1.2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116599/ --- (Updated March 5, 2014, 9:02 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Repository: kde-workspace Description --- Latest code in infocenter requires Wayland 1.2 because it uses new fields from the wl_output_listener which were introduced in 1.2. This only works when https://git.reviewboard.kde.org/r/116598/ is applied. Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116599/diff/ Testing --- Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl) Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116599: Set minimum version of Wayland to 1.2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116599/#review52030 --- This review has been submitted with commit d61b0e229fb429d5153c09a2e41f19b7e5c06817 by Aurélien Gâteau to branch master. - Commit Hook On March 4, 2014, 3:56 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116599/ --- (Updated March 4, 2014, 3:56 p.m.) Review request for Plasma and Martin Gräßlin. Repository: kde-workspace Description --- Latest code in infocenter requires Wayland 1.2 because it uses new fields from the wl_output_listener which were introduced in 1.2. This only works when https://git.reviewboard.kde.org/r/116598/ is applied. Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116599/diff/ Testing --- Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl) Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Bug 322820 - Playlist is not reachable from home screen
Hi Shantanu, If you think the 1st solution bring unnecessary clutter to the home screen , we can make it auto-hide like on the now playing screen. Another way to implement Solution 1, like if we presently click the empty area in the top and there is a media player instance it goes to it, we can make it go to the playlist page if there is no media player instance. On 4 March 2014 22:36, Shantanu Tushar Jha shaan...@gmail.com wrote: Hi Ashish, Solution 1 isn't very good because it brings unnecessary clutter to the home screen. Solution 2 is what we should be going for, however to get a menu item you'll have to create a new backend and this backend will need to run some QML code to bring up the playlist. Right now backends cannot do this, so in order to do this you'll have to add this capability to the backend system. Cheers, On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti sskash...@gmail.com wrote: In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820 I have two solutions to the problem. 1. We can show the mediaController even on home screen (welcome screen). It will have an added advantage (can be implemented in near future) of directly playing the last selected playlist by clicking the play button on welcome screen. 2. We can add a menu item for Browse Playlists on welcome screen for music and videos. I will try to implement whichever is better. -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- *Ashish Madeti* 2nd Year Computer Science Engineering The LNM Institute of Information Technology Jaipur, Rajasthan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review52055 --- Ship it! Ship It! - Kevin Ottens On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 11:14 a.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: frameworkintegration Description --- Add menu support to KDEPlatformSystemTrayIcon Uses new QPA API which got introduced in Qt 5.3. Provide an implementation for QPlatformSystemTrayIcon The idea is to force all QSystemTrayIcon to use our status notifiers as we don't want to provide an xembed based system tray in the next iteration of the Plasma desktop shell anymore. The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement the system tray icon. Unfortunately a complete wrapping is not yet possible as we cannot create a menu. We do not want to provide a QPlatformMenu in our PlatformTheme and thus the menu used by QSystemTrayIcon does not have a QPlatformMenu. This is adressed in Qt 5.3 which extends the QPA API. Diffs - autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b Diff: https://git.reviewboard.kde.org/r/116075/diff/ Testing --- Using systray from qtbase/examples/widgets/desktop/systray Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 11:49 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Repository: frameworkintegration Description --- Add menu support to KDEPlatformSystemTrayIcon Uses new QPA API which got introduced in Qt 5.3. Provide an implementation for QPlatformSystemTrayIcon The idea is to force all QSystemTrayIcon to use our status notifiers as we don't want to provide an xembed based system tray in the next iteration of the Plasma desktop shell anymore. The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement the system tray icon. Unfortunately a complete wrapping is not yet possible as we cannot create a menu. We do not want to provide a QPlatformMenu in our PlatformTheme and thus the menu used by QSystemTrayIcon does not have a QPlatformMenu. This is adressed in Qt 5.3 which extends the QPA API. Diffs - autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b Diff: https://git.reviewboard.kde.org/r/116075/diff/ Testing --- Using systray from qtbase/examples/widgets/desktop/systray Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review52056 --- This review has been submitted with commit a6c75f16514a2f8bb537f557bf8a07e957199171 by Martin Gräßlin to branch master. - Commit Hook On March 5, 2014, 11:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 11:14 a.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: frameworkintegration Description --- Add menu support to KDEPlatformSystemTrayIcon Uses new QPA API which got introduced in Qt 5.3. Provide an implementation for QPlatformSystemTrayIcon The idea is to force all QSystemTrayIcon to use our status notifiers as we don't want to provide an xembed based system tray in the next iteration of the Plasma desktop shell anymore. The KDEPlatformSystemTrayIcon uses a KStatusNotifierItem to implement the system tray icon. Unfortunately a complete wrapping is not yet possible as we cannot create a menu. We do not want to provide a QPlatformMenu in our PlatformTheme and thus the menu used by QSystemTrayIcon does not have a QPlatformMenu. This is adressed in Qt 5.3 which extends the QPA API. Diffs - autotests/CMakeLists.txt fb58b3a0cb9acc062be0edeb53210048e364c1be src/platformtheme/CMakeLists.txt 5fd949bee41b762120e120148de0b3b473de915c src/platformtheme/kdeplatformsystemtrayicon.h PRE-CREATION src/platformtheme/kdeplatformsystemtrayicon.cpp PRE-CREATION src/platformtheme/kdeplatformtheme.h f436eea4e3aa9cfda62654e5c6dc77aea05e8f27 src/platformtheme/kdeplatformtheme.cpp a5d86c27385447b7744cb8bca0cf65889872fb0b Diff: https://git.reviewboard.kde.org/r/116075/diff/ Testing --- Using systray from qtbase/examples/widgets/desktop/systray Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma Next alpha release engineering bits
Hi, As we're planning to release the first alpha of Plasma Next next week, I'd like to go over some details that need discussing. - promo preparations - tagging / tarballing: can happen anytime on Thursday next week - smoke-testing of packages - rolling out packages on Monday, or sooner depending on testing? We'll need someone to roll the tarballs and put them on the download site. Who is willing to help here? Affected repositories: - plasma-framework - kde-workspace - kde-runtime - kwin-compositing-kcm Am I missing something, perhaps the wallpapers? We have some bits in kde- baseapps that could be useful, should we include that as well (as sort of limited tarball)? This means: don't make changes to frameworks other than plasma-framework that are required, we'll not be able to include them in the Alpha. It also means that if you have invasive changes, get them in NOW, we need some time to stabilize them. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Next alpha release engineering bits
On Wednesday 05 March 2014 13:10:12 Sebastian Kügler wrote: Hi, As we're planning to release the first alpha of Plasma Next next week, I'd like to go over some details that need discussing. - promo preparations - tagging / tarballing: can happen anytime on Thursday next week - smoke-testing of packages - rolling out packages on Monday, or sooner depending on testing? We'll need someone to roll the tarballs and put them on the download site. Who is willing to help here? Affected repositories: - plasma-framework - kde-workspace - kde-runtime - kwin-compositing-kcm we will also need - kwindowsystem - frameworkintegration kwindowsystem because there will be SC changes and we need to adjust kde- workspace and I want to get those in as early as possible because of upcoming freeze in frameworks. frameworkintegration for the QSystemTrayIcon - statusnotifier mapping Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Oxygen as default font
Hey,
I've been trying to change our default font to Oxygen, with some mixed success
so far. Let me explain a bit: There's two components to this, we need to set
the default font to Oxygen, and we need to install the Oxygen font.
Default Setting
The easiest way to do this is to write out a kdeglobals config file if it
doesn't exist and put the font settings in there. I've looked through all the
magic that happens from startkde (kstartupconfig, kcminit), and initially
tried to use that. It doesn't really fix the problem however, since what we
need is the fonts defined in kdeglobals, which is the only thing to be picked
up by the frameworksintegration plugin. I think that's completely fine, it
even makes it quite easy to achieve a default font setting: Just writing out a
kdeglobals file is enough -- if you have the font installed.
Font Installation
So I've moved the latest version of the Oxygen font into the kde-workspace
repository, and am installing it under
${CMAKE_INSTALL_PREFIX}/share/fonts/oxygen. There, it's not automatically
picked up by fontconfig, though. This means, installing it to a non-/usr
prefix will likely mean the font is never going to be found for the user.
There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and
~/.fonts/ by default on most systems. So what I'm doing now is symlining the
Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME
isn't set).
I don't have it fully working, but so far my progress on this. I expect to
have a fully working version shortly.
One final remark: On my Debian system, defaulting to Oxygen makes a *huge*
difference. It seems that the default font's metrics are so utterly broken
that sizing of many elements is screwed up for the default font. Using Oxygen
makes it all look rather slick.
Cheers,
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Minutes Monday Plasma hangout
On Monday 03 March 2014 15:20:03 Ivan Čukić wrote: Ivan Cukic: - Keyboard support for activity switcher. - Some fixes/improvements to kactivities/imports (did anyone notice we are in master now :) finally) Questions: - The time to merge the switcher into plasma is approaching. I'm thinking about the best way to do it. I don't really like the idea that the activity switcher should be in the same box as the applet browser. (especially since I'm planning some fancy things that would collide with the idea of being boxed. I have even thought of making it a separate executable so that people can switch activities even when plasma crashes, but that would take much more memory than if it was inside plasma-shell. Some parts of it need to be always running, to be able to react to meta+tab properly. I really don't like the idea of the separate process, really overkill. as to where it is, right now it was managed by the desktop view qml to be able to work well with the active shell as well, where the switcher is very minimal, and always on the same window. So it needs to be completely replaceable in another shell and needs to be possible to stay in the same window of the main containment. it's also derived from how much I'm wary of adding much complexity in the switcher, since if we want people to start to use it we actually have to make it much simpler than is now, rather than more complicated -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116613: Fix dis/connects in PanelView
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116613/ --- Review request for Plasma. Repository: plasma-framework Description --- I was getting a warning that they didn't exist, changed for the most similar thing. Diffs - src/shell/panelview.cpp 949f6fa Diff: https://git.reviewboard.kde.org/r/116613/diff/ Testing --- I don't get a warning anymore. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wednesday 05 March 2014 13:36:33 Sebastian Kügler wrote: picked up by fontconfig, though. This means, installing it to a non-/usr prefix will likely mean the font is never going to be found for the user. There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and ~/.fonts/ by default on most systems. So what I'm doing now is symlining the Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME isn't set). so would symlink in the home if the prefix is not /usr? one thing that may be useful is to see how packagers expect fonts to be installed? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
Hi,
Yes I've been changing the default font to Oxygen an all machines I have set up.
However, we should also enable font anti-aliasing and subpixel hinting (I use
Medium) to make the font really shine.
Cheers,
Kai Uwe
Am 05.03.2014 13:36 schrieb =?ISO-8859-1?Q?Sebastian_K=FCgler?= se...@kde.org:
Hey,
I've been trying to change our default font to Oxygen, with some mixed
success
so far. Let me explain a bit: There's two components to this, we need to set
the default font to Oxygen, and we need to install the Oxygen font.
Default Setting
The easiest way to do this is to write out a kdeglobals config file if it
doesn't exist and put the font settings in there. I've looked through all the
magic that happens from startkde (kstartupconfig, kcminit), and initially
tried to use that. It doesn't really fix the problem however, since what we
need is the fonts defined in kdeglobals, which is the only thing to be picked
up by the frameworksintegration plugin. I think that's completely fine, it
even makes it quite easy to achieve a default font setting: Just writing out
a
kdeglobals file is enough -- if you have the font installed.
Font Installation
So I've moved the latest version of the Oxygen font into the kde-workspace
repository, and am installing it under
${CMAKE_INSTALL_PREFIX}/share/fonts/oxygen. There, it's not automatically
picked up by fontconfig, though. This means, installing it to a non-/usr
prefix will likely mean the font is never going to be found for the user.
There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and
~/.fonts/ by default on most systems. So what I'm doing now is symlining the
Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME
isn't set).
I don't have it fully working, but so far my progress on this. I expect to
have a fully working version shortly.
One final remark: On my Debian system, defaulting to Oxygen makes a *huge*
difference. It seems that the default font's metrics are so utterly broken
that sizing of many elements is screwed up for the default font. Using Oxygen
makes it all look rather slick.
Cheers,
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wednesday, March 05, 2014 14:06:43 Marco Martin wrote: picked up by fontconfig, though. This means, installing it to a non-/usr prefix will likely mean the font is never going to be found for the user. There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and ~/.fonts/ by default on most systems. So what I'm doing now is symlining the Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME isn't set). so would symlink in the home if the prefix is not /usr? one thing that may be useful is to see how packagers expect fonts to be installed? Correct. For packagers, we're likely installing into /usr, which means the font will get found automatically (it ends up in /usr/share/fonts, which is default). This trick is for those that install their Plasma into non-/usr. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116613: Fix dis/connects in PanelView
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116613/ --- (Updated March 5, 2014, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- I was getting a warning that they didn't exist, changed for the most similar thing. Diffs - src/shell/panelview.cpp 949f6fa Diff: https://git.reviewboard.kde.org/r/116613/diff/ Testing --- I don't get a warning anymore. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wed, Mar 05, 2014 at 02:06:43PM +0100, Marco Martin wrote: On Wednesday 05 March 2014 13:36:33 Sebastian Kügler wrote: picked up by fontconfig, though. This means, installing it to a non-/usr prefix will likely mean the font is never going to be found for the user. There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and ~/.fonts/ by default on most systems. So what I'm doing now is symlining the Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME isn't set). so would symlink in the home if the prefix is not /usr? one thing that may be useful is to see how packagers expect fonts to be installed? we install oxygen to /usr/share/fonts/truetype/oxygen-fonts it may be easiest to just release oxygen font separately and have it as a build depends of kde-runtime, that way people who install kde-runtime into something other than /usr can just install the package. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116614: Reduce glitches when moving panels around
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/ --- Review request for Plasma. Repository: plasma-framework Description --- There are 2 (quite separate) changes: * Never use the window size to figure out the thickness: This is bad because sometimes this will get called before the move hasn't been effective, which results in full-screen struts. Use the thickness method from KConfig instead. * Don't call setPosition and resize, but do it all at once in a setGeometry call. It simplifies the life of the QPA and WM, also it's quite faster as we reduce the calls to the WM by half (both setPosition and resize are syntax-sugar for setGeometry). Diffs - src/shell/panelview.cpp a09a61a Diff: https://git.reviewboard.kde.org/r/116614/diff/ Testing --- Played with it, KWin didn't decide to throw my windows to the other screen. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115922: Drop taskbar thumbnail effect
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115922/ --- (Updated March 5, 2014, 1:46 p.m.) Status -- This change has been marked as submitted. Review request for kwin and Plasma. Repository: kde-workspace Description --- Drop taskbar thumbnail effect As Plasma components provide a thumbnail which does not use the effect we can also remove it. Diffs - kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop b26d7a3e4c80ee39ab200fdd53e0890d68d7d450 kwin/effects/taskbarthumbnail/taskbarthumbnail.h e5cb235c9b75a2575b286c56131fbceb1f136112 kwin/effects/CMakeLists.txt de85ad6e5dbd3c1080c0fb9319338ce756b46264 kwin/effects/effect_builtins.cpp eb82204586aa9dde16f8bf57f8aa1b348dcb607b kwin/effects/taskbarthumbnail/CMakeLists.txt c502753907fc12a5dc8c393af466572ea03988fd kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 4f7dce7fb4af89c103cbf6dc7edee47dee34238e Diff: https://git.reviewboard.kde.org/r/115922/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115922: Drop taskbar thumbnail effect
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115922/#review52079 --- This review has been submitted with commit 53f83bfddc6209a36b7b3c98a763f4adabfae02c by Martin Gräßlin to branch master. - Commit Hook On Feb. 20, 2014, 6:14 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115922/ --- (Updated Feb. 20, 2014, 6:14 p.m.) Review request for kwin and Plasma. Repository: kde-workspace Description --- Drop taskbar thumbnail effect As Plasma components provide a thumbnail which does not use the effect we can also remove it. Diffs - kwin/effects/taskbarthumbnail/taskbarthumbnail.desktop b26d7a3e4c80ee39ab200fdd53e0890d68d7d450 kwin/effects/taskbarthumbnail/taskbarthumbnail.h e5cb235c9b75a2575b286c56131fbceb1f136112 kwin/effects/CMakeLists.txt de85ad6e5dbd3c1080c0fb9319338ce756b46264 kwin/effects/effect_builtins.cpp eb82204586aa9dde16f8bf57f8aa1b348dcb607b kwin/effects/taskbarthumbnail/CMakeLists.txt c502753907fc12a5dc8c393af466572ea03988fd kwin/effects/taskbarthumbnail/taskbarthumbnail.cpp 4f7dce7fb4af89c103cbf6dc7edee47dee34238e Diff: https://git.reviewboard.kde.org/r/115922/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wednesday, March 05, 2014 14:16:06 Kai Uwe Broulik wrote: Yes I've been changing the default font to Oxygen an all machines I have set up. However, we should also enable font anti-aliasing and subpixel hinting (I use Medium) to make the font really shine. That's actually part of my changes. :) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Oxygen as default font
On Wednesday, March 05, 2014 13:34:36 Jonathan Riddell wrote: On Wed, Mar 05, 2014 at 02:06:43PM +0100, Marco Martin wrote: On Wednesday 05 March 2014 13:36:33 Sebastian Kügler wrote: picked up by fontconfig, though. This means, installing it to a non-/usr prefix will likely mean the font is never going to be found for the user. There's a trick to fix this: fonts are picked up from XDG_DATA_HOME/fonts and ~/.fonts/ by default on most systems. So what I'm doing now is symlining the Oxygen font (conditionally) in one of those dirs (~/.fonts/ if XDG_DATA_HOME isn't set). so would symlink in the home if the prefix is not /usr? one thing that may be useful is to see how packagers expect fonts to be installed? we install oxygen to /usr/share/fonts/truetype/oxygen-fonts it may be easiest to just release oxygen font separately and have it as a build depends of kde-runtime, that way people who install kde-runtime into something other than /usr can just install the package. It doesn't solve the problem, though. People will still need to install the oxygen font, either from package or from source using cmake. How it's split at packaging level doesn't change this. (I've actually considered your suggestion already, but found that it doesn't actually solve the problem for me.) -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Bug 322820 - Playlist is not reachable from home screen
On Wed, Mar 5, 2014 at 2:53 PM, Ashish Madeti sskash...@gmail.com wrote: Hi Shantanu, If you think the 1st solution bring unnecessary clutter to the home screen , we can make it auto-hide like on the now playing screen. Another way to implement Solution 1, like if we presently click the empty area in the top and there is a media player instance it goes to it, we can make it go to the playlist page if there is no media player instance. This sounds good, try implementing it and see how it behaves. On 4 March 2014 22:36, Shantanu Tushar Jha shaan...@gmail.com wrote: Hi Ashish, Solution 1 isn't very good because it brings unnecessary clutter to the home screen. Solution 2 is what we should be going for, however to get a menu item you'll have to create a new backend and this backend will need to run some QML code to bring up the playlist. Right now backends cannot do this, so in order to do this you'll have to add this capability to the backend system. Cheers, On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti sskash...@gmail.comwrote: In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820 I have two solutions to the problem. 1. We can show the mediaController even on home screen (welcome screen). It will have an added advantage (can be implemented in near future) of directly playing the last selected playlist by clicking the play button on welcome screen. 2. We can add a menu item for Browse Playlists on welcome screen for music and videos. I will try to implement whichever is better. -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- *Ashish Madeti* 2nd Year Computer Science Engineering The LNM Institute of Information Technology Jaipur, Rajasthan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116614: Reduce glitches when moving panels around
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/#review52087 --- Ship it! Makes sense. src/shell/panelview.cpp https://git.reviewboard.kde.org/r/116614/#comment36984 don't commit commented out code - David Edmundson On March 5, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/ --- (Updated March 5, 2014, 1:36 p.m.) Review request for Plasma. Repository: plasma-framework Description --- There are 2 (quite separate) changes: * Never use the window size to figure out the thickness: This is bad because sometimes this will get called before the move hasn't been effective, which results in full-screen struts. Use the thickness method from KConfig instead. * Don't call setPosition and resize, but do it all at once in a setGeometry call. It simplifies the life of the QPA and WM, also it's quite faster as we reduce the calls to the WM by half (both setPosition and resize are syntax-sugar for setGeometry). Diffs - src/shell/panelview.cpp a09a61a Diff: https://git.reviewboard.kde.org/r/116614/diff/ Testing --- Played with it, KWin didn't decide to throw my windows to the other screen. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
On March 3, 2014, 6:01 a.m., Sujith Haridasan wrote: Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. Harshit Agarwal wrote: Test Cases: 1. With an pre-empty playlist, added videos from a folder on the local drive. Result: The videos get added on clicking the PlayAll Button, and the first video starts playing, window remains in the file browser only. 2. With a pre-filled playlist, and some video playing from the playlist, went to another folder and clicked PlayAll to a new set of videos. They get added to the existing playlist and the video continues without breaking. 3. With a single video playing from the local drive, and an empty playlist before, clicked PlayAll on a list of videos from a folder. They get added to the playlist, but do not disturb the current video playing. Launch pmc and then try to go to All Music. And then click on Play All. See if that solves the problem? - Sujith --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review51736 --- On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 2, 2014, 10:53 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasma-shell] [Bug 328651] Theme is not updated when composite changes
https://bugs.kde.org/show_bug.cgi?id=328651 Alex Fiestas afies...@kde.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasma-shell] [Bug 328651] Theme is not updated when composite changes
https://bugs.kde.org/show_bug.cgi?id=328651 --- Comment #2 from Alex Fiestas afies...@kde.org --- Created attachment 85423 -- https://bugs.kde.org/attachment.cgi?id=85423action=edit image showing composite with opaque theme. -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116614: Reduce glitches when moving panels around
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/#review52090 --- This review has been submitted with commit 78c6e452dfc2bbbdec430cde84ee09bc1f4122ce by Aleix Pol to branch master. - Commit Hook On March 5, 2014, 3:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/ --- (Updated March 5, 2014, 3:09 p.m.) Review request for Plasma. Repository: plasma-framework Description --- There are 2 (quite separate) changes: * Never use the window size to figure out the thickness: This is bad because sometimes this will get called before the move hasn't been effective, which results in full-screen struts. Use the thickness method from KConfig instead. * Don't call setPosition and resize, but do it all at once in a setGeometry call. It simplifies the life of the QPA and WM, also it's quite faster as we reduce the calls to the WM by half (both setPosition and resize are syntax-sugar for setGeometry). Diffs - src/shell/panelview.cpp a09a61a Diff: https://git.reviewboard.kde.org/r/116614/diff/ Testing --- Played with it, KWin didn't decide to throw my windows to the other screen. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116614: Reduce glitches when moving panels around
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116614/ --- (Updated March 5, 2014, 3:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- There are 2 (quite separate) changes: * Never use the window size to figure out the thickness: This is bad because sometimes this will get called before the move hasn't been effective, which results in full-screen struts. Use the thickness method from KConfig instead. * Don't call setPosition and resize, but do it all at once in a setGeometry call. It simplifies the life of the QPA and WM, also it's quite faster as we reduce the calls to the WM by half (both setPosition and resize are syntax-sugar for setGeometry). Diffs - src/shell/panelview.cpp a09a61a Diff: https://git.reviewboard.kde.org/r/116614/diff/ Testing --- Played with it, KWin didn't decide to throw my windows to the other screen. Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116618: Port FrameSVGItem to paint directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116618/ --- Review request for Plasma. Repository: plasma-framework Description --- Port FrameSVGItem to paint directly Simple port, not the full thing I want to do, but should at least save quite a few copies. Diffs - src/declarativeimports/core/framesvgitem.h 552be6e src/declarativeimports/core/framesvgitem.cpp e567e18 Diff: https://git.reviewboard.kde.org/r/116618/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116618: Port FrameSVGItem to paint directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116618/ --- (Updated March 5, 2014, 3:20 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port FrameSVGItem to paint directly Simple port, not the full thing I want to do, but should at least save quite a few copies. Diffs (updated) - src/declarativeimports/core/framesvgitem.h 552be6e src/declarativeimports/core/framesvgitem.cpp e567e18 src/declarativeimports/core/svgitem.cpp 6b11046 src/declarativeimports/core/svgtexturenode.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116618/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Move plasmate to git-next?
Since nobody disagrees I will make the request to the sysadmins. I will inform you again when the move is completed. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116618: Port FrameSVGItem to paint directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116618/ --- (Updated March 5, 2014, 4:23 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Port FrameSVGItem to paint directly Simple port, not the full thing I want to do, but should at least save quite a few copies. Diffs - src/declarativeimports/core/framesvgitem.h 552be6e src/declarativeimports/core/framesvgitem.cpp e567e18 src/declarativeimports/core/svgitem.cpp 6b11046 src/declarativeimports/core/svgtexturenode.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116618/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116618: Port FrameSVGItem to paint directly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116618/#review52097 --- This review has been submitted with commit 6599c2508738d829893ffc7ba4c3f0114caeb8ee by David Edmundson to branch master. - Commit Hook On March 5, 2014, 3:20 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116618/ --- (Updated March 5, 2014, 3:20 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port FrameSVGItem to paint directly Simple port, not the full thing I want to do, but should at least save quite a few copies. Diffs - src/declarativeimports/core/framesvgitem.h 552be6e src/declarativeimports/core/framesvgitem.cpp e567e18 src/declarativeimports/core/svgitem.cpp 6b11046 src/declarativeimports/core/svgtexturenode.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116618/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
AFAIK it's unused, and was just a clone for ivan's testing shell switching testing We probably don't want it in the release. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
On Wednesday 05 March 2014 17:47:41 David Edmundson wrote: AFAIK it's unused, and was just a clone for ivan's testing shell switching testing We probably don't want it in the release. maybe moving it in examples? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
maybe moving it in examples? +1 -- The problem with object-oriented languages is they’ve got all this implicit environment that they carry around with them. You wanted a banana but what you got was a gorilla holding the banana. -- Joe Armstrong ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
On Wed, Mar 5, 2014 at 6:04 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 05 March 2014 17:47:41 David Edmundson wrote: AFAIK it's unused, and was just a clone for ivan's testing shell switching testing We probably don't want it in the release. yes please. maybe moving it in examples? I wouldn't do that. At the moment it's little more than a fork of the desktop shell from some time ago. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Aleix ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
On Wednesday 05 March 2014 18:50:14 Aleix Pol wrote: On Wed, Mar 5, 2014 at 6:04 PM, Marco Martin notm...@gmail.com wrote: On Wednesday 05 March 2014 17:47:41 David Edmundson wrote: AFAIK it's unused, and was just a clone for ivan's testing shell switching testing We probably don't want it in the release. yes please. maybe moving it in examples? I wouldn't do that. At the moment it's little more than a fork of the desktop shell from some time ago. so let's just kill it. Ivan. do you still need it for tests? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Can I remove kde-workspace/plasma/desktop/qmlpackages/blank
so let's just kill it. Ivan. do you still need it for tests? I guess no. Until we have a second shell (active or whatever) I don't really have anything to do there. -- Make your code readable. Pretend the next person who looks at your code is a psychopath and they know where you live. -- Philip Wadler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116621: New activity switcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116621/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: kde-workspace Description --- Needed further improvements: - close on lost focus (not only activities switcher) - focus on open (not only activities switcher) - activity creation and configuration dialogues (investigate where the hell they are opening) Diffs - plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityBrowser.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityDelegate.qml 0decbf1 plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityItem.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityList.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityManager.qml 3aa7daa plasma/desktop/qmlpackages/desktop/contents/activitymanager/ControlButton.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/Heading.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/WindowPreview.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116621/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[kde-runtime/frameworks] kioexec: This basically makes kioexec work, by finishing the port
Git commit 84317812ee91ff504644aa999d2e681266b412a1 by Àlex Fiestas.
Committed on 05/03/2014 at 18:54.
Pushed by afiestas into branch 'frameworks'.
This basically makes kioexec work, by finishing the port
It is quite embarassing from our part (if you ask me) that we had this
in this state. It clearly shows that nobody has been running
kde-runtime from frameworks.
Please, start using the proper kde-runtime (until today kdesrc-build
pointed to kde-runtime/master).
CCMAIL: plasma-devel@kde.org
M +36 -33 kioexec/main.cpp
M +4-3kioexec/main.h
http://commits.kde.org/kde-runtime/84317812ee91ff504644aa999d2e681266b412a1
diff --git a/kioexec/main.cpp b/kioexec/main.cpp
index 7f4d1e7..6aeb5f7 100644
--- a/kioexec/main.cpp
+++ b/kioexec/main.cpp
@@ -38,7 +38,6 @@
#include klocale.h
#include KLocalizedString
#include KStandardDirs
-#include kcmdlineargs.h//remove it
#include kdeversion.h
#include kaboutdata.h
#include kstartupinfo.h
@@ -52,24 +51,19 @@ static const char description[] =
I18N_NOOP(KIO Exec - Opens remote files, watches modifications, asks
for upload);
-KIOExec::KIOExec()
+KIOExec::KIOExec(const QStringList args, bool tempFiles, const QString
suggestedFileName)
: mExited(false)
{
-KCmdLineArgs *args = KCmdLineArgs::parsedArgs();
-if (args-count() 1)
-KCmdLineArgs::usageError(i18n('command' expected.\n));
-
-tempfiles = args-isSet(tempfiles);
-if ( args-isSet( suggestedfilename ) )
-suggestedFileName = args-getOption( suggestedfilename );
+mTempFiles = tempFiles;
+mSuggestedFileName = suggestedFileName;
expectedCounter = 0;
jobCounter = 0;
-command = args-arg(0);
+command = args.first();
qDebug() command= command;
-for ( int i = 1; i args-count(); i++ )
+for ( int i = 1; i args.count(); i++ )
{
-QUrl url = args-url(i);
+QUrl url(args.value(i));
url = KIO::NetAccess::mostLocalUrl( url, 0 );
//kDebug() url= url.url() filename= url.fileName();
@@ -87,7 +81,7 @@ KIOExec::KIOExec()
{
if ( !url.isValid() )
KMessageBox::error( 0L, i18n( The URL %1\nis malformed ,
url.url() ) );
-else if ( tempfiles )
+else if ( mTempFiles )
KMessageBox::error( 0L, i18n( Remote URL %1\nnot allowed with
--tempfiles switch , url.url() ) );
else
// We must fetch the file
@@ -116,9 +110,8 @@ KIOExec::KIOExec()
}
}
}
-args-clear();
-if ( tempfiles )
+if ( mTempFiles )
{
slotRunApp();
return;
@@ -218,7 +211,7 @@ void KIOExec::slotRunApp()
if ( (KDE::stat( src, buff ) == 0)
((*it).time != buff.st_mtime) )
{
-if ( tempfiles )
+if ( mTempFiles )
{
if ( KMessageBox::questionYesNo( 0L,
i18n( The supposedly
temporary file\n%1\nhas been modified.\nDo you still want to delete it?,
dest.toDisplayString(QUrl::PreferLocalFile)),
@@ -242,7 +235,7 @@ void KIOExec::slotRunApp()
}
}
-if ((!dest.isLocalFile() || tempfiles) exit_code == 0) {
+if ((!dest.isLocalFile() || mTempFiles) exit_code == 0) {
// Wait for a reasonable time so that even if the application
forks on startup (like OOo or amarok)
// it will have time to start up and read the file before it gets
deleted. #130709.
qDebug() sleeping...;
@@ -258,26 +251,36 @@ void KIOExec::slotRunApp()
int main( int argc, char **argv )
{
-/* K4AboutData aboutData( kioexec, kioexec, ki18n(KIOExec),
- *KDE_VERSION_STRING, ki18n(description), KAboutData::License_GPL,
- *ki18n((c) 1998-2000,2003 The KFM/Konqueror Developers));
- *aboutData.addAuthor(ki18n(David Faure),KLocalizedString(),
fa...@kde.org);
- *aboutData.addAuthor(ki18n(Stephan Kulow),KLocalizedString(),
co...@kde.org);
- *aboutData.addAuthor(ki18n(Bernhard
Rosenkraenzer),KLocalizedString(), b...@arklinux.org);
- *aboutData.addAuthor(ki18n(Waldo Bastian),KLocalizedString(),
bast...@kde.org);
- *aboutData.addAuthor(ki18n(Oswald Buddenhagen),KLocalizedString(),
o...@kde.org);
- *aboutData.setProgramIconName(kde);
- */
-QCommandLineParser parser;
-/*parser.addOption(QCommandLineOption(QStringList() tempfiles ,
i18n(Treat URLs as local files and delete them afterwards)));
-parser.addOption(QCommandLineOption(QStringList() suggestedfilename
file name , ki18n(Suggested file name for the downloaded file)));
-parser.addOption(QCommandLineOption(QStringList() +command,
i18n(Command to execute)));
-parser.addOption(QCommandLineOption(QStringList() +[URLs],
i18n(URL(s) or local file(s) used for 'command'))); */
QApplication app( argc, argv);
+KAboutData aboutData( kioexec,
Re: Review Request 116621: New activity switcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116621/ --- (Updated March 5, 2014, 7:07 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Marco Martin and Sebastian Kügler. Repository: kde-workspace Description --- Needed further improvements: - close on lost focus (not only activities switcher) - focus on open (not only activities switcher) - activity creation and configuration dialogues (investigate where the hell they are opening) Diffs - plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityBrowser.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityDelegate.qml 0decbf1 plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityItem.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityList.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/ActivityManager.qml 3aa7daa plasma/desktop/qmlpackages/desktop/contents/activitymanager/ControlButton.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/Heading.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION plasma/desktop/qmlpackages/desktop/contents/activitymanager/WindowPreview.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116621/diff/ Testing --- Thanks, Ivan Čukić ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52206
---
Good work!
Neat and best solution as of whatever we came across till now! From my side, it
should go ahead. Please wait for some time in case any one has any concern.
shells/newshell/package/contents/ui/mediacenter.qml
https://git.reviewboard.kde.org/r/116620/#comment36996
Please follow, if-else code format as:
if (condition) {
// statement
} else {
// statement
}
- Sinny Kumari
On March 5, 2014, 5:46 p.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---
(Updated March 5, 2014, 5:46 p.m.)
Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and
Sujith Haridasan.
Repository: plasma-mediacenter
Description
---
Playlist was not reachable from home screen as reported in Bug 322820 :
https://bugs.kde.org/show_bug.cgi?id=322820
Default behavior of pmc when user clicks on empty area is to show the media
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and
there is no media playing, so that user can now access playlists from
there.Clicking again will hide the controller.
If we want to show the playlist page directly by clicking the empty area (i.e
no media controller shown) then the 154th line can be changed to :
pmcPageStack.pushAndFocus(getPlaylist());
Diffs
-
shells/newshell/package/contents/ui/mediacenter.qml 49ea403
Diff: https://git.reviewboard.kde.org/r/116620/diff/
Testing
---
1.On welcome screen, (when no media is playing) clicked on empty area and the
media controller is showing and it goes into hiding by clicking again in
empty area.
2.Left the media controller visible on welcome screen and started some media
and then again went back to welcome screen, media controller is not visible
now.
Thanks,
Ashish Madeti
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 5, 2014, 7:38 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Changed the if-else code format as pointed out by Sinny. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Next alpha release engineering bits
El Dimecres, 5 de març de 2014, a les 13:10:12, Sebastian Kügler va escriure: Hi, As we're planning to release the first alpha of Plasma Next next week, I'd like to go over some details that need discussing. - promo preparations - tagging / tarballing: can happen anytime on Thursday next week - smoke-testing of packages - rolling out packages on Monday, or sooner depending on testing? We'll need someone to roll the tarballs and put them on the download site. Who is willing to help here? Sorry but personally I don't have the capacity to help, next week, i'll be doing 4.13 Beta 2. For the tagging and tarballing part, have a look at http://quickgit.kde.org/?p=sysadmin%2Frelease-tools.git we are using for both 4.x and KF5. dfaure is doing the KF5 part so that means that even if i wrote them it seems they are not that hard to understand/reuse. Cheers, Albert Affected repositories: - plasma-framework - kde-workspace - kde-runtime - kwin-compositing-kcm Am I missing something, perhaps the wallpapers? We have some bits in kde- baseapps that could be useful, should we include that as well (as sort of limited tarball)? This means: don't make changes to frameworks other than plasma-framework that are required, we'll not be able to include them in the Alpha. It also means that if you have invasive changes, get them in NOW, we need some time to stabilize them. Cheers, ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- Review request for Plasma. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116625: Oxygen as default font
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 --- startkde.cmake https://git.reviewboard.kde.org/r/116625/#comment37007 Why not just change the defaults in frameworkintegration instead of writing directly into users settings? - Hrvoje Senjan On March 6, 2014, 1:08 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/ --- (Updated March 6, 2014, 1:08 a.m.) Review request for Plasma. Repository: kde-workspace Description --- Make Oxygen the default font This has three portions: the fonts itself, installation of them including fontconfig bits, and setting font defaults in kdeglobals. Oxygen Font 0.4 Imported from oxygen-font repository. The startkde portion contains the bits to write out a kdeglobals default file if it doesn't exist with font settings applied. Usually, with install prefix set to /usr, the installed oxygen font is found automatically by fontconfig. If we're installed to a different prefix, we need to point fontconfig at the font. We do that by linking it from either XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is irrelevant for systems that install into /usr. Diffs - CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 fonts/CMakeLists.txt PRE-CREATION fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION fonts/oxygen/GPL.txt PRE-CREATION fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION fonts/oxygen/README PRE-CREATION startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 Diff: https://git.reviewboard.kde.org/r/116625/diff/ Testing --- Logged into session with clean config. Font settings are applied correctly throughout. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review5 --- A better way would be to just show the playlist instead of showing the controller, because the controller is useless when nothing is playing. See if it works good if you simply show the playlist. - Shantanu Tushar On March 5, 2014, 7:38 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 5, 2014, 7:38 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen
On March 6, 2014, 5:07 a.m., Shantanu Tushar wrote: A better way would be to just show the playlist instead of showing the controller, because the controller is useless when nothing is playing. See if it works good if you simply show the playlist. Yes! This approach will be more sensible. - Sinny --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/#review5 --- On March 5, 2014, 7:38 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116620/ --- (Updated March 5, 2014, 7:38 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Playlist was not reachable from home screen as reported in Bug 322820 : https://bugs.kde.org/show_bug.cgi?id=322820 Default behavior of pmc when user clicks on empty area is to show the media player instance when some media is playing and if not then it does nothing. This patch will show the media controller when empty area is clicked and there is no media playing, so that user can now access playlists from there.Clicking again will hide the controller. If we want to show the playlist page directly by clicking the empty area (i.e no media controller shown) then the 154th line can be changed to : pmcPageStack.pushAndFocus(getPlaylist()); Diffs - shells/newshell/package/contents/ui/mediacenter.qml 49ea403 Diff: https://git.reviewboard.kde.org/r/116620/diff/ Testing --- 1.On welcome screen, (when no media is playing) clicked on empty area and the media controller is showing and it goes into hiding by clicking again in empty area. 2.Left the media controller visible on welcome screen and started some media and then again went back to welcome screen, media controller is not visible now. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116626: Fix for Bug 325012 - Playlist reordering works only in one direction
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116626/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Playlist reordering used to work only in one direction i.e you could only drag a media to somewhere below it's current index. After this patch it will work both ways. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 Diff: https://git.reviewboard.kde.org/r/116626/diff/ Testing --- Reordered a playlist both ways. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
