kde-l10n-* pre-releases rolled from wrong l10n branch
Aloha It was brought to my attention that both czech and slovenian language tars apparently do not result in a fully translated plasmas for 4.12.95 (e.g. [1]). Looking at the cs tar I see no launcher po but a kickoff po: ~/tmp/kde-l10n-cs-4.12.95/messages/kde-workspace ls *kickoff* plasma_applet_kickoff.po ~/tmp/kde-l10n-cs-4.12.95/messages/kde-workspace ls *launcher* zsh: no matches found: *launcher* Looking at kde-workspace KDE/4.11 I see launcher as expected: ~/src/git/k/kde-workspace/plasma KDE/4.11 grep -r insertCata desktop/applets/kickoff desktop/applets/kickoff/applet/applet.cpp: KGlobal::locale()-insertCatalog(plasma_applet_launcher); desktop/applets/kickoff/simpleapplet/simpleapplet.cpp: KGlobal::locale()-insertCatalog(plasma_applet_launcher); Looking at SVN I see launcher in stable and kickoff in trunk: http://websvn.kde.org/branches/stable/l10n-kde4/cs/messages/kde-workspace/plasma_applet_launcher.po?view=log http://websvn.kde.org/trunk/l10n-kde4/templates/messages/kde-workspace/plasma_applet_kickoff.pot?view=log So, it appears to me that kde-l10n-cs-4.12.95 (and supposedly all other languages) have the kde-workspace directory from trunk rather than stable resulting in incomplete localization. Would be lovely if someone could clarify/fix things. [1] https://bugs.launchpad.net/ubuntu/+source/kde-l10n-cs/+bug/1295398 HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-l10n-* pre-releases rolled from wrong l10n branch
That is known and will be fixed for the final release of 4.13 Cheers, Albert P.S: I thought noone would realize, good work :D - Mensaje original - De: Harald Sitter sit...@kde.org Para: KDE release coordination release-t...@kde.org; kde-i18n-...@kde.org kde-i18n-...@kde.org; plasma-devel@kde.org CC: Enviado: Jueves 27 de marzo de 2014 10:23 Asunto: kde-l10n-* pre-releases rolled from wrong l10n branch Aloha It was brought to my attention that both czech and slovenian language tars apparently do not result in a fully translated plasmas for 4.12.95 (e.g. [1]). Looking at the cs tar I see no launcher po but a kickoff po: ~/tmp/kde-l10n-cs-4.12.95/messages/kde-workspace ls *kickoff* plasma_applet_kickoff.po ~/tmp/kde-l10n-cs-4.12.95/messages/kde-workspace ls *launcher* zsh: no matches found: *launcher* Looking at kde-workspace KDE/4.11 I see launcher as expected: ~/src/git/k/kde-workspace/plasma KDE/4.11 grep -r insertCata desktop/applets/kickoff desktop/applets/kickoff/applet/applet.cpp: KGlobal::locale()-insertCatalog(plasma_applet_launcher); desktop/applets/kickoff/simpleapplet/simpleapplet.cpp: KGlobal::locale()-insertCatalog(plasma_applet_launcher); Looking at SVN I see launcher in stable and kickoff in trunk: http://websvn.kde.org/branches/stable/l10n-kde4/cs/messages/kde-workspace/plasma_applet_launcher.po?view=log http://websvn.kde.org/trunk/l10n-kde4/templates/messages/kde-workspace/plasma_applet_kickoff.pot?view=log So, it appears to me that kde-l10n-cs-4.12.95 (and supposedly all other languages) have the kde-workspace directory from trunk rather than stable resulting in incomplete localization. Would be lovely if someone could clarify/fix things. [1] https://bugs.launchpad.net/ubuntu/+source/kde-l10n-cs/+bug/1295398 HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-l10n-* pre-releases rolled from wrong l10n branch
On Thu, Mar 27, 2014 at 10:46 AM, Albert Astals Cid aa...@kde.org wrote: That is known and will be fixed for the final release of 4.13 Cheers, Albert P.S: I thought noone would realize, good work :D lol :P ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
The happy bugs thread
Yesterday we started a bug triage session. BShah then joined in and went completely nuts. Results are looking awesome: https://bugs.kde.org/reports.cgi?product=plasma-shelloutput=show_chartdatasets=CONFIRMEDdatasets=ASSIGNEDdatasets=REOPENEDdatasets=UNCONFIRMED In general 'unconfirmed' bugs should be close to 0, and the number of bugs tagged under 'general' should also be there. Another awesome graph is this one https://bugs.kde.org/reports.cgi?product=plasma-shelloutput=show_chartdatasets=RESOLVED which shows just how many bugs we've fixed. Good work \o/ David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The happy bugs thread
On Thursday 27 March 2014 10:58:47 David Edmundson wrote: Yesterday we started a bug triage session. BShah then joined in and went completely nuts. Results are looking awesome: https://bugs.kde.org/reports.cgi?product=plasma-shelloutput=show_chartdata sets=CONFIRMEDdatasets=ASSIGNEDdatasets=REOPENEDdatasets=UNCONFIRMED In general 'unconfirmed' bugs should be close to 0, and the number of bugs tagged under 'general' should also be there. Another awesome graph is this one https://bugs.kde.org/reports.cgi?product=plasma-shelloutput=show_chartdata sets=RESOLVED which shows just how many bugs we've fixed. Awesome work :) i was wondering this moring why the cunt was so smaller than yesterday ;) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell
https://bugs.kde.org/show_bug.cgi?id=328593 Bhushan Shah bhus...@gmail.com changed: What|Removed |Added CC||bhus...@gmail.com Depends on||330757 -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell
https://bugs.kde.org/show_bug.cgi?id=328593 Bhushan Shah bhus...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The happy bugs thread
On Thu, Mar 27, 2014 at 3:38 PM, Marco Martin notm...@gmail.com wrote: i was wondering this moring why the cunt was so smaller than yesterday ;) I'm sorry but how's that even related ? :P A typo perhaps ? Anyways, awesome work indeed ! Cheers. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The happy bugs thread
On Thu, Mar 27, 2014 at 3:28 PM, David Edmundson da...@davidedmundson.co.uk wrote: which shows just how many bugs we've fixed. never mind, I am going to report many more! ;P -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
On March 26, 2014, 6:09 p.m., Alex Merry wrote: All looks sane. Is this Qt4 or Qt5? Because you've got a KUrl in the added code... Bhushan Shah wrote: Qt4 OK, that's fine then. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54220 --- On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 5:23 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/ --- (Updated March 27, 2014, 11:22 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Since I was having troubles building from the latest source, I started off again from a fresh clone and made changes which I believe fix the issue. Bugs: 330990 and Bug http://bugs.kde.org/show_bug.cgi?id=330990 http://bugs.kde.org/show_bug.cgi?id=Bug Repository: plasma-mediacenter Description --- Now the next and previous buttons do not work unless a media is playing. Diffs - mediaelements/playlist/Playlist.qml fd83c21 Diff: https://git.reviewboard.kde.org/r/116874/diff/ Testing --- I've done the testing for this patch. These are the steps that I followed. 1. Added a new playlist and added a few songs to the playlist. 2. Re-opened Plasma Media Center 3. Clicked the Next and Previous buttons. 4. Nothing was played. 5. Selected a song from the list and then tested the next and previous buttons. 6. The buttons worked seamlessly. File Attachments (updated) pulled the latest source and made changes https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: The happy bugs thread
On Thursday 27 March 2014 16:24:14 R.Harish Navnit wrote: On Thu, Mar 27, 2014 at 3:38 PM, Marco Martin notm...@gmail.com wrote: i was wondering this moring why the cunt was so smaller than yesterday ;) I'm sorry but how's that even related ? :P A typo perhaps ? Anyways, awesome work indeed ! oh, damnit, but *count* it was a bug *count* :p -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54293
---
If a button doesn't do anything, it should be indicated by disabling it, not
just making it a no-op.
mediaelements/playlist/Playlist.qml
https://git.reviewboard.kde.org/r/116874/#comment37984
Add { } to the if statement, it makes the code easier to read, and prevents
errors when people insert a line without adjusting {}
It's also Plasma's recommended coding style.
mediaelements/playlist/Playlist.qml
https://git.reviewboard.kde.org/r/116874/#comment37985
indenting is wrong now
- Sebastian Kügler
On March 27, 2014, 11:22 a.m., R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 27, 2014, 11:22 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug
Repository: plasma-mediacenter
Description
---
Now the next and previous buttons do not work unless a media is playing.
Diffs
-
mediaelements/playlist/Playlist.qml fd83c21
Diff: https://git.reviewboard.kde.org/r/116874/diff/
Testing
---
I've done the testing for this patch.
These are the steps that I followed.
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous
buttons.
6. The buttons worked seamlessly.
File Attachments
pulled the latest source and made changes
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch
Thanks,
R.Harish Navnit
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 4:02 p.m.) Review request for Plasma. Changes --- Wrong group, it's not for frameworks even though that's for the frameworks port of plasma-nm. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
On March 27, 2014, 1:05 p.m., Sebastian Kügler wrote:
mediaelements/playlist/Playlist.qml, line 159
https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line159
indenting is wrong now
I have added a new diff file after I pulled the latest source and built
successfully. Please do check that
patch(https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch),
I've added {} to the if-statement in that one. It however, isn't disabled when
the playlist isn't active.
- R.Harish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54293
---
On March 27, 2014, 11:22 a.m., R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 27, 2014, 11:22 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug
Repository: plasma-mediacenter
Description
---
Now the next and previous buttons do not work unless a media is playing.
Diffs
-
mediaelements/playlist/Playlist.qml fd83c21
Diff: https://git.reviewboard.kde.org/r/116874/diff/
Testing
---
I've done the testing for this patch.
These are the steps that I followed.
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous
buttons.
6. The buttons worked seamlessly.
File Attachments
pulled the latest source and made changes
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch
Thanks,
R.Harish Navnit
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
On March 27, 2014, 1:05 p.m., Sebastian Kügler wrote:
mediaelements/playlist/Playlist.qml, line 159
https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line159
indenting is wrong now
R.Harish Navnit wrote:
I have added a new diff file after I pulled the latest source and built
successfully. Please do check that
patch(https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch),
I've added {} to the if-statement in that one. It however, isn't disabled
when the playlist isn't active.
Can you update the diff in the review instead of attaching it? Otherwise its
not possible to leave comments on code.
- Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54293
---
On March 27, 2014, 11:22 a.m., R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 27, 2014, 11:22 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug
Repository: plasma-mediacenter
Description
---
Now the next and previous buttons do not work unless a media is playing.
Diffs
-
mediaelements/playlist/Playlist.qml fd83c21
Diff: https://git.reviewboard.kde.org/r/116874/diff/
Testing
---
I've done the testing for this patch.
These are the steps that I followed.
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous
buttons.
6. The buttons worked seamlessly.
File Attachments
pulled the latest source and made changes
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch
Thanks,
R.Harish Navnit
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/#review54353 --- Doesn't really look on my box http://i.imgur.com/nJMYi9E.jpg Also, I think the right fix for these things is to use one of PlasmaExtras.Heading, PlasmaExtras.Title (or PlasmaExtras.Paragraph when applicable). Can someone else comment on whether making the font depend on window size is a good idea? - Shantanu Tushar On March 26, 2014, 9:29 p.m., Nikolaos Chatzidakis wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/ --- (Updated March 26, 2014, 9:29 p.m.) Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This is my first patch trying to hack PMC. Untill now, whenever PMC was resized, the menu strings font size remained fixed. Now it changes the font size according to parents dimensions. Diffs - mediaelements/mediawelcome/BackendsListDelegate.qml 4840982 mediaelements/mediawelcome/MediaWelcome.qml a3108d8 Diff: https://git.reviewboard.kde.org/r/117101/diff/ Testing --- The size of the icons in the menus remains the same, due to the file format (png). Converting these graphics to SVG may solve the graphics resize issue as well. Thanks, Nikolaos Chatzidakis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasma 2014.6 Alpha 1
Alpha 1 is due out on Tuesday but due to the splitting of kde-runtme and kde-workspace I'm going to try and get it tagged and tarred tomorrow. If you have any must have patched to get in time to do it toot sweet. I'll also tar up oxygen-fonts as Plasma now uses it by default. Then I'll send it around the packagers for mulling over and hopefully we can announce on Tuesday. Sebas and Jos are working on publicity. kde-runtime isn't currently co-installable so we'll have to highlight that it can't be installed alongside stuff using kdelibs4 yet. (But I'm working on patches, reviews needed https://git.reviewboard.kde.org/users/jriddell/ ) How does that sound? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- break as in.. ? - Marco Martin On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 2014.6 Alpha 1
On Thursday, March 27, 2014 17:55:41 Jonathan Riddell wrote: Alpha 1 is due out on Tuesday but due to the splitting of kde-runtme and kde-workspace I'm going to try and get it tagged and tarred tomorrow. If you have any must have patched to get in time to do it toot sweet. I'll also tar up oxygen-fonts as Plasma now uses it by default. Then I'll send it around the packagers for mulling over and hopefully we can announce on Tuesday. Sebas and Jos are working on publicity. kde-runtime isn't currently co-installable so we'll have to highlight that it can't be installed alongside stuff using kdelibs4 yet. (But I'm working on patches, reviews needed https://git.reviewboard.kde.org/users/jriddell/ ) How does that sound? Solid. :) Thanks for handling it! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/#review54359 --- This review has been submitted with commit 1984f5d1fa63eeb8d27f9d8d2c5ac31d9af99efa by Alex Richardson to branch frameworks. - Commit Hook On March 27, 2014, 4:02 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 4:02 p.m.) Review request for Plasma. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/#review54360 --- This review has been submitted with commit 647158be634408413a1a9d654eec2f91a6eafab7 by Alex Richardson to branch frameworks. - Commit Hook On March 27, 2014, 4:02 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 4:02 p.m.) Review request for Plasma. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117058: plasma-nm CMake fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/ --- (Updated March 27, 2014, 6:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-nm Description --- Don't find frameworks that are not required for compilation -- Also search CMAKE_PREFIX_PATH for the pkgconfig files This will be the default behaviour when requiring CMake = 3.1 Diffs - CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 Diff: https://git.reviewboard.kde.org/r/117058/diff/ Testing --- Fixes compilation for me using kdesrc-build. Before it failed because it couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search path) Thanks, Alexander Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. Marco Martin wrote: uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png ah, no, apparently depends from where the applet is - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. Marco Martin wrote: uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png Marco Martin wrote: ah, no, apparently depends from where the applet is well, i don't see where locateinsideparent should be true. right now locateinsideparent = true if the window is a desktop.. and that doesn't seem to make any sense? if i remove completely locateinsideparent everything seems to just work? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54371 --- This review has been submitted with commit 2b9d28e02660906a41b4809635f2de1ee5007cdf by Ashish Madeti to branch sujith-dbus-mpris. - Commit Hook On March 26, 2014, 5:23 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 26, 2014, 5:23 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 27, 2014, 8:33 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Changes in plasma desktop scripting
Hi all, we had still a problem in the plasma desktop scripting api, because it comes from a time when one containment == one activity, therefore right now adding new activities from the script is pretty much broken. Since now is the only moment we can screw the api, today I made the following changes: activities() - desktops() activityById() - desktopById() activityForScreen() - desktopForScreen() To create a new activity, there is the new global function createActivity(activtyName, containmentPlugin (optional)) when you want to access the actual containments created by the activity, you do Array[containments] = desktopsForActivity(activityId) Opinions? comments? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review54375 --- This review has been submitted with commit 9d7fb9c1efa1228c3a8ddcd6ed2a28424f6dbe8a by Ashish Madeti to branch sujith-dbus-mpris. - Commit Hook On March 27, 2014, 8:33 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 27, 2014, 8:33 p.m.) Review request for Plasma, Alex Merry, Eike Hein, Nikolaos Chatzidakis, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef mediaelements/mediaplayer/MediaPlayer.qml 39ed617 shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Changes in plasma desktop scripting
On Thursday 27 March 2014 21:39:12 Marco Martin wrote: Hi all, we had still a problem in the plasma desktop scripting api, because it comes from a time when one containment == one activity, therefore right now adding new activities from the script is pretty much broken. Since now is the only moment we can screw the api, today I made the following changes: activities() - desktops() activityById() - desktopById() activityForScreen() - desktopForScreen() I have also updated the documentation on a clone page of the docs of the plasma1 version: http://techbase.kde.org/KDE_System_Administration/PlasmaTwoDesktopScripting -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. Marco Martin wrote: uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png Marco Martin wrote: ah, no, apparently depends from where the applet is Marco Martin wrote: well, i don't see where locateinsideparent should be true. right now locateinsideparent = true if the window is a desktop.. and that doesn't seem to make any sense? if i remove completely locateinsideparent everything seems to just work? Without ever setting it to true WidgetExplorer won't work when loaded on a second screen which is to the right of the main screen. We would try to position it to the left outside the parentItem (which is the entire screen) so it appears on the wrong screen. The fact that it works in any other case is just a fortunate set of circumstances as the logic to make sure it fits in the screen ends up putting it back. I will need to add the locateInsideParent: true to the relevant part of in kde-workspace. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. Marco Martin wrote: uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png Marco Martin wrote: ah, no, apparently depends from where the applet is Marco Martin wrote: well, i don't see where locateinsideparent should be true. right now locateinsideparent = true if the window is a desktop.. and that doesn't seem to make any sense? if i remove completely locateinsideparent everything seems to just work? David Edmundson wrote: Without ever setting it to true WidgetExplorer won't work when loaded on a second screen which is to the right of the main screen. We would try to position it to the left outside the parentItem (which is the entire screen) so it appears on the wrong screen. The fact that it works in any other case is just a fortunate set of circumstances as the logic to make sure it fits in the screen ends up putting it back. I will need to add the locateInsideParent: true to the relevant part of in kde-workspace. hmm, to me the proper solution would be trying to always put the dialog in the same screen as the parent view - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117121: Add property to determine if popups should be inside or outside the parentItem
On March 27, 2014, 5:57 p.m., Marco Martin wrote: break as in.. ? David Edmundson wrote: Add kickoff to the desktop. Resize it so it's compact then hover over it. Broken. Marco Martin wrote: uhm, works for me? http://wstaw.org/m/2014/03/27/plasma-desktopLW1833.png Marco Martin wrote: ah, no, apparently depends from where the applet is Marco Martin wrote: well, i don't see where locateinsideparent should be true. right now locateinsideparent = true if the window is a desktop.. and that doesn't seem to make any sense? if i remove completely locateinsideparent everything seems to just work? David Edmundson wrote: Without ever setting it to true WidgetExplorer won't work when loaded on a second screen which is to the right of the main screen. We would try to position it to the left outside the parentItem (which is the entire screen) so it appears on the wrong screen. The fact that it works in any other case is just a fortunate set of circumstances as the logic to make sure it fits in the screen ends up putting it back. I will need to add the locateInsideParent: true to the relevant part of in kde-workspace. Marco Martin wrote: hmm, to me the proper solution would be trying to always put the dialog in the same screen as the parent view the proper solution would be trying to always put the dialog in the same screen as the parent view Which is why we need the locateInsideParent. Without it we explicitly calculate that the best position for the widget explorer dialog is off the screen. Calculating something should be completely off the screen and then trying to manipulate it back onto the right screen isn't a very proper solution. We need to fix the initial calculation to be in the right place to start with. Relative to the parent the ideal position for widget explorer and any other popup are completely different. One is on top of the parent, the other is outside it. We need a way to tell dialog that as determining it automatically (what we had before this patch) doesn't work safely enough. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/#review54355 --- On March 27, 2014, 5:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117121/ --- (Updated March 27, 2014, 5:34 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Add property to determine if popups should be inside or outside the parentItem For some cases of dialog we want to position within the parent item for example widget explorer. For popup applets on the desktop the dialog should appear outside of the parentItem. Currently we try to determine it automatically from the window type of the parentItem. This worked fine for widget explorer and panels, but breaks for popup applets on the desktop. Diffs - src/plasmaquick/dialog.h 3804d18 src/plasmaquick/dialog.cpp 77c0c8c Diff: https://git.reviewboard.kde.org/r/117121/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options
On March 25, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote: The frameworks version is ready, but the GUI is a complete rewrite as in Plasma 2, C++ plasmoids are not supported. Personally, I don't think these options are needed: 1. I've never had a problem with accidentally sharing anything. 2. the plasmoid should have enough resources to know what size it should be. I would prefer a saner default. Regarding the group, you should use plasma. Gregor Mi wrote: 1. This is why I made it an option. :) In my opinion, potentially private data should not be send to the internet without given the user the chance to know what is happening. When I was using pastebin the first time I was a bit surprised how quick the data went away. Advanced users can easily disable this option. With the do not ask again method suggested by Dominik it should not hurt at all. 2. Are you referring to the default width (or height) of 22.0 pixels? Or the widget geometry in general? Do you already have a saner default in mind? complete rewrite as in Plasma 2, C++ plasmoids are not supported Is plasma2 going to be released with KDE frameworks 5? Because there are still many c++ applets in the frameworks branch. So all of them have to be rewritten? Aleix Pol Gonzalez wrote: 1. So you mean that only advanced users care about sharing too much data? 2. Well, I guess you added this option because the applet became huge, right? Yes, either the applets get rewritten or they die. And actually it's not a trivial task. Dominik Haumann wrote: Hi Aleix, to 1) I'm pretty sure this is not at all what Gregor wants to say. It's more like the behavior should be: - On a fresh install, the message box asks you whether you really want to send the data. - This message box always pops up, except if you - either activated [x] Don't show again, - or you deactivated in the settings [ ] Ask for confirmation Granted, the code in the review request does not yet fully do that (as far as I can see), but this is totally NOT about advanced users not careing about sharing too much data ;) Gregor Mi wrote: to 1) Dominik is right. to 2) Correct, I find the icon gets massively huge. :) I would very much welcome a saner default. But as with all defaults I guess this will be a big discussion. Maybe others like the huge icon? I would like to have the icons start stacking vertically if the certain panel width is reached as it is already done with the system tray icons (see http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png). Or do it like in Windows 7 (just have a thin button with no text or icon at all for the show desktop feature)? 1) What about leaving some time before it starts sending so you can stop the sending instead? A bit like the undo send e-mail in GMail. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117041/#review54054 --- On March 27, 2014, 11:54 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117041/ --- (Updated March 27, 2014, 11:54 p.m.) Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Ivan Čukić. Repository: kdeplasma-addons Description --- Summary --- Add two options: 1. Show confirmation before sending (to prevent accidental sending of maybe sensible data) 2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels) How does this change manifest on screen? Settings dialog: - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png Behaviour: 1. Show confirmation before sending turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png 2. Appearance: Restrict width on large host panel - turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray) - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space) Open issues --- - Is there a default review board TARGET_GROUP for kdeplasma-addons review-request? @apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin? Diffs - applets/pastebin/pastebinConfig.ui
