Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/#review62748
---

Ship it!


Ship It!

- Sinny Kumari


On July 20, 2014, 5:14 p.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119250/
> ---
> 
> (Updated July 20, 2014, 5:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> I got this idea on a recent trip that usually a family would have a device 
> where they store their trips/events photos on. Easier than tagging 
> everything, what if you could just say "Hey, I went to Kashmir during 5 April 
> to 14 April 2014" and voila!
> 
> This backend implements this idea in a (hopefully) easy-to-use way. I'll love 
> to hear some feedback around this :)
> 
> 
> Diffs
> -
> 
>   browsingbackends/metadatabackends/CMakeLists.txt ae56603 
>   browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.h 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp 
> PRE-CREATION 
>   browsingbackends/onlineservices/picasa/picasabackend.h 83b3eb2 
>   browsingbackends/onlineservices/picasa/picasabackend.cpp b01ba4a 
>   browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 
> d15a46e 
>   libs/mediacenter/abstractbrowsingbackend.h 14ad502 
>   libs/mediacenter/abstractbrowsingbackend.cpp 6cd32f8 
>   libs/mediacenter/backendsmodel.cpp 2823fb6 
>   libs/mediacenter/filtermediamodel.h b8272f6 
>   mediaelements/mediabrowser/MediaBrowser.qml b4ebdf9 
>   shells/newshell/package/contents/ui/mediacenter.qml 15c9cee 
> 
> Diff: https://git.reviewboard.kde.org/r/119250/diff/
> 
> 
> Testing
> ---
> 
> Seems to work as expected, I will be attaching screenshots.
> 
> 
> File Attachments
> 
> 
> Showing events
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
> Showing photos from an event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
> Editing dates of an existing event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: ToolButtons and focus

2014-07-20 Thread Marco Martin 
On Sunday 20 July 2014, Frederik Gladhorn wrote:
> That made me wonder if Tool Buttons shouldn't receive the tab focus by
> default. I'm not 100% sure, but my gut-feeling says that might be a good
> idea. Currently that's intentionally not the case - aligning well with
> QWidgets. I wonder though if the plasma use of tool buttons is not quite
> often a different one, more like normal small buttons...

yes, receiving focus would be a good idea, since there are usually no tabbar 
in plasmoids (btw there is a tabbar component, even tough not used often, if 
one would be fancy could even be checked the parent and make it tabbable only 
if not in a tabbar

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/
---

(Updated July 20, 2014, 5:14 p.m.)


Review request for Plasma.


Changes
---

Prevent empty eventName or an existing eventName when not editing
Also added keyboard trigerring


Repository: plasma-mediacenter


Description
---

I got this idea on a recent trip that usually a family would have a device 
where they store their trips/events photos on. Easier than tagging everything, 
what if you could just say "Hey, I went to Kashmir during 5 April to 14 April 
2014" and voila!

This backend implements this idea in a (hopefully) easy-to-use way. I'll love 
to hear some feedback around this :)


Diffs (updated)
-

  browsingbackends/metadatabackends/CMakeLists.txt ae56603 
  browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.h PRE-CREATION 
  
browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml 
PRE-CREATION 
  
browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml
 PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp 
PRE-CREATION 
  browsingbackends/onlineservices/picasa/picasabackend.h 83b3eb2 
  browsingbackends/onlineservices/picasa/picasabackend.cpp b01ba4a 
  browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 
d15a46e 
  libs/mediacenter/abstractbrowsingbackend.h 14ad502 
  libs/mediacenter/abstractbrowsingbackend.cpp 6cd32f8 
  libs/mediacenter/backendsmodel.cpp 2823fb6 
  libs/mediacenter/filtermediamodel.h b8272f6 
  mediaelements/mediabrowser/MediaBrowser.qml b4ebdf9 
  shells/newshell/package/contents/ui/mediacenter.qml 15c9cee 

Diff: https://git.reviewboard.kde.org/r/119250/diff/


Testing
---

Seems to work as expected, I will be attaching screenshots.


File Attachments


Showing events
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
Showing photos from an event
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
Editing dates of an existing event
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Assign plasmoid global shortcut to custom action

2014-07-20 Thread Simone Gaiarin 
>From the documentation of Plasma Applet I've red that I need to run
addAssociatedWidget(someWidget) to make the actions work.

I've done this:

//Initialize the plasmoid using an IconWidget
m_button = new Plasma::IconWidget(this);
m_button->setIcon(KIcon("redshift-status-off"));

m_layout = new QGraphicsGridLayout(this);
m_layout->setContentsMargins(0, 0, 0, 0);
m_layout->addItem(m_button, 0, 0);

m_widget = new QWidget();
m_layout->addItem(m_widget->graphicsProxyWidget(), 1, 0);

addAssociatedWidget(m_widget);

but still doesn't work.


2014-07-20 17:01 GMT+02:00 Simone Gaiarin :

> Hi all,
> I'm trying to use the global shortcut that the user can configure from the
> "Shortcut configuration page" of a plasma applet, to trigger a KAction and
> let the plasmoid do something.
>
> I've done this
>
> //Setup the action
> m_toggleAction = new KAction("ToggleAction", this);
> //Add action to the plasmoid action collection
> addAction("ToggleAction", m_toggleAction);
> m_toggleAction->setGlobalShortcut(globalShortcut());
> connect(m_toggleAction, SIGNAL(triggered(bool)), this, SLOT(toggle()));
>
> but nothing happens when I trigger the shortcut. Do anyone know what I'm
> missing?
> Is there any plasmoid that is using the global shortcut feature?
>
> Thanks
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Frederik Gladhorn 


> On July 20, 2014, 4:11 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/LogoutOptions.qml, line 64
> > 
> >
> > I think this may need to be i18ncd; unless someone is setting the 
> > catalog on the c++ side. 
> > Current code has a mix, so Im not sure.

That was actually the main reason for the review request - I dunno how the 
catalog stuff works these days. It would be great if someone could shed some 
light on this :)


> On July 20, 2014, 4:11 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/LogoutOptions.qml, line 94
> > 
> >
> > Should we put this into PlamsaComponents.ToolButton itself?
> > 
> > Is there ever a case where we wouldn't want a toolbutton to be in the 
> > tab chain?

I just sent a mail to plasma-devel, I completely agree on this one.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/#review62741
---


On July 20, 2014, 4:05 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119379/
> ---
> 
> (Updated July 20, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Make lockscreen buttons say something and let shutdown/lock/reboot buttons 
> get focus.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
>   lookandfeel/contents/components/UserDelegate.qml 2221368 
> 
> Diff: https://git.reviewboard.kde.org/r/119379/diff/
> 
> 
> Testing
> ---
> 
> Tested with Orca.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

ToolButtons and focus

2014-07-20 Thread Frederik Gladhorn 
Hello,

I just looked at the screen locker from an accessibility point of view (it's 
kinda' buggersome when there's no way to get back into a session after it has 
been locked) and with a bit of nudging (see review request) I can use it 
nicely. Not perfect, but good enough to get back to work.

Now the ToolButton.qml that plasma components ship is by default not 
"tabbable" - pressing tab you'll never land on one of these. For the lock 
screen I think the situation is simple, it should be tab-able, so I added the 
good old activeFocusOnTab property (sidenote: I recommend reading its 
implementation, it's beautiful graph traversal).

That made me wonder if Tool Buttons shouldn't receive the tab focus by 
default. I'm not 100% sure, but my gut-feeling says that might be a good idea. 
Currently that's intentionally not the case - aligning well with QWidgets. I 
wonder though if the plasma use of tool buttons is not quite often a different 
one, more like normal small buttons...

Greetings,
Frederik

PS: please let your tool buttons and other icon-only things have tooltips 
and/or set the Accessible.name. That will make my life as grumpy old man much 
more pleasant. Thanks.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/#review62741
---



lookandfeel/contents/components/LogoutOptions.qml


I think this may need to be i18ncd; unless someone is setting the catalog 
on the c++ side. 
Current code has a mix, so Im not sure.



lookandfeel/contents/components/LogoutOptions.qml


Should we put this into PlamsaComponents.ToolButton itself?

Is there ever a case where we wouldn't want a toolbutton to be in the tab 
chain?


- David Edmundson


On July 20, 2014, 4:05 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119379/
> ---
> 
> (Updated July 20, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Make lockscreen buttons say something and let shutdown/lock/reboot buttons 
> get focus.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
>   lookandfeel/contents/components/UserDelegate.qml 2221368 
> 
> Diff: https://git.reviewboard.kde.org/r/119379/diff/
> 
> 
> Testing
> ---
> 
> Tested with Orca.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/#review62742
---

Ship it!


Ship It!

- Martin Gräßlin


On July 20, 2014, 6:05 p.m., Frederik Gladhorn wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119379/
> ---
> 
> (Updated July 20, 2014, 6:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Make lockscreen buttons say something and let shutdown/lock/reboot buttons 
> get focus.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
>   lookandfeel/contents/components/UserDelegate.qml 2221368 
> 
> Diff: https://git.reviewboard.kde.org/r/119379/diff/
> 
> 
> Testing
> ---
> 
> Tested with Orca.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119379: Lockscreen accessibility

2014-07-20 Thread Frederik Gladhorn 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Make lockscreen buttons say something and let shutdown/lock/reboot buttons get 
focus.


Diffs
-

  lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
  lookandfeel/contents/components/UserDelegate.qml 2221368 

Diff: https://git.reviewboard.kde.org/r/119379/diff/


Testing
---

Tested with Orca.


Thanks,

Frederik Gladhorn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/#review62740
---


Works fine now. Just two minor fix:
1. New events with blank name shouldn't be created. Save button should be 
disabled until name some valid name is enterd
2. Creating a new event with an existing event name ends up editing same. 
Ideally, it should give error message saying event already exits.

- Sinny Kumari


On July 20, 2014, 3:08 p.m., Shantanu Tushar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119250/
> ---
> 
> (Updated July 20, 2014, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> I got this idea on a recent trip that usually a family would have a device 
> where they store their trips/events photos on. Easier than tagging 
> everything, what if you could just say "Hey, I went to Kashmir during 5 April 
> to 14 April 2014" and voila!
> 
> This backend implements this idea in a (hopefully) easy-to-use way. I'll love 
> to hear some feedback around this :)
> 
> 
> Diffs
> -
> 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp 
> PRE-CREATION 
>   browsingbackends/onlineservices/picasa/picasabackend.h 83b3eb2 
>   browsingbackends/onlineservices/picasa/picasabackend.cpp b01ba4a 
>   browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 
> d15a46e 
>   libs/mediacenter/abstractbrowsingbackend.h 14ad502 
>   libs/mediacenter/abstractbrowsingbackend.cpp 6cd32f8 
>   libs/mediacenter/backendsmodel.cpp 2823fb6 
>   libs/mediacenter/filtermediamodel.h b8272f6 
>   mediaelements/mediabrowser/MediaBrowser.qml b4ebdf9 
>   shells/newshell/package/contents/ui/mediacenter.qml 15c9cee 
>   browsingbackends/metadatabackends/CMakeLists.txt ae56603 
>   browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.h 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119250/diff/
> 
> 
> Testing
> ---
> 
> Seems to work as expected, I will be attaching screenshots.
> 
> 
> File Attachments
> 
> 
> Showing events
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
> Showing photos from an event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
> Editing dates of an existing event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/
---

(Updated July 20, 2014, 3:08 p.m.)


Review request for Plasma.


Changes
---

Fix some UI bugs


Repository: plasma-mediacenter


Description
---

I got this idea on a recent trip that usually a family would have a device 
where they store their trips/events photos on. Easier than tagging everything, 
what if you could just say "Hey, I went to Kashmir during 5 April to 14 April 
2014" and voila!

This backend implements this idea in a (hopefully) easy-to-use way. I'll love 
to hear some feedback around this :)


Diffs (updated)
-

  browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp 
PRE-CREATION 
  browsingbackends/onlineservices/picasa/picasabackend.h 83b3eb2 
  browsingbackends/onlineservices/picasa/picasabackend.cpp b01ba4a 
  browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml 
d15a46e 
  libs/mediacenter/abstractbrowsingbackend.h 14ad502 
  libs/mediacenter/abstractbrowsingbackend.cpp 6cd32f8 
  libs/mediacenter/backendsmodel.cpp 2823fb6 
  libs/mediacenter/filtermediamodel.h b8272f6 
  mediaelements/mediabrowser/MediaBrowser.qml b4ebdf9 
  shells/newshell/package/contents/ui/mediacenter.qml 15c9cee 
  browsingbackends/metadatabackends/CMakeLists.txt ae56603 
  browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsbackend.h PRE-CREATION 
  
browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml 
PRE-CREATION 
  
browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml
 PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir 
PRE-CREATION 
  browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119250/diff/


Testing
---

Seems to work as expected, I will be attaching screenshots.


File Attachments


Showing events
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
Showing photos from an event
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
Editing dates of an existing event
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png


Thanks,

Shantanu Tushar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Assign plasmoid global shortcut to custom action

2014-07-20 Thread Simone Gaiarin 
Hi all,
I'm trying to use the global shortcut that the user can configure from the
"Shortcut configuration page" of a plasma applet, to trigger a KAction and
let the plasmoid do something.

I've done this

//Setup the action
m_toggleAction = new KAction("ToggleAction", this);
//Add action to the plasmoid action collection
addAction("ToggleAction", m_toggleAction);
m_toggleAction->setGlobalShortcut(globalShortcut());
connect(m_toggleAction, SIGNAL(triggered(bool)), this, SLOT(toggle()));

but nothing happens when I trigger the shortcut. Do anyone know what I'm
missing?
Is there any plasmoid that is using the global shortcut feature?

Thanks
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel