date:20140825



 On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
  https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62
 
  what happens if you copy a normal http:// url? Is it still shown?
 
 Sebastian Kügler wrote:
 No, we're showing the url text in this case. 
 
 We *could* make it smarter and run the text through QUrl::isValid(), and 
 then switch the type (though with our current rendering, that would probably 
 be less descriptive than just showing the URL text).
 
 Martin Gräßlin wrote:
 that's fine, I was just afraid that switching the check, could have 
 broken it.
 
 I don't think it's a very good idea to download the URL - it's one of the 
 things which can get embarrassing if one copies a tiny url ;-)
 
 Thomas Pfeiffer wrote:
 Couldn't it also open up an attack vector if someone prepares a site with 
 malicious content and gets users to select a link to it (without even making 
 them click the link)?

Not on its own, one would need another broken or leaky component for it to be 
exploitable. It may be a privacy problem, since the downloading of a URL leaves 
traces. Fairly remote, but some people might care.

IOW: let's just drop the idea and leave it to Unity ;)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---


On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119866/
 ---
 
 (Updated Aug. 22, 2014, 2:33 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This patch paints previews of copied images, instead of displaying the urls 
 in plain text.
 
 The display is limited to 4 images right now. The painting of the delegates 
 is in line with the recommendations from the HIG at 
 https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
 
 It has a few rough edges:
 - not all images get thumbnails -- need to investigate why
 - vertical alignment throughout the list is quite bad, this is the case 
 already, I will fix that separately
 - I want to add an indicator that it's more than 4 files (if applicable), 
 working on that still
 - When no preview is loaded, it should show an icon, almost done, with some 
 fixes
 
 I'd like some feedback on the code, so that with the remaining issues fixed, 
 it can get in.
 
 
 Diffs
 -
 
   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
   applets/clipboard/contents/ui/Menu.qml e6821c3 
   applets/clipboard/contents/ui/clipboard.qml ac784d2 
   klipper/CMakeLists.txt 660b0d1 
   klipper/clipboardjob.h b4f5284 
   klipper/clipboardjob.cpp d84d014 
   klipper/historyurlitem.cpp fb2a766 
   klipper/org.kde.plasma.clipboard.operations 813aafa 
 
 Diff: https://git.reviewboard.kde.org/r/119866/diff/
 
 
 Testing
 ---
 
 Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
 that the previews are only loaded when needed, so no additional memory taken 
 when the systray / klipper popup is not open.
 
 
 File Attachments
 
 
 Before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
 Klipper with thumbnails
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
 Klipper with thumbnails 2nd version
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119822: QScreen backend for libkscreen



 On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote:
  Besides the nitpits, here is a concern I have.
  
  KScreen is a library that should be used only by components of the shell 
  (kwin, plasma, kscreen), the idea is to have a library that manipulates 
  lowlevel stuff directly so we can control how we do things (events and what 
  not). Because of this having a qscreen backend enabled by default (even if 
  it is only in platforms where we don't have a backend) imho is a no-go. We 
  can't relay on abstractions.
  
  That said, I do think that having a qscreen backend is an excellent 
  fallback to test the shell in non supported platforms while we develop a 
  proper backend, but we have to find a way of doing so qscreen backend is 
  not used by accident.
  
  To archieve this I see 2 options:
  1-Load qscreen backend only via KSCREEN_BACKEND env
  2-Improve backendloader and backends to make sure we use the proper backend 
  in every case.
  
  I think I will go for 1 at the moment, and we can figure out how to do the 
  backend loading later on.
  
  What do you think?
 
 Martin Gräßlin wrote:
 1 sounds like a sane approach to me especially if it's supposed to be for 
 early testing.
 
 Sebastian Kügler wrote:
 Thanks for the reviews so far, much appreciated. I'll wait for more 
 comments to trickle in and will then address them all in one go - so no 
 updated diff just yet. I think a few things also warrant further discussion, 
 such as:
 
 The alternative to automatically picking the screen backend is that it 
 crashes. To me, that's about the worst possible thing our code could do. It 
 manifests itself by running anything using libkscreen on Wayland not working 
 until you find out about the KSCREEN_BACKEND env var (which is documented 
 exactly nowhere). That means the screen KCM and also plasmashell will just 
 crash. A warning about this sounds much better to me, since it will actually 
 point out what's wrong, instead of hiding it in backtraces one needs to 
 understand first.
 
 I'd much prefer to not having it crash. We can improve the backend 
 picking logic more once we have a proper Wayland backend, in the meantime, 
 I'd want to it not explode by default. It will just make it harder to test 
 anything Wayland.
 
 That's my opinion, and I'll go with whatever the gods that maintain 
 decide, but it's a pretty strong disagreement. :)

ping!


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119822/#review64727
---


On Aug. 20, 2014, 4:35 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119822/
 ---
 
 (Updated Aug. 20, 2014, 4:35 p.m.)
 
 
 Review request for Plasma and Solid.
 
 
 Repository: libkscreen
 
 
 Description
 ---
 
 This patch adds a QScreen backend to libkscreen.
 
 This is useful to avoid a dependency on XRandR (at build time) and a running 
 X server at runtime.
 
 The backend itself is read-only and kept simple. It only reports the basic 
 necessities (which is what QScreen provides).
 
 The changes are kept to the backends/qscreen directory, so no API has been 
 touched. The changes outside of that directory are autotests, tests, and a 
 fallback to the qscreen backend non non-X11 platforms. The latter will 
 automatically make libkscreen work on Wayland (as far as QScreen allows us 
 to, so r-o). This case otherwise just crashes, and the XRandR backend can't 
 work. If the user specifies the backend using the KSCREEN_BACKEND env var, it 
 will be respected, the automatism only triggers when no backend is 
 explicitely specified. I've also added apidocs in some files, but again, no 
 functional changes.
 
 The plan is to augment this also with a native Wayland backend, which will 
 take a bit longer to complete (more complex, it's r-w, I have to learn 
 Wayland APIs). That backend is work-in-progress in the sebas/wayland branch. 
 The QScreen backend allows us to test and run our code under Wayland, without 
 crashing, so we can continue the port while a native Wayland backend is 
 conceived.
 
 You can find the code for this QScreen backend in sebas/qscreen if you'd like 
 to give it a try.
 
 
 Diffs
 -
 
   tests/testplugandplay.cpp PRE-CREATION 
   tests/testpnp.h PRE-CREATION 
   tests/testpnp.cpp PRE-CREATION 
   autotests/CMakeLists.txt 18b93c0 
   autotests/testqscreenbackend.cpp PRE-CREATION 
   backends/CMakeLists.txt a827ee8 
   backends/abstractbackend.h 7ffe627 
   backends/qscreen/CMakeLists.txt PRE-CREATION 
   backends/qscreen/qscreenbackend.h PRE-CREATION 
   backends/qscreen/qscreenbackend.cpp PRE-CREATION 
   backends/qscreen/qscreenconfig.h

Re: Review Request 119866: Thumbnails in Klipper

2014-08-25 Thread Thomas Pfeiffer



 On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
  https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62
 
  what happens if you copy a normal http:// url? Is it still shown?
 
 Sebastian Kügler wrote:
 No, we're showing the url text in this case. 
 
 We *could* make it smarter and run the text through QUrl::isValid(), and 
 then switch the type (though with our current rendering, that would probably 
 be less descriptive than just showing the URL text).
 
 Martin Gräßlin wrote:
 that's fine, I was just afraid that switching the check, could have 
 broken it.
 
 I don't think it's a very good idea to download the URL - it's one of the 
 things which can get embarrassing if one copies a tiny url ;-)
 
 Thomas Pfeiffer wrote:
 Couldn't it also open up an attack vector if someone prepares a site with 
 malicious content and gets users to select a link to it (without even making 
 them click the link)?
 
 Sebastian Kügler wrote:
 Not on its own, one would need another broken or leaky component for it 
 to be exploitable. It may be a privacy problem, since the downloading of a 
 URL leaves traces. Fairly remote, but some people might care.
 
 IOW: let's just drop the idea and leave it to Unity ;)

For the privacy-cautious, an option to turn off automatic download would 
probably be enough.
The security concern would be more problematic, but if you say that Klipper 
alone would not pose a security thread (so we'd avoid situations like Outlook 
Express automatically running malicious code in emails back in the day), then 
that shouldn't be a problem.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---


On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119866/
 ---
 
 (Updated Aug. 22, 2014, 2:33 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This patch paints previews of copied images, instead of displaying the urls 
 in plain text.
 
 The display is limited to 4 images right now. The painting of the delegates 
 is in line with the recommendations from the HIG at 
 https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
 
 It has a few rough edges:
 - not all images get thumbnails -- need to investigate why
 - vertical alignment throughout the list is quite bad, this is the case 
 already, I will fix that separately
 - I want to add an indicator that it's more than 4 files (if applicable), 
 working on that still
 - When no preview is loaded, it should show an icon, almost done, with some 
 fixes
 
 I'd like some feedback on the code, so that with the remaining issues fixed, 
 it can get in.
 
 
 Diffs
 -
 
   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
   applets/clipboard/contents/ui/Menu.qml e6821c3 
   applets/clipboard/contents/ui/clipboard.qml ac784d2 
   klipper/CMakeLists.txt 660b0d1 
   klipper/clipboardjob.h b4f5284 
   klipper/clipboardjob.cpp d84d014 
   klipper/historyurlitem.cpp fb2a766 
   klipper/org.kde.plasma.clipboard.operations 813aafa 
 
 Diff: https://git.reviewboard.kde.org/r/119866/diff/
 
 
 Testing
 ---
 
 Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
 that the previews are only loaded when needed, so no additional memory taken 
 when the systray / klipper popup is not open.
 
 
 File Attachments
 
 
 Before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
 Klipper with thumbnails
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
 Klipper with thumbnails 2nd version
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

2014-08-25 Thread Thomas Pfeiffer



 On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
  https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62
 
  what happens if you copy a normal http:// url? Is it still shown?
 
 Sebastian Kügler wrote:
 No, we're showing the url text in this case. 
 
 We *could* make it smarter and run the text through QUrl::isValid(), and 
 then switch the type (though with our current rendering, that would probably 
 be less descriptive than just showing the URL text).
 
 Martin Gräßlin wrote:
 that's fine, I was just afraid that switching the check, could have 
 broken it.
 
 I don't think it's a very good idea to download the URL - it's one of the 
 things which can get embarrassing if one copies a tiny url ;-)
 
 Thomas Pfeiffer wrote:
 Couldn't it also open up an attack vector if someone prepares a site with 
 malicious content and gets users to select a link to it (without even making 
 them click the link)?
 
 Sebastian Kügler wrote:
 Not on its own, one would need another broken or leaky component for it 
 to be exploitable. It may be a privacy problem, since the downloading of a 
 URL leaves traces. Fairly remote, but some people might care.
 
 IOW: let's just drop the idea and leave it to Unity ;)
 
 Thomas Pfeiffer wrote:
 For the privacy-cautious, an option to turn off automatic download would 
 probably be enough.
 The security concern would be more problematic, but if you say that 
 Klipper alone would not pose a security thread (so we'd avoid situations like 
 Outlook Express automatically running malicious code in emails back in the 
 day), then that shouldn't be a problem.

(sorry, confusing typo: security thread = security threat)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---


On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119866/
 ---
 
 (Updated Aug. 22, 2014, 2:33 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This patch paints previews of copied images, instead of displaying the urls 
 in plain text.
 
 The display is limited to 4 images right now. The painting of the delegates 
 is in line with the recommendations from the HIG at 
 https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
 
 It has a few rough edges:
 - not all images get thumbnails -- need to investigate why
 - vertical alignment throughout the list is quite bad, this is the case 
 already, I will fix that separately
 - I want to add an indicator that it's more than 4 files (if applicable), 
 working on that still
 - When no preview is loaded, it should show an icon, almost done, with some 
 fixes
 
 I'd like some feedback on the code, so that with the remaining issues fixed, 
 it can get in.
 
 
 Diffs
 -
 
   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
   applets/clipboard/contents/ui/Menu.qml e6821c3 
   applets/clipboard/contents/ui/clipboard.qml ac784d2 
   klipper/CMakeLists.txt 660b0d1 
   klipper/clipboardjob.h b4f5284 
   klipper/clipboardjob.cpp d84d014 
   klipper/historyurlitem.cpp fb2a766 
   klipper/org.kde.plasma.clipboard.operations 813aafa 
 
 Diff: https://git.reviewboard.kde.org/r/119866/diff/
 
 
 Testing
 ---
 
 Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
 that the previews are only loaded when needed, so no additional memory taken 
 when the systray / klipper popup is not open.
 
 
 File Attachments
 
 
 Before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
 Klipper with thumbnails
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
 Klipper with thumbnails 2nd version
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png
 
 
 Thanks,
 
 Sebastian Kügler
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62

what happens if you copy a normal http:// url? Is it still shown?

Sebastian Kügler wrote:
No, we're showing the url text in this case.

We *could* make it smarter and run the text through QUrl::isValid(), and
then switch the type (though with our current rendering, that would probably
be less descriptive than just showing the URL text).

Martin Gräßlin wrote:
that's fine, I was just afraid that switching the check, could have
broken it.

I don't think it's a very good idea to download the URL - it's one of the
things which can get embarrassing if one copies a tiny url ;-)

Thomas Pfeiffer wrote:
Couldn't it also open up an attack vector if someone prepares a site with
malicious content and gets users to select a link to it (without even making
them click the link)?

Sebastian Kügler wrote:
Not on its own, one would need another broken or leaky component for it
to be exploitable. It may be a privacy problem, since the downloading of a
URL leaves traces. Fairly remote, but some people might care.

IOW: let's just drop the idea and leave it to Unity ;)

Thomas Pfeiffer wrote:
For the privacy-cautious, an option to turn off automatic download would
probably be enough.
The security concern would be more problematic, but if you say that
Klipper alone would not pose a security thread (so we'd avoid situations like
Outlook Express automatically running malicious code in emails back in the
day), then that shouldn't be a problem.

Thomas Pfeiffer wrote:
(sorry, confusing typo: security thread = security threat)

An option to turn off automatic downloading would mean that 99.9% would not
switch it off (guess-based stats FTW! ;)), changing almost nothing about the
implications.

The preview itself would not be very accurate, though, since rendering of a
webpage, for example, highly depends on things inside the browser (font
settings, javascript / flash / fooplugin on/off, adblock, etc.) and the website
itself (mobile vs. desktop site, cookies on/off, https?, is the user logged
in?, etc). I don't think a URL preview would offer too much value, besides that
it's quite heavy to implement (downloading a webpage often involves hundreds of
individual http requests).

- Sebastian

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---

On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/
---

(Updated Aug. 22, 2014, 2:33 p.m.)

Review request for Plasma.

Repository: plasma-workspace

Description
---

This patch paints previews of copied images, instead of displaying the urls
in plain text.

The display is limited to 4 images right now. The painting of the delegates
is in line with the recommendations from the HIG at
https://techbase.kde.org/Projects/Usability/HIG/Layout/Image

It has a few rough edges:
- not all images get thumbnails -- need to investigate why
- vertical alignment throughout the list is quite bad, this is the case
already, I will fix that separately
- I want to add an indicator that it's more than 4 files (if applicable),
working on that still
- When no preview is loaded, it should show an icon, almost done, with some
fixes

I'd like some feedback on the code, so that with the remaining issues fixed,
it can get in.

Diffs
-

applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80
applets/clipboard/contents/ui/Menu.qml e6821c3
applets/clipboard/contents/ui/clipboard.qml ac784d2
klipper/CMakeLists.txt 660b0d1
klipper/clipboardjob.h b4f5284
klipper/clipboardjob.cpp d84d014
klipper/historyurlitem.cpp fb2a766
klipper/org.kde.plasma.clipboard.operations 813aafa

Diff: https://git.reviewboard.kde.org/r/119866/diff/

Testing
---

Copied images and files in Dolphin, see them showing up in Klipper. Made sure
that the previews are only loaded when needed, so no additional memory taken
when the systray / klipper popup is not open.

File Attachments

Before

https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
Klipper with thumbnails

https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
Klipper with thumbnails 2nd version

Minutes Monday Plasma Hangout

Minutes Plasma Hangout, 25-8-2014

Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas

For updates on TODO/status, see also Kanban board at: 
https://todo.kde.org/?controller=boardaction=showproject_id=13

Antonis:
- Worked on Baloo timeline model,
- will continue post-exams (good luck!)

Marco:
- Moved more components over to QQC
- Dialogs got option to not have a background, easier to use outside of Plasma 
(Maui, for now)
- Look  Feel KCMs merged
- Experimented with Plasma KPart
- Started port of plasma-windowed

Martin:
- Will attend http://www.x.org/wiki/Events/XDC2014/ 
  It would be good if at least one more Plasma developer could go
- Refactored KWin-internal Wayland client library
- Working on rendering to multiple outputs
- Will try to implement shell interfaces for Wayland

Jonathan:
- unified cmake version numbers, quickens release process

Vishesh:
- Research metadata handling in other OSen (Mac OS, Microsoft)
- Worked on removable media support
- Improved krunner's scoring algo

Kai Uwe:
- Worked on Breeze kdecoration2
- Looked into wl_touch interface
- Started impementing markdown support in Notes plasmoid

sebas:
- QScreen backend in review, waiting for feedback about one more issue
- Previews for URL lists in Klipper, in review
- More work on libkscreen's Wayland backend

-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

2014-08-25 Thread Martin Gräßlin



 On Aug. 21, 2014, 7:39 a.m., Martin Gräßlin wrote:
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
  https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62
 
  what happens if you copy a normal http:// url? Is it still shown?
 
 Sebastian Kügler wrote:
 No, we're showing the url text in this case. 
 
 We *could* make it smarter and run the text through QUrl::isValid(), and 
 then switch the type (though with our current rendering, that would probably 
 be less descriptive than just showing the URL text).
 
 Martin Gräßlin wrote:
 that's fine, I was just afraid that switching the check, could have 
 broken it.
 
 I don't think it's a very good idea to download the URL - it's one of the 
 things which can get embarrassing if one copies a tiny url ;-)
 
 Thomas Pfeiffer wrote:
 Couldn't it also open up an attack vector if someone prepares a site with 
 malicious content and gets users to select a link to it (without even making 
 them click the link)?
 
 Sebastian Kügler wrote:
 Not on its own, one would need another broken or leaky component for it 
 to be exploitable. It may be a privacy problem, since the downloading of a 
 URL leaves traces. Fairly remote, but some people might care.
 
 IOW: let's just drop the idea and leave it to Unity ;)
 
 Thomas Pfeiffer wrote:
 For the privacy-cautious, an option to turn off automatic download would 
 probably be enough.
 The security concern would be more problematic, but if you say that 
 Klipper alone would not pose a security thread (so we'd avoid situations like 
 Outlook Express automatically running malicious code in emails back in the 
 day), then that shouldn't be a problem.
 
 Thomas Pfeiffer wrote:
 (sorry, confusing typo: security thread = security threat)
 
 Sebastian Kügler wrote:
 An option to turn off automatic downloading would mean that 99.9% would 
 not switch it off (guess-based stats FTW! ;)), changing almost nothing about 
 the implications.
 
 The preview itself would not be very accurate, though, since rendering of 
 a webpage, for example, highly depends on things inside the browser (font 
 settings, javascript / flash / fooplugin on/off, adblock, etc.) and the 
 website itself (mobile vs. desktop site, cookies on/off, https?, is the user 
 logged in?, etc). I don't think a URL preview would offer too much value, 
 besides that it's quite heavy to implement (downloading a webpage often 
 involves hundreds of individual http requests).

just to make it clear again: I asked because I was afraid that the change would 
start downloading and rendering a preview. I do not want to have a preview for 
an external URL and I would argument very strongly against a change to do so.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---


On Aug. 22, 2014, 4:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119866/
 ---
 
 (Updated Aug. 22, 2014, 4:33 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This patch paints previews of copied images, instead of displaying the urls 
 in plain text.
 
 The display is limited to 4 images right now. The painting of the delegates 
 is in line with the recommendations from the HIG at 
 https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
 
 It has a few rough edges:
 - not all images get thumbnails -- need to investigate why
 - vertical alignment throughout the list is quite bad, this is the case 
 already, I will fix that separately
 - I want to add an indicator that it's more than 4 files (if applicable), 
 working on that still
 - When no preview is loaded, it should show an icon, almost done, with some 
 fixes
 
 I'd like some feedback on the code, so that with the remaining issues fixed, 
 it can get in.
 
 
 Diffs
 -
 
   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
   applets/clipboard/contents/ui/Menu.qml e6821c3 
   applets/clipboard/contents/ui/clipboard.qml ac784d2 
   klipper/CMakeLists.txt 660b0d1 
   klipper/clipboardjob.h b4f5284 
   klipper/clipboardjob.cpp d84d014 
   klipper/historyurlitem.cpp fb2a766 
   klipper/org.kde.plasma.clipboard.operations 813aafa 
 
 Diff: https://git.reviewboard.kde.org/r/119866/diff/
 
 
 Testing
 ---
 
 Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
 that the previews are only loaded when needed, so no additional memory taken 
 when the systray / klipper popup is not open.
 
 
 File Attachments
 
 
 Before

Re: Minutes Monday Plasma Hangout

2014-08-25 Thread Ivan Čukić

On Monday 25 August 2014 14:22:20 Sebastian Kügler wrote:
 Minutes Plasma Hangout, 25-8-2014
 
 Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas
 
 For updates on TODO/status, see also Kanban board at:
 https://todo.kde.org/?controller=boardaction=showproject_id=13

Investigating a big issue with the way plasma handles activities. There is 
something strange going on with plasma not instantiating containments for all 
activities.


-- 

Cheerio,
Ivan


KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ 
gpg key id: 850B6F76, keyserver.pgp.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop



 On Aug. 25, 2014, 1:24 a.m., Aleix Pol Gonzalez wrote:
  plasma.desktop.cmake, line 5
  https://git.reviewboard.kde.org/r/119885/diff/1/?file=306866#file306866line5
 
  The TryExec is wrong now? :P

Oooops, fixed now. Thanks!


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119885/#review65163
---


On Aug. 21, 2014, 9:11 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119885/
 ---
 
 (Updated Aug. 21, 2014, 9:11 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Prevents ending up with /usr//usr/bin/startkde in plasma.desktop when 
 CMAKE_INSTALL_BINDIR is absolute. It's already used in startkde, so I think 
 it makes sense to use it here too.
 
 
 Diffs
 -
 
   plasma.desktop.cmake 81ca9a7 
 
 Diff: https://git.reviewboard.kde.org/r/119885/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper

2014-08-25 Thread Thomas Pfeiffer



 On Aug. 21, 2014, 5:39 a.m., Martin Gräßlin wrote:
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml, line 62
  https://git.reviewboard.kde.org/r/119866/diff/1/?file=306729#file306729line62
 
  what happens if you copy a normal http:// url? Is it still shown?
 
 Sebastian Kügler wrote:
 No, we're showing the url text in this case. 
 
 We *could* make it smarter and run the text through QUrl::isValid(), and 
 then switch the type (though with our current rendering, that would probably 
 be less descriptive than just showing the URL text).
 
 Martin Gräßlin wrote:
 that's fine, I was just afraid that switching the check, could have 
 broken it.
 
 I don't think it's a very good idea to download the URL - it's one of the 
 things which can get embarrassing if one copies a tiny url ;-)
 
 Thomas Pfeiffer wrote:
 Couldn't it also open up an attack vector if someone prepares a site with 
 malicious content and gets users to select a link to it (without even making 
 them click the link)?
 
 Sebastian Kügler wrote:
 Not on its own, one would need another broken or leaky component for it 
 to be exploitable. It may be a privacy problem, since the downloading of a 
 URL leaves traces. Fairly remote, but some people might care.
 
 IOW: let's just drop the idea and leave it to Unity ;)
 
 Thomas Pfeiffer wrote:
 For the privacy-cautious, an option to turn off automatic download would 
 probably be enough.
 The security concern would be more problematic, but if you say that 
 Klipper alone would not pose a security thread (so we'd avoid situations like 
 Outlook Express automatically running malicious code in emails back in the 
 day), then that shouldn't be a problem.
 
 Thomas Pfeiffer wrote:
 (sorry, confusing typo: security thread = security threat)
 
 Sebastian Kügler wrote:
 An option to turn off automatic downloading would mean that 99.9% would 
 not switch it off (guess-based stats FTW! ;)), changing almost nothing about 
 the implications.
 
 The preview itself would not be very accurate, though, since rendering of 
 a webpage, for example, highly depends on things inside the browser (font 
 settings, javascript / flash / fooplugin on/off, adblock, etc.) and the 
 website itself (mobile vs. desktop site, cookies on/off, https?, is the user 
 logged in?, etc). I don't think a URL preview would offer too much value, 
 besides that it's quite heavy to implement (downloading a webpage often 
 involves hundreds of individual http requests).
 
 Martin Gräßlin wrote:
 just to make it clear again: I asked because I was afraid that the change 
 would start downloading and rendering a preview. I do not want to have a 
 preview for an external URL and I would argument very strongly against a 
 change to do so.

Okay, no URL previews, then, fine with me, case closed :)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/#review64951
---


On Aug. 22, 2014, 2:33 p.m., Sebastian Kügler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119866/
 ---
 
 (Updated Aug. 22, 2014, 2:33 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This patch paints previews of copied images, instead of displaying the urls 
 in plain text.
 
 The display is limited to 4 images right now. The painting of the delegates 
 is in line with the recommendations from the HIG at 
 https://techbase.kde.org/Projects/Usability/HIG/Layout/Image
 
 It has a few rough edges:
 - not all images get thumbnails -- need to investigate why
 - vertical alignment throughout the list is quite bad, this is the case 
 already, I will fix that separately
 - I want to add an indicator that it's more than 4 files (if applicable), 
 working on that still
 - When no preview is loaded, it should show an icon, almost done, with some 
 fixes
 
 I'd like some feedback on the code, so that with the remaining issues fixed, 
 it can get in.
 
 
 Diffs
 -
 
   applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
   applets/clipboard/contents/ui/Menu.qml e6821c3 
   applets/clipboard/contents/ui/clipboard.qml ac784d2 
   klipper/CMakeLists.txt 660b0d1 
   klipper/clipboardjob.h b4f5284 
   klipper/clipboardjob.cpp d84d014 
   klipper/historyurlitem.cpp fb2a766 
   klipper/org.kde.plasma.clipboard.operations 813aafa 
 
 Diff: https://git.reviewboard.kde.org/r/119866/diff/
 
 
 Testing
 ---
 
 Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
 that the previews are only loaded when needed, so no additional memory taken 
 when the systray / klipper popup is not

Review Request 119929: Cleaning up plasma-shell, episode 1


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

While reviewing the plasma-shell binary for use in a device project, I came 
across a number of issues which are fixed in a longer-than-probably-desirable 
series of patches in the clean_shellcorona branch of plasma-workspace. There 
are two types of changes:

* improving multiscreen code; in particular there was a recursive function that 
would (I assume innadvertently) migrate panels to the last screen when 
detached. there was also potentially unecessary signal emissions, 
* code cleanups

The code cleanups come in a few flavors:
* getting code in line with the kdelibs coding style this project purportedly 
follows
* removal of dead code
* checking of parameters where sensible
* making debug code only available in debug builds (c.f. 
CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
notices when built in release mode)

It is probably easier to review the patches in the branch than the monster 
review this has become, however many of the patches (though admittedly not all) 
are built one atop the other making individual review tricky; it was one of 
those tug on a loose thread, and the whole sweater came unravelled type 
things.


Diffs
-

  shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 
  shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
  shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
  shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
  shell/widgetexplorer/widgetexplorer.cpp 
0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
  shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 

Diff: https://git.reviewboard.kde.org/r/119929/diff/


Testing
---


Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

2014-08-25 Thread Aleix Pol

On Mon, Aug 25, 2014 at 2:22 PM, Sebastian Kügler se...@kde.org wrote:

 Minutes Plasma Hangout, 25-8-2014

 Present: Antonis, Marco, Martin G., Jonathan, Vishsesh, Kai Uwe, Sebas

 For updates on TODO/status, see also Kanban board at:
 https://todo.kde.org/?controller=boardaction=showproject_id=13

 Antonis:
 - Worked on Baloo timeline model,
 - will continue post-exams (good luck!)

 Marco:
 - Moved more components over to QQC
 - Dialogs got option to not have a background, easier to use outside of
 Plasma
 (Maui, for now)

** snip **


 - Look  Feel KCMs merged
 - Experimented with Plasma KPart
 - Started port of plasma-windowed

 Martin:
 - Will attend http://www.x.org/wiki/Events/XDC2014/
   It would be good if at least one more Plasma developer could go
 - Refactored KWin-internal Wayland client library
 - Working on rendering to multiple outputs
 - Will try to implement shell interfaces for Wayland

 Jonathan:
 - unified cmake version numbers, quickens release process

 Vishesh:
 - Research metadata handling in other OSen (Mac OS, Microsoft)
 - Worked on removable media support
 - Improved krunner's scoring algo

 Kai Uwe:
 - Worked on Breeze kdecoration2
 - Looked into wl_touch interface
 - Started impementing markdown support in Notes plasmoid

 sebas:
 - QScreen backend in review, waiting for feedback about one more issue
 - Previews for URL lists in Klipper, in review
 - More work on libkscreen's Wayland backend


What does outside of plasma mean? It's in plasma-framework right?

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65204
---

Ship it!


Inviala!

- Marco Martin


On Ago. 25, 2014, 1:24 p.m., Aaron J. Seigo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119929/
 ---
 
 (Updated Ago. 25, 2014, 1:24 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 While reviewing the plasma-shell binary for use in a device project, I came 
 across a number of issues which are fixed in a longer-than-probably-desirable 
 series of patches in the clean_shellcorona branch of plasma-workspace. There 
 are two types of changes:
 
 * improving multiscreen code; in particular there was a recursive function 
 that would (I assume innadvertently) migrate panels to the last screen when 
 detached. there was also potentially unecessary signal emissions, 
 * code cleanups
 
 The code cleanups come in a few flavors:
 * getting code in line with the kdelibs coding style this project purportedly 
 follows
 * removal of dead code
 * checking of parameters where sensible
 * making debug code only available in debug builds (c.f. 
 CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
 notices when built in release mode)
 
 It is probably easier to review the patches in the branch than the monster 
 review this has become, however many of the patches (though admittedly not 
 all) are built one atop the other making individual review tricky; it was one 
 of those tug on a loose thread, and the whole sweater came unravelled type 
 things.
 
 
 Diffs
 -
 
   shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 
   shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
   shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
   shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
   shell/widgetexplorer/widgetexplorer.cpp 
 0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
   shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
 
 Diff: https://git.reviewboard.kde.org/r/119929/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aaron J. Seigo
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/
---

(Updated Aug. 25, 2014, 3:39 p.m.)


Review request for Plasma.


Changes
---

Lukas Tinkl found a nice way to get Caps Lock status and changes from the 
KeyState DataEngine, so the patch now makes use of the DataEngine and removes 
the X11-dependent CapsLock status detection from greeterapp.cpp


Repository: plasma-workspace


Description
---

This will show a warning when capslock is enabled, like it used to in KDE 4 
screen locker.


Diffs (updated)
-

  ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
  lookandfeel/contents/components/UserSelect.qml 7b605b1 
  lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
  ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 

Diff: https://git.reviewboard.kde.org/r/119797/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119794/
---

(Updated Aug. 25, 2014, 3:43 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

This adds a button that allows toggling keyboard layout from the lockscreen. It 
talks and listens directly to the KDED's keyboard module.


Diffs (updated)
-

  ksmserver/screenlocker/greeter/CMakeLists.txt 4837017 
  ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
  ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION 
  ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION 
  lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION 
  lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 

Diff: https://git.reviewboard.kde.org/r/119794/diff/


Testing
---


File Attachments



  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

On Monday, August 25, 2014 15:26:32 Aleix Pol wrote:
 What does outside of plasma mean? It's in plasma-framework right?

Outside of Plasma-the-workspace-as-we-ship, not outside of plasma-framework. 
Basically, Maui using plasma-framework.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65205
---



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45570

QSetQScreen *



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45569

KScreen::Output *out



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45568

DesktopView *v



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45571

QListPanelView *



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45572

KScreen::Output *



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45567

if (idx == d-views.count()) {



shell/shellcorona.cpp
https://git.reviewboard.kde.org/r/119929/#comment45573

QHashint, Plasma::Containment *


- Kai Uwe Broulik


On Aug. 25, 2014, 1:24 nachm., Aaron J. Seigo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119929/
 ---
 
 (Updated Aug. 25, 2014, 1:24 nachm.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 While reviewing the plasma-shell binary for use in a device project, I came 
 across a number of issues which are fixed in a longer-than-probably-desirable 
 series of patches in the clean_shellcorona branch of plasma-workspace. There 
 are two types of changes:
 
 * improving multiscreen code; in particular there was a recursive function 
 that would (I assume innadvertently) migrate panels to the last screen when 
 detached. there was also potentially unecessary signal emissions, 
 * code cleanups
 
 The code cleanups come in a few flavors:
 * getting code in line with the kdelibs coding style this project purportedly 
 follows
 * removal of dead code
 * checking of parameters where sensible
 * making debug code only available in debug builds (c.f. 
 CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
 notices when built in release mode)
 
 It is probably easier to review the patches in the branch than the monster 
 review this has become, however many of the patches (though admittedly not 
 all) are built one atop the other making individual review tricky; it was one 
 of those tug on a loose thread, and the whole sweater came unravelled type 
 things.
 
 
 Diffs
 -
 
   shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 
   shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
   shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
   shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
   shell/widgetexplorer/widgetexplorer.cpp 
 0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
   shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
 
 Diff: https://git.reviewboard.kde.org/r/119929/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aaron J. Seigo
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aleix Pol Gonzalez



 On Aug. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote:
 

Can we maybe run a script or something after this review? It's already hard 
enough to decode the patch...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65205
---


On Aug. 25, 2014, 1:24 p.m., Aaron J. Seigo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119929/
 ---
 
 (Updated Aug. 25, 2014, 1:24 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 While reviewing the plasma-shell binary for use in a device project, I came 
 across a number of issues which are fixed in a longer-than-probably-desirable 
 series of patches in the clean_shellcorona branch of plasma-workspace. There 
 are two types of changes:
 
 * improving multiscreen code; in particular there was a recursive function 
 that would (I assume innadvertently) migrate panels to the last screen when 
 detached. there was also potentially unecessary signal emissions, 
 * code cleanups
 
 The code cleanups come in a few flavors:
 * getting code in line with the kdelibs coding style this project purportedly 
 follows
 * removal of dead code
 * checking of parameters where sensible
 * making debug code only available in debug builds (c.f. 
 CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
 notices when built in release mode)
 
 It is probably easier to review the patches in the branch than the monster 
 review this has become, however many of the patches (though admittedly not 
 all) are built one atop the other making individual review tricky; it was one 
 of those tug on a loose thread, and the whole sweater came unravelled type 
 things.
 
 
 Diffs
 -
 
   shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 
   shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
   shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
   shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
   shell/widgetexplorer/widgetexplorer.cpp 
 0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
   shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
 
 Diff: https://git.reviewboard.kde.org/r/119929/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aaron J. Seigo
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65208
---



lookandfeel/contents/lockscreen/LockScreen.qml
https://git.reviewboard.kde.org/r/119797/#comment45574

Does that work? Shouldn't it be dataChanged() ?


- Kai Uwe Broulik


On Aug. 25, 2014, 1:39 nachm., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 1:39 nachm.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

2014-08-25 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65210
---

Ship it!


I looked through it, it made sense to me.

Thanks for looking into this.

- Aleix Pol Gonzalez


On Aug. 25, 2014, 1:24 p.m., Aaron J. Seigo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119929/
 ---
 
 (Updated Aug. 25, 2014, 1:24 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 While reviewing the plasma-shell binary for use in a device project, I came 
 across a number of issues which are fixed in a longer-than-probably-desirable 
 series of patches in the clean_shellcorona branch of plasma-workspace. There 
 are two types of changes:
 
 * improving multiscreen code; in particular there was a recursive function 
 that would (I assume innadvertently) migrate panels to the last screen when 
 detached. there was also potentially unecessary signal emissions, 
 * code cleanups
 
 The code cleanups come in a few flavors:
 * getting code in line with the kdelibs coding style this project purportedly 
 follows
 * removal of dead code
 * checking of parameters where sensible
 * making debug code only available in debug builds (c.f. 
 CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
 notices when built in release mode)
 
 It is probably easier to review the patches in the branch than the monster 
 review this has become, however many of the patches (though admittedly not 
 all) are built one atop the other making individual review tricky; it was one 
 of those tug on a loose thread, and the whole sweater came unravelled type 
 things.
 
 
 Diffs
 -
 
   shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 
   shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
   shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
   shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
   shell/widgetexplorer/widgetexplorer.cpp 
 0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
   shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
 
 Diff: https://git.reviewboard.kde.org/r/119929/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Aaron J. Seigo
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65213
---

Ship it!


Nice


lookandfeel/contents/lockscreen/LockScreen.qml
https://git.reviewboard.kde.org/r/119797/#comment45576

does it not work to do
visible: keystateSource.data[Caps Lock][Locked]

and then get rid of the function?


- David Edmundson


On Aug. 25, 2014, 1:39 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 1:39 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/
---

(Updated Aug. 25, 2014, 2:11 p.m.)


Review request for Plasma and Andrew Lake.


Repository: plasma-workspace


Description
---

This will show a warning when capslock is enabled, like it used to in KDE 4 
screen locker.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
  lookandfeel/contents/components/UserSelect.qml 7b605b1 
  lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
  ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 

Diff: https://git.reviewboard.kde.org/r/119797/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

On Ago. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote:

Aleix Pol Gonzalez wrote:
Can we maybe run a script or something after this review? It's already
hard enough to decode the patch...

maybe after this is merged could be tried to run astyle from
https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting
?

- Marco

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65205
---

On Ago. 25, 2014, 1:24 p.m., Aaron J. Seigo wrote:

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/
---

(Updated Ago. 25, 2014, 1:24 p.m.)

Review request for Plasma.

Repository: plasma-workspace

Description
---

While reviewing the plasma-shell binary for use in a device project, I came
across a number of issues which are fixed in a longer-than-probably-desirable
series of patches in the clean_shellcorona branch of plasma-workspace. There
are two types of changes:

* improving multiscreen code; in particular there was a recursive function
that would (I assume innadvertently) migrate panels to the last screen when
detached. there was also potentially unecessary signal emissions,
* code cleanups

The code cleanups come in a few flavors:
* getting code in line with the kdelibs coding style this project purportedly
follows
* removal of dead code
* checking of parameters where sensible
* making debug code only available in debug builds (c.f.
CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler
notices when built in release mode)

It is probably easier to review the patches in the branch than the monster
review this has become, however many of the patches (though admittedly not
all) are built one atop the other making individual review tricky; it was one
of those tug on a loose thread, and the whole sweater came unravelled type
things.

Diffs
-

shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694
shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982
shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d
shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101
shell/widgetexplorer/widgetexplorer.cpp
0ad5cc8519c8f37ce20e49332491ea0469ee7a29
shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f

Diff: https://git.reviewboard.kde.org/r/119929/diff/

Testing
---

Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled



 On Aug. 25, 2014, 2:04 p.m., Kai Uwe Broulik wrote:
  lookandfeel/contents/lockscreen/LockScreen.qml, line 178
  https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line178
 
  Does that work? Shouldn't it be dataChanged() ?

both work, this calls the slot, yours would emit the signal which would call 
the slot.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65208
---


On Aug. 25, 2014, 1:39 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 1:39 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119721: Don't explicitly set a height on button in notification delegate.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119721/
---

(Updated Aug. 25, 2014, 2:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Don't explicitly set a height on button in notification delegate.

Setting a random value on a button means that it's smaller than the button 
wants to be and text falls out. The default is set by the button and is correct.

It's not up to the controls to handle being resized; it'd be like complaining 
at LineEdit if you set the height to 2px tall and you can't read the text.


Diffs
-

  applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 

Diff: https://git.reviewboard.kde.org/r/119721/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119927: Port systemloadviewer plasmoid


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119927/#review65217
---



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml
https://git.reviewboard.kde.org/r/119927/#comment45577

If you want bigger labels see PlasmaExtras and use a different heading type.


- David Edmundson


On Aug. 24, 2014, 7:26 p.m., Martin Yrjölä wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119927/
 ---
 
 (Updated Aug. 24, 2014, 7:26 p.m.)
 
 
 Review request for Plasma and David Edmundson.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 Port systemloadviewer plasmoid
 
 It had a VDG makeover and now there's also circular monitors available in the 
 options.
 
 There are regressions as well. These features aren't yet implemented:
 - Horizontal bar support
 - Individual monitors for each cpu
 
 Probably there are some optimizations to be done. I'm not really sure how I 
 should handle the two types of monitors (bar, circular) correctly. Now I just 
 hide the one that is not enabled in the options.
 
 
 Diffs
 -
 
   applets/CMakeLists.txt ccbe440342c7fc0ca5c9f67bcaa4e823cd35a099 
   applets/systemloadviewer/CMakeLists.txt 
 6de867aa63e5102a5085667f8106ec09da2c4968 
   applets/systemloadviewer/Messages.sh 
 b95833b3b5cf7865e72ed6b46e8dcd7848c599e1 
   applets/systemloadviewer/TODO 210dcd76f02b2a8f62e2e7339d089c545a4fb112 
   applets/systemloadviewer/coloursconfig.ui 
 70a08afbaa204bb78865a545965210f3e2dfe42a 
   applets/systemloadviewer/generalconfig.ui 
 2ae6d6540a12203e73bab5ca930da751f94bde22 
   applets/systemloadviewer/package/contents/config/config.qml PRE-CREATION 
   applets/systemloadviewer/package/contents/config/main.xml PRE-CREATION 
   applets/systemloadviewer/package/contents/ui/BarMonitor.qml PRE-CREATION 
   applets/systemloadviewer/package/contents/ui/CircularMonitor.qml 
 PRE-CREATION 
   applets/systemloadviewer/package/contents/ui/ColorPicker.qml PRE-CREATION 
   
 applets/systemloadviewer/package/contents/ui/ConditionallyRoundedRectangle.qml
  PRE-CREATION 
   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml 
 PRE-CREATION 
   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 
 PRE-CREATION 
   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 
 9324d4216e716b2156f5f084c8b4782a6dd84806 
   applets/systemloadviewer/systemloadviewer.h 
 9bbcf2305ef47dd888362a9b65954ba65a74 
   applets/systemloadviewer/systemloadviewer.cpp 
 bff0b34aa2d7a46e8e1fa052bb6008cf52a4497f 
 
 Diff: https://git.reviewboard.kde.org/r/119927/diff/
 
 
 Testing
 ---
 
 Works nicely on Air, Breeze light and Breeze dark Plasma themes. The Bar 
 monitor is not pixel perfect because of the edge roundings. I haven't been 
 able to test if this plasmoid works with high DPI monitors.
 
 
 File Attachments
 
 
 Screenshot
   
 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/24/a2a69145-6d76-48e8-bccd-ce7cead244bb__2014-08-24-212539_505x860_scrot.png
 
 
 Thanks,
 
 Martin Yrjölä
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/
---

(Updated Aug. 25, 2014, 2:50 p.m.)


Review request for Plasma.


Changes
---

Yet more style fixes noted by Kai; I'm pretty sure this still isn't exhaustive 
but it is more :)


Repository: plasma-workspace


Description
---

While reviewing the plasma-shell binary for use in a device project, I came 
across a number of issues which are fixed in a longer-than-probably-desirable 
series of patches in the clean_shellcorona branch of plasma-workspace. There 
are two types of changes:

* improving multiscreen code; in particular there was a recursive function that 
would (I assume innadvertently) migrate panels to the last screen when 
detached. there was also potentially unecessary signal emissions, 
* code cleanups

The code cleanups come in a few flavors:
* getting code in line with the kdelibs coding style this project purportedly 
follows
* removal of dead code
* checking of parameters where sensible
* making debug code only available in debug builds (c.f. 
CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
notices when built in release mode)

It is probably easier to review the patches in the branch than the monster 
review this has become, however many of the patches (though admittedly not all) 
are built one atop the other making individual review tricky; it was one of 
those tug on a loose thread, and the whole sweater came unravelled type 
things.


Diffs (updated)
-

  shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
  shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
  shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
  shell/widgetexplorer/widgetexplorer.cpp 
0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
  shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
  shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 

Diff: https://git.reviewboard.kde.org/r/119929/diff/


Testing
---


Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1

On Aug. 25, 2014, 1:51 p.m., Kai Uwe Broulik wrote:

Aleix Pol Gonzalez wrote:
Can we maybe run a script or something after this review? It's already
hard enough to decode the patch...

Marco Martin wrote:
maybe after this is merged could be tried to run astyle from

https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting
?

I actually tried astyle but the command line options have changed yet again and
the various incantations I tried made more of a mess as it made more changes
than desired. If someone else can make it go though, that'd be great as I
would very much appreciate a more consistent code base to work off of.

- Aaron J.

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/#review65205
---

On Aug. 25, 2014, 2:50 p.m., Aaron J. Seigo wrote:

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/
---

(Updated Aug. 25, 2014, 2:50 p.m.)

Review request for Plasma.

Repository: plasma-workspace

Description
---

Diffs
-

shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982
shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d
shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101
shell/widgetexplorer/widgetexplorer.cpp
0ad5cc8519c8f37ce20e49332491ea0469ee7a29
shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f
shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694

Diff: https://git.reviewboard.kde.org/r/119929/diff/

Testing
---

Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119929: Cleaning up plasma-shell, episode 1


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119929/
---

(Updated Aug. 25, 2014, 2:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

While reviewing the plasma-shell binary for use in a device project, I came 
across a number of issues which are fixed in a longer-than-probably-desirable 
series of patches in the clean_shellcorona branch of plasma-workspace. There 
are two types of changes:

* improving multiscreen code; in particular there was a recursive function that 
would (I assume innadvertently) migrate panels to the last screen when 
detached. there was also potentially unecessary signal emissions, 
* code cleanups

The code cleanups come in a few flavors:
* getting code in line with the kdelibs coding style this project purportedly 
follows
* removal of dead code
* checking of parameters where sensible
* making debug code only available in debug builds (c.f. 
CHECK_SCREEN_INVARIANTS; this would previously result in a bunch of compiler 
notices when built in release mode)

It is probably easier to review the patches in the branch than the monster 
review this has become, however many of the patches (though admittedly not all) 
are built one atop the other making individual review tricky; it was one of 
those tug on a loose thread, and the whole sweater came unravelled type 
things.


Diffs
-

  shell/scripting/scriptengine.cpp 94e93fe810edb1743b84cdca168bc7f7e556e982 
  shell/shellcorona.h ebfbdc7ceea9f6cfb387c1931e78faa9e43a894d 
  shell/shellcorona.cpp 29935a51ffc490e1d7e91e2a1109764a4ff2d101 
  shell/widgetexplorer/widgetexplorer.cpp 
0ad5cc8519c8f37ce20e49332491ea0469ee7a29 
  shell/containmentconfigview.cpp f489f1771f3de0a0a5fb7e385615e5981b2f240f 
  shell/desktopview.cpp 0f8bde7af9bae1a17ff42d54c9882fbddc695694 

Diff: https://git.reviewboard.kde.org/r/119929/diff/


Testing
---


Thanks,

Aaron J. Seigo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled



 On Aug. 25, 2014, 4:11 p.m., David Edmundson wrote:
  lookandfeel/contents/lockscreen/LockScreen.qml, line 167
  https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line167
 
  does it not work to do
  visible: keystateSource.data[Caps Lock][Locked]
  
  and then get rid of the function?

Yep, that works perfectly.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65213
---


On Aug. 25, 2014, 4:11 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 4:11 p.m.)
 
 
 Review request for Plasma and Andrew Lake.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/
---

(Updated Aug. 25, 2014, 3:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Andrew Lake.


Repository: plasma-workspace


Description
---

This will show a warning when capslock is enabled, like it used to in KDE 4 
screen locker.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
  lookandfeel/contents/components/UserSelect.qml 7b605b1 
  lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
  ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 

Diff: https://git.reviewboard.kde.org/r/119797/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65237
---



lookandfeel/contents/lockscreen/LockScreen.qml
https://git.reviewboard.kde.org/r/119797/#comment45584

What was the point of this layout, there's only one item in it?


- David Edmundson


On Aug. 25, 2014, 3:10 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 3:10 p.m.)
 
 
 Review request for Plasma and Andrew Lake.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled



 On Aug. 25, 2014, 5:25 p.m., David Edmundson wrote:
  lookandfeel/contents/lockscreen/LockScreen.qml, line 119
  https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line119
 
  What was the point of this layout, there's only one item in it?

nevermind, I got confused.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119797/#review65237
---


On Aug. 25, 2014, 3:10 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119797/
 ---
 
 (Updated Aug. 25, 2014, 3:10 p.m.)
 
 
 Review request for Plasma and Andrew Lake.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This will show a warning when capslock is enabled, like it used to in KDE 4 
 screen locker.
 
 
 Diffs
 -
 
   ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd 
   lookandfeel/contents/components/UserSelect.qml 7b605b1 
   lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 
   ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 
 
 Diff: https://git.reviewboard.kde.org/r/119797/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119934: Make nothing interesting going on labels in applets consistent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This makes the labels for No notifications, No devices and No media 
playing consistent. I took the one from the mediacontroller because I found it 
the most visually appealing.

Font size is increased, making it more of a heading instead of a lonely text 
label, and more importantly I made label positioning consistent so when 
switching between applets the labels are all in the same exact spot.

See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.

We should probably unify the notation as well. Device notifier uses a short 
sentence with Title Capitalization, notifications use a short sentence with a 
full stop at the end, and mediacontroller uses a long sentence.


Diffs
-

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca 
  applets/notifications/package/contents/ui/main.qml fd39c57 

Diff: https://git.reviewboard.kde.org/r/119934/diff/


Testing
---

Device notifier still shows its label, notifications still show their label 
(not if there are notifications), mediacontroller unchanged.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119934: Make nothing interesting going on labels in applets consistent

2014-08-25 Thread Mark Gaiser


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/#review65244
---


While watching the video i noticed that the text has a weird slide in. It seems 
to be visible right from the begginning of the animation. That gives a bit of a 
weird look since the text overlaps for a fraction of a second with the tool 
buttons on the left.

Besides that, looking fancy!

- Mark Gaiser


On aug 25, 2014, 6:40 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119934/
 ---
 
 (Updated aug 25, 2014, 6:40 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This makes the labels for No notifications, No devices and No media 
 playing consistent. I took the one from the mediacontroller because I found 
 it the most visually appealing.
 
 Font size is increased, making it more of a heading instead of a lonely text 
 label, and more importantly I made label positioning consistent so when 
 switching between applets the labels are all in the same exact spot.
 
 See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.
 
 We should probably unify the notation as well. Device notifier uses a short 
 sentence with Title Capitalization, notifications use a short sentence with a 
 full stop at the end, and mediacontroller uses a long sentence.
 
 
 Diffs
 -
 
   applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca 
   applets/notifications/package/contents/ui/main.qml fd39c57 
 
 Diff: https://git.reviewboard.kde.org/r/119934/diff/
 
 
 Testing
 ---
 
 Device notifier still shows its label, notifications still show their label 
 (not if there are notifications), mediacontroller unchanged.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119934: Make nothing interesting going on labels in applets consistent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/#review65245
---

Ship it!


Inviala!

- Marco Martin


On Ago. 25, 2014, 6:40 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119934/
 ---
 
 (Updated Ago. 25, 2014, 6:40 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This makes the labels for No notifications, No devices and No media 
 playing consistent. I took the one from the mediacontroller because I found 
 it the most visually appealing.
 
 Font size is increased, making it more of a heading instead of a lonely text 
 label, and more importantly I made label positioning consistent so when 
 switching between applets the labels are all in the same exact spot.
 
 See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.
 
 We should probably unify the notation as well. Device notifier uses a short 
 sentence with Title Capitalization, notifications use a short sentence with a 
 full stop at the end, and mediacontroller uses a long sentence.
 
 
 Diffs
 -
 
   applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca 
   applets/notifications/package/contents/ui/main.qml fd39c57 
 
 Diff: https://git.reviewboard.kde.org/r/119934/diff/
 
 
 Testing
 ---
 
 Device notifier still shows its label, notifications still show their label 
 (not if there are notifications), mediacontroller unchanged.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119934: Make nothing interesting going on labels in applets consistent



 On Ago. 25, 2014, 6:47 p.m., Mark Gaiser wrote:
  While watching the video i noticed that the text has a weird slide in. It 
  seems to be visible right from the begginning of the animation. That gives 
  a bit of a weird look since the text overlaps for a fraction of a second 
  with the tool buttons on the left.
  
  Besides that, looking fancy!

that's in the systray, doesn't depend from the patch


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/#review65244
---


On Ago. 25, 2014, 6:40 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119934/
 ---
 
 (Updated Ago. 25, 2014, 6:40 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This makes the labels for No notifications, No devices and No media 
 playing consistent. I took the one from the mediacontroller because I found 
 it the most visually appealing.
 
 Font size is increased, making it more of a heading instead of a lonely text 
 label, and more importantly I made label positioning consistent so when 
 switching between applets the labels are all in the same exact spot.
 
 See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.
 
 We should probably unify the notation as well. Device notifier uses a short 
 sentence with Title Capitalization, notifications use a short sentence with a 
 full stop at the end, and mediacontroller uses a long sentence.
 
 
 Diffs
 -
 
   applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca 
   applets/notifications/package/contents/ui/main.qml fd39c57 
 
 Diff: https://git.reviewboard.kde.org/r/119934/diff/
 
 
 Testing
 ---
 
 Device notifier still shows its label, notifications still show their label 
 (not if there are notifications), mediacontroller unchanged.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119934: Make nothing interesting going on labels in applets consistent


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119934/
---

(Updated Aug. 25, 2014, 7:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This makes the labels for No notifications, No devices and No media 
playing consistent. I took the one from the mediacontroller because I found it 
the most visually appealing.

Font size is increased, making it more of a heading instead of a lonely text 
label, and more importantly I made label positioning consistent so when 
switching between applets the labels are all in the same exact spot.

See https://www.youtube.com/watch?v=1XoommwAiWc for this patch in action.

We should probably unify the notation as well. Device notifier uses a short 
sentence with Title Capitalization, notifications use a short sentence with a 
full stop at the end, and mediacontroller uses a long sentence.


Diffs
-

  applets/devicenotifier/package/contents/ui/FullRepresentation.qml d1da0ca 
  applets/notifications/package/contents/ui/main.qml fd39c57 

Diff: https://git.reviewboard.kde.org/r/119934/diff/


Testing
---

Device notifier still shows its label, notifications still show their label 
(not if there are notifications), mediacontroller unchanged.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119866/
---

(Updated Aug. 25, 2014, 10:04 p.m.)


Review request for Plasma.


Changes
---

Address reviewers' comments.


Repository: plasma-workspace


Description
---

This patch paints previews of copied images, instead of displaying the urls in 
plain text.

The display is limited to 4 images right now. The painting of the delegates is 
in line with the recommendations from the HIG at 
https://techbase.kde.org/Projects/Usability/HIG/Layout/Image

It has a few rough edges:
- not all images get thumbnails -- need to investigate why
- vertical alignment throughout the list is quite bad, this is the case 
already, I will fix that separately
- I want to add an indicator that it's more than 4 files (if applicable), 
working on that still
- When no preview is loaded, it should show an icon, almost done, with some 
fixes

I'd like some feedback on the code, so that with the remaining issues fixed, it 
can get in.


Diffs (updated)
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml 8eecb80 
  applets/clipboard/contents/ui/Menu.qml e6821c3 
  applets/clipboard/contents/ui/clipboard.qml ac784d2 
  klipper/CMakeLists.txt 660b0d1 
  klipper/clipboardjob.h b4f5284 
  klipper/clipboardjob.cpp d84d014 
  klipper/historyurlitem.cpp fb2a766 
  klipper/org.kde.plasma.clipboard.operations 813aafa 

Diff: https://git.reviewboard.kde.org/r/119866/diff/


Testing
---

Copied images and files in Dolphin, see them showing up in Klipper. Made sure 
that the previews are only loaded when needed, so no additional memory taken 
when the systray / klipper popup is not open.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/ebdde483-136e-44da-8735-f98ba88485a9__klipper-before.png
Klipper with thumbnails
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/20/65749cc3-3fed-4c9b-9a28-b9791b8e93d8__klipper-thumbnails.png
Klipper with thumbnails 2nd version
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/4fb72495-0781-4535-8de8-5266652b467a__klipper-after.png


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119866: Thumbnails in Klipper