Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously it didn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor
but then i have to compile the whole plasma framework. that’s far out of scope of a plasma applet :/ 2014-12-28 0:57 GMT+01:00 David Edmundson da...@davidedmundson.co.uk: On Sat, Dec 27, 2014 at 10:11 PM, Philipp A. flying-sh...@web.de wrote: Hi, i’m developing a plasma wiget with C++ plugin. consistent with how upstream packages do it, with my package being called `org.kde.plasma.steam`, the plugin is called `org.kde.plasma.private.steam`. i try to load my plasmoid from its dev directory via QML2_IMPORT_PATH=../build/:$QML2_IMPORT_PATH plasmoidviewer $@ . now my problem is that the following seems to be triggered: https://projects.kde.org/projects/frameworks/plasma-framework/repository/entry/src/plasmaquick/packageurlinterceptor.cpp?rev=master#L128 i.e. `path().contains(org/kde/plasma/private)`, so `pathCheck` should be replaced with `org.kde.plasma.steam`. but why does the following test fail? `pathCheck == m_package.metadata().pluginName()` From the information given, I have no idea. I recommend adding qDebug statements all over that method till the problem reveals itself. the plasmoidviewer should load the app metadata, which clearly states `X-KDE-PluginInfo-Name=org.kde.plasma.steam` https://projects.kde.org/projects/extragear/sdk/plasmate/repository/revisions/frameworks/entry/plasmoidviewer/view.cpp#L105 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor
code is here btw: https://github.com/flying-sheep/steam-plasmoid 2014-12-28 17:41 GMT+01:00 Philipp A. flying-sh...@web.de: but then i have to compile the whole plasma framework. that’s far out of scope of a plasma applet :/ 2014-12-28 0:57 GMT+01:00 David Edmundson da...@davidedmundson.co.uk: On Sat, Dec 27, 2014 at 10:11 PM, Philipp A. flying-sh...@web.de wrote: Hi, i’m developing a plasma wiget with C++ plugin. consistent with how upstream packages do it, with my package being called `org.kde.plasma.steam`, the plugin is called `org.kde.plasma.private.steam`. i try to load my plasmoid from its dev directory via QML2_IMPORT_PATH=../build/:$QML2_IMPORT_PATH plasmoidviewer $@ . now my problem is that the following seems to be triggered: https://projects.kde.org/projects/frameworks/plasma-framework/repository/entry/src/plasmaquick/packageurlinterceptor.cpp?rev=master#L128 i.e. `path().contains(org/kde/plasma/private)`, so `pathCheck` should be replaced with `org.kde.plasma.steam`. but why does the following test fail? `pathCheck == m_package.metadata().pluginName()` From the information given, I have no idea. I recommend adding qDebug statements all over that method till the problem reveals itself. the plasmoidviewer should load the app metadata, which clearly states `X-KDE-PluginInfo-Name=org.kde.plasma.steam` https://projects.kde.org/projects/extragear/sdk/plasmate/repository/revisions/frameworks/entry/plasmoidviewer/view.cpp#L105 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KHolidays 5 branch
Hi, I've just pushed a new branch called kf5-port to the kholidays repository for people to look at. This contains the set of api changes I wanted to make and attempts to remove the kdelibs4support dependency. Could someone who understands CMake better than me have a look at the last commit, as it refuses to link to QWidget once I remove the kdelibs4support linkage. Once that's fixed, what's the next step, do people want to see each individual change go on review board? Or do I just push and get it tagged for the next frameworks release? The api changes are pretty self-explanatory, but there's a couple of interim measures needed to plug gaps in Qt to allow removing kdelibs4support usage: 1) I've replaced KCalendarSystem with a private copy of QCalendarSystem until it is merged into Qt 2) I've had to import some private Qt code for converting ISO codes to QLocale language and country enums until Qt adds the required public api or I finish OpenCodes. I've kept the astronomical and astrological classes, but haven't looked at them in detail. I was wondering if we want to add private d-pointers to them just to be safe? Some other possible changes remain, but are not really necessary for the first release: 1) Change from ki18n to tr 2) Make the widget and designer plugin build fully optional (any CMake wizard care to do it?) 3) Add the Holiday Category public api Cheers! John. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Kde-pim] KHolidays 5 branch
Le Sunday 28 December 2014 17:19:48 John Layt a écrit : Hi, I've just pushed a new branch called kf5-port to the kholidays repository for people to look at. This contains the set of api changes I wanted to make and attempts to remove the kdelibs4support dependency. We can't for the moment see last commit. Could someone who understands CMake better than me have a look at the last commit, as it refuses to link to QWidget once I remove the kdelibs4support linkage. Fixed now. Once that's fixed, what's the next step, do people want to see each individual change go on review board? Or do I just push and get it tagged for the next frameworks release? Kdepim/kdepimlibs/pim* module compiles against this branch ? The api changes are pretty self-explanatory, but there's a couple of interim measures needed to plug gaps in Qt to allow removing kdelibs4support usage: 1) I've replaced KCalendarSystem with a private copy of QCalendarSystem until it is merged into Qt 2) I've had to import some private Qt code for converting ISO codes to QLocale language and country enums until Qt adds the required public api or I finish OpenCodes. I've kept the astronomical and astrological classes, but haven't looked at them in detail. I was wondering if we want to add private d-pointers to them just to be safe? Some other possible changes remain, but are not really necessary for the first release: 1) Change from ki18n to tr 2) Make the widget and designer plugin build fully optional (any CMake wizard care to do it?) 3) Add the Holiday Category public api Cheers! John. ___ KDE PIM mailing list kde-...@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- Review request for Plasma. Repository: plasma-workspace Description --- Only drkonqi and systemmonitor depend on it. (systemmonitor uses libksysguard's processui lib, which is not installed by libksysguard if webkit is not found) Diffs - CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 Diff: https://git.reviewboard.kde.org/r/121718/diff/ Testing --- Compiling without qt5 webkit. Thanks, David Faure ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Change in plasma-framework[master]: Set visibility on mainItem to match Dialog
David Edmundson has uploaded a new change for review.
https://gerrit.vesnicky.cesnet.cz/r/282
Change subject: Set visibility on mainItem to match Dialog
..
Set visibility on mainItem to match Dialog
Otherwise we can have an invisible dialog in which the items think they
are visible.
QtQuick is smart enough to not redraw anything if the window isn't
visible, but a lot of bits of our code check the visibility flag to
enable/disable animations. These animation timers do still trigger when
the window isn't visible which wastes CPU cycles.
We are already meddling with the visibility flag so this shouldn't have
too much impact.
Change-Id: I92b969e60b4fdbe4ff2c70f9cce6e3408482a862
---
M src/plasmaquick/dialog.cpp
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework
refs/changes/82/282/1
diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp
index 1c07ab0..74c68a6 100644
--- a/src/plasmaquick/dialog.cpp
+++ b/src/plasmaquick/dialog.cpp
@@ -237,6 +237,10 @@
void DialogPrivate::updateVisibility(bool visible)
{
+if (mainItem) {
+mainItem-setVisible(visible);
+}
+
if (visible) {
if (visualParent visualParent-window()) {
q-setTransientParent(visualParent-window());
@@ -268,6 +272,7 @@
}
}
}
+
if (!(q-flags() Qt::ToolTip)) {
KWindowEffects::SlideFromLocation slideLocation =
KWindowEffects::NoEdge;
@@ -675,7 +680,7 @@
d-mainItem = mainItem;
if (mainItem) {
-d-mainItem-setVisible(true);
+d-mainItem-setVisible(isVisible());
mainItem-setParentItem(contentItem());
connect(mainItem, SIGNAL(widthChanged()), this,
SLOT(slotMainItemSizeChanged()));
--
To view, visit https://gerrit.vesnicky.cesnet.cz/r/282
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92b969e60b4fdbe4ff2c70f9cce6e3408482a862
Gerrit-PatchSet: 1
Gerrit-Project: plasma-framework
Gerrit-Branch: master
Gerrit-Owner: David Edmundson da...@davidedmundson.co.uk
Gerrit-Reviewer: Marco Martin notm...@gmail.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121720: Load wallpaper immediately on startup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121720/ --- Review request for Plasma. Repository: plasma-workspace Description --- When the shell starts we want the wallpaper to show up immediately to get a seamless transition from ksplash. This patch also hides the background color rectangle while the image is not ready yet to prevent it appearing for a split second. The add wallpaper stuff in Component.onCompleted has been removed since the function got fired twice due to the onModelImageChanged which seems to be executed anyway. Diffs - wallpapers/image/imagepackage/contents/ui/main.qml 0cb4812 Diff: https://git.reviewboard.kde.org/r/121720/diff/ Testing --- Logged in, splash screen disappears and the wallpaper is already there. The image seems to be loading fine too. The slideshow also no longer initially loads the default wallpaper but just black and then fade to the slideshow (but this is a bug in the image.cpp where it falls back to the default wallpaper even initially when it's still crawling for images (depending on the number of files it has to scan the default wallpaper can stay there for a second or two)) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- Ship it! - Lukáš Tinkl On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Pro. 28, 2014, 9:13 odp.) Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
On Pro. 28, 2014, 9:14 odp., Lukáš Tinkl wrote: Oh and, for the record, check the Chassis property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Pro. 28, 2014, 9:13 odp.) Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- Review request for Plasma. Repository: plasma-framework Description --- Before the move to QQC we used a Label with opacity 0.5 to gray it out. I suggested using Qt.tint but tinting a black label (in case of a light theme) with semi-transparent black still stays black. Instead I read the documentation and found a little paragraph Oh, by the way, there's r, g, b, a properties on every color. Diffs - src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 Diff: https://git.reviewboard.kde.org/r/121724/diff/ Testing --- Works fine on both light and dark breeze again. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
On Dez. 28, 2014, 8:14 nachm., Lukáš Tinkl wrote: Lukáš Tinkl wrote: Oh and, for the record, check the Chassis property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ Yeah I had that one at the back of my mind :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- On Dez. 28, 2014, 8:13 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Dez. 28, 2014, 8:13 nachm.) Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/#review72622 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 28, 2014, 9:17 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- (Updated Pro. 28, 2014, 9:17 odp.) Review request for Plasma. Repository: plasma-framework Description --- Before the move to QQC we used a Label with opacity 0.5 to gray it out. I suggested using Qt.tint but tinting a black label (in case of a light theme) with semi-transparent black still stays black. Instead I read the documentation and found a little paragraph Oh, by the way, there's r, g, b, a properties on every color. Diffs - src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 Diff: https://git.reviewboard.kde.org/r/121724/diff/ Testing --- Works fine on both light and dark breeze again. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor
aha, so the problem seems to be that when loaded via plasmoidviewer m_package.metadata().pluginName() == org.kde.desktopcontainment when using a custom interceptor to circumvent it, i still get strange errors. can someone help? QML debugging is enabled. Only use this in a safe environment. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Plasma/FocusFrameStyle.qml: File not found file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth file:///usr/lib/qt/qml/QtQuick/Controls/Styles/Base/ButtonStyle.qml:153:31: QML Item: Binding loop detected for property implicitWidth qml: View QML loaded kf5.kservice.sycoca: Trying to open ksycoca from /home/phil/.cache/ksycoca5 Trying to use rootObject before initialization is completed, whilst using setInitializationDelayed. Forcing completion Plasmoidviewer detected: circumventing security QUrl( file:///home/phil/Dev/KDE/steam-plasmoid/build/org/kde/plasma/private/steam/qmldir ) Plasmoidviewer detected: circumventing security QUrl( file:///home/phil/Dev/KDE/steam-plasmoid/build/org/kde/plasma/private/steam/qmldir ) Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. qml: New Containment: ContainmentInterface(0x194b390) QQmlComponent: Component is not ready QCoreApplication::postEvent: Unexpected null receiver file:///usr/share/plasma/shells/org.kde.plasma.plasmoidviewershell/contents/applet/AppletError.qml Error loading QML file. File not found Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() instead of kservice_desktop_to_json() in your CMake code. 2014-12-28 18:11 GMT+01:00 Philipp A. flying-sh...@web.de: code is here btw: https://github.com/flying-sheep/steam-plasmoid 2014-12-28 17:41 GMT+01:00 Philipp A. flying-sh...@web.de: but then i have to compile the whole plasma framework. that’s far out of scope of a plasma applet :/ 2014-12-28 0:57 GMT+01:00 David Edmundson da...@davidedmundson.co.uk: On Sat, Dec 27,
Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121724/ --- (Updated Dec. 28, 2014, 8:34 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- Before the move to QQC we used a Label with opacity 0.5 to gray it out. I suggested using Qt.tint but tinting a black label (in case of a light theme) with semi-transparent black still stays black. Instead I read the documentation and found a little paragraph Oh, by the way, there's r, g, b, a properties on every color. Diffs - src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 Diff: https://git.reviewboard.kde.org/r/121724/diff/ Testing --- Works fine on both light and dark breeze again. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Dec. 28, 2014, 8:35 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/ --- Review request for Plasma. Repository: plasma-framework Description --- This ensures Labels and TextFields/TextAreas (and basically anyone else using ColorScope) properly update their colors when theme changes. Diffs - src/declarativeimports/core/colorscope.cpp 4115052 Diff: https://git.reviewboard.kde.org/r/121726/diff/ Testing --- Switched from Breeze to Breeze Dark, no more darkgray text on black background and vice-versa. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/#review72628 --- Ship it! Ship It! - David Edmundson On Dec. 28, 2014, 9:29 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/ --- (Updated Dec. 28, 2014, 9:29 p.m.) Review request for Plasma. Repository: plasma-framework Description --- This ensures Labels and TextFields/TextAreas (and basically anyone else using ColorScope) properly update their colors when theme changes. Diffs - src/declarativeimports/core/colorscope.cpp 4115052 Diff: https://git.reviewboard.kde.org/r/121726/diff/ Testing --- Switched from Breeze to Breeze Dark, no more darkgray text on black background and vice-versa. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121726: Connect Plasma::Theme::themeChanged to ColorScope::colorsChanged
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121726/ --- (Updated Dec. 28, 2014, 10:03 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- This ensures Labels and TextFields/TextAreas (and basically anyone else using ColorScope) properly update their colors when theme changes. Diffs - src/declarativeimports/core/colorscope.cpp 4115052 Diff: https://git.reviewboard.kde.org/r/121726/diff/ Testing --- Switched from Breeze to Breeze Dark, no more darkgray text on black background and vice-versa. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121728: Fix Label not picking up font changes at runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/ --- Review request for Plasma. Bugs: 334818 http://bugs.kde.org/show_bug.cgi?id=334818 Repository: plasma-framework Description --- The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime. Diffs - src/plasma/private/theme_p.cpp 1963f74 Diff: https://git.reviewboard.kde.org/r/121728/diff/ Testing --- Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121728: Fix Label not picking up font changes at runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/#review72636 --- Ship it! src/plasma/private/theme_p.cpp https://git.reviewboard.kde.org/r/121728/#comment50613 so to confirm, it's redundant because we also have this line. - David Edmundson On Dec. 28, 2014, 10:22 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/ --- (Updated Dec. 28, 2014, 10:22 p.m.) Review request for Plasma. Bugs: 334818 http://bugs.kde.org/show_bug.cgi?id=334818 Repository: plasma-framework Description --- The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime. Diffs - src/plasma/private/theme_p.cpp 1963f74 Diff: https://git.reviewboard.kde.org/r/121728/diff/ Testing --- Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121728: Fix Label not picking up font changes at runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121728/ --- (Updated Dec. 28, 2014, 10:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 334818 http://bugs.kde.org/show_bug.cgi?id=334818 Repository: plasma-framework Description --- The event filter was installed but then removed when the color file path was not empty (read: always). Keeping the event filter around ensures font changes are picked up at runtime. Diffs - src/plasma/private/theme_p.cpp 1963f74 Diff: https://git.reviewboard.kde.org/r/121728/diff/ Testing --- Changed my fonts to bold or changed the size, everything updated like magic after hitting the Apply button. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121732: Port kcm_kded away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121732/ --- Review request for Plasma. Repository: plasma-desktop Description --- Port kcm_kded away from kdelibs4support Diffs - kcms/kded/CMakeLists.txt 07217e0cfe5490aab8099940de2ea26139fc52fe kcms/kded/kcmkded.h 272a6191a6c668dbc486673c724d5da02bbc5001 kcms/kded/kcmkded.cpp 34a1acf6c6105d3ef7202663417603b47478e359 Diff: https://git.reviewboard.kde.org/r/121732/diff/ Testing --- Compiles Thanks, Alex Richardson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/#review72655 --- Unfortunataly it doesn't fix it here, plasmashell starts with a blank screen. kquitapp5 plasmashell plasmashell brings it back - Lukáš Tinkl On Pro. 28, 2014, 11:33 dop., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Pro. 28, 2014, 11:33 dop.) Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously it didn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions
On Dec. 29, 2014, 7:25 a.m., Lukáš Tinkl wrote: Unfortunataly it doesn't fix it here, plasmashell starts with a blank screen. kquitapp5 plasmashell plasmashell brings it back Works for me.. :S which XRandr version you have? - Bhushan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/#review72655 --- On Dec. 28, 2014, 4:03 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Dec. 28, 2014, 4:03 p.m.) Review request for Plasma, Solid and Daniel Vrátil. Repository: libkscreen Description --- Avoid risk of starting two kscreen_launchers at the same having a race condition. There were three possible bugs: CheckIsAlreadyRunning tried to register a service and check if it worked. This could clash with another process checking at the same time. Causing them both to fail saying another is running Similarly, a daemon doing actual registering could clash with another daemon just checking if the name is free, and then it would fail saying we can't init() There was also a risk that two launchers pass the check that nothing is running, then both try to activate a session. DBus server handles this fine and one will gracefully fail. Without this patch the second launcher would just die without returning the path of the service that was activated causing the relevant app to do nothing. -- IMHO, you'd be better off having a fixed service name and using DBus activation for exactly these reasons. You could put the different backends at different object paths, and have a method on the root object that says which object path to use rather than using the stdout of a launcher. That's a discussion for another day though. Diffs - src/backendlauncher/backendloader.cpp e7da8cd src/backendlauncher/main.cpp f8bf323 Diff: https://git.reviewboard.kde.org/r/121710/diff/ Testing --- Send it to bshah. Plasmashell started for him. Previously it didn't. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121701: Introduce KQuickControls TextField with context menu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121701/#review72657 --- +1 to me, it's something that clearly belongs on our side. Also huge +1 for David for thinking about sonnet. - Aleix Pol Gonzalez On Dec. 27, 2014, 7:17 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121701/ --- (Updated Dec. 27, 2014, 7:17 p.m.) Review request for Plasma. Repository: kdeclarative Description --- This adds a KQuickControls TextField and TextArea with a context menu similar to what the widgets provide, based on Review 121698. It uses the new menu property and thus requires QtQuick.Controls 1.3, ie. Qt 5.4 and should eventually be used as base for its PlasmaComponents counterparts. A user of this Item could manupulate menu to remove or add additional items. Diffs - src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420 src/qmlcontrols/kquickcontrols/TextArea.qml PRE-CREATION src/qmlcontrols/kquickcontrols/TextField.qml PRE-CREATION src/qmlcontrols/kquickcontrols/private/CMakeLists.txt c024800 src/qmlcontrols/kquickcontrols/private/TextMenu.qml PRE-CREATION src/qmlcontrols/kquickcontrols/private/qmldir 8770bce src/qmlcontrols/kquickcontrols/qmldir 31d8b14 Diff: https://git.reviewboard.kde.org/r/121701/diff/ Testing --- Works in qmlscene, was too lazy recompiling the frameworksintegration for Qt 5.4 Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 --- Then Qt5Webkit should be marked as optional through the set_package_properties(). To be honest, I'm not thrilled about having many ways to configure these things, because sooner or later somebody will end up compiling Plasma without qtwebkit by mistake and then he'll miss drkonqi, but well, building qtwebkit sure is a PITA, so won't oppose. - Aleix Pol Gonzalez On Dec. 28, 2014, 6:16 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- (Updated Dec. 28, 2014, 6:16 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Only drkonqi and systemmonitor depend on it. (systemmonitor uses libksysguard's processui lib, which is not installed by libksysguard if webkit is not found) Diffs - CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974 drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67 Diff: https://git.reviewboard.kde.org/r/121718/diff/ Testing --- Compiling without qt5 webkit. Thanks, David Faure ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
