Review Request 122888: Port the look and feel KCM to the qml only version

2015-03-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122888/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-desktop


Description
---

this ports the lf kcm to KDeclarative::ConfigModule
showing an example on how should be used


Diffs
-

  CMakeLists.txt 7c6284c 
  kcms/lookandfeel/CMakeLists.txt 2cde16f 
  kcms/lookandfeel/autotests/CMakeLists.txt 1f01310 
  kcms/lookandfeel/kcm.h c082cd3 
  kcms/lookandfeel/kcm.cpp d930b45 
  kcms/lookandfeel/package/contents/ui/main.qml 9ff3df3 

Diff: https://git.reviewboard.kde.org/r/122888/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bluedevil frameworks merge?

2015-03-10 Thread David Rosca
Hi Jonathan,
frameworks port is complete, so I think it can be merged to master.

I will merge it today, if that's okay?

David

On Mon, Mar 9, 2015 at 5:10 PM, Jonathan Riddell j...@jriddell.org wrote:
 Hi David, do you think Bluedevil frameworks branch can be merged into master 
 for Plasma 5.3 or are there still features which have not been ported to 
 frameworks?

 Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122886: QML-only KCM base

2015-03-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77247
---



src/quickaddons/configmodule.h
https://git.reviewboard.kde.org/r/122886/#comment53046

I don't particularly like the KDeclarative namespace here since the library 
is called QuickAddons, but unfortunately that name is terrible, since makes 
people think this arrives from Qt (should have been called KQuickAddons, all 
old classes in it namespaced etc, that library is a disaster :/))


- Marco Martin


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122886/
 ---
 
 (Updated March 10, 2015, 11:28 a.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
 more declarative friendly.
 it loads a qml file that then will be able to access its instance as kcm or 
 as the KCM attached property, like what happens in plasmoids (for how 
 attached proeprties work, unfortunately only properties of the base class 
 will be accessible).
 They will be loaded in systemsettings by review 122887
 
 
 Diffs
 -
 
   src/quickaddons/CMakeLists.txt 3c7a34b 
   src/quickaddons/configmodule.h PRE-CREATION 
   src/quickaddons/configmodule.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/122886/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122884: Adapt to KDecoration API changes

2015-03-10 Thread Mika Allan Rauhala

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122884/
---

Review request for kwin and Plasma.


Repository: breeze


Description
---

Adapt to API changes proposed by /r/122882. Breeze::ColorSettings is moved to 
KDecoration. This allows per window color schemes with custom titlebar colors 
to work.


Diffs
-

  kdecoration/CMakeLists.txt 88b2fc17a55257df1a79434f8f639f360d6325d2 
  kdecoration/breezecolorsettings.h 40e04fb871f552bf31112d02cad86d286aa416c0 
  kdecoration/breezecolorsettings.cpp c52bfbe624fc79842f504a586cee20724b176be4 
  kdecoration/breezedecoration.h ccdc6a67c65aad4a17e083b3f3360fc3cb57ddbc 
  kdecoration/breezedecoration.cpp 5ed41d8e338a8128cf4a5698dcdc2aee2ff01259 

Diff: https://git.reviewboard.kde.org/r/122884/diff/


Testing
---


Thanks,

Mika Allan Rauhala

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122885: Adapt to KDecoration API changes

2015-03-10 Thread Mika Allan Rauhala

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122885/
---

Review request for kwin and Plasma.


Repository: oxygen


Description
---

Adapt to API changes proposed by /r/122882.


Diffs
-

  kdecoration/oxygenbutton.cpp 943b6f7ba1c162ad0fb13674911daf0f12c40966 
  kdecoration/oxygendecoration.cpp c8f3bfc7a378a672101e9e7fe8f08ac98ea2a363 
  kdecoration/oxygensizegrip.cpp 4fbc149efabf8bf2d4821b485fcde5e6c660fd1d 

Diff: https://git.reviewboard.kde.org/r/122885/diff/


Testing
---


Thanks,

Mika Allan Rauhala

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122886: QML-only KCM base

2015-03-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/#review77248
---



src/quickaddons/configmodule.cpp
https://git.reviewboard.kde.org/r/122886/#comment53047

I didn't test things that need authentication yet (if some good soul ports 
a module that uses it would be great)
but seems there may be a problem here due to KAuth assuming QWidgets


- Marco Martin


On March 10, 2015, 11:28 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122886/
 ---
 
 (Updated March 10, 2015, 11:28 a.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
 more declarative friendly.
 it loads a qml file that then will be able to access its instance as kcm or 
 as the KCM attached property, like what happens in plasmoids (for how 
 attached proeprties work, unfortunately only properties of the base class 
 will be accessible).
 They will be loaded in systemsettings by review 122887
 
 
 Diffs
 -
 
   src/quickaddons/CMakeLists.txt 3c7a34b 
   src/quickaddons/configmodule.h PRE-CREATION 
   src/quickaddons/configmodule.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/122886/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bluedevil frameworks merge?

2015-03-10 Thread Sebastian Kügler
On Tuesday, March 10, 2015 11:08:57 David Rosca wrote:
 frameworks port is complete, so I think it can be merged to master.
 
 I will merge it today, if that's okay?

I've been using it for a while, and just tested it last week. It worked nicely 
with my Bluetooth headphones.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122887: Load and wrap the QML-only version of kcms if possible

2015-03-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122887/
---

Review request for KDE Frameworks and Plasma.


Repository: kcmutils


Description
---

This makes KCMLoader try to load the qobject-only, qml based kcms as well, if 
it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it 
as loaded module (the class itself is not exported, so no new symbols).
This makes systemsettings, kcmshell and any config dialog that loads kcms 
transparently load those config modules not based upon KCModule


Diffs
-

  CMakeLists.txt cb4ae5d 
  src/CMakeLists.txt f7b869f 
  src/kcmoduleloader.cpp 5ccf236 
  src/kcmoduleqml.cpp PRE-CREATION 
  src/kcmoduleqml_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122887/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122886: QML-only KCM base

2015-03-10 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122886/
---

Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
---

This is a QObject-based fork of KCmodule, with the api slightly adaped to be 
more declarative friendly.
it loads a qml file that then will be able to access its instance as kcm or 
as the KCM attached property, like what happens in plasmoids (for how 
attached proeprties work, unfortunately only properties of the base class will 
be accessible).
They will be loaded in systemsettings by review 122887


Diffs
-

  src/quickaddons/CMakeLists.txt 3c7a34b 
  src/quickaddons/configmodule.h PRE-CREATION 
  src/quickaddons/configmodule.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122886/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bluedevil frameworks merge?

2015-03-10 Thread Jonathan Riddell

That would be lovely thanks :)

Jonathan


On Tue, Mar 10, 2015 at 11:08:57AM +0100, David Rosca wrote:
 Hi Jonathan,
 frameworks port is complete, so I think it can be merged to master.
 
 I will merge it today, if that's okay?
 
 David
 
 On Mon, Mar 9, 2015 at 5:10 PM, Jonathan Riddell j...@jriddell.org wrote:
  Hi David, do you think Bluedevil frameworks branch can be merged into 
  master for Plasma 5.3 or are there still features which have not been 
  ported to frameworks?
 
  Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

2015-03-10 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122673/#review77254
---


Final comment (promise!)
then ship it.


src/declarativeimports/core/units.h
https://git.reviewboard.kde.org/r/122673/#comment53052

I don't understand this name.

1) It's not storing anything decimal related.
m_scaledDevicePixelRatio maybe.

2) once you rebase, line 183 becomes logicalDotsPerInch which is already 
scaled, so you don't need this?


I tried it on the fancy machine with line 183 changed to logicalDPI and all 
other changes in units reverted, and that seemed to be fine?

- David Edmundson


On March 9, 2015, 9:53 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122673/
 ---
 
 (Updated March 9, 2015, 9:53 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 (still in progress but here for feedback)
 when QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps 
 generated by Svg will be scaled up to give a proper texture.
 
 This is complementary but not replacing our current approach:
 the pixelratio that can be accessed by units is now in relation to the qt 
 pixel ratio, spacings are also adjusted accordingly (therefore, spaces and 
 sizes won't need an integer value like pixelratio)
 
 svg introduces also a scaleFactor property (that is pretty much like its old 
 pixelRatio)
 basically, scalefactor, will scale both the textures *and* all the reported 
 sizes, (old method) pixelratio just scales textures without altering measures 
 (like qt pixelratio likes)
 they are now both used and combined, so a) we can have this working before 
 supporting officially qt pixelratio when will be good enough but b) keeping 
 the old mwthod working for the time being c) by using both at the sae time we 
 can at least scale sizes of values != from integers, for screens that are too 
 dense for 1 and not enough for 2
 
 
 Diffs
 -
 
   src/declarativeimports/core/framesvgitem.cpp dae8a4f 
   src/declarativeimports/core/iconitem.cpp 03f40c4 
   src/declarativeimports/core/svgitem.cpp 570c1c3 
   src/declarativeimports/core/units.h 6c038ba 
   src/declarativeimports/core/units.cpp a740145 
   src/plasma/framesvg.cpp 1bb3510 
   src/plasma/private/svg_p.h a31d0ac 
   src/plasma/svg.h 0bcbd7a 
   src/plasma/svg.cpp 0a0db5e 
 
 Diff: https://git.reviewboard.kde.org/r/122673/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122899: Set directory mimetype for smb protocol

2015-03-10 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/#review77284
---

Ship it!



smb/kio_smb_browse.cpp
https://git.reviewboard.kde.org/r/122899/#comment53075

Correct indentation?


- Lukáš Tinkl


On Bře. 10, 2015, 11:18 odp., Rajeesh K Nambiar wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122899/
 ---
 
 (Updated Bře. 10, 2015, 11:18 odp.)
 
 
 Review request for Plasma.
 
 
 Repository: kio-extras
 
 
 Description
 ---
 
 Browsing samba shares using Dolphin doesn't show directory icons properly. 
 This is due to missing mimetype in UDSEntry. Set the mimetype 
 inode/directory for directories.
 
 
 Diffs
 -
 
   smb/kio_smb_browse.cpp 67e2fa0 
 
 Diff: https://git.reviewboard.kde.org/r/122899/diff/
 
 
 Testing
 ---
 
 Tested with kio-extras 5.2.1. See attached before and after screenshots of 
 Dolphin.
 
 
 File Attachments
 
 
 samba folder before
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
 samba folder after
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png
 
 
 Thanks,
 
 Rajeesh K Nambiar
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins build is back to stable : plasma-workspace_master_qt5 #1381

2015-03-10 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1381/changes

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Bluedevil frameworks merge?

2015-03-10 Thread Raymond Wooninck
On Tuesday, March 10, 2015 03:59:35 PM David Rosca wrote:
 Done.
 I have also updated branches in kde-build-metadata.
 
 David
 

What about the libbluedevil framework branch ? Shouldn't this be merged as 
well into its master branch ?

Regards

Raymond
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122332: KQuickControls IconDialog

2015-03-10 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77270
---


I tried using setTransientParent but the windowHandle is null before I show the 
dialog but changing it afterwards doesn't work.

- Kai Uwe Broulik


On März 10, 2015, 8:03 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122332/
 ---
 
 (Updated März 10, 2015, 8:03 nachm.)
 
 
 Review request for Plasma and Daniel Vrátil.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 This patch adds KQuickControls wrapper around KIconDialog similar to how the 
 ColorDialog and other QtQuick Dialogs work. This can be used, for instance, 
 in Kickoff's config UI to provide a picker for a custom item.
 
 It is an initial draft and lacks for example window modality as I couldn't 
 figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic 
 inside) and I'm also not sure about the lifecycle/ownership of the dialog, 
 I've seen a lot of fixes for issues in that area on Review Board.
 
 
 Diffs
 -
 
   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
   src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 
 
 Diff: https://git.reviewboard.kde.org/r/122332/diff/
 
 
 Testing
 ---
 
 For testing I added a button to Kickoff that allows to open the dialog and 
 the button icon source is bound to the dialog's iconName property. Didn't 
 test the icon source/user/custom path stuff.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122894: Add config option for Kickoff icon

2015-03-10 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This restores the functionality from the 4.x times. The button uses the same 
style used in various places, such as lockscreen and display manager, it has a 
Choose action and a, previously missing, convenient Clear action.


Diffs
-

  applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 

Diff: https://git.reviewboard.kde.org/r/122894/diff/


Testing
---

Choosing an icon works, applying changes the icon, and reset resets it. Is 
there a way to set a config back to its defaults?


File Attachments


Config in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122332: KQuickControls IconDialog

2015-03-10 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/
---

(Updated März 10, 2015, 8:03 nachm.)


Review request for Plasma and Daniel Vrátil.


Changes
---

Rebased.

Close dialog on destruction just to be sure. It requires Review 122893 because 
both openDialog and showDialog mess with the dialog's modality (either 
ApplicationModal or NonModal).

The Dialog is WindowModal. I added it to Kickoff and for some reason both the 
applet config dialog as well as all panels and the desktop get dimmed, whereas 
widget explorer is not. Using WindowModal causes all of plasma to be 
non-interactive while the dialog is there. I looked at QtQuick Dialogs because 
these seem to support proper modality but I ended up in some QPA madness and 
gave up. I didn't find a way to tell it which is the parent window, 
setParent(window()) didn't work because QDialog wants a QWidget parent.


Repository: kdeclarative


Description
---

This patch adds KQuickControls wrapper around KIconDialog similar to how the 
ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in 
Kickoff's config UI to provide a picker for a custom item.

It is an initial draft and lacks for example window modality as I couldn't 
figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) 
and I'm also not sure about the lifecycle/ownership of the dialog, I've seen a 
lot of fixes for issues in that area on Review Board.


Diffs (updated)
-

  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 

Diff: https://git.reviewboard.kde.org/r/122332/diff/


Testing
---

For testing I added a button to Kickoff that allows to open the dialog and the 
button icon source is bound to the dialog's iconName property. Didn't test the 
icon source/user/custom path stuff.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122894: Add config option for Kickoff icon

2015-03-10 Thread Kai Uwe Broulik


 On März 10, 2015, 9:23 nachm., Marco Martin wrote:
  applets/kickoff/package/contents/ui/configGeneral.qml, line 63
  https://git.reviewboard.kde.org/r/122894/diff/1/?file=354051#file354051line63
 
  this looks a bit hackish, sure is visually really necessary?

In a widget world with the menu attached to the button it stays in its pressed 
state until the menu closes. Since we cannot change the state to pressed from 
the outside, I use the checked property to provide some kind of feedback.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/#review77271
---


On März 10, 2015, 8:55 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122894/
 ---
 
 (Updated März 10, 2015, 8:55 nachm.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 This restores the functionality from the 4.x times. The button uses the same 
 style used in various places, such as lockscreen and display manager, it has 
 a Choose action and a, previously missing, convenient Clear action.
 
 
 Diffs
 -
 
   applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 
 
 Diff: https://git.reviewboard.kde.org/r/122894/diff/
 
 
 Testing
 ---
 
 Choosing an icon works, applying changes the icon, and reset resets it. Is 
 there a way to set a config back to its defaults?
 
 
 File Attachments
 
 
 Config in action
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 122899: Set directory mimetype for smb protocol

2015-03-10 Thread Rajeesh K Nambiar

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122899/
---

Review request for Plasma.


Repository: kio-extras


Description
---

Browsing samba shares using Dolphin doesn't show directory icons properly. This 
is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for 
directories.


Diffs
-

  smb/kio_smb_browse.cpp 67e2fa0 

Diff: https://git.reviewboard.kde.org/r/122899/diff/


Testing
---

Tested with kio-extras 5.2.1. See attached before and after screenshots of 
Dolphin.


File Attachments


samba folder before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png
samba folder after
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png


Thanks,

Rajeesh K Nambiar

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 122332: KQuickControls IconDialog

2015-03-10 Thread Martin Klapetek


 On March 10, 2015, 9:36 p.m., Kai Uwe Broulik wrote:
  I tried using setTransientParent but the windowHandle is null before I show 
  the dialog but changing it afterwards doesn't work.

You can call m_dialog-winId() before, that will ensure that windowHandle is 
created without needing to show the dialog first


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review77270
---


On March 10, 2015, 9:03 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122332/
 ---
 
 (Updated March 10, 2015, 9:03 p.m.)
 
 
 Review request for Plasma and Daniel Vrátil.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 This patch adds KQuickControls wrapper around KIconDialog similar to how the 
 ColorDialog and other QtQuick Dialogs work. This can be used, for instance, 
 in Kickoff's config UI to provide a picker for a custom item.
 
 It is an initial draft and lacks for example window modality as I couldn't 
 figure out how QtQuick Dialogs do that (some PlatformDialogHelper magic 
 inside) and I'm also not sure about the lifecycle/ownership of the dialog, 
 I've seen a lot of fixes for issues in that area on Review Board.
 
 
 Diffs
 -
 
   src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt d5713a0 
   src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION 
   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION 
   src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp cee2360 
 
 Diff: https://git.reviewboard.kde.org/r/122332/diff/
 
 
 Testing
 ---
 
 For testing I added a button to Kickoff that allows to open the dialog and 
 the button icon source is bound to the dialog's iconName property. Didn't 
 test the icon source/user/custom path stuff.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2015-03-10 Thread Ivan Čukić
Ivan:
- mostly work on ResourceModel in libkactivities-stats
- few squashed bugs

On 9 March 2015 at 22:01, Sebastian Kügler se...@kde.org wrote:
 On Monday, March 09, 2015 12:30:44 Marco Martin wrote:
 notes for hangout of 9 March:

 present: Jens, David, Kai Uwe, Vishesh, Marco

 From me (sorry for not being able to attend):
 - Worked on papercuts, quite a few down already
 - Fixed a regression (caused by myself) in the tooltip (thanks everybody who
helped, I *think* we got it right just in time for the Frameworks 5.8
release
 - NM Plasmoid's tooltip is now more in line with other systray widgets
 - Pager collapses to zero width (or height) now when virtual desktops  2
 - Toolbox is more subtle (faded background)
 - Kickoff's Recently Used tab is now called History (shorter labels are
 happy labels)

 I think that's it from my side.
 --
 sebas

 Sebastian Kügler|http://vizZzion.org| http://kde.org
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel



-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel