Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- Review request for kwin, Plasma and Kai Uwe Broulik. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122209: [plasma-workspace] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review77607 --- ksmserver/CMakeLists.txt https://git.reviewboard.kde.org/r/122209/#comment53298 AFAIU the if is not needed. The tests should be marked with ecm_mark_as_test which will not build them if BUILD_TESTING is disabled. - Martin Gräßlin On March 17, 2015, 12:18 a.m., Andreas Sturmlechner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/ --- (Updated March 17, 2015, 12:18 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- Qt5Test should not be mandatory. Diffs - CMakeLists.txt 907c00836531db511a91860993a54acd89720055 ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce ksmserver/screenlocker/greeter/CMakeLists.txt d502cb82516e85a76685d7e3d7106a41dcf0cfff Diff: https://git.reviewboard.kde.org/r/122209/diff/ Testing --- Built with (all successful) and without tests. Thanks, Andreas Sturmlechner ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- kcmkwin/kwindecoration/qml/main.qml https://git.reviewboard.kde.org/r/122985/#comment53299 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization - Martin Klapetek On March 17, 2015, 9:20 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 9:20 a.m.) Review request for kwin, Plasma and Kai Uwe Broulik. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1106
See http://build.kde.org/job/plasma-desktop_master_qt5/1106/changes Changes: [hein] Don't allow press-to-move when widgets are locked. -- [...truncated 1206 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ [ 31%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/leavemodel.cpp.o [ 31%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/models.cpp.o [ 31%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/runnermatchesmodel.cpp.o [ 32%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/recentappsmodel.cpp.o [ 32%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/kcm_solid_actions_automoc.cpp.o [ 33%] Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/core/recentapplications.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.cpp:21:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:38:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp: In member function ‘void Kickoff::LeaveModel::updateModel()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:181:85: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74)
Building Plasma Media Center
Hi All, I just started with Plasma Media Center. I was hoping to work on Intelligent TV Series/Movies grouping for Plasma Media Center as part of Google Summer of Code 2015. I was able to build successfully Plasma Media Center on Kubuntu (without mockcpp, was not able to get this library from repository and I did not know how to add custom build one). The problem is when I opened Plasma Media Center it only show a blank screen. Could you please help me with below issues. 1 - Build Plasma Media Center with mockcpp. 2 - How to get rid of blank screen when open Plasma Media Center 3 - kbuildsycoca4 was also not successful. How to make it work (below is the error I got) - kbuildsycoca4(17948) VFolderMenu::loadDoc: Parse error in /home/drawat/.config/menus/applications-merged/xdg-desktop-menu-dummy.menu , line 1 , col 1 : unexpected end of file This is the first time I am starting with open source project (I am thankful to my professor to encourage me to work on Open Source project). It would be helpful if you can point me to some resources, right now I am exploring the project documentation. Please excuse me if I am not according to mailing list guidelines. Best Regards, Deepak ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On March 17, 2015, 9:53 a.m., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization Martin Gräßlin wrote: My understanding was that ... is needed when a dialog is opened - adding Thomas as expert Martin Klapetek wrote: Ah sorry, I posted that comment only after looking at the screenshots and thought this /does/ open a new dialog. In that case, I think some drop-down arrow would be more helpful rather than ... yes, I also thought about an arrow, but was unsure on how to do it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On March 17, 2015, 10:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 10:59 a.m.) Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On March 17, 2015, 9:53 a.m., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization My understanding was that ... is needed when a dialog is opened - adding Thomas as expert - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On March 17, 2015, 9:20 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 9:20 a.m.) Review request for kwin, Plasma and Kai Uwe Broulik. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On March 17, 2015, 9:53 a.m., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization Martin Gräßlin wrote: My understanding was that ... is needed when a dialog is opened - adding Thomas as expert Ah sorry, I posted that comment only after looking at the screenshots and thought this /does/ open a new dialog. In that case, I think some drop-down arrow would be more helpful rather than ... - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On March 17, 2015, 10:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 10:59 a.m.) Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to normal : plasma-desktop_master_qt5 #1107
See http://build.kde.org/job/plasma-desktop_master_qt5/1107/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #1105
See http://build.kde.org/job/plasma-desktop_master_qt5/1105/changes Changes: [hein] Simplify. -- [...truncated 892 lines...] Generating moc_main.cpp Scanning dependencies of target kfontview_bin_automoc [ 19%] Generating kcm.moc Generating moc_folderselectionwidget.cpp Generating moc_kcm.cpp Built target kcm_useraccount_automoc [ 19%] Built target kcm_baloofile_automoc [ 19%] Scanning dependencies of target kio_fonts_automoc Automatic moc for target kfontview_bin Scanning dependencies of target fontthumbnail_automoc [ 19%] Automatic moc for target kio_fonts [ 19%] Generating moc_FontinstIface.cpp Generating moc_Helper.cpp Automatic moc for target fontthumbnail [ 19%] [ 19%] Built target fontinst_helper_automoc Built target fontthumbnail_automoc Generating fonts.moc Generating moc_fonts.cpp [ 19%] Built target kcm_fonts_automoc Scanning dependencies of target kfontviewpart_automoc [ 19%] Scanning dependencies of target attica_kde_automoc Automatic moc for target kfontviewpart [ 20%] Scanning dependencies of target knetattach_automoc [ 20%] Automatic moc for target attica_kde Generating moc_Printer.cpp Generating moc_ActionLabel.cpp Automatic moc for target knetattach [ 20%] Built target kfontprint_bin_automoc Scanning dependencies of target activityswitcherextensionplugin_automoc Generating moc_FontInst.cpp Generating moc_FontinstIface.cpp Generating moc_knetattach.cpp [ 20%] [ 20%] Generating moc_Viewer.cpp Automatic moc for target activityswitcherextensionplugin [ 20%] Built target fontinst_bin_automoc Built target knetattach_automoc [ 20%] [ 21%] Built target kfontview_bin_automoc Generating ui_ActionEditor.h Generating moc_kdeplatformdependent.cpp [ 21%] Built target attica_kde_automoc [ 21%] Scanning dependencies of target solid-action-desktop-gen Generating ui_SolidActions.h [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/DesktopFileGenerator.cpp.o Scanning dependencies of target desktopplugin Generating switcherbackend.moc http://build.kde.org/job/plasma-desktop_master_qt5/ws/imports/activitymanager/switcherbackend.cpp:0: Note: No relevant classes found. No output generated. [ 21%] [ 21%] Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_JobRunner.cpp [ 21%] Built target kfontinst_bin_automoc Generating ui_AddAction.h Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/desktopplugin.cpp.o [ 21%] Generating moc_FontinstIface.cpp Generating moc_FontInstInterface.cpp [ 21%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/eventforge.cpp.o Built target kio_fonts_automoc [ 21%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/infonotification.cpp.o Generating moc_activityswitcherextensionplugin.cpp Generating moc_switcherbackend.cpp [ 21%] Built target activityswitcherextensionplugin_automoc [ 21%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/systemsettings.cpp.o Scanning dependencies of target kcm_solid_actions [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateItem.cpp.o Scanning dependencies of target folderplugin [ 21%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/directorypicker.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp: In member function ‘void InfoNotification::show()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:62:104: error: no matching function for call to ‘InfoNotification::connect(QPointerKNotification, void (KNotification::*)(), InfoNotification* const, void (InfoNotification::*)()const)’ connect(m_notification, KNotification::action1Activated, this, InfoNotification::acknowledged); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:62:104: note: candidates are: In file included from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/QObject:1:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.h:23, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:20: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:196:36: note: static QMetaObject::Connection QObject::connect(const QObject*, const char*, const QObject*, const char*, Qt::ConnectionType) static QMetaObject::Connection connect(const QObject *sender, const char *signal, ^
Build failed in Jenkins: plasma-desktop_master_qt5 #1103
See http://build.kde.org/job/plasma-desktop_master_qt5/1103/changes Changes: [hein] Show a help notification to aid press-to-move discovery when unlocking widgets. -- [...truncated 1216 lines...] from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:21: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 32%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/viewpropertiesmenu.cpp.o [ 32%] Building CXX object applets/kicker/CMakeFiles/kickerplugin.dir/plugin/imagepicker.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:98:54: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KService::Ptr Kickoff::serviceForUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:138:49: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] bool KRunnerItemHandler::openUrl(const KUrl url) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual Qt::ItemFlags Kickoff::KRunnerModel::flags(const QModelIndex) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:258:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp: In member function ‘virtual QMimeData* Kickoff::KRunnerModel::mimeData(const QModelIndexList) const’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:272:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:275:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl url = data(index, UrlRole).toString(); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/krunnermodel.cpp:287:39: warning: ‘void KUrl::List::populateMimeData(QMimeData*, const MetaDataMap, KUrl::MimeDataFlags) const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:221) [-Wdeprecated-declarations] urls.populateMimeData(mimeData); ^ [ 32%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/wheelinterceptor.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:38:0: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/models.h:138:30: warning: ‘KComponentData’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kcomponentdata.h:51) [-Wdeprecated-declarations] KComponentData componentData(); ^ [ 32%] http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp: In member function ‘void Kickoff::LeaveModel::updateModel()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/applets/kickoff/core/leavemodel.cpp:181:85: warning: ‘QSetSolid::PowerManagement::SleepState Solid::PowerManagement::supportedSleepStates()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/solid/powermanagement.h:74) [-Wdeprecated-declarations] QSet Solid::PowerManagement::SleepState spdMethods = Solid::PowerManagement::supportedSleepStates(); ^
Build failed in Jenkins: plasma-desktop_master_qt5 #1104
See http://build.kde.org/job/plasma-desktop_master_qt5/1104/changes Changes: [hein] Pop up the help notification whenever press-to-move gets enabled while widgets are unlocked. -- [...truncated 943 lines...] [ 21%] Built target kio_fonts_automoc [ 21%] Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/eventforge.cpp.o Generating moc_FontinstIface.cpp Generating moc_ActionLabel.cpp Generating moc_JobRunner.cpp [ 21%] Built target kfontinst_bin_automoc [ 21%] Generating moc_activityswitcherextensionplugin.cpp Generating moc_switcherbackend.cpp Building CXX object containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/infonotification.cpp.o [ 21%] Built target activityswitcherextensionplugin_automoc Scanning dependencies of target kcm_solid_actions [ 21%] [ 21%] Building CXX object solid-actions-kcm/CMakeFiles/solid-action-desktop-gen.dir/SolidActionData.cpp.o Building CXX object solid-actions-kcm/CMakeFiles/kcm_solid_actions.dir/PredicateItem.cpp.o Scanning dependencies of target folderplugin [ 21%] Building CXX object containments/desktop/plugins/folder/CMakeFiles/folderplugin.dir/directorypicker.cpp.o http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp: In member function ‘void InfoNotification::show()’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:62:104: error: no matching function for call to ‘InfoNotification::connect(QPointerKNotification, void (KNotification::*)(), InfoNotification* const, void (InfoNotification::*)()const)’ connect(m_notification, KNotification::action1Activated, this, InfoNotification::acknowledged); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:62:104: note: candidates are: In file included from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/QObject:1:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.h:23, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:20: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:196:36: note: static QMetaObject::Connection QObject::connect(const QObject*, const char*, const QObject*, const char*, Qt::ConnectionType) static QMetaObject::Connection connect(const QObject *sender, const char *signal, ^ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:196:36: note: no known conversion for argument 2 from ‘void (KNotification::*)()’ to ‘const char*’ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:199:36: note: static QMetaObject::Connection QObject::connect(const QObject*, const QMetaMethod, const QObject*, const QMetaMethod, Qt::ConnectionType) static QMetaObject::Connection connect(const QObject *sender, const QMetaMethod signal, ^ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:199:36: note: no known conversion for argument 2 from ‘void (KNotification::*)()’ to ‘const QMetaMethod’ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:477:32: note: QMetaObject::Connection QObject::connect(const QObject*, const char*, const char*, Qt::ConnectionType) const inline QMetaObject::Connection QObject::connect(const QObject *asender, const char *asignal, ^ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:477:32: note: no known conversion for argument 2 from ‘void (KNotification::*)()’ to ‘const char*’ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:213:43: note: templateclass Func1, class Func2 static QMetaObject::Connection QObject::connect(const typename QtPrivate::FunctionPointerFunc::Object*, Func1, const typename QtPrivate::FunctionPointerFunc2::Object*, Func2, Qt::ConnectionType) static inline QMetaObject::Connection connect(const typename QtPrivate::FunctionPointerFunc1::Object *sender, Func1 signal, ^ /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtCore/qobject.h:213:43: note: template argument deduction/substitution failed: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/desktop/plugins/desktop/infonotification.cpp:62:104: note: mismatched types ‘const typename QtPrivate::FunctionPointerFunc::Object*’ and ‘QPointerKNotification’ connect(m_notification, KNotification::action1Activated, this,
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On March 17, 2015, 8:53 a.m., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization Martin Gräßlin wrote: My understanding was that ... is needed when a dialog is opened - adding Thomas as expert Martin Klapetek wrote: Ah sorry, I posted that comment only after looking at the screenshots and thought this /does/ open a new dialog. In that case, I think some drop-down arrow would be more helpful rather than ... Martin Gräßlin wrote: yes, I also thought about an arrow, but was unsure on how to do it. Thomas Lübking wrote: There's no way back, is there? - Tabs? Style / Layout Martin Gräßlin wrote: would prefer to not have tabs as it makes everything (option syncing, updating previews) more complicated and the second tab would have lots of whitespace ;-) Even though you might not like it, I have to side with my namesake here: Now that I - admittedly - see the button config UI in the context of the list, it really feels like two things that don't belong together have been put in the same UI. We have a list of windecos to select from and then below it, barely separated from it - is a UI that does a completely different thing. This may already confuse users into mistaking the button config UI for just another windeco preview if they don't look closely enough, and the new situation with a button expanding into the full UI when the window is resized might just add to the confusion (jumpy UIs should be avoided if possible, as they are less predictable). I'm not exactly a huge tab fan in general, but in this case it makes perfect sense since we have two related, yet distinct sets of controls. Unless the added complexity would very likely cause tons of nasty bugs, a UI with a bit of whitespace would be a perfectly okay trade-off for reduced confusion and no need to come up with workarounds for a space limitation problem. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On March 17, 2015, 9:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 9:59 a.m.) Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On March 17, 2015, 9:53 a.m., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization Martin Gräßlin wrote: My understanding was that ... is needed when a dialog is opened - adding Thomas as expert Martin Klapetek wrote: Ah sorry, I posted that comment only after looking at the screenshots and thought this /does/ open a new dialog. In that case, I think some drop-down arrow would be more helpful rather than ... Martin Gräßlin wrote: yes, I also thought about an arrow, but was unsure on how to do it. Thomas Lübking wrote: There's no way back, is there? - Tabs? Style / Layout would prefer to not have tabs as it makes everything (option syncing, updating previews) more complicated and the second tab would have lots of whitespace ;-) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On March 17, 2015, 10:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated March 17, 2015, 10:59 a.m.) Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Building Plasma Media Center
Hello! On Tue, Mar 17, 2015 at 2:56 PM, Deepak Rawat deepakrawat2...@gmail.com wrote: I just started with Plasma Media Center. I was hoping to work on Intelligent TV Series/Movies grouping for Plasma Media Center as part of Google Summer of Code 2015. Welcome.. :-) I was able to build successfully Plasma Media Center on Kubuntu (without mockcpp, was not able to get this library from repository and I did not know how to add custom build one). The problem is when I opened Plasma Media Center it only show a blank screen. Could you please help me with below issues. First of all which branch you compiled? master branch or v1.4 branch? Please note that both are totally different.. 1 - Build Plasma Media Center with mockcpp. mockcpp is optional dependency of the Plasma Media Center to run the automated unit tests and it is not required to run the Plasma Media Center. You can ignore it for now. 2 - How to get rid of blank screen when open Plasma Media Center Depends upon what you mean by blank screen? There are no media items shown and just categories? or nothing is shown? preferably link us the screenshot of what you mean.. 3 - kbuildsycoca4 was also not successful. How to make it work (below is the error I got) - kbuildsycoca4(17948) VFolderMenu::loadDoc: Parse error in /home/drawat/.config/menus/applications-merged/xdg-desktop-menu-dummy.menu , line 1 , col 1 : unexpected end of file This warning is totally unrelated and not fatal. You can ignore this too for now. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122985: [kcmkwin/deco] Hide button layout on small screen estate
On März 17, 2015, 8:53 vorm., Martin Klapetek wrote: kcmkwin/kwindecoration/qml/main.qml, line 52 https://git.reviewboard.kde.org/r/122985/diff/1/?file=355356#file355356line52 This should end with ... to hint that new dialog will show (it will right?) and the text should be capitalized as per the HIG https://techbase.kde.org/Projects/Usability/HIG/Capitalization Martin Gräßlin wrote: My understanding was that ... is needed when a dialog is opened - adding Thomas as expert Martin Klapetek wrote: Ah sorry, I posted that comment only after looking at the screenshots and thought this /does/ open a new dialog. In that case, I think some drop-down arrow would be more helpful rather than ... Martin Gräßlin wrote: yes, I also thought about an arrow, but was unsure on how to do it. There's no way back, is there? - Tabs? Style / Layout - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/#review77608 --- On März 17, 2015, 9:59 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122985/ --- (Updated März 17, 2015, 9:59 vorm.) Review request for kwin, Plasma, Kai Uwe Broulik, and Thomas Pfeiffer. Repository: kwin Description --- If the window is small the list of decorations might not be visible at all giving a bad first impression on opening systemsettings and also making the user interface difficult to use. This change ensures that at least two decorations are visible before we try to show the buttons view. So only if the window is large enough the button configuration will be shown. Otherwise a push button is displayed to explicitly show the button config interface. This explicit show is not bound to the size of the window. If the window gets resized in a way that there is enough place for the button interface the view is shown autmatically and the button is hidden. There is no button to hide the view again. This is considered not needed as at that point a user already has seen the view and recognized that the list of decorations can be scrolled. Diffs - kcmkwin/kwindecoration/qml/Previews.qml eabc666432b5df04e929f1ba640a79cd99714a9d kcmkwin/kwindecoration/qml/main.qml 4d8bcf8c98f238676e9128da20f4969980bf143c Diff: https://git.reviewboard.kde.org/r/122985/diff/ Testing --- File Attachments Buttons hidden on small window https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/fe54076a-1d58-49c4-a27d-f49da4f3bb97__view-small.png Buttons automatically shown if window is large enough https://git.reviewboard.kde.org/media/uploaded/files/2015/03/17/29970eae-8189-47c3-b942-6aade7111956__view-large.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122988: make PlasmaCore.ColorScope work better as advertised
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122988/ --- Review request for Plasma. Repository: plasma-framework Description --- Since attached properties cannot ever change during the lifetime of the object, a colorscope needs to be created for each obect that asks for the attached property. now each instance if (internal) has m_inherit (only those created as an attached property), will search for the property of the proper ancestor. Not super efficient, but the proeprties should be actually asked for rarely enough. doesn't look much nice, but seems to work pretty reliably and the only way to. Diffs - src/declarativeimports/core/colorscope.h fa75b9d src/declarativeimports/core/colorscope.cpp cca0d2f src/declarativeimports/plasmacomponents/qml/TabButton.qml a336900 Diff: https://git.reviewboard.kde.org/r/122988/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122990: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122990/ --- Review request for Plasma. Repository: kscreen Description --- The only usage I can find of QX11Extras is a stray include, so remove it. Diffs - CMakeLists.txt 19801903fc03a634b23f2819bc3c4d5fc08dbc97 console/CMakeLists.txt 860cc5f6b996dc47c54245c51c8f6756495233ba console/console.cpp 91be35bfb0f1ebf0950da0850426fcc7f45dd0db kcm/src/CMakeLists.txt 8c693b50ec04e3143735b8917aedc7e81d987fbd tests/kded/CMakeLists.txt 528eaa817980d0027c98441666b1a1ca5f56dbcb Diff: https://git.reviewboard.kde.org/r/122990/diff/ Testing --- Inspected source and checked library links. Builds and runs. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122990: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122990/#review77645 --- +1 - Aleix Pol Gonzalez On March 17, 2015, 5:17 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122990/ --- (Updated March 17, 2015, 5:17 p.m.) Review request for Plasma. Repository: kscreen Description --- The only usage I can find of QX11Extras is a stray include, so remove it. Diffs - CMakeLists.txt 19801903fc03a634b23f2819bc3c4d5fc08dbc97 console/CMakeLists.txt 860cc5f6b996dc47c54245c51c8f6756495233ba console/console.cpp 91be35bfb0f1ebf0950da0850426fcc7f45dd0db kcm/src/CMakeLists.txt 8c693b50ec04e3143735b8917aedc7e81d987fbd tests/kded/CMakeLists.txt 528eaa817980d0027c98441666b1a1ca5f56dbcb Diff: https://git.reviewboard.kde.org/r/122990/diff/ Testing --- Inspected source and checked library links. Builds and runs. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122653/ --- (Updated March 17, 2015, 4:49 p.m.) Review request for kdelibs, Plasma and Christoph Feck. Changes --- added plasma group, patch applies also to plasma-workspace Bugs: 339193 http://bugs.kde.org/show_bug.cgi?id=339193 Repository: kde-runtime Description --- KFileItem uses UDS_ACCESS to determine permissions. Readability is subsequently used to create the list of overlay icons. CCBUG: 339193 Diffs - kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661 Diff: https://git.reviewboard.kde.org/r/122653/diff/ Testing --- dolphin remote: - no lock icon on smb:, mtp:, ... links Thanks, Stefan Brüns ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
