Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 6 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 12:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. applets/minimizeall/plugin/minimizeall.cpp (line 44) https://git.reviewboard.kde.org/r/123653/#comment54839 this creates a copy of the list (it calls ::begin() instead of ::constBegin()). If you want a performant variant either create a temp variable: const auto stackingOrder = KWindowSystem::self()-stackingOrder(); for (auto wid: stackingOrder) or use Qt's foreach macro (which uses const iterators internally), or use a good old iterator based loop. - Martin Gräßlin On May 6, 2015, 2:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 2:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 6 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? Martin Gräßlin wrote: in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( Sebastian Kügler wrote: The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to). Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain. Kai Uwe Broulik wrote: The show desktop feature hides the panel. About which a lot of people complain. I haven't seen a statement from the UX group why it should hide them, other than that's what the Dashboard did. David Edmundson wrote: so what is the new show desktop for? Sebastian Kügler wrote: Yes, I haven't figured out that either. The missing panel during the show desktop effect removes the way to immediately reverse the action. Users are missing it, and that's understandable since the traditional behaviour of a feature changed. I haven't seen a rationale for hiding the panel either. new show desktop is used in place of the dashboard, i'll probably rename in the shell show dashboard with show desktop, that should make it more clear - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 12:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On Mai 6, 2015, 6 vorm., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On Mai 6, 2015, 12:16 vorm., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated Mai 6, 2015, 12:16 vorm.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 6 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? Martin Gräßlin wrote: in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( Sebastian Kügler wrote: The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to). Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain. Kai Uwe Broulik wrote: The show desktop feature hides the panel. About which a lot of people complain. I haven't seen a statement from the UX group why it should hide them, other than that's what the Dashboard did. David Edmundson wrote: so what is the new show desktop for? Yes, I haven't figured out that either. The missing panel during the show desktop effect removes the way to immediately reverse the action. Users are missing it, and that's understandable since the traditional behaviour of a feature changed. I haven't seen a rationale for hiding the panel either. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 12:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On Mai 6, 2015, 6 vorm., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? Martin Gräßlin wrote: in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( Sebastian Kügler wrote: The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to). Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain. The show desktop feature hides the panel. About which a lot of people complain. I haven't seen a statement from the UX group why it should hide them, other than that's what the Dashboard did. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On Mai 6, 2015, 12:16 vorm., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated Mai 6, 2015, 12:16 vorm.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 6 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? Martin Gräßlin wrote: in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( Sebastian Kügler wrote: The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to). Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain. Kai Uwe Broulik wrote: The show desktop feature hides the panel. About which a lot of people complain. I haven't seen a statement from the UX group why it should hide them, other than that's what the Dashboard did. so what is the new show desktop for? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 12:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 1:55 p.m., Martin Gräßlin wrote: applets/minimizeall/plugin/minimizeall.cpp, line 57 https://git.reviewboard.kde.org/r/123653/diff/2/?file=366858#file366858line57 suggestion: instead of reconnecting all the time: a QElapsedTimer to measure whether it's in the blocked interval. I would also consider to add more conditions to break out. E.g. activities, window added/window removed Rationale being here that we save a function call in most cases (namely when !m_active, performance win is probably negligible, but feels nicer. (I'm open to change it, just think that disconnecting and reconnecting is the cleaner thing to do here.) I'll add more reset conditions. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79970 --- On May 6, 2015, 1:20 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 1:20 p.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7ac applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79970 --- applets/minimizeall/plugin/minimizeall.cpp (line 57) https://git.reviewboard.kde.org/r/123653/#comment54854 suggestion: instead of reconnecting all the time: a QElapsedTimer to measure whether it's in the blocked interval. I would also consider to add more conditions to break out. E.g. activities, window added/window removed - Martin Gräßlin On May 6, 2015, 3:20 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 3:20 p.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7ac applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 2:35 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs (updated) - KF5PlasmaConfig.cmake.in dee79ca KF5PlasmaMacros.cmake 24bebb4 src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 6 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? Martin Gräßlin wrote: in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( The show desktop feature hides the panel. This breaks the workflow of people who use the panel to trigger and untrigger the effect. This plasmoid gives the old behaviour (which admittedly has its problems, but it's what many users are used to). Note: you are questioning the very reason to have this plasmoid. We know the feature can't be implemented perfectly, we just have to provide users a way to get the traditional behaviour. If we change this behaviour, this plasmoid becomes moot, and users are still left out in the rain. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 12:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 12:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
On May 6, 2015, 8 a.m., Martin Gräßlin wrote: From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again. Sebastian Kügler wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize. Kai Uwe Broulik wrote: That is kind of the point of this feature -- it allows to click twice to peek at the desktop. Well, that's what show desktop is for? in that case I fail to understand why you go that route. Why not just minimize and be done with it? The way it's currently is bringing back all the bugs from kwin of the last decade in that area without the fixes :-( - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- On May 6, 2015, 2:16 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 2:16 a.m.) Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs - applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123653: New Minimize Windows Plasmoid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated May 6, 2015, 1:20 p.m.) Review request for Plasma. Changes --- Use foreach to get the const_iterator. Bugs: 346837 http://bugs.kde.org/show_bug.cgi?id=346837 Repository: kdeplasma-addons Description --- New Minimize Windows Plasmoid This plasmoid allows to minimize windows on the current desktop. It does not mess with the KWindowSystem::showingDesktop flag, just allows to hide and show windows. Diffs (updated) - applets/CMakeLists.txt 7ada7ac applets/minimizeall/CMakeLists.txt PRE-CREATION applets/minimizeall/Messages.sh PRE-CREATION applets/minimizeall/package/contents/config/main.xml PRE-CREATION applets/minimizeall/package/contents/ui/main.qml PRE-CREATION applets/minimizeall/package/metadata.desktop PRE-CREATION applets/minimizeall/plugin/minimizeall.h PRE-CREATION applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION applets/minimizeall/plugin/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123653/diff/ Testing --- Used it for a while. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review7 --- Ship it! I've read and tested it, everything still works nicely. Good job! I like how the patch moves much of the query language into simple C++, avoids a lot of query parsing and moves some of the error paths to compile time. src/plasma/pluginloader.cpp https://git.reviewboard.kde.org/r/123626/#comment54873 Why did you remove this, seems unrelated? (I'd keep the sorting in, just to assure backwards compat.) src/plasma/pluginloader.cpp (line 730) https://git.reviewboard.kde.org/r/123626/#comment54874 Why? This remark makes it kinda magical and doesn't provide any other information than rather don't touch this which is counter-productive to actually fixing it. src/plasma/pluginloader.cpp (line 796) https://git.reviewboard.kde.org/r/123626/#comment54875 Can this lead to containmentactions being listed twice? (I haven't seen it in the UI, but seems plausible as a corner case.) src/plasma/private/applet_p.cpp (line 182) https://git.reviewboard.kde.org/r/123626/#comment54876 I think this may end up calling the non-const version, rather use foreach(const QString ..). src/plasma/private/applet_p.cpp (line 461) https://git.reviewboard.kde.org/r/123626/#comment54877 redundant. Forgot to delete a row? src/plasmapkg/plasmapkg.cpp (line 581) https://git.reviewboard.kde.org/r/123626/#comment54879 This can now be const - Sebastian Kügler On May 6, 2015, 5:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-) Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion... Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99). If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. Marco Martin wrote: the thing is the systray that would not show plasmoids anymore. all the rest should be 100% compatible. but yeah, we can leave the desktop files in kservices5 for the time being. we may eventually port the applets to a new install macro to have that file not installed Well, the .desktop files won't need to be installed anymore since we don't use them at runtime (the metadata is baked into the plugin), so we're in fact not breaking backwards compatibility, but we're reducing the installation footprint while keeping the functionality. I agree, though, for safety to keep them around for a bit and remove them from the install in a later release. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- On May 6, 2015, 5:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: I've read and tested it, everything still works nicely. Good job! I like how the patch moves much of the query language into simple C++, avoids a lot of query parsing and moves some of the error paths to compile time. https://git.reviewboard.kde.org/r/123669/ This moves the filtering by id, which is quite common, into KPluginLoader to save us a bit of churn. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review7 --- On May 6, 2015, 5:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123473: Port mouse theme kcm to QML
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79996 --- Wait, what happened to no regressions? Your combo box patch isn't released; and it still has a bug with backgrounds? - David Edmundson On May 6, 2015, 4:57 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated May 6, 2015, 4:57 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This is more an experiment on how much modules can be closely ported (and in how much time). the mouse theme kcm should be pretty much feature complete. the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate. all the other functions such as add/remove/ghns seems to work well Diffs - applets/icontasks/metadata.desktop f0b237c containments/folder/metadata.desktop a6d08a7 kcms/access/kcmaccess.desktop 825b6d7 kcms/baloo/kcm_baloofile.desktop 2eee6fc kcms/cursortheme/CMakeLists.txt 83f3ba2 kcms/cursortheme/Messages.sh 79450c7 kcms/cursortheme/cursortheme.desktop f443208 kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION kcms/cursortheme/kcmcursortheme.h d9e32b2 kcms/cursortheme/kcmcursortheme.cpp 44576ff kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION kcms/cursortheme/package/metadata.desktop PRE-CREATION kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 kcms/cursortheme/xcursor/itemdelegate.cpp e737005 kcms/cursortheme/xcursor/previewwidget.h 4a11e2d kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 kcms/cursortheme/xcursor/thememodel.h bcf046a kcms/cursortheme/xcursor/thememodel.cpp 4e4647f kcms/cursortheme/xcursor/themepage.h 98c69fd kcms/cursortheme/xcursor/themepage.cpp 687bd65 kcms/cursortheme/xcursor/themepage.ui 6efe60b kcms/desktoppaths/desktoppath.desktop eb2fad5 kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c kcms/lookandfeel/package/metadata.desktop 6595d6e kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 kcms/useraccount/kcm_useraccount.desktop 46ef110 layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 Diff: https://git.reviewboard.kde.org/r/123473/diff/ Testing --- File Attachments cursorskcm.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Reverting review 123473
We had an agreement that there would be no regressions when porting any KCMs to QML. The following regressions remain in the newly ported KCM: - combo boxes load in wrong places https://codereview.qt-project.org/#/c/111326/ isn't merged, and Qt 5.5 isn't a requirement for the Plasma 5.4 release. - combo boxes have wrong backgrounds - missing automatic accelerators (we need a QML version of the class in KXMLGui) I am happy to help work on those problems, but I am not happy about seeing decisions being willfully ignored. Tomorrow I will be reverting that commit. David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123664: Find DBusAddons component explicitly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/#review79995 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 6, 2015, 8:50 p.m., Matthias Klumpp wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/ --- (Updated May 6, 2015, 8:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This apparently causes trouble, since DBusAddons is required by e.g. appmenu, and not found in every environment. We stumbled upon this in Tanglu, where plasma-workspace failed to build. Relevant buildlog excerpts: ``` -- Configuring done CMake Warning (dev) at appmenu/CMakeLists.txt:24 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_appmenu links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at plasma-windowed/CMakeLists.txt:7 (add_executable): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target plasmawindowed links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at freespacenotifier/CMakeLists.txt:9 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_freespacenotifier links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. [...] ``` ``` [ 87%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o cd appmenu /usr/bin/c++ -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkded_appmenu_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I../../appmenu -I.. -isystem /usr/include/dbusmenu-qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -isystem /usr/include/x86_64-linux-gnu/qt5/QtX11Extras -isystem /usr/include/x86_64-l inux-gnu/qt5/QtGui -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5 -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KDELibs4Support -isystem /usr/include/KF5/KDELibs4Support/KDE -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs -I/usr/include/KF5/KConfigGui -I/usr/include/x86_64-linux-gnu/qt5/QtXml -I/usr/include/KF5/KAuth -isystem /usr/include/KF5/KIOFileWidgets -I/usr/include/KF5/KBookmarks -I/usr/include/KF5/KItemViews -I/usr/include/KF5/KXmlGui -I/usr/include/KF5/Solid -isystem / usr/include/KF5/KI18n -isystem /usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KUnitConversion -isystem /usr/include/KF5/KTextWidgets
Re: Review Request 123664: Find DBusAddons component explicitly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/ --- (Updated May 6, 2015, 9:47 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit e215432a039c3681d9246ce621f8f50382acc39a by Matthias Klumpp to branch master. Repository: plasma-workspace Description --- This apparently causes trouble, since DBusAddons is required by e.g. appmenu, and not found in every environment. We stumbled upon this in Tanglu, where plasma-workspace failed to build. Relevant buildlog excerpts: ``` -- Configuring done CMake Warning (dev) at appmenu/CMakeLists.txt:24 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_appmenu links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at plasma-windowed/CMakeLists.txt:7 (add_executable): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target plasmawindowed links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at freespacenotifier/CMakeLists.txt:9 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_freespacenotifier links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. [...] ``` ``` [ 87%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o cd appmenu /usr/bin/c++ -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkded_appmenu_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I../../appmenu -I.. -isystem /usr/include/dbusmenu-qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -isystem /usr/include/x86_64-linux-gnu/qt5/QtX11Extras -isystem /usr/include/x86_64-lin ux-gnu/qt5/QtGui -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5 -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KDELibs4Support -isystem /usr/include/KF5/KDELibs4Support/KDE -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs -I/usr/include/KF5/KConfigGui -I/usr/include/x86_64-linux-gnu/qt5/QtXml -I/usr/include/KF5/KAuth -isystem /usr/include/KF5/KIOFileWidgets -I/usr/include/KF5/KBookmarks -I/usr/include/KF5/KItemViews -I/usr/include/KF5/KXmlGui -I/usr/include/KF5/Solid -isystem /us r/include/KF5/KI18n -isystem /usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KUnitConversion -isystem /usr/include/KF5/KTextWidgets -I/usr/include/KF5/SonnetUi -isystem /usr/include/KF5/KParts-o CMakeFiles/kded_appmenu.dir/appmenu.cpp.o -c ../../appmenu/appmenu.cpp In file included from ../../appmenu/appmenu.cpp:26:0: ../../appmenu/appmenu.h:29:24: fatal error: kdedmodule.h:
Re: Review Request 123626: port libplasma away from sycoca as much as possible
On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-) Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion... Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99). If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. the thing is the systray that would not show plasmoids anymore. all the rest should be 100% compatible. but yeah, we can leave the desktop files in kservices5 for the time being. we may eventually port the applets to a new install macro to have that file not installed - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- On May 6, 2015, 5:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing (updated) --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123664: Find DBusAddons component explicitly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123664/ --- Review request for Plasma. Repository: plasma-workspace Description --- This apparently causes trouble, since DBusAddons is required by e.g. appmenu, and not found in every environment. We stumbled upon this in Tanglu, where plasma-workspace failed to build. Relevant buildlog excerpts: ``` -- Configuring done CMake Warning (dev) at appmenu/CMakeLists.txt:24 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_appmenu links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at plasma-windowed/CMakeLists.txt:7 (add_executable): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target plasmawindowed links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at freespacenotifier/CMakeLists.txt:9 (add_library): Policy CMP0028 is not set: Double colon in target name means ALIAS or IMPORTED target. Run cmake --help-policy CMP0028 for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target kded_freespacenotifier links to target KF5::DBusAddons but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? This warning is for project developers. Use -Wno-dev to suppress it. [...] ``` ``` [ 87%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o cd appmenu /usr/bin/c++ -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkded_appmenu_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -std=c++0x -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I../../appmenu -I.. -isystem /usr/include/dbusmenu-qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -isystem /usr/include/x86_64-linux-gnu/qt5/QtX11Extras -isystem /usr/include/x86_64-lin ux-gnu/qt5/QtGui -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5 -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5/KWindowSystem -isystem /usr/include/KF5/KDELibs4Support -isystem /usr/include/KF5/KDELibs4Support/KDE -isystem /usr/include/x86_64-linux-gnu/qt5/QtPrintSupport -isystem /usr/include/KF5/KCrash -isystem /usr/include/KF5/KConfigWidgets -I/usr/include/KF5/KCodecs -I/usr/include/KF5/KConfigGui -I/usr/include/x86_64-linux-gnu/qt5/QtXml -I/usr/include/KF5/KAuth -isystem /usr/include/KF5/KIOFileWidgets -I/usr/include/KF5/KBookmarks -I/usr/include/KF5/KItemViews -I/usr/include/KF5/KXmlGui -I/usr/include/KF5/Solid -isystem /us r/include/KF5/KI18n -isystem /usr/include/KF5/KNotifications -isystem /usr/include/KF5/KIconThemes -isystem /usr/include/KF5/KGuiAddons -isystem /usr/include/KF5/KUnitConversion -isystem /usr/include/KF5/KTextWidgets -I/usr/include/KF5/SonnetUi -isystem /usr/include/KF5/KParts-o CMakeFiles/kded_appmenu.dir/appmenu.cpp.o -c ../../appmenu/appmenu.cpp In file included from ../../appmenu/appmenu.cpp:26:0: ../../appmenu/appmenu.h:29:24: fatal error: kdedmodule.h: No such file or directory #include kdedmodule.h ^ compilation terminated. ``` See
Re: Review Request 123473: Port mouse theme kcm to QML
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated May 6, 2015, 4:57 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit f9fe76cbade454ea05b7975b401dd946610864b1 by Marco Martin to branch master. Repository: plasma-desktop Description --- This is more an experiment on how much modules can be closely ported (and in how much time). the mouse theme kcm should be pretty much feature complete. the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate. all the other functions such as add/remove/ghns seems to work well Diffs - applets/icontasks/metadata.desktop f0b237c containments/folder/metadata.desktop a6d08a7 kcms/access/kcmaccess.desktop 825b6d7 kcms/baloo/kcm_baloofile.desktop 2eee6fc kcms/cursortheme/CMakeLists.txt 83f3ba2 kcms/cursortheme/Messages.sh 79450c7 kcms/cursortheme/cursortheme.desktop f443208 kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION kcms/cursortheme/kcmcursortheme.h d9e32b2 kcms/cursortheme/kcmcursortheme.cpp 44576ff kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION kcms/cursortheme/package/metadata.desktop PRE-CREATION kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 kcms/cursortheme/xcursor/itemdelegate.cpp e737005 kcms/cursortheme/xcursor/previewwidget.h 4a11e2d kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 kcms/cursortheme/xcursor/thememodel.h bcf046a kcms/cursortheme/xcursor/thememodel.cpp 4e4647f kcms/cursortheme/xcursor/themepage.h 98c69fd kcms/cursortheme/xcursor/themepage.cpp 687bd65 kcms/cursortheme/xcursor/themepage.ui 6efe60b kcms/desktoppaths/desktoppath.desktop eb2fad5 kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85 kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c kcms/lookandfeel/package/metadata.desktop 6595d6e kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1 kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9 kcms/useraccount/kcm_useraccount.desktop 46ef110 layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3 Diff: https://git.reviewboard.kde.org/r/123473/diff/ Testing --- File Attachments cursorskcm.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:20 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs (updated) - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123626: port libplasma away from sycoca as much as possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- I would keep this for safety until Plasma 5.4 is released, then try to remove it again First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-) Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion... Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99). If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. - Hrvoje Senjan On May 6, 2015, 7:21 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 7:21 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache) a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well Diffs - KF5PlasmaConfig.cmake.in dee79ca src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 src/plasma/applet.cpp 2dda381 src/plasma/containment.cpp 7eabbb8 src/plasma/containmentactions.cpp f24bdac src/plasma/dataengine.cpp 4b3d671 src/plasma/package.cpp 4e0be88 src/plasma/packagestructure.cpp b2686b6 src/plasma/pluginloader.cpp 0ce349a src/plasma/private/applet_p.cpp 2cbfd06 src/plasma/private/dataenginemanager.cpp b9c5d8e src/plasma/scripting/appletscript.h 863d707 src/plasma/scripting/dataenginescript.h f7ad3c2 src/plasma/scripting/scriptengine.cpp cc407e7 src/plasma/service.h b5d9b5a src/plasma/service.cpp 3e9d852 src/plasmapkg/plasmapkg.cpp d606365 src/scriptengines/CMakeLists.txt f566406 src/scriptengines/qml/CMakeLists.txt e7130db src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 Diff: https://git.reviewboard.kde.org/r/123626/diff/ Testing --- still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
