Minutes Monday Plasma Hangout

2015-07-13 Thread Sebastian Kügler
Present: Alex F, David E, Jonathan R, Kai Uwe B, Marco M, Martin G, Martin K, 
Sebastian K, Jens R

Date: 13 July, 2015

Next week: no hangout on Monday, but on Tuesday due to public holiday in 
relevant regions

David:
- peculiar crasher in QGLContext::create()

Kai Uwe
- various fixes all over the place
- spotted and investigated shared engine bugs (#349052 and #350157)
- merged Martin G's powerdevil patches
- pung some Qt peeps about https://codereview.qt-project.org/#/c/113758/ 
and https://codereview.qt-project.org/#/c/111326/

Marco
- issue with shared engine and pragma library

Martin G:
- has Plasma Wayland session running, patches on reviewboard
- Finished kwayland integration plugin

People not mentioned don't have anything relevant to report.


-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Minutes Monday Plasma Hangout

2015-07-13 Thread Sebastian Kügler
On Monday, July 13, 2015 10:32:42 Sebastian Kügler wrote:
 Next week: no hangout on Monday, but on Tuesday due to public holiday in 
 relevant regions

Forget this line, it's an error.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 124340: Use plasma icon for update notifier

2015-07-13 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124340/
---

Review request for Plasma and KDE Usability.


Repository: muon


Description
---

This makes it use the Plasma theme's icon for the updater.


Diffs
-

  notifier/MuonNotifier.cpp e3ca913 
  notifier/plasmoid/contents/ui/main.qml 5e32b24 

Diff: https://git.reviewboard.kde.org/r/124340/diff/


Testing
---

Works. I'm not too happy with the icons, though, perhaps VDG should improve 
them a bit.

The no updates icon isn't really recognizable and looks similar to the 
notification icon above it. The there are updates icon looks sort of okay, 
the security updates icon should perhaps be red/orange so it stands out. 
There's also a dedicated security updates icon but it has a padlock in it and 
looks like something has to be unlocked rather than about updates.


File Attachments


No updates
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/024917b4-d9ab-4584-bc3a-333d2d47487b__updates-none.png
Updates available
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/99678ec4-ebb9-49de-93e0-fdb990660fd9__updates-some.png
Security updates
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/8f641ed9-0012-4384-b3c6-9ac7ea6a1b7e__updates-important.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 124339: Don't store state in the LayoutManager.js

2015-07-13 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124339/
---

Review request for Plasma.


Bugs: 350157
https://bugs.kde.org/show_bug.cgi?id=350157


Repository: plasma-desktop


Description
---

It breaks with our shared engine approach. I'm not really happy with this, it 
feels a bit like writing C code. Another approach would be to kill the layout 
manager and dump its functions into the main.qml


Diffs
-

  containments/panel/contents/code/LayoutManager.js fed32be 
  containments/panel/contents/ui/ConfigOverlay.qml a89a5fe 
  containments/panel/contents/ui/main.qml 1ed0dc2 

Diff: https://git.reviewboard.kde.org/r/124339/diff/


Testing
---

Added another panel, played around with it a bit, unlocked and locked widgets, 
seems to work. I will make a patch for Desktop containment too.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124339: Don't store state in the LayoutManager.js

2015-07-13 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124339/
---

(Updated Juli 13, 2015, 5:57 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Bugs: 350157
https://bugs.kde.org/show_bug.cgi?id=350157


Repository: plasma-desktop


Description
---

It breaks with our shared engine approach. I'm not really happy with this, it 
feels a bit like writing C code. Another approach would be to kill the layout 
manager and dump its functions into the main.qml


Diffs
-

  containments/panel/contents/code/LayoutManager.js fed32be 
  containments/panel/contents/ui/ConfigOverlay.qml a89a5fe 
  containments/panel/contents/ui/main.qml 1ed0dc2 

Diff: https://git.reviewboard.kde.org/r/124339/diff/


Testing
---

Added another panel, played around with it a bit, unlocked and locked widgets, 
seems to work. I will make a patch for Desktop containment too.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 124342: Show plasmoid / application icon in systray entries config

2015-07-13 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124342/
---

Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

This makes the list significantly easier to scan for the applet you're looking 
for.


Diffs
-

  applets/systemtray/package/contents/ui/ConfigEntries.qml 98d8554 
  applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h 
ea1703c 
  applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp fb077c4 

Diff: https://git.reviewboard.kde.org/r/124342/diff/


Testing
---

It uses the icon name or falls back to the actual icon used (eg. kmail), 
restores 4.x behavior


File Attachments


List with icons
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/c00a96cc-a04d-45cd-955e-eb0ade6febe4__entryicons.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 102983: Added support for rfkill

2015-07-13 Thread Rüdiger Sonderfeld

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102983/
---

(Updated jul. 13, 2015, 9:35 p.m.)


Status
--

This change has been discarded.


Review request for Plasma and Solid.


Repository: libbluedevil


Description
---

rfkill is a subsystem of the Linux Kernel to disable radio transmitters 
(including Bluetooth). This patch adds support for rfkill to libbluedevil. An 
interface is added to the Manager class.

rfkill support is important because gnome uses rfkill to deactivate bluetooth. 
Therefore if bluetooth is currently disabled in the gnome-control-center it can 
not be used by kde. With this patch the proper API to reenable bluetooth is 
provided.

Disabling bluetooth with rfkill has the advantage that some computers switch 
off the bluetooth LED. Which does not happen (at least on my Thinkpad) if it's 
just powered off (as kde does at the moment).

rfkill can also detect if bluetooth has been deactivated by a hardware switch.

btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete 
and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used the 
old gitorious code base at first.


Diffs
-

  bluedevil/bluedevilmanager.h 0386b8e 
  bluedevil/bluedevilmanager.cpp 594d3bd 
  bluedevil/test/bluedeviltest.cpp 2d3d0e2 

Diff: https://git.reviewboard.kde.org/r/102983/diff/


Testing
---

I added a test to bluedeviltest and it works for me.


Thanks,

Rüdiger Sonderfeld

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124342: Show plasmoid / application icon in systray entries config

2015-07-13 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124342/#review82476
---


+about1000

- Martin Klapetek


On July 13, 2015, 10:01 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124342/
 ---
 
 (Updated July 13, 2015, 10:01 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 This makes the list significantly easier to scan for the applet you're 
 looking for.
 
 
 Diffs
 -
 
   applets/systemtray/package/contents/ui/ConfigEntries.qml 98d8554 
   applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h 
 ea1703c 
   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp fb077c4 
 
 Diff: https://git.reviewboard.kde.org/r/124342/diff/
 
 
 Testing
 ---
 
 It uses the icon name or falls back to the actual icon used (eg. kmail), 
 restores 4.x behavior
 
 
 File Attachments
 
 
 List with icons
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/c00a96cc-a04d-45cd-955e-eb0ade6febe4__entryicons.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel