[Powerdevil] [Bug 354623] Full charge not trigger notification

[Anthony via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354623

--- Comment #4 from Anthony  ---
(In reply to Kai Uwe Broulik from comment #3)
> Also, please check the output of upower -d to ensure the driver actually
> reports "fully charged" state

Yes, 'upower -d' reports "fully charged".

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125888: systemmonitor: Don't link to unused libraries

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125888/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

^summary


Diffs
-

  systemmonitor/CMakeLists.txt ecfdfbd 

Diff: https://git.reviewboard.kde.org/r/125888/diff/


Testing
---

Builds


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125886: drkonqi: Drop KF5::WebKit dependency

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125886/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display HTML with 
setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are 
not resolved.
Replacing it with QTextBrowser should provide similar rendering.


Diffs
-

  CMakeLists.txt 50091ea 
  drkonqi/CMakeLists.txt 339b475 
  drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3 

Diff: https://git.reviewboard.kde.org/r/125886/diff/


Testing
---

Made sure it builds, no idea how to trigger the dialog.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125887/
---

Review request for Plasma.


Repository: libksysguard


Description
---

When building without QtWebKitWidgets, the Detailed Memory Information dialog 
is not working (will not be opened at all).
This makes plasma-workspace build without QtWebKitWidgets as it requires 
KSysGuardProcessList from ProcessUI.


Diffs
-

  CMakeLists.txt 14d32d9 
  config-ksysguard.h.cmake d95e1f5 
  processui/CMakeLists.txt 7f87b85 
  processui/scripting.h e8b1e3b 
  processui/scripting.cpp adcb354 

Diff: https://git.reviewboard.kde.org/r/125887/diff/


Testing
---

Builds, clicking on Detailed Memory Information from context menu just does 
nothing.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125889: Take QApplication::wheelScrollLines into account from ScrollView

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125889/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This is adaptation of https://codereview.qt-project.org/#/c/109615/ for Plasma 
style.


Diffs
-

  src/declarativeimports/plasmastyle/ScrollViewStyle.qml 7dd55cb 

Diff: https://git.reviewboard.kde.org/r/125889/diff/


Testing
---

Scroll speed is now scaled to WheelScrollLines settings.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/
---

Review request for Plasma, David Edmundson and Martin Gräßlin.


Repository: plasma-workspace


Description
---

To split libksld it is required that it no longer depends upon ksmserver being 
parent dir.


Diffs
-

  ksmserver/config-ksmserver.h.cmake f24e62d 
  ksmserver/screenlocker/CMakeLists.txt 4213713 
  ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
  ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
  ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
  ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
  ksmserver/screenlocker/waylandserver.cpp f8ef665 
  ksmserver/screenlocker/ksldapp.cpp f062082 
  ksmserver/screenlocker/kcm/kcm.cpp 751b566 
  ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 

Diff: https://git.reviewboard.kde.org/r/125892/diff/


Testing
---

builds, installs, tests pass


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125888: systemmonitor: Don't link to unused libraries

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125888/#review87775
---

Ship it!


Ship It!

- David Edmundson


On Oct. 31, 2015, 10:54 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125888/
> ---
> 
> (Updated Oct. 31, 2015, 10:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^summary
> 
> 
> Diffs
> -
> 
>   systemmonitor/CMakeLists.txt ecfdfbd 
> 
> Diff: https://git.reviewboard.kde.org/r/125888/diff/
> 
> 
> Testing
> ---
> 
> Builds
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/
---

(Updated Oct. 31, 2015, 6:11 p.m.)


Review request for Plasma, David Edmundson and Martin Gräßlin.


Repository: plasma-workspace


Description (updated)
---

To split libksld it is required that it no longer depends upon ksmserver being 
parent dir.

I am just unsure about removal of,

set(ksmserver_xml  
${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
and
qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)


Diffs
-

  ksmserver/config-ksmserver.h.cmake f24e62d 
  ksmserver/screenlocker/CMakeLists.txt 4213713 
  ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
  ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
  ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
  ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
  ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
  ksmserver/screenlocker/waylandserver.cpp f8ef665 
  ksmserver/screenlocker/ksldapp.cpp f062082 
  ksmserver/screenlocker/kcm/kcm.cpp 751b566 
  ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
  ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 

Diff: https://git.reviewboard.kde.org/r/125892/diff/


Testing
---

builds, installs, tests pass


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125817: Add plugin system for Calendar events

[David Edmundson]

> On Oct. 31, 2015, 1:08 a.m., David Edmundson wrote:
> > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h,
> >  line 173
> > 
> >
> > Unless needed otherwise, I'd put the UID in the constructor.
> > 
> > If a plugin uses this, you screw everything up
> 
> Martin Klapetek wrote:
> > If a plugin uses this, you screw everything up
> 
> I don't follow. Note that uid is not a mandatory property. You can have 
> events without uid. As the comment above it says, it's useful only if you 
> want to implement eventModified/eventRemoved (so that it can locate the 
> events in the model), which in case of eg. holidays is not needed, cause they 
> are not going to be modified/removed. So there's no need to make those 
> plugins more complex for no reason.

ah, ignore this then.


> On Oct. 31, 2015, 1:08 a.m., David Edmundson wrote:
> > src/declarativeimports/calendar/daysmodel.h, line 44
> > 
> >
> > I think we need some sort of
> > 
> > QStringList availablePlugins()
> > 
> > setPlugins( QStringList plugins);
> 
> Martin Klapetek wrote:
> What for?

Plasma 4 had an option to "show events". mostly people complaining about 
akonadi starting up when they didn't actually use korganiser


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125817/#review87768
---


On Oct. 28, 2015, 5:18 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125817/
> ---
> 
> (Updated Oct. 28, 2015, 5:18 p.m.)
> 
> 
> Review request for Plasma and Daniel Vrátil.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This adds a simple plugin interface that can be subclassed
> and provide events integration with Plasma Calendar applet.
> 
> It's asynchronous and I've kept it deliberately simple.
> For now the Calendar tells the plugins which date range
> is being displayed, the plugins load the data and then
> emit the dataReady() signal containing the events.
> 
> The events are stored in a multihash for quick access
> by the Calendar's agenda part but also for overall
> easy-to-use (eg. in teh model data()).
> 
> The event data is stored in EventData class, which has
> a pretty self-explanatory members, except perhaps the
> "isMinor" one. The intention with this is to support
> namedays, where in some countries the calendars have
> different name every day. This is just a minor holiday
> and as such should not mark the calendar grid, otherwise
> the whole grid would be in a different color.
> 
> Putting the interface here might raise the question of
> depending on plasma-framework, but plugins provided by
> KDE can go to plasma-workspace and other 3rd party ones
> would just have to live with it. I don't think it will
> be a problem but if it turns out it is, we can rethink
> the placement.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/CMakeLists.txt 40ead91 
>   src/declarativeimports/calendar/calendarplugin.cpp bafe80c 
>   src/declarativeimports/calendar/daysmodel.h a5bdac9 
>   src/declarativeimports/calendar/daysmodel.cpp 2d059a8 
>   src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION 
>   src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h
>  PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp
>  PRE-CREATION 
>   src/declarativeimports/calendar/plasmacalendarintegration/eventdata_p.cpp 
> PRE-CREATION 
>   
> src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h
>  PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125817/diff/
> 
> 
> Testing
> ---
> 
> I have a simple KHolidays based plugin written (patch should be up later 
> today)
> and patches in the Calendar applet.
> 
> Everything works as expected:
> * the days are marked as containing an event
> * the agenda part displays details of that event (name)
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/
---

(Updated Okt. 31, 2015, 5:21 nachm.)


Review request for Plasma, KDE Usability and Martin Gräßlin.


Changes
---

Fix hovering file thumbnails


Bugs: 354602
https://bugs.kde.org/show_bug.cgi?id=354602


Repository: plasma-workspace


Description
---

This avoids the buttons from blending in with the text making it look ugly.

This could allow us to use flat ToolButtons again since four round things in a 
row look strange imho.


Diffs (updated)
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 

Diff: https://git.reviewboard.kde.org/r/125898/diff/


Testing
---

Works


File Attachments


Hovered item
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/#review87783
---


All fine from the usability side, looks much better now!

- Thomas Pfeiffer


On Oct. 31, 2015, 5:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125898/
> ---
> 
> (Updated Oct. 31, 2015, 5:21 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 354602
> https://bugs.kde.org/show_bug.cgi?id=354602
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This avoids the buttons from blending in with the text making it look ugly.
> 
> This could allow us to use flat ToolButtons again since four round things in 
> a row look strange imho.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 
> 
> Diff: https://git.reviewboard.kde.org/r/125898/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Hovered item
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125897: [Clipboard plasmoid] Fix line breaks

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125897/#review87786
---


Showing the whitespaces only for the first line does not make much sense to me, 
as that would bring back the original problem fixed by the highlighting (that 
what gets pasted in is not the same as what you saw in the preview).
Therefore it should show the whitespaces for all lines.

- Thomas Pfeiffer


On Oct. 31, 2015, 4:47 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125897/
> ---
> 
> (Updated Oct. 31, 2015, 4:47 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This fixes the list only showing one line of text instead of the supposed 
> maximum of 3 lines.
> 
> I'm unsure about the "m" modifier, however. With it, it highlights leading 
> and trailing whitespace on any line which can be nice but also somewhat 
> distracting depending on what you copied. On the other hand, only doing it 
> for the first line (as is now but wasnt apparent because we only showed one 
> line) is also strange. Especially when you use spaces rather than line breaks 
> you can get quite a few "space" indicators.. (I can split the patch though, 
> broken multiline display is definitely a bug)
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 
> 
> Diff: https://git.reviewboard.kde.org/r/125897/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> With multiline modifier
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png
> Without (currently)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[Kai Uwe Broulik]

> On Okt. 31, 2015, 3:39 nachm., Kai Uwe Broulik wrote:
> > I'm not sure, perhaps add Usability.
> > One thing I would like, though, is the entire header area being scrollable 
> > rather than the width-changing label.
> > Also please make sure it doesn't break the MultiPointTouchArea.
> 
> David Rosca wrote:
> I got used to this behavior from Plasma 4.
> 
> > One thing I would like, though, is the entire header area being 
> scrollable rather than the width-changing label.
> 
> also click the entire header to go up in stack would be good.
> 
> > Also please make sure it doesn't break the MultiPointTouchArea.
> 
> I have no idea what that is, only thing I found is PinchArea in 
> MonthView.qml. But the new MouseArea is not accepting any buttons (just wheel 
> events) so that should not be a problem?

Ok I just tried it and indeed being able to scroll the entire area makes it 
much more comfortable to use. +1 from me.

Yeah, I meant PinchArea, should be fine.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review8
---


On Okt. 31, 2015, 4:21 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> ---
> 
> (Updated Okt. 31, 2015, 4:21 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review87784
---


Thanks for adding usability!
I agree with Kai that the whole header area should be scrollable instead of 
just the label.
One thing to make sure (if that is even affected by this change at all) is that 
when we have events in the poup, scrolling over the even description won't 
change the month.

Other than that, +1 for the change!

- Thomas Pfeiffer


On Oct. 31, 2015, 4:21 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> ---
> 
> (Updated Oct. 31, 2015, 4:21 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354623] Full charge not trigger notification

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354623

Martin Klapetek  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||mklape...@kde.org
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Martin Klapetek  ---
Confirming, I've set a sound and didn't hear one when it was charged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125895/
---

(Updated Oct. 31, 2015, 3:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit e3ed62cf9f44fb16adb7bfe8e347472757e2ae18 by Kai Uwe 
Broulik to branch Plasma/5.4.


Repository: plasma-sdk


Description
---

Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer 
to crash


Diffs
-

  engineexplorer/engineexplorer.cpp 31525ee 

Diff: https://git.reviewboard.kde.org/r/125895/diff/


Testing
---

Doesn't crash anymore


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125893: calendar: Fix updating decade overview

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125893/#review87778
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Okt. 31, 2015, 2:59 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125893/
> ---
> 
> (Updated Okt. 31, 2015, 2:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Always update model when switching to decade overview.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/MonthView.qml f698934 
> 
> Diff: https://git.reviewboard.kde.org/r/125893/diff/
> 
> 
> Testing
> ---
> 
> 1. Opened calendar popup in digital clock, navigated to decade overview, 
> switched to another decade, closed popup.
> 2. Opened popup and navigated to decade overivew again and it now shows 
> correct decade, instead of the one left from step 1.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review8
---


I'm not sure, perhaps add Usability.
One thing I would like, though, is the entire header area being scrollable 
rather than the width-changing label.
Also please make sure it doesn't break the MultiPointTouchArea.

- Kai Uwe Broulik


On Okt. 31, 2015, 2:59 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> ---
> 
> (Updated Okt. 31, 2015, 2:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[David Rosca]

> On Oct. 31, 2015, 3:39 p.m., Kai Uwe Broulik wrote:
> > I'm not sure, perhaps add Usability.
> > One thing I would like, though, is the entire header area being scrollable 
> > rather than the width-changing label.
> > Also please make sure it doesn't break the MultiPointTouchArea.

I got used to this behavior from Plasma 4.

> One thing I would like, though, is the entire header area being scrollable 
> rather than the width-changing label.

also click the entire header to go up in stack would be good.

> Also please make sure it doesn't break the MultiPointTouchArea.

I have no idea what that is, only thing I found is PinchArea in MonthView.qml. 
But the new MouseArea is not accepting any buttons (just wheel events) so that 
should not be a problem?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review8
---


On Oct. 31, 2015, 2:59 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> ---
> 
> (Updated Oct. 31, 2015, 2:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125897: [Clipboard plasmoid] Fix line breaks

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125897/
---

Review request for Plasma, KDE Usability and Martin Gräßlin.


Repository: plasma-workspace


Description
---

This fixes the list only showing one line of text instead of the supposed 
maximum of 3 lines.

I'm unsure about the "m" modifier, however. With it, it highlights leading and 
trailing whitespace on any line which can be nice but also somewhat distracting 
depending on what you copied. On the other hand, only doing it for the first 
line (as is now but wasnt apparent because we only showed one line) is also 
strange. Especially when you use spaces rather than line breaks you can get 
quite a few "space" indicators.. (I can split the patch though, broken 
multiline display is definitely a bug)


Diffs
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 

Diff: https://git.reviewboard.kde.org/r/125897/diff/


Testing
---

Works


File Attachments


With multiline modifier
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png
Without (currently)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[David Rosca]

> On Oct. 31, 2015, 5:33 p.m., Thomas Pfeiffer wrote:
> > Thanks for adding usability!
> > I agree with Kai that the whole header area should be scrollable instead of 
> > just the label.
> > One thing to make sure (if that is even affected by this change at all) is 
> > that when we have events in the poup, scrolling over the even description 
> > won't change the month.
> > 
> > Other than that, +1 for the change!

This change makes the entire component (header + calendar view) scrollable.

> scrolling over the event description won't change the month.

Of course, but the code isn't there yet (at least I can't find it :).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review87784
---


On Oct. 31, 2015, 4:21 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> ---
> 
> (Updated Oct. 31, 2015, 4:21 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125899: calendar: Make the entire header area clickable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125899/
---

Review request for Plasma and KDE Usability.


Repository: plasma-framework


Description
---

As suggested in https://git.reviewboard.kde.org/r/125891/, this makes the 
entire header area clickable (not just the header label).


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 

Diff: https://git.reviewboard.kde.org/r/125899/diff/


Testing
---

Clicked next to the header, got to the year overview.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125899: calendar: Make the entire header area clickable

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125899/#review87788
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Okt. 31, 2015, 8:11 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125899/
> ---
> 
> (Updated Okt. 31, 2015, 8:11 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> As suggested in https://git.reviewboard.kde.org/r/125891/, this makes the 
> entire header area clickable (not just the header label).
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125899/diff/
> 
> 
> Testing
> ---
> 
> Clicked next to the header, got to the year overview.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125896: [desktopcontainment] Clip applet container while resizing it

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125896/#review87789
---

Ship it!


Ship It!

- Eike Hein


On Oct. 31, 2015, 4:05 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125896/
> ---
> 
> (Updated Oct. 31, 2015, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When dragging the applet it takes a while for it to collapse sometimes 
> causing applet contents to spill out its boundaries (notably battery monitor 
> or sticky notes).
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/AppletHandle.qml a432057 
> 
> Diff: https://git.reviewboard.kde.org/r/125896/diff/
> 
> 
> Testing
> ---
> 
> No more applet content outside when resizing like a normal person.
> 
> You can briefly see contents reappearing when resizing the widget small and 
> then immediately, before it loaded the compact rep, releasing the mouse, but 
> whatever.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125893: calendar: Fix updating decade overview

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125893/
---

(Updated Oct. 31, 2015, 9:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1e867f276b3551f69e56cf0ba46a25cac4ead113 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

Always update model when switching to decade overview.


Diffs
-

  src/declarativeimports/calendar/qml/MonthView.qml f698934 

Diff: https://git.reviewboard.kde.org/r/125893/diff/


Testing
---

1. Opened calendar popup in digital clock, navigated to decade overview, 
switched to another decade, closed popup.
2. Opened popup and navigated to decade overivew again and it now shows correct 
decade, instead of the one left from step 1.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125894: calendar: Don't use current day number in goToMonth

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125894/
---

(Updated Oct. 31, 2015, 9:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 2ca48a7d2d841929f2e1855a4cdb52b5e4376ca0 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

Fix goToMonth when that month does not have current day number (eg. today = 31).


Diffs
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125894/diff/


Testing
---

Calendar now works today.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125899: calendar: Make the entire header area clickable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125899/
---

(Updated Oct. 31, 2015, 9:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 5dc3f0ac7f0e3417e32d2b2babe1bd0a456dd739 by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

As suggested in https://git.reviewboard.kde.org/r/125891/, this makes the 
entire header area clickable (not just the header label).


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 

Diff: https://git.reviewboard.kde.org/r/125899/diff/


Testing
---

Clicked next to the header, got to the year overview.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125888: systemmonitor: Don't link to unused libraries

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125888/
---

(Updated Oct. 31, 2015, 9:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 87029dd53d20edb066fbdbf9e7f8e435d87f17a4 by David Rosca 
to branch master.


Repository: plasma-workspace


Description
---

^summary


Diffs
-

  systemmonitor/CMakeLists.txt ecfdfbd 

Diff: https://git.reviewboard.kde.org/r/125888/diff/


Testing
---

Builds


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125678: Introduce User Switcher plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125678/
---

(Updated Oct. 31, 2015, 1:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 01824730acc49aea50bc0d0da1eb17b270125458 by Kai Uwe 
Broulik to branch master.


Repository: kdeplasma-addons


Description
---

It is prety common in other desktop environments to have something that allows 
switching between users and logout/shutdown quickly. It is inspired by the Fast 
User Switch plasmoid from kde-apps.org [1]

[1] http://kde-apps.org/content/show.php?content=127462


Diffs
-

  applets/CMakeLists.txt 4079726 
  applets/userswitcher/CMakeLists.txt PRE-CREATION 
  applets/userswitcher/Messages.sh PRE-CREATION 
  applets/userswitcher/package/contents/config/config.qml PRE-CREATION 
  applets/userswitcher/package/contents/config/main.xml PRE-CREATION 
  applets/userswitcher/package/contents/ui/ListDelegate.qml PRE-CREATION 
  applets/userswitcher/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/userswitcher/package/contents/ui/main.qml PRE-CREATION 
  applets/userswitcher/package/metadata.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125678/diff/


Testing
---

When the applet opens, it updates. It grows a maximum of half the screen 
height, should there be more users currently logged in, the list can be 
scrolled. Switching users works, both with and without locking the screen, 
depending on user's settings. Opening new sessions, locking the screen and 
shutting down also work.

The applet doesn't have any settings, the label probably needs tweaking so its 
sizing policy is similar to the digital clock so the two look reasonable next 
to each other.


File Attachments


Plasmoid in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/17/05d93363-9b15-4c77-abe0-6f8ed9b3cab7__userswitcherplasmoid3.png
Applet in larger panel and desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/49290a8d-8ce3-4ab4-89a8-76990ca73084__userswitcherplasmoid4.png
Applet settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/19/704a5450-2aa9-4250-92a8-6deed29ac859__userswitcherplasmoid5.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125891: calendar: Allow to scroll navigate in the entire DaysCalendar component

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Allow to scroll navigate back/forward in DaysCalendar in the entire 
DaysCalendar component, not just on header label.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 

Diff: https://git.reviewboard.kde.org/r/125891/diff/


Testing
---


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125894: calendar: Don't use current day number in goToMonth

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125894/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Fix goToMonth when that month does not have current day number (eg. today = 31).


Diffs
-

  src/declarativeimports/calendar/calendar.cpp 67a08e5 

Diff: https://git.reviewboard.kde.org/r/125894/diff/


Testing
---

Calendar now works today.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125893: calendar: Fix updating decade overview

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125893/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Always update model when switching to decade overview.


Diffs
-

  src/declarativeimports/calendar/qml/MonthView.qml f698934 

Diff: https://git.reviewboard.kde.org/r/125893/diff/


Testing
---

1. Opened calendar popup in digital clock, navigated to decade overview, 
switched to another decade, closed popup.
2. Opened popup and navigated to decade overivew again and it now shows correct 
decade, instead of the one left from step 1.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125895/
---

(Updated Okt. 31, 2015, 3:25 nachm.)


Review request for Plasma.


Changes
---

Fall back to plasma icon/title instead of leaving the previous one there


Repository: plasma-sdk


Description
---

Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer 
to crash


Diffs (updated)
-

  engineexplorer/engineexplorer.cpp 31525ee 

Diff: https://git.reviewboard.kde.org/r/125895/diff/


Testing
---

Doesn't crash anymore


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125896: [desktopcontainment] Clip applet container while resizing it

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125896/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

When dragging the applet it takes a while for it to collapse sometimes causing 
applet contents to spill out its boundaries (notably battery monitor or sticky 
notes).


Diffs
-

  containments/desktop/package/contents/ui/AppletHandle.qml a432057 

Diff: https://git.reviewboard.kde.org/r/125896/diff/


Testing
---

No more applet content outside when resizing like a normal person.

You can briefly see contents reappearing when resizing the widget small and 
then immediately, before it loaded the compact rep, releasing the mouse, but 
whatever.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125849: [kscreenlocker_greet] Port fallback theme to SessionsModel

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125849/
---

(Updated Oct. 31, 2015, 2:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 0ff4006610f960b21cd81d6361ffc27ac0c5708d by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

Required for removing the sessions stuff and thus the KWorkspace dependency.


Diffs
-

  ksmserver/screenlocker/greeter/fallbacktheme/Greeter.qml fac9cf9 
  ksmserver/screenlocker/greeter/fallbacktheme/LockScreen.qml 1d958c3 
  ksmserver/screenlocker/greeter/fallbacktheme/SessionSwitching.qml b429bb3 

Diff: https://git.reviewboard.kde.org/r/125849/diff/


Testing
---

Switching sessions and creating new ones works


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354623] Full charge not trigger notification

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354623

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
Created attachment 95236
  --> https://bugs.kde.org/attachment.cgi?id=95236=edit
Use FullyCharged instead of NoCharge

Can you try this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354623] Full charge not trigger notification

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354623

--- Comment #3 from Kai Uwe Broulik  ---
Also, please check the output of upower -d to ensure the driver actually
reports "fully charged" state

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125895/
---

Review request for Plasma.


Repository: plasma-sdk


Description
---

Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer 
to crash


Diffs
-

  engineexplorer/engineexplorer.cpp 31525ee 

Diff: https://git.reviewboard.kde.org/r/125895/diff/


Testing
---

Doesn't crash anymore


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125895: [plasmaengineexplorer] Don't crash on invalid plugininfo

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125895/#review87776
---

Ship it!


- David Edmundson


On Oct. 31, 2015, 3:25 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125895/
> ---
> 
> (Updated Oct. 31, 2015, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> Some engines (eg. mpris) have invalid plugininfo causing plasmaengineexplorer 
> to crash
> 
> 
> Diffs
> -
> 
>   engineexplorer/engineexplorer.cpp 31525ee 
> 
> Diff: https://git.reviewboard.kde.org/r/125895/diff/
> 
> 
> Testing
> ---
> 
> Doesn't crash anymore
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125894: calendar: Don't use current day number in goToMonth

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125894/#review87779
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Okt. 31, 2015, 2:59 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125894/
> ---
> 
> (Updated Okt. 31, 2015, 2:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix goToMonth when that month does not have current day number (eg. today = 
> 31).
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125894/diff/
> 
> 
> Testing
> ---
> 
> Calendar now works today.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/
---

(Updated Okt. 31, 2015, 4:51 nachm.)


Review request for Plasma, KDE Usability and Martin Gräßlin.


Bugs: 354602
https://bugs.kde.org/show_bug.cgi?id=354602


Repository: plasma-workspace


Description (updated)
---

This avoids the buttons from blending in with the text making it look ugly.

This could allow us to use flat ToolButtons again since four round things in a 
row look strange imho.


Diffs
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 

Diff: https://git.reviewboard.kde.org/r/125898/diff/


Testing
---

Works


File Attachments


Hovered item
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125898/
---

Review request for Plasma, KDE Usability and Martin Gräßlin.


Bugs: 354602
https://bugs.kde.org/show_bug.cgi?id=354602


Repository: plasma-workspace


Description
---

This avoids the buttons from blending in with the text making it look ugly.


Diffs
-

  applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 

Diff: https://git.reviewboard.kde.org/r/125898/diff/


Testing
---

Works


File Attachments


Hovered item
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/b4fb7d52-90fe-4954-a1c0-462a86c31f4a__klipperlinebreaks3.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel