Re: Review Request 126443: Fix memleak in Plasma framework's PackageUrlInterceptor

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126443/#review89801
---

Ship it!


Ship It!

- David Edmundson


On Dec. 21, 2015, 3:08 a.m., Michael Pyne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126443/
> ---
> 
> (Updated Dec. 21, 2015, 3:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fixes a minor memleak in PackageUrlInterceptor (noted by Coverity, CID 
> #1332370), by deleting d-ptr in existing destructor.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/packageurlinterceptor.cpp e49fc35 
> 
> Diff: https://git.reviewboard.kde.org/r/126443/diff/
> 
> 
> Testing
> ---
> 
> Still builds.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Eike Hein]

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.
> 
> Uri Herrera wrote:
> The margins are not random. I literally had to use kruler and kmag to 
> properly align that. I even used a layered file with a red rectangle in it 
> because that area consists of a deadzone. I pointed that out when I made the 
> reveiw request originally.
> 
> Eike Hein wrote:
> The inside margins are currently inconsistent at the top and bottom 
> causing the icon to be vertically misaligned. The outside margins are 
> inconsistent as well - I think it's trying to position the button well inside 
> the panel, but this is an incorrect approach to the problem (the optical 
> imbalance with consistent margins is caused by how the panel inside margins 
> function, which is something we need to address in the theming system - my 
> approach to fix it was rejected, I'll be trying again though). The outside 
> margins and the corners (top ones rounded, bottom ones not) subtly break 
> things when the panel is anywhere but the bottom.
> 
> I'm working on a series of changes to make the panel and Task Manager 
> finally pixel-perfect - fix the theme, fix the panel controller when 
> resizing, fix the panel default size, and fix something in FrameSVG/the panel 
> containment.
> 
> Johan Ouwerkerk wrote:
> In any case, the top version (new draft?) has markedly better alignment 
> of the text with icons... The other two versions seem vertically imbalanced 
> (more margin on the bottom than at the top).
> Ideally, the icon is vertically aligned with the baseline of the text 
> such that ascenders and descenders extend equally far beyond the 
> corresponding border of the icon, hough this may be rather tricky when 
> considering languages with different baseline conventions (hanging or 
> variable or none).
> 
> Eike Hein wrote:
> The top version on the screenshot still shows all of the problems I'm 
> currently fixing FWIW.

I've now pushed the cleaned up tasks.svgz to git master. This fixes:

* Fix inconsistent inside margins causing vertical misalignment inside Task 
Buttons.
* Fix inconsistent outside margins causing incorrect alignment inside panel.
* Fix outside margins and button corner appearance in locations other than 
South.
* Align button frames with things like the pager edges.
* Fix a few instances of incorrect color scheme application.
* Remove many unused elements.

This is what this gets us: http://i.imgur.com/7KaeJH5.png

This took *hours* to fix. If anyone breaks these margins I will *eat* them. 
Please base future changes on this version of the file!


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/20

Re: Review Request 126373: change the taskbar color from blue to gray

[Martin Klapetek]

> On Dec. 20, 2015, 9:24 p.m., andreas kainz wrote:
> > ok so please vote for
> > 1. leave it as it is
> > 2. as it is now but with white text for selected task
> > 3. add blue boarder as all other tasks have (see first line in taskbar3.png)
> > 4. better idea

3) is good. Keeps the color meaning and improves the visuals, +1 to that.

If you want to go for blue-bg/white-fg, this would require more things
involved, Eike could probably elaborate on that more.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89777
---


On Dec. 16, 2015, 8:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126443: Fix memleak in Plasma framework's PackageUrlInterceptor

[Michael Pyne]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126443/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Fixes a minor memleak in PackageUrlInterceptor (noted by Coverity, CID 
#1332370), by deleting d-ptr in existing destructor.


Diffs
-

  src/plasmaquick/packageurlinterceptor.cpp e49fc35 

Diff: https://git.reviewboard.kde.org/r/126443/diff/


Testing
---

Still builds.


Thanks,

Michael Pyne

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Eike Hein]

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.
> 
> Uri Herrera wrote:
> The margins are not random. I literally had to use kruler and kmag to 
> properly align that. I even used a layered file with a red rectangle in it 
> because that area consists of a deadzone. I pointed that out when I made the 
> reveiw request originally.
> 
> Eike Hein wrote:
> The inside margins are currently inconsistent at the top and bottom 
> causing the icon to be vertically misaligned. The outside margins are 
> inconsistent as well - I think it's trying to position the button well inside 
> the panel, but this is an incorrect approach to the problem (the optical 
> imbalance with consistent margins is caused by how the panel inside margins 
> function, which is something we need to address in the theming system - my 
> approach to fix it was rejected, I'll be trying again though). The outside 
> margins and the corners (top ones rounded, bottom ones not) subtly break 
> things when the panel is anywhere but the bottom.
> 
> I'm working on a series of changes to make the panel and Task Manager 
> finally pixel-perfect - fix the theme, fix the panel controller when 
> resizing, fix the panel default size, and fix something in FrameSVG/the panel 
> containment.
> 
> Johan Ouwerkerk wrote:
> In any case, the top version (new draft?) has markedly better alignment 
> of the text with icons... The other two versions seem vertically imbalanced 
> (more margin on the bottom than at the top).
> Ideally, the icon is vertically aligned with the baseline of the text 
> such that ascenders and descenders extend equally far beyond the 
> corresponding border of the icon, hough this may be rather tricky when 
> considering languages with different baseline conventions (hanging or 
> variable or none).

The top version on the screenshot still shows all of the problems I'm currently 
fixing FWIW.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/f

Re: Review Request 126373: change the taskbar color from blue to gray

[Johan Ouwerkerk]

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.
> 
> Uri Herrera wrote:
> The margins are not random. I literally had to use kruler and kmag to 
> properly align that. I even used a layered file with a red rectangle in it 
> because that area consists of a deadzone. I pointed that out when I made the 
> reveiw request originally.
> 
> Eike Hein wrote:
> The inside margins are currently inconsistent at the top and bottom 
> causing the icon to be vertically misaligned. The outside margins are 
> inconsistent as well - I think it's trying to position the button well inside 
> the panel, but this is an incorrect approach to the problem (the optical 
> imbalance with consistent margins is caused by how the panel inside margins 
> function, which is something we need to address in the theming system - my 
> approach to fix it was rejected, I'll be trying again though). The outside 
> margins and the corners (top ones rounded, bottom ones not) subtly break 
> things when the panel is anywhere but the bottom.
> 
> I'm working on a series of changes to make the panel and Task Manager 
> finally pixel-perfect - fix the theme, fix the panel controller when 
> resizing, fix the panel default size, and fix something in FrameSVG/the panel 
> containment.

In any case, the top version (new draft?) has markedly better alignment of the 
text with icons... The other two versions seem vertically imbalanced (more 
margin on the bottom than at the top).
Ideally, the icon is vertically aligned with the baseline of the text such that 
ascenders and descenders extend equally far beyond the corresponding border of 
the icon, hough this may be rather tricky when considering languages with 
different baseline conventions (hanging or variable or none).


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploa

Re: Review Request 126373: change the taskbar color from blue to gray

[Eike Hein]

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.
> 
> Uri Herrera wrote:
> The margins are not random. I literally had to use kruler and kmag to 
> properly align that. I even used a layered file with a red rectangle in it 
> because that area consists of a deadzone. I pointed that out when I made the 
> reveiw request originally.

The inside margins are currently inconsistent at the top and bottom causing the 
icon to be vertically misaligned. The outside margins are inconsistent as well 
- I think it's trying to position the button well inside the panel, but this is 
an incorrect approach to the problem (the optical imbalance with consistent 
margins is caused by how the panel inside margins function, which is something 
we need to address in the theming system - my approach to fix it was rejected, 
I'll be trying again though). The outside margins and the corners (top ones 
rounded, bottom ones not) subtly break things when the panel is anywhere but 
the bottom.

I'm working on a series of changes to make the panel and Task Manager finally 
pixel-perfect - fix the theme, fix the panel controller when resizing, fix the 
panel default size, and fix something in FrameSVG/the panel containment.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Uri Herrera]

> On Dic. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.

The margins are not random. I literally had to use kruler and kmag to properly 
align that. I even used a layered file with a red rectangle in it because that 
area consists of a deadzone. I pointed that out when I made the reveiw request 
originally.


- Uri


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dic. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dic. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126374: [Activity Pager] Implement drag and drop for Task Manager entries

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126374/
---

(Updated Dec. 20, 2015, 9:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Ivan Čukić.


Changes
---

Submitted with commit 08cc10167b0bb0162006bf587b38d3097ee493b0 by Kai Uwe 
Broulik to branch master.


Repository: kdeplasma-addons


Description
---

Just like you can drop windows from the task manager on the virtual desktop 
pager, you shold be able to do the same with the activity pager.

If set, this naturally unsets the "On All Activities" setting but so does 
dragging the miniature windows.

Also enabled preventStealing so Plasma doesn't create an icon widget in 
response to our drop.


Diffs
-

  CMakeLists.txt 5a654b3 
  applets/activitypager/CMakeLists.txt 078f8ef 
  applets/activitypager/package/contents/ui/main.qml 15a63a5 
  applets/activitypager/plugin/activitypager.h 976e5f1 
  applets/activitypager/plugin/activitypager.cpp 4d1a5a6 

Diff: https://git.reviewboard.kde.org/r/126374/diff/


Testing
---

Works.

Pretty straightforward but as it introduces a new dependency master only.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126433: [Containment Interface] Fix erratic high precision scrolling

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126433/
---

(Updated Dec. 20, 2015, 9:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Xuetian Weng.


Changes
---

Submitted with commit 899f95d0cfa1c00779736749527ecd7808f14dc1 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

This makes containment actions only trigger for one "wheel tick" rather than 
continuously when you scroll with a touchpad


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.h ec2c801 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp decbacf 

Diff: https://git.reviewboard.kde.org/r/126433/diff/


Testing
---

Swiping my finger across the touchpad now results in a couple of virtual 
desktop switches rather than dozens.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 20 Dec 2015 21:53:51 +
Build duration: 1 min 58 sec

CHANGE SET
Revision c8e71c462c0aa4f449239771b10f56a4894e8f62 by kde: ([Containment 
Actions] Send along proper wheel orientation)
  change: edit shell/currentcontainmentactionsmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126432: [Containment Actions] Send along a proper wheel orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126432/
---

(Updated Dec. 20, 2015, 9:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c8e71c462c0aa4f449239771b10f56a4894e8f62 by Kai Uwe 
Broulik to branch Plasma/5.5.


Bugs: 356799
https://bugs.kde.org/show_bug.cgi?id=356799


Repository: plasma-workspace


Description
---

The orientation for wheel events is deprecated but this is a quick and easy fix 
to the problem without refactoring that entire thing.


Diffs
-

  shell/currentcontainmentactionsmodel.cpp fe1c676 

Diff: https://git.reviewboard.kde.org/r/126432/diff/


Testing
---

I can now assign actions to horizontal wheel and trigger them accordingly.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

[Artur Puzio]

> On Gru 20, 2015, 10:48 po południu, David Edmundson wrote:
> > do you have commit access?

No. I don't have.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/#review89783
---


On Gru 20, 2015, 10:12 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126438/
> ---
> 
> (Updated Gru 20, 2015, 10:12 po południu)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356946
> https://bugs.kde.org/show_bug.cgi?id=356946
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As discribed in the bug report: when users has a avatar it's shown in sound 
> kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is 
> a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces 
> maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
> Aspect ratio isn't preserved, but please note that in many other places it's 
> also assumed that avatar is a square.
> 
> 
> Diffs
> -
> 
>   kcms/phonon/audiosetup.cpp 4bdba69 
> 
> Diff: https://git.reviewboard.kde.org/r/126438/diff/
> 
> 
> Testing
> ---
> 
> Installed patched version. Checked visually sound kcm on account with avatar 
> and on account without an avatar.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/#review89783
---


do you have commit access?

- David Edmundson


On Dec. 20, 2015, 9:12 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126438/
> ---
> 
> (Updated Dec. 20, 2015, 9:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356946
> https://bugs.kde.org/show_bug.cgi?id=356946
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As discribed in the bug report: when users has a avatar it's shown in sound 
> kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is 
> a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces 
> maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
> Aspect ratio isn't preserved, but please note that in many other places it's 
> also assumed that avatar is a square.
> 
> 
> Diffs
> -
> 
>   kcms/phonon/audiosetup.cpp 4bdba69 
> 
> Diff: https://git.reviewboard.kde.org/r/126438/diff/
> 
> 
> Testing
> ---
> 
> Installed patched version. Checked visually sound kcm on account with avatar 
> and on account without an avatar.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/#review89782
---

Ship it!


Ship It!

- David Edmundson


On Dec. 20, 2015, 9:12 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126438/
> ---
> 
> (Updated Dec. 20, 2015, 9:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356946
> https://bugs.kde.org/show_bug.cgi?id=356946
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As discribed in the bug report: when users has a avatar it's shown in sound 
> kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is 
> a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces 
> maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
> Aspect ratio isn't preserved, but please note that in many other places it's 
> also assumed that avatar is a square.
> 
> 
> Diffs
> -
> 
>   kcms/phonon/audiosetup.cpp 4bdba69 
> 
> Diff: https://git.reviewboard.kde.org/r/126438/diff/
> 
> 
> Testing
> ---
> 
> Installed patched version. Checked visually sound kcm on account with avatar 
> and on account without an avatar.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126433: [Containment Interface] Fix erratic high precision scrolling

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126433/#review89781
---

Ship it!


Ship It!

- David Edmundson


On Dec. 20, 2015, 2:38 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126433/
> ---
> 
> (Updated Dec. 20, 2015, 2:38 p.m.)
> 
> 
> Review request for Plasma and Xuetian Weng.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes containment actions only trigger for one "wheel tick" rather than 
> continuously when you scroll with a touchpad
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h ec2c801 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp decbacf 
> 
> Diff: https://git.reviewboard.kde.org/r/126433/diff/
> 
> 
> Testing
> ---
> 
> Swiping my finger across the touchpad now results in a couple of virtual 
> desktop switches rather than dozens.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126432: [Containment Actions] Send along a proper wheel orientation

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126432/#review89780
---

Ship it!


Thanks


shell/currentcontainmentactionsmodel.cpp (line 92)


instead of:

abs(x) - abs(y) > 0

abs(x) > abs(y)

is considerably easier to read and does the same thing.


- David Edmundson


On Dec. 20, 2015, 2:28 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126432/
> ---
> 
> (Updated Dec. 20, 2015, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356799
> https://bugs.kde.org/show_bug.cgi?id=356799
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The orientation for wheel events is deprecated but this is a quick and easy 
> fix to the problem without refactoring that entire thing.
> 
> 
> Diffs
> -
> 
>   shell/currentcontainmentactionsmodel.cpp fe1c676 
> 
> Diff: https://git.reviewboard.kde.org/r/126432/diff/
> 
> 
> Testing
> ---
> 
> I can now assign actions to horizontal wheel and trigger them accordingly.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

[Artur Puzio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/
---

Review request for Plasma.


Bugs: 356946
https://bugs.kde.org/show_bug.cgi?id=356946


Repository: plasma-desktop


Description
---

As discribed in the bug report: when users has a avatar it's shown in sound kcm 
in "Speaker Placement and Testing", but it's not resized. (e.g. If it is a 
1000x1000 image it takes 1000x1000px on screen.) This simple patch forces 
maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
Aspect ratio isn't preserved, but please note that in many other places it's 
also assumed that avatar is a square.


Diffs
-

  kcms/phonon/audiosetup.cpp 4bdba69 

Diff: https://git.reviewboard.kde.org/r/126438/diff/


Testing
---

Installed patched version. Checked visually sound kcm on account with avatar 
and on account without an avatar.


Thanks,

Artur Puzio

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


General PSA: I will soon push a fixed-up version of tasks.svgz to the repo that 
cleans up all the random margins and inconsistent corner styles in it that 
currently mess up alignments inside and outside of task buttons as well as 
corner appearance. Whatever the outcome of this, it needs to be rebased against 
those fixes first.

- Eike Hein


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

[Alessandro Longo]

> On Dic. 11, 2015, 7:08 p.m., Martin Klapetek wrote:
> > > Attached images directly to request; if this is not the preferred way of 
> > > attaching large files
> > 
> > Attaching just one file would be fine, I mean this is just to see it right?
> > So there's no need to upload /all/ the resolutions, imo :)
> > 
> > > I would like to shift to more "professional" default wallpapers
> > 
> > Can you clarify a bit what does that mean?
> > 
> > ---
> > 
> > Overall the wallpaper strikes me as a visual corruption. This may be due
> > to my currently slightly broken intel driver which creates all sorts of 
> > graphical glitches and that wallpaper to me just looks like it glitched
> > (the shadow polygon going on from the top-left corner is just a strong
> > reminescence of that plus the "rainbow noise" going on at the lower-right
> > diagonal part of the image).
> 
> Ken Vermette wrote:
> Ah, sorry, haven't seriously used reviewboard. Wasn't sure if the content 
> in the request would be what actually goes into the repo. David very 
> patiently explained everything I needed to know about this all, but my birdy 
> little brain promptly forgot anything important and I don't think I've 
> (properly) gotten as far as having a patch committed. Sorry - this is an area 
> I'm trying to improve.
> 
> Generally when I talk about "professional" I'm talking less organic, 
> wild, "in your face" wallpapers. 5.2 was just horrible neon mess, 5.3 looked 
> cluttered, 5.4 was regularly called an "acid trip", etc... I don't want to 
> make things dull and lifeless, but after going down the current road I think 
> a cleaner approach is worth a shot. Practically this means I want to be more 
> conservative in the shapes and clutter department, rope in the organics a 
> bit, and focus on clearly defined visually interesting layers.
> 
> ---
> 
> Hopefully our users aren't exposed to enough visual corruption to feel 
> that way :P 
> 
> But in all seriousness I will move the top-left of the "shadow polygon" 
> away from the corner though (possibly hiding it off-screen entirely (in 
> certian sizes it is cropped anyway), I do regularly work on a machine with 
> AMD graphics w/ graphical bugs and I can understand the where you're coming 
> from when I specifically look for it. 
> 
> Otherwise people who have seen this wallpaper haven't mentioned it 
> looking glitchy, so general users may not be as sensitive to this. Consider 
> that I personally don't see it as a big issue, as for some "glitchy" is even 
> a desirable look. Before I remove/alter the circuit pattern I'd like to see 
> another person or two weigh in and answer if I'm biased because I know what 
> it's supposed to be, or if you are possibly biased from working on a system 
> with visual corruption. Does anyone else think;
>  - the pattern could be regularly/easily misidentified as visual 
> corruption?
>  - ... And would a wallpaper with that style be a problem?
> 
> I'll wait until we decide what to do with the pattern before loading 
> another version (with the shadow polygon altered)

Every time that you release a wallpaper I think: "oh, OK, this is the best 
wallpaper ever, even the next won't be better than this!" and every time you 
surprise me with a wallpaper better than the previous.

This time you impress me again, this wallpaper goes exactly in the direction I 
wanted for Plasma! It's professional, has unique style, it's an art 
masterpiece.

I want it for Plasma 5.6. Absolutely.


- Alessandro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126319/#review89366
---


On Dic. 11, 2015, 7:04 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126319/
> ---
> 
> (Updated Dic. 11, 2015, 7:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Attached images directly to request; if this is not the preferred way of 
> attaching large files, please let me know and I'll change methods, perhaps 
> using the VDG share if that's preferred.
> 
> For reference I would like to shift to more "professional" default wallpapers 
> and away from the more organic style of 5.4 and 5.5. Feedback on both general 
> direction or this wallpaper is welcome.
> 
> Note: I will submit splash files later in case of changes to this wallpaper.
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/i

Re: Review Request 126373: change the taskbar color from blue to gray

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89777
---


ok so please vote for
1. leave it as it is
2. as it is now but with white text for selected task
3. add blue boarder as all other tasks have (see first line in taskbar3.png)
4. better idea

- andreas kainz


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element in the sidebar the text color change from "black" to white 
> which isn't possible in the system tray and than the contrast isn't that good 
> in the panel for selected application (gray text on blue background). In 
> addition the blue is very visible. see screenshot before.
> 
> Solution
> 
> I like that we use the same color language but when you look at the dolphin 
> toolbar on top selected elements (e.g. preview in the screenshot) are gray so 
> I change the blue color for the selected application to gray and change 
> minimized app to no border.
> 
> what do you think?
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/widgets/tasks.svgz 086558b 
> 
> Diff: https://git.reviewboard.kde.org/r/126373/diff/
> 
> 
> Testing
> ---
> 
> I will test the new taskbar and hope someone else can test it too before we 
> may ship it.
> 
> 
> File Attachments
> 
> 
> taskbar style old
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
> taskbar style new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
> new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
> taskbar old and new
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
> tasks new blue boarder in difference to the original one
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
> new draft, origin, old draft
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89770
---


Sorry for being picky :)


backends/kwayland/waylandconfig.cpp (line 203)


The () can be omitted



backends/kwayland/waylandconfig.cpp (line 222)


Out of curiosity, why do you always check explicitly for nullptr and false?



backends/kwayland/waylandconfig.cpp (lines 250 - 251)


Btw if you made outputs const you could use a range-for, range-for is only 
evil on Qt containers if not const. :)



backends/kwayland/waylandconfig.cpp (line 259)


Q_FOREACH should be able to iterate QMap, if not, use iterators:
for (auto it = m_outputMap.constBegin(), end = m_outputMap.constEnd(); it 
!= end; ++it) {



backends/kwayland/waylandconfig.cpp (line 281)


newConfig



backends/kwayland/waylandconfig.cpp (line 325)


You could theoretically create one lambda and connect both signals to it, 
since these are identical.



backends/kwayland/waylandoutput.h (line 33)


You can forward-declare enum classes :)



backends/kwayland/waylandoutput.h (lines 54 - 55)


Asterisks to variable name, same below



backends/kwayland/waylandoutput.h (line 74)


nullptr



backends/kwayland/waylandoutput.h (line 82)


static?



backends/kwayland/waylandoutput.cpp (lines 105 - 106)


The outputs are destroyed when they get disconnected, so you don't connect 
multiple times, right?



backends/kwayland/waylandoutput.cpp (line 128)


QLatin1Char('-') ?



backends/kwayland/waylandoutput.cpp (line 158)


modeList.insert(modeid, mode);



backends/kwayland/waylandoutput.cpp (lines 184 - 185)


could just use output->name()



backends/kwayland/waylandscreen.cpp (line 30)


Not neccessary



backends/kwayland/waylandscreen.cpp (line 61)


:) I'll remind you when I buy my 64K SuperMegaUltraHD monitor



src/screen.h (line 48)


That sounds wrong



tests/kwayland/waylandconfigreader.h (lines 40 - 44)


Asterisk and Ampersand to variable name



tests/kwayland/waylandconfigreader.cpp (line 33)


QVector


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handl

Re: Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89769
---



backends/kwayland/waylandbackend.h (line 54)


const KScreen::ConfigPtr &cfg



backends/kwayland/waylandbackend.cpp (lines 51 - 53)


= default



backends/kwayland/waylandbackend.cpp (line 57)


Why is this QStringLiteral whereas the other is QLatin1Literal?



backends/kwayland/waylandbackend.cpp (line 79)


const KScreen::ConfigPtr &cfg



backends/kwayland/waylandconfig.h (line 68)


nullptr



backends/kwayland/waylandconfig.cpp (line 57)


QTimer::singleShot(1000, this, [this] { ... })



backends/kwayland/waylandconfig.cpp (line 79)


Remove



backends/kwayland/waylandconfig.cpp (line 87)


connect(m_connection, ..., this, [this] { ... });



backends/kwayland/waylandconfig.cpp (lines 115 - 117)


qDeleteAll (I think this requires Qt 5.6 to work though)



backends/kwayland/waylandconfig.cpp (line 177)


postfix



backends/kwayland/waylandconfig.cpp (line 180)


if (m_outputMap.contains(new_id))

The contains method in QMap/QHash looks for a key, no need to create a 
temporary list



backends/kwayland/waylandconfig.cpp (line 188)


waylandOutput



backends/kwayland/waylandconfig.cpp (lines 234 - 235)


m_outputMap.take(kscreen_id)



backends/kwayland/waylandconfig.cpp (line 252)


if (!m_outputMap.contains(output->id())


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/

Re: Review Request 126381: kwayland backend for libkscreen

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89768
---



autotests/testconfigserializer.cpp (line 161)


Why this change?


- Kai Uwe Broulik


On Dez. 18, 2015, 3:16 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dez. 18, 2015, 3:16 nachm.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.md PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
> 
> 
> Testing
> ---
> 
> The patch contains a test server, which is used for the autotests.
> 
> The test server uses KWayland's server classes and is set up from the json 
> config data we use for the other tests. That means that the backends runs 
> against a real server to test everything.
> 
> I also tested the kscreen UI, which also works as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126433: [Containment Interface] Fix erratic high precision scrolling

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126433/
---

Review request for Plasma and Xuetian Weng.


Repository: plasma-framework


Description
---

This makes containment actions only trigger for one "wheel tick" rather than 
continuously when you scroll with a touchpad


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.h ec2c801 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp decbacf 

Diff: https://git.reviewboard.kde.org/r/126433/diff/


Testing
---

Swiping my finger across the touchpad now results in a couple of virtual 
desktop switches rather than dozens.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126432: [Containment Actions] Send along a proper wheel orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126432/
---

Review request for Plasma.


Bugs: 356799
https://bugs.kde.org/show_bug.cgi?id=356799


Repository: plasma-workspace


Description
---

The orientation for wheel events is deprecated but this is a quick and easy fix 
to the problem without refactoring that entire thing.


Diffs
-

  shell/currentcontainmentactionsmodel.cpp fe1c676 

Diff: https://git.reviewboard.kde.org/r/126432/diff/


Testing
---

I can now assign actions to horizontal wheel and trigger them accordingly.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Fabian Köster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #10 from Fabian Köster  ---
Same with 5.5.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 356941] "Switch User" sometimes sends computer to Standby

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356941

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Kai Uwe Broulik  ---
Thanks, will reopen the other one.

*** This bug has been marked as a duplicate of bug 354250 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=354250

--- Comment #9 from Kai Uwe Broulik  ---
*** Bug 356941 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 356941] New: "Switch User" sometimes sends computer to Standby

[Fabian Köster via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356941

Bug ID: 356941
   Summary: "Switch User" sometimes sends computer to Standby
   Product: Powerdevil
   Version: 5.5.1
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: koesterre...@fastmail.fm

This is the same bug as #354250 which is not fixed for me, but I cannot reopen
the report.

System should not suspend when switching to an inactive session.

Reproducible: Always

Steps to Reproduce:
1. Boot computer into SDDM
2. Login with user A
3. From the running Plasma session start a new session for user B
4. Work more than $t minutes in user B's session (where $t is the configured
time after inactivity, after which the system should suspend)
5. Logout user B or switch back to user A's session

Actual Results:  
 The system suspends 

Expected Results:  
The system should not suspend, because the person in front of the machine was
actively using it all the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126381: kwayland backend for libkscreen

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review89764
---


I think it's OK now - just one (hopefuly last) nitpick: could you please unify 
the use of foreach v. Q_FOREACH/emit v. Q_EMIT? I prefer the latter.


backends/kwayland/waylandconfig.cpp (line 217)


Superflous semicolon



tests/kwayland/waylandconfigreader.cpp (line 110)


No need for .toList(), Q_FOREACH can iterate over values of a map.



tests/kwayland/waylandtestserver.cpp (line 72)


Don't use range-based loops on Qt containers, they cause detach and deep 
copy, use Q_FOREACH instead.



tests/kwayland/waylandtestserver.cpp (line 105)


Q_FOREACH



tests/kwayland/waylandtestserver.cpp (line 156)


Q_FOREACH


- Daniel Vrátil


On Dec. 18, 2015, 4:16 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> ---
> 
> (Updated Dec. 18, 2015, 4:16 p.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This adds a kwayland backend to libkscreen.
> 
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
> 
> Enlisting outputs
> 
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
> 
> Configuring outputs
> 
> The backend asks the global OutputManagement interface for an 
> OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
> 
> For this to work, the compositor should support the Wayland 
> org_kde_kwin_outputdevice
> and org_kde_kwin_outputmanagement protocols, for example through
> KWayland::Server classes OutputDevice, OutputManagmenent and 
> OuputConfiguration.
> 
> General working
> 
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as 
> WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
> 
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt efac5ce 
>   autotests/CMakeLists.txt 07b7bbc 
>   autotests/configs/default.json 3ac3e19 
>   autotests/testconfigserializer.cpp 1af3069 
>   autotests/testkwaylandbackend.cpp PRE-CREATION 
>   autotests/testkwaylandconfig.cpp PRE-CREATION 
>   backends/CMakeLists.txt ff5d751 
>   backends/kwayland/CMakeLists.txt PRE-CREATION 
>   backends/kwayland/README.md PRE-CREATION 
>   backends/kwayland/waylandbackend.h PRE-CREATION 
>   backends/kwayland/waylandbackend.cpp PRE-CREATION 
>   backends/kwayland/waylandconfig.h PRE-CREATION 
>   backends/kwayland/waylandconfig.cpp PRE-CREATION 
>   backends/kwayland/waylandoutput.h PRE-CREATION 
>   backends/kwayland/waylandoutput.cpp PRE-CREATION 
>   backends/kwayland/waylandscreen.h PRE-CREATION 
>   backends/kwayland/waylandscreen.cpp PRE-CREATION 
>   src/backendmanager.cpp 89ae31e 
>   src/config.cpp e8b8a8f 
>   src/screen.h 4cd1e82 
>   tests/CMakeLists.txt d5e41d5 
>   tests/kwayland/CMakeLists.txt PRE-CREATION 
>   tests/kwayland/main.cpp PRE-CREATION 
>   tests/kwayland/waylandconfigreader.h PRE-CREATION 
>   tests/kwayland/waylandconfigreader.cpp PRE-CREATION 
>   tests/kwayland/waylandtestserver.h PRE-CREATION 
>   tests/kwayland/waylandtestserver.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126381/d