Review Request 126946: ShowDesktop is not synchronized

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/
---

Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.


Repository: kdeplasma-addons


Description
---

Activity pager settings -> Selecting current desktop -> showDesktop. If desktop 
is showed by clicking on widget, it can be restored by clicking on item in task 
manager, which lead m_desktopDown to store incorrect state.


Diffs
-

  applets/activitypager/plugin/activitypager.cpp b991bac 

Diff: https://git.reviewboard.kde.org/r/126946/diff/


Testing
---

Now works correctly, but i'm affraid about checks
#if HAVE_X11
if (!m_isX11) {
return;
}
why the is performed and even why the hell NETRootInfo is used in that way. And 
NETRootInfo::showingDesktop() about be is hell not working function.


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126952: Set layout in kickoff config properly

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/#review91895
---




applets/kickoff/package/contents/ui/ConfigGeneral.qml (line 28)


Why not make this the ColumnLayout? Should give you sensible minimum sizing 
of the dialog and stuff for free?


- Kai Uwe Broulik


On Feb. 1, 2016, 7:52 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126952/
> ---
> 
> (Updated Feb. 1, 2016, 7:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Existing layout wasn't bound to anything so no labels would clip if they
> got too wide. We were just lucky all text was short.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 
> aa345a508cc9da5c148b6237d4446627cd6656a1 
> 
> Diff: https://git.reviewboard.kde.org/r/126952/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/
---

Review request for KDE Frameworks and Plasma.


Bugs: 358533
http://bugs.kde.org/show_bug.cgi?id=358533


Repository: plasma-framework


Description
---

They are untested, unmaintained and most importantly, broken.

Let's remove them from our releases and move them to kde-look.org for grabs.


Diffs
-

  src/desktoptheme/air/CMakeLists.txt 40ea382 
  src/desktoptheme/air/colors 5c4e53d 
  src/desktoptheme/air/dialogs/background.svgz 81ef460 
  src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
  src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
  src/desktoptheme/air/icons/amarok.svgz e3c157e 
  src/desktoptheme/air/icons/audio.svgz 540cc77 
  src/desktoptheme/air/icons/battery.svgz 88f864e 
  src/desktoptheme/air/icons/configure.svgz a433b3c 
  src/desktoptheme/air/icons/device.svgz 23df094 
  src/desktoptheme/air/icons/document.svgz 6e89dd8 
  src/desktoptheme/air/icons/edit.svgz d0e1ca4 
  src/desktoptheme/air/icons/go.svgz ad3a4b2 
  src/desktoptheme/air/icons/kget.svgz 1f1702f 
  src/desktoptheme/air/icons/klipper.svgz 4afd33c 
  src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
  src/desktoptheme/air/icons/konversation.svgz 376211a 
  src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
  src/desktoptheme/air/icons/korgac.svgz 8c8f700 
  src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
  src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
  src/desktoptheme/air/icons/list.svgz 0a25bb0 
  src/desktoptheme/air/icons/media.svgz 23653bd 
  src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
  src/desktoptheme/air/icons/network.svgz a8e8b16 
  src/desktoptheme/air/icons/notification.svgz db12260 
  src/desktoptheme/air/icons/preferences.svgz 12e6588 
  src/desktoptheme/air/icons/printer.svgz 199ab95 
  src/desktoptheme/air/icons/quassel.svgz b004749 
  src/desktoptheme/air/icons/slc.svgz 9fd376b 
  src/desktoptheme/air/icons/wallet.svgz 4ad3691 
  src/desktoptheme/air/icons/window.svgz eecc37f 
  src/desktoptheme/air/icons/zoom.svgz c159491 
  src/desktoptheme/air/metadata.desktop 0be4bd5 
  src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
  src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
  src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
  src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
  src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
  src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
  src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
  src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
  src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
  src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
  src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
  src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
  src/desktoptheme/air/widgets/arrows.svgz b987b32 
  src/desktoptheme/air/widgets/background.svgz 174a8fc 
  src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
  src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
  src/desktoptheme/air/widgets/branding.svgz c6316fb 
  src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
  src/desktoptheme/air/widgets/button.svgz 2c529bf 
  src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
  src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
  src/desktoptheme/air/widgets/clock.svgz 3839dac 
  src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
  src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
  src/desktoptheme/air/widgets/dragger.svgz 3629591 
  src/desktoptheme/air/widgets/extender-background.svgz 4003079 
  src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
  src/desktoptheme/air/widgets/frame.svgz 327c284 
  src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
  src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
  src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
  src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
  src/desktoptheme/air/widgets/line.svgz 70efca4 
  src/desktoptheme/air/widgets/lineedit.svgz 22347db 
  src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
  src/desktoptheme/air/widgets/media-delegate.svgz e28b313 
  src/desktoptheme/air/widgets/monitor.svgz 13a22fd 
  src/desktoptheme/air/widgets/pager.svgz 2dcbbcd 
  src/desktoptheme/air/widgets/panel-background.svgz 080a65d 
  src/desktoptheme/air/widgets/picker.svgz c15eb0e 
  src/desktoptheme/air/widgets/plot-background.svgz f4c7957 
  src/desktoptheme/air/widgets/scrollbar.svgz c0ea8f5 
  src/desktoptheme/air/widgets/scrollwidget.svgz 3281ad6 
  src/desktoptheme/air/widgets/slider.svgz 107e627 
  src/desktoptheme/air/widgets/systemtray.svgz 6e15351 
  

Re: Review Request 126593: [Task Manager] Add Jump List actions to grouped tasks

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126593/#review91872
---



I've seen that I can actually pass a QList to TaskManager::BasicMenu 
which we could use. Unfortunately QAction doesn't support "sections" so the 
"Recent Documents" heading won't work with that.

- Kai Uwe Broulik


On Jan. 1, 2016, 6:41 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126593/
> ---
> 
> (Updated Jan. 1, 2016, 6:41 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This just adds the jump list actions to the top of the menu as with all the 
> other tasks.
> 
> Is it better if we place the jump list actions below the list of windows?
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/plugin/backend.cpp f83ae09 
> 
> Diff: https://git.reviewboard.kde.org/r/126593/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Jump List Action group
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/c0479186-77e7-4d33-bb6a-49b4abaf96f1__jumplistactionongroup.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126950: Fix kicker userExtraRunners

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126950/#review91894
---


Ship it!




Ship It!

- Martin Klapetek


On Feb. 1, 2016, 8:52 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126950/
> ---
> 
> (Updated Feb. 1, 2016, 8:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> array.concat(array2) creates a new array, it does not edit the initial
> object as one would expect
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/main.qml 
> 689a598b06580c11995d9730eb6460d4dc831336 
> 
> Diff: https://git.reviewboard.kde.org/r/126950/diff/
> 
> 
> Testing
> ---
> 
> New results appear, though to me the UI looks a bit broken. I think this was 
> masking another bug?
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126953: Remove Theme Details KCM

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/
---

Review request for Plasma, KDE Usability and Andrew Lake.


Repository: plasma-desktop


Description
---

This removes the theme editor thing in the Desktop Theme KCM.

Most settings in there are either broken or useless nowadays.

The only setting I would miss is different Analog Clock faces which could be 
done in the Analog Clock directly. What I am missing in general is a custom 
Panel color/texture or something like that which we don't have in here anyway.


Diffs
-

  kcms/desktoptheme/CMakeLists.txt 6168686 
  kcms/desktoptheme/DesktopTheme.ui f57cdf8 
  kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
  kcms/desktoptheme/desktopthemedetails.h 475d893 
  kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
  kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
  kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
  kcms/desktoptheme/kcmdesktoptheme.h ac87862 
  kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
  kcms/desktoptheme/thememodel.cpp bb5bb94 

Diff: https://git.reviewboard.kde.org/r/126953/diff/


Testing
---

Tab gone.

While at it I also replaced the status label with a proper KMessageWidget


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126947/
---

Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

Prevents them from being hidden by show desktop.

They're for configuring things on the desktop, so this makes sense. Also allows 
to configure an applet when it has been dropped from Widget Explorer which 
enters show desktop mode.


Diffs
-

  shell/desktopview.cpp bc40083 

Diff: https://git.reviewboard.kde.org/r/126947/diff/


Testing
---

Dragged widget from Widget Explorer and successfully configured it.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126956/
---

Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

Fixes the tooltips being broken for me (not properly resizing, spacing too 
large etc)

I don't see why we would need this.


Diffs
-

  containments/desktop/package/contents/ui/FolderItemDelegate.qml c2d7020 
  containments/desktop/package/contents/ui/FolderItemToolTipDelegate.qml 
a8b6f44 
  containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 

Diff: https://git.reviewboard.kde.org/r/126956/diff/


Testing
---

Works. No more glitchy tooltips.

(I wish the thumbnails in Folder tooltips were bigger, though)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126954: [Notifications] Fix Job finished persistency

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/#review91890
---


Ship it!




Thanks

- Martin Klapetek


On Feb. 1, 2016, 9:39 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126954/
> ---
> 
> (Updated Feb. 1, 2016, 9:39 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This was an oversight when porting to call the dataengine for that 
> notification.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/Jobs.qml 669d0bd 
>   dataengines/notifications/notificationaction.cpp c2da498 
> 
> Diff: https://git.reviewboard.kde.org/r/126954/diff/
> 
> 
> Testing
> ---
> 
> Works now.
> 
> KNotificationDBusTest also works fine.
> 
> Plasma Undo notifications are no longer persistent but this is unrelated to 
> this patch.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 1, 2016, 8:39 p.m., Boudhayan Gupta wrote:
> > +1
> > 
> > Ideally the default look-n-feel package should include only two themes - 
> > the default one and a high-contrast counterpart. In fact all other themes 
> > should reside elsewhere.
> > 
> > If we still want to "officially" provide Air and Oxygen, maybe we should 
> > move them to an extra-themes package instead instead of kde-look?

I have no preference as to where it gets moved. Maybe somewhere in git would be 
better in the end as it would preserve the history.

Imo if we still want to "officially" ship these two, they need to get some 
upgrade, cause at least on my hidpi they are kinda broken.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.

in addition a lot of dev's make screenshots with oxygen so there is an user 
group for oxygen.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   

Re: KDE papercuts love

[josephk]

ok, I filed some of these minor bugs





https://bugs.kde.org/show_bug.cgi?id=358532


https://bugs.kde.org/show_bug.cgi?id=358533


https://bugs.kde.org/show_bug.cgi?id=358534


https://bugs.kde.org/show_bug.cgi?id=358535


https://bugs.kde.org/show_bug.cgi?id=358536





Cheers









- Original Message 

 Da: "Marco Martin" notm...@gmail.com

 To: "plasma-devel" plasma-devel@kde.org

 Oggetto: Re: KDE papercuts love

 Data: 19/01/16 11:08

 

  

 

 On Sun, Jan 17, 2016 at 12:01 AM, jose...@email.it wrote:

  Hi and thank you for providing us great software. The leap from KDE SC
4

  serie is giant and in the good direction imho.

  I took some time to point out the little quirks I found using your
latest

  software on Arch Linux (Intel Broadwell).

  I own a micro-blog at www.archkde.blogspot.it if you wanna check out.

 

 Hi,

 Thanks for the time you took gathering those issues.

 In oder to make sure they are tracked, can you put them (especially

 the papercuts) in bugs.kde.org?

 

 --

 Marco Martin

  


 
 
 --
 ZE-Light e ZE-Pro: servizi zimbra per caselle con dominio email.it, per tutti 
i dettagli 
Clicca qui 
http://posta.email.it/caselle-di-posta-z-email-it/?utm_campaign=email_Zimbra_102014=main_footer/f
 
 Sponsor:
 Registra i domini che desideri ed inizia a creare il tuo sito web
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=13323=25-1___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126954: [Notifications] Fix Job finished persistency

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/
---

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

This was an oversight when porting to call the dataengine for that notification.


Diffs
-

  applets/notifications/package/contents/ui/Jobs.qml 669d0bd 
  dataengines/notifications/notificationaction.cpp c2da498 

Diff: https://git.reviewboard.kde.org/r/126954/diff/


Testing
---

Works now.

KNotificationDBusTest also works fine.

Plasma Undo notifications are no longer persistent but this is unrelated to 
this patch.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126954: [Notifications] Fix Job finished persistency

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126954/
---

(Updated Feb. 1, 2016, 9:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Changes
---

Submitted with commit bec916168c269df8807678c61aeb551cc3aac10e by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

This was an oversight when porting to call the dataengine for that notification.


Diffs
-

  applets/notifications/package/contents/ui/Jobs.qml 669d0bd 
  dataengines/notifications/notificationaction.cpp c2da498 

Diff: https://git.reviewboard.kde.org/r/126954/diff/


Testing
---

Works now.

KNotificationDBusTest also works fine.

Plasma Undo notifications are no longer persistent but this is unrelated to 
this patch.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Boudhayan Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---



+1

Ideally the default look-n-feel package should include only two themes - the 
default one and a high-contrast counterpart. In fact all other themes should 
reside elsewhere.

If we still want to "officially" provide Air and Oxygen, maybe we should move 
them to an extra-themes package instead instead of kde-look?

- Boudhayan Gupta


On Feb. 2, 2016, 1 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 2, 2016, 1 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 

Re: Review Request 126953: Remove Theme Details KCM

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/#review91886
---


Ship it!




+1 from me!

- Andrew Lake


On Feb. 1, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126953/
> ---
> 
> (Updated Feb. 1, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This removes the theme editor thing in the Desktop Theme KCM.
> 
> Most settings in there are either broken or useless nowadays.
> 
> The only setting I would miss is different Analog Clock faces which could be 
> done in the Analog Clock directly. What I am missing in general is a custom 
> Panel color/texture or something like that which we don't have in here anyway.
> 
> 
> Diffs
> -
> 
>   kcms/desktoptheme/CMakeLists.txt 6168686 
>   kcms/desktoptheme/DesktopTheme.ui f57cdf8 
>   kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
>   kcms/desktoptheme/desktopthemedetails.h 475d893 
>   kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
>   kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
>   kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
>   kcms/desktoptheme/kcmdesktoptheme.h ac87862 
>   kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
>   kcms/desktoptheme/thememodel.cpp bb5bb94 
> 
> Diff: https://git.reviewboard.kde.org/r/126953/diff/
> 
> 
> Testing
> ---
> 
> Tab gone.
> 
> While at it I also replaced the status label with a proper KMessageWidget
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126672/#review91889
---




src/declarativeimports/calendar/daysmodel.cpp (line 135)


Why this change?



src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp 
(line 34)


I thought QLatin1String was better for comparison?



src/plasma/package.cpp (line 262)


auto 

Coding style, and below.



src/plasma/pluginloader.cpp (line 609)


const auto and then you could keep the range-for?



src/plasma/private/applet_p.cpp (line 128)


QLatin1Char('&') ?



src/plasma/private/applet_p.cpp (line 381)


Not in this patch: I think QKeySequence(int, int, int, int) is more 
efficient than parsing text.



src/plasma/private/packages.cpp (line 99)


QByteArrayLiteral and below



src/plasma/private/storage.cpp (line 139)


QLatin1Char('.') ?



src/plasma/scripting/scriptengine.cpp (line 67)


This vector is already const, so it cannot detach



src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 484)


This should be i18n


- Kai Uwe Broulik


On Jan. 17, 2016, 8:50 nachm., Sergey Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126672/
> ---
> 
> (Updated Jan. 17, 2016, 8:50 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix almost all the Clazy warnings in plasma-framework.
> 
> Related GCI-2015 task: 
> [https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks/6272625345036288/)
> 
> 
> Diffs
> -
> 
>   autotests/coronatest.cpp 378a4b7 
>   autotests/dialogqmltest.cpp 618e64d 
>   autotests/fallbackpackagetest.cpp 91bc6e9 
>   autotests/packagestructuretest.cpp 67cdb4f 
>   autotests/pluginloadertest.cpp 868d5f8 
>   autotests/sortfiltermodeltest.cpp 6ee0e35 
>   autotests/storagetest.cpp 8a7dbd0 
>   src/declarativeimports/calendar/calendar.cpp 5515550 
>   src/declarativeimports/calendar/daysmodel.cpp 0f81b5a 
>   src/declarativeimports/core/corebindingsplugin.cpp adfdc29 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
>   src/declarativeimports/core/datasource.cpp 4fe5dc5 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
>   src/declarativeimports/core/units.cpp 1798727 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 9e924b3 
>   src/declarativeimports/plasmacomponents/qmenuitem.cpp 287e9b3 
>   
> src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp 
> 1a25f06 
>   src/plasma/applet.cpp 4ce2d28 
>   src/plasma/containment.cpp 0beb196 
>   src/plasma/containmentactions.cpp f42807f 
>   src/plasma/corona.cpp bae9244 
>   src/plasma/datacontainer.cpp 396bc6d 
>   src/plasma/dataengine.cpp dd56807 
>   src/plasma/dataengineconsumer.cpp 7c9b5f9 
>   src/plasma/framesvg.cpp 81187dc 
>   src/plasma/package.cpp 09f36f3 
>   src/plasma/packagestructure.cpp 09ea698 
>   src/plasma/pluginloader.cpp d7c49f2 
>   src/plasma/private/applet_p.cpp 949c92e 
>   src/plasma/private/associatedapplicationmanager.cpp e1620e9 
>   src/plasma/private/componentinstaller.cpp 8fbef24 
>   src/plasma/private/containment_p.cpp 09ed2cd 
>   src/plasma/private/dataenginemanager.cpp 7862171 
>   src/plasma/private/packages.cpp 1edd55a 
>   src/plasma/private/service_p.h 8a48487 
>   src/plasma/private/storage.cpp bc6992e 
>   src/plasma/private/storagethread.cpp 91b490b 
>   src/plasma/private/svg_p.h 1d1000d 
>   src/plasma/private/theme_p.cpp 18419bb 
>   src/plasma/private/timetracker.cpp cdfe94b 
>   src/plasma/scripting/scriptengine.cpp b9f43fe 
>   src/plasma/service.cpp d603cf2 
>   src/plasma/svg.cpp 28abd00 
>   src/plasma/theme.cpp e9420e6 
>   src/plasmapkg/main.cpp 336b14e 
>   src/plasmapkg/plasmapkg.cpp 4626323 
>   src/plasmaquick/appletquickitem.cpp ec2ed24 
>   src/plasmaquick/configmodel.cpp df537c1 
>   src/plasmaquick/configview.cpp c4ab518 
>   src/plasmaquick/dialog.cpp 8f4ee57 
>  

Re: Review Request 126952: Set layout in kickoff config properly

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/
---

(Updated Feb. 1, 2016, 11:20 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

Existing layout wasn't bound to anything so no labels would clip if they
got too wide. We were just lucky all text was short.


Diffs (updated)
-

  applets/kickoff/package/contents/ui/ConfigGeneral.qml 
aa345a508cc9da5c148b6237d4446627cd6656a1 

Diff: https://git.reviewboard.kde.org/r/126952/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91904
---



can you add an screenshot with the week names?

- andreas kainz


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91878
---


Ship it!




Ship It!

- David Edmundson


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
>   

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126672/#review91881
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Jan. 17, 2016, 9:50 p.m., Sergey Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126672/
> ---
> 
> (Updated Jan. 17, 2016, 9:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix almost all the Clazy warnings in plasma-framework.
> 
> Related GCI-2015 task: 
> [https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks/6272625345036288/)
> 
> 
> Diffs
> -
> 
>   autotests/coronatest.cpp 378a4b7 
>   autotests/dialogqmltest.cpp 618e64d 
>   autotests/fallbackpackagetest.cpp 91bc6e9 
>   autotests/packagestructuretest.cpp 67cdb4f 
>   autotests/pluginloadertest.cpp 868d5f8 
>   autotests/sortfiltermodeltest.cpp 6ee0e35 
>   autotests/storagetest.cpp 8a7dbd0 
>   src/declarativeimports/calendar/calendar.cpp 5515550 
>   src/declarativeimports/calendar/daysmodel.cpp 0f81b5a 
>   src/declarativeimports/core/corebindingsplugin.cpp adfdc29 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
>   src/declarativeimports/core/datasource.cpp 4fe5dc5 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
>   src/declarativeimports/core/units.cpp 1798727 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 9e924b3 
>   src/declarativeimports/plasmacomponents/qmenuitem.cpp 287e9b3 
>   
> src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp 
> 1a25f06 
>   src/plasma/applet.cpp 4ce2d28 
>   src/plasma/containment.cpp 0beb196 
>   src/plasma/containmentactions.cpp f42807f 
>   src/plasma/corona.cpp bae9244 
>   src/plasma/datacontainer.cpp 396bc6d 
>   src/plasma/dataengine.cpp dd56807 
>   src/plasma/dataengineconsumer.cpp 7c9b5f9 
>   src/plasma/framesvg.cpp 81187dc 
>   src/plasma/package.cpp 09f36f3 
>   src/plasma/packagestructure.cpp 09ea698 
>   src/plasma/pluginloader.cpp d7c49f2 
>   src/plasma/private/applet_p.cpp 949c92e 
>   src/plasma/private/associatedapplicationmanager.cpp e1620e9 
>   src/plasma/private/componentinstaller.cpp 8fbef24 
>   src/plasma/private/containment_p.cpp 09ed2cd 
>   src/plasma/private/dataenginemanager.cpp 7862171 
>   src/plasma/private/packages.cpp 1edd55a 
>   src/plasma/private/service_p.h 8a48487 
>   src/plasma/private/storage.cpp bc6992e 
>   src/plasma/private/storagethread.cpp 91b490b 
>   src/plasma/private/svg_p.h 1d1000d 
>   src/plasma/private/theme_p.cpp 18419bb 
>   src/plasma/private/timetracker.cpp cdfe94b 
>   src/plasma/scripting/scriptengine.cpp b9f43fe 
>   src/plasma/service.cpp d603cf2 
>   src/plasma/svg.cpp 28abd00 
>   src/plasma/theme.cpp e9420e6 
>   src/plasmapkg/main.cpp 336b14e 
>   src/plasmapkg/plasmapkg.cpp 4626323 
>   src/plasmaquick/appletquickitem.cpp ec2ed24 
>   src/plasmaquick/configmodel.cpp df537c1 
>   src/plasmaquick/configview.cpp c4ab518 
>   src/plasmaquick/dialog.cpp 8f4ee57 
>   src/plasmaquick/dialogshadows.cpp db408ae 
>   src/plasmaquick/dialogshadows_p.h 7e17c12 
>   src/plasmaquick/packageurlinterceptor.cpp 5e349d2 
>   src/plasmaquick/private/packages.h aa08b11 
>   src/plasmaquick/private/packages.cpp 5275848 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 31285a2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp b15695b 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ecd62b 
>   tests/dpi/main.cpp 6767b2d 
>   tests/kplugins/main.cpp 421e3fb 
>   tests/kplugins/plugintest.h a99701a 
>   tests/kplugins/plugintest.cpp 3d98dec 
>   tests/testengine/testengine.cpp 76947c3 
> 
> Diff: https://git.reviewboard.kde.org/r/126672/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Sergey Popov
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126957: [FolderView] Show title in tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126957/
---

(Updated Feb. 1, 2016, 10:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Eike Hein.


Changes
---

Submitted with commit 954a4bc30b84b46d5cdfd9d5809dcd56fdff7dfd by Kai Uwe 
Broulik to branch master.


Repository: plasma-desktop


Description
---

Show the title you would get in the popup also in the tooltip.

"Folder View" is rather useless when in a panel :)


Diffs
-

  containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
  containments/desktop/package/contents/ui/main.qml 27e1cc3 

Diff: https://git.reviewboard.kde.org/r/126957/diff/


Testing
---

I get "Pictures", or "/home/foo/Pictures", or "Custom Title", or (if "None") 
the fallback "FolderView"

For some reason it doesn't update the tooltip when I change the settings.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/63234dfa-36e4-4daf-99ec-014ebb663c2c__Screenshot_20160201_231414.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---



Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
time I need the plasma oxygen theme too to give the user the one single click 
feature (look & feel package). Is there an space where you can move 
"unmaintained" stuff and the distros can choose what they want to ship. now all 
distros ship oxygen.

I love breeze but oxygen is also really sexy in addition a lot of uers work 
with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 LTS. It 
would be bad to support oxygen for an additional LTS cycle, but for the switch 
it would be nice to give the user the posibility for an soft switch.

- andreas kainz


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

[Kai Uwe Broulik]

> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.

There'a an oxygen repository where the widget style and everything resides, I'd 
say the Plasma theme would fit in there as well.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   

Review Request 126957: [FolderView] Show title in tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126957/
---

Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

Show the title you would get in the popup also in the tooltip.

"Folder View" is rather useless when in a panel :)


Diffs
-

  containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
  containments/desktop/package/contents/ui/main.qml 27e1cc3 

Diff: https://git.reviewboard.kde.org/r/126957/diff/


Testing
---

I get "Pictures", or "/home/foo/Pictures", or "Custom Title", or (if "None") 
the fallback "FolderView"

For some reason it doesn't update the tooltip when I change the settings.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/63234dfa-36e4-4daf-99ec-014ebb663c2c__Screenshot_20160201_231414.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

Review request for Plasma and KDE Usability.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing
---

Works.


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126950: Fix kicker userExtraRunners

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126950/#review91896
---




applets/kicker/package/contents/ui/main.qml (line 149)


Array.prototype.push.apply(runners, plasmoid.configuration.extraRunners)

is faster, sigh, JavaScript...

https://jsperf.com/array-prototype-push-apply-vs-concat/20


- Kai Uwe Broulik


On Feb. 1, 2016, 7:52 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126950/
> ---
> 
> (Updated Feb. 1, 2016, 7:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> array.concat(array2) creates a new array, it does not edit the initial
> object as one would expect
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/main.qml 
> 689a598b06580c11995d9730eb6460d4dc831336 
> 
> Diff: https://git.reviewboard.kde.org/r/126950/diff/
> 
> 
> Testing
> ---
> 
> New results appear, though to me the UI looks a bit broken. I think this was 
> masking another bug?
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126951: Clone useExtraRunners config option from kicker to kickoff

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126951/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

BUG: 358881


Diffs
-

  applets/kickoff/package/contents/config/main.xml 
afd0b6fa2128d4970aed163d8c696b9f10c77602 
  applets/kickoff/package/contents/ui/ConfigGeneral.qml 
aa345a508cc9da5c148b6237d4446627cd6656a1 
  applets/kickoff/package/contents/ui/Kickoff.qml 
d5a0675716ddeab6803943625a10c64c5c10953b 

Diff: https://git.reviewboard.kde.org/r/126951/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126952: Set layout in kickoff config properly

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126952/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

Existing layout wasn't bound to anything so no labels would clip if they
got too wide. We were just lucky all text was short.


Diffs
-

  applets/kickoff/package/contents/ui/ConfigGeneral.qml 
aa345a508cc9da5c148b6237d4446627cd6656a1 

Diff: https://git.reviewboard.kde.org/r/126952/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126950: Fix kicker userExtraRunners

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126950/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

array.concat(array2) creates a new array, it does not edit the initial
object as one would expect


Diffs
-

  applets/kicker/package/contents/ui/main.qml 
689a598b06580c11995d9730eb6460d4dc831336 

Diff: https://git.reviewboard.kde.org/r/126950/diff/


Testing
---

New results appear, though to me the UI looks a bit broken. I think this was 
masking another bug?


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.

ok. that would fit for me. since now we have not that much look and feel 
packages most distros use it for there look and feel stuff and than breeze and 
breeze-dark for people how don't like monochrome (there are a lot) is oxygen. 
it would be nice to have more packages there available so move the oxygen stuff 
in an spacific area is fine for me but don't move them to kde-look cause than 
oxygen is more broken than now and no one can fix it any more.

thanks Kai


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

[Aleix Pol Gonzalez]

> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp,
> >  line 34
> > 
> >
> > I thought QLatin1String was better for comparison?

+1


> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/calendar/daysmodel.cpp, line 135
> > 
> >
> > Why this change?

Because Clazy found that it's easier to optimize the code if not passing the 
reference. Note the only attribute in the class is a`qint64 jd;`, which fits in 
a 64bit processor register.


> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/plasma/package.cpp, line 262
> > 
> >
> > auto 
> > 
> > Coding style, and below.

in any case, it should be `const auto `.


> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/plasma/private/applet_p.cpp, line 128
> > 
> >
> > QLatin1Char('&') ?

+1


> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/plasma/private/storage.cpp, line 139
> > 
> >
> > QLatin1Char('.') ?

And QLatin1Char on the first too.


> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote:
> > src/plasma/scripting/scriptengine.cpp, line 67
> > 
> >
> > This vector is already const, so it cannot detach

const &.

In any case, I'd say it's safe to just agree to always use foreach on Qt 
containers.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126672/#review91889
---


On Jan. 17, 2016, 9:50 p.m., Sergey Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126672/
> ---
> 
> (Updated Jan. 17, 2016, 9:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix almost all the Clazy warnings in plasma-framework.
> 
> Related GCI-2015 task: 
> [https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks/6272625345036288/)
> 
> 
> Diffs
> -
> 
>   autotests/coronatest.cpp 378a4b7 
>   autotests/dialogqmltest.cpp 618e64d 
>   autotests/fallbackpackagetest.cpp 91bc6e9 
>   autotests/packagestructuretest.cpp 67cdb4f 
>   autotests/pluginloadertest.cpp 868d5f8 
>   autotests/sortfiltermodeltest.cpp 6ee0e35 
>   autotests/storagetest.cpp 8a7dbd0 
>   src/declarativeimports/calendar/calendar.cpp 5515550 
>   src/declarativeimports/calendar/daysmodel.cpp 0f81b5a 
>   src/declarativeimports/core/corebindingsplugin.cpp adfdc29 
>   src/declarativeimports/core/datamodel.cpp 4449f30 
>   src/declarativeimports/core/datasource.cpp 4fe5dc5 
>   src/declarativeimports/core/tooltip.cpp a5e223b 
>   src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
>   src/declarativeimports/core/units.cpp 1798727 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
>   src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 9e924b3 
>   src/declarativeimports/plasmacomponents/qmenuitem.cpp 287e9b3 
>   
> src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp 
> 1a25f06 
>   src/plasma/applet.cpp 4ce2d28 
>   src/plasma/containment.cpp 0beb196 
>   src/plasma/containmentactions.cpp f42807f 
>   src/plasma/corona.cpp bae9244 
>   src/plasma/datacontainer.cpp 396bc6d 
>   src/plasma/dataengine.cpp dd56807 
>   src/plasma/dataengineconsumer.cpp 7c9b5f9 
>   src/plasma/framesvg.cpp 81187dc 
>   src/plasma/package.cpp 09f36f3 
>   src/plasma/packagestructure.cpp 09ea698 
>   src/plasma/pluginloader.cpp d7c49f2 
>   src/plasma/private/applet_p.cpp 949c92e 
>   src/plasma/private/associatedapplicationmanager.cpp e1620e9 
>   src/plasma/private/componentinstaller.cpp 8fbef24 
>   src/plasma/private/containment_p.cpp 09ed2cd 
>   src/plasma/private/dataenginemanager.cpp 7862171 
>   src/plasma/private/packages.cpp 1edd55a 
>   src/plasma/private/service_p.h 8a48487 
>   src/plasma/private/storage.cpp bc6992e 
>   src/plasma/private/storagethread.cpp 91b490b 
>   src/plasma/private/svg_p.h 1d1000d 
>   src/plasma/private/theme_p.cpp 18419bb 
>   src/plasma/private/timetracker.cpp cdfe94b 
>   src/plasma/scripting/scriptengine.cpp b9f43fe 
>   src/plasma/service.cpp d603cf2 
>   src/plasma/svg.cpp 28abd00 
>   src/plasma/theme.cpp e9420e6 
>   

Re: Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126947/
---

(Updated Feb. 1, 2016, 9:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 467565d4556b0481779e3aa0cbce47ed9a919318 by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

Prevents them from being hidden by show desktop.

They're for configuring things on the desktop, so this makes sense. Also allows 
to configure an applet when it has been dropped from Widget Explorer which 
enters show desktop mode.


Diffs
-

  shell/desktopview.cpp bc40083 

Diff: https://git.reviewboard.kde.org/r/126947/diff/


Testing
---

Dragged widget from Widget Explorer and successfully configured it.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126951: Clone useExtraRunners config option from kicker to kickoff

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126951/#review91897
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Feb. 1, 2016, 7:52 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126951/
> ---
> 
> (Updated Feb. 1, 2016, 7:52 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> BUG: 358881
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 
> afd0b6fa2128d4970aed163d8c696b9f10c77602 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 
> aa345a508cc9da5c148b6237d4446627cd6656a1 
>   applets/kickoff/package/contents/ui/Kickoff.qml 
> d5a0675716ddeab6803943625a10c64c5c10953b 
> 
> Diff: https://git.reviewboard.kde.org/r/126951/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

plasma icons and system settings icons

[kainz.a]

plasma ship there own icons and as all other kf5 applications the master
section for icons are in the system settings defined.

The problem is that some distributions ship there own plasma theme (with
icons) but use breeze-icons as there icon set. so if they add an
distribution specific plasma icon which is already in breeze-icons
(/usr/share/icons/breeze) they have to fork breeze-icons and remove the
icon from /usr/share/icons/breeze.

I'm a big fan that the master section for icons is /usr/share/icons but
maybe for plasma it would be better to use the icons from the plasma theme
first.

cheers
Andreas_k
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Martin Klapetek]

> On Feb. 1, 2016, 9:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai

> in addition a lot of dev's make screenshots with oxygen so there is an user 
> group for oxygen.

Really? Got any examples?

> There'a an oxygen repository where the widget style and everything resides, 
> I'd say the Plasma theme would fit in there as well.


Ok, I'll put it there then.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 8:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 8:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/
---

(Updated Feb. 1, 2016, 11:12 nachm.)


Review request for Plasma and KDE Usability.


Bugs: 336124, 348362 and 358536
http://bugs.kde.org/show_bug.cgi?id=336124
http://bugs.kde.org/show_bug.cgi?id=348362
http://bugs.kde.org/show_bug.cgi?id=358536


Repository: plasma-framework


Description
---

This removes the custom label-based triangles and replaces them with proper 
ToolButtons using proper icons. It also adds a "Today" button to return to the 
current day. Also, tooltips that reflect the actual action ("Previous Month", 
"Previous Year", "Previous Decade", depending on the zoom level) were added.


Diffs
-

  src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
  src/declarativeimports/calendar/qml/MonthView.qml c876e3b 

Diff: https://git.reviewboard.kde.org/r/126960/diff/


Testing (updated)
---

Works.

The weekday names look a bit awkward now


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Kai Uwe Broulik]

> On Feb. 1, 2016, 7:39 nachm., Boudhayan Gupta wrote:
> > +1
> > 
> > Ideally the default look-n-feel package should include only two themes - 
> > the default one and a high-contrast counterpart. In fact all other themes 
> > should reside elsewhere.
> > 
> > If we still want to "officially" provide Air and Oxygen, maybe we should 
> > move them to an extra-themes package instead instead of kde-look?
> 
> Martin Klapetek wrote:
> I have no preference as to where it gets moved. Maybe somewhere in git 
> would be better in the end as it would preserve the history.
> 
> Imo if we still want to "officially" ship these two, they need to get 
> some upgrade, cause at least on my hidpi they are kinda broken.

I'd say Light, Dark, and high-contrast which we don't have.

Imho we should turn Air/Oxygen back into their 4.x form since at the moment 
they have quite ugly looking tray icons and Kickoff tabs that were used as a 
testing ground for auto-coloring icons, also Task Manager looks rather borked


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91874
---


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   

Re: Review Request 126957: [FolderView] Show title in tooltip

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126957/#review91901
---


Ship it!




Ship It!

- andreas kainz


On Feb. 1, 2016, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126957/
> ---
> 
> (Updated Feb. 1, 2016, 10:19 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Show the title you would get in the popup also in the tooltip.
> 
> "Folder View" is rather useless when in a panel :)
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
>   containments/desktop/package/contents/ui/main.qml 27e1cc3 
> 
> Diff: https://git.reviewboard.kde.org/r/126957/diff/
> 
> 
> Testing
> ---
> 
> I get "Pictures", or "/home/foo/Pictures", or "Custom Title", or (if "None") 
> the fallback "FolderView"
> 
> For some reason it doesn't update the tooltip when I change the settings.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/63234dfa-36e4-4daf-99ec-014ebb663c2c__Screenshot_20160201_231414.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[andreas kainz]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.

can we add ALL oxygen stuff in one "unmaintained" area?


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

[David Edmundson]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.

Andreas, note the oxygen widget style and plasma theme are different things. 
The Oxygen plasma style is this theme: 
https://www.kde.org/announcements/4.0/screenshots/desktop.jpg

the widget style isn't being touched.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   

Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126961/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

We were mixing KScreen and QScreen API badly.

Corona.cpp checks we are requesting a containment for a valid screen
if (screen >= 0 && screen < numScreens()) {

This fails as numScreens() is Qt API based, whereas the signal we're
adding the output for is ShellCorona::addOutput so we have an effective race 
condition.

BUG: 351777


Diffs
-

  shell/shellcorona.cpp 762e503bf59fe648fb0f5b76a36229aa43c563e5 

Diff: https://git.reviewboard.kde.org/r/126961/diff/


Testing
---

Started Plasma on dual screen.

Ideally we need to do more testing before backporting, as that entire codebase 
is a disgrace.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Bugs - a stricter approach

[David Edmundson]

I am sick of the current distribution of Plasma bug triage/fixing. [1].
I've brought it up many many times in every meeting and no-one has done
anything except talk.

Bugs are the most important part of making a quality product, which is our
ultimate goal. Bug triage and fixing is a crucial part of being a
maintainer. You can't just cherry-pick the fun bits.

So, as discussed in the 5.5 planning meeting;

*From now on, if I see a feature request from a maintainer who hasn't done
their appropriate share of bug work I will block and/or revert their
feature commits. No excuses.*

David Edmundson

[1] https://bugs.kde.org/weekly-bug-summary.cgi?days=100=30

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126946: ShowDesktop is not synchronized

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/#review91909
---


Ship it!




Ship It!

- Sebastian Kügler


On Feb. 1, 2016, 6:24 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126946/
> ---
> 
> (Updated Feb. 1, 2016, 6:24 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Activity pager settings -> Selecting current desktop -> showDesktop. If 
> desktop is showed by clicking on widget, it can be restored by clicking on 
> item in task manager, which lead m_desktopDown to store incorrect state.
> 
> 
> Diffs
> -
> 
>   applets/activitypager/plugin/activitypager.cpp b991bac 
> 
> Diff: https://git.reviewboard.kde.org/r/126946/diff/
> 
> 
> Testing
> ---
> 
> Now works correctly, but i'm affraid about checks
> #if HAVE_X11
> if (!m_isX11) {
> return;
> }
> why the is performed and even why the hell NETRootInfo is used in that way. 
> And NETRootInfo::showingDesktop() about be is hell not working function.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126961/#review91912
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 2, 2016, 12:08 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126961/
> ---
> 
> (Updated Feb. 2, 2016, 12:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> We were mixing KScreen and QScreen API badly.
> 
> Corona.cpp checks we are requesting a containment for a valid screen
> if (screen >= 0 && screen < numScreens()) {
> 
> This fails as numScreens() is Qt API based, whereas the signal we're
> adding the output for is ShellCorona::addOutput so we have an effective race 
> condition.
> 
> BUG: 351777
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 762e503bf59fe648fb0f5b76a36229aa43c563e5 
> 
> Diff: https://git.reviewboard.kde.org/r/126961/diff/
> 
> 
> Testing
> ---
> 
> Started Plasma on dual screen.
> 
> Ideally we need to do more testing before backporting, as that entire 
> codebase is a disgrace.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126956: [Desktop Containment] Remove custom tooltip delegate

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126956/#review91913
---



> I don't see why we would need this.

Eike will be back in 8 days, I guess we should wait for his input on why this 
is needed.

- Martin Klapetek


On Feb. 1, 2016, 10:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126956/
> ---
> 
> (Updated Feb. 1, 2016, 10:23 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Fixes the tooltips being broken for me (not properly resizing, spacing too 
> large etc)
> 
> I don't see why we would need this.
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml c2d7020 
>   containments/desktop/package/contents/ui/FolderItemToolTipDelegate.qml 
> a8b6f44 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
> 
> Diff: https://git.reviewboard.kde.org/r/126956/diff/
> 
> 
> Testing
> ---
> 
> Works. No more glitchy tooltips.
> 
> (I wish the thumbnails in Folder tooltips were bigger, though)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126960/#review91907
---



Nice improvement. If the week numbers look ok then +1 from me.

- Andrew Lake


On Feb. 1, 2016, 11:12 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126960/
> ---
> 
> (Updated Feb. 1, 2016, 11:12 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 336124, 348362 and 358536
> http://bugs.kde.org/show_bug.cgi?id=336124
> http://bugs.kde.org/show_bug.cgi?id=348362
> http://bugs.kde.org/show_bug.cgi?id=358536
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This removes the custom label-based triangles and replaces them with proper 
> ToolButtons using proper icons. It also adds a "Today" button to return to 
> the current day. Also, tooltips that reflect the actual action ("Previous 
> Month", "Previous Year", "Previous Decade", depending on the zoom level) were 
> added.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 3ab16eb 
>   src/declarativeimports/calendar/qml/MonthView.qml c876e3b 
> 
> Diff: https://git.reviewboard.kde.org/r/126960/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> The weekday names look a bit awkward now
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/a065dfcf-ca75-4d50-81aa-4d725245344e__Screenshot_20160201_234605.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 345208] OSD not updating when keeping brightness keys pressed.

[Antonis G . via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345208

Antonis G.  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126957: [FolderView] Show title in tooltip

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126957/#review91900
---


Ship it!




Ship It!

- David Edmundson


On Feb. 1, 2016, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126957/
> ---
> 
> (Updated Feb. 1, 2016, 10:19 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Show the title you would get in the popup also in the tooltip.
> 
> "Folder View" is rather useless when in a panel :)
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderViewLayer.qml 1d470eb 
>   containments/desktop/package/contents/ui/main.qml 27e1cc3 
> 
> Diff: https://git.reviewboard.kde.org/r/126957/diff/
> 
> 
> Testing
> ---
> 
> I get "Pictures", or "/home/foo/Pictures", or "Custom Title", or (if "None") 
> the fallback "FolderView"
> 
> For some reason it doesn't update the tooltip when I change the settings.
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/63234dfa-36e4-4daf-99ec-014ebb663c2c__Screenshot_20160201_231414.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126953: Remove Theme Details KCM

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126953/#review91898
---


Ship it!




+1 from me

would it be possible to change the preview to an rectangular preview like in 
look & feel, splas screen. than the section don't look so bussy and it would 
fit better to the other design KCM's.

- andreas kainz


On Feb. 1, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126953/
> ---
> 
> (Updated Feb. 1, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This removes the theme editor thing in the Desktop Theme KCM.
> 
> Most settings in there are either broken or useless nowadays.
> 
> The only setting I would miss is different Analog Clock faces which could be 
> done in the Analog Clock directly. What I am missing in general is a custom 
> Panel color/texture or something like that which we don't have in here anyway.
> 
> 
> Diffs
> -
> 
>   kcms/desktoptheme/CMakeLists.txt 6168686 
>   kcms/desktoptheme/DesktopTheme.ui f57cdf8 
>   kcms/desktoptheme/DesktopThemeDetails.ui 9df3536 
>   kcms/desktoptheme/desktopthemedetails.h 475d893 
>   kcms/desktoptheme/desktopthemedetails.cpp ce5c856 
>   kcms/desktoptheme/kcm_desktoptheme_debug.h e3363f0 
>   kcms/desktoptheme/kcm_desktoptheme_debug.cpp e09e839 
>   kcms/desktoptheme/kcmdesktoptheme.h ac87862 
>   kcms/desktoptheme/kcmdesktoptheme.cpp 8991990 
>   kcms/desktoptheme/thememodel.cpp bb5bb94 
> 
> Diff: https://git.reviewboard.kde.org/r/126953/diff/
> 
> 
> Testing
> ---
> 
> Tab gone.
> 
> While at it I also replaced the status label with a proper KMessageWidget
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/01/ddff6657-da2d-4fef-8dc1-872588e967b5__simplifiedthemesettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126946: ShowDesktop is not synchronized

[Sebastian Kügler]

> On Feb. 2, 2016, 12:54 a.m., Sebastian Kügler wrote:
> > Ship It!

For bonus points, you could check if there's any X11 usage in the applet 
otherwise, and if not, remove the m_isX11 and HAVE_X11 conditionals. This is 
nicely abstracted in KWindowSystem now, the code there is a bit dated in that 
regard.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/#review91909
---


On Feb. 1, 2016, 6:24 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126946/
> ---
> 
> (Updated Feb. 1, 2016, 6:24 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Activity pager settings -> Selecting current desktop -> showDesktop. If 
> desktop is showed by clicking on widget, it can be restored by clicking on 
> item in task manager, which lead m_desktopDown to store incorrect state.
> 
> 
> Diffs
> -
> 
>   applets/activitypager/plugin/activitypager.cpp b991bac 
> 
> Diff: https://git.reviewboard.kde.org/r/126946/diff/
> 
> 
> Testing
> ---
> 
> Now works correctly, but i'm affraid about checks
> #if HAVE_X11
> if (!m_isX11) {
> return;
> }
> why the is performed and even why the hell NETRootInfo is used in that way. 
> And NETRootInfo::showingDesktop() about be is hell not working function.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126906/
---

(Updated Feb. 1, 2016, 8:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin, Plasma and Eike Hein.


Changes
---

Submitted with commit 22bd8badbf72b19a9c3849e4df3e873c1e2c9c0b by Martin 
Gräßlin to branch master.


Repository: kwin


Description
---

[kwineffects] Expose fullScreen property in EffectWindow
Also copied to Deleted.

[effects] Add a simplified fullscreen blur

If a window is fullscreen and wants fullscreen blur behind it, we
use the blur from logout effect. This is mostly intended for the
Application Dashboard which requires a fullscreen blur. The generic
blur effect is not designed for such usage and is rather costly.

This simplified blur just needs framebuffer blit and midmaps. This
makes it rather cheap in usage and also doesn't need a cached texture.


Diffs
-

  deleted.h bb87ae9611a5b59a5b37cf5a4cd38e99ed987069 
  deleted.cpp 239ba8fec76ad520728182faf6429be8730ebec1 
  effects/blur/blur.h fd5a020688d0e4397ce18e03aa4f79565418e9c5 
  effects/blur/blur.cpp a360f0301e2983d0fb0bf3e71f95ac46ff22 
  libkwineffects/kwineffects.h 4350e2b1c86252af43186164b10ad55fa388266e 
  libkwineffects/kwineffects.cpp b767f6671284295d2e81b023ef62b24fcca8929a 

Diff: https://git.reviewboard.kde.org/r/126906/diff/


Testing
---


File Attachments


Dashboard with new algorithm.
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/27/b6607afa-cf10-4cd8-a490-7b56de4faaec__Spectacle.o12214.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

KActivitiesStats framework for review

[Ivan Čukić]

Hi all,

There is a new framework-to-be under review. Until now, it was used in
plasma (and shipped with plasma, although it was developed in
kactivities repository - strange setup, but we somehow managed). To
avoid collisions, it was previously known under the
KActivitiesExperimentalStats name, and it exported symbols in
KActivities::Experimental::Stats namespace.

The framework allows querying the statistics collected by the
activities system in plasma. It depends only on Qt, KActivities and
KConfig, so it will be a tier2 (KActivities will move to tier1 quite
soon).

https://projects.kde.org/projects/kdereview/kactivities-stats

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126930: sddm theme: Add keyboard layout button

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review91811
---



>Btw, there is a comment saying that password input must be first child to get 
>focus (automatically when login screen is shown?),

That comment is valid and it does do something.
It's about tab order when we enter the buttons area.

I wanted password to always come after the user input bar; so pressing 
shift+tab changes user, tab is back on password. As they are the most important 
elements.

- David Edmundson


On Feb. 1, 2016, 10:17 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> ---
> 
> (Updated Feb. 1, 2016, 10:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> ---
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get 
> focus (automatically when login screen is shown?), but it is not true. It 
> works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual 
> sddm session) even with password input being second child. So, remove the 
> comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126937/#review91833
---


Ship it!




> but the greeter window stayed there no matter what.

because the greeter window is an override redirect. Which means it's not a 
window the window manager manages and thus does not restack on show desktop.

- Martin Gräßlin


On Jan. 31, 2016, 3:58 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126937/
> ---
> 
> (Updated Jan. 31, 2016, 3:58 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> I don't know why this was omitted.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h 3e47f00 
>   src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp a70ce90 
> 
> Diff: https://git.reviewboard.kde.org/r/126937/diff/
> 
> 
> Testing
> ---
> 
> Works.
> 
> I added it to the lockscreen qml in hopes of finding a privacy vulnerability 
> but the greeter window stayed there no matter what. :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126906: Simplified fullscreen blur for Application Dashboard

[Martin Gräßlin]

> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote:
> > effects/blur/blur.cpp, line 474
> > 
> >
> > Did you try the behavior on a varying scene?
> > 
> > Generating mipmaps isn't exactly cheap and linear interpolation suffers 
> > from artifacts when things below move (I had tried an even smarter trick 
> > for general blurring, looks stunning and is incredibly fast ... as long as 
> > you deal with static contents)
> 
> Martin Gräßlin wrote:
> just tried a youtube video + the blur on my Ivybridge system. Didn't 
> notice any problems. That's of course not a scientific measurement ;-)
> 
> Thomas Lübking wrote:
> Harsh contrast changes would cause "flicker" - playing a video would 
> likely be more a CPU/GPU overhead (mipmapping) concern.
> 
> Martin Gräßlin wrote:
> in the given usage scenario (app dashboard) it's rather unlikely that 
> there are contrast changes. After all the set of windows below is supposed to 
> be kind of static.

I'm going to push it to master to expose it more testing. If we get complaints 
about bad effects, we can remove it again.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126906/#review91675
---


On Jan. 27, 2016, 2:24 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126906/
> ---
> 
> (Updated Jan. 27, 2016, 2:24 p.m.)
> 
> 
> Review request for kwin, Plasma and Eike Hein.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> [kwineffects] Expose fullScreen property in EffectWindow
> Also copied to Deleted.
> 
> [effects] Add a simplified fullscreen blur
> 
> If a window is fullscreen and wants fullscreen blur behind it, we
> use the blur from logout effect. This is mostly intended for the
> Application Dashboard which requires a fullscreen blur. The generic
> blur effect is not designed for such usage and is rather costly.
> 
> This simplified blur just needs framebuffer blit and midmaps. This
> makes it rather cheap in usage and also doesn't need a cached texture.
> 
> 
> Diffs
> -
> 
>   deleted.h bb87ae9611a5b59a5b37cf5a4cd38e99ed987069 
>   deleted.cpp 239ba8fec76ad520728182faf6429be8730ebec1 
>   effects/blur/blur.h fd5a020688d0e4397ce18e03aa4f79565418e9c5 
>   effects/blur/blur.cpp a360f0301e2983d0fb0bf3e71f95ac46ff22 
>   libkwineffects/kwineffects.h 4350e2b1c86252af43186164b10ad55fa388266e 
>   libkwineffects/kwineffects.cpp b767f6671284295d2e81b023ef62b24fcca8929a 
> 
> Diff: https://git.reviewboard.kde.org/r/126906/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Dashboard with new algorithm.
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/27/b6607afa-cf10-4cd8-a490-7b56de4faaec__Spectacle.o12214.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/
---

(Updated Feb. 1, 2016, 11:06 vorm.)


Status
--

This change has been discarded.


Review request for Plasma, KDE Usability and Andrew Lake.


Bugs: 350705
https://bugs.kde.org/show_bug.cgi?id=350705


Repository: plasma-desktop


Description
---

I just found this patch I made a while ago. This turns the handmade close 
button into a regular ToolButton (which is only shown when hovering) with a 
proper size. Also, the button is always in the top right corner of the 
*thumbnail* rather than the dialog


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125793/diff/


Testing
---

Works.


File Attachments


New close button
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/
---

Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Displaying layout variant makes the button too big.


Diffs
-

  lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 

Diff: https://git.reviewboard.kde.org/r/126942/diff/


Testing
---

"de(nodeadkeys)" is now just "de"

Might be good idea to show full name in tooltip, but `tooltip: "str"` has no 
effect.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91839
---



That would give me "de" and "de" for "de(nodeadkeys)" and "de(neo)"

- Kai Uwe Broulik


On Feb. 1, 2016, 11:08 vorm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> ---
> 
> (Updated Feb. 1, 2016, 11:08 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Displaying layout variant makes the button too big.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
> 
> 
> Testing
> ---
> 
> "de(nodeadkeys)" is now just "de"
> 
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no 
> effect.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D884: Async variant to check whether power management is inhibited

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Not really happy with 3rd party using InhibitionsChanged signal because I 
find it quite horrible in retrospect, and will probably need to change it for 
our future Inhibitions plasmoid but we can still adjust here when we get this 
far.

INLINE COMMENTS
  powermanagement_inhibition.cpp:99 InterruptSession is "suspend", I think we 
still want the screen to lock while listening to music where only change screen 
settings would be set

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  async-check-fdo-inhibition

REVISION DETAIL
  https://phabricator.kde.org/D884

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126143/
---

(Updated Feb. 1, 2016, 11:04 vorm.)


Status
--

This change has been discarded.


Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

In case the UserSwitcher.qml file is missing or broken, let's fall back to use 
KRunner's session runner.


Diffs
-

  ksmserver/server.cpp 9477e54 
  ksmserver/switchuserdialog.cpp 26d6710 

Diff: https://git.reviewboard.kde.org/r/126143/diff/


Testing
---

Broke my UserSwitcher.qml file, got KRunner instead.
Fixed it, got the proper QML UI again.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

[David Rosca]

> On Feb. 1, 2016, 11:10 a.m., Kai Uwe Broulik wrote:
> > That would give me "de" and "de" for "de(nodeadkeys)" and "de(neo)"

Hm, that's true. So it won't be that easy and will need to modify 
`org.kde.keyboard` api.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91839
---


On Feb. 1, 2016, 11:08 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> ---
> 
> (Updated Feb. 1, 2016, 11:08 a.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Displaying layout variant makes the button too big.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
> 
> 
> Testing
> ---
> 
> "de(nodeadkeys)" is now just "de"
> 
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no 
> effect.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91843
---



>  but tooltip: "str" has no effect.

That's because kscreenlocker_greet is a QGuiApplication and QToolTip used by 
QtQuick.Controls requires QApplication

- Kai Uwe Broulik


On Feb. 1, 2016, 11:14 vorm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> ---
> 
> (Updated Feb. 1, 2016, 11:14 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Displaying layout variant makes the button too big.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
> 
> 
> Testing
> ---
> 
> "de(nodeadkeys)" is now just "de"
> 
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no 
> effect.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/#review91844
---



Would it make sense to mark the applet ConfigView transient to the DesktopView?

- Kai Uwe Broulik


On Jan. 31, 2016, 2:51 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126938/
> ---
> 
> (Updated Jan. 31, 2016, 2:51 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 327530
> https://bugs.kde.org/show_bug.cgi?id=327530
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When starting to drag a widget, show desktop mode is enabled causing all 
> windows but the widget explorer to disappear.
> 
> Windows are only restored when widget explorer closes, not as soon as you 
> drop it, so you can see where you dropped the widget and configure it right 
> away also.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 
> 
> Diff: https://git.reviewboard.kde.org/r/126938/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer from my panel, started dragging a widget, windows 
> disappeared, dropped on desktop, closed widget explorer, windows re-appeared.
> 
> There's a glitch when you drop a widget and then open its config dialog, 
> widget explorer does not automatically hide thus keeping show desktop enabled 
> and the config dialog disappears immediately after it was shown.
> 
> I guess this is because hide on window deactivate in Dialog checks for 
> whether I tapped a containment, which I did, and then keeps the dialog open.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/
---

(Updated Feb. 1, 2016, 11:14 a.m.)


Status
--

This change has been discarded.


Review request for Plasma and Kai Uwe Broulik.


Repository: plasma-workspace


Description
---

Displaying layout variant makes the button too big.


Diffs
-

  lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 

Diff: https://git.reviewboard.kde.org/r/126942/diff/


Testing
---

"de(nodeadkeys)" is now just "de"

Might be good idea to show full name in tooltip, but `tooltip: "str"` has no 
effect.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/#review91846
---


Ship it!




Ship It!

- Marco Martin


On Feb. 1, 2016, 11:36 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126938/
> ---
> 
> (Updated Feb. 1, 2016, 11:36 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 327530
> https://bugs.kde.org/show_bug.cgi?id=327530
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When starting to drag a widget, show desktop mode is enabled causing all 
> windows but the widget explorer to disappear.
> 
> Windows are only restored when widget explorer closes, not as soon as you 
> drop it, so you can see where you dropped the widget and configure it right 
> away also.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 
> 
> Diff: https://git.reviewboard.kde.org/r/126938/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer from my panel, started dragging a widget, windows 
> disappeared, dropped on desktop, closed widget explorer, windows re-appeared.
> 
> There's a glitch when you drop a widget and then open its config dialog, 
> widget explorer does not automatically hide thus keeping show desktop enabled 
> and the config dialog disappears immediately after it was shown.
> 
> I guess this is because hide on window deactivate in Dialog checks for 
> whether I tapped a containment, which I did, and then keeps the dialog open.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Marco Martin]

> On Feb. 1, 2016, 11:36 a.m., Kai Uwe Broulik wrote:
> > Would it make sense to mark the applet ConfigView transient to the 
> > DesktopView?

yes


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/#review91844
---


On Feb. 1, 2016, 11:36 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126938/
> ---
> 
> (Updated Feb. 1, 2016, 11:36 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 327530
> https://bugs.kde.org/show_bug.cgi?id=327530
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When starting to drag a widget, show desktop mode is enabled causing all 
> windows but the widget explorer to disappear.
> 
> Windows are only restored when widget explorer closes, not as soon as you 
> drop it, so you can see where you dropped the widget and configure it right 
> away also.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 
> 
> Diff: https://git.reviewboard.kde.org/r/126938/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer from my panel, started dragging a widget, windows 
> disappeared, dropped on desktop, closed widget explorer, windows re-appeared.
> 
> There's a glitch when you drop a widget and then open its config dialog, 
> widget explorer does not automatically hide thus keeping show desktop enabled 
> and the config dialog disappears immediately after it was shown.
> 
> I guess this is because hide on window deactivate in Dialog checks for 
> whether I tapped a containment, which I did, and then keeps the dialog open.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/
---

(Updated Feb. 1, 2016, 2:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 39327c21b8b51d3b29f7a01f58200dcf8f5d99bd by David Rosca 
to branch master.


Repository: plasma-workspace


Description
---

Use display name (can be changed by user) instead of full layout name.
This matches the behavior of keyboard layout osd and systray.


Diffs
-

  components/keyboardlayout/keyboardlayout.h e5a172e 
  components/keyboardlayout/keyboardlayout.cpp 3e456ca 
  lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 

Diff: https://git.reviewboard.kde.org/r/126944/diff/


Testing
---

Changed the display name in kcm ("label" column), lockscreen displayed this 
name.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/
---

(Updated Feb. 1, 2016, 3:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Martin Gräßlin.


Changes
---

Submitted with commit 1aab04cec1c479d68171216b877d1b91a7af5adc by Kai Uwe 
Broulik to branch master.


Bugs: 327530
https://bugs.kde.org/show_bug.cgi?id=327530


Repository: plasma-desktop


Description
---

When starting to drag a widget, show desktop mode is enabled causing all 
windows but the widget explorer to disappear.

Windows are only restored when widget explorer closes, not as soon as you drop 
it, so you can see where you dropped the widget and configure it right away 
also.


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
  desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 

Diff: https://git.reviewboard.kde.org/r/126938/diff/


Testing
---

Opened widget explorer from my panel, started dragging a widget, windows 
disappeared, dropped on desktop, closed widget explorer, windows re-appeared.

There's a glitch when you drop a widget and then open its config dialog, widget 
explorer does not automatically hide thus keeping show desktop enabled and the 
config dialog disappears immediately after it was shown.

I guess this is because hide on window deactivate in Dialog checks for whether 
I tapped a containment, which I did, and then keeps the dialog open.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126930: sddm theme: Add keyboard layout button

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review91835
---



+1

If you're at it, could you perhaps have a look at the code that generates the 
label? :) In system tray and OSD it says "neo" and "de" for me whereas the 
lockscreen says "de(nodeadkeys)" which makes the button super huge and ugly.


lookandfeel/contents/loginmanager/Main.qml (line 128)


This id is unused



lookandfeel/contents/loginmanager/Main.qml (line 129)


I think it does that by default in QtQuick.Controls



lookandfeel/contents/loginmanager/dummydata/keyboard.qml (lines 9 - 12)


You can do that in the property directly:

property var layouts: [
{ shortName: "us", longName: "English" }
...
]


- Kai Uwe Broulik


On Jan. 30, 2016, 10:59 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> ---
> 
> (Updated Jan. 30, 2016, 10:59 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> ---
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get 
> focus (automatically when login screen is shown?), but it is not true. It 
> works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual 
> sddm session) even with password input being second child. So, remove the 
> comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126930: sddm theme: Add keyboard layout button

[David Rosca]

> On Feb. 1, 2016, 9:45 a.m., Kai Uwe Broulik wrote:
> > +1
> > 
> > If you're at it, could you perhaps have a look at the code that generates 
> > the label? :) In system tray and OSD it says "neo" and "de" for me whereas 
> > the lockscreen says "de(nodeadkeys)" which makes the button super huge and 
> > ugly.

Wait, in lockscreen or in sddm?

Can you please paste output of `setxkbmap -print`?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review91835
---


On Jan. 30, 2016, 10:59 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> ---
> 
> (Updated Jan. 30, 2016, 10:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> ---
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get 
> focus (automatically when login screen is shown?), but it is not true. It 
> works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual 
> sddm session) even with password input being second child. So, remove the 
> comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126937/
---

(Updated Feb. 1, 2016, 10:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 8ea478dbcc3349dd421ac64fc5263801d6859185 by Kai Uwe 
Broulik to branch master.


Repository: kdeclarative


Description
---

I don't know why this was omitted.


Diffs
-

  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h 3e47f00 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp a70ce90 

Diff: https://git.reviewboard.kde.org/r/126937/diff/


Testing
---

Works.

I added it to the lockscreen qml in hopes of finding a privacy vulnerability 
but the greeter window stayed there no matter what. :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358859] New: Screen not always locked when lid closed

[Olivier Churlaud via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358859

Bug ID: 358859
   Summary: Screen not always locked when lid closed
   Product: Powerdevil
   Version: 5.5.4
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: oliv...@churlaud.com

When I close the lid of my computer, it's quite often that when I open it I
don't need to type my password.

The network takes some seconds to reconnect, which means that is was suspended. 

Of course in the settings I said: lock screen on suspend. It however doesn't
always happen.

=> Security issue: so I raise the severity to major.

I don't know how to debug further...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358859] Screen not always locked when lid closed

[Olivier Churlaud via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358859

--- Comment #1 from Olivier Churlaud  ---
next time it happens I'll send the journalctl concerned part..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[kscreenlocker] [Bug 358859] Screen not always locked when lid closed

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358859

Martin Gräßlin  changed:

   What|Removed |Added

Product|Powerdevil  |kscreenlocker
Version|5.5.4   |unspecified
 CC||bhus...@gmail.com,
   ||mgraess...@kde.org
   Assignee|plasma-devel@kde.org|plasma-b...@kde.org
  Component|general |general

--- Comment #2 from Martin Gräßlin  ---
Are you using logind?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

[Olivier Churlaud via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349750

Olivier Churlaud  changed:

   What|Removed |Added

 CC||oliv...@churlaud.com

--- Comment #2 from Olivier Churlaud  ---
Created attachment 96950
  --> https://bugs.kde.org/attachment.cgi?id=96950=edit
dump of the interesting part of journalctl

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 358859] Screen not always locked when lid closed

[Olivier Churlaud via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=358859

Olivier Churlaud  changed:

   What|Removed |Added

   Platform|Other   |Archlinux Packages

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 349750] Laptop does not suspend when lid closed in lock screen

[Olivier Churlaud via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=349750

--- Comment #3 from Olivier Churlaud  ---
Oups wrong thread...  please forget this last one...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126930: sddm theme: Add keyboard layout button

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/
---

(Updated Feb. 1, 2016, 10:17 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Show keyboard layout button in sddm theme, same as in lock screen.


Diffs (updated)
-

  lookandfeel/contents/loginmanager/Main.qml 1bbefec 
  lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126930/diff/


Testing
---

Looks & works exactly the same as in lock screen.

Btw, there is a comment saying that password input must be first child to get 
focus (automatically when login screen is shown?), but it is not true. It works 
fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm 
session) even with password input being second child. So, remove the comment?


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126949: Remove Air and Oxygen themes

[Hugo Pereira Da Costa]

> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote:
> > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the 
> > time I need the plasma oxygen theme too to give the user the one single 
> > click feature (look & feel package). Is there an space where you can move 
> > "unmaintained" stuff and the distros can choose what they want to ship. now 
> > all distros ship oxygen.
> > 
> > I love breeze but oxygen is also really sexy in addition a lot of uers work 
> > with kde4 (which is unmainted too) and update to kf5 with Kubuntu 16.04 
> > LTS. It would be bad to support oxygen for an additional LTS cycle, but for 
> > the switch it would be nice to give the user the posibility for an soft 
> > switch.
> 
> andreas kainz wrote:
> in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Kai Uwe Broulik wrote:
> There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> andreas kainz wrote:
> ok. that would fit for me. since now we have not that much look and feel 
> packages most distros use it for there look and feel stuff and than breeze 
> and breeze-dark for people how don't like monochrome (there are a lot) is 
> oxygen. it would be nice to have more packages there available so move the 
> oxygen stuff in an spacific area is fine for me but don't move them to 
> kde-look cause than oxygen is more broken than now and no one can fix it any 
> more.
> 
> thanks Kai
> 
> Martin Klapetek wrote:
> > in addition a lot of dev's make screenshots with oxygen so there is an 
> user group for oxygen.
> 
> Really? Got any examples?
> 
> > There'a an oxygen repository where the widget style and everything 
> resides, I'd say the Plasma theme would fit in there as well.
> 
> 
> Ok, I'll put it there then.
> 
> David Edmundson wrote:
> Andreas, note the oxygen widget style and plasma theme are different 
> things. 
> The Oxygen plasma style is this theme: 
> https://www.kde.org/announcements/4.0/screenshots/desktop.jpg
> 
> the widget style isn't being touched.
> 
> andreas kainz wrote:
> can we add ALL oxygen stuff in one "unmaintained" area?

Wait wait, neither oxygen widget style nor window decoration are unmaintained. 
(nor broken as far as I know)
They are in "maintenance" mode on the contrary. Meaning: they are "done", there 
won't be any new feature, but bugs get fixed when reported. 
Please 
- dont move them anywhere else,
- dont move broken, nor truely unmaintained things in there.
This is not a trash can :)

Thx,

Hugo


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91883
---


On Feb. 1, 2016, 7:30 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   

Re: Review Request 126949: Remove Air and Oxygen themes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126949/#review91876
---



+1

- Kai Uwe Broulik


On Feb. 1, 2016, 7:30 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126949/
> ---
> 
> (Updated Feb. 1, 2016, 7:30 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 358533
> http://bugs.kde.org/show_bug.cgi?id=358533
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> They are untested, unmaintained and most importantly, broken.
> 
> Let's remove them from our releases and move them to kde-look.org for grabs.
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/air/CMakeLists.txt 40ea382 
>   src/desktoptheme/air/colors 5c4e53d 
>   src/desktoptheme/air/dialogs/background.svgz 81ef460 
>   src/desktoptheme/air/dialogs/kickoff.svgz 40e2ae6 
>   src/desktoptheme/air/dialogs/krunner.svgz 1f6a64f 
>   src/desktoptheme/air/icons/amarok.svgz e3c157e 
>   src/desktoptheme/air/icons/audio.svgz 540cc77 
>   src/desktoptheme/air/icons/battery.svgz 88f864e 
>   src/desktoptheme/air/icons/configure.svgz a433b3c 
>   src/desktoptheme/air/icons/device.svgz 23df094 
>   src/desktoptheme/air/icons/document.svgz 6e89dd8 
>   src/desktoptheme/air/icons/edit.svgz d0e1ca4 
>   src/desktoptheme/air/icons/go.svgz ad3a4b2 
>   src/desktoptheme/air/icons/kget.svgz 1f1702f 
>   src/desktoptheme/air/icons/klipper.svgz 4afd33c 
>   src/desktoptheme/air/icons/konv_message.svgz 10e31cd 
>   src/desktoptheme/air/icons/konversation.svgz 376211a 
>   src/desktoptheme/air/icons/kopete.svgz 5f41c4c 
>   src/desktoptheme/air/icons/korgac.svgz 8c8f700 
>   src/desktoptheme/air/icons/kpackagekit.svgz 234e6da 
>   src/desktoptheme/air/icons/ktorrent.svgz dc623d8 
>   src/desktoptheme/air/icons/list.svgz 0a25bb0 
>   src/desktoptheme/air/icons/media.svgz 23653bd 
>   src/desktoptheme/air/icons/nepomuk.svgz 5c8545e 
>   src/desktoptheme/air/icons/network.svgz a8e8b16 
>   src/desktoptheme/air/icons/notification.svgz db12260 
>   src/desktoptheme/air/icons/preferences.svgz 12e6588 
>   src/desktoptheme/air/icons/printer.svgz 199ab95 
>   src/desktoptheme/air/icons/quassel.svgz b004749 
>   src/desktoptheme/air/icons/slc.svgz 9fd376b 
>   src/desktoptheme/air/icons/wallet.svgz 4ad3691 
>   src/desktoptheme/air/icons/window.svgz eecc37f 
>   src/desktoptheme/air/icons/zoom.svgz c159491 
>   src/desktoptheme/air/metadata.desktop 0be4bd5 
>   src/desktoptheme/air/opaque/dialogs/background.svgz d2329ff 
>   src/desktoptheme/air/opaque/dialogs/krunner.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/extender-background.svgz e810ba4 
>   src/desktoptheme/air/opaque/widgets/panel-background.svgz 2a2134f 
>   src/desktoptheme/air/opaque/widgets/tooltip.svgz 2a2134f 
>   src/desktoptheme/air/translucent/dialogs/background.svgz 9b68062 
>   src/desktoptheme/air/translucent/dialogs/krunner.svgz 4c48b52 
>   src/desktoptheme/air/translucent/widgets/extender-background.svgz 799e798 
>   src/desktoptheme/air/translucent/widgets/panel-background.svgz 7783e3b 
>   src/desktoptheme/air/translucent/widgets/tooltip.svgz 7783e3b 
>   src/desktoptheme/air/widgets/action-overlays.svgz 4259105 
>   src/desktoptheme/air/widgets/actionbutton.svgz e1713ea 
>   src/desktoptheme/air/widgets/analog_meter.svgz f0d2163 
>   src/desktoptheme/air/widgets/arrows.svgz b987b32 
>   src/desktoptheme/air/widgets/background.svgz 174a8fc 
>   src/desktoptheme/air/widgets/bar_meter_horizontal.svgz 8031b77 
>   src/desktoptheme/air/widgets/bar_meter_vertical.svgz 1b0660d 
>   src/desktoptheme/air/widgets/branding.svgz c6316fb 
>   src/desktoptheme/air/widgets/busywidget.svgz f638cfb 
>   src/desktoptheme/air/widgets/button.svgz 2c529bf 
>   src/desktoptheme/air/widgets/calendar.svgz 2d80a49 
>   src/desktoptheme/air/widgets/checkmarks.svgz dcf2924 
>   src/desktoptheme/air/widgets/clock.svgz 3839dac 
>   src/desktoptheme/air/widgets/configuration-icons.svgz 9b212d3 
>   src/desktoptheme/air/widgets/containment-controls.svgz a3166ce 
>   src/desktoptheme/air/widgets/dragger.svgz 3629591 
>   src/desktoptheme/air/widgets/extender-background.svgz 4003079 
>   src/desktoptheme/air/widgets/extender-dragger.svgz 5bf3e0f 
>   src/desktoptheme/air/widgets/frame.svgz 327c284 
>   src/desktoptheme/air/widgets/glowbar.svgz 4a8a464 
>   src/desktoptheme/air/widgets/identiconshapes.svgz 67fe725 
>   src/desktoptheme/air/widgets/identicontheme.svgz ad881cd 
>   src/desktoptheme/air/widgets/labeltexture.svgz f52a78d 
>   src/desktoptheme/air/widgets/line.svgz 70efca4 
>   src/desktoptheme/air/widgets/lineedit.svgz 22347db 
>   src/desktoptheme/air/widgets/listitem.svgz ec7e89a 
>   

Re: Review Request 126947: [Shell] Make Applet/ContainmentConfig transient for DesktopView

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126947/#review91870
---


Ship it!




Ship It!

- David Edmundson


On Feb. 1, 2016, 6:33 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126947/
> ---
> 
> (Updated Feb. 1, 2016, 6:33 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Prevents them from being hidden by show desktop.
> 
> They're for configuring things on the desktop, so this makes sense. Also 
> allows to configure an applet when it has been dropped from Widget Explorer 
> which enters show desktop mode.
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp bc40083 
> 
> Diff: https://git.reviewboard.kde.org/r/126947/diff/
> 
> 
> Testing
> ---
> 
> Dragged widget from Widget Explorer and successfully configured it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126938: [Widget Explorer] Show desktop on dragging widget

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126938/#review91848
---



Yup, makes sense!

- Thomas Pfeiffer


On Feb. 1, 2016, 11:36 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126938/
> ---
> 
> (Updated Feb. 1, 2016, 11:36 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Bugs: 327530
> https://bugs.kde.org/show_bug.cgi?id=327530
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> When starting to drag a widget, show desktop mode is enabled causing all 
> windows but the widget explorer to disappear.
> 
> Windows are only restored when widget explorer closes, not as soon as you 
> drop it, so you can see where you dropped the widget and configure it right 
> away also.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml c315b4c 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 90e84d3 
> 
> Diff: https://git.reviewboard.kde.org/r/126938/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer from my panel, started dragging a widget, windows 
> disappeared, dropped on desktop, closed widget explorer, windows re-appeared.
> 
> There's a glitch when you drop a widget and then open its config dialog, 
> widget explorer does not automatically hide thus keeping show desktop enabled 
> and the config dialog disappears immediately after it was shown.
> 
> I guess this is because hide on window deactivate in Dialog checks for 
> whether I tapped a containment, which I did, and then keeps the dialog open.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Use display name (can be changed by user) instead of full layout name.
This matches the behavior of keyboard layout osd and systray.


Diffs
-

  components/keyboardlayout/keyboardlayout.h e5a172e 
  components/keyboardlayout/keyboardlayout.cpp 3e456ca 
  lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 

Diff: https://git.reviewboard.kde.org/r/126944/diff/


Testing
---

Changed the display name in kcm ("label" column), lockscreen displayed this 
name.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126943/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

^


Diffs
-

  kcms/keyboard/keyboard_daemon.h 1ba6f32 
  kcms/keyboard/keyboard_daemon.cpp 1a09a92 

Diff: https://git.reviewboard.kde.org/r/126943/diff/


Testing
---


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/#review91849
---



+1


components/keyboardlayout/keyboardlayout.cpp (lines 85 - 87)


can be simplified to:

QDBusPendingCall pendingDisplayName = 
mIface->asyncCallWithArgumentList(QStringLiteral("getLayoutDisplayName"), 
{mCurrentLayout});



components/keyboardlayout/keyboardlayout.cpp (line 92)


You can use a lambda


- Kai Uwe Broulik


On Feb. 1, 2016, 12:58 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126944/
> ---
> 
> (Updated Feb. 1, 2016, 12:58 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Use display name (can be changed by user) instead of full layout name.
> This matches the behavior of keyboard layout osd and systray.
> 
> 
> Diffs
> -
> 
>   components/keyboardlayout/keyboardlayout.h e5a172e 
>   components/keyboardlayout/keyboardlayout.cpp 3e456ca 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126944/diff/
> 
> 
> Testing
> ---
> 
> Changed the display name in kcm ("label" column), lockscreen displayed this 
> name.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/
---

(Updated Feb. 1, 2016, 1:16 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Use display name (can be changed by user) instead of full layout name.
This matches the behavior of keyboard layout osd and systray.


Diffs (updated)
-

  components/keyboardlayout/keyboardlayout.h e5a172e 
  components/keyboardlayout/keyboardlayout.cpp 3e456ca 
  lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 

Diff: https://git.reviewboard.kde.org/r/126944/diff/


Testing
---

Changed the display name in kcm ("label" column), lockscreen displayed this 
name.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[David Rosca]

> On Feb. 1, 2016, 1:12 p.m., Kai Uwe Broulik wrote:
> > components/keyboardlayout/keyboardlayout.cpp, line 92
> > 
> >
> > You can use a lambda

The rest of the file is using slots, so I went with slot too.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/#review91849
---


On Feb. 1, 2016, 1:16 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126944/
> ---
> 
> (Updated Feb. 1, 2016, 1:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Use display name (can be changed by user) instead of full layout name.
> This matches the behavior of keyboard layout osd and systray.
> 
> 
> Diffs
> -
> 
>   components/keyboardlayout/keyboardlayout.h e5a172e 
>   components/keyboardlayout/keyboardlayout.cpp 3e456ca 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126944/diff/
> 
> 
> Testing
> ---
> 
> Changed the display name in kcm ("label" column), lockscreen displayed this 
> name.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126943/#review91851
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Feb. 1, 2016, 12:58 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126943/
> ---
> 
> (Updated Feb. 1, 2016, 12:58 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> ^
> 
> 
> Diffs
> -
> 
>   kcms/keyboard/keyboard_daemon.h 1ba6f32 
>   kcms/keyboard/keyboard_daemon.cpp 1a09a92 
> 
> Diff: https://git.reviewboard.kde.org/r/126943/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126944/#review91852
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Feb. 1, 2016, 1:16 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126944/
> ---
> 
> (Updated Feb. 1, 2016, 1:16 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Use display name (can be changed by user) instead of full layout name.
> This matches the behavior of keyboard layout osd and systray.
> 
> 
> Diffs
> -
> 
>   components/keyboardlayout/keyboardlayout.h e5a172e 
>   components/keyboardlayout/keyboardlayout.cpp 3e456ca 
>   lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126944/diff/
> 
> 
> Testing
> ---
> 
> Changed the display name in kcm ("label" column), lockscreen displayed this 
> name.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126943: Add getLayoutDisplayName to keyboard layouts DBus API

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126943/
---

(Updated Feb. 1, 2016, 1:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ef79414c794c7343ed09d3714c741e3a080db71b by David Rosca 
to branch master.


Repository: plasma-desktop


Description
---

^


Diffs
-

  kcms/keyboard/keyboard_daemon.h 1ba6f32 
  kcms/keyboard/keyboard_daemon.cpp 1a09a92 

Diff: https://git.reviewboard.kde.org/r/126943/diff/


Testing
---


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D884: Async variant to check whether power management is inhibited

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKER4e9dce5f0e07: Async variant to check whether 
power management is inhibited (authored by graesslin).

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D884?vs=2139=2165

REVISION DETAIL
  https://phabricator.kde.org/D884

AFFECTED FILES
  CMakeLists.txt
  ksldapp.cpp
  ksldapp.h
  powermanagement_inhibition.cpp
  powermanagement_inhibition.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, bshah, broulik
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel