Re: Review Request 125755: Fix build with QT5.6

[David Kahles]

> On Oct. 22, 2015, 1:38 p.m., Martin Gräßlin wrote:
> > src/CMakeLists.txt, line 7
> > 
> >
> > is KWindowSystem being found at all in sddm-kcm?

Sorry for the late reply, I was very busy over the last moths.
I just noticed that the build works fine again with an up-to-date qt build. I 
don't remember the exact problem, but if it works fine now, i think this isn't 
needed anymore.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125755/#review87258
---


On Oct. 22, 2015, 1:20 p.m., David Kahles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125755/
> ---
> 
> (Updated Oct. 22, 2015, 1:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> Since QT5.6, qpixmap.h pulls in qtextstream.h. Xlib.h has a
> but qtextstream.h uses Status as an enum name. fixx11h.h resolves this
> name clash.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
>   src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 
> 
> Diff: https://git.reviewboard.kde.org/r/125755/diff/
> 
> 
> Testing
> ---
> 
> Compiles now.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG approved widgets

[kainz.a]

Good stuff sebras. I would also thinking about how should be the quality
standards are defined?

VDG usability and design
PLasma additional code review, signing, ...
User feedback something like at least an post on the planet or something
like that.

And what the dev get from plasma? An quality sign and the feedback that
Distros can / should ship them that the user get the plasma experience.

Andreas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127337: [libksysguard] Don't call into QX11Info::connection() on wayland

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127337/
---

Review request for Plasma and Martin Gräßlin.


Repository: libksysguard


Description
---

Blows up otherwise


Diffs
-

  processui/ProcessModel.cpp 7a65104 

Diff: https://git.reviewboard.kde.org/r/127337/diff/


Testing
---

Ctrl+Esc and we now have a beautiful task list \o/

(Disregard the other optimization, middle click paste apparently didnt work so 
I just git diff'd everything :)


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1113: New Desktop Theme KCM

[drosca (David Rosca)]

drosca added a comment.


  F94789: kcm_desktoptheme.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1113

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 819 lines] D1113: New Desktop Theme KCM

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  New Desktop Theme KCM
  It is in new directory (desktoptheme-qml) for easier review.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D1113

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/desktoptheme-qml/CMakeLists.txt
  kcms/desktoptheme-qml/Messages.sh
  kcms/desktoptheme-qml/kcm.cpp
  kcms/desktoptheme-qml/kcm.h
  kcms/desktoptheme-qml/kcm_desktoptheme.desktop
  kcms/desktoptheme-qml/package/contents/ui/Hand.qml
  kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme-qml/package/contents/ui/main.qml
  kcms/desktoptheme-qml/package/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 10 Mar 2016 17:54:28 +
Build duration: 1 min 36 sec

CHANGE SET
Revision fce16a6e4c2848ac681c4ab5f6f25936a80e02dc by kde: ([KRunner] Fix keep 
above)
  change: edit krunner/view.cpp
Revision 96ff1c868e3cd6fa359b9830016e857fcda7e4ae by aleixpol: (Properly define 
overrides as suggested by the c++ standard)
  change: edit kioslave/applications/kio_applications.cpp
  change: edit applets/systemtray/plugin/host.h
  change: edit runners/calculator/calculatorrunner.h
  change: edit dataengines/mpris2/playeractionjob.h
  change: edit dataengines/filebrowser/filebrowserengine.h
  change: edit dataengines/apps/appsource.h
  change: edit components/shellprivate/widgetexplorer/widgetexplorer.h
  change: edit dataengines/weather/ions/envcan/ion_envcan.h
  change: edit shell/plasmaquick/configview.h
  change: edit drkonqi/parser/backtraceparsernull.h
  change: edit dataengines/systemmonitor/systemmonitor.h
  change: edit drkonqi/bugzillaintegration/reportassistantdialog.h
  change: edit components/sessionsprivate/sessionsprivateplugin.h
  change: edit xembed-sni-proxy/fdoselectionmanager.h
  change: edit dataengines/tasks/taskjob.h
  change: edit drkonqi/drkonqibackends.h
  change: edit applets/digital-clock/plugin/timezonemodel.h
  change: edit 
components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels_p.h
  change: edit applets/systemtray/tests/statusnotifier/statusnotifiertest.h
  change: edit applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h
  change: edit drkonqi/aboutbugreportingdialog.h
  change: edit wallpapers/image/image.h
  change: edit dataengines/statusnotifieritem/statusnotifieritemservice.h
  change: edit 
applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h
  change: edit dataengines/packagekit/packagekitengine.h
  change: edit drkonqi/drkonqidialog.h
  change: edit dataengines/favicons/faviconprovider.h
  change: edit shell/scripting/containment.h
  change: edit klipper/klipperpopup.h
  change: edit dataengines/soliddevice/soliddevicejob.h
  change: edit ktimezoned/ktimezonedbase.h
  change: edit shell/plasmaquick/containmentview.h
  change: edit klipper/history.h
  change: edit containmentactions/contextmenu/menu.h
  change: edit runners/places/placesrunner.h
  change: edit dataengines/powermanagement/powermanagementservice.h
  change: edit kuiserver/tests/kuiservertest.h
  change: edit drkonqi/parser/backtraceparsergdb.h
  change: edit phonon/platform_kde/kdeplatformplugin.h
  change: edit ksplash/ksplashqml/splashapp.h
  change: edit shell/desktopview.h
  change: edit shell/containmentconfigview.h
  change: edit dataengines/packagekit/packagekitjob.h
  change: edit libtaskmanager/taskmanager.h
  change: edit dataengines/favicons/favicons.h
  change: edit runners/services/servicerunner.h
  change: edit statusnotifierwatcher/statusnotifierwatcher.h
  change: edit dataengines/statusnotifieritem/statusnotifieritem_engine.h
  change: edit dataengines/tasks/taskwindowservice.h
  change: edit xembed-sni-proxy/sniproxy.h
  change: edit dataengines/keystate/keystate.h
  change: edit components/shellprivate/interactiveconsole/interactiveconsole.h
  change: edit shell/scripting/configgroup.h
  change: edit ksplash/ksplashqml/splashwindow.h
  change: edit klipper/clipboardjob.h
  change: edit kuiserver/progresslistmodel.h
  change: edit dataengines/devicenotifications/devicenotificationsengine.h
  change: edit libtaskmanager/abstractgroupableitem.h
  change: edit plasma-windowed/plasmaquick/view.h
  change: edit runners/bookmarks/fetchsqlite.h
  change: edit dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  change: edit wallpapers/image/imageplugin.h
  change: edit appmenu/appmenu_dbus.h
  change: edit dataengines/keystate/keyservice.h
  change: edit plasma-windowed/plasmawindowedcorona.h
  change: edit dataengines/time/timeengine.h
  change: edit klipper/clipboardengine.h
  change: edit ktimezoned/ktimezoned.h
  change: edit shell/scripting/scriptengine.h
  change: edit runners/bookmarks/browsers/kdebrowser.h
  change: edit runners/webshortcuts/webshortcutrunner.h
  change: edit applets/systemtray/plugin/tasksproxymodel.h
  change: edit dataengines/apps/appservice.h
  change: edit runners/kill/killrunner.h
  change: edit kuiserver/jobview.h
  change: edit dataengines/tasks/tasksengine.h
  change: edit dataengines/powermanagement/powermanagementengine.h
  change: edit dataengines/dict/dictengine.h
  change: edit dataengines/places/placesengine.h
  change: edit systemmonitor/kdedksysguard.h
  change: edit dataengines/places/placesproxymodel.h
  change: edit runners/recentdocuments/recentdocuments.h
  change: edit drkonqi/backtraceratingwidget.h
  change: edit drkonqi/bugzillaintegration/duplicatefinderjob.h
  change: edit dataengines/activities/activityjob.h
 

[Differential] [Closed] D947: Fix path of kcheckpass when pass to chown

[kfunk (Kevin Funk)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREENLOCKERfcfeae0cf4d6: Fix path of kcheckpass when 
passing it to chown (authored by kfunk).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D947?vs=2307=2676#toc

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D947?vs=2307=2676

REVISION DETAIL
  https://phabricator.kde.org/D947

AFFECTED FILES
  kcheckpass/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 10 Mar 2016 12:47:23 +
Build duration: 50 sec

CHANGE SET
Revision 8244b2675e5461583aa1972c6c32ca646eb90066 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit kcms/activities/kcm_activities.desktop
  change: edit applets/kimpanel/package/metadata.desktop
  change: edit dataengines/kimpanel/plasma-dataengine-kimpanel.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 10 Mar 2016 11:55:27 +
Build duration: 1 min 36 sec

CHANGE SET
Revision 740106b4885d9ec31ce0e3aa54c58c8de2e52ad5 by kde: ([Wallpaper 
configuration] Fix height of color button)
  change: edit wallpapers/image/imagepackage/contents/ui/config.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D1107: Opening activity configuration as a modal dialog when calling from kcm

[Ivan Čukić]

ivan abandoned this revision.
ivan added a comment.


  Not needed after the https://git.reviewboard.kde.org/r/127333/

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1107

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127333: KCMshell window has no reason to be modal

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127333/
---

(Updated March 10, 2016, 5:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson and David Faure.


Changes
---

Submitted with commit ed53baa2b1753e59f9adde3ef7c261bb1746d10f by Ivan ?uki? to 
branch master.


Repository: kde-cli-tools


Description
---

The fact that the KCMshell window is marked as modal breaks KCMs that
want to show a non-parrented non-modal dialog - it can never get focus.

Was there a reason for making it modal?


Diffs
-

  kcmshell/main.cpp c05ae83 

Diff: https://git.reviewboard.kde.org/r/127333/diff/


Testing
---


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127333: KCMshell window has no reason to be modal

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127333/#review93393
---


Ship it!




Ship It!

- Marco Martin


On March 10, 2016, 5:28 p.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127333/
> ---
> 
> (Updated March 10, 2016, 5:28 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> The fact that the KCMshell window is marked as modal breaks KCMs that
> want to show a non-parrented non-modal dialog - it can never get focus.
> 
> Was there a reason for making it modal?
> 
> 
> Diffs
> -
> 
>   kcmshell/main.cpp c05ae83 
> 
> Diff: https://git.reviewboard.kde.org/r/127333/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127333: KCMshell window has no reason to be modal

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127333/
---

Review request for Plasma, David Edmundson and David Faure.


Repository: kde-cli-tools


Description
---

The fact that the KCMshell window is marked as modal breaks KCMs that
want to show a non-parrented non-modal dialog - it can never get focus.

Was there a reason for making it modal?


Diffs
-

  kcmshell/main.cpp c05ae83 

Diff: https://git.reviewboard.kde.org/r/127333/diff/


Testing
---


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kdereview: breeze-grub & breeze-plymouth

[Jonathan Riddell]

On Fri, Feb 19, 2016 at 09:43:27AM +0100, Harald Sitter wrote:
> GRUB is ready for review.

error: unknown property 'terminal-color'
 https://www.flickr.com/photos/jriddell/25584072671/in/photostream/

probably it's being snobbish and it should be 'terminal-colour' :)

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kdereview: breeze-grub & breeze-plymouth

[Jonathan Riddell]

On Thu, Mar 10, 2016 at 05:10:40PM +, Jonathan Riddell wrote:
> On Thu, Mar 10, 2016 at 09:28:35AM +0100, Harald Sitter wrote:
> > On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler  wrote:
> > > On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote:
> > >> This does not build when using
> > >> -Wl,--no-undefined
> > >>
> > >> breeze-text/plugin.c:601: undefined reference to `pow'
> > >> breeze-text/plugin.c:601: undefined reference to `pow'
> > >
> > > offhand, it needs
> > >
> > > #include 
> > 
> > I am pretty sure that is what Hrvoje's RR [1] fixes. Did your build
> > include that commit?
> > 
> > (missing the include would raise 'implicit declaration' I think)
> > 
> > [1] https://git.reviewboard.kde.org/r/127296/
> 
> Lovely, that sorts it.
> 
> Some queries:
>  - why does it have a .grub theme file? shouldn't that be in breeze-grub?
>  - It doesn't do anything for ask-question
>  - It depends on plymouth-label but doesn't check for it at configure time 
> (maybe it's just Debian splitting it out when other distros don't)
>  - There's graphics for distros to have their own logo in place of the KDE 
> one but no means to use that, are distros expected to just patch them?

And the text covers the progress spinner
 https://www.flickr.com/photos/jriddell/25650567456/

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kdereview: breeze-grub & breeze-plymouth

[Jonathan Riddell]

On Thu, Mar 10, 2016 at 09:28:35AM +0100, Harald Sitter wrote:
> On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler  wrote:
> > On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote:
> >> This does not build when using
> >> -Wl,--no-undefined
> >>
> >> breeze-text/plugin.c:601: undefined reference to `pow'
> >> breeze-text/plugin.c:601: undefined reference to `pow'
> >
> > offhand, it needs
> >
> > #include 
> 
> I am pretty sure that is what Hrvoje's RR [1] fixes. Did your build
> include that commit?
> 
> (missing the include would raise 'implicit declaration' I think)
> 
> [1] https://git.reviewboard.kde.org/r/127296/

Lovely, that sorts it.

Some queries:
 - why does it have a .grub theme file? shouldn't that be in breeze-grub?
 - It doesn't do anything for ask-question
 - It depends on plymouth-label but doesn't check for it at configure time 
(maybe it's just Debian splitting it out when other distros don't)
 - There's graphics for distros to have their own logo in place of the KDE one 
but no means to use that, are distros expected to just patch them?

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127332: [Pager] List minimized windows in the tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127332/
---

(Updated März 10, 2016, 5:09 nachm.)


Review request for Plasma and KDE Usability.


Bugs: 357545
https://bugs.kde.org/show_bug.cgi?id=357545


Repository: plasma-desktop


Description (updated)
---

The tooltip now shows minimized windows in a separate list below the regular 
ones.

Drive-by changes:
- Don't bother creating the window rectangles if the pager is hidden (ie. just 
one virtual desktop), saves some CPU cycles - will backport to 5.6
- Use bindings for the colors rather than duplicating the logic
- Use devicePixelRatio rather than 1px fixed borders


Diffs
-

  applets/pager/package/contents/ui/main.qml eef7510 
  applets/pager/plugin/model.h 91dabc2 
  applets/pager/plugin/model.cpp 595e3c6 
  applets/pager/plugin/pager.cpp de95835 

Diff: https://git.reviewboard.kde.org/r/127332/diff/


Testing
---

Works


File Attachments


Screenshot_20160310_174757.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/12e721b4-cbcc-4da2-9268-580a0acfa14e__Screenshot_20160310_174757.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127332: [Pager] List minimized windows in the tooltip

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127332/
---

Review request for Plasma and KDE Usability.


Bugs: 357545
https://bugs.kde.org/show_bug.cgi?id=357545


Repository: plasma-desktop


Description
---

The tooltip now shows minimized windows in a separate list below the regular 
ones.

Drive-by changes:
* Don't bother creating the window rectangles if the pager is hidden (ie. just 
one virtual desktop), saves some CPU cycles - will backport to 5.6
* Use bindings for the colors rather than duplicating the logic
* Use devicePixelRatio rather than 1px fixed borders


Diffs
-

  applets/pager/package/contents/ui/main.qml eef7510 
  applets/pager/plugin/model.h 91dabc2 
  applets/pager/plugin/model.cpp 595e3c6 
  applets/pager/plugin/pager.cpp de95835 

Diff: https://git.reviewboard.kde.org/r/127332/diff/


Testing
---

Works


File Attachments


Screenshot_20160310_174757.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/10/12e721b4-cbcc-4da2-9268-580a0acfa14e__Screenshot_20160310_174757.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 38 lines] D1107: Opening activity configuration as a modal dialog when calling from kcm

[Ivan Čukić]

ivan created this revision.
ivan added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  We turned of the modal-ness of the activity configuration dialogue
  so that we do not block plasma (https://git.reviewboard.kde.org/r/126945/)
  but this introduced a problem when the dialog is opened from the kcm.
  
  This patch allows creating the dialog both as modal and not.
  Plasma uses the non-modal version, KCM uses the modal one.
  
  Now, there is a question whether this is smart to do from KCM as well?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1107

AFFECTED FILES
  desktoppackage/contents/activitymanager/ActivityItem.qml
  desktoppackage/contents/activitymanager/StoppedActivityItem.qml
  kcms/activities/imports/activitysettings.cpp
  kcms/activities/imports/activitysettings.h
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/dialog.h
  kcms/activities/qml/activitiesTab/ActivitiesView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[Aleix Pol Gonzalez]

> On March 10, 2016, 3 p.m., Marco Martin wrote:
> > Ship It!

Heh, hold your horses (my horses?). Still uses Qt 5.6 and doesn't have the 
changes we discussed.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review93388
---


On March 10, 2016, 11:48 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> ---
> 
> (Updated March 10, 2016, 11:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d407aed 
>   shell/CMakeLists.txt 7be2cfd 
>   shell/panelview.h c671f14 
>   shell/panelview.cpp c8c3c71 
>   shell/shellcorona.h b803239 
>   shell/shellcorona.cpp 54667da 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> ---
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. 
> (There could be crashes, I just didn't find them :D)
> 
> 
> File Attachments
> 
> 
> org.kde.konversation.desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127315: Icon applet: Set sensible minimum height

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127315/
---

(Updated March 10, 2016, 3:21 p.m.)


Review request for Plasma.


Changes
---

Add text height only when there is a text


Repository: plasma-workspace


Description
---

^^


Diffs (updated)
-

  applets/icon/package/contents/ui/main.qml acc493a 

Diff: https://git.reviewboard.kde.org/r/127315/diff/


Testing
---

Icon is now always visible


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 360309] [Window List applet] add text field to widget for the panel

[Martin Klapetek via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360309

Martin Klapetek  changed:

   What|Removed |Added

  Component|general |Window List
 CC||mklape...@kde.org
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/#review93388
---


Ship it!




Ship It!

- Marco Martin


On March 10, 2016, 10:48 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125451/
> ---
> 
> (Updated March 10, 2016, 10:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Now that everything's in place in Qt, we can do that.
> 
> It basically removes all the translation layer between KScreen and QScreen.
> 
> NOTE: This can't be merged until Qt 5.6 is a dependency.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d407aed 
>   shell/CMakeLists.txt 7be2cfd 
>   shell/panelview.h c671f14 
>   shell/panelview.cpp c8c3c71 
>   shell/shellcorona.h b803239 
>   shell/shellcorona.cpp 54667da 
> 
> Diff: https://git.reviewboard.kde.org/r/125451/diff/
> 
> 
> Testing
> ---
> 
> Hands-on testing, it's been working quite fluid and I couldn't find a crash. 
> (There could be crashes, I just didn't find them :D)
> 
> 
> File Attachments
> 
> 
> org.kde.konversation.desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122859/
---

(Updated March 10, 2016, 1:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 344d04e2306ca2fdaf17269bc218f4fad065cbbf by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

We have a lot of reusable singletons that are just hidden when unneeded 
(tooltip, osd). IconItem, however, will always fade from the previous state, 
even if the previous action happened minutes ago.

This patch makes it track its visibility and skip the fade-and-wait dance when 
it just became visible. It also removes a visible false call in the tooltip 
which I didn't know what it was for. (With it in place, the IconItem always 
becomes visible when moving between tooltip areas, breaking the animation 
altogether).

@Eike: Could you check whether this makes it more viable for Kicker?


Diffs
-

  autotests/iconitemtest.h c7ba89f 
  autotests/iconitemtest.cpp ae825a9 
  src/declarativeimports/core/iconitem.h 9613354 
  src/declarativeimports/core/iconitem.cpp 6c23a7e 

Diff: https://git.reviewboard.kde.org/r/122859/diff/


Testing
---

Moving between tray icons - icon fades, moving relly rapidly causes it not 
to load any icon until you halt (dunno if that happened before but doesn't seem 
too bad)
Hovering tray icon, leaving, waiting, hovering another one - icon does not 
fade, is there right away
Notifications also don't fade from the previously issued notification icon


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127313/
---

(Updated March 10, 2016, 11:58 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3b115e6d901fc9e74c6393ce21415d13e286a9eb by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

Changing the color group of an Svg emits repaintNeeded which will then cause it 
to schedule a pixmap update anyway.


Diffs
-

  autotests/iconitemtest.h c7ba89f 
  autotests/iconitemtest.cpp ae825a9 
  src/declarativeimports/core/iconitem.cpp 6c23a7e 

Diff: https://git.reviewboard.kde.org/r/127313/diff/


Testing
---

It doesn't work but that's unrelated to the loadPixmap call(); the icon item is 
updated but SVG still renders an SVG with the normal color group, 
investigating...


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP3bf5a5a1c592: [Folder View] Add "Icon Size" to 
"Icons" context menu (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D1103?vs=2659=2661#toc

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1103?vs=2659=2661

REVISION DETAIL
  https://phabricator.kde.org/D1103

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1090: [krunner] Make it work on Wayland

[Martin Gräßlin]

graesslin closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1090

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, mart
Cc: plasma-devel, Plasma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1088: [krunner] Don't call KWindowSystem::setState on every event

[Martin Gräßlin]

graesslin closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1088

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, broulik
Cc: broulik, plasma-devel, Plasma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127329/
---

(Updated March 10, 2016, 11:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 827861d0c7b1833862c529e2f7462fde998fd123 by Aleix Pol to 
branch master.


Repository: plasma-workspace


Description
---

Otherwise we get many warnings about using `::package()` which doesn't look 
easily fixable and doesn't let us see more relevant things.

https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/488/PLATFORM=Linux,compiler=gcc/warnings18Result/package.109403696/


Diffs
-

  shell/CMakeLists.txt 7be2cfd 

Diff: https://git.reviewboard.kde.org/r/127329/diff/


Testing
---

Builds without these deprecated warnings inside `shell/`.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127329/#review93385
---


Ship it!




Ship It!

- Sebastian Kügler


On March 10, 2016, 11:15 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127329/
> ---
> 
> (Updated March 10, 2016, 11:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Otherwise we get many warnings about using `::package()` which doesn't look 
> easily fixable and doesn't let us see more relevant things.
> 
> https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/488/PLATFORM=Linux,compiler=gcc/warnings18Result/package.109403696/
> 
> 
> Diffs
> -
> 
>   shell/CMakeLists.txt 7be2cfd 
> 
> Diff: https://git.reviewboard.kde.org/r/127329/diff/
> 
> 
> Testing
> ---
> 
> Builds without these deprecated warnings inside `shell/`.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127329/#review93384
---


Ship it!




yep, i agree, unfortunately i can't remove the usage of package() in kf5 
lifetime :/

- Marco Martin


On March 10, 2016, 11:15 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127329/
> ---
> 
> (Updated March 10, 2016, 11:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Otherwise we get many warnings about using `::package()` which doesn't look 
> easily fixable and doesn't let us see more relevant things.
> 
> https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/488/PLATFORM=Linux,compiler=gcc/warnings18Result/package.109403696/
> 
> 
> Diffs
> -
> 
>   shell/CMakeLists.txt 7be2cfd 
> 
> Diff: https://git.reviewboard.kde.org/r/127329/diff/
> 
> 
> Testing
> ---
> 
> Builds without these deprecated warnings inside `shell/`.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127329: Shut down warnings about deprecated KF5Plasma API being used

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127329/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Otherwise we get many warnings about using `::package()` which doesn't look 
easily fixable and doesn't let us see more relevant things.

https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/488/PLATFORM=Linux,compiler=gcc/warnings18Result/package.109403696/


Diffs
-

  shell/CMakeLists.txt 7be2cfd 

Diff: https://git.reviewboard.kde.org/r/127329/diff/


Testing
---

Builds without these deprecated warnings inside `shell/`.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

[hein (Eike Hein)]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  This looks fine, but I'm not sure we want to expose awkward icon size names 
like "Small Medium" to users. But that's a broader point that has to be 
addressed separately.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1103

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 45 lines] D1103: [Folder View] Add "Icon Size" to "Icons" context menu

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  As requested by VDG
  
  BUG: 360351
  FIXED-IN: 5.7.0

TEST PLAN
  Choosing a different size in the context menu changes the icon size and 
reflects that in the config dialog
  Choosing a different size in the config dialog updates the context menu action

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1103

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/
---

(Updated March 10, 2016, 11:48 a.m.)


Review request for Plasma.


Changes
---

Address David's concerns and few other things.

More work TBD.


Repository: plasma-workspace


Description
---

Now that everything's in place in Qt, we can do that.

It basically removes all the translation layer between KScreen and QScreen.

NOTE: This can't be merged until Qt 5.6 is a dependency.


Diffs (updated)
-

  CMakeLists.txt d407aed 
  shell/CMakeLists.txt 7be2cfd 
  shell/panelview.h c671f14 
  shell/panelview.cpp c8c3c71 
  shell/shellcorona.h b803239 
  shell/shellcorona.cpp 54667da 

Diff: https://git.reviewboard.kde.org/r/125451/diff/


Testing
---

Hands-on testing, it's been working quite fluid and I couldn't find a crash. 
(There could be crashes, I just didn't find them :D)


File Attachments (updated)


org.kde.konversation.desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/01/47534796-9ab4-4f8f-b770-089cae126b84__org.kde.konversation.desktop


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127325: Replace all keywords by Qt macros

[Kåre Särs]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127325/#review93381
---




daemon/powerdevilactionpool.cpp (line 130)


Is this a mistakenly included addition?


- Kåre Särs


On March 10, 2016, 8:42 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127325/
> ---
> 
> (Updated March 10, 2016, 8:42 a.m.)
> 
> 
> Review request for Plasma, Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> ---
> 
> Reason for this is new dependency on networkmanager-qt which uses some NM 
> headers causing the error below.
> 
> Compilation error:
> /usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected 
> unqualified-id before ‘public’
>GDBusSignalInfo **signals;
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e7fff17 
>   daemon/actions/bundled/handlebuttonevents.h 5d602d7 
>   daemon/actions/bundled/handlebuttonevents.cpp 7e1d16e 
>   daemon/actions/bundled/handlebuttoneventsconfig.cpp b1d4ef0 
>   daemon/actions/bundled/suspendsession.h d0fc78d 
>   daemon/backends/upower/backlighthelper.h b5ce7dc 
>   daemon/backends/upower/backlighthelper.cpp 58b82be 
>   daemon/backends/upower/powerdevilupowerbackend.h 32f0ee4 
>   daemon/backends/upower/powerdevilupowerbackend.cpp 6133887 
>   daemon/backends/upower/udevqtclient.cpp 52b17f6 
>   daemon/kwinkscreenhelpereffect.h bc1c21b 
>   daemon/kwinkscreenhelpereffect.cpp dec5d65 
>   daemon/powerdevilactionconfig.cpp 2565b0d 
>   daemon/powerdevilactionpool.cpp 2091879 
>   daemon/powerdevilbackendinterface.cpp 7aadb01 
>   daemon/powerdevilcore.cpp f02d474 
>   daemon/powerdevilfdoconnector.cpp d9a3ee6 
>   daemon/powerdevilpolicyagent.cpp e0d1ec6 
>   daemon/powerdevilprofilegenerator.cpp cff3120 
>   kcmodule/activities/activitypage.cpp ec18dee 
>   kcmodule/activities/activitywidget.cpp 5992a4d 
>   kcmodule/common/actioneditwidget.cpp 216399c 
>   kcmodule/global/GeneralPage.h a34d54f 
>   kcmodule/global/GeneralPage.cpp b2d9767 
>   kcmodule/profiles/EditPage.h 4791017 
>   kcmodule/profiles/EditPage.cpp 30973b2 
> 
> Diff: https://git.reviewboard.kde.org/r/127325/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: two exceptions for string freeze in Plasma

[Sebastian Kügler]

On Thursday, March 10, 2016 02:37:11 Alexander Potashev wrote:
> 2016-03-09 19:24 GMT+03:00 Sebastian Kügler :
> > Indeed. My change was not trying to get a generalized policy implemented,
> > but to fix the wrong use of the KDE brand. We do have people telling us
> > that they'll happily use KDE to refer to the desktop because we don't
> > even use it consistently ourselves. My change addresses this consistency
> > issue.
> Sebastian,
> 
> I don't think "KDE Info Center" is wrong use of KDE brand. This name
> is as common as "Microsoft Internet Explorer": in both cases the first
> part is name of the developer/vendor.

It's highly confusing, as it can too easily be mistaken that this thing 
provides info about KDE, which is the whole problem.

By your logic, we'd have to prepend all of our application names with KDE.
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-doc-english] [kinfocenter] /: Remove all remaining bits of SCSI module

[Sebastian Kügler]

CC:ing plasma-devel.

On Thursday, March 10, 2016 02:41:16 Alexander Potashev wrote:
> Next time please clarify in the commit message why you remove
> something (reasoning, links to discussions, etc?), SCSI support in
> this case.

SCSI isn't used in today's systems, it's very unlikely to find a system with 
sufficient OpenGL support to run Plasma which still has SCSI. Reducing UI 
clutter and maintenance overhead trumps here.

Cheers,
-- 
sebas

Sebastian Kügler|http://vizZzion.org| http://kde.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127325: Replace all keywords by Qt macros

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127325/
---

Review request for Plasma, Solid and Kai Uwe Broulik.


Repository: powerdevil


Description
---

Reason for this is new dependency on networkmanager-qt which uses some NM 
headers causing the error below.

Compilation error:
/usr/include/glib-2.0/gio/gdbusintrospection.h:155:25: error: expected 
unqualified-id before ‘public’
   GDBusSignalInfo **signals;


Diffs
-

  CMakeLists.txt e7fff17 
  daemon/actions/bundled/handlebuttonevents.h 5d602d7 
  daemon/actions/bundled/handlebuttonevents.cpp 7e1d16e 
  daemon/actions/bundled/handlebuttoneventsconfig.cpp b1d4ef0 
  daemon/actions/bundled/suspendsession.h d0fc78d 
  daemon/backends/upower/backlighthelper.h b5ce7dc 
  daemon/backends/upower/backlighthelper.cpp 58b82be 
  daemon/backends/upower/powerdevilupowerbackend.h 32f0ee4 
  daemon/backends/upower/powerdevilupowerbackend.cpp 6133887 
  daemon/backends/upower/udevqtclient.cpp 52b17f6 
  daemon/kwinkscreenhelpereffect.h bc1c21b 
  daemon/kwinkscreenhelpereffect.cpp dec5d65 
  daemon/powerdevilactionconfig.cpp 2565b0d 
  daemon/powerdevilactionpool.cpp 2091879 
  daemon/powerdevilbackendinterface.cpp 7aadb01 
  daemon/powerdevilcore.cpp f02d474 
  daemon/powerdevilfdoconnector.cpp d9a3ee6 
  daemon/powerdevilpolicyagent.cpp e0d1ec6 
  daemon/powerdevilprofilegenerator.cpp cff3120 
  kcmodule/activities/activitypage.cpp ec18dee 
  kcmodule/activities/activitywidget.cpp 5992a4d 
  kcmodule/common/actioneditwidget.cpp 216399c 
  kcmodule/global/GeneralPage.h a34d54f 
  kcmodule/global/GeneralPage.cpp b2d9767 
  kcmodule/profiles/EditPage.h 4791017 
  kcmodule/profiles/EditPage.cpp 30973b2 

Diff: https://git.reviewboard.kde.org/r/127325/diff/


Testing
---


Thanks,

Jan Grulich

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kdereview: breeze-grub & breeze-plymouth

[Harald Sitter]

On Wed, Mar 9, 2016 at 6:19 PM, Sebastian Kügler  wrote:
> On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote:
>> This does not build when using
>> -Wl,--no-undefined
>>
>> breeze-text/plugin.c:601: undefined reference to `pow'
>> breeze-text/plugin.c:601: undefined reference to `pow'
>
> offhand, it needs
>
> #include 

I am pretty sure that is what Hrvoje's RR [1] fixes. Did your build
include that commit?

(missing the include would raise 'implicit declaration' I think)

[1] https://git.reviewboard.kde.org/r/127296/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel