Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 498 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/498/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Mar 2016 01:49:09 +
Build duration: 2 min 17 sec

CHANGE SET
Revision c8ac2199cf4b1da7778df98c58d9f2ad15c99135 by David Edmundson: (resize 
xembedsniproxy windows with a config notify and an actual resize)
  change: edit xembed-sni-proxy/sniproxy.cpp
Revision a00f0a7cc9373655158f63f6298e0715452fba35 by David Edmundson: (Avoid 
accidentally inserting values into m_proxies)
  change: edit xembed-sni-proxy/fdoselectionmanager.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Mar 2016 01:32:09 +
Build duration: 2 min 17 sec

CHANGE SET
Revision c8ac2199cf4b1da7778df98c58d9f2ad15c99135 by David Edmundson: (resize 
xembedsniproxy windows with a config notify and an actual resize)
  change: edit xembed-sni-proxy/sniproxy.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127389: Fix the krunner KCM UI

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127389/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

paint was changed but sizeHint wasn't implemented meaning it will only
look OK if you have icons bigger than the text.


Diffs
-

  kcms/runners/kcm.h 8f4d362dc27fcce9441b5dba2c6e1bb401669365 
  kcms/runners/kcm.cpp 6020e74590059752526f570f2a4ebb1871f4081d 

Diff: https://git.reviewboard.kde.org/r/127389/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: remove khelpcenter from next Plasma release?

[Jeremy Whiting]

As an application developer I agree it makes sense to have khelpcenter
released with KDE Applications. I also agree with Albert's point that
having online documentation isn't the best since it could be newer
than what's actually running. People using LTS distributions or
"stable" variants of less often released distributions will have very
old (to those of us that run from git) versions of stuff. Having
online documentation for plasma 5.7 to look at while you're running
plasma 4 would just confuse.

Also, thanks Luigi for stepping up to maintain it.

BR,
Jeremy

On Tue, Mar 15, 2016 at 4:11 PM, Luigi Toscano  wrote:
> Luigi Toscano ha scritto:
>> On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote:
>>> On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote:
> Let me cut right to the chase, do you want to maintain it? Does it need
> to
> be in Plasma?

 Yes, I can maintain it. In fact many features come from components I
 already  control.

> You're right that Plasma devs don't seem to want it, I thought my
> initial
> email made that pretty clear. We do think that disconnected systems are
> rather a fringe case, and that our time and effort is better spent on
> other
> things.

 Then the question still holds: with a maintainer, does it have a place in
 Plasma? I'm not talking about an hypothetical time and effort for
 maintaining  this offline use case (which will continue to be 0) but in
 the
 light of the statement above. In other words, if the question mark in the
 subject is real or rhetorical.
 I'm ready for both possible outcomes.
>>>
>>> Ah OK, sorry for misunderstanding it.
>>>
>>> I think there are the following options:
>>>
>>> 1) keeping it in Plasma with maintainer
>>> 2) keeping it outside of Plasma with maintainer
>>> 3) moving it to unmaintained (that's basically killing it)
>>> 4) keeping the status quo (not wanted)
>>>
>>> My personal preference would be an optional component (hence Extragear),
>>> since I think that the vast majority of users has web access, so
>>> khelpcenter isn't necessary and only adds to our maintainance burden
>>> without much gain in those cases.
>>
>> My offer stands and we can rule out 4) and 3).
>> Note that 2) could also mean a move to Applications (from your point of view
>> it does not matter too much).
>> The case 1) shouldn't add maintenance anyway as the maintainer is identified.
>>
>>>
>>> If we can move from 4) to 1) (so status quo but with maintainer), that would
>>> already be an improvement of course.
>>>
>>> The question mark was honest, we haven't made a decision on it, but
>>> different people do have expressed a preference for not shipping it (as or
>>> by default in Plasma releases). We may have missed important points, and we
>>> don't want to just kick things out unilaterally.
>>
>> I think we can leave some time for other people to comment. The shortest
>> deadline of all possibilities is the one for moving into Applications, and
>> there are still 8 days before the dependency freeze and two weeks before the
>> branch.
>
> Any other comment from anyone else?
>
> Ciao
> --
> Luigi
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

[Gustavo Alvarez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126970/
---

(Updated March 15, 2016, 11:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Andreas Sturmlechner.


Changes
---

Submitted with commit 0a3dda7c1717f672eee4e8bc6655a7d26561b465 by David 
Edmundson on behalf of Last Avengers to branch Plasma/5.6.


Bugs: 356395
https://bugs.kde.org/show_bug.cgi?id=356395


Repository: breeze-gtk


Description
---

breeze-dark and breeze GTK3 theme have a assets files with wrong names, this 
patch rename these files according with the gtk.css file

renamig these files fix this message:

Gtk-WARNING **: Error loading image 
'file:///usr/share/themes/Breeze-Dark/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png':
 Error opening file: No such file or directory


Diffs
-

  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
6d21caf 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
09ed07f 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png 
b260f91 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 
5884f60 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
PRE-CREATION 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
PRE-CREATION 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
PRE-CREATION 
  Breeze-dark-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
PRE-CREATION 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-dark.png 
6d21caf 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay-d...@2.png 
09ed07f 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-overlay.png b260f91 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-horizontal-over...@2.png 5884f60 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-dark.png 
PRE-CREATION 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal-d...@2.png 
PRE-CREATION 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizontal.png 
PRE-CREATION 
  Breeze-gtk/gtk-3.0/assets/scrollbar-slider-overlay-horizon...@2.png 
PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126970/diff/


Testing
---


Thanks,

Gustavo Alvarez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127387: Refactor the backend loading code

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127387/#review93578
---



looks generally good.


autotests/testbackendloader.cpp (line 60)


this won't do want you want, you're  shadowing into a new local variable 
called _b, rather than the member variable



src/backendmanager.cpp (line 192)


is the name argument still used?

It looks like that used to be the name of the backend to load, which you 
now determine yourself inside the function, rendering it useless.


- David Edmundson


On March 15, 2016, 5:57 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127387/
> ---
> 
> (Updated March 15, 2016, 5:57 p.m.)
> 
> 
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> Refactor the backend loading code
> 
> Untangle the large plugin loading logic in the BackendManager static
> into  separate bits. This makes the code clearer and easier to auto-test.
> 
> - listBackends() compiles a list of backends from the plugin paths
> - preferredBackend() picks the backend, in this priority:
> - if KSCREEN_BACKEND is set in the environment, this is the only
>   used method to find the backend plugin
> - if platform is X11, the XRandR backend is picked
> - if platform is wayland, KWayland backend is picked
> - if neither is the case, QScreen backend is picked
> 
> It does introduce a slight behavioral change: The mechanism was based on
> falling through, so it would consider another backend if the logically
> picked on fails to load. This is undesired behavior, however, since the
> backendloader may be able to load the plugin, but that doesn't mean that
> the plugin actually work.
> 
> Parsing of the KSCREEN_BACKEND variable is kept case-insensitive.
> 
> 
> autotests for new backend loading logic
> 
> - makes sure we find plugins installed
> - pick plugins from env var
> 
> We can't sensible test all the runtime cases yet, but this at least
> covers the code paths around those few lines that do runtime detection
> of x11 and wayland.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 26c7952 
>   autotests/testbackendloader.cpp PRE-CREATION 
>   src/backendmanager.cpp 382ae71 
>   src/backendmanager_p.h 150883b 
> 
> Diff: https://git.reviewboard.kde.org/r/127387/diff/
> 
> 
> Testing
> ---
> 
> manual runtime tests and autotests pass
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Lucas S]

Hi

"One thing that I found little bit off is the animation transition at 1:20.
It's kinda hasty/fast zoom-out-zoom-in. Maybe zoom directly to the
next scene without the zooming out?"

This is the tricky one, because here I change the view from "monitor
template" to full screen, hence this fast zoom-out-zoom-in. It also
makes the video more dynamic and the change between scenes is less
visible.  Basically I use the two effects when I switch between
scenes, the first one is fast zoom out and zoom in, the other is
something I call "white flash". This is how it looks like in this
scene https://youtu.be/uKO0RwuDMzU. Fast zoom-out-zoom-in looks much
better in my opinion. And yes I tried with a simple zoom, but the
result is disappointing.


"Also sometimes it shows things within a screen and sometimes
not (it's most notable at 1:46 when it suddenly zooms out for no
apparent reason). This is really a minor issue, just for the sake
of consistency."

Ah yes.  As I mentioned earlier I use two modes for the video scenes a
"monitor template" and full screen. When I switch to monitor template
the video is downscaled and makes things blurry. This is not a problem
for the video sequences when I show only parts of the screen like
download progress or media controls on the panel, but is quite
problematic for a full screen sequences like breeze theme part. As for
1:46, well at first I just wanted to do a simple zoom in but weather
widget is still using old oxygen icons and the buttons on the media
frame plasmoid are misaligned and the effect is not something we want
to show, hence zoom out  ;)
https://youtu.be/ywtINeDKBLo


Cheers
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 20:50:53 +
Build duration: 2 min 6 sec

CHANGE SET
Revision 46f466bf12c6e6e2d8d50f53cfedcf48dd8a7eb9 by kde: ([Widget Explorer] 
Become transparent during widget drag)
  change: edit desktoppackage/contents/explorer/AppletDelegate.qml
  change: edit desktoppackage/contents/views/Desktop.qml
  change: edit desktoppackage/contents/explorer/WidgetExplorer.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: remove khelpcenter from next Plasma release?

[Luigi Toscano]

Luigi Toscano ha scritto:
> On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote:
>> On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote:
 Let me cut right to the chase, do you want to maintain it? Does it need
 to
 be in Plasma?
>>>
>>> Yes, I can maintain it. In fact many features come from components I
>>> already  control.
>>>
 You're right that Plasma devs don't seem to want it, I thought my
 initial
 email made that pretty clear. We do think that disconnected systems are
 rather a fringe case, and that our time and effort is better spent on
 other
 things.
>>>
>>> Then the question still holds: with a maintainer, does it have a place in
>>> Plasma? I'm not talking about an hypothetical time and effort for
>>> maintaining  this offline use case (which will continue to be 0) but in
>>> the
>>> light of the statement above. In other words, if the question mark in the
>>> subject is real or rhetorical.
>>> I'm ready for both possible outcomes.
>>
>> Ah OK, sorry for misunderstanding it.
>>
>> I think there are the following options:
>>
>> 1) keeping it in Plasma with maintainer
>> 2) keeping it outside of Plasma with maintainer
>> 3) moving it to unmaintained (that's basically killing it)
>> 4) keeping the status quo (not wanted)
>>
>> My personal preference would be an optional component (hence Extragear),
>> since I think that the vast majority of users has web access, so
>> khelpcenter isn't necessary and only adds to our maintainance burden
>> without much gain in those cases.
> 
> My offer stands and we can rule out 4) and 3).
> Note that 2) could also mean a move to Applications (from your point of view 
> it does not matter too much).
> The case 1) shouldn't add maintenance anyway as the maintainer is identified.
> 
>>
>> If we can move from 4) to 1) (so status quo but with maintainer), that would
>> already be an improvement of course.
>>
>> The question mark was honest, we haven't made a decision on it, but
>> different people do have expressed a preference for not shipping it (as or
>> by default in Plasma releases). We may have missed important points, and we
>> don't want to just kick things out unilaterally.
> 
> I think we can leave some time for other people to comment. The shortest 
> deadline of all possibilities is the one for moving into Applications, and 
> there are still 8 days before the dependency freeze and two weeks before the 
> branch.

Any other comment from anyone else?

Ciao
-- 
Luigi
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 478 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/478/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 20:47:27 +
Build duration: 2 min 12 sec

CHANGE SET
Revision 7897c2529c7e9a89b818a55239d09b8e345927f0 by ivan.cukic: (Properly 
initializing activity configuration dialog)
  change: edit kcms/activities/imports/dialog.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > I've tested it extensively and it works great. Thanks a lot!
> > 
> > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the 
> > same font size should also be applied to the left date label (there are; 
> > the bottom should stay as is). Do you think you could include it as part of 
> > this patch?
> 
> Daniel Faust wrote:
> I changed it, but now I'm not so sure anymore if the fixed font size 
> wasn't intentional.
> It would be a separate issue anyway and not connected to this one, so if 
> you want, I can upload the patch to a new review request.

Yeah, that'd be great. Thanks!


> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568
> > 
> >
> > Can't we just compare "A" and "P" width's and use that? Would spare 
> > creating two Date objects and two calls to Qt.formatTime
> 
> Daniel Faust wrote:
> No, because eg. in german the strings for am and pm are "vorm." and 
> "nachm.".

Ah, good. Haven't thought of that. Those germans...

(on the other hand, I wouldn't expect anyone in Germany to actually not use 24h 
clock format, but oh well)

One other thing - create just a single Date object and then call setHours(13) 
on it for the second format.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---


On March 8, 2016, 6:53 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 8, 2016, 6:53 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

[Fuchs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360537

--- Comment #3 from Fuchs  ---
As discussed on IRC: 

I also checked why using the slider or dbus would trigger the buggy behaviour. 
As expected, the driver is silly enough to emit 

keycode 236 (keysym 0x1008ff04, XF86KbdLightOnOff)

even if you didn't touch the keyboard, it just does this on all keyboard
brightness changes. Huzzah.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Dirk Hohndel]

On Tue, Mar 15, 2016 at 01:26:22PM +, Lucas S wrote:
> Hi
> 
> It is time for a quick update so here is the first version of the
> Plasma 5.6 video https://youtu.be/q-nACSvivGU
> After initial feedback on the plasma IRC channel, this is the list of
> planned changes for the next video.
> 
> 1.  Rework the end of the video, because now it ends rather unexpectedly.
> 2.  Update the "widget explorer" part
> 3.  Ivan are you ok with the "Activity Manager" part?
> 4.???
> Feel free to post other suggestion/improvements, but please be quick :)

Amazing. Who would one have to bribe to get a video of that quality for
ones own project?

/D
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 26 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 20:15:02 +
Build duration: 1 min 55 sec

CHANGE SET
Revision e350ae8e33eb0130f17ad6656d81c604f67ed8c5 by ivan.cukic: (Allocating 
the dialog and loading QML only once per application instance)
  change: edit kcms/activities/imports/dialog.h
  change: edit kcms/activities/imports/dialog.cpp
  change: edit kcms/activities/imports/activitysettings.cpp
Revision 8cbf5359f3d03fcdce2730c308bcce1d87e12587 by ivan.cukic: (Properly 
initializing activity configuration dialog)
  change: edit kcms/activities/imports/dialog.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Marco Martin]

On Tuesday 15 March 2016, Lucas S wrote:
> Hi
> 
> It is time for a quick update so here is the first version of the
> Plasma 5.6 video https://youtu.be/q-nACSvivGU

just... awesome!


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 477 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/477/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 19:54:02 +
Build duration: 2 min 21 sec

CHANGE SET
Revision 06db46af336064bdf22bae420b623a34ef6c0e21 by ivan.cukic: (Allocating 
the dialog and loading QML only once per application instance)
  change: edit kcms/activities/imports/activitysettings.cpp
  change: edit kcms/activities/imports/dialog.h
  change: edit kcms/activities/imports/dialog.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Ivan Čukić]

Hi Lucas,

I agree with Martin - fantastic! :)

Also on other points - the transitions are a bit off and disorienting
when watching the video full-screen.

Other than that, truly amazing work!

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Martin Klapetek]

I want to say that this video is amazing. Really really well done.

One thing that I found little bit off is the animation transition at 1:20.
It's kinda hasty/fast zoom-out-zoom-in. Maybe zoom directly to the
next scene without the zooming out?

Also sometimes it shows things within a screen and sometimes
not (it's most notable at 1:46 when it suddenly zooms out for no
apparent reason). This is really a minor issue, just for the sake
of consistency.

Yeah the ending is a bit cut off. Maybe say something like "All this
in the new Plasma 5.6 release, out now. KDE - Experience Freedom".

Other than that, outstanding work, thanks a lot for that.

And kudos for Darude - Sandstorm :D

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 476 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 18:37:26 +
Build duration: 1 min 34 sec

CHANGE SET
Revision b9f310d9e7ddea6a62b01e2336250b1fc97cf6fa by ivan.cukic: (New 
implementation of wallpaper updating in the activity switcher)
  change: edit imports/activitymanager/sortedactivitiesmodel.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127387: Refactor the backend loading code

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127387/
---

Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.


Repository: libkscreen


Description
---

Refactor the backend loading code

Untangle the large plugin loading logic in the BackendManager static
into  separate bits. This makes the code clearer and easier to auto-test.

- listBackends() compiles a list of backends from the plugin paths
- preferredBackend() picks the backend, in this priority:
- if KSCREEN_BACKEND is set in the environment, this is the only
  used method to find the backend plugin
- if platform is X11, the XRandR backend is picked
- if platform is wayland, KWayland backend is picked
- if neither is the case, QScreen backend is picked

It does introduce a slight behavioral change: The mechanism was based on
falling through, so it would consider another backend if the logically
picked on fails to load. This is undesired behavior, however, since the
backendloader may be able to load the plugin, but that doesn't mean that
the plugin actually work.

Parsing of the KSCREEN_BACKEND variable is kept case-insensitive.


autotests for new backend loading logic

- makes sure we find plugins installed
- pick plugins from env var

We can't sensible test all the runtime cases yet, but this at least
covers the code paths around those few lines that do runtime detection
of x11 and wayland.


Diffs
-

  autotests/CMakeLists.txt 26c7952 
  autotests/testbackendloader.cpp PRE-CREATION 
  src/backendmanager.cpp 382ae71 
  src/backendmanager_p.h 150883b 

Diff: https://git.reviewboard.kde.org/r/127387/diff/


Testing
---

manual runtime tests and autotests pass


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

(Updated March 15, 2016, 5:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Changes
---

Submitted with commit a79c2be9b4db0755ad6ff6b26a513d71a94ef790 by Anthony 
Fieroni to branch Plasma/5.6.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Daniel Faust]

> On März 15, 2016, 5:48 nachm., Martin Klapetek wrote:
> > I've tested it extensively and it works great. Thanks a lot!
> > 
> > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the 
> > same font size should also be applied to the left date label (there are; 
> > the bottom should stay as is). Do you think you could include it as part of 
> > this patch?

I changed it, but now I'm not so sure anymore if the fixed font size wasn't 
intentional.
It would be a separate issue anyway and not connected to this one, so if you 
want, I can upload the patch to a new review request.


> On März 15, 2016, 5:48 nachm., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568
> > 
> >
> > Can't we just compare "A" and "P" width's and use that? Would spare 
> > creating two Date objects and two calls to Qt.formatTime

No, because eg. in german the strings for am and pm are "vorm." and "nachm.".


> On März 15, 2016, 5:48 nachm., Martin Klapetek wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555
> > 
> >
> > spaces around operators

Sure thing.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---


On März 8, 2016, 6:53 nachm., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated März 8, 2016, 6:53 nachm.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 497 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/497/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 17:07:06 +
Build duration: 58 sec

CHANGE SET
Revision 6f2c71cc947322adc0c8996326e991dbd081289d by David Edmundson: (Fix 
mouse interaction with xmebed sni proxy applets in new tray)
  change: edit 
applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127102/#review93561
---



I've tested it extensively and it works great. Thanks a lot!

There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the same 
font size should also be applied to the left date label (there are; the bottom 
should stay as is). Do you think you could include it as part of this patch?


applets/digital-clock/package/contents/ui/DigitalClock.qml (line 554)


spaces around operators



applets/digital-clock/package/contents/ui/DigitalClock.qml (lines 564 - 567)


Can't we just compare "A" and "P" width's and use that? Would spare 
creating two Date objects and two calls to Qt.formatTime


- Martin Klapetek


On March 8, 2016, 6:53 p.m., Daniel Faust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127102/
> ---
> 
> (Updated March 8, 2016, 6:53 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 347724
> https://bugs.kde.org/show_bug.cgi?id=347724
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Currently the width of the date label is not fixed but changes depending on 
> the text. This causes the entire applet to change its width (if the time is 
> the widest displayed item). This in turn can cause all other applets in the 
> same panel to move whenever the displayed time changes.
> 
> This patch uses FontMetrics to iterate over all possible time strings (with 
> different width) and chooses the widest of them as reference for the fixed 
> width of the time label.
> 
> This way the width of the applet stays the same (unless the date is displayed 
> and changes). The text remains centered though, which means that it can still 
> move within the applet when the time changes.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 95bb071 
> 
> Diff: https://git.reviewboard.kde.org/r/127102/diff/
> 
> 
> Testing
> ---
> 
> Works with horizontal and vertical panel.
> Also displaying different combinations of "seconds", "date" and "timezone" 
> works.
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

[David Edmundson]

> On March 15, 2016, 3:15 p.m., David Rosca wrote:
> > Are you sure this fixes it? I've tested it now with Qt 5.5 and it just 
> > completely broke the skip taskbar feature (= plasma popups are shown ALWAYS 
> > in taskbar). I was experimenting with various workarounds too, but found 
> > none (other than always using Popup as window type for Plasma::Dialog 
> > instead of normal window).
> > 
> > I think it is because the _NET_WM_STATE hints are reset by Qt before Expose 
> > event, not in Show event. But I'm not sure about this one (didn't look in 
> > the code). My patch however fixes it correctly :)

Oh crap. I came up with an idea for a workaround after I had started a Qt patch 
(basically same as yours)... and I forgot to remove it before testing


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127374/#review93558
---


On March 15, 2016, 2:36 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127374/
> ---
> 
> (Updated March 15, 2016, 2:36 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When we show a Qt window it resets all wm_states, including the
> SKIP_TASKBAR state that Qt doesn't support see
> QXcbWindow::setNetWmStates
> 
> In order to set the flag we need to do it after Qt has mapped the
> window. (after a showEvent)
> 
> Dialog previously did this using ExposeEvent which we know will happen after 
> show.
> 
> However:
> 1) This is a rather random fix
> 2) It will be called after TaskManager has been notified of a new window
> 
> By merging into the same event we can make sure the flag is set before
> the task manager processes the new window. This means task manager will 
> always skip plasma popups.
> 
> A better fix will obviously be patching Qt to not reset flags it doesn't know 
> about 
> and then we can set this flag in the ctor. I shall try and do that for Qt 5.7.
> 
> BUG: 332024
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 
> 
> Diff: https://git.reviewboard.kde.org/r/127374/diff/
> 
> 
> Testing
> ---
> 
> Added debug in libtaskmanager, the window flags are always correct for the 
> new window.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: I've got kwin_wayland + plasmashell (wayland) running in a container (bugs included)

[Martin Graesslin]

On Tuesday, March 15, 2016 3:21:58 PM CET Sebastian Kügler wrote:
> Hi Sebastian,
> 
> On Monday, March 14, 2016 05:36:28 PM Sebastian Grüner wrote:
> > hey all,
> > 
> > I've been fiddling around wit lxc on a smartphone the other week, did
> > some reading and thought I'd try out some ideas with kwin_wayland.
> > This is one of your proposals for this years GSOC projects at KDE [1],
> > and I know my approach is different from what is explained there.
> > Nevertheless I'd like to share my initial hack with you, in case anyone
> > wants to pursue this further.
> > Long story short: I copied random bits and pieces of the web and got
> > kwin_wayland and plasmashell (via startplasmacompositor) running in a
> > containerized environment with native hardware acceleration, no llvmpipe
> > needed :-). (I used systemd-nspawn, docker and lxc should work as well,
> > haven't tried this though).
> > 
> > Here is what I've done:
> > Get a rootfs of your favorite distro:
> > - I use Opensuse Tumbleweed since I am familiar with this. (KDE
> > Frameworks 5.20, Plasma 5.5.95)
> > - I set up Debian unstable as well, which worked, but this uses old KDE
> > packages (debootstrap)
> > - I tried Ubuntu Xenial (debootstrap), weston works with native hw, but
> > kwin_wayland won't start up.
> 
> [...]
> 
> > There is probably a lot of stuff that could be improved upon, but I got
> > plasmashell in a container up and running!
> > If the container hangs/crashes you can terminate it from a different tty
> > with machinectl [3].
> > 
> > I hope you like this. :-)
> 
> I do!
> 
> What I'm wondering is how hard would it be to run such a container on a very
> bare Mer system? Mer has great support in hardware, but a downside is that
> we'd have to do almost all the packaging of our stack twice, that adds huge
> overhead, both in building, build infrastructure and in testing. Now if we
> could create images from a Mer hardware adaption with Neon or Debian
> builds, we could get great hardware support for mobile devices while having
> to do the packaging only once.
> 
> Have you thought about this? Am I ignoring major roadblocks?

sorry I don't think that gives us much. The question is whether KWin can 
access the device hardware. If it can it means we have a DRM enabled driver. 
If yes KWin will work just fine without the need for a container. If it doesn't 
(which is where Mer comes in the game) it doesn't help us as we need the 
Android stack inside the container (KWin would need to use hwcomposer). That's 
a completely different problem and probably not solved by passing the dri 
device into the container.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 496 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/496/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 15:36:01 +
Build duration: 1 min 56 sec

CHANGE SET
Revision 9f1afff2673d9a4a36f5eeaa1d8d7bc9e1ae2450 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/systemtray/package/metadata.desktop
Revision 1be9630c41f32c9d5a701beba0aae1b98b196179 by Marco Martin: (use 
org.kde.plasma:force-create)
  change: edit applets/systemtray/systemtray.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: I've got kwin_wayland + plasmashell (wayland) running in a container (bugs included)

[Martin Graesslin]

Hi Sebastian,

that's pretty cool! Thanks for sharing. 

Cheers
Martin

P.S.: Personally I'm a little bit shocked to see how easy it is to expose the 
GPU as that makes escaping the container pretty easy.

On Monday, March 14, 2016 5:36:28 PM CET Sebastian Grüner wrote:
> hey all,
> 
> I've been fiddling around wit lxc on a smartphone the other week, did
> some reading and thought I'd try out some ideas with kwin_wayland.
> This is one of your proposals for this years GSOC projects at KDE [1],
> and I know my approach is different from what is explained there.
> Nevertheless I'd like to share my initial hack with you, in case anyone
> wants to pursue this further.
> Long story short: I copied random bits and pieces of the web and got
> kwin_wayland and plasmashell (via startplasmacompositor) running in a
> containerized environment with native hardware acceleration, no llvmpipe
> needed :-). (I used systemd-nspawn, docker and lxc should work as well,
> haven't tried this though).
> 
> Here is what I've done:
> Get a rootfs of your favorite distro:
> - I use Opensuse Tumbleweed since I am familiar with this. (KDE
> Frameworks 5.20, Plasma 5.5.95)
> - I set up Debian unstable as well, which worked, but this uses old KDE
> packages (debootstrap)
> - I tried Ubuntu Xenial (debootstrap), weston works with native hw, but
> kwin_wayland won't start up.
> 
> Systemd comes with a minimal container tool, systemd-nspawn [2], which
> is described as similar to a chroot and quite easy to use. With this one
> can just switch into the rootfs:
> 
> sudo systemd-nspawn -D $ROOTFSDIRECTORY/
> 
> systemd-nspawn has quite a lot of command line switches, you can set
> environment variables and bind-mount specific directories for example.
> So why not just bind-mount the device-node of my graphics-card?
> here we go:
> 
> xhost +local:
> 
> sudo systemd-nspawn --setenv=DISPLAY=:0 \
> --setenv=XAUTHORITY=~/.Xauthority \
> --setenv=XDG_RUNTIME_DIR=/run/user/1000 \
> --bind-ro=$HOME/.Xauthority:/root/.Xauthority \
> --bind=/run/user/1000/:/run/user/1000 \
> --bind=/tmp/.X11-unix \
> --bind=/dev/shm:/dev/shm \
> --bind=/dev/dri/card0:/dev/dri/card0 \
> -D suse/ kwin_wayland --libinput --xwayland --drm --windowed "konsole
> --platform wayland"
> 
> Initially I tried weston: to do this just change the command at the very
> end. If you change the command to startplasmacompositor the Plasma
> desktop starts up. In order to make Plasma useable and avoid loops for
> kscreen, powerdevil you need Dbus, so I just did bind mount my
> bus-socket with
> 
> --bind=/run/dbus/system_bus_socket:/run/dbus/system_bus_socket
> 
> It should be somehow possible to run the dbus-daemon from within the
> container.
> 
> There is probably a lot of stuff that could be improved upon, but I got
> plasmashell in a container up and running!
> If the container hangs/crashes you can terminate it from a different tty
> with machinectl [3].
> 
> I hope you like this. :-)
> 
> Sebastian
> 
> [1]
> https://community.kde.org/GSoC/2016/Ideas#Project:_Running_KWin.2FWayland_in
> _a_Docker_container [2]
> https://www.freedesktop.org/software/systemd/man/systemd-nspawn.html [3]
> https://www.freedesktop.org/software/systemd/man/machinectl.html
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127373: introduce org.kde.plasma:force-create for Containment::createApplet as well

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127373/
---

(Updated March 15, 2016, 3:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Ivan Čukić.


Changes
---

Submitted with commit 917b2768a8eaa8d4781fea9136e5be539ac91601 by Marco Martin 
to branch master.


Bugs: 360363
http://bugs.kde.org/show_bug.cgi?id=360363


Repository: plasma-framework


Description
---

so much for removing sytray-related hacks.. :/
when the widgets are locked, must be possible to add/remoe widgets in the 
sytemtray anyways, as their creation/destruction can depend from dbus 
activation (or the first time you launch plasma with the new systray and it 
must be populated)


Diffs
-

  src/plasma/private/containment_p.cpp a8b8343 

Diff: https://git.reviewboard.kde.org/r/127373/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127382: Avoid blocking DBus call to kded

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/
---

(Updated March 15, 2016, 4:22 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Jan Grulich.


Changes
---

Submitted with commit 6d57e1664f1106c3c0fac3a89f5ebc514be01d75 by David 
Edmundson to branch master.


Repository: plasma-nm


Description
---

There are two blocking calls here; the QDBusInterface constructor which does 
introspection and
the init method.

It should be fine to do blocking calls to kded, but given we don't need
to, we may as well avoid them.


Diffs
-

  libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
  libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 

Diff: https://git.reviewboard.kde.org/r/127382/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: I've got kwin_wayland + plasmashell (wayland) running in a container (bugs included)

[Sebastian Kügler]

Hi Sebastian,

On Monday, March 14, 2016 05:36:28 PM Sebastian Grüner wrote:
> hey all,
> 
> I've been fiddling around wit lxc on a smartphone the other week, did
> some reading and thought I'd try out some ideas with kwin_wayland.
> This is one of your proposals for this years GSOC projects at KDE [1],
> and I know my approach is different from what is explained there.
> Nevertheless I'd like to share my initial hack with you, in case anyone
> wants to pursue this further.
> Long story short: I copied random bits and pieces of the web and got
> kwin_wayland and plasmashell (via startplasmacompositor) running in a
> containerized environment with native hardware acceleration, no llvmpipe
> needed :-). (I used systemd-nspawn, docker and lxc should work as well,
> haven't tried this though).
> 
> Here is what I've done:
> Get a rootfs of your favorite distro:
> - I use Opensuse Tumbleweed since I am familiar with this. (KDE
> Frameworks 5.20, Plasma 5.5.95)
> - I set up Debian unstable as well, which worked, but this uses old KDE
> packages (debootstrap)
> - I tried Ubuntu Xenial (debootstrap), weston works with native hw, but
> kwin_wayland won't start up.
[...]
> There is probably a lot of stuff that could be improved upon, but I got
> plasmashell in a container up and running!
> If the container hangs/crashes you can terminate it from a different tty
> with machinectl [3].
> 
> I hope you like this. :-)

I do!

What I'm wondering is how hard would it be to run such a container on a very 
bare Mer system? Mer has great support in hardware, but a downside is that 
we'd have to do almost all the packaging of our stack twice, that adds huge 
overhead, both in building, build infrastructure and in testing. Now if we 
could create images from a Mer hardware adaption with Neon or Debian builds, 
we could get great hardware support for mobile devices while having to do the 
packaging only once.

Have you thought about this? Am I ignoring major roadblocks?

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127374/#review93558
---



Are you sure this fixes it? I've tested it now with Qt 5.5 and it just 
completely broke the skip taskbar feature (= plasma popups are shown ALWAYS in 
taskbar). I was experimenting with various workarounds too, but found none 
(other than always using Popup as window type for Plasma::Dialog instead of 
normal window).

I think it is because the _NET_WM_STATE hints are reset by Qt before Expose 
event, not in Show event. But I'm not sure about this one (didn't look in the 
code). My patch however fixes it correctly :)

- David Rosca


On March 15, 2016, 2:36 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127374/
> ---
> 
> (Updated March 15, 2016, 2:36 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When we show a Qt window it resets all wm_states, including the
> SKIP_TASKBAR state that Qt doesn't support see
> QXcbWindow::setNetWmStates
> 
> In order to set the flag we need to do it after Qt has mapped the
> window. (after a showEvent)
> 
> Dialog previously did this using ExposeEvent which we know will happen after 
> show.
> 
> However:
> 1) This is a rather random fix
> 2) It will be called after TaskManager has been notified of a new window
> 
> By merging into the same event we can make sure the flag is set before
> the task manager processes the new window. This means task manager will 
> always skip plasma popups.
> 
> A better fix will obviously be patching Qt to not reset flags it doesn't know 
> about 
> and then we can set this flag in the ctor. I shall try and do that for Qt 5.7.
> 
> BUG: 332024
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 
> 
> Diff: https://git.reviewboard.kde.org/r/127374/diff/
> 
> 
> Testing
> ---
> 
> Added debug in libtaskmanager, the window flags are always correct for the 
> new window.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 25 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 15 Mar 2016 14:33:25 +
Build duration: 1 min 4 sec

CHANGE SET
Revision 8b28f9dd94632e7d1480aae89bc1ab15f18082a1 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127382: Avoid blocking DBus call to kded

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/#review93557
---


Ship it!




Ship It!

- Jan Grulich


On Bře. 15, 2016, 2:39 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127382/
> ---
> 
> (Updated Bře. 15, 2016, 2:39 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> There are two blocking calls here; the QDBusInterface constructor which does 
> introspection and
> the init method.
> 
> It should be fine to do blocking calls to kded, but given we don't need
> to, we may as well avoid them.
> 
> 
> Diffs
> -
> 
>   libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
>   libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 
> 
> Diff: https://git.reviewboard.kde.org/r/127382/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127382: Avoid blocking DBus call to kded

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/
---

(Updated March 15, 2016, 2:39 p.m.)


Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
---

There are two blocking calls here; the QDBusInterface constructor which does 
introspection and
the init method.

It should be fine to do blocking calls to kded, but given we don't need
to, we may as well avoid them.


Diffs (updated)
-

  libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
  libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 

Diff: https://git.reviewboard.kde.org/r/127382/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127382: Avoid blocking DBus call to kded

[David Edmundson]

> On March 15, 2016, 2:32 p.m., Jan Grulich wrote:
> > libs/handler.h, line 33
> > 
> >
> > Why this include? It doesn't compile with it, I removed it and it 
> > compiles just fine.

Ooops, thanks


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/#review93555
---


On March 15, 2016, 2:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127382/
> ---
> 
> (Updated March 15, 2016, 2:16 p.m.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> There are two blocking calls here; the QDBusInterface constructor which does 
> introspection and
> the init method.
> 
> It should be fine to do blocking calls to kded, but given we don't need
> to, we may as well avoid them.
> 
> 
> Diffs
> -
> 
>   libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
>   libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 
> 
> Diff: https://git.reviewboard.kde.org/r/127382/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127374/
---

(Updated March 15, 2016, 3:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 42e924e7f61e7b36266e6c3ca07aa414e88f50ca by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

When we show a Qt window it resets all wm_states, including the
SKIP_TASKBAR state that Qt doesn't support see
QXcbWindow::setNetWmStates

In order to set the flag we need to do it after Qt has mapped the
window. (after a showEvent)

Dialog previously did this using ExposeEvent which we know will happen after 
show.

However:
1) This is a rather random fix
2) It will be called after TaskManager has been notified of a new window

By merging into the same event we can make sure the flag is set before
the task manager processes the new window. This means task manager will always 
skip plasma popups.

A better fix will obviously be patching Qt to not reset flags it doesn't know 
about 
and then we can set this flag in the ctor. I shall try and do that for Qt 5.7.

BUG: 332024
REVIEW:


Diffs
-

  src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 

Diff: https://git.reviewboard.kde.org/r/127374/diff/


Testing
---

Added debug in libtaskmanager, the window flags are always correct for the new 
window.


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127382: Avoid blocking DBus call to kded

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/#review93555
---




libs/handler.h (line 33)


Why this include? It doesn't compile with it, I removed it and it compiles 
just fine.


- Jan Grulich


On Bře. 15, 2016, 2:16 odp., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127382/
> ---
> 
> (Updated Bře. 15, 2016, 2:16 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> There are two blocking calls here; the QDBusInterface constructor which does 
> introspection and
> the init method.
> 
> It should be fine to do blocking calls to kded, but given we don't need
> to, we may as well avoid them.
> 
> 
> Diffs
> -
> 
>   libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
>   libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 
> 
> Diff: https://git.reviewboard.kde.org/r/127382/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127382: Avoid blocking DBus call to kded

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/
---

Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
---

There are two blocking calls here; the QDBusInterface constructor which does 
introspection and
the init method.

It should be fine to do blocking calls to kded, but given we don't need
to, we may as well avoid them.


Diffs
-

  libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
  libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 

Diff: https://git.reviewboard.kde.org/r/127382/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127373: introduce org.kde.plasma:force-create for Containment::createApplet as well

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127373/#review93554
---


Ship it!




- David Edmundson


On March 15, 2016, 10:54 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127373/
> ---
> 
> (Updated March 15, 2016, 10:54 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Bugs: 360363
> http://bugs.kde.org/show_bug.cgi?id=360363
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> so much for removing sytray-related hacks.. :/
> when the widgets are locked, must be possible to add/remoe widgets in the 
> sytemtray anyways, as their creation/destruction can depend from dbus 
> activation (or the first time you launch plasma with the new systray and it 
> must be populated)
> 
> 
> Diffs
> -
> 
>   src/plasma/private/containment_p.cpp a8b8343 
> 
> Diff: https://git.reviewboard.kde.org/r/127373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

[Martin Gräßlin]

> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote:
> > Do we want a kconf_update script with that for all hte people that have 
> > systemsettings.desktop as favourite in launchers?
> 
> Martin Gräßlin wrote:
> I don't think it's needed. The important part is that there is a desktop 
> file which is reverse domain name dot binaryname. How the desktop file which 
> launched the application is called, doesn't really matter.
> 
> Hrvoje Senjan wrote:
> A misunderstanding ;-)
> I'm merely talking about people losing their favourite after upgrading to 
> 5.6.
> 
> Martin Gräßlin wrote:
> Sorry I don't get that. Why should renaming result in losing the favorite?
> 
> Matthias Klumpp wrote:
> The favourite apps settings is a list with .desktop filenames which are 
> shown in the launcher. If you now change the .desktop filename, the launcher 
> entry will become invalid or vanish, although the actual application is still 
> there, leading to confused users.
> 
> Martin Gräßlin wrote:
> and where is that stored?
> 
> Martin Gräßlin wrote:
> btw. that's a pretty big problem. We have thousands of incorrectly named 
> desktop files. I don't want to write a kconf update script for each of them. 
> I don't mind spending the time to fix the desktop files, but also adding a 
> kconf update script is quite some work.
> 
> Matthias Klumpp wrote:
> Yeah, it's a massive pain. Ubuntu is duplicating .desktop files for that 
> reason and hiding the new name (so the app doesn't show up twice), so user's 
> favourites don't break in Unity - which has a whole lot of problems.
> GNOME had a .desktop file name mapping once (I think meanwhile they've 
> just given up completely), but only cared for GNOME apps in there.
> 
> So yes, much pain, hard to solve, really annoying :(
> 
> Eike Hein wrote:
> In terms of launchers/favorites, I think adding the reverse domain isn't 
> a problem - the KService storage id lookup function is slightly fuzzy and I 
> think it can handle both versions and resolve them to a KService. Our 
> launcher favorites backend uses it at read-in and then serializes a cleaned 
> version back out. However, the systemsettings->systemsettings5 change might 
> be a problem. In any case the default applet configs should be changed for 
> cleanliness if this gets in.

concerning the Wayland bits we might also just use the new desktopFileName in 
KAboutData. If that works I might just ignore the desktop file renaming for 
following changed standards if that causes problems.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127308/#review93306
---


On March 8, 2016, 4:18 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127308/
> ---
> 
> (Updated March 8, 2016, 4:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> The desktop file name should include the reverse domain name and must
> much the binary.
> 
> 
> Diffs
> -
> 
>   app/CMakeLists.txt 3fa8dbb52b4cd8fd553c67a768fcd68c51cb83e4 
>   app/systemsettings.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/127308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.6 video

[Lucas S]

Hi

It is time for a quick update so here is the first version of the
Plasma 5.6 video https://youtu.be/q-nACSvivGU
After initial feedback on the plasma IRC channel, this is the list of
planned changes for the next video.

1.  Rework the end of the video, because now it ends rather unexpectedly.
2.  Update the "widget explorer" part
3.  Ivan are you ok with the "Activity Manager" part?
4.???
Feel free to post other suggestion/improvements, but please be quick :)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1143: do not install development helper files via cmake

[sitter (Harald Sitter)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rBREEZEGTK673f3e18af95: do not install development helper 
files via cmake (authored by sitter).

REPOSITORY
  rBREEZEGTK Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1143?vs=2769=2778

REVISION DETAIL
  https://phabricator.kde.org/D1143

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-gtk/CMakeLists.txt
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, graesslin, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127373: introduce org.kde.plasma:force-create for Containment::createApplet as well

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127373/
---

(Updated March 15, 2016, 10:54 a.m.)


Review request for Plasma and Ivan Čukić.


Bugs: 360363
http://bugs.kde.org/show_bug.cgi?id=360363


Repository: plasma-framework


Description
---

so much for removing sytray-related hacks.. :/
when the widgets are locked, must be possible to add/remoe widgets in the 
sytemtray anyways, as their creation/destruction can depend from dbus 
activation (or the first time you launch plasma with the new systray and it 
must be populated)


Diffs
-

  src/plasma/private/containment_p.cpp a8b8343 

Diff: https://git.reviewboard.kde.org/r/127373/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120892: move notification out of the way of other plasma windows

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120892/
---

(Updated March 15, 2016, 10:47 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This is an attempt to solve
https://bugs.kde.org/show_bug.cgi?id=338946

It's very crude (therefore no, i don't really like it that much)

alternatively, a second approach i was thinking to: it may be tried to find the 
actual window of the systray popup, it would probably have a better behavior 
(notifications could be moved as well when the popup opens/closes) finding that 
window reliably could be quite messy tough


Diffs
-

  applets/notifications/plugin/notificationshelper.cpp 425f0d6 

Diff: https://git.reviewboard.kde.org/r/120892/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1143: do not install development helper files via cmake

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.

REPOSITORY
  rBREEZEGTK Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1143

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, graesslin, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

[Eike Hein]

> On March 8, 2016, 5:20 p.m., Hrvoje Senjan wrote:
> > Do we want a kconf_update script with that for all hte people that have 
> > systemsettings.desktop as favourite in launchers?
> 
> Martin Gräßlin wrote:
> I don't think it's needed. The important part is that there is a desktop 
> file which is reverse domain name dot binaryname. How the desktop file which 
> launched the application is called, doesn't really matter.
> 
> Hrvoje Senjan wrote:
> A misunderstanding ;-)
> I'm merely talking about people losing their favourite after upgrading to 
> 5.6.
> 
> Martin Gräßlin wrote:
> Sorry I don't get that. Why should renaming result in losing the favorite?
> 
> Matthias Klumpp wrote:
> The favourite apps settings is a list with .desktop filenames which are 
> shown in the launcher. If you now change the .desktop filename, the launcher 
> entry will become invalid or vanish, although the actual application is still 
> there, leading to confused users.
> 
> Martin Gräßlin wrote:
> and where is that stored?
> 
> Martin Gräßlin wrote:
> btw. that's a pretty big problem. We have thousands of incorrectly named 
> desktop files. I don't want to write a kconf update script for each of them. 
> I don't mind spending the time to fix the desktop files, but also adding a 
> kconf update script is quite some work.
> 
> Matthias Klumpp wrote:
> Yeah, it's a massive pain. Ubuntu is duplicating .desktop files for that 
> reason and hiding the new name (so the app doesn't show up twice), so user's 
> favourites don't break in Unity - which has a whole lot of problems.
> GNOME had a .desktop file name mapping once (I think meanwhile they've 
> just given up completely), but only cared for GNOME apps in there.
> 
> So yes, much pain, hard to solve, really annoying :(

In terms of launchers/favorites, I think adding the reverse domain isn't a 
problem - the KService storage id lookup function is slightly fuzzy and I think 
it can handle both versions and resolve them to a KService. Our launcher 
favorites backend uses it at read-in and then serializes a cleaned version back 
out. However, the systemsettings->systemsettings5 change might be a problem. In 
any case the default applet configs should be changed for cleanliness if this 
gets in.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127308/#review93306
---


On March 8, 2016, 3:18 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127308/
> ---
> 
> (Updated March 8, 2016, 3:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> ---
> 
> The desktop file name should include the reverse domain name and must
> much the binary.
> 
> 
> Diffs
> -
> 
>   app/CMakeLists.txt 3fa8dbb52b4cd8fd553c67a768fcd68c51cb83e4 
>   app/systemsettings.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/127308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1143: do not install development helper files via cmake

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rBREEZEGTK Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1143

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127373: introduce org.kde.plasma:force-create for Containment::createApplet as well

[Marco Martin]

> On March 14, 2016, 11:54 p.m., David Edmundson wrote:
> > src/plasma/private/containment_p.cpp, line 198
> > 
> >
> > Why bother even having the check?

in any way is breaking the api, i didn't want to change the behavior by 
default, even tough it could remotely make sense to consider locking only 
affecting the availability of actions not the c++ api, but i don't like that 
too much, but as usual "systray is special" hmm, problems..


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127373/#review93526
---


On March 14, 2016, 2:54 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127373/
> ---
> 
> (Updated March 14, 2016, 2:54 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> so much for removing sytray-related hacks.. :/
> when the widgets are locked, must be possible to add/remoe widgets in the 
> sytemtray anyways, as their creation/destruction can depend from dbus 
> activation (or the first time you launch plasma with the new systray and it 
> must be populated)
> 
> 
> Diffs
> -
> 
>   src/plasma/private/containment_p.cpp a8b8343 
> 
> Diff: https://git.reviewboard.kde.org/r/127373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/#review93537
---


Ship it!




Ship It!

- Marco Martin


On March 15, 2016, 6:23 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127356/
> ---
> 
> (Updated March 15, 2016, 6:23 a.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> 1. Correct highlighted tabs visablity
> 2. Scale content on update comic
> 3. Open/close fullview widget
> 4. Added icon
> 5. Resize content
> 
> 
> Diffs
> -
> 
>   applets/comic/comic.h 302f7b8 
>   applets/comic/comic.cpp 97ec6a1 
>   applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
>   applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
>   applets/comic/package/contents/ui/main.qml 4cf1cae 
> 
> Diff: https://git.reviewboard.kde.org/r/127356/diff/
> 
> 
> Testing
> ---
> 
> Resize cannot get to work as i want :)
> Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
> Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
> 60% of current image, i don't understaind how this must be written to start 
> working :P
> 
> 
> File Attachments
> 
> 
> Screenshot_20160312_214006.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127374/#review93531
---


Ship it!




I'd say flesh out the comment a bit more to indicate this won't be needed with 
newer versions of Qt (so future readers don't need to do research to answer 
"can I delete this?"), but otherwise it's a harmless fix that helps, so +1

- Eike Hein


On March 14, 2016, 6:45 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127374/
> ---
> 
> (Updated March 14, 2016, 6:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When we show a Qt window it resets all wm_states, including the
> SKIP_TASKBAR state that Qt doesn't support see
> QXcbWindow::setNetWmStates
> 
> In order to set the flag we need to do it after Qt has mapped the
> window. (after a showEvent)
> 
> Dialog previously did this using ExposeEvent which we know will happen after 
> show.
> 
> However:
> 1) This is a rather random fix
> 2) It will be called after TaskManager has been notified of a new window
> 
> By merging into the same event we can make sure the flag is set before
> the task manager processes the new window. This means task manager will 
> always skip plasma popups.
> 
> A better fix will obviously be patching Qt to not reset flags it doesn't know 
> about 
> and then we can set this flag in the ctor. I shall try and do that for Qt 5.7.
> 
> BUG: 332024
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 
> 
> Diff: https://git.reviewboard.kde.org/r/127374/diff/
> 
> 
> Testing
> ---
> 
> Added debug in libtaskmanager, the window flags are always correct for the 
> new window.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127356: [Comic] Improvements

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127356/
---

(Updated Март 15, 2016, 8:23 преди обяд)


Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin.


Repository: kdeplasma-addons


Description
---

1. Correct highlighted tabs visablity
2. Scale content on update comic
3. Open/close fullview widget
4. Added icon
5. Resize content


Diffs (updated)
-

  applets/comic/comic.h 302f7b8 
  applets/comic/comic.cpp 97ec6a1 
  applets/comic/package/contents/ui/ComicCentralView.qml 59989b2 
  applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d 
  applets/comic/package/contents/ui/main.qml 4cf1cae 

Diff: https://git.reviewboard.kde.org/r/127356/diff/


Testing
---

Resize cannot get to work as i want :)
Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6
Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 
60% of current image, i don't understaind how this must be written to start 
working :P


File Attachments


Screenshot_20160312_214006.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel