Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128417/ --- Review request for Plasma. Repository: plasma-workspace Description --- This is the first step towards not loosing the sort order of the task buttons in the task bar, even when plasmashell crashes and the user has a specific manual sort order. For now, we use the sort order imposed by the creation time (so the user can affect the sort order simply by ordering the creation of the windows). Once this patch is successful, we can expand sort order storage by storing the manual sort order offset in the X window properties each time that offset changes. This will make plasmashell crashes less damaging to a user who prefers a certain task button sort order (for the duration of the X session). Diffs - libtaskmanager/CMakeLists.txt 9c3e15e libtaskmanager/tasksmodel.cpp bf37042 libtaskmanager/xwindowtasksmodel.h d24a7d5 libtaskmanager/xwindowtasksmodel.cpp c1e9495 Diff: https://git.reviewboard.kde.org/r/128417/diff/ Testing --- Testing was performed under openSUSE 42.1 against KDE Plasma 5.7 Thanks, Xuân Baldauf ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128402: Kickoff: Add option to hide Favorites tab
> On July 8, 2016, 9:35 a.m., Kai Uwe Broulik wrote: > > -1 > > > > What I would instead like is the ability to re-arrange and hide individual > > tabs, see Bug 361210, but not a corner-case solution for just the favorites. > > John Salatas wrote: > Yes! That would be great! Not sure if I can implement it through drag and > drop, but I could give it a try :\ > > Kai Uwe Broulik wrote: > As a first step already having the infrastructure in the applet, ie. a > stringlist setting favorites,applications,history,... and > the applet placing the tabs as configured would be nice. > > A fancy settings UI with drag and drop could be added at a later stage. > > David Edmundson wrote: > Or should we just hide if a model is empty? > > We have an existing bug on the leave tab existing even if all the entries > are disabled with kiosk. > > Kai Uwe Broulik wrote: > I made a patch for that a while ago (eg. hide History tab when empty) but > it was rejected for... "performance" reasons. Patch updated as per Kai Uwe Broulik's suggestion. Not sure if I did it the correct way but I guess I didn't as it is actually my first qml application :\ I would appreciate your feedback! - John --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/#review97199 --- On July 9, 2016, 6:48 p.m., John Salatas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128402/ > --- > > (Updated July 9, 2016, 6:48 p.m.) > > > Review request for Plasma. > > > Bugs: 361210 > https://bugs.kde.org/show_bug.cgi?id=361210 > > > Repository: plasma-desktop > > > Description > --- > > I'm using the Icons-Only Task Manager and it seems to me that the Favorites > tab in kickoff is somewhat redundant, as I have added launchers for all of my > favorites in the Icons-Only Task Manager. > So in this patch I'm introducing an option to hide any menu and also > according to bug 36210 to reorganize them. > > In the attached screenshot you can see > > 1) the configuration options: These are just the menu buttons than can be > rearranged via drag n drop and the also include a checkbox (checked: show it, > unchecked: hide it). > 2) The Kickoff menu with just 3 menu items (the other two are hidden). > > > Diffs > - > > applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION > applets/kickoff/package/contents/config/main.xml 2de73ba > applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION > applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b > applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c > applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 > applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128402/diff/ > > > Testing > --- > > Tested in KDE Neon Developer Stable (as of July 8, 2016) > > > File Attachments > > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png > > > Thanks, > > John Salatas > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128402: Kickoff: Add option to hide Favorites tab
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/ --- (Updated July 9, 2016, 6:48 p.m.) Review request for Plasma. Bugs: 361210 https://bugs.kde.org/show_bug.cgi?id=361210 Repository: plasma-desktop Description (updated) --- I'm using the Icons-Only Task Manager and it seems to me that the Favorites tab in kickoff is somewhat redundant, as I have added launchers for all of my favorites in the Icons-Only Task Manager. So in this patch I'm introducing an option to hide any menu and also according to bug 36210 to reorganize them. In the attached screenshot you can see 1) the configuration options: These are just the menu buttons than can be rearranged via drag n drop and the also include a checkbox (checked: show it, unchecked: hide it). 2) The Kickoff menu with just 3 menu items (the other two are hidden). Diffs (updated) - applets/kickoff/package/contents/code/ButtonTools.js PRE-CREATION applets/kickoff/package/contents/config/main.xml 2de73ba applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128402/diff/ Testing (updated) --- Tested in KDE Neon Developer Stable (as of July 8, 2016) File Attachments (updated) Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png Thanks, John Salatas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128409: IconItem: Use better approach to disable animation when going from invisible to visible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128409/ --- Review request for Plasma. Repository: plasma-framework Description --- Clearing the pixmap is actually wrong, because in some cases the IconItem::updatePolish() is not called when changing visibility. Diffs - src/declarativeimports/core/iconitem.h e73829b src/declarativeimports/core/iconitem.cpp 4f41b3b Diff: https://git.reviewboard.kde.org/r/128409/diff/ Testing --- Tests still pass. The bug (no icon rendered) can be sometimes experienced in task manager volume controls and systray popup pin button. This patch fixes it. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1231: Add Remote Access interface to KWayland
Kanedias added a comment. Can't we pass screen index along with all the invocations? Krfb (and other recording tools) will know the screen configuration as they reside in same wayland session. They'll get the buffer and the screen index and will know exactly what to map. Am I missing something here? Besides, I didn't find any mentions of multi-screen capabilities in Krfb at all. It currently works like this: d->framebufferImage = XGetImage(QX11Info::display(), id, 0, 0, QApplication::desktop()->width(), QApplication::desktop()->height(), AllPlanes, ZPixmap); If that's the requirement, there will be huge amount of work to implement it from ground up. Patchset for KRfb is already enormous and rewrites half of the input system into plugins instead of built-in libraries (to integrate it with fake-input). I doubt it will endure another set of additions, the review will take forever. I think we should implement screen indexing in protocol but start with passing screen №1 only for now. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Kanedias, graesslin Cc: plasma-devel, jensreuterberg, abetts, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 243 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/243/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 09 Jul 2016 11:28:29 + Build duration: 10 min CHANGE SET Revision e742d27137d5b97aef6876b577f3e25660779116 by ivan.cukic: (Adding default values for the SplashWindow constructor) change: edit ksplash/ksplashqml/splashwindow.h JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: TestSuite.org.kde.plasma.kickoff-test COBERTURA RESULTS Cobertura Coverage Report PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5299 (37%)CONDITIONAL 1382/5446 (25%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 37/92 (40%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3024 (5%)CONDITIONAL 88/3173 (3%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%)___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128408: IconItemTest: Set plasma theme to default rather than skipping tests if not default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128408/ --- Review request for Plasma. Repository: plasma-framework Description --- Default plasma theme is installed with plasma-framework, so there shouldn't be reason to skip tests. Diffs - autotests/iconitemtest.h e2e05c0 autotests/iconitemtest.cpp e6bbc66 Diff: https://git.reviewboard.kde.org/r/128408/diff/ Testing --- Tests still pass Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
