[Differential] [Updated] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

[Martin Gräßlin]

graesslin added a dependency: D2202: Support restarting the OpenGL compositor 
on Wayland.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2231

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2202: Support restarting the OpenGL compositor on Wayland

[Martin Gräßlin]

graesslin added a dependent revision: D2231: [plugins/qpa] Support 
SharingPlatformContext on the existing eglSurface and eglconfig.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2202

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4 lines] D2232: [plugins/hwcomposer] Use an RGBA_8888 format for rendering surface

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  When sharing surface and config used by the compositor scene with
  QtQuick's OpenGL context an RGBA surface makes Qt way more happy.

REPOSITORY
  rKWIN KWin

BRANCH
  hwcomposer-format-rgba

REVISION DETAIL
  https://phabricator.kde.org/D2232

AFFECTED FILES
  plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp
  plugins/platforms/hwcomposer/hwcomposer_backend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 65 lines] D2231: [plugins/qpa] Support SharingPlatformContext on the existing eglSurface and eglconfig

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  So far SharingPlatformContext was only used if the OpenGL context
  supports EGL_KHR_surfaceless_context. If not supported, KWin tried to
  create a context through the Wayland API. Unfortunately on hwcomposer
  platform this results in a crash as libhybris only supports the init
  of EGLDisplay for one native platform.
  
  This change tries to also use the SharingPlatformContext if there is
  an OpenGL context in general. It reuses the native EGLSurface created
  for the compositing scene and makes its own OpenGL context current on
  that surface, too. As KWin creates an FBO, it never renders to it, so
  it shouldn't matter at all.
  
  In order to prevent EGL_BAD_MATCH errors when making Qt's OpenGL context
  current also the EGLConfig from the scene is used to create the context.

TEST PLAN
  Tested on Nexus5 with qtvirtualkeyboard in KWin

REPOSITORY
  rKWIN KWin

BRANCH
  sharingplatform-hwcomposer

REVISION DETAIL
  https://phabricator.kde.org/D2231

AFFECTED FILES
  abstract_egl_backend.h
  platform.cpp
  platform.h
  plugins/qpa/abstractplatformcontext.cpp
  plugins/qpa/abstractplatformcontext.h
  plugins/qpa/integration.cpp
  plugins/qpa/sharingplatformcontext.cpp
  plugins/qpa/sharingplatformcontext.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2201: [platforms/wayland] Use XdgShell if available and prefer it

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINbec69b5705e1: [platforms/wayland] Use XdgShell if 
available and prefer it (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2201?vs=5254=5341

REVISION DETAIL
  https://phabricator.kde.org/D2201

AFFECTED FILES
  plugins/platforms/wayland/wayland_backend.cpp
  plugins/platforms/wayland/wayland_backend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 271 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/271/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 20:01:12 +
Build duration: 18 min

CHANGE SET
Revision c521b596e04310cc3fd8709b00ea38200d58ed28 by kde: ([Notifications 
Dataengine] Fix default timeout)
  change: edit dataengines/notifications/notifications.operations
Revision 35579e66489abb903721eb08215ac9f6a1fc5d38 by kde: ([Notifications] Only 
keep job finished notification in case of an error)
  change: edit applets/notifications/package/contents/ui/Jobs.qml
Revision 501bba4a51ba9d07009508d719ef03194682faeb by kde: ([Service Runner] 
Search through quot;Commentquot; as well)
  change: edit runners/services/servicerunner.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 11/11 (100%)FILES 50/67 (75%)CLASSES 50/67 (75%)LINE 1973/5345 
(37%)CONDITIONAL 1382/5474 (25%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 113/168 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 5/16 (31%)CLASSES 5/16 (31%)LINE 139/3070 (5%)CONDITIONAL 
88/3201 (3%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2204: [Service Runner] Search through "Comment" as well

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE501bba4a51ba: [Service Runner] Search through 
"Comment" as well (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2204?vs=5268=5332

REVISION DETAIL
  https://phabricator.kde.org/D2204

AFFECTED FILES
  runners/services/servicerunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, sebas
Cc: colomar, davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2223: [Notifications] Only keep job finished notification in case of an error

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE35579e66489a: [Notifications] Only keep job 
finished notification in case of an error (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2223?vs=5312=5331

REVISION DETAIL
  https://phabricator.kde.org/D2223

AFFECTED FILES
  applets/notifications/package/contents/ui/Jobs.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2222: [Notifications Dataengine] Fix default timeout

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEc521b596e043: [Notifications Dataengine] Fix 
default timeout (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D?vs=5311=5330

REVISION DETAIL
  https://phabricator.kde.org/D

AFFECTED FILES
  dataengines/notifications/notifications.operations

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

[rwooninck (Raymond Wooninck)]

rwooninck added a comment.


  I have been using this patch for a couple of days now and I haven’t 
experienced issues anymore with the screens.  Before the patch, I had the issue 
that despite the correct kscreen configuration, the panel would start on the 
wrong screen, etc. (This was then corrected by restarting plasmashell). Also 
from time to time I had the issue that one of the two screens would be 
completely black and no background or panel would be displayed.
  
  Both issues have no longer occurred, despite using three different setups 
(Single laptop screen, Home with external monitor as primary and laptop screen 
on the right, Work with external monitor as primary and laptop screen on the 
left).  Everything works now as it should.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: rwooninck, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2156: improve output identification

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  So far, no bad side effects that I can tell, even with the newer version.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2223#41241, @colomar wrote:
  
  > Even in some minutes, quite a few notifications can pile up in the queue if 
you do lots of operations.
  >  This would only be acceptable if they could all be collapsed into a single 
notification, but I don't know if that is possible,
  
  
  anyways, I trust your judgement on the matter! let's do it and see for a 
release how it works.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  In https://phabricator.kde.org/D2223#41238, @mart wrote:
  
  > if they would auto clear, but still stay for some minutes, i would be fine
  
  
  Even in some minutes, quite a few notifications can pile up in the queue if 
you do lots of operations.
  This would only be acceptable if they could all be collapsed into a single 
notification, but I don't know if that is possible,

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2212#41093, @andreaska wrote:
  
  > what's the reason for this pin stuff?
  
  
  many want to be able to keep the calendar open when doing something else, ie 
if you want to have a calendar at hand if you are talking with someone in a 
chat planning for stuff.
  in kde4 times we initially had both normal click anywhere to dismiss and we 
had terrible feedback, until we had to change to make it stay there (and of 
course group #2 that wanted the opposite thing went out with torches and 
pitchforks)
  but angry mobs aside, both use cases make sense, so the pin is here to stay.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: mart, broulik, drosca, andreaska, mck182, plasma-devel, jensreuterberg, 
abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[mart (Marco Martin)]

mart added a comment.


  if they would auto clear, but still stay for some minutes, i would be fine

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  @mart If you started a file transfer job at some point and now you neither 
have a progress indicator anymore, nor see an error message, what is supposed 
to have happened other than that it succeeded?
  
  Of all the file transfer job, the vast majority will complete successfully 
(hopefully, otherwise we have way bigger problems). Notifying about the success 
at the point it happens makes sense because it shows you "Ah good, now I can 
start working with the files at their destination!". However, long after that 
moment, if you see no indication of failure, you know it succeeded.
  
  Now that the notification queue does what it's supposed to do again in Plasma 
5.7, it's hugely annoying that it fills up with lots of "Coyping finished" 
messages that you have to manually remove although they tell you //nothing// 
you don't already know.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[mart (Marco Martin)]

mart added a comment.


  (no, don't like it)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  You do know, except it won't stick around forever (I got the habit of copying 
files, then clearing the notification history, it's so tedious). If something 
went wrong you'll either have the persistent error notification or a KIO error 
dialog anyway...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[mart (Marco Martin)]

mart added a comment.


  so i don't know what happened to the files i was copying, meh :(

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: mart, graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 48 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 16:02:28 +
Build duration: 56 sec

CHANGE SET
Revision 23f5907256fa439f8e77f204f184693dea513585 by David Edmundson: 
(Reposition the krunner window if the width changes)
  change: edit krunner/view.h
  change: edit krunner/view.cpp
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2201: [platforms/wayland] Use XdgShell if available and prefer it

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  xdg-shell-platform

REVISION DETAIL
  https://phabricator.kde.org/D2201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[David Edmundson]

> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as 
> > this creates now a race condition on startup where apps don't show up in 
> > the systray at all. That is if an application tries to create a systray 
> > icon before Plasma is started.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> it still creates a systray icon, it just creates an "old style" tray icon.
> 
> Martin Gräßlin wrote:
> > it still creates a systray icon, it just creates an "old style" tray 
> icon.
> 
> Which won't work on Wayland. And yes that's a valid point as we need to 
> think further than 3 months ;-)
> 
> Martin Gräßlin wrote:
> actually it won't even work on X11 as if Plasma is not up yet, neither 
> will be the xembed proxy. Which means no systray and Qt won't create it.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> won't it jump into the xembed proxy when it appears? I seem to recall 
> that happening, but I might be wrong.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> and regarding wayland, what does the "normal" platform plugin for wayland 
> do with QPlatformSystemTrayIcon?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> well, I looked in qtbase, and apparently Qt has a SNI implementation, so 
> the fallback here should work under wayland?
> 
> David Edmundson wrote:
> The Qt SNI won't work.
> 
> That's in QGenericUnixTheme - however because we load our platform theme 
> (which subclasses QPlatformTheme) we don't load it - and it's private API so 
> can't (without changing Qt)
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> Anyhow, you don't agree that it is better for the application to not get 
> a tray icon than recursing like this and not showing up at all and spinning 
> like crazy?

I do agree. But it's also important to base patches based on the right 
assumptions.

Which is why in the other comment thread I simply want to understand why the 
current solution doesn't work and how you end up in this situation where this 
is a problem before merging.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97514
---


On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128473/
> ---
> 
> (Updated July 17, 2016, 8:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> If the status notifier item host is not available, KSNI tries to create a 
> normal QSystemTrayIcon.
> 
> The plasma platform plugin uses KSNI when it is called to create a 
> QPlatformSystemTrayIcon.
> 
> So if the status notifier item host for any reason was unavailable, this 
> would recursively run forever (assuming a turing machine with infinite 
> memory).
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
>   src/platformtheme/kdeplatformtheme.cpp 5f0407c 
> 
> Diff: https://git.reviewboard.kde.org/r/128473/diff/
> 
> 
> Testing
> ---
> 
> Now it is possible to run applications that have tray icons with the plasma 
> platform plugin even when the status notifier item host is down or 
> unavailable.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[David Edmundson]

> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in 
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471  (in knotifications) - which 
> > basically checks if we're using the KDE platform theme (albeit in a 
> > slightly weird way)
> > 
> > Not saying yours is "worse" but we don't want two fixes in two places.
> > 
> > Could you check you have that patch? and why it doesn't work?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> firstly, as you said, it checks in a weird way, which doesn't work, 
> that's why I thought it made more sense to fix it in the platform theme 
> itself which already knows that it is loaded and whether an SNI host is 
> available.
> 
> (fwiw, qApp->platformName() is not correct either, that's what I thought 
> was the "proper" way to do it)
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> patching around that also leads to no legacy tray icon being created at 
> all, which is obviously wrong.

Is it wrong?

If you're logged in to a plasma session with the plasma integration running 
it's a valid assumption that people will run Plasmashell. 

Without plasmashell you won't get the legacy tray icons appearing either. 

And if you're running a different shell..you shouldn't be using the plasma 
integration in the first place.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97506
---


On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128473/
> ---
> 
> (Updated July 17, 2016, 8:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> If the status notifier item host is not available, KSNI tries to create a 
> normal QSystemTrayIcon.
> 
> The plasma platform plugin uses KSNI when it is called to create a 
> QPlatformSystemTrayIcon.
> 
> So if the status notifier item host for any reason was unavailable, this 
> would recursively run forever (assuming a turing machine with infinite 
> memory).
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
>   src/platformtheme/kdeplatformtheme.cpp 5f0407c 
> 
> Diff: https://git.reviewboard.kde.org/r/128473/diff/
> 
> 
> Testing
> ---
> 
> Now it is possible to run applications that have tray icons with the plasma 
> platform plugin even when the status notifier item host is down or 
> unavailable.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2223: [Notifications] Only keep job finished notification in case of an error

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.


  asking the testing question: how can we autotest this?

INLINE COMMENTS

> broulik wrote in Jobs.qml:88
> !! is the JavaScript-way of casting to a bool, error is the KIO error number.
> 
> I could do Boolean(error) or error ? true : false if you like. I do a 
> toBool() in the notification action but I'd prefer being explicit here

ok, I wasn't aware of this language element. It looks weird (well all of 
JavaScript looks weird to my C++-eyes).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> graesslin wrote in Jobs.qml:88
> why !!

!! is the JavaScript-way of casting to a bool, error is the KIO error number.

I could do Boolean(error) or error ? true : false if you like. I do a toBool() 
in the notification action but I'd prefer being explicit here

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  +1 from me (of course, since it was my request ;) )

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D2223: [Notifications] Only keep job finished notification in case of an error

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> Jobs.qml:88
>  body: errorText || message,
> -isPersistent: true,
> +isPersistent: !!error, // we'll assume success to be the 
> note-unworthy default, only be persistent in error case
>  urgency: 0,

why !!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: graesslin, colomar, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2222: [Notifications Dataengine] Fix default timeout

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

[broulik (Kai Uwe Broulik)]

broulik added a dependent revision: D2223: [Notifications] Only keep job 
finished notification in case of an error.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D2223: [Notifications] Only keep job finished notification in case of an error

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
broulik added a dependency: D: [Notifications Dataengine] Fix default 
timeout.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As requested by Usability we'll assume a job finished successfully as the 
most likely case and only keep the notification persistent in case of an error. 
This makes dealing with files significantly less annoying.

TEST PLAN
  Depends on https://phabricator.kde.org/D (hooray, repdigit \o/)
  
  selected file, Ctrl+C, Ctrl+V in the same folder, waited a bit for the job to 
show up, now:
  
  - Canceled transfer,, got a persistent "Copying: Failed" notification
  - Chose different file name, got a regular "Copying: Finished" notification, 
nothing in my history
  
  Note: Technically canceling is an "error" and I didn't know any other way to 
trigger that but obviously we don't show a notification in this case as it 
would be pointless. This was just for testing and not part of this patch :)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2223

AFFECTED FILES
  applets/notifications/package/contents/ui/Jobs.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2222: [Notifications Dataengine] Fix default timeout

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 1 line] D2222: [Notifications Dataengine] Fix default timeout

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As per notification spec the value "0" means "persistent notification" 
whereas "-1" means "server default timeout", so when no timeout is explicitly 
specified, it will always yield a persistent notification.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D

AFFECTED FILES
  dataengines/notifications/notifications.operations

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2212#41053, @andreaska wrote:
  
  > the reduced calender size in the widget is way better than before, but 
what's with the text (time) in the panel? the time height in the panel should 
be the same height than the system tray icon
  
  
  This is because on the "before" i use plasmashell from my distrib, "after" 
compiled from myself and the latter has font issues.
  
  In https://phabricator.kde.org/D2212#41057, @broulik wrote:
  
  > The spacing is completely off now and the pin overlaps the calendar...
  
  
  True, I haven't see that. Sh*t!
  
  Anyway, it's really too big ATM. it takes more than half of my screen, with 
huge fonts: it's ridiculous I think.
  I can work on this, but I'll need some pointers on what and where to change 
things.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: broulik, drosca, andreaska, mck182, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2154: kscreen kcm: block changed signal after save

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN4b69f8708e63: kscreen kcm: block changed signal after 
save (authored by sebas).

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2154?vs=5309=5310

REVISION DETAIL
  https://phabricator.kde.org/D2154

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, graesslin
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 22 lines] D2154: kscreen kcm: block changed signal after save

[Sebastian Kügler]

sebas updated this revision to Diff 5309.
sebas added a comment.


  - Add comment explaining the hack

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2154?vs=5139=5309

BRANCH
  blockkcmchanges

REVISION DETAIL
  https://phabricator.kde.org/D2154

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/kcm_kscreen.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 33 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 13:59:10 +
Build duration: 49 sec

CHANGE SET
Revision 578fffd64d379fc59da3b7e6ffd9117285c28ae5 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit knetattach/org.kde.knetattach.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[Martin Tobias Holmedahl Sandsmark]

> On July 18, 2016, 5:49 a.m., Martin Gräßlin wrote:
> > I acknowledge the problem in general, but I think the solution is wrong as 
> > this creates now a race condition on startup where apps don't show up in 
> > the systray at all. That is if an application tries to create a systray 
> > icon before Plasma is started.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> it still creates a systray icon, it just creates an "old style" tray icon.
> 
> Martin Gräßlin wrote:
> > it still creates a systray icon, it just creates an "old style" tray 
> icon.
> 
> Which won't work on Wayland. And yes that's a valid point as we need to 
> think further than 3 months ;-)
> 
> Martin Gräßlin wrote:
> actually it won't even work on X11 as if Plasma is not up yet, neither 
> will be the xembed proxy. Which means no systray and Qt won't create it.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> won't it jump into the xembed proxy when it appears? I seem to recall 
> that happening, but I might be wrong.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> and regarding wayland, what does the "normal" platform plugin for wayland 
> do with QPlatformSystemTrayIcon?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> well, I looked in qtbase, and apparently Qt has a SNI implementation, so 
> the fallback here should work under wayland?
> 
> David Edmundson wrote:
> The Qt SNI won't work.
> 
> That's in QGenericUnixTheme - however because we load our platform theme 
> (which subclasses QPlatformTheme) we don't load it - and it's private API so 
> can't (without changing Qt)

Anyhow, you don't agree that it is better for the application to not get a tray 
icon than recursing like this and not showing up at all and spinning like crazy?


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97514
---


On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128473/
> ---
> 
> (Updated July 17, 2016, 8:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> If the status notifier item host is not available, KSNI tries to create a 
> normal QSystemTrayIcon.
> 
> The plasma platform plugin uses KSNI when it is called to create a 
> QPlatformSystemTrayIcon.
> 
> So if the status notifier item host for any reason was unavailable, this 
> would recursively run forever (assuming a turing machine with infinite 
> memory).
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
>   src/platformtheme/kdeplatformtheme.cpp 5f0407c 
> 
> Diff: https://git.reviewboard.kde.org/r/128473/diff/
> 
> 
> Testing
> ---
> 
> Now it is possible to run applications that have tray icons with the plasma 
> platform plugin even when the status notifier item host is down or 
> unavailable.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2154: kscreen kcm: block changed signal after save

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rKSCREEN KScreen

BRANCH
  blockkcmchanges

REVISION DETAIL
  https://phabricator.kde.org/D2154

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma, graesslin
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[Martin Tobias Holmedahl Sandsmark]

> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in 
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471  (in knotifications) - which 
> > basically checks if we're using the KDE platform theme (albeit in a 
> > slightly weird way)
> > 
> > Not saying yours is "worse" but we don't want two fixes in two places.
> > 
> > Could you check you have that patch? and why it doesn't work?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> firstly, as you said, it checks in a weird way, which doesn't work, 
> that's why I thought it made more sense to fix it in the platform theme 
> itself which already knows that it is loaded and whether an SNI host is 
> available.
> 
> (fwiw, qApp->platformName() is not correct either, that's what I thought 
> was the "proper" way to do it)

patching around that also leads to no legacy tray icon being created at all, 
which is obviously wrong.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97506
---


On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128473/
> ---
> 
> (Updated July 17, 2016, 8:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> If the status notifier item host is not available, KSNI tries to create a 
> normal QSystemTrayIcon.
> 
> The plasma platform plugin uses KSNI when it is called to create a 
> QPlatformSystemTrayIcon.
> 
> So if the status notifier item host for any reason was unavailable, this 
> would recursively run forever (assuming a turing machine with infinite 
> memory).
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
>   src/platformtheme/kdeplatformtheme.cpp 5f0407c 
> 
> Diff: https://git.reviewboard.kde.org/r/128473/diff/
> 
> 
> Testing
> ---
> 
> Now it is possible to run applications that have tray icons with the plasma 
> platform plugin even when the status notifier item host is down or 
> unavailable.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[Martin Tobias Holmedahl Sandsmark]

> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in 
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471  (in knotifications) - which 
> > basically checks if we're using the KDE platform theme (albeit in a 
> > slightly weird way)
> > 
> > Not saying yours is "worse" but we don't want two fixes in two places.
> > 
> > Could you check you have that patch? and why it doesn't work?

firstly, as you said, it checks in a weird way, which doesn't work, that's why 
I thought it made more sense to fix it in the platform theme itself which 
already knows that it is loaded and whether an SNI host is available.

(fwiw, qApp->platformName() is not correct either, that's what I thought was 
the "proper" way to do it)


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128473/#review97506
---


On July 17, 2016, 8:14 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128473/
> ---
> 
> (Updated July 17, 2016, 8:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-integration
> 
> 
> Description
> ---
> 
> If the status notifier item host is not available, KSNI tries to create a 
> normal QSystemTrayIcon.
> 
> The plasma platform plugin uses KSNI when it is called to create a 
> QPlatformSystemTrayIcon.
> 
> So if the status notifier item host for any reason was unavailable, this 
> would recursively run forever (assuming a turing machine with infinite 
> memory).
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformsystemtrayicon.h 6825b4d 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 0e82385 
>   src/platformtheme/kdeplatformtheme.cpp 5f0407c 
> 
> Diff: https://git.reviewboard.kde.org/r/128473/diff/
> 
> 
> Testing
> ---
> 
> Now it is possible to run applications that have tray icons with the plasma 
> platform plugin even when the status notifier item host is down or 
> unavailable.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2218: New logic for screen numbers in plasmashell

[mart (Marco Martin)]

mart updated the summary for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma 5.7.2

[Jonathan Riddell]

Plasma 5.7.2 is now released https://www.kde.org/announcements/plasma-5.7.2.php
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 999 lines] D2218: New logic for screen numbers in plasmashell

[mart (Marco Martin)]

mart updated this revision to Diff 5308.
mart added a comment.


  - use .data and remoe dead code

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2218?vs=5296=5308

BRANCH
  mart/screenConnectorManagement

REVISION DETAIL
  https://phabricator.kde.org/D2218

AFFECTED FILES
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/autotests/desktopview.cpp
  shell/autotests/desktopview.h
  shell/autotests/screenpooltest.cpp
  shell/desktopview.cpp
  shell/desktopview.h
  shell/panelview.cpp
  shell/panelview.h
  shell/screenpool.cpp
  shell/screenpool.h
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in panelview.cpp:679-684
> what about that connect?

right, that didn't work, it tried to be too smart and moved the panel around,
while now when m_screenToFollow goes away, the panel view gets deleted 
externally in ShellCorona::removeDesktop

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 284 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5302.
bdhruve added a comment.


  - Fixed automatic selection of backend to look for WAYLAND_SOCKET also
  - Rendering kwin instance
  - Fixed minor issues.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=5014=5302

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, #plasma_on_wayland, graesslin
Cc: bshah, graesslin, plasma-devel, kwin, hardening, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND5732215ea7ba: Expose Geometry in PlasmaWindowModel. 
(authored by hein).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2203?vs=5298=5301

REVISION DETAIL
  https://phabricator.kde.org/D2203

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Reopened] D2156: improve output identification

[Sebastian Kügler]

sebas reopened this revision.
sebas added a comment.


  (Pushed a branch for testing which closed this request. This patch is not 
merged, yet.)

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D2156: improve output identification

[Sebastian Kügler]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKSCREEN1b1c51cddda7: improve output identification (authored 
by sebas).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2156?vs=5194=5300#toc

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2156?vs=5194=5300

REVISION DETAIL
  https://phabricator.kde.org/D2156

AFFECTED FILES
  kded/serializer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D2203: Expose Geometry in PlasmaWindowModel.

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  How about we keep it as one option and only add more fine-grained controls of 
users demand it?
  
  If we want to do fine-grained options right away, it should be hidden behind 
an "Advanced" expander (see 
https://techbase.kde.org/Projects/Usability/HIG/Settings ), since it's only a 
corner-case which can be safely ignored by most users.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: broulik, colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 284 lines] D2219: Add option to enable volume feedback

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Play "pop" sound when changing volume
  BUG: 365197

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  volume-feedback (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2219

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml
  cmake/FindCanberra.cmake
  src/qml/CMakeLists.txt
  src/qml/plugin.cpp
  src/qml/volumefeedback.cpp
  src/qml/volumefeedback.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2219: Add option to enable volume feedback

[drosca (David Rosca)]

drosca added a reviewer: Plasma: Design.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2219

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Abandoned] D2217: Add option to disable OSD on volume change

[drosca (David Rosca)]

drosca abandoned this revision.
drosca added a comment.


  > That looks like a way better way to do it, if we decide for it.
  
  Agree

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: broulik, colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dfaure wrote in kdeplatformfiledialoghelper.cpp:78
> Can you explain and document here what this function does, i.e. input args 
> and return value? It's a bit confusing.
> 
> "kde" is a mimetype name, e.g. application/zip right?
> "list" is a list of  mimetype names?
> 
> I'm confused because the calling code is
> 
>   return kde2QtFilter(options()->nameFilters(), 
> m_dialog->selectedNameFilter());
> 
> which looks like "Plain Text (*.txt)" type filter to me, but I guess it can 
> also be "Plain Text (text/plain)" ? Or is that wrong ?
> It's strange because in the QFileDialog docu, name filters and mimetype 
> filters are two different things...
> 
> Documenting examples here would be useful.
> 
> I see that the patch adds support for the (*.txt) case. Then the commit log 
> is incomplete, because this isn't just about multiple mimetypes, but also 
> about (non-mimetype-based) name filters, right?
> The commit log also says "for some reason" which sounds like the problem 
> isn't fully understood, and says "when we're about to return empty" which 
> sounds too-last-minute and doesn't match this version of the patch.
> Please revise the commit log and document the inputs/outputs of this method, 
> then look at adding a unittest ;)
> Thanks!

Note that the "manually set" name filters seem currently broken (there is a 
`QEXPECT_FAIL` in `testSelectNameFilter()`), which is why I was only 
considering the "official" filters defined in the shared-mime-info database.

Anyway, I'll try to write an unit test :)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D1813

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, #plasma
Cc: dfaure, graesslin, mart, plasma-devel, #plasma, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D2217#41094, @broulik wrote:
  
  > See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771
  >
  > What I could imagine is having a list of check boxes there:
  >  "Show visual feedback for:"
  >
  > - [  ] Volume change
  > - [  ] Brightness change
  > - etc
  
  
  That looks like a way better way to do it, if we decide for it.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: broulik, colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 47 lines] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

hein updated this revision to Diff 5298.
hein added a comment.


  Shake up x/y.

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2203?vs=5292=5298

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2203

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  See https://phabricator.kde.org/D1770 and https://phabricator.kde.org/D1771
  
  What I could imagine is having a list of check boxes there:
  "Show visual feedback for:"
  
  - [  ] Volume change
  - [  ] Brightness change
  - etc
  
  but then I don't think we should do that.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: broulik, colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[andreaska (Andreas Kainz)]

andreaska added a comment.


  what's the reason for this pin stuff?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: broulik, drosca, andreaska, mck182, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I agree with Martin: Either people want to see an OSD when changing a 
parameter using the keyboard, or they don't. 
  Like Martin, I don't see why someone would want an OSD when changing screen 
brightness with the keyboard, but not when changing volume.
  
  Would it be possible to link to the KCM where OSDs can be configured from the 
volume applet settings? That would make it easier for people who are only 
annoyed by the volume OSD to find the setting...

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: colomar, graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D2217#41086, @drosca wrote:
  
  > I think there already is global option to disable OSD, but I think it makes 
sense to just disable OSD for volume. Also kmix has this option and there are 
users that want it.
  
  
  I'm not sure. Where's the difference to screen brightness or changing 
keyboard layout? Why does audio volume need a dedicated option for it?
  
  Anyway please add VDG to the review.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D2218: New logic for screen numbers in plasmashell

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> panelview.cpp:679-684
> +/*connect(screen, ::destroyed, this, [this]() {
> +if (PanelView::screen()) {
> +m_screenToFollow = PanelView::screen();
> +adaptToScreen();
> +}
> +});*/

what about that connect?

> panelview.cpp:693
> +{
> +return m_screenToFollow;
> +}

m_screenToFollow.data()

otherwise it won't compile with older gcc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 10:47:19 +
Build duration: 55 sec

CHANGE SET
Revision 5da5af2d975c54bd92df024bbadff94f7e3c304c by Jonathan Riddell: (Update 
version number for 5.7.2 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 32 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 10:45:39 +
Build duration: 4 min 59 sec

CHANGE SET
Revision 420b5595733101c63c7c7566319ed28de7415ab9 by Jonathan Riddell: (Update 
version number for 5.7.2 GIT_SILENT)
  change: edit CMakeLists.txt
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[drosca (David Rosca)]

drosca added a comment.


  I think there already is global option to disable OSD, but I think it makes 
sense to just disable OSD for volume. Also kmix has this option and there are 
users that want it.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2218: New logic for screen numbers in plasmashell

[mart (Marco Martin)]

mart added a reviewer: Plasma.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2218

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[Martin Gräßlin]

graesslin added a comment.


  Does it make sense to add an option for this to the plasmoid? If there is a 
need to disable osds, shouldn't we rather do it globally and disable all osd?

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 1,005 lines] D2218: New logic for screen numbers in plasmashell

[mart (Marco Martin)]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  screen numbers for containments are not anymore a sequential
  number starting from 0, but make the numbers correspond
  1:1 to screen connector names, so if DVI-1-1 is 0 and
  VGA-0 is 1, they will stay so trough different sessions.
  the only exception in which screens can be juggled around is
  when the "primary" screen changes, which is always the
  number 0

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  mart/screenConnectorManagement

REVISION DETAIL
  https://phabricator.kde.org/D2218

AFFECTED FILES
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/autotests/desktopview.cpp
  shell/autotests/desktopview.h
  shell/autotests/screenpooltest.cpp
  shell/desktopview.cpp
  shell/desktopview.h
  shell/panelview.cpp
  shell/panelview.h
  shell/screenpool.cpp
  shell/screenpool.h
  shell/scripting/scriptengine.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 10:41:48 +
Build duration: 1 min 22 sec

CHANGE SET
Revision 352a104d52966e57d4f03d9bbd8af9b5620cede9 by Jonathan Riddell: (Update 
version number for 5.7.2 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: khotkeys Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 5 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 19 Jul 2016 10:41:48 +
Build duration: 1 min 22 sec

CHANGE SET
Revision 352a104d52966e57d4f03d9bbd8af9b5620cede9 by Jonathan Riddell: (Update 
version number for 5.7.2 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

[drosca (David Rosca)]

drosca added a comment.


  F188070: Screenshot_20160719_122725.png 

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2217: Add option to disable OSD on volume change

[drosca (David Rosca)]

drosca added a reviewer: Plasma: Design.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2217

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, #plasma:_design
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 96 lines] D2217: Add option to disable OSD on volume change

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 363983

TEST PLAN
  I'm not really sure on the label "Show OSD" as that may not be
  clear to user what it is, better ideas?

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  osd-option (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2217

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  The spacing is completely off now and the pin overlaps the calendar...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: broulik, drosca, andreaska, mck182, plasma-devel, jensreuterberg, abetts, 
sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[drosca (David Rosca)]

drosca added a comment.


  The calendar popup size is fine for me (with patched plasma-framework), what 
I *still* think is broken is the gridSize scaling - see 
https://git.reviewboard.kde.org/r/125773/
  
  You can also test it simply by switching font to DejaVu Sans.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: drosca, andreaska, mck182, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[andreaska (Andreas Kainz)]

andreaska added a comment.


  the reduced calender size in the widget is way better than before, but what's 
with the text (time) in the panel? the time height in the panel should be the 
same height than the system tray icon

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: andreaska, mck182, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128485: Reposition the krunner window if the width changes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128485/#review97595
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Juli 19, 2016, 4:31 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128485/
> ---
> 
> (Updated Juli 19, 2016, 4:31 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is mostly useful for the first run where the first showEvent() happens 
> whilst we have a width of 0. Leading to krunner starting in a random place 
> sometimes.
> 
> Width changing could also theoretically happen at any other time if a 
> different l had a krunner that dynamically changed size all over the place.
> 
> 
> Diffs
> -
> 
>   krunner/view.h 7314a2132ce5a9f409d7c164bccf99bb6ea5f144 
>   krunner/view.cpp 1783a46f1596f899936cd6137f1a606bd9ea3ffb 
> 
> Diff: https://git.reviewboard.kde.org/r/128485/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128484: Don't set a Window Icon on Plamsa::Dialog

[Kai Uwe Broulik]

> On Juli 19, 2016, 5:44 vorm., Martin Gräßlin wrote:
> > In KWin it can be seen when e.g. activating Present Windows while Kickoff 
> > is open or the calendar. Also in Alt+Tab this could happen.
> > 
> > KWin will show an icon - always - in the worst case it will be the generic 
> > X icon. If we go for that we must make sure that Plasma window are excluded 
> > from all KWin elements.

I thought that was the idea but we set skip pager and skip taskbar but that 
doesn't imply skip $other-effects (which is to be expected, I suppose) so we 
have the situation we're in now.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128484/#review97586
---


On Juli 19, 2016, 4:26 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128484/
> ---
> 
> (Updated Juli 19, 2016, 4:26 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's practically never visible.
> 
> Window flags are always masked with FramelessWindowHint and we always
> have the state NET::SkipTaskbar | NET::SkipPager set.
> 
> (There is theoretically a code path that would allow an icon to be
> visible in some kwin effects that overlay icons..but not triggerable by
> anything in Plasma, at which point why would you want a Plasma icon
> anyway)
> 
> This saves a bit of memory (up to 512K) as window icons are always
> loaded at every size to set the _NET_WM_ICON.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp be7406725ff0876f7ebee63c752e6ea84f90e577 
> 
> Diff: https://git.reviewboard.kde.org/r/128484/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 117 lines] D2216: [platforms/virtual] Use rendernode or vgem device if available for egl

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The egl implementation for the virtual platform tries to use a render
  node if available. If there is no render node it looks for a virtual
  (kernel driver vgem) device, which unfortunately does not create a
  render node in mainline kernel (there are patches in ChromiumOS).
  
  For this the Udev wrapper is extended to search for renderNode devices
  and for virtual dri devices.
  
  If either render node or vgem dri device is found, it is tried to be
  opened (without logind escalation) and on success a gbm device is
  created on it. If any step of this fails the so far default behavior
  of default device is tried for creating the EGLDisplay.
  
  All of this is compile optional, so that the virtual platform does not
  hard depend on udev and/or gbm.

TEST PLAN
  Auto tests which need OpenGL executed and verified that they
  use the render node or vgem device.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-render-node-vgem

REVISION DETAIL
  https://phabricator.kde.org/D2216

AFFECTED FILES
  CMakeLists.txt
  config-kwin.h.cmake
  plugins/platforms/virtual/CMakeLists.txt
  plugins/platforms/virtual/egl_gbm_backend.cpp
  plugins/platforms/virtual/egl_gbm_backend.h
  udev.cpp
  udev.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, hardening, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D2203: Expose Geometry in PlasmaWindowModel.

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_plasma_window_model.cpp:463
> +
> +const QRect geom(0, 0, 50, 75);
> +w->setGeometry(geom);

and what about x and y?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  Before: 
  F188019: Screenshot_20160719_101221.png 
  
  After:
  F188021: Screenshot_20160719_101336.png 

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, #plasma:_design, #plasma, davidedmundson
Cc: mck182, plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 47 lines] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

hein updated this revision to Diff 5292.
hein added a comment.


  Drop flush/dispatch; use different values for width and height.

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2203?vs=5267=5292

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2203

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, graesslin, #plasma
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> graesslin wrote in test_plasma_window_model.cpp:460-461
> those two should not be needed.

Dropped.

> graesslin wrote in test_plasma_window_model.cpp:466
> could you use different values? E.g. if we swapped width and height, we 
> wouldn't notice.

Done.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> hein wrote in test_plasma_window_model.cpp:446-447
> I copied that from testBooleanData

Also m_pw is not actually a model but a PlasmaWindowManagement :-)

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2203: Expose Geometry in PlasmaWindowModel.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> graesslin wrote in test_plasma_window_model.cpp:446-447
> you don't need to create a model. You have one in m_pw

I copied that from testBooleanData

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D2203

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, graesslin
Cc: plasma-devel, jensreuterberg, abetts, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel