Re: Failing unittests

[Martin Graesslin]

On Saturday, August 6, 2016 8:12:06 PM CEST David Faure wrote:
> Today is KF 5.25 tagging day, but the CI isn't green...
> kwayland: testWaylandFullscreenShell fails

Sorry about that. It's caused by a newer weston version [1] which got 
installed on Friday on build.kde.org. I just pushed a fix which QSKIPs if the 
old interface is not announced.

Cheers
Martin

[1] The Weston specific fullscreen shell extension got moved to Wayland 
Protocols and renamed to the conventions there.



signature.asc
Description: This is a digitally signed message part.

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

[Raman Gupta via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=357288

Raman Gupta  changed:

   What|Removed |Added

Version|5.5.0   |5.7.3

--- Comment #4 from Raman Gupta  ---
This seemed to have been working for a while, but is now broken again in 5.7.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Selecting a Plasma logo

[Marco Martin]

On Sunday 07 August 2016, Clemens Toennies wrote:
> 2016-08-07 8:19 GMT+02:00 Ivan Čukić https://mail.kde.org/mailman/listinfo/plasma-devel>>:
> >//>/Do you have screenshots? />//>/Cheers, />/Ivan /
> 
> Here is some variant from Uris logo to be used as startbutton:
> https://www.dropbox.com/s/4eyofwx1kiqyq9g/plasma-icons-uri.png?dl=0

having it in a square as part of the logo surrounding it actually alleviates 
(tought not completely solves) one that i think is the biggest problem of this 
one, it brings it from 4 disjointed elements to an overall single shape (a 
charateristic that i find quite important in a logo)


-- 
Marco Martin

Re: Selecting a Plasma logo

[Marco Martin]

On Tuesday 02 August 2016, Ken Vermette wrote:
> I don't mean to be "that guy", but he submitted his logo under the LGPLv3,
> signalling that everyone has the right to modify his work. I'm not saying
> this because I have a horse in this race, I'm saying it because, frankly,
> the idea that we "aren't allowed" to collaborate and remix artwork in an
> open-source project is extremely distasteful to our core values... The idea
> that we would be beholden to a single author for every tweak is ridiculous.

Agree, this devalues a bit that entry for me, as i think the unmodified 
version is not quite enough, and modifying it after it has been chosen means 
that the logo that ends up being used is not the one that has been chosen.
perhaps the rules should have stated explicitly that this was going to be an 
iterative process.

-- 
Marco Martin

[Differential] [Abandoned] D2363: Use prefered backend if none is specified

[cordlandwehr (Andreas Cord-Landwehr)]

cordlandwehr abandoned this revision.
cordlandwehr added a comment.


  I figured out that this "fix" is wrong, since there is already code handling 
an empty backend name string by falling back to the preferred backend.
  Will investigate why that code is not triggered for me.

REPOSITORY
  rLIBKSCREEN KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D2363

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, #plasma, sebas
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2365: Add failing test case for selected filter from mimetype

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  I think I figured out what's going on. This seems to be a regression 
introduced by 
https://phabricator.kde.org/rPLASMAINTEGRATION25be75542f831863e905b590b6429127df1b13d3.
 If I revert this commit, this test passes.
  
  So, this is what's happening. In this example I'm considering the 
`text/x-chdr` test case:
  
  1. The test calls `dialog.setMimeTypeFilters("text/x-chdr")` and then 
`dialog.show()`
  2. `KDEPlatformFileDialogHelper::show()` calls `initializeDialog()`
  3. In `initiliazeDialog()` we end up appending `text/x-chdr` to the filters 
of `m_fileWidget`'s KFileFilterCombo (`d->m_filters` in 
`kio.git/src/filewidgets/kfilefiltercombo.cpp`)
  4. In the test we call `dialog.selectMimeTypeFilter("text/x-chdr")`
  5. QFileDialog calls `selectNameFilter("C header (*.h)")`
  6. KDEPlatformFileDialogHelper calls 
`selectNameFilter(qt2KdeFilter(QStringList("C header (*.h)")))`
  7. KDEPlatformFileDialog calls `filterWidget()->setCurrentFilter("*.h|C 
header ")`
  8. The KFileFilterCombo ends up calling 
`setCurrentIndex(d->m_filters.indexOf("*.h|C header "))` which fails because 
`d->m_filters` contains only `text/x-chdr`.
  9. `dialog.selectedNameFilter()` returns an empty string because of step 8.
  
  So the bug seems to be in the step 3. Before of commit 
https://phabricator.kde.org/rPLASMAINTEGRATION25be75542f831863e905b590b6429127df1b13d3,
 `d->m_filters` would also receive `*.h|C header ` which would make the test 
pass.
  
  But I'm still not sure how to properly fix this...

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, dfaure, graesslin
Cc: plasma-devel, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 347 lines] D1989: Introduce QQuickItem to nest kwin_wayland

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 5713.
bdhruve added a comment.


  Pass different input events from QML to Kwin,
  
  - Use mouse hover events to set pointer position.
  - Mouse press/release events to send pointer button events.
  - KeyPress events to send keys.
  
  However, keyevents are not working as it should, if i press 'a' it types 
something different.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1989?vs=5389=5713

BRANCH
  kwinqml

REVISION DETAIL
  https://phabricator.kde.org/D1989

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/qml/CMakeLists.txt
  plugins/qml/kwinqml/CMakeLists.txt
  plugins/qml/kwinqml/kwinplugin.cpp
  plugins/qml/kwinqml/kwinplugin.h
  plugins/qml/kwinqml/kwinqml.cpp
  plugins/qml/kwinqml/kwinqml.h
  plugins/qml/kwinqml/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, #plasma_on_wayland
Cc: bshah, graesslin, plasma-devel, kwin, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Re: Review Request 128552: Distinguish symlinks from other files in folder view plasmoid

[Chinmoy Ranjan Pradhan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128552/#review98166
---



Ping -- Eike

- Chinmoy Ranjan Pradhan


On Aug. 4, 2016, 10:55 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128552/
> ---
> 
> (Updated Aug. 4, 2016, 10:55 a.m.)
> 
> 
> Review request for Plasma, Eike Hein and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> In folder view plasmoid symlinks and ordinary files look similar. This patch 
> makes the symlink look different by italicising its name and adding an icon 
> overlay.
> 
> 
> Diffs
> -
> 
>   containments/desktop/package/contents/ui/FolderItemDelegate.qml e4fcd67 
>   containments/desktop/plugins/folder/foldermodel.h a6992bb 
>   containments/desktop/plugins/folder/foldermodel.cpp 6abfb6b 
> 
> Diff: https://git.reviewboard.kde.org/r/128552/diff/
> 
> 
> Testing
> ---
> 
> build
> 
> 
> File Attachments
> 
> 
> symlinks and other files/folders look similar
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/7428b23d-03f9-4aed-8ca0-536d44e45e8c__beforepatch.png
> after patch , everything looks fine
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/29/040b2e3b-9ea0-4347-9e6c-ca3bdb73b36a__link.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

[plasma-framework] autotests: Skip autotest that is broken with Qt 5.5

[David Faure]

Git commit 8abeceaffd0c93028810ea12131b7fa8bcd13b12 by David Faure.
Committed on 07/08/2016 at 11:25.
Pushed by dfaure into branch 'master'.

Skip autotest that is broken with Qt 5.5

Eike Hein said this was fixed by David Rosca in Qt >= 5.6.1.

CCMAIL: plasma-devel@kde.org

M  +3-0autotests/dialogstatetest.cpp

http://commits.kde.org/plasma-framework/8abeceaffd0c93028810ea12131b7fa8bcd13b12

diff --git a/autotests/dialogstatetest.cpp b/autotests/dialogstatetest.cpp
index f8ac9bc..333f74f 100644
--- a/autotests/dialogstatetest.cpp
+++ b/autotests/dialogstatetest.cpp
@@ -37,6 +37,9 @@ void DialogStateTest::cleanupTestCase()
 
 void DialogStateTest::windowState()
 {
+#if QT_VERSION < QT_VERSION_CHECK(5, 6, 0)
+QSKIP("This test is broken with Qt 5.5");
+#endif
 for (int i = 0; i <= 100; ++i) {
 m_dialog->show();
 

Re: Selecting a Plasma logo

[Clemens Toennies]

2016-08-07 8:19 GMT+02:00 Ivan Čukić https://mail.kde.org/mailman/listinfo/plasma-devel>>:

>//>/Do you have screenshots? />//>/Cheers, />/Ivan /


Here is some variant from Uris logo to be used as startbutton:
https://www.dropbox.com/s/4eyofwx1kiqyq9g/plasma-icons-uri.png?dl=0

Note this mod is not done by Uri (nor me), and I personally would think
the biggest circle should be placed a bit lower again.
Still find it fresh and good looking as a startbutton.

Greetings, Clemens.

[kio-extras] [Bug 366488] New: Too many sftp.so processes, not closing

[Nikita Skovoroda via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366488

Bug ID: 366488
   Summary: Too many sftp.so processes, not closing
   Product: kio-extras
   Version: unspecified
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: chalk...@gmail.com

It looks like something constantly spawns new sftp.so processes without killing
the old ones.

Atm, I have 110 running sftp.so processes totalling to over 1 GiB RSS. I'm sure
I don't have that many sftp directories open.

Reproducible: Always

Steps to Reproduce:
0. Kill all Dolphin and sftp.so instances (or just make sure those are not
running) 
1. Open Dolphin
2. Open something over sftp:// protocol.
3. Wait about a minute.
4. Navigate to another, local directory
5. Open something else over sftp:// protocol in the same tab
6. Wait about a minute.
7. Open a new tab poiting to a local directory and close the first tab


Actual Results:  
1. There are 0 sftp.so processes running, totalling in 0 MiB.
2. There are 4 sftp.so processes running, totalling in 16 MiB.
3. There are 5 sftp.so processes running, totalling in 20 MiB.
4. There are 5 sftp.so processes running, totalling in 20 MiB.
5. There are 8 sftp.so processes running, totalling in 32 MiB.
6. There are 10 sftp.so processes running, totalling in 40 MiB.
7. There are 10 sftp.so processes running, totalling in 40 MiB.

Expected Results:  
I expect sftp.so old processes to be killed after a certain amount of time if
they couldn't be reused.

Some of the sftp.so processes present are over a month old.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Selecting a Plasma logo

[kainz.a]

when I have time I can do it for all logos.

https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/plasma-logo.png
https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/plasmaLogoUri.png

cheers
Andreas

2016-08-07 8:19 GMT+02:00 Ivan Čukić :

> Andreas,
>
> Do you have screenshots?
>
> Cheers,
> Ivan
>

Re: Selecting a Plasma logo

[Ivan Čukić]

Andreas,

Do you have screenshots?

Cheers,
Ivan