Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 104 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/104/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 16 Aug 2016 05:38:10 +
Build duration: 7 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 104 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/104/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 16 Aug 2016 05:38:10 +
Build duration: 7 min 36 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

[Differential] [Closed] D2402: [wayland] Unset focused keyboard surface when handling key event internally

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN4651aa1d7959: [wayland] Unset focused keyboard surface 
when handling key event internally (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2402?vs=5822=5967

REVISION DETAIL
  https://phabricator.kde.org/D2402

AFFECTED FILES
  autotests/integration/internal_window.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/test_helpers.cpp
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Subsurface-mobile status update

[Dirk Hohndel]

Once I fixed the build issues and added back a couple of our private patches I 
was able to build a working Subsurface-mobile for iOS based on Kirigami 1.0 
(plus patches).

Nice. Took me a LOT longer than I wanted, but hey... it's all good.

4.5.2.1525 should be available for testing on TestFlight, soon.

Next I'll have to get this to work for Android :-)

/D

[Differential] [Accepted] D2402: [wayland] Unset focused keyboard surface when handling key event internally

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  internal-window-unset-focus-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D2402

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, sebas
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review98407
---



For 5.7.4

- Anthony Fieroni


On Авг. 9, 2016, 8:25 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128038/
> ---
> 
> (Updated Авг. 9, 2016, 8:25 след обяд)
> 
> 
> Review request for Plasma, David Edmundson and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> 1. Enable highlighted window, tooltips and grouping
> 2. Open more then one in goup
> 3. Close one of grouped windows by click at tooltip button
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/plugin/backend.cpp 4a94b25 
> 
> Diff: https://git.reviewboard.kde.org/r/128038/diff/
> 
> 
> Testing
> ---
> 
> Activate window "works" because kwin stops effect on activate, however it 
> better to be stopped.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98406
---



Ping. For 5.7.4

- Anthony Fieroni


On Авг. 13, 2016, 8:17 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128647/
> ---
> 
> (Updated Авг. 13, 2016, 8:17 преди обяд)
> 
> 
> Review request for kwin, Plasma, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 350826 and 365014
> https://bugs.kde.org/show_bug.cgi?id=350826
> https://bugs.kde.org/show_bug.cgi?id=365014
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   shell/desktopview.cpp 83866dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128647/diff/
> 
> 
> Testing
> ---
> 
> 1. open 1 or more non maximized windows
> 2. make left clicks periodically between window and the desktop
> 3. desktop is raised over opened windows *sometimes*
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 103 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 16 Aug 2016 00:40:15 +
Build duration: 11 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Re: Now Dock - create a single widget panel?

[Michail Vourlakos]

Yes !!! :)
I'm so sorry for this but I had messed something with my git branches!
I have now my own red panel in order to start with!!! :)

Thank u very much guys
regards,
michail


On 15/08/2016 07:30 μμ, Marco Martin wrote:

should be ok

On Monday 15 August 2016, Michail Vourlakos wrote:

have I messed up or missed something?


--
[Desktop Entry]
Encoding=UTF-8
Keywords=
Name=Now Dock
Type=Service
NoDisplay=true

X-KDE-ServiceTypes=Plasma/Applet,Plasma/Containment
X-Plasma-API=declarativeappletscript
X-Plasma-MainScript=ui/main.qml
X-Plasma-ContainmentType=Panel
--

Kirigami patches

[Dirk Hohndel]

It's pretty clear that no one ever tested the kirigami.pro qmake file. The
second patch I'm not 100% sure about, but it seems to match what the
documentation tells us SHOULD be done.

/D
>From 8e4307346614943a940f11d2ee6159886c54ee83 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:39:21 -0700
Subject: [PATCH 1/2] More qmake fixes

So the qmake file didn't include the resource file, which of course made things
not work when built with qmake.

Since clearly no one else is using the qmake file but me, I also defined the
static build right there - feel free to change.

Signed-off-by: Dirk Hohndel 
---
 kirigami.pro | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kirigami.pro b/kirigami.pro
index f7d6fe6..ee77100 100644
--- a/kirigami.pro
+++ b/kirigami.pro
@@ -4,6 +4,8 @@ CONFIG += plugin
 QT  += qml quick gui svg
 HEADERS += $$PWD/src/kirigamiplugin.h $$PWD/src/enums.h
 SOURCES += $$PWD/src/kirigamiplugin.cpp $$PWD/src/enums.cpp
+DEFINES += KIRIGAMI_BUILD_TYPE_STATIC
+RESOURCES   += $$PWD/kirigami.qrc
 
 API_VER=1.0
 
-- 
2.7.4 (Apple Git-66)

>From e8de9c0bbc4dbe1e75fc4c8cb2ee0285e98c118a Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Mon, 15 Aug 2016 16:42:08 -0700
Subject: [PATCH 2/2] Q_RESOURCE_INIT macro has to be called by user

Calling this from within the library doesn't seem to be the right thing to do,
according to the documentation at http://doc.qt.io/qt-5/resources.html

Signed-off-by: Dirk Hohndel 
---
 src/kirigamiplugin.cpp | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/kirigamiplugin.cpp b/src/kirigamiplugin.cpp
index fc530b3..83b4dc2 100644
--- a/src/kirigamiplugin.cpp
+++ b/src/kirigamiplugin.cpp
@@ -43,10 +43,6 @@ QString KirigamiPlugin::componentPath(const QString ) const
 
 void KirigamiPlugin::registerTypes(const char *uri)
 {
-#ifdef KIRIGAMI_BUILD_TYPE_STATIC
-Q_INIT_RESOURCE(kirigami);
-#endif
-
 Q_ASSERT(uri == QLatin1String("org.kde.kirigami"));
 const QString style = QString::fromLatin1(qgetenv("QT_QUICK_CONTROLS_STYLE"));
 
-- 
2.7.4 (Apple Git-66)

Re: Subsurface-mobile status update

[Dirk Hohndel]

> On Aug 15, 2016, at 10:06 AM, Marco Martin  wrote:
> 
> On Monday 15 August 2016, Dirk Hohndel wrote:
>>> On Aug 15, 2016, at 7:50 AM, Marco Martin  wrote:
>>> 
>>> On Monday 15 August 2016, Dirk Hohndel wrote:
 Line numbers in kirigamiplugin.cpp are slightly off since I have a few
 lines of debug output in there; frame #9 is foreach (const QString
 , m_stylesFallbackChain) {
 frame #10 is
 
qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")),
uri,
 
 1, 0, "Theme");
 
 /D
>>> 
>>> as that list ended up to always be 2 at most, i may try to simplify that,
>>> but if it's really a crash during a simple foreach of a string list,
>>> suggests there may be something else..
>> 
>> Agreed. That's why I was saying it's an init issue.
> 
> just to get an idea, can you try the attached patch? if it works i would 
> still 
> have no idea why, but interesting never the less to see tyhe result

As expected, this didn't fix the issue

* thread #1: tid = 0x2f77bb, 0x010c8768 
Subsurface-mobile`QString::append(this=0x03393640, str=0x018d7ab8) + 120 at 
qstring.cpp:2041, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS 
(code=1, address=0x5)
  * frame #0: 0x010c8768 Subsurface-mobile`QString::append(this=0x03393640, 
str=0x018d7ab8) + 120 at qstring.cpp:2041
frame #1: 0x00aa1202 Subsurface-mobile`QString::operator+=(this=0x03393640, 
s=0x018d7ab8) + 18 at qstring.h:447
frame #2: 0x004d0ba0 Subsurface-mobile`operator+(s1=0x0339363c, 
s2=0x018d7ab8) + 40 at qstring.h:1273
frame #3: 0x001cb618 
Subsurface-mobile`KirigamiPlugin::componentPath(this=0x018d7aac, 
fileName=0x033939f8) const + 128 at kirigamiplugin.cpp:34
frame #4: 0x001cba3c 
Subsurface-mobile`KirigamiPlugin::registerTypes(this=0x018d7aac, 
uri="org.kde.kirigami") + 576 at kirigamiplugin.cpp:69
frame #5: 0x000fe45a Subsurface-mobile`KirigamiPlugin::registerTypes() + 22 
at kirigamiplugin.h:51
frame #6: 0x000fd074 Subsurface-mobile`run_ui() + 168 at 
subsurface-mobile-helper.cpp:40

This is very strange to me - by the time we call run_ui() things shouldn't be 
crashing like this.

As I said in my last email, by hardcoding all the paths I can actually prevent 
it from crashing, 
but that still doesn't make things work because it then fails to load the 
Kirigami .qml files.

That problem sounds like the one that might be easier to tackle:

QQmlApplicationEngine failed to load component
qrc:///qml/main.qml:350 Type DiveDetails unavailable
qrc:///qml/DiveDetails.qml:219 Type Kirigami.OverlaySheet unavailable
qrc:///OverlaySheet.qml:-1 File not found

Attached is the (obviously not desirable) patch that gets me to that point.

/D
diff --git a/src/kirigamiplugin.cpp b/src/kirigamiplugin.cpp
index fc530b3..3c71d29 100644
--- a/src/kirigamiplugin.cpp
+++ b/src/kirigamiplugin.cpp
@@ -67,28 +70,30 @@ void KirigamiPlugin::registerTypes(const char *uri)
 
 qmlRegisterUncreatableType(uri, 1, 0, 
"ApplicationHeaderStyle", "Cannot create objects of type 
ApplicationHeaderStyle");
 
-qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")), uri, 
1, 0, "Theme");
-qmlRegisterSingletonType(componentPath(QStringLiteral("Units.qml")), uri, 
1, 0, "Units");
-
-qmlRegisterType(componentPath(QStringLiteral("Action.qml")), uri, 1, 0, 
"Action");
-
qmlRegisterType(componentPath(QStringLiteral("AbstractApplicationHeader.qml")), 
uri, 1, 0, "AbstractApplicationHeader");
-
qmlRegisterType(componentPath(QStringLiteral("AbstractApplicationWindow.qml")), 
uri, 1, 0, "AbstractApplicationWindow");
-qmlRegisterType(componentPath(QStringLiteral("AbstractListItem.qml")), 
uri, 1, 0, "AbstractListItem");
-qmlRegisterType(componentPath(QStringLiteral("ApplicationHeader.qml")), 
uri, 1, 0, "ApplicationHeader");
-
qmlRegisterType(componentPath(QStringLiteral("ToolBarApplicationHeader.qml")), 
uri, 1, 0, "ToolBarApplicationHeader");
-qmlRegisterType(componentPath(QStringLiteral("ApplicationWindow.qml")), 
uri, 1, 0, "ApplicationWindow");
-qmlRegisterType(componentPath(QStringLiteral("BasicListItem.qml")), uri, 
1, 0, "BasicListItem");
-qmlRegisterType(componentPath(QStringLiteral("OverlayDrawer.qml")), uri, 
1, 0, "OverlayDrawer");
-qmlRegisterType(componentPath(QStringLiteral("ContextDrawer.qml")), uri, 
1, 0, "ContextDrawer");
-qmlRegisterType(componentPath(QStringLiteral("GlobalDrawer.qml")), uri, 1, 
0, "GlobalDrawer");
-qmlRegisterType(componentPath(QStringLiteral("Heading.qml")), uri, 1, 0, 
"Heading");
-qmlRegisterType(componentPath(QStringLiteral("Icon.qml")), uri, 1, 0, 
"Icon");
-qmlRegisterType(componentPath(QStringLiteral("Label.qml")), uri, 1, 0, 
"Label");
-qmlRegisterType(componentPath(QStringLiteral("OverlaySheet.qml")), uri, 1, 
0, "OverlaySheet");
-qmlRegisterType(componentPath(QStringLiteral("Page.qml")), uri, 1, 0, 
"Page");
-

Re: Subsurface-mobile status update

[Marco Martin]

On Monday 15 August 2016, Dirk Hohndel wrote:
> > On Aug 15, 2016, at 7:50 AM, Marco Martin  wrote:
> > 
> > On Monday 15 August 2016, Dirk Hohndel wrote:
> >> Line numbers in kirigamiplugin.cpp are slightly off since I have a few
> >> lines of debug output in there; frame #9 is foreach (const QString
> >> , m_stylesFallbackChain) {
> >> frame #10 is
> >> 
> >>qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")),
> >>uri,
> >> 
> >> 1, 0, "Theme");
> >> 
> >> /D
> > 
> > as that list ended up to always be 2 at most, i may try to simplify that,
> > but if it's really a crash during a simple foreach of a string list,
> > suggests there may be something else..
> 
> Agreed. That's why I was saying it's an init issue.

just to get an idea, can you try the attached patch? if it works i would still 
have no idea why, but interesting never the less to see tyhe result


-- 
Marco Martin
diff --git a/src/kirigamiplugin.cpp b/src/kirigamiplugin.cpp
index fc530b3..546afa4 100644
--- a/src/kirigamiplugin.cpp
+++ b/src/kirigamiplugin.cpp
@@ -31,12 +31,11 @@ QString KirigamiPlugin::componentPath(const QString ) const
 QString candidate;
 QString candidatePath;
 
-foreach (const QString , m_stylesFallbackChain) {
-candidate = QStringLiteral("styles/") + style + QLatin1Char('/') + fileName;
-if (QFile::exists(resolveFilePath(candidate))) {
-return resolveFileUrl(candidate);
-}
+candidate = QStringLiteral("styles/") + m_style + QLatin1Char('/') + fileName;
+if (QFile::exists(resolveFilePath(candidate))) {
+return resolveFileUrl(candidate);
 }
+
 return resolveFileUrl(fileName);
 }
 
@@ -52,12 +51,12 @@ void KirigamiPlugin::registerTypes(const char *uri)
 
 #if !defined(Q_OS_ANDROID) && !defined(Q_OS_IOS)
 if (style.isEmpty() && QFile::exists(resolveFilePath(QStringLiteral("/styles/Desktop" {
-m_stylesFallbackChain.prepend(QStringLiteral("Desktop"));
+m_style = QStringLiteral("Desktop");
 }
 #endif
 
 if (!style.isEmpty() && QFile::exists(resolveFilePath(QStringLiteral("/styles/") + style))) {
-m_stylesFallbackChain.prepend(style);
+m_style = style;
 }
 //At this point the fallback chain will be selected->Desktop->Fallback
 
diff --git a/src/kirigamiplugin.h b/src/kirigamiplugin.h
index 92f73f2..de137fd 100644
--- a/src/kirigamiplugin.h
+++ b/src/kirigamiplugin.h
@@ -65,7 +65,7 @@ private:
 }
 return QStringLiteral("qrc:/") + filePath;
 }
-QStringList m_stylesFallbackChain;
+QString m_style;
 };
 
 #else
@@ -93,7 +93,7 @@ private:
 {
 return QStringLiteral("file://") + baseUrl().path() + QLatin1Char('/') + filePath;
 }
-QStringList m_stylesFallbackChain;
+QString m_style;
 };
 
 #endif

Re: Now Dock - create a single widget panel?

[Marco Martin]

should be ok

On Monday 15 August 2016, Michail Vourlakos wrote:
> have I messed up or missed something?
> 
> 
> --
> [Desktop Entry]
> Encoding=UTF-8
> Keywords=
> Name=Now Dock
> Type=Service
> NoDisplay=true
> 
> X-KDE-ServiceTypes=Plasma/Applet,Plasma/Containment
> X-Plasma-API=declarativeappletscript
> X-Plasma-MainScript=ui/main.qml
> X-Plasma-ContainmentType=Panel
> --
> 
> > a panel is a plasmoid, just change the metadata.desktop accordingly and
> > it should popup in add panels.
> > 
> > after that works, then you should make it correctly manage adding, and
> > layouting plasmoids in it, but that's another story


-- 
Marco Martin

[Differential] [Commented On] D2449: small utility to create L packages

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:43
> If you're going to poke me on IRC to review something, I don't expect to see 
> FIXMEs that you haven't investigated.

ouch, that was actually coming from copy and paste of another application 
(which i'll have to investigate then) but on this one all is fine, no crash, I 
removed the timer hack now

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 1,365 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart updated this revision to Diff 5953.
mart added a comment.


  - prototype of basic editor for lookandfeel packages
  - correctly list look and feel packages
  - make the theme list a simple list
  - load theme name in textbox
  - complete metadata editor
  - sic creation (of an empty theme)
  - start with layout file generator
  - function to set a screenshot
  - open file dialog to update screenshots
  - fix layout
  - possibility to update default layout
  - async dbus call
  - start port to kirigami
  - actions in GlobalDrawer
  - remove the timer hack

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5933=5953

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Subsurface-mobile status update

[Dirk Hohndel]

> On Aug 15, 2016, at 7:50 AM, Marco Martin  wrote:
> 
> On Monday 15 August 2016, Dirk Hohndel wrote:
>> Line numbers in kirigamiplugin.cpp are slightly off since I have a few
>> lines of debug output in there; frame #9 is foreach (const QString ,
>> m_stylesFallbackChain) {
>> frame #10 is
>>  qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")), 
>> uri,
>> 1, 0, "Theme");
>> 
>> /D
> 
> as that list ended up to always be 2 at most, i may try to simplify that, but 
> if it's really a crash during a simple foreach of a string list, suggests 
> there may be something else..

Agreed. That's why I was saying it's an init issue.

I have now super-simplified the functions, removed all the nested calls and 
turned
them into direct registration calls:

qmlRegisterSingletonType(QStringLiteral("qrc:///styles/Plasma/Theme.qml"), 
uri, 1, 0, "Theme");
qmlRegisterSingletonType(QStringLiteral("qrc:///styles/Plasma/Units.qml"), 
uri, 1, 0, "Theme");

qmlRegisterType(QStringLiteral("qrc:///Action.qml"), uri, 1, 0, "Action");
qmlRegisterType(QStringLiteral("qrc:///AbstractApplicationHeader.qml"), 
uri, 1, 0, "AbstractApplicationHeader");
qmlRegisterType(QStringLiteral("qrc:///AbstractApplicationWindow.qml"), 
uri, 1, 0, "AbstractApplicationWindow");
...
qmlRegisterType(QStringLiteral("qrc:///Icon.qml"), uri, 1, 0, "Icon");
qmlRegisterType(QStringLiteral("qrc:///Label.qml"), uri, 1, 0, "Label");
qmlRegisterType(QStringLiteral("qrc:///OverlaySheet.qml"), uri, 1, 0, 
"OverlaySheet");
qmlRegisterType(QStringLiteral("qrc:///Page.qml"), uri, 1, 0, "Page"); 
...
etc

This no longer crashes, but now the app fails with

QQmlApplicationEngine failed to load component
qrc:///qml/main.qml:350 Type DiveDetails unavailable
qrc:///qml/DiveDetails.qml:219 Type Kirigami.OverlaySheet unavailable
qrc:///OverlaySheet.qml:-1 File not found

Which is strange because at that time it appears to have successfully loaded 
Page.qml (since the 
outermost item in DiveDetails.qml is a Kirigami.Page). So why would if find one 
and not the other?

/D

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D2365#45684, @dfaure wrote:
  
  > The thing is, mimetype filters should be preferred above name filters. So 
the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to 
selectNameFilter. Instead it should call some 
selectInitiallySelectedMimeTypeFilter in the options, like selectNameFilter 
does with setInitiallySelectedNameFilter, and QPlatformFileDialogHelper is 
missing a selectMimeTypeFilter.
  >
  > The fallback to selectNameFilter should only happen if d->usingWidgets() or 
d->selectMimeTypeFilter_sys() (to be added) fails.
  >
  > Feel like making a patch for Qt ?
  
  
  Sounds like something that I can try to do at Akademy :)
  In the meantime, does this test still makes sense? Or maybe (if we are going 
to patch QFileDialog) would be better to add a new 
`QFileDialog::selectedMimeTypeFilter()`? (and use it instead of 
`selectedNameFilter()` in the last QCOMPARE)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Now Dock - create a single widget panel?

[Michail Vourlakos]

I implemented this plasmoid:

https://www.kde-look.org/p/1151047/

but there was a talk that it would be much better if I made it a panel...

I tried... but as it appears something is wrong or missing from the 
metadata.desktop I created...



regards,
michail

--
[Desktop Entry]
Encoding=UTF-8
Keywords=
Name=Now Dock
Type=Service
NoDisplay=true

X-KDE-ServiceTypes=Plasma/Applet,Plasma/Containment
X-Plasma-API=declarativeappletscript
X-Plasma-MainScript=ui/main.qml
X-Plasma-ContainmentType=Panel
--



What is "Now Dock"? Perhaps you can give a link, and tell us what you tried
and where you failed?

[Differential] [Closed] D2413: Trigger global shortcuts also on key-repeat

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINb9c98bd2: Trigger global shortcuts also on key-repeat 
(authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2413?vs=5846=5952

REVISION DETAIL
  https://phabricator.kde.org/D2413

AFFECTED FILES
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=366608

Martin Gräßlin  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kwin
   ||/b9c98bd2b977bd68d79240
   ||ac4d60fcadc96b

--- Comment #9 from Martin Gräßlin  ---
Git commit b9c98bd2b977bd68d79240ac4d60fcadc96b by Martin Gräßlin.
Committed on 15/08/2016 at 15:39.
Pushed by graesslin into branch 'master'.

Trigger global shortcuts also on key-repeat

Summary:
Restores feature parity with X11. Global shortcuts need to trigger
also for repeat events. An example is the volume key or screen
brightness.

For other shortcuts like showing yakuake it does not make sense to
trigger on repeat. Thus a long term solution is to add a flag to
global shortcuts whether the key should trigger on repeat.

Reviewers: #kwin, #plasma_on_wayland

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D2413

M  +1-1input.cpp

http://commits.kde.org/kwin/b9c98bd2b977bd68d79240ac4d60fcadc96b

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Now Dock - create a single widget panel?

[Michail Vourlakos]

have I messed up or missed something?


--
[Desktop Entry]
Encoding=UTF-8
Keywords=
Name=Now Dock
Type=Service
NoDisplay=true

X-KDE-ServiceTypes=Plasma/Applet,Plasma/Containment
X-Plasma-API=declarativeappletscript
X-Plasma-MainScript=ui/main.qml
X-Plasma-ContainmentType=Panel
--

a panel is a plasmoid, just change the metadata.desktop accordingly and it
should popup in add panels.

after that works, then you should make it correctly manage adding, and
layouting plasmoids in it, but that's another story

[Differential] [Requested Changes To] D2449: small utility to create L packages

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:43
> +}
> +//FIXME: why crashes?
> +//model: lnfLogic.lnfList

If you're going to poke me on IRC to review something, I don't expect to see 
FIXMEs that you haven't investigated.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 257 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/257/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 15 Aug 2016 14:33:32 +
Build duration: 20 min

CHANGE SET
Revision c47e5223ee83f881c57c0516d598d73f145f by kde: ([Task Manager 
ToolTipDelegate] Let positioner size itself automatically)
  change: edit applets/taskmanager/package/contents/ui/ToolTipDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1536/3727 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 257 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/257/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 15 Aug 2016 14:33:32 +
Build duration: 20 min

CHANGE SET
Revision c47e5223ee83f881c57c0516d598d73f145f by kde: ([Task Manager 
ToolTipDelegate] Let positioner size itself automatically)
  change: edit applets/taskmanager/package/contents/ui/ToolTipDelegate.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2290/3367 
(68%)CONDITIONAL 1536/3727 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 252/350 (72%)CONDITIONAL 
82/189 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Closed] D2454: [Task Manager ToolTipDelegate] Adjust for right-to-left languages

[broulik (Kai Uwe Broulik)]

broulik closed this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2454

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Subsurface-mobile status update

[Marco Martin]

On Monday 15 August 2016, Dirk Hohndel wrote:
> Line numbers in kirigamiplugin.cpp are slightly off since I have a few
> lines of debug output in there; frame #9 is foreach (const QString ,
> m_stylesFallbackChain) {
> frame #10 is
>   qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")), 
> uri,
> 1, 0, "Theme");
> 
> /D

as that list ended up to always be 2 at most, i may try to simplify that, but 
if it's really a crash during a simple foreach of a string list, suggests 
there may be something else..

-- 
Marco Martin

[Differential] [Reopened] D2455: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

davidedmundson reopened this revision.
davidedmundson added a comment.


  what on Earth is phab doing?
  Kai's commit doesn't close this at all.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2455

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2455: Use new inline revealpassword action

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP708ba4b426f5: [Task Manager ToolTipDelegate] 
Adjust for right-to-left languages (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2455?vs=5948=5949#toc

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2455?vs=5948=5949

REVISION DETAIL
  https://phabricator.kde.org/D2455

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 15 lines] D2455: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Clicked a new connection. Toggled show/hide action

REPOSITORY
  rPLASMANM Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2455

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2454: [Task Manager ToolTipDelegate] Adjust for right-to-left languages

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2454

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Subsurface-mobile status update

[Dirk Hohndel]

> On Aug 15, 2016, at 7:10 AM, Marco Martin  wrote:
> 
> On Monday 15 August 2016, Dirk Hohndel wrote:
>> Do you have any idea, though, while this is crashing for me on iOS?
>> The crash is always in some Qt internal - and it's always that some
>> internal Qt managed pointer is set to 0x1 which then of course gives a bad
>> access when dereferencing it.
> 
> on ios i can only shoot in the dark, but yeah, if you can generate good 
> backtraces those are always a nice thing to have :)

* thread #1: tid = 0x2ef6ba, 0x009b520c Subsurface-mobile`int 
QAtomicOps::load(std::__1::atomic const&) [inlined] 
std::__1::__atomic_base::load(this=0x0001, 
__m=memory_order_relaxed) const + 20 at atomic:845, queue = 
'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x1)
frame #0: 0x009b520c Subsurface-mobile`int 
QAtomicOps::load(std::__1::atomic const&) [inlined] 
std::__1::__atomic_base::load(this=0x0001, 
__m=memory_order_relaxed) const + 20 at atomic:845
frame #1: 0x009b51f8 Subsurface-mobile`int 
QAtomicOps::load(_q_value=0x0001) + 16 at qatomic_cxx11.h:96
frame #2: 0x0082e62e 
Subsurface-mobile`QBasicAtomicInteger::load(this=0x0001) const + 14 at 
qbasicatomic.h:116
frame #3: 0x00111be8 
Subsurface-mobile`QtPrivate::RefCount::ref(this=0x0001) + 16 at 
qrefcount.h:49
frame #4: 0x00aa8d7e 
Subsurface-mobile`QList::QList(this=0x032fd62c, l=0x01841ab8) + 30 at 
qlist.h:799
frame #5: 0x009e5aba 
Subsurface-mobile`QStringList::QStringList(this=0x032fd62c, (null)=0x01841ab8) 
+ 26 at qstringlist.h:93
frame #6: 0x009e5a94 
Subsurface-mobile`QStringList::QStringList(this=0x032fd62c, (null)=0x01841ab8) 
+ 20 at qstringlist.h:93
frame #7: 0x009e5a5c 
Subsurface-mobile`QForeachContainer::QForeachContainer(this=0x032fd62c,
 t=0x01841ab8) + 20 at qglobal.h:923
frame #8: 0x009a2dc4 
Subsurface-mobile`QForeachContainer::QForeachContainer(this=0x032fd62c,
 t=0x01841ab8) + 20 at qglobal.h:923
  * frame #9: 0x001354fa 
Subsurface-mobile`KirigamiPlugin::componentPath(this=0x01841aac, 
fileName=0x032fd9f8) const + 210 at kirigamiplugin.cpp:37
frame #10: 0x001359ec 
Subsurface-mobile`KirigamiPlugin::registerTypes(this=0x01841aac, 
uri="org.kde.kirigami") + 580 at kirigamiplugin.cpp:73
frame #11: 0x000682ea Subsurface-mobile`KirigamiPlugin::registerTypes() + 
22 at kirigamiplugin.h:52
frame #12: 0x00066f04 Subsurface-mobile`run_ui() + 168 at 
subsurface-mobile-helper.cpp:40

Line numbers in kirigamiplugin.cpp are slightly off since I have a few lines of 
debug output in there; frame #9 is
 foreach (const QString , m_stylesFallbackChain) {
frame #10 is
qmlRegisterSingletonType(componentPath(QStringLiteral("Theme.qml")), 
uri, 1, 0, "Theme");

/D

[Differential] [Request, 8 lines] D2454: [Task Manager ToolTipDelegate] Adjust for right-to-left languages

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Enable LayoutMirroring
  - Anchors.left the label row so it becomes right-aligned then
  - Make sure the media control arrows always point outwards

TEST PLAN
plasmashell -reverse
  
  Works

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2454

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPc47e5223: [Task Manager ToolTipDelegate] Let 
positioner size itself automatically (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2451?vs=5945=5946

REVISION DETAIL
  https://phabricator.kde.org/D2451

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 18 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5945.
broulik added a comment.


  Fix typo

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2451?vs=5943=5945

REVISION DETAIL
  https://phabricator.kde.org/D2451

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2446: Remove redundant manual focusOut handling in DesktopView

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd95779b7df33: Remove redundant manual focusOut 
handling in DesktopView (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2446?vs=5921=5944#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2446?vs=5921=5944

REVISION DETAIL
  https://phabricator.kde.org/D2446

AFFECTED FILES
  shell/desktopview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2450: Add support for touch events in the Effect system

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  as discussed on irc, i would have loved if it was exposed with qtouchevents 
(or a qtouchevent-like api
  however, as this seems to be really overcomplicated to do, this lower level 
api is fine as well

REPOSITORY
  rKWIN KWin

BRANCH
  effects-touch

REVISION DETAIL
  https://phabricator.kde.org/D2450

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 18 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 5943.
broulik added a comment.


  - Get rid of _s which is just units.smallSpacing / 2 (and only used in two 
places after the previous patch)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2451?vs=5937=5943

REVISION DETAIL
  https://phabricator.kde.org/D2451

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2407: [libinput] Expose all input devices through DBus

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINab5d31426ab6: [libinput] Expose all input devices through 
DBus (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2407?vs=5830=5940

REVISION DETAIL
  https://phabricator.kde.org/D2407

AFFECTED FILES
  autotests/libinput/CMakeLists.txt
  libinput/connection.cpp
  libinput/device.cpp
  libinput/device.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2435: Don't trigger modifier only shortcuts if pointer interaction

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINbd58d7792fed: Don't trigger modifier only shortcuts if 
pointer interaction (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2435?vs=5894=5938

REVISION DETAIL
  https://phabricator.kde.org/D2435

AFFECTED FILES
  autotests/integration/modifier_only_shortcut_test.cpp
  keyboard_input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: mart, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2452: Simplify and fix sizing code in ToolTipDelegate

[davidedmundson (David Edmundson)]

davidedmundson abandoned this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2452

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2451

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D2452: Simplify and fix sizing code in ToolTipDelegate

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Row's implicitWidth is already set to the width of the children.
  Using childrenRect results in more evaluations, and an apparent binding
  loop when RTL layouts are used.

TEST PLAN
  Ran plasmashell --reverse with Kai's patch and nothing froze
  Ran normally and everything looks the same

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2452

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2410: [wayland] Properly implement minimize of ShellClient

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN8bbd53a77493: [wayland] Properly implement minimize of 
ShellClient (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2410?vs=5840=5939

REVISION DETAIL
  https://phabricator.kde.org/D2410

AFFECTED FILES
  autotests/integration/shell_client_test.cpp
  shell_client.cpp
  shell_client.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 10 lines] D2451: [Task Manager ToolTipDelegate] Let positioner size itself automatically

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Setting a Row's or Column's size to childrenRect size is just asking for 
trouble.
  Also instead of messing with the "y" position of items within a Row, make 
spacing of its parent bigger which is probably what this code wanted to do in 
the first place.

TEST PLAN
  No more freeze when enabling LayoutMirroring and starting
  
plasmashell -reverse
  
  Tested with one window and a group, looked good.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2451

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Now Dock - create a single widget panel?

[Marco Martin]

On Saturday 13 August 2016, Michail Vourlakos wrote:
> Hello everyone...
> 
> 
> Having published the Now Dock plasmoid in kdelook, I would like in
> parallel to start the effort to implement it as a panel... But I dont
> know from where to start... I found in the plasmoids folder the
> org.kde.panel which I think is used for the current panel but I couldnt
> create a simple panel that I can add through the "Add Panels" menu in
> the Desktop.
> 
> Just an empty panel with a red rectangle in it would be sufficient for
> me for now... :-)
> 
> I would love to have your direction for these...

a panel is a plasmoid, just change the metadata.desktop accordingly and it 
should popup in add panels.

after that works, then you should make it correctly manage adding, and 
layouting plasmoids in it, but that's another story

-- 
Marco Martin

Re: Kirigami build instructions

[Sebastian Kügler]

On Monday, August 15, 2016 5:35:00 AM UTC Police Terror wrote:
> Directory /platforms does not exist

Looks like you haven't exported the ANDROID_NDK vars correctly, like Aleix 
suggested.
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Subsurface-mobile status update

[Marco Martin]

On Monday 15 August 2016, Dirk Hohndel wrote:
> Do you have any idea, though, while this is crashing for me on iOS?
> The crash is always in some Qt internal - and it's always that some
> internal Qt managed pointer is set to 0x1 which then of course gives a bad
> access when dereferencing it.

on ios i can only shoot in the dark, but yeah, if you can generate good 
backtraces those are always a nice thing to have :)

-- 
Marco Martin

Re: Now Dock - create a single widget panel?

[Sebastian Kügler]

On Saturday, August 13, 2016 1:47:18 PM UTC Michail Vourlakos wrote:
> Having published the Now Dock plasmoid in kdelook, I would like in parallel
> to start the effort to implement it as a panel... But I dont know from
> where to start... I found in the plasmoids folder the org.kde.panel which I
> think is used for the current panel but I couldnt create a simple panel
> that I can add through the "Add Panels" menu in the Desktop.
> 
> Just an empty panel with a red rectangle in it would be sufficient for me
> for now... :-)
> 
> I would love to have your direction for these...

What is "Now Dock"? Perhaps you can give a link, and tell us what you tried 
and where you failed?
-- 
sebas

http://www.kde.org | http://vizZzion.org

Re: Subsurface-mobile status update

[Dirk Hohndel]

On Mon, Aug 15, 2016 at 11:33:08AM +0200, Marco Martin wrote:
> On Monday 15 August 2016, Dirk Hohndel wrote:
> > Kirigami as is has a few oddities. It compiles neither with cmake nor with
> > qmake. Hmm.
> > 
> > I have patches for that, but on iOS it still dies at startup with a
> > BAD_ACCESS to address 0x1 when trying to loop over the
> > m_stylesFallbackChain in KirigamiPlugin::componentPath (we are building
> > static).
> > 
> > I have pushed what I have to Subsurface master if someone else wants to
> > play with this.
> 
> thank you for noticing, i'll push them upstream asap!

Thanks. Sorry for the syntax error in the cmake - I had just commented out
that line and then figured "nah, I should instead make it conditional" and
of course forgot to compile test that :-(

Do you have any idea, though, while this is crashing for me on iOS?
The crash is always in some Qt internal - and it's always that some
internal Qt managed pointer is set to 0x1 which then of course gives a bad
access when dereferencing it.
It seems to me that somehow some variables aren't set up correctly during
the Qt initialization - but I have no idea what to do about it.

I can send stack traces or anything that would be useful. I tried to debug
things but seem to be only falling deeper into the rabbit hole.

/D

[Differential] [Request, 212 lines] D2450: Add support for touch events in the Effect system

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The Effect class is extended by three new virtual methods:
  
  - touchDown
  - touchMotion
  - touchUp
  
  The methods return a boolean value so that the events can be filtered
  out. E.g. an effect which has also a mouse grab installed wants to
  filter out all events, other effects don't need the events exclusively.
  
  This is a difference to how e.g. keyboard and pointer events are handled.
  But is more close to how KWin's internal input event passing works and
  makes it easier to get touch event: one does not explicitly has to grab
  the events. It's also closer to Wayland where all input events are
  available.
  
  As a first example the Present Windows effect is adjusted and allows to
  activate windows through the touch screen. As much code as possible is
  shared with pointer input.

REPOSITORY
  rKWIN KWin

BRANCH
  effects-touch

REVISION DETAIL
  https://phabricator.kde.org/D2450

AFFECTED FILES
  effects.cpp
  effects.h
  effects/presentwindows/presentwindows.cpp
  effects/presentwindows/presentwindows.h
  input.cpp
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Review Request 128693: Proofread + update khtml-java-js kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128693/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update
remove unused entity nsplugins-kcontrol
add debug info
use entity javascript

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/khtml-java-js/index.docbook d707fcb 

Diff: https://git.reviewboard.kde.org/r/128693/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128549: [TextField] Hide clear button properly

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128549/
---

(Updated Aug. 15, 2016, 1:35 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

Opacity does not affect input handling (it did in QtQuick 1 which is probably 
where this comes from) so clicking the rightmost region of any TextField would 
unexpectedly clear it.


Diffs
-

  src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 

Diff: https://git.reviewboard.kde.org/r/128549/diff/


Testing
---

Button still shows properly but clicking there when it doesn't show doesn't do 
anything as expected.


Thanks,

Kai Uwe Broulik

Re: Review Request 128551: [TextFieldStyle] Calculate right padding with clear button properly

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128551/
---

(Updated Aug. 15, 2016, 1:34 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

This is probably a copy-paste error as the close button's height is 
"parent.height * 0.8" and in a style you usually prepend "control." to 
everything but basing the padding on the TextField's *parent* makes no sense. 
While at it, fixed coding style.


Diffs
-

  src/declarativeimports/plasmastyle/TextFieldStyle.qml 05ff3d5 

Diff: https://git.reviewboard.kde.org/r/128551/diff/


Testing
---

Fixes the filter box in eg. KTP quick chat applet having an insanely huge right 
padding


Thanks,

Kai Uwe Broulik

Re: Review Request 128660: Add an optional reveal password button to TextField

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/
---

(Updated Aug. 15, 2016, 1:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit cb9ec94625ebca02926579c16c96309127aacfc9 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Similar to KPasswordWidget in kwidgetaddons


Diffs
-

  src/declarativeimports/plasmacomponents/qml/TextField.qml 
c0d9155df5bb584cd3070a66c99d98465b81a5ef 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 
05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
  tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 

Diff: https://git.reviewboard.kde.org/r/128660/diff/


Testing
---

Updated manual test. See screenshot.


File Attachments


Spectacle.B12253.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png


Thanks,

David Edmundson

[Differential] [Reopened] D2449: small utility to create L packages

[mart (Marco Martin)]

mart reopened this revision.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2449: small utility to create L packages

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMASDKaec60062c7be: actions in GlobalDrawer (authored by 
mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2449?vs=5930=5933#toc

REPOSITORY
  rPLASMASDK Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2449?vs=5930=5933

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  lookandfeelexplorer/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE5cdcec32252f: [Digital Clock Tooltip] Enable 
LayoutMirroring (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2421?vs=5925=5932#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2421?vs=5925=5932

REVISION DETAIL
  https://phabricator.kde.org/D2421

AFFECTED FILES
  applets/digital-clock/package/contents/ui/Tooltip.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2422: [Clipboard Plasmoid] Adjust gradient for right-to-left languages

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE3b251bc6ccb1: [Clipboard Plasmoid] Adjust 
gradient for right-to-left languages (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2422?vs=5870=5931#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2422?vs=5870=5931

REVISION DETAIL
  https://phabricator.kde.org/D2422

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart added a dependent revision: D2449: small utility to create L packages.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D2449: small utility to create L packages

[mart (Marco Martin)]

mart added a reviewer: Plasma.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2449: small utility to create L packages

[mart (Marco Martin)]

mart added a dependency: D2345: use a separate configuration per look and feel.

REPOSITORY
  rPLASMASDK Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D2449

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 128691: Proofread + update history kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128691/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/history/index.docbook 27f805c 

Diff: https://git.reviewboard.kde.org/r/128691/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Request, 1,370 lines] D2449: small utility to create L packages

[mart (Marco Martin)]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  small utility that can browse look and feel packages,
  edit the metadata of those installed in ~/.local and create new ones
  with defaults files and layout.js taken from the current plasma setup
  
  this uses the javascript export functions introduced in plasmashell

REPOSITORY
  rPLASMASDK Plasma SDK

BRANCH
  mart/lookandfeelexplorer

REVISION DETAIL
  https://phabricator.kde.org/D2449

AFFECTED FILES
  CMakeLists.txt
  lookandfeelexplorer/CMakeLists.txt
  lookandfeelexplorer/Messages.sh
  lookandfeelexplorer/package/contents/ui/FormField.qml
  lookandfeelexplorer/package/contents/ui/FormLabel.qml
  lookandfeelexplorer/package/contents/ui/MetadataEditor.qml
  lookandfeelexplorer/package/contents/ui/main.qml
  lookandfeelexplorer/package/metadata.desktop
  lookandfeelexplorer/src/CMakeLists.txt
  lookandfeelexplorer/src/lnflistmodel.cpp
  lookandfeelexplorer/src/lnflistmodel.h
  lookandfeelexplorer/src/lnflogic.cpp
  lookandfeelexplorer/src/lnflogic.h
  lookandfeelexplorer/src/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 128692: Don't redeclare property implicitHeight

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128692/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Don't redeclare property implicitHeight


Diffs
-

  src/declarativeimports/plasmacomponents/qml/ListItem.qml 
619c5bdcb107c44e0bfc857083f1020b0de071da 

Diff: https://git.reviewboard.kde.org/r/128692/diff/


Testing
---

Clipboard applet (a user of ListItem) still works.
Less warnings on startup


Thanks,

David Edmundson

Review Request 128690: Proofread + update khtml-adblock kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128690/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update
remove unused entity

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/khtml-adblock/index.docbook 1868626 

Diff: https://git.reviewboard.kde.org/r/128690/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Review Request 128689: Proofread + update kcmcss kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128689/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/kcmcss/index.docbook c63e83c 

Diff: https://git.reviewboard.kde.org/r/128689/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Accepted] D2407: [libinput] Expose all input devices through DBus

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  input-device-dbus

REVISION DETAIL
  https://phabricator.kde.org/D2407

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2413: Trigger global shortcuts also on key-repeat

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  global-shortcut-key-repeat

REVISION DETAIL
  https://phabricator.kde.org/D2413

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2410: [wayland] Properly implement minimize of ShellClient

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  minimize-shell-client

REVISION DETAIL
  https://phabricator.kde.org/D2410

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2445: [ksmerver/logout] KWayland integration to create PlasmaShell surface for absolute positioning

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  ksmserver-logout-greeter-wayland-integration

REVISION DETAIL
  https://phabricator.kde.org/D2445

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 128688: Proofread + update khtml-behavior kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128688/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update
remove unused entity

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/khtml-behavior/index.docbook ca39472 

Diff: https://git.reviewboard.kde.org/r/128688/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Updated, 68 lines] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart updated this revision to Diff 5929.
mart added a comment.


  - use .call(message, QDBus::NoBlock)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2448?vs=5926=5929

BRANCH
  phab/lnfshellswitchkcm

REVISION DETAIL
  https://phabricator.kde.org/D2448

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2426: [KRunner] Set componentDisplayName for shortcuts

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb0940b6b6ed1: [KRunner] Set 
componentDisplayName for shortcuts (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2426?vs=5878=5928

REVISION DETAIL
  https://phabricator.kde.org/D2426

AFFECTED FILES
  krunner/view.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2448: use dbus interface to switch shell l

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcm.cpp:33
>  #include 
> +#include 
>  #include 

unused

> kcm.cpp:258
> +
> +QDBusConnection::sessionBus().asyncCall(message);
> +

if you're not going to handle the reply at all

.call(message, QDBus::NoBlock) 
is better

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/lnfshellswitchkcm

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 378 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 5927.
mart added a comment.


  - methods to switch lnf

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5812=5927

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart added a dependency: D2345: use a separate configuration per look and feel.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart added a reviewer: Plasma.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 69 lines] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  the shell has 2 methods to switch lnf layout:
  one that throws away the config contents, one that
  keeps them

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  phab/lnfshellswitchkcm

REVISION DETAIL
  https://phabricator.kde.org/D2448

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Reopened] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

[broulik (Kai Uwe Broulik)]

broulik reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2421

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> bshah wrote in KeyboardButton.qml:13
> I wonder if it ever worked to translate those in SDDM? Given KDeclarative 
> takes care of loading translation domain IIRC.

It used to work.
We don't have the i18n domain set because we're being loaded by SDDM, however 
the i18nd explicitly sets the domain to use.

This has been fixed by 
https://phabricator.kde.org/rPLASMAWORKSPACE0ece53786e1a7ee37f4ce5e01172673b43a1407c
 in plasma-workspace master.

No changes to this patch are needed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Review Request 128687: Proofread + update filemanager kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128687/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/filemanager/index.docbook 2ac80b6 

Diff: https://git.reviewboard.kde.org/r/128687/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Kirigami build instructions

[Police Terror]

Yes, I can build other things fine such as the hello-jni example or
compiling C libraries that use autotools too.

I will try the qtcreator thing as you say.

Marco Martin:
> On Monday 15 August 2016, Police Terror wrote:
>> 'CMakeFiles/create-apk-kirigamigallery.dir/all' failed
>> make[2]: *** [CMakeFiles/create-apk-kirigamigallery.dir/all] Error 2
>> CMakeFiles/Makefile2:106: recipe for target
>> 'CMakeFiles/create-apk-kirigamigallery.dir/rule' failed
>> make[1]: *** [CMakeFiles/create-apk-kirigamigallery.dir/rule] Error 2
>> Makefile:208: recipe for target 'create-apk-kirigamigallery' failed
>> make: *** [create-apk-kirigamigallery] Error 2
>>
>> Where is it looking for /platforms?
>  
> can you build other things with the ndk? looks like an sdl/ndk setup issue, 
> you could try with the standard qtcreator integration to build some hello-
> world qml project and see if works or gives similar problems.
> 

Re: Review Request 128660: Add an optional reveal password button to TextField

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/#review98401
---


Fix it, then Ship it!





src/declarativeimports/plasmacomponents/qml/TextField.qml (line 113)


This always confuses me but:
the LTR or RTL suffix does NOT indicate the writing direction but the 
direction of the arrow (ie. it's vice-versa as you would think it is). That 
Breeze uses the same icon for both doesn't help with this, of course, so should 
be:

source: LayoutMirroring.enabled ? "edit-clear-locationbar-ltr" : 
"edit-clear-locationbar-rtl"


http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Actions-edit-clear-locationbar-ltr-icon.html
 ? that's the mirrored one with "ltr" suffix


- Kai Uwe Broulik


On Aug. 15, 2016, 11:22 vorm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128660/
> ---
> 
> (Updated Aug. 15, 2016, 11:22 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Similar to KPasswordWidget in kwidgetaddons
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml 
> c0d9155df5bb584cd3070a66c99d98465b81a5ef 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 
> 05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
>   tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 
> 
> Diff: https://git.reviewboard.kde.org/r/128660/diff/
> 
> 
> Testing
> ---
> 
> Updated manual test. See screenshot.
> 
> 
> File Attachments
> 
> 
> Spectacle.B12253.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128686: Proofread + update bookmarks kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128686/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/bookmarks/index.docbook 173222c 

Diff: https://git.reviewboard.kde.org/r/128686/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/
---

(Updated Aug. 15, 2016, 11:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Rosca and Hugo Pereira Da Costa.


Changes
---

Submitted with commit 6ecd3cad7448726807213274f66f08af79252f39 by Kai Uwe 
Broulik to branch master.


Repository: breeze


Description
---

This enables painting the focus underline also for QtQuick Controls and fixes 
an off-by-one error which caused the line to be rendered outside the QtQuick 
Controls canvas and was thus invisible.


Diffs
-

  kstyle/breezestyle.cpp 12a2f35 

Diff: https://git.reviewboard.kde.org/r/128654/diff/


Testing
---


File Attachments


Focus underline
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
Spurious focus underline in Honeycomb
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png


Thanks,

Kai Uwe Broulik

Review Request 128685: Proofread + update performance kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128685/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update
remove obsolete comment

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/performance/index.docbook 5ac5055 

Diff: https://git.reviewboard.kde.org/r/128685/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Review Request 128683: Add overlay(s) to items in plasma folder view

[Chinmoy Ranjan Pradhan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128683/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

If this patch is applied then (whenever necessary) icons in plasma folder view 
will be rendered with an overlay.

/*This patch was part of RR 128552. Since the overlay part was not specific to 
symlink so i created this review request.*/


Diffs
-

  containments/desktop/package/contents/ui/FolderItemDelegate.qml e4fcd67 
  containments/desktop/plugins/folder/foldermodel.h 0e31b1e 
  containments/desktop/plugins/folder/foldermodel.cpp 6abfb6b 

Diff: https://git.reviewboard.kde.org/r/128683/diff/


Testing
---


File Attachments


after patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/3055e363-c8bc-4922-b373-532d8b7d8c23__with_overlays.png


Thanks,

Chinmoy Ranjan Pradhan

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 256 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/256/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 15 Aug 2016 11:26:15 +
Build duration: 12 min

CHANGE SET
Revision b08caf02eed8a1cba3da44027585ff53f2158f67 by olivier: (color kcm: 
separate the select area from the edit area)
  change: add kcms/colors/coloredit.ui
  change: edit kcms/colors/colorsettings.ui
Revision 4d8976394575b4cb02b1942f4073f2e25990c528 by olivier: (Colors KCM: move 
buttons below tabwidget in external dialog)
  change: edit kcms/colors/coloredit.ui
Revision 0fffb1237c49a226c5b00bf7016dc1bbe955d1e0 by olivier: (Colors KCM: 
Compiles, features missing)
  change: edit kcms/colors/colorscm.cpp
  change: add kcms/colors/coloreditdialog.h
  change: add kcms/colors/coloreditdialog.cpp
  change: edit kcms/colors/CMakeLists.txt
  change: edit kcms/colors/colorscm.h
Revision c4f56f8221cb7581548e8c7f1915b692df6bedad by olivier: (Colors KCM: code 
splitted in single classes)
  change: edit kcms/colors/coloredit.ui
  change: edit kcms/colors/CMakeLists.txt
  change: add kcms/colors/scmeditordialog.h
  change: add kcms/colors/scmeditordialog.cpp
  change: add kcms/colors/scmeditordialog.ui
  change: edit kcms/colors/colorsettings.ui
  change: add kcms/colors/scmeditoreffects.cpp
  change: add kcms/colors/scmeditoroptions.cpp
  change: edit kcms/colors/coloreditdialog.h
  change: add kcms/colors/scmeditorcolors.h
  change: add kcms/colors/scmeditoroptions.h
  change: edit kcms/colors/coloreditdialog.cpp
  change: add kcms/colors/scmeditoroptions.ui
  change: add kcms/colors/scmeditoreffects.ui
  change: add kcms/colors/scmeditorcolors.ui
  change: add kcms/colors/scmeditoreffects.h
  change: add kcms/colors/scmeditorcolors.cpp
  change: edit kcms/colors/colorscm.h
  change: edit kcms/colors/colorscm.cpp
Revision ac2d8d2669f3433ec14001867b0edba000397278 by olivier: (Colors KCM: 
Saving chosen theme works again)
  change: edit kcms/colors/colorscm.h
  change: edit kcms/colors/colorscm.cpp
Revision c9acf2ea3b0e327c0bfea43588ed507080f5a028 by olivier: (olors KCM: 
remove KDE3 Imports feature (deprecated))
  change: edit kcms/colors/colorscm.cpp
Revision f3dd3ba00b1c362bc9cf3bd258b8661cff8728b0 by olivier: (Colors KCM: move 
WindecoColors to SchemeEditorColors)
  change: edit kcms/colors/colorscm.cpp
  change: edit kcms/colors/scmeditorcolors.h
  change: edit kcms/colors/scmeditorcolors.cpp
  change: edit kcms/colors/colorscm.h
Revision 451e2f7a0afada235e8f714611b54c20838e1844 by olivier: (Colors KCM: 
documentate colorscm methods, remove unused files)
  change: delete kcms/colors/coloredit.ui
  change: edit kcms/colors/scmeditoreffects.cpp
  change: edit kcms/colors/scmeditorcolors.cpp
  change: edit kcms/colors/colorscm.cpp
  change: edit kcms/colors/colorscm.h
  change: delete kcms/colors/coloreditdialog.cpp
  change: delete kcms/colors/coloreditdialog.h
Revision 26f48274adc3b238d5a2131aa7d23a0d8e005014 by olivier: (Colors KCM: 
Create standalone app)
  change: edit kcms/colors/CMakeLists.txt
  change: add kcms/colors/schemeeditor.cpp
  change: edit kcms/colors/colorscm.h
  change: edit kcms/colors/colorscm.cpp
Revision a9ddbfd234f7fcb1934d28de3dd007fac37e391a by olivier: (Colors KCM: More 
cleanup)
  change: edit kcms/colors/colorscm.cpp
  change: edit kcms/colors/scmeditoreffects.cpp
  change: edit kcms/colors/scmeditordialog.cpp
Revision d8ef9d320d8f96f01d3d4680abe88b24d0e5f2d3 by olivier: (Colors KCM: 
Corrected last fixme: everything seems ok)
  change: edit kcms/colors/scmeditordialog.ui
  change: edit kcms/colors/scmeditordialog.cpp
  change: edit kcms/colors/scmeditorcolors.cpp
  change: edit kcms/colors/colorscm.cpp
  change: edit kcms/colors/scmeditordialog.h
Revision b9e2664cc7aa50aa9e6be8368f34390bc756b73a by olivier: (Colors KCM: 
Remove dead code + finish appnbsp; + add .desktop)
  change: add kcms/colors/kcolorschemeeditor.desktop
  change: edit kcms/colors/CMakeLists.txt
  change: edit kcms/colors/colorsettings.ui
  change: edit kcms/colors/scmeditoroptions.cpp
  change: edit kcms/colors/scmeditordialog.cpp
  change: delete kcms/colors/schemeeditor.cpp
  change: add kcms/colors/kcolorschemeeditor.cpp
  change: edit kcms/colors/colorscm.cpp

Review Request 128684: Proofread + update khtml-general kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128684/
---

Review request for Documentation, KDE Base Apps, Plasma, and David Faure.


Repository: plasma-desktop


Description
---

proofread + update
comment webkit

code in kde-baseapps - docbook in plasma-desktop?


Diffs
-

  doc/kcontrol/khtml-general/index.docbook 1b9c80e 

Diff: https://git.reviewboard.kde.org/r/128684/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128660: Add an optional reveal password button to TextField

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/
---

(Updated Aug. 15, 2016, 11:22 a.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Similar to KPasswordWidget in kwidgetaddons


Diffs (updated)
-

  src/declarativeimports/plasmacomponents/qml/TextField.qml 
c0d9155df5bb584cd3070a66c99d98465b81a5ef 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 
05ff3d542ad0de6879ec1de832b5e5d9ed33281e 
  tests/components/textfield.qml 0a7f8886ba0552c2bb23424ee873423cc5ee0585 

Diff: https://git.reviewboard.kde.org/r/128660/diff/


Testing
---

Updated manual test. See screenshot.


File Attachments


Spectacle.B12253.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/b308072d-a1c2-4bd8-9405-2826fc9f4086__Spectacle.B12253.png


Thanks,

David Edmundson

[Differential] [Closed] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud closed this revision.
ochurlaud added a comment.


  This was submitted  in commit 
https://phabricator.kde.org/rPLASMADESKTOPb9e2664cc7aa50aa9e6be8368f34390bc756b73a

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #vdg, mart, #plasma, bshah
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2409: Update Color KCM

[bshah (Bhushan Shah)]

bshah accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #vdg, mart, #plasma, bshah
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128654/#review98400
---


Ship it!




Ship It!

- David Edmundson


On Aug. 15, 2016, 11 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128654/
> ---
> 
> (Updated Aug. 15, 2016, 11 a.m.)
> 
> 
> Review request for Plasma, David Rosca and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> This enables painting the focus underline also for QtQuick Controls and fixes 
> an off-by-one error which caused the line to be rendered outside the QtQuick 
> Controls canvas and was thus invisible.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 12a2f35 
> 
> Diff: https://git.reviewboard.kde.org/r/128654/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Focus underline
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/0ea1f0d7-c295-4bf8-8b17-7c9125a781b6__Screenshot_20160811_131347.png
> Spurious focus underline in Honeycomb
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/11/c8030b3f-673d-43ac-ab78-495c6da55a1a__Screenshot_20160811_132249.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Updated] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud reclaimed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #vdg, mart, #plasma, bshah
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commandeered] D2409: Update Color KCM

[ochurlaud (Olivier Churlaud)]

ochurlaud commandeered this revision.
ochurlaud edited reviewers, added: bshah; removed: ochurlaud.

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #vdg, mart, #plasma, bshah
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2409: Update Color KCM

[bshah (Bhushan Shah)]

bshah abandoned this revision.
bshah added a comment.


  This has been submitted, I will just abandon changes..

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, andreask, #vdg, mart, #plasma, ochurlaud
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commandeered] D2409: Update Color KCM

[bshah (Bhushan Shah)]

bshah commandeered this revision.
bshah edited reviewers, added: ochurlaud; removed: bshah.
This revision now requires review to proceed.

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, andreask, #vdg, mart, #plasma, ochurlaud
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2409: Update Color KCM

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D2409

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ochurlaud, andreask, #vdg, mart, #plasma, bshah
Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2421: [Digital Clock Tooltip] Enable LayoutMirroring

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEbe801f30eb89: [Digital Clock Tooltip] Enable 
LayoutMirroring (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2421?vs=5869=5925#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2421?vs=5869=5925

REVISION DETAIL
  https://phabricator.kde.org/D2421

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/digital-clock/package/contents/ui/Tooltip.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2420: [Task Manager] Fix icon placement with right-to-left languages

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP7034546fefe1: [Task Manager] Fix icon placement 
with right-to-left languages (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2420?vs=5868=5924

REVISION DETAIL
  https://phabricator.kde.org/D2420

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas