fix Kirigami qrc file

[Dirk Hohndel]

>From fb2d355d00011f7ff9a0a7ea69ea93ecc36a5486 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel 
Date: Thu, 18 Aug 2016 22:05:25 -0700
Subject: [PATCH] Remove reference to Icon.qml under desktop style

This file was removed in commit 2496430d9404 ("c++ implementation of Icon
on Desktop style")

Signed-off-by: Dirk Hohndel 
---
 kirigami.qrc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kirigami.qrc b/kirigami.qrc
index 63d64ac0e113..6064a84d2ced 100644
--- a/kirigami.qrc
+++ b/kirigami.qrc
@@ -46,7 +46,6 @@
 src/styles/Desktop/OverlayDrawer.qml
 src/styles/Desktop/Units.qml
 src/styles/Desktop/ApplicationWindow.qml
-src/styles/Desktop/Icon.qml
 src/styles/Desktop/AbstractApplicationHeader.qml
 
 
-- 
2.9.3

[Differential] [Request, 76 lines] D2496: normalize output positions in setoperation

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When setting a config, outputs may fall outside of the virtual screen
  layout. This can happen when, for example, a single screen is enabled
  and its position is not zero. The screen size is a unified rect of the
  enabled and connected outputs, which doesn't necessarily sit at 0,0
  initially. By normalizing the output position, we avoid this pitfall.
  
  Especially the xrandr backend struggles with this, since it will disable
  outputs falling outside of the virtual screen, and it does so after
  policy checks have happened, so in the worst (and actually fairly
  common) case, it will disable the only remaining output, leading to ...
  
  BUG:367490
  
  The reason to do the normalization in SetConfigOperation right before
  the config is passed to the backends to apply is to catch this
  inconsistency problem with configs at a common entry-point. Doing it in
  the library, rather than in the xrandr backend also means that we can
  autotest it -- we can't sensible do that with the xrandr backend.

TEST PLAN
  - manually tested by enabling the left / top most output of two actual 
outputs, this failed before and left all outputs disabled, with this patch, it 
works as expected
  - added autotest to make sure the normalization works

REPOSITORY
  rLIBKSCREEN KScreen Library

BRANCH
  sebas/positionnormalization

REVISION DETAIL
  https://phabricator.kde.org/D2496

AFFECTED FILES
  autotests/testscreenconfig.cpp
  src/setconfigoperation.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: [PATCH 1/7] add simple script to generate a qrc containing all qml files

[Aleix Pol]

Can you please upload the patches to phabricator.kde.org or reviewboard.kde.org?

Thanks!
Aleix

On Tue, Aug 16, 2016 at 8:23 PM, Martin Gysel  wrote:
> ---
>  scripts/gen_qml_qrc.sh | 39 +++
>  1 file changed, 39 insertions(+)
>  create mode 100755 scripts/gen_qml_qrc.sh
>
> diff --git a/scripts/gen_qml_qrc.sh b/scripts/gen_qml_qrc.sh
> new file mode 100755
> index 000..6e1c378
> --- /dev/null
> +++ b/scripts/gen_qml_qrc.sh
> @@ -0,0 +1,39 @@
> +#!/usr/bin/env bash
> +
> +TAB=""
> +
> +kirigami_dir="$(dirname $(readlink -f $0))/.."
> +
> +case $1 in
> +-h|--help)
> +   echo "usage: $(basename $0) [QRC_FILE]"
> +   exit 1
> +   ;;
> +esac
> +
> +pushd ${kirigami_dir} > /dev/null
> +
> +tmpfile=$(mktemp)
> +
> +echo "" > ${tmpfile}
> +echo "${TAB}" >> ${tmpfile}
> +
> +for i in $(find src/controls/ -name *.qml); do
> +   echo -e "${TAB}${TAB}${i}" 
> >> ${tmpfile};
> +done
> +for i in $(find src/styles/ -name *.qml); do
> +echo -e "${TAB}${TAB}${i}" >> 
> ${tmpfile};
> +done
> +
> +echo "${TAB}" >> ${tmpfile}
> +echo "" >> ${tmpfile}
> +
> +if [[ -n $1 ]]; then
> +   cat ${tmpfile} > $1
> +else
> +   cat ${tmpfile}
> +fi
> +
> +unlink ${tmpfile}
> +
> +popd > /dev/null
> --
> 2.9.3
>

Hi

[Differential] [Updated, 2 lines] D2495: Supress QML warning

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 6053.
davidedmundson added a comment.


  clearer syntax

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2495?vs=6052=6053

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2495

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2495: Supress QML warning

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Role LegacyWinIdList can be null, for example on a StartupItem or on
  Wayland. This means we access a property on an undefined object.
  
  Fixes:
  
share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipDelegate.qml:41:
  TypeError: Cannot read property 'length' of undefined

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2495

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2492: [Panel Containment] Cleanup

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2492

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 63 lines] D2492: [Panel Containment] Cleanup

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - When creating the applet container set as many properties initially as you 
can (today I learned: Qt.binding works in there too)
  - Use Qt.binding for configure action visibility/enabledness
  - Cache array lengths and lookups in loops (unfortunately QML list basic type 
behaves widely different from a JS Array and has none of its fancy "some" and 
"forEach" functions)
  - Remove unused variables

TEST PLAN
  Panel still works.
  Verified the binding with HiddenStatus still works, ie. pager is invisible 
with just one virtual desktop but shows up when panel controller opens.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2492

AFFECTED FILES
  containments/panel/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2491: [Kickoff] Mirror breadcrumb arrow in right-to-left layout

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The breadcrumbs are already mirrored (although still left-aligned due to its 
custom nature) but the arrow pointed in the same, wrong, direction.

TEST PLAN
plasmashell -reverse
  
  Arrow now always points towards the deeper level

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2491

AFFECTED FILES
  applets/kickoff/package/contents/ui/Breadcrumb.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2489

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2490: [Desktop Toolbox] Animate position change

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ToolBoxRoot.qml:75
> +Behavior on x {
> +NumberAnimation { duration: units.longDuration; easing.type: 
> Easing.InOutQuad }
> +}

don't remember atm: can XAnimator be used in a Behavior?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2490

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

> On Aug. 18, 2016, 7:11 p.m., Marco Martin wrote:
> > ship it from me.. maybe wait for a second as well, to see there is enough 
> > agreement

Roger that.


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98486
---


On Aug. 18, 2016, 6:23 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 18, 2016, 6:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> Link to VDG Share download:
> https://share.kde.org/index.php/s/M4fzjKibKeZFyMx
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 2560x1600-UPDATED.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

Re: plasma-frameworks compile failure

[Marco Martin]

On Thursday 18 August 2016 21:06:00 Jonathan Riddell wrote:
> 
> I've not updated any other frameworks, is there something that needs
> updated first?

kdeclarative needs to be updated

-- 
Marco Martin

[Differential] [Request, 7 lines] D2490: [Desktop Toolbox] Animate position change

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This animates when the toolbox changes position due to changing available 
screen rect.

TEST PLAN
  I verified that this neither fixes nor worsens the toolbox dance (if it 
danced before it still will and if it didn't then it won't).
  
  Top panel, top left toolbox: On startup toolbox now slides into place after 
panel shows up
  Top panel, bottom left toolbox: stays as it is (ie. doesn't slide out of view 
and back in or crap like that)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2490

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: plasma-frameworks compile failure

[rik]

On 18/08/16 21:31, David Edmundson wrote:
> kdeclarative
> ​

Aha! Trying a new build of that.

TY

Re: plasma-frameworks compile failure

[David Edmundson]

kdeclarative
​

Re: plasma-frameworks compile failure

[rik]

On 18/08/16 21:06, Jonathan Riddell wrote:
> Getting an error in plasma-frameworks today
> 
> http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console
> 
> /workspace/build/src/plasmaquick/containmentview.cpp:205:69: error:
> ‘setTranslationDomain’ was not declared in this scope
> 16:37:02  setTranslationDomain("plasma_shell_" + 
> info.pluginName());


Same error on the kubuntu CI for the Xenial build of plasma-frameworks

Interestingly, the Yakkety build competed OK.

> I've not updated any other frameworks, is there something that needs
> updated first?

Nor here, AFAIK.

I guess that it is the change in this commit that has triggered or
exposed this, if not the actual cause.

https://quickgit.kde.org/?p=plasma-framework.git=commit=f1699fe543dace21563f88d2921e8645bcf89ee8

Re: Review Request 128707: Add support for captive portals

[Thomas Pfeiffer]

> On Aug. 18, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > While I really appreciate that we get support for this I don't think just 
> > opening a webview automatically is a good idea.
> > 
> > Can we perhaps show a notification [1] "log in to this network" with a 
> > button that will then open the web view? Would also be nice if we could 
> > indicate that we're behind a portal in the network applet icon (note the 
> > exclamation mark on the wifi icon) - we even already have "limited" icons 
> > in NM.
> > 
> > [1] 
> > https://4.bp.blogspot.com/-dw9MiaM5GmE/VaFd4t_QmZI/FuM/OTMfLTcdUeA/s1600/starbucks.png
> 
> Jan Grulich wrote:
> We already kinda show exclamation mark on the wifi icon, it's just that 
> the connectivity is not updated everytime and needs to be perhaps forced 
> everytime we connect to a new network. 
> 
> Showing a notification is a good idea, that's why I added more people 
> (including usability) to even start a discussion about that and implement it 
> the best possible way. For now I implemented it the same way as Gnome does.

I agree with Kai Uwe: Detecting that a wifi needs login is a background event, 
not necessarily the user's current main task, therefore a notification is the 
right way to inform the user about it and allow the appropriate action.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98460
---


On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 12:47 p.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

[Differential] [Request, 2 lines] D2489: [Containment Actions Configuration] Add labels for Back / Forward mouse buttons

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's not like we're doing any sensible with them but still better than 
displaying "undefined" in the UI.
  
  Ideally, mouse back and forward buttons would be a mix of mouse wheel (switch 
desktop) and button (can still trigger menus) but the infrastructure cannot 
accomodate that just yet.

TEST PLAN
  Patch had been lying around for a whilte, I think there was even a bug report 
but can't find it right now

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2489

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

plasma-frameworks compile failure

[Jonathan Riddell]

Getting an error in plasma-frameworks today

http://build.neon.kde.org/job/xenial_unstable_frameworks_plasma-framework_bin_amd64/92/console

/workspace/build/src/plasmaquick/containmentview.cpp:205:69: error:
‘setTranslationDomain’ was not declared in this scope
16:37:02  setTranslationDomain("plasma_shell_" + info.pluginName());

I've not updated any other frameworks, is there something that needs
updated first?

Jonathan

[Differential] [Commented On] D2487: Simpler KSplash design

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > with a transparent window i'm a bit concerned that all eventual flickering 
of compositor starting at half startup
  
  I didn't notice any issue, given the root window is black there's nothing to 
see with or without compositing. KWin just briefly freezes the screen when its 
compositor starts up but shouldn't flicker.
  
  > or resolution be changed?
  
  It's all black but I need to check how soon plasma starts up and whether you 
can see it repositoning containments and what not. I will check with 
multiscreen and various setups tomorrow.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2487

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2345: use a separate configuration per look and feel

[Ivan Čukić]

ivan accepted this revision.
ivan added a reviewer: ivan.
ivan added a comment.


  Since David has not objected to the last revision, I'm marking as accepted.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma, ivan
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 2,011 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 6043.
mart added a comment.


  - remove dead code

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=6039=6043

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/CMakeLists.txt
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98486
---


Ship it!




ship it from me.. maybe wait for a second as well, to see there is enough 
agreement

- Marco Martin


On Aug. 18, 2016, 6:23 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 18, 2016, 6:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> Link to VDG Share download:
> https://share.kde.org/index.php/s/M4fzjKibKeZFyMx
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 2560x1600-UPDATED.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

[Differential] [Accepted] D2488: [Desktop Containment] Animate margin changes due to available screen rect

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2488

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2487: Simpler KSplash design

[mart (Marco Martin)]

mart added a comment.


  with a transparent window i'm a bit concerned that all eventual flickering of 
compositor starting at half startup, or resolution be changed?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2487

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 13 lines] D2488: [Desktop Containment] Animate margin changes due to available screen rect

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Animate the changing margins when available screen rect changes because a 
panel shows up on startup or the user adds/removes/resizes panels

TEST PLAN
  Startup looks nicer now, also the widgets moving around whne resizing panels 
and adding/removing them is less distracting.
  
  FolderView containment also gracefully re-layouts its icons

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2488

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98485
---



I've updated the VDG share with the (final?) version of the wallpaper, and I 
uploaded the updated version here as well.

Changes include...
 - Refinements to the glows around the orange/yellow bands
 - Adjusting the height offset of a few 'polygons'
 - Many small fixes/adjustments tn the orange/yellow bands
 - In GIMP, usage of proper opacity masks and slightly nicer noise-mapping

Assuming there are no objections, can I get a 'Ship It'?

- Ken Vermette


On Aug. 18, 2016, 6:23 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 18, 2016, 6:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> Link to VDG Share download:
> https://share.kde.org/index.php/s/M4fzjKibKeZFyMx
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 2560x1600-UPDATED.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

[Differential] [Commented On] D2345: use a separate configuration per look and feel

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> containment.cpp:197
> +//addWidget("org.kde.plasma.analogclock", {"x": 0, "y": 100, 
> "width": 300, "height": 400});
> +const QVariantMap geom = 
> context->argument(1).toVariant().value();
> +geometry = QRectF(context->argument(1).toNumber(),

This seems not to be used

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2345

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/
---

(Updated Aug. 18, 2016, 6:23 p.m.)


Review request for Plasma.


Repository: breeze


Description
---

New wallpaper for Plasma 5.8

Bringing back some colour to our wallpapers - they kept getting darker and some 
people were disappointed at that, so for the 5.8 LTS I think we can celebrate a 
bit. 

This wallpaper will also be available in 4K resolution.

Link to VDG Share download:
https://share.kde.org/index.php/s/M4fzjKibKeZFyMx


Diffs
-

  wallpapers/Next/contents/images/1024x768.png 60e1205 
  wallpapers/Next/contents/images/1280x1024.png 36a9130 
  wallpapers/Next/contents/images/1280x800.png c33e594 
  wallpapers/Next/contents/images/1440x900.png 2c75b54 
  wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
  wallpapers/Next/contents/images/1638x1024.png a3c7492 
  wallpapers/Next/contents/images/1680x1050.png eddc47e 
  wallpapers/Next/contents/images/1920x1080.png ab6d950 
  wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
  wallpapers/Next/contents/images/2560x1600.png eeb08a1 
  wallpapers/Next/contents/images/3200x1800.png 7340567 
  wallpapers/Next/contents/images/3200x2000.png fd1a62c 
  wallpapers/Next/contents/screenshot.png a6d2b7b 

Diff: https://git.reviewboard.kde.org/r/128699/diff/


Testing
---


File Attachments (updated)


2560x1600.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
preview.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
splash.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
2560x1600-UPDATED.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/18/119c1e58-03bb-45ca-a3e6-13f3fe4c3e6c__2560x1600.png


Thanks,

Ken Vermette

[Differential] [Request, 74 lines] D2487: Simpler KSplash design

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This changes KSplash to be transparent so the desktop window, which appears 
pretty quickly, can be seen, significantly improving perceived startup 
experience.
  
  If startup takes longer than 5 seconds (old computer, no SSD) a busy 
indicator will appear to indicate that we're not stuck.

TEST PLAN
  Video: https://www.youtube.com/watch?v=sbJGBTHXmZk
  
  Note that I placed a sleep 10 in startkde to simulate a slow computer, on my 
machine I don't even get to see the busy indicator.
  
  Together with https://phabricator.kde.org/D2486 makes for a gorgeous startup 
experience.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2487

AFFECTED FILES
  lookandfeel/contents/splash/Splash.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 2,012 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 6039.
mart added a comment.


  - use a single config file again

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=6031=6039

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/CMakeLists.txt
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 72 lines] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart updated this revision to Diff 6038.
mart added a comment.


  - switch to single config file

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2448?vs=6035=6038

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

[Fredrik Höglund]

fredrik added a comment.


  The correct way to fix this is to use a custom shader that does approximately 
this:
  
uniform sampler2D texture1;
uniform sampler2D texture2;
uniform float fadeProgress;
varying vec2 texcoord1;
varying vec2 texcoord2;

void main(void) {
vec4 texel1 = texture2D(texture1, texcoord1);
vec4 texel2 = texture2D(texture2, texcoord2);
gl_FragColor = mix(texel1, texel2, fadeProgress);
}
  
  As an added bonus you only render each pixel once, and you don't need 
blending to be enabled, so it's much faster. Especially on tiled renderers.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2484

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: fredrik, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2484

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: more Kirigami patches

[Marco Martin]

On Tuesday 16 August 2016 20:23:45 Martin Gysel wrote:
> Hi
> Here are some patches I have in my branch.
> It contains a script to (re)generate the qml file, one the generate a
> resource file with possibly used icons and one to generaste a qmltypes file.
> It adds the icon resource to the pri file and updates the qml resource
> file. Furthermore the library target in the pro file seems to miss a
> kirigami dir level.

any news on this?
i can take another look at the patches and integrate the ones that are good, 
but it's more work for us.
could you consider to do review requests and eventually oush, to see wether is 
a workflow/contribution model that you would be interested in? (even rarely, or 
from time to time, is very valuable for us never the less)

-- 
Marco Martin

[Differential] [Commented On] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2448#46454, @colomar wrote:
  
  > UI-wise, I'd do it differently.
  >  Currently, the description of what the checkbox affects and the checkbox 
itself are too far separated, plus it makes it sound like the layout is going 
to be changed even if the checkbox is not checked. Instead what I'd do is, 
below the general description paragraph (above the actual selection), put
  >
  > [  ] Change the workspace layout to the one in the selected theme
  
  
  that will always happen, for how the architecture is done now i have no way 
to make it not switch the layout, neither i would have any idea how to make 
this configurable
  
  the checkbox is between throwing away any change the user may have done or not

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

[mart (Marco Martin)]

mart added a comment.


  hmm, it shouldn't cause flicker, fading between 2 different sized wallpapers 
should be just fine

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2484

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2448: use dbus interface to switch shell l

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  UI-wise, I'd do it differently.
  Currently, the description of what the checkbox affects and the checkbox 
itself are too far separated, plus it makes it sound like the layout is going 
to be changed even if the checkbox is not checked. Instead what I'd do is, 
below the general description paragraph (above the actual selection), put
  
  [  ] Change the workspace layout to the one in the selected theme
  
  **unchecked** by default, and if it's checked, show directly below
  "Warning: When clicking "Apply", your current workspace layout (including all 
panels and desktop widgets) will be irrevocably lost and changed to the one 
defined in the Look & Feel theme."

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: colomar, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 41 lines] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When simultaneously fading two items (one from fully opaque to transparent 
and the other one vice-versa) you can briefly see the black background through 
the images leading to an ugly flicker.
  
  By only doing this when the old image could be seen (when the new one has a 
smaller size) we avoid this in the common case of full-size wallpapers.

TEST PLAN
  Added a large and tiny wallpaper, randomly switched between them, also played 
around with various scale modes. It no longer flickers everytime the wallpaper 
is changed.
  
  This obviously breaks (as in you can see the old image which then suddenly 
disapperas once the animation finishes) images with alpha channel but I don't 
think we actively support/encourge that? It's just a corner-case anyway imho.
  
  I noticed that because kscreenlocker greeter sets the image size after the 
wallpaper has loaded causing it to reload (source size changed) and this 
flickered when the lock screen showed up. This issue needs to be addressed 
separately but this patch still gives us a more polished look, especially when 
using a slideshow wallpaper.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2484

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Lamarque Souza]

> On Aug. 18, 2016, 12:37 p.m., Lamarque Souza wrote:
> > kded/portalmonitor.cpp, line 44
> > 
> >
> > You should delete m_view here in case this module is unloaded from 
> > kded5.
> 
> Jan Grulich wrote:
> Isn't this purpose of QScopedPointer? I suppose there is no need for that 
> as QScopedPointer will do that instead of me.

Yeah, you are right.


- Lamarque


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98468
---


On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 12:47 p.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98475
---




kded/service.cpp (line 31)


#if WITH_WEBENGINE_SUPPORT


- Lamarque Souza


On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 12:47 p.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Selecting a Plasma logo

[Alessandro Longo]

Il 11-08-2016 11:37 Ivan Čukić ha scritto:

Hi all,

For anyone interested I've also posted the SVG file (Andreas asked for 
it):


https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp

Cheers,
Ivan


I updated it with the last version of my logo (posted on Forums) plus a 
new version: https://share.kde.org/index.php/s/Jo9ADJYOpWsyxIW


In the new version there is a ">" that stands for "shell" and it's in 
the current Plasma logo too, a gear like the K logo one that looks like 
Sun, since Sun is made by plasma and the ">" contribute to make it look 
like a Sun with a sort of "eclipse" effect.


Cheers,

--
Alessandro Longo

[Differential] [Updated, 73 lines] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart updated this revision to Diff 6035.
mart added a comment.


  - typo

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2448?vs=6033=6035

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 73 lines] D2448: use dbus interface to switch shell l

[mart (Marco Martin)]

mart updated this revision to Diff 6033.
mart added a comment.


  - be more verbose on what the kcm is doing

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2448?vs=5929=6033

BRANCH
  arcpatch-D2448_1

REVISION DETAIL
  https://phabricator.kde.org/D2448

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h
  kcms/lookandfeel/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2482: [Kicker Dash] Use ComplementaryColorGroup for icon tinting

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2482

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D2482: [Kicker Dash] Use ComplementaryColorGroup for icon tinting

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Ensures we don't end up with dark-gray icons on black background as can be 
seen with the black and white leave icons.

TEST PLAN
  Tested with Breeze light, Breeze dark and Breeze with Honeycomb colors. 
Always got a white shutdown icon.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2482

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemGridDelegate.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 2,050 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 6031.
mart added a comment.


  merge new serialization code from Ivan

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=6030=6031

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/CMakeLists.txt
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2480: Serializing the desktop layout to a JavaScript object

[Ivan Čukić]

ivan closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2480

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 373 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 6030.
mart added a comment.


  use new config serialization

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=6029=6030

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

> On Aug. 18, 2016, 9:28 a.m., Sebastian Kügler wrote:
> > I like it a lot as well.
> > 
> > I can't try it, since reviewboard doesn't let me download the files. Could 
> > you put them up somewhere? (At least the highest resolution.)

Added a downloadable link to the description, uncompressed. The wallpaper is 
there in both 4K formats (4096x2160 and 3840x2160, though only 3840x2160 will 
likely be available)


- Ken


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/#review98458
---


On Aug. 18, 2016, 1:02 p.m., Ken Vermette wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128699/
> ---
> 
> (Updated Aug. 18, 2016, 1:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> New wallpaper for Plasma 5.8
> 
> Bringing back some colour to our wallpapers - they kept getting darker and 
> some people were disappointed at that, so for the 5.8 LTS I think we can 
> celebrate a bit. 
> 
> This wallpaper will also be available in 4K resolution.
> 
> Link to VDG Share download:
> https://share.kde.org/index.php/s/M4fzjKibKeZFyMx
> 
> 
> Diffs
> -
> 
>   wallpapers/Next/contents/images/1024x768.png 60e1205 
>   wallpapers/Next/contents/images/1280x1024.png 36a9130 
>   wallpapers/Next/contents/images/1280x800.png c33e594 
>   wallpapers/Next/contents/images/1440x900.png 2c75b54 
>   wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
>   wallpapers/Next/contents/images/1638x1024.png a3c7492 
>   wallpapers/Next/contents/images/1680x1050.png eddc47e 
>   wallpapers/Next/contents/images/1920x1080.png ab6d950 
>   wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
>   wallpapers/Next/contents/images/2560x1600.png eeb08a1 
>   wallpapers/Next/contents/images/3200x1800.png 7340567 
>   wallpapers/Next/contents/images/3200x2000.png fd1a62c 
>   wallpapers/Next/contents/screenshot.png a6d2b7b 
> 
> Diff: https://git.reviewboard.kde.org/r/128699/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> 2560x1600.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
> preview.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
> splash.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png
> 
> 
> Thanks,
> 
> Ken Vermette
> 
>

Re: Review Request 128699: Plasma 5.8 "Bismuth" Wallpaper

[Ken Vermette]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128699/
---

(Updated Aug. 18, 2016, 1:02 p.m.)


Review request for Plasma.


Repository: breeze


Description (updated)
---

New wallpaper for Plasma 5.8

Bringing back some colour to our wallpapers - they kept getting darker and some 
people were disappointed at that, so for the 5.8 LTS I think we can celebrate a 
bit. 

This wallpaper will also be available in 4K resolution.

Link to VDG Share download:
https://share.kde.org/index.php/s/M4fzjKibKeZFyMx


Diffs
-

  wallpapers/Next/contents/images/1024x768.png 60e1205 
  wallpapers/Next/contents/images/1280x1024.png 36a9130 
  wallpapers/Next/contents/images/1280x800.png c33e594 
  wallpapers/Next/contents/images/1440x900.png 2c75b54 
  wallpapers/Next/contents/images/1600x1200.png 5ddaf72 
  wallpapers/Next/contents/images/1638x1024.png a3c7492 
  wallpapers/Next/contents/images/1680x1050.png eddc47e 
  wallpapers/Next/contents/images/1920x1080.png ab6d950 
  wallpapers/Next/contents/images/2560x1440.png 5c78e9d 
  wallpapers/Next/contents/images/2560x1600.png eeb08a1 
  wallpapers/Next/contents/images/3200x1800.png 7340567 
  wallpapers/Next/contents/images/3200x2000.png fd1a62c 
  wallpapers/Next/contents/screenshot.png a6d2b7b 

Diff: https://git.reviewboard.kde.org/r/128699/diff/


Testing
---


File Attachments


2560x1600.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/d8dc1072-2ad1-4954-b339-a7319e2d765b__2560x1600.png
preview.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/1adec791-1f97-4887-976c-6eb5363b26e3__preview.png
splash.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/08/16/ceb0bf36-a476-4725-b0d6-6f7f74d990df__splash.png


Thanks,

Ken Vermette

[Differential] [Updated, 373 lines] D2345: use a separate configuration per look and feel

[mart (Marco Martin)]

mart updated this revision to Diff 6029.
mart added a comment.


  - Merge branch 'master' into mart/separateLookAndFeelLayout

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2345?vs=5980=6029

BRANCH
  mart/separateLookAndFeelLayout

REVISION DETAIL
  https://phabricator.kde.org/D2345

AFFECTED FILES
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/containment.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson, #plasma
Cc: graesslin, davidedmundson, ivan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2480: Serializing the desktop layout to a JavaScript object

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> mart wrote in shellcorona.cpp:392
> QByteArray and returning .toUtf8()?

toJson is already utf8 byte array

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  ivan/separateLookAndFeelLayoutSerialization

REVISION DETAIL
  https://phabricator.kde.org/D2480

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 1,979 lines] D2480: Serializing the desktop layout to a JavaScript object

[Ivan Čukić]

ivan updated this revision to Diff 6028.
ivan added a comment.


  - Dumping JS as a UTF8 byte array instead as a string

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2480?vs=6026=6028

BRANCH
  ivan/separateLookAndFeelLayoutSerialization

REVISION DETAIL
  https://phabricator.kde.org/D2480

AFFECTED FILES
  shell/CMakeLists.txt
  shell/dbus/org.kde.PlasmaShell.xml
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
---

(Updated Srp. 18, 2016, 12:47 odp.)


Review request for Network Management, Plasma, KDE Usability, and Lamarque 
Souza.


Changes
---

Fixes++.


Bugs: 365417
http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
---

Adds portal monitor to our kded module, which checks NetworkManager 
connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are 
behind a captive portal), then we open a QWebEngineView trying to load 
"http://kde.org; page which is supposed to be redirected to the captive portal 
page. Once user logs in and url changes, we re-check the connectivity again and 
close the web view if we are no longer behind the captive portal.


Diffs (updated)
-

  CMakeLists.txt a27c1f2 
  kded/CMakeLists.txt 1f0613e 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
---

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich

Re: Review Request 128707: Add support for captive portals

[Jan Grulich]

> On Srp. 18, 2016, 12:37 odp., Lamarque Souza wrote:
> > kded/portalmonitor.cpp, line 44
> > 
> >
> > You should delete m_view here in case this module is unloaded from 
> > kded5.

Isn't this purpose of QScopedPointer? I suppose there is no need for that as 
QScopedPointer will do that instead of me.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98468
---


On Srp. 18, 2016, 11:42 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Srp. 18, 2016, 11:42 dop.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98470
---




kded/portalmonitor.cpp (line 44)


That shouldn't be necessary when using a scoped pointer.


- Sebastian Kügler


On Aug. 18, 2016, 11:42 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 11:42 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98468
---




kded/portalmonitor.cpp (line 25)


Nitpick: keep includes in lexicography order as much as possible.



kded/portalmonitor.cpp (line 44)


You should delete m_view here in case this module is unloaded from kded5.



kded/portalmonitor.cpp (line 63)


Missing watcher->deleteLater()



kded/portalmonitor.cpp (line 64)


You should check if reply returned error or this line can lead to crash in 
that case.


- Lamarque Souza


On Aug. 18, 2016, 11:42 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 11:42 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

[Differential] [Accepted] D2480: Serializing the desktop layout to a JavaScript object

[mart (Marco Martin)]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> scriptengine_v1.cpp:345
> +//  << appletData.property("plugin").toString()
> +//  << appletData.property("geometry.x").toInteger()  * 
> ScriptEngine::gridUnit()
> +//  << appletData.property("geometry.y").toInteger()  * 
> ScriptEngine::gridUnit()

clear it from dead code

> scriptengine_v1.cpp:622
>  if (!command.isEmpty()) {
> -//if (settings.getSetting(KEMailSettings::ClientTerminal) == 
> "true") {
> -if (false) {
> +// if (settings.getSetting(KEMailSettings::ClientTerminal) ==
> +// "true") {

dead code

> shellcorona.cpp:392
>  
> -QString ShellCorona::dumpCurrentLayoutJS()
> +QString ShellCorona::dumpCurrentLayoutJS() const
>  {

QByteArray and returning .toUtf8()?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  ivan/separateLookAndFeelLayoutSerialization

REVISION DETAIL
  https://phabricator.kde.org/D2480

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128709: Remove code that can never be executed.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128709/
---

(Updated Aug. 18, 2016, 12:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit b07904b901891b5482e06fbfec39b56c1a80a9ae by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

We know d->uiReady is false, otherwise we wouldn't be in this code
block. Modifying d->loadingApplets won't change that.

I don't know what this was possibly trying to do.


Diffs
-

  src/plasma/containment.cpp 31b83927a17cab23e7d70e25dec48f6dbe74699d 

Diff: https://git.reviewboard.kde.org/r/128709/diff/


Testing
---


Thanks,

David Edmundson

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

[Pascal d'Hermilly via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362830

--- Comment #3 from Pascal d'Hermilly  ---
I was just wondering if the devs saw my point :-)  (Sometimes bugs.kde.org
feels lonely)

Yeah, so the problem is exactly that turning down the brightness to lowest with
the keys switches off the display instead of setting the lowest level of
brightness - that's not the case with the battery widget.

problem yes/no?  ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 1 line] D2481: install new header

[sitter (Harald Sitter)]

sitter created this revision.
sitter added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  it is included by concatenatetasksproxymodel.h (and probably others)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2481

AFFECTED FILES
  libtaskmanager/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 1,985 lines] D2480: Serializing the desktop layout to a JavaScript object

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Serializing the desktop layout for current activity
  - Support for different config groups
  - Introducing the mechanism for the future API versioning
  - Loading the desktop from the serialized data
  - Added debugging output just for comparison with regular layout.js
  - Splitting V1 scripting functions into a separate class and file
  - Loading the panels
  - Disabled the debugging output

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  ivan/separateLookAndFeelLayoutSerialization

REVISION DETAIL
  https://phabricator.kde.org/D2480

AFFECTED FILES
  shell/CMakeLists.txt
  shell/scripting/scriptengine.cpp
  shell/scripting/scriptengine.h
  shell/scripting/scriptengine_v1.cpp
  shell/scripting/scriptengine_v1.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98467
---


Fix it, then Ship it!





kded/portalmonitor.cpp (line 51)


Perhaps "Redirecting..." since that's what's supposedly happens. It's more 
telling than "captive portal" IMO.


- Sebastian Kügler


On Aug. 18, 2016, 11:42 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 11:42 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128709: Remove code that can never be executed.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128709/#review98466
---


Ship it!




Ship It!

- Marco Martin


On Aug. 18, 2016, 11:55 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128709/
> ---
> 
> (Updated Aug. 18, 2016, 11:55 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We know d->uiReady is false, otherwise we wouldn't be in this code
> block. Modifying d->loadingApplets won't change that.
> 
> I don't know what this was possibly trying to do.
> 
> 
> Diffs
> -
> 
>   src/plasma/containment.cpp 31b83927a17cab23e7d70e25dec48f6dbe74699d 
> 
> Diff: https://git.reviewboard.kde.org/r/128709/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 128709: Remove code that can never be executed.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128709/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

We know d->uiReady is false, otherwise we wouldn't be in this code
block. Modifying d->loadingApplets won't change that.

I don't know what this was possibly trying to do.


Diffs
-

  src/plasma/containment.cpp 31b83927a17cab23e7d70e25dec48f6dbe74699d 

Diff: https://git.reviewboard.kde.org/r/128709/diff/


Testing
---


Thanks,

David Edmundson

[Differential] [Closed] D2475: [Shell Corona] Don't show panels right away

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE595953f2bc79: [Shell Corona] Don't show panels 
right away (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2475?vs=6012=6025

REVISION DETAIL
  https://phabricator.kde.org/D2475

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2476: [Panel View] Set visible after everything has settled

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2476

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128708: [ContainmentView] Show panel when ui becomes ready

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128708/
---

(Updated Aug. 18, 2016, 11:43 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1d66098e50f7fc3be08b826c7a3a31e1e8ea2135 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

The code already had logic in there but since ui ready is usually emitted later 
the client (in this case plasmashell) had to manually show the panels and would 
usually show them when they're not ready yet.


Diffs
-

  src/plasmaquick/containmentview.cpp adffb0c 

Diff: https://git.reviewboard.kde.org/r/128708/diff/


Testing
---

Together with https://phabricator.kde.org/D2475 I now get a glitch-free panel 
startup in plasma


Thanks,

Kai Uwe Broulik

Re: Review Request 128707: Add support for captive portals

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
---

(Updated Srp. 18, 2016, 11:42 dop.)


Review request for Network Management, Plasma, KDE Usability, and Lamarque 
Souza.


Changes
---

Fix compilation when QWebEngine is not available.


Bugs: 365417
http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
---

Adds portal monitor to our kded module, which checks NetworkManager 
connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are 
behind a captive portal), then we open a QWebEngineView trying to load 
"http://kde.org; page which is supposed to be redirected to the captive portal 
page. Once user logs in and url changes, we re-check the connectivity again and 
close the web view if we are no longer behind the captive portal.


Diffs (updated)
-

  CMakeLists.txt a27c1f2 
  kded/CMakeLists.txt 1f0613e 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
---

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

[David Edmundson]

> On July 19, 2016, 4:02 a.m., David Edmundson wrote:
> > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled)
> > already has a recursion check added in 
> > b45544f3d4dd9cb1873b92a609f45a68f5f6e471  (in knotifications) - which 
> > basically checks if we're using the KDE platform theme (albeit in a 
> > slightly weird way)
> > 
> > Not saying yours is "worse" but we don't want two fixes in two places.
> > 
> > Could you check you have that patch? and why it doesn't work?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> firstly, as you said, it checks in a weird way, which doesn't work, 
> that's why I thought it made more sense to fix it in the platform theme 
> itself which already knows that it is loaded and whether an SNI host is 
> available.
> 
> (fwiw, qApp->platformName() is not correct either, that's what I thought 
> was the "proper" way to do it)
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> patching around that also leads to no legacy tray icon being created at 
> all, which is obviously wrong.
> 
> David Edmundson wrote:
> Is it wrong?
> 
> If you're logged in to a plasma session with the plasma integration 
> running it's a valid assumption that people will run Plasmashell. 
> 
> Without plasmashell you won't get the legacy tray icons appearing either. 
> 
> And if you're running a different shell..you shouldn't be using the 
> plasma integration in the first place.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> The legacy tray icons will work in cases where SNI won't, so breaking 
> that fallback is wrong in my opinion, but I agree it is better than the 
> alternative.
> 
> Anyhow, this is a mess and the interdependencies on behaviour is bad. 
> IMHO it should be "fixed" in both places, the plasma-integration plugin 
> shouldn't rely on some shaky string magic logic in KSNI not to hang 
> applications.
> 
> So if the only objection to this patch is that some applications a) under 
> X11 get a legacy tray icon instead of a SNI one if started too early instead 
> of hanging, b) under Wayland might not get a tray icon at all instead of just 
> hanging if started too early, I think this should go in.
> 
> David Edmundson wrote:
> >The legacy tray icons will work in cases where SNI won't
> 
> How? If Plasmashell is running you get the SNIs. If plasmashell is not 
> running you don't get the legacy icons anyway.
> 
> It's not going in until you can explain:
> 1) why this is needed
> 2) why the other patch doesn't work.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> > How? If Plasmashell is running you get the SNIs. If plasmashell is not 
> running you don't get the legacy icons anyway.
> 
> Because they're very different technologies with very different kinds of 
> bugs? There's a reason the fallback is there already.
> 
> and that's just the unintended ways it can fail, then you have users that 
> for some reasons intentionally don't run plasma-shell with the default 
> settings, use another tray solution, etc.
> 
> 
> > 2) why the other patch doesn't work.
> 
> The other patch won't work because it doesn't know if the plasma 
> integration plugin is loaded. it's also the wrong place to put those kinds of 
> checks, even if you would find a 100% bulletproof bug free way to detect 
> that. hardcoding in fixes for bugs in platform plugins (e. g. if another 
> platform plugin decides to do the same) is wrong.
> 
> and as already demonstrated, it doesn't work well in practice.
> 
> 
> > 1) why this is needed
> 
> to avoid applications hanging/crashing, approach the zen of failing 
> gracefully, and in general make this a bit more robust.
> 
> imho, this shouldn't even be using the same KSNI classes that 
> applications are supposed to use, it's a design error that leads to these 
> kinds of problems, but this makes it a bit more sane.
> 
> 
> but this discussion was absurd several posts ago, and it's not getting 
> better...
> 
> Martin Gräßlin wrote:
> So could you please explain why the existing solution doesn't work and 
> why this is needed in addition? We just try to understand and whether there 
> are things we need to change in KNotifications.
> 
> Btw. the fact that this will break SNIs during startup in a racy way on 
> Wayland is a reason for me to not make it go in. We need to start thinking 
> about the "can break in Wayland" cases more, after all there are people using 
> it productivly ;-)
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> Sorry for the late reply, dayjob started up again. :-)
> 
> 
> > So could you please explain why the existing solution doesn't work [...]
> 
> I'll try to summarize:
> 
> * It has the same race condition problem that you say this patch has, 
> only worse, as far as I can tell. If a SNI is unavailable on startup 

Re: Review Request 128708: [ContainmentView] Show panel when ui becomes ready

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128708/#review98464
---


Ship it!




Ship It!

- Marco Martin


On Aug. 18, 2016, 11:34 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128708/
> ---
> 
> (Updated Aug. 18, 2016, 11:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The code already had logic in there but since ui ready is usually emitted 
> later the client (in this case plasmashell) had to manually show the panels 
> and would usually show them when they're not ready yet.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/containmentview.cpp adffb0c 
> 
> Diff: https://git.reviewboard.kde.org/r/128708/diff/
> 
> 
> Testing
> ---
> 
> Together with https://phabricator.kde.org/D2475 I now get a glitch-free panel 
> startup in plasma
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Review Request 128708: [ContainmentView] Show panel when ui becomes ready

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128708/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

The code already had logic in there but since ui ready is usually emitted later 
the client (in this case plasmashell) had to manually show the panels and would 
usually show them when they're not ready yet.


Diffs
-

  src/plasmaquick/containmentview.cpp adffb0c 

Diff: https://git.reviewboard.kde.org/r/128708/diff/


Testing
---

Together with https://phabricator.kde.org/D2475 I now get a glitch-free panel 
startup in plasma


Thanks,

Kai Uwe Broulik

[Differential] [Updated] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas marked 2 inline comments as done.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2465

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> graesslin wrote in daemon.cpp:167-169
> So what is the code going to do here? Will it go into the code path here or 
> not?

Ah, I see what you mean. Yes, it would go in there but do nothing since 
QFile::exists(..) will return false -- the file is never created on non-laptops.

We can also avoid it altogether, by checking Device::isLaptop(), that seems 
prudent here, so I've added it -- it will save a file system access on 
non-laptop systems.

(Laptop systems in this sense are detected by querying UPower for the presence 
of a lid, so it's a logical thing to check.)

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2465

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 108 lines] D2465: [kded] correctly restore lidOpened configuration on startup

[Sebastian Kügler]

sebas updated this revision to Diff 6024.
sebas added a comment.


  - Also check isLaptop)

REPOSITORY
  rKSCREEN KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2465?vs=5988=6024

BRANCH
  sebas/lidopeninit

REVISION DETAIL
  https://phabricator.kde.org/D2465

AFFECTED FILES
  kded/daemon.cpp
  kded/serializer.cpp
  kded/serializer.h
  tests/kded/serializertest.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 128707: Add support for captive portals

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98462
---




kded/service.cpp (line 49)


PortalMonitor is not known when webengine support is off at build time



kded/service.cpp (line 86)


This would also need a an #if (or you can make webengine required dep, of 
course)


- Sebastian Kügler


On Aug. 18, 2016, 10:58 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 10:58 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128692: Don't redeclare property implicitHeight

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128692/
---

(Updated Aug. 18, 2016, 11:06 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Don't redeclare property implicitHeight


Diffs
-

  src/declarativeimports/plasmacomponents/qml/ListItem.qml 
619c5bdcb107c44e0bfc857083f1020b0de071da 

Diff: https://git.reviewboard.kde.org/r/128692/diff/


Testing
---

Clipboard applet (a user of ListItem) still works.
Less warnings on startup


Thanks,

David Edmundson

Re: Review Request 128692: Don't redeclare property implicitHeight

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128692/#review98463
---


Ship it!




Ship It!

- Kai Uwe Broulik


On Aug. 15, 2016, 1:15 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128692/
> ---
> 
> (Updated Aug. 15, 2016, 1:15 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Don't redeclare property implicitHeight
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qml/ListItem.qml 
> 619c5bdcb107c44e0bfc857083f1020b0de071da 
> 
> Diff: https://git.reviewboard.kde.org/r/128692/diff/
> 
> 
> Testing
> ---
> 
> Clipboard applet (a user of ListItem) still works.
> Less warnings on startup
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Abandoned] D2479: [Shell Corona] Delay showing the panel slightly

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2479

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Jan Grulich]

> On Srp. 18, 2016, 10:27 dop., Kai Uwe Broulik wrote:
> > While I really appreciate that we get support for this I don't think just 
> > opening a webview automatically is a good idea.
> > 
> > Can we perhaps show a notification [1] "log in to this network" with a 
> > button that will then open the web view? Would also be nice if we could 
> > indicate that we're behind a portal in the network applet icon (note the 
> > exclamation mark on the wifi icon) - we even already have "limited" icons 
> > in NM.
> > 
> > [1] 
> > https://4.bp.blogspot.com/-dw9MiaM5GmE/VaFd4t_QmZI/FuM/OTMfLTcdUeA/s1600/starbucks.png

We already kinda show exclamation mark on the wifi icon, it's just that the 
connectivity is not updated everytime and needs to be perhaps forced everytime 
we connect to a new network. 

Showing a notification is a good idea, that's why I added more people 
(including usability) to even start a discussion about that and implement it 
the best possible way. For now I implemented it the same way as Gnome does.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98460
---


On Srp. 18, 2016, 10:58 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Srp. 18, 2016, 10:58 dop.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
---

(Updated Srp. 18, 2016, 10:58 dop.)


Review request for Network Management, Plasma, KDE Usability, and Lamarque 
Souza.


Changes
---

Fixes mentioned issues.

I'm just not sure about my usage of QScopedPointer as I have never used it 
before. I removed initialization/deinitialization of m_view pointer in 
connectivityChanged() slot and I just show it or hide it instead.


Bugs: 365417
http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
---

Adds portal monitor to our kded module, which checks NetworkManager 
connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are 
behind a captive portal), then we open a QWebEngineView trying to load 
"http://kde.org; page which is supposed to be redirected to the captive portal 
page. Once user logs in and url changes, we re-check the connectivity again and 
close the web view if we are no longer behind the captive portal.


Diffs (updated)
-

  CMakeLists.txt a27c1f2 
  kded/CMakeLists.txt 1f0613e 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
---

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich

[Differential] [Accepted] D2476: [Panel View] Set visible after everything has settled

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  ok, tough the phone shell should be adjusted in the same way

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2476

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2470: [upowerbackend] set cached brightness manually in case of led backlight

[bshah (Bhushan Shah)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVIL26a48f9dbfa8: [upowerbackend] set cached brightness 
manually in case of led backlight (authored by bshah).

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2470?vs=6022=6023

REVISION DETAIL
  https://phabricator.kde.org/D2470

AFFECTED FILES
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 21 lines] D2470: [upowerbackend] set cached brightness manually in case of led backlight

[bshah (Bhushan Shah)]

bshah updated this revision to Diff 6022.
bshah marked 2 inline comments as done.
bshah added a comment.


  make things simple

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2470?vs=6004=6022

BRANCH
  workaround-broken-backlight-driver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2470

AFFECTED FILES
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D2475: [Shell Corona] Don't show panels right away

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  as now the screen stays correct since screentofollow is independent from 
screen(), that should work well now (backstory, something similar was done for 
5.0, but didn't work correctly due the wonky behavior of screen())

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2475

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[sitter (Harald Sitter)]

sitter marked an inline comment as done.
sitter added a comment.


  Dump from IRC
  
  > [12:18]  ochurlaud: why is kcolorschemeeditor a standalone 
application if you don't use it as such?
  >  [12:25]  sitter: It can be used at such
  >  [12:26]  but you might want to access it from the colors kcm, 
and until now, i didn't find a way to reload the kcm after creating a new scheme
  >  [12:27]  maybe i would need to send a DBus signal or 
something...
  >  [12:27]  ochurlaud: so the plan is to not use SchemeEditorDialog 
directly but run the standalone application from the KCM?
  >  [12:28]  sitter, if it  is possible it is the plan
  >  [12:28]  the idea is also that notmart is creating a theme 
creation tool
  >  [12:28]  and a color scheme creation tool would be needed: it 
should finally move to plasma-sdk or something
  >  [12:29]  ah yes, cool then
  >  [12:30]  ochurlaud: also, yeah you'll probably need to send a dbus 
signal to the editor to have it load a different scheme
  >  [12:30]  sitter: well but don't expect it too early... :S
  >  [12:31]  ochurlaud: no no. I was just perplexed by there being an 
application but the application not actually being used by the KCM :)
  >  [12:36]  sitter: see Thomas comments on 
https://phabricator.kde.org/D2409 about the context
  >  [12:36]  Diff 2409 "Update Color KCM" [Closed] 
https://phabricator.kde.org/D2409
  >  [12:36]  It was the first iteration. Now that we have a 
standalone app, we can play with it so that it becomes better without breaking 
the kcm
  >  [12:37]  sitter: ok, then I accept your change, and we'll undo 
the nodisplay (maybe) in next iteration
  >  [12:37]  ochurlaud: right now I think nodisplay is the way to go. 
That being said, I think even with it being a proper application it would be 
weird to have it in the menu. Even if it doesn't look like a KCM anymore, it 
still is effectively a settings app, which we all bundle into systemsettings
  >  [12:38]  but yeah, that's a discussion to be had at a later time

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[sitter (Harald Sitter)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP53b7f0d805a7: make kcolorschemeditor desktop 
entry spec compliant and refine it (authored by sitter).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2478?vs=6019=6021

REVISION DETAIL
  https://phabricator.kde.org/D2478

AFFECTED FILES
  kcms/colors/org.kde.kcolorschemeeditor.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[ochurlaud (Olivier Churlaud)]

ochurlaud accepted this revision.
ochurlaud added a comment.


  After discussion on IRC: the nodisplay bit will be removed in a next 
iteration when the app will have more context.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2470: [upowerbackend] set cached brightness manually in case of led backlight

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPOWERDEVIL Powerdevil

BRANCH
  workaround-broken-backlight-driver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D2470

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2470: [upowerbackend] set cached brightness manually in case of led backlight

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> powerdevilupowerbackend.cpp:55
>  , m_kbdMaxBrightness(0)
> -, m_lidIsPresent(false), m_lidIsClosed(false), m_onBattery(false)
> +, m_lidIsPresent(false), m_lidIsClosed(false), m_onBattery(false), 
> m_isLedBrightnessControl(false)
>  {

Put new var on a new line

> powerdevilupowerbackend.cpp:193
>  
> -UdevQt::Client *client =  new 
> UdevQt::Client(QStringList("backlight"), this);
> -connect(client, 
> SIGNAL(deviceChanged(UdevQt::Device)), SLOT(onDeviceChanged(UdevQt::Device)));
> +m_isLedBrightnessControl = 
> m_syspath.split('/').contains("leds");
> +if (!m_isLedBrightnessControl) {

splitRef and QLatin1String

Can't you do contains("/leds/") to reduce the likelihood of false positives? Or 
can it also be /sys/class/ledsfoo/ or sth like that?

> powerdevilupowerbackend.cpp:454
> +m_cachedBrightnessMap[Screen] = value;
> +slotScreenBrightnessChanged();
> +}

Make sure you don't emit if it didn't actually change (dunno what the code does 
internally so might already check for that)

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2470

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bshah, #plasma, broulik
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[ochurlaud (Olivier Churlaud)]

ochurlaud added a comment.


  In https://phabricator.kde.org/D2478#46347, @sitter wrote:
  
  > Pulling in @ochurlaud
  >
  > The NoDisplay remark from Bhushan got me wondering how the KCM actually 
starts the app. And it turns out that it doesn't.
  >
  >   SchemeEditorDialog* dialog = new SchemeEditorDialog(path, this);
  >   dialog->setModal(true);
  >   dialog->show();
  >   
  >
  > Which is now raising the question why kcolorschemeditor was made a 
standalone application to begin with seeing as it adds no value?
  
  
  I would not put that in no-display but rather so that it goes in the tools or 
something similar

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98460
---



While I really appreciate that we get support for this I don't think just 
opening a webview automatically is a good idea.

Can we perhaps show a notification [1] "log in to this network" with a button 
that will then open the web view? Would also be nice if we could indicate that 
we're behind a portal in the network applet icon (note the exclamation mark on 
the wifi icon) - we even already have "limited" icons in NM.

[1] 
https://4.bp.blogspot.com/-dw9MiaM5GmE/VaFd4t_QmZI/FuM/OTMfLTcdUeA/s1600/starbucks.png


kded/portalmonitor.cpp (lines 40 - 42)


delete nullptr is fine, no need for an if check



kded/portalmonitor.cpp (line 50)


That is a pretty technical description


- Kai Uwe Broulik


On Aug. 18, 2016, 10:15 vorm., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 10:15 vorm.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98459
---




kded/portalmonitor.h (line 43)


QScopedPointer?



kded/portalmonitor.cpp (line 47)


if it's Portal, and m_view has been created, maybe it should be shown?



kded/portalmonitor.cpp (line 51)


Why? Shouldn't we let the window manager decide this? On my 4K screen, it 
doesn't make sense to maximize, for example.



kded/portalmonitor.cpp (line 52)


parent the lambda to this



kded/portalmonitor.cpp (line 56)


nullptr, no need to use the Qt macro



kded/portalmonitor.cpp (line 64)


parent to this



kded/service.cpp (line 49)


coding style, PortalMonitor *portalMonitor

(should be at least consistent for new code)



kded/service.cpp (line 60)


nullptr


- Sebastian Kügler


On Aug. 18, 2016, 10:15 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Aug. 18, 2016, 10:15 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[sitter (Harald Sitter)]

sitter added a reviewer: ochurlaud.
sitter added a subscriber: ochurlaud.
sitter added a comment.


  Pulling in @ochurlaud
  
  The NoDisplay remark from Bhushan got me wondering how the KCM actually 
starts the app. And it turns out that it doesn't.
  
SchemeEditorDialog* dialog = new SchemeEditorDialog(path, this);
dialog->setModal(true);
dialog->show();
  
  Which is now raising the question why kcolorschemeditor was made a standalone 
application to begin with seeing as it adds no value?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah, ochurlaud
Cc: ochurlaud, bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 4 lines] D2479: [Shell Corona] Delay showing the panel slightly

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  By doing a roundtrip with a Timer (QMetaObject::invokeMethod with 
QueuedConnection isn't sufficient) we delay showing the panel window until its 
contents have settled and we avoid visual glitches.

TEST PLAN
  This is an alternative approach to https://phabricator.kde.org/D2475 and 
https://phabricator.kde.org/D2476 which don't need adjustments to the Panel QML.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2479

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 362830] Allow lowest brightness when using the brightness down/up buttons

[Sebastian Kügler via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362830

Sebastian Kügler  changed:

   What|Removed |Added

 CC||se...@kde.org

--- Comment #2 from Sebastian Kügler  ---
What do you mean with yes/no? (You're not asking a question, and I don't get
the context.)

The last step should not be reachable as on some hardware it switches the
display off with no easy way to turn it back on. That's why it's skipped.

yes/no? :P

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 128707: Add support for captive portals

[Jan Grulich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/
---

Review request for Network Management, Plasma, KDE Usability, and Lamarque 
Souza.


Bugs: 365417
http://bugs.kde.org/show_bug.cgi?id=365417


Repository: plasma-nm


Description
---

Adds portal monitor to our kded module, which checks NetworkManager 
connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we are 
behind a captive portal), then we open a QWebEngineView trying to load 
"http://kde.org; page which is supposed to be redirected to the captive portal 
page. Once user logs in and url changes, we re-check the connectivity again and 
close the web view if we are no longer behind the captive portal.


Diffs
-

  CMakeLists.txt a27c1f2 
  kded/CMakeLists.txt 1f0613e 
  kded/portalmonitor.h PRE-CREATION 
  kded/portalmonitor.cpp PRE-CREATION 
  kded/service.cpp 18ffd41 

Diff: https://git.reviewboard.kde.org/r/128707/diff/


Testing
---

Tested with three different captive portals and it worked perfectly.


Thanks,

Jan Grulich

[Differential] [Accepted] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> org.kde.kcolorschemeeditor.desktop:28
>  Terminal=false
> -Categories=Qt;KDE;X-KDE-settings-looknfeel;
> +NoDisplay=true
> +OnlyShowIn=KDE;

Assuming systemsettings don't filter this one out.. "ship it".

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2478

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, bshah
Cc: bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas