Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 313 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/313/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 20:47:31 +
Build duration: 19 min

CHANGE SET
Revision 052ee9402023fb0a5ee3c91eae164f460b7f20db by kde: 
([AppletConfiguration] Don't call saveConfig() twice)
  change: edit desktoppackage/contents/configuration/AppletConfiguration.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
---

(Updated Sept. 6, 2016, 8:55 nachm.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Bugs: 349177
https://bugs.kde.org/show_bug.cgi?id=349177


Repository: plasma-workspace


Description
---

This brings back the KPropertiesDialog to modify an icon's appearance. This has 
been requested at multiple occasions. This has been adapted from the Plasma 4 
icon code.


Diffs
-

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
---

Dropped a file from my home onto the desktop -> dialog from the actual file, 
allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the 
desktop file, allowing to change its icon and description. The applet reflected 
the changes.


Thanks,

Kai Uwe Broulik

[Differential] [Closed] D2673: [AppletConfiguration] Don't call saveConfig() twice

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP052ee9402023: [AppletConfiguration] Don't call 
saveConfig() twice (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2673?vs=6470&id=6508

REVISION DETAIL
  https://phabricator.kde.org/D2673

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D2690: [System Tray] Set applet status to RequiresAttention when popup is open

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This keeps auto-hiding panels open while the applet popup is opened.
  
  BUG: 368160

TEST PLAN
  I was so sure we already fixed that at some point :/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2690

AFFECTED FILES
  applets/systemtray/container/package/contents/ui/main.qml
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2687: WIP: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2687: WIP: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 618 lines] D2687: WIP: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This brings back the properties dialog allowing to manipulate the icon and 
label of a widget.

TEST PLAN
  It's pretty broken right now.
  Basically it makes sure we always have a desktop file which we can edit 
(either copying the one of the app or making a Link one in case of files). (the 
plasma 4 applet did some mental stuff with creating a desktp file only if you 
edited it and it wasnt writable etc etc). I made sure though that existing 
applets (plasma 5.7) will be gracefully migrated by creating a desktop file on 
first launch.
  Due to some kio bug the editing of desktop file doesnt actually work.
  Also launching it is broken as a I cant figure out a KRun call that actually 
work with both desktop files (app or Link)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  CMake Error at applets/activitypager/cmake_install.cmake:36 (file):
  
file INSTALL cannot find

"/home/kaiuwe/Projekte/kf5/kdeplasma-addons/applets/activitypager/metadata.desktop".

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D2677

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: broulik, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 128851: [AppletQuickItem] Break from loop when we found a layout

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128851/
---

(Updated Sept. 6, 2016, 6:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit dd5d07afece20f977d84f908032d81bd31f8e488 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

There's no point in going on once we found a layout.


Diffs
-

  src/plasmaquick/appletquickitem.cpp a95c445 

Diff: https://git.reviewboard.kde.org/r/128851/diff/


Testing
---

Reduces number of loop iterations by 20% on my machine


Thanks,

Kai Uwe Broulik

Re: Review Request 128851: [AppletQuickItem] Break from loop when we found a layout

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128851/#review98945
---


Ship it!




Ship It!

- David Edmundson


On Sept. 6, 2016, 3:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128851/
> ---
> 
> (Updated Sept. 6, 2016, 3:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> There's no point in going on once we found a layout.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.cpp a95c445 
> 
> Diff: https://git.reviewboard.kde.org/r/128851/diff/
> 
> 
> Testing
> ---
> 
> Reduces number of loop iterations by 20% on my machine
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Updated] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[hein (Eike Hein)]

hein added a comment.


  I'm kind of wondering about the arch here ... I can see that this works, but 
is it worth putting complexity like evaluating taskManagerAppletsCount into the 
QML code, along with all of this register/unregister applet stuff? I feel like 
this could all be on the C++ side and driven by the constructors+destructors of 
the Backend class, keeping a static instance counter in there.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 312 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/312/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 17:54:11 +
Build duration: 5 min 46 sec

CHANGE SET
Revision 53243cbaf9e3537be28f3fe1122495d427840c62 by hein: (Only reparent on 
drag initiation and update root.dragging before reset.)
  change: edit applets/pager/package/contents/ui/main.qml
Revision 996a69033631630610753388e7b41f907bfe9613 by hein: (Fix regression from 
01ac3aa3660.)
  change: edit applets/pager/plugin/pagermodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 311 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/311/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 16:40:25 +
Build duration: 6 min 45 sec

CHANGE SET
Revision 4b9d8046347b17ef7337ae31f1c2cdfc73a87781 by hein: (Improved and 
optimized Pager and Activity Pager)
  change: delete applets/pager/plugin/pager.h
  change: edit applets/pager/package/contents/ui/configGeneral.qml
  change: add applets/pager/plugin/pagermodel.h
  change: delete applets/pager/plugin/model.h
  change: add applets/pager/plugin/windowmodel.cpp
  change: delete applets/pager/plugin/model.cpp
  change: edit applets/pager/CMakeLists.txt
  change: edit applets/pager/package/metadata.desktop
  change: add applets/pager/plugin/windowmodel.h
  change: delete applets/pager/plugin/pager.cpp
  change: add applets/pager/plugin/pagermodel.cpp
  change: edit applets/pager/plugin/pagerplugin.cpp
  change: edit applets/pager/package/contents/ui/main.qml
Revision 01ac3aa3660b22449d79ecebd7bbb403cab75193 by hein: (Use 
plasmashell's toggleDashboard instead.)
  change: edit applets/pager/CMakeLists.txt
  change: edit applets/pager/plugin/pagermodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Closed] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKDEPLASMAADDONSa4bd3e75fe1c: Reduce Activity Pager to 
.desktop file referencing the Pager package. (authored by hein).

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2677?vs=6475&id=6497

REVISION DETAIL
  https://phabricator.kde.org/D2677

AFFECTED FILES
  applets/activitypager/CMakeLists.txt
  applets/activitypager/Messages.sh
  applets/activitypager/package/contents/code/utils.js
  applets/activitypager/package/contents/config/config.qml
  applets/activitypager/package/contents/config/main.xml
  applets/activitypager/package/contents/ui/configGeneral.qml
  applets/activitypager/package/contents/ui/main.qml
  applets/activitypager/package/metadata.desktop
  applets/activitypager/plugin/activitypager.cpp
  applets/activitypager/plugin/activitypager.h
  applets/activitypager/plugin/activitypagerplugin.cpp
  applets/activitypager/plugin/activitypagerplugin.h
  applets/activitypager/plugin/model.cpp
  applets/activitypager/plugin/model.h
  applets/activitypager/plugin/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2676: Improved and optimized Pager and Activity Pager

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP4b9d8046347b: Improved and optimized Pager and 
Activity Pager (authored by hein).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2676?vs=6493&id=6496

REVISION DETAIL
  https://phabricator.kde.org/D2676

AFFECTED FILES
  applets/pager/CMakeLists.txt
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml
  applets/pager/package/metadata.desktop
  applets/pager/plugin/model.cpp
  applets/pager/plugin/model.h
  applets/pager/plugin/pager.cpp
  applets/pager/plugin/pager.h
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h
  applets/pager/plugin/pagerplugin.cpp
  applets/pager/plugin/windowmodel.cpp
  applets/pager/plugin/windowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2676: Improved and optimized Pager and Activity Pager

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  One idea to think about if you think it makes sense, otherwise ship it!

INLINE COMMENTS

> hein wrote in pagermodel.cpp:84
> No, it's not. refreshDataSource() doesn't set anything on the models. What 
> this lambda does is make sure that in VirtualDesktopsPager mode, the Pager 
> always only shows windows that are on the current activity, by setting the 
> activity filter to the current activity when it changes. Nothing in 
> refreshDataSource() (which also isn't run when the activity changes) or 
> refresh() (ditto) does this.

You're right. Got confused.

> hein wrote in pagermodel.cpp:96
> Because this is what the old code did, and I assume whoever wrote it figured 
> out that kwin cancels show-desktop state when changing virtual desktops.

ok. That makes sense

Though:
would KWindowSystem::showingDesktopChanged would be a more robust approach to 
that?

or

info.setShowingDesktop(!info.showingDesktop());

or

...if you did switch to PlasmaShell showDashboard over the DBus (which Qt won't 
actually send over DBus) you get toggling done for free.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2675: Add desktop layout rows property.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEccdb29b235d3: Add desktop layout rows 
property. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2675?vs=6473&id=6495

REVISION DETAIL
  https://phabricator.kde.org/D2675

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2674: Add optional filtering by SkipPager window state.

[hein (Eike Hein)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEc1424673db10: Add optional filtering by 
SkipPager window state. (authored by hein).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2674?vs=6472&id=6494

REVISION DETAIL
  https://phabricator.kde.org/D2674

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 2,563 lines] D2676: Improved and optimized Pager and Activity Pager

[hein (Eike Hein)]

hein updated this revision to Diff 6493.
hein marked 5 inline comments as done.
hein added a comment.


  - Fixed ActivityInfo/VirtualDesktopInfo instanciation.
  - Added code comment to post-drag model reset.
  - Update count property when disabling model.
  - Mark layout-related properties readonly.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2676?vs=6474&id=6493

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2676

AFFECTED FILES
  applets/pager/CMakeLists.txt
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml
  applets/pager/package/metadata.desktop
  applets/pager/plugin/model.cpp
  applets/pager/plugin/model.h
  applets/pager/plugin/pager.cpp
  applets/pager/plugin/pager.h
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h
  applets/pager/plugin/pagerplugin.cpp
  applets/pager/plugin/windowmodel.cpp
  applets/pager/plugin/windowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2676: Improved and optimized Pager and Activity Pager

[hein (Eike Hein)]

hein marked 9 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:175
> add some readonly's over here.
> 
> It's apparently marginally faster; plus it can make things a bit more readable

Will do.

> davidedmundson wrote in main.qml:402
> why?

Using Quick's drag functionality on the delegate breaks the binding that will 
otherwise cause it to be repositioned based on the model's Geometry role. 
Resetting the model destroys and recreates the delegate. The old code relied on 
this happening implicitly (because that model would reset tens of thousands of 
times throughout a typical session on window state changes), in the new code it 
needs to be done explicitly. It would be possible to optimize this more, but 
it's not really worth more complicated code (or extra objects like Bindings) 
considering DND is rare and operation doesn't impact UX. I'll add a comment 
though.

> davidedmundson wrote in pagermodel.cpp:76
> you delete them in 
> if (!instanceCount) in the dstror,
> 
> but you're creating them statically.
> 
> that will crash on create/remove/create and it's a bit weird.

Fixed.

> davidedmundson wrote in pagermodel.cpp:84
> this is effectively duped in refreshDatasSource()

No, it's not. refreshDataSource() doesn't set anything on the models. What this 
lambda does is make sure that in VirtualDesktopsPager mode, the Pager always 
only shows windows that are on the current activity, by setting the activity 
filter to the current activity when it changes. Nothing in refreshDataSource() 
(which also isn't run when the activity changes) or refresh() (ditto) does this.

> davidedmundson wrote in pagermodel.cpp:96
> I'm a bit confused here.
> 
> If VirtualDesktop changes you're resetting your own knowledge of if the 
> desktop is shown or not. 
> Why?

Because this is what the old code did, and I assume whoever wrote it figured 
out that kwin cancels show-desktop state when changing virtual desktops.

> davidedmundson wrote in pagermodel.cpp:250
> emit countChanged in both places

It's not needed in the first case because refresh() does it, but good catch on 
the second.

> davidedmundson wrote in pagermodel.cpp:429
> this is a new feature?
> 
> It doesn't work in the current version anyway.
> 
> Note there is a DBus verison of showDashboard which is maybe sensible to use? 
> It cuts out some of the X specific code.

Not new feature, and works just fine for me?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D2365#45684, @dfaure wrote:
  
  > The thing is, mimetype filters should be preferred above name filters. So 
the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to 
selectNameFilter. Instead it should call some 
selectInitiallySelectedMimeTypeFilter in the options, like selectNameFilter 
does with setInitiallySelectedNameFilter, and QPlatformFileDialogHelper is 
missing a selectMimeTypeFilter.
  >
  > The fallback to selectNameFilter should only happen if d->usingWidgets() or 
d->selectMimeTypeFilter_sys() (to be added) fails.
  >
  > Feel like making a patch for Qt ?
  
  
  Patch up for review at https://codereview.qt-project.org/#/c/170332/

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D2365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, graesslin, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 395 lines] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 6491.
broulik added a comment.


  Get rid of KActionCollection to drop KXmlGui dependency

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2680?vs=6482&id=6491

REVISION DETAIL
  https://phabricator.kde.org/D2680

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/plugin/globalshortcuts.cpp
  applets/taskmanager/plugin/globalshortcuts.h
  applets/taskmanager/plugin/globalshortcutsbackend.cpp
  applets/taskmanager/plugin/globalshortcutsbackend.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D2683: Simplify AbstractListItem logic

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMI9261ecc98d10: Simplify AbstractListItem logic 
(authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2683?vs=6489&id=6490

REVISION DETAIL
  https://phabricator.kde.org/D2683

AFFECTED FILES
  src/controls/templates/AbstractListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Accepted] D2683: Simplify AbstractListItem logic

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  arcpatch-D2683

REVISION DETAIL
  https://phabricator.kde.org/D2683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated, 16 lines] D2683: Simplify AbstractListItem logic

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6489.
apol added a comment.


  address as suggested by marco

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2683?vs=6488&id=6489

BRANCH
  arcpatch-D2683

REVISION DETAIL
  https://phabricator.kde.org/D2683

AFFECTED FILES
  src/controls/templates/AbstractListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated] D2683: Simplify AbstractListItem logic

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.
apol added a comment.


  Fixed issue

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128849/#review98939
---


Ship it!




Ship It!

- Marco Martin


On Sept. 6, 2016, 2:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128849/
> ---
> 
> (Updated Sept. 6, 2016, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's not like applet() can change, can it?
> 
> On my maching nativeInterface is called 90 times (System Tray and 
> Notifications use it), doing a string comparison every time.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h a215ddd 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 
> 
> Diff: https://git.reviewboard.kde.org/r/128849/diff/
> 
> 
> Testing
> ---
> 
> System Tray and Notifications still work
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Updated] D2683: Simplify AbstractListItem logic

[mart (Marco Martin)]

mart added a comment.


  good idea, shouldn't add api tough

INLINE COMMENTS

> AbstractListItem.qml:168
>  
> -Component.onCompleted: {
> +function integrateBackground() {
>  if (background) {

move it into itemMouse (or anywhere where gets hidden from the public api)

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2683

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 2 lines] D2682: Make sure padding is respected in the GlobalDrawer

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Sets it just like on the other components, could probably be refactored
  into a parent's margin

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2682

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Review Request 128851: [AppletQuickItem] Break from loop when we found a layout

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128851/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

There's no point in going on once we found a layout.


Diffs
-

  src/plasmaquick/appletquickitem.cpp a95c445 

Diff: https://git.reviewboard.kde.org/r/128851/diff/


Testing
---

Reduces number of loop iterations by 20% on my machine


Thanks,

Kai Uwe Broulik

[Differential] [Request, 9 lines] D2683: Simplify AbstractListItem logic

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Make it an Item rather than a rectangle, the background item is supposed
  to be the base item.
  Make sure we don't have 2 different code paths for setting a background.
  Ensure both do the same

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2683

AFFECTED FILES
  src/controls/templates/AbstractListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

[Marco Martin]

> On Sept. 6, 2016, 2:32 p.m., David Edmundson wrote:
> > 1) That seems a somewhat premature optimisation? We do literally millions 
> > of string comparisons elsewhere.
> >  
> > 2) get rid of the string comparison and compare the metaObject to 
> > Applet::staticMetaObject() and you can kill the string comparison. That 
> > will be better regardless.
> > 
> > I think you can compare the classInfoOffset ?

i think it's an optimization sensible enough.
and yeah, comparing the metaobject would be better than caching the result and 
doing a first string comparison


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128849/#review98938
---


On Sept. 6, 2016, 2:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128849/
> ---
> 
> (Updated Sept. 6, 2016, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's not like applet() can change, can it?
> 
> On my maching nativeInterface is called 90 times (System Tray and 
> Notifications use it), doing a string comparison every time.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h a215ddd 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 
> 
> Diff: https://git.reviewboard.kde.org/r/128849/diff/
> 
> 
> Testing
> ---
> 
> System Tray and Notifications still work
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Closed] D2681: Remove unused traces of kdesu

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEa2202472aa4d: Remove unused traces of kdesu 
(authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2681?vs=6485&id=6486

REVISION DETAIL
  https://phabricator.kde.org/D2681

AFFECTED FILES
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128849: [AppletQuickItem] Reduce string comparisons

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128849/#review98938
---



1) That seems a somewhat premature optimisation? We do literally millions of 
string comparisons elsewhere.
 
2) get rid of the string comparison and compare the metaObject to 
Applet::staticMetaObject() and you can kill the string comparison. That will be 
better regardless.

I think you can compare the classInfoOffset ?

- David Edmundson


On Sept. 6, 2016, 2:19 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128849/
> ---
> 
> (Updated Sept. 6, 2016, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's not like applet() can change, can it?
> 
> On my maching nativeInterface is called 90 times (System Tray and 
> Notifications use it), doing a string comparison every time.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h a215ddd 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 
> 
> Diff: https://git.reviewboard.kde.org/r/128849/diff/
> 
> 
> Testing
> ---
> 
> System Tray and Notifications still work
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D2680#49912, @broulik wrote:
  
  > > Do we really need KActionCollection? At least in KWin I ported away from 
it, because I don't want the xmlgui dependency.
  >
  > Isn't needed at all from what I can tell. I could just set the component 
name property manually and call it a day.
  
  
  yeah, cool!

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D2681: Remove unused traces of kdesu

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2681

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > Do we really need KActionCollection? At least in KWin I ported away from 
it, because I don't want the xmlgui dependency.
  
  Isn't needed at all from what I can tell. I could just set the component name 
property manually and call it a day.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Review Request 128849: [AppletQuickItem] Reduce string comparisons

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128849/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

It's not like applet() can change, can it?

On my maching nativeInterface is called 90 times (System Tray and Notifications 
use it), doing a string comparison every time.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h a215ddd 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 466dbd8 

Diff: https://git.reviewboard.kde.org/r/128849/diff/


Testing
---

System Tray and Notifications still work


Thanks,

Kai Uwe Broulik

[Differential] [Closed] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP9c8b7b7e9aa3: [Task Manager] Disallow 
adding/removing launchers when system immutable (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2678?vs=6478&id=6484

REVISION DETAIL
  https://phabricator.kde.org/D2678

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D2681: Remove unused traces of kdesu

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Include is unused, and kdesu should die regardless

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2681

AFFECTED FILES
  runners/shell/CMakeLists.txt
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> CMakeLists.txt:35
> +  KF5::WindowSystem
> +  KF5::XmlGui)
>  

Do we really need KActionCollection? At least in KWin I ported away from it, 
because I don't want the xmlgui dependency. Overall KActionCollection is just 
doing some convenience stuff which is not really needed.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: graesslin, lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > the owner doesn't seem to be saved and restored anywhere, so it may happen 
that is not deterministic who owns it? (not sure if needed tough)
  
  In Component.onCompleted it sets itself as owner if its config says the 
feature is Enabled
  
  > btw, if one had an Applet subclass implementation, there is a 
globalConfig() kconfiggroup thatsaves and reads in an area of appletsrc common 
for all applets of a given tye
  
  Neat. There I could just store the ID and then we also avoid two applets 
claiming to be the owner (should not happen but who knows)
  
  > what would happen if a user has existing shortcuts defined already?
  
  They won't be re-assigned, ie. if Meta+1 is already something else, it will 
stay that way. But you can end up with a bit of a mixture of, for example, only 
Meta+4, Meta+5, Meta+6 being assigned to task manager if the others were 
occupied.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2680#49893, @lbeltrame wrote:
  
  > A question: what would happen if a user has existing shortcuts defined 
already? (I know that's a non-default case)
  
  
  afaik then the corresponding shortcuts from the taskbar should be disabled by 
default

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[lbeltrame (Luca Beltrame)]

lbeltrame added a comment.


  A question: what would happen if a user has existing shortcuts defined 
already? (I know that's a non-default case)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: lbeltrame, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2675: Add desktop layout rows property.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  virtd

REVISION DETAIL
  https://phabricator.kde.org/D2675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[mart (Marco Martin)]

mart added a comment.


  the owner doesn't seem to be saved and restored anywhere, so it may happen 
that is not deterministic who owns it? (not sure if needed tough)
  (btw, if one had an Applet subclass implementation, there is a globalConfig() 
kconfiggroup thatsaves and reads in an area of appletsrc common for all applets 
of a given tye

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 310 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/310/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 13:28:10 +
Build duration: 19 min

CHANGE SET
Revision 9c8b7b7e9aa3d319415d6be1a25367c06395a109 by kde: ([Task Manager] 
Disallow adding/removing launchers when system immutable)
  change: edit applets/taskmanager/package/contents/ui/main.qml
  change: edit applets/taskmanager/package/contents/ui/ContextMenu.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Abandoned] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

[Daniel Vrátil]

dvratil abandoned this revision.
dvratil added a comment.


  Found a way to fix the issue in Akonadi.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2679

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, davidedmundson, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated the test plan for this revision.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 399 lines] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a rather often requested functionality but in Plasma this is much 
trickier as we could have multiple task bars.
  
  Only one task manager applet can have the option enabled. If the user has 
more than one task manager applet, the configuration dialog will indicate this 
fact when there's more than one applet present (simply be default, you know).

TEST PLAN
  The option is enabled by default, so on startup the first task bar that is 
created will have this (hence the enum crap instead of a simple bool).
  
  I think KWin at least occupies Meta+0 for it, so that cannot be assigned by 
default. (Forgot whether the others wee pre-occupied).
  
  When checking the option in an applet while another one already has it, it 
will be unchecked for the other applet. If you uncheck it, the functionality 
will be disabled.
  
  Config dialog
  F277736: Screenshot_20160906_152525.png 
  
  When there are multiple applets present (wording/visuals could be improved)
  F277737: Screenshot_20160906_152541.png 
  
  Global shortcuts config
  F277738: Screenshot_20160906_153507.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/plugin/globalshortcuts.cpp
  applets/taskmanager/plugin/globalshortcuts.h
  applets/taskmanager/plugin/globalshortcutsbackend.cpp
  applets/taskmanager/plugin/globalshortcutsbackend.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2673: [AppletConfiguration] Don't call saveConfig() twice

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2673

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128819: grid layout for windowdecoration KCM

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/
---

(Updated Sept. 6, 2016, 1:19 nachm.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kwin


Description
---

change the list layout to a grid layout and move the config button to the 
preview.


Diffs
-

  kcmkwin/kwindecoration/qml/Previews.qml a146f86 

Diff: https://git.reviewboard.kde.org/r/128819/diff/


Testing
---

qml file was tested on my system.


this is my first qml patch so be careful.


File Attachments


window decoration kcm update
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png


Thanks,

Andreas Kainz

[Differential] [Changed Subscribers] D2676: Improved and optimized Pager and Activity Pager

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in pagermodel.cpp:250
> emit countChanged in both places

couldn't be instead connected modelreset,rowsinserted,rowsdeleted signals to 
countchanged signal?

> davidedmundson wrote in pagermodel.cpp:429
> this is a new feature?
> 
> It doesn't work in the current version anyway.
> 
> Note there is a DBus verison of showDashboard which is maybe sensible to use? 
> It cuts out some of the X specific code.

the current pager has it (settings, "when clicking on current desktop")

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2652: Let the application control the menu further

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKIRIGAMIdd4173055e14: Let the application control the menu 
further (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2652?vs=6479&id=6481

REVISION DETAIL
  https://phabricator.kde.org/D2652

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Accepted] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2677

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, mart, davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2676: Improved and optimized Pager and Activity Pager

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Generally awesome.
  One major bug, rest are tiny comments.
  
  Will give it a second review later, as it's a bit patch and I got tired :)

INLINE COMMENTS

> main.qml:175
>  
> -mainText: desktopName
> -// our ToolTip has maximumLineCount of 8 which doesn't fit but 
> QML doesn't
> -// respect that in RichText so we effectively can put in as much 
> as we like :)
> -// it also gives us more flexibility when it comes to styling 
> the 
> -textFormat: Text.RichText
> +property int effectiveRows: {
> +var columns = Math.floor(repeater.count / pagerModel.layoutRows);

add some readonly's over here.

It's apparently marginally faster; plus it can make things a bit more readable

> main.qml:402
> +
> +pagerModel.refresh();
> +} else {

why?

> pagermodel.cpp:76
> +int PagerModel::Private::instanceCount = 0;
> +ActivityInfo *PagerModel::Private::activityInfo = new ActivityInfo();
> +VirtualDesktopInfo *PagerModel::Private::virtualDesktopInfo = new 
> VirtualDesktopInfo();

you delete them in 
if (!instanceCount) in the dstror,

but you're creating them statically.

that will crash on create/remove/create and it's a bit weird.

> pagermodel.cpp:84
> +
> +QObject::connect(activityInfo, &ActivityInfo::currentActivityChanged, q,
> +[this]() {

this is effectively duped in refreshDatasSource()

> pagermodel.cpp:96
> +[this]() {
> +desktopDown = false;
> +}

I'm a bit confused here.

If VirtualDesktop changes you're resetting your own knowledge of if the desktop 
is shown or not. 
Why?

> pagermodel.cpp:250
> +d->windowModels.clear();
> +
> +endResetModel();

emit countChanged in both places

> pagermodel.cpp:429
> +// Toggle the desktop.
> +if (d->showDesktop) {
> +NETRootInfo info(QX11Info::connection(), 0);

this is a new feature?

It doesn't work in the current version anyway.

Note there is a DBus verison of showDashboard which is maybe sensible to use? 
It cuts out some of the X specific code.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

[Daniel Vrátil]

dvratil added reviewers: davidedmundson, broulik.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2679

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, davidedmundson, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D2679: Prevent crash when a KRunner plugin triggers loading QtWebEngine

[Daniel Vrátil]

dvratil created this revision.
dvratil set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Workaround a crash when a KRunner plugin triggers libQt5WebEngine being 
loaded from the runner thread. QtWebEngine has a QtStartUpFunction that will 
abort when invoked from non-GUI thread. A workaround is to enable context 
sharing in KRunner's main() so that QtWebEngine won't try to do that itself 
when loaded.
  
  Since KRunner is just a single window, this flag will have no side-effects.
  
  BUG: 364342

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2679

AFFECTED FILES
  krunner/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6479.
apol added a comment.


  Ugh...

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2652?vs=6477&id=6479

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2652

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Accepted] D2652: Let the application control the menu further

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Accepted] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  yes please :D (after https://phabricator.kde.org/D2676 of course)

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2677

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2678

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Requested Changes To] D2652: Let the application control the menu further

[mart (Marco Martin)]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  almost good to go

INLINE COMMENTS

> GlobalDrawer.qml:369
>  stackView.push(menuComponent, 
> {"model": modelData.children, "level": level + 1});
> -} else {
> -stackView.pop(stackView.initialItem);
> -if (root.modal) {
> -root.opened = false;
> -}
> +} else if (root.moveUpOnLeafAction) {
> +root.resetMenu();

you renamed the property to resetOnMenuTriggered, so this should be updated as 
well

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

Re: Review Request 128819: grid layout for windowdecoration KCM

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/#review98927
---


Ship it!




code now looks fine to me

- Marco Martin


On Sept. 4, 2016, 6:37 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128819/
> ---
> 
> (Updated Sept. 4, 2016, 6:37 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> change the list layout to a grid layout and move the config button to the 
> preview.
> 
> 
> Diffs
> -
> 
>   kcmkwin/kwindecoration/qml/Previews.qml a146f86 
> 
> Diff: https://git.reviewboard.kde.org/r/128819/diff/
> 
> 
> Testing
> ---
> 
> qml file was tested on my system.
> 
> 
> this is my first qml patch so be careful.
> 
> 
> File Attachments
> 
> 
> window decoration kcm update
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

Re: Kiosk Documentation?

[Marco Martin]

On Thu, Aug 25, 2016 at 2:59 PM, Dennis Knorr  wrote:
> Hi,
> i just wanted to look at the new kiosk implementation for plasma 5.7, but
> i'm not really sure where to look. I tried
> https://userbase.kde.org/KDE_System_Administration/Kiosk/Introduction but
> further links there are brokenore empty:
> http://websvn.kde.org/trunk/KDE/kdelibs/kdecore/doc/README.kiosk?view=markup
> http://developer.kde.org/source/
>



Hi,
we are rewriting those pages on userbase to bear a more up to date content

--
Marco Martin

[Differential] [Request, 10 lines] D2678: [Task Manager] Disallow adding/removing launchers when system immutable

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We locked favorites in Kickoff but didn't lock down the launchers.

TEST PLAN
  Put the following in kdeglobals
  
[KDE Action Restrictions]
plasma/plasmashell/unlockedDesktop=false
  
  - "Show launcher when not running" and "Remove this launcher" entry was gone 
from context menu
  - Dropping app on task bar did nothing
  - "Add as launcher" in Kickoff was hidden already in this case
  
  Without the aforementioned restriction:
  
  - "Show launcher when not running" and "Remove this launcher" entry was shown 
in context menu
  - Dropping app on task bar added launcher
  - "Add as launcher" in Kickoff added launcher

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2678

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2674: Add optional filtering by SkipPager window state.

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

[Martin Gräßlin]

graesslin abandoned this revision.
graesslin added a comment.


  Don't think that's needed at all.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D1359

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, #plasma, bshah
Cc: davidedmundson, bshah, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Abandoned] D1360: [lnf] Add Qt VirtualKeyboard optionally to lock screen

[Martin Gräßlin]

graesslin abandoned this revision.
graesslin added a comment.


  Abandon as the theme changed and I'm rather for adding it to be shown from 
KWin.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1360

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: sebas, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6477.
apol added a comment.


  Fix naming

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2652?vs=6423&id=6477

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2652

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Updated] D2652: Let the application control the menu further

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel, apol

[Differential] [Request, 1,878 lines] D2677: Reduce Activity Pager to .desktop file referencing the Pager package.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
hein added a dependency: D2676: Improved and optimized Pager and Activity Pager.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D2676.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2677

AFFECTED FILES
  applets/activitypager/CMakeLists.txt
  applets/activitypager/Messages.sh
  applets/activitypager/package/contents/code/utils.js
  applets/activitypager/package/contents/config/config.qml
  applets/activitypager/package/contents/config/main.xml
  applets/activitypager/package/contents/ui/configGeneral.qml
  applets/activitypager/package/contents/ui/main.qml
  applets/activitypager/package/metadata.desktop
  applets/activitypager/plugin/activitypager.cpp
  applets/activitypager/plugin/activitypager.h
  applets/activitypager/plugin/activitypagerplugin.cpp
  applets/activitypager/plugin/activitypagerplugin.h
  applets/activitypager/plugin/model.cpp
  applets/activitypager/plugin/model.h
  applets/activitypager/plugin/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2676: Improved and optimized Pager and Activity Pager

[hein (Eike Hein)]

hein added a dependent revision: D2677: Reduce Activity Pager to .desktop file 
referencing the Pager package..

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2676

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2,551 lines] D2676: Improved and optimized Pager and Activity Pager

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
hein added dependencies: D2675: Add desktop layout rows property., D2674: Add 
optional filtering by SkipPager window state..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  - Unify Desktop and Activity Pager applets. The latter was an out-of- sync 
fork of the former, with 99% code copied needlessly. Separate commit to 
kdeplasma-addons pending that slashes the Activity Pager down to a .desktop 
file.
  
  - Share window state monitoring backend with the Task Manager by porting to 
libtaskmanager. Reduces the window state monitoring in a typical plasmashell 
instance from two to one. Saves CPU time, memory use and improves support for 
Wayland.
  
  - Don't destroy and recreate all delegates every time window focus or other 
window state changes. Saves a lot of CPU time.
  
  - Save various items and objects by e.g. creating window icon and
  - desktop label items only when needed and cleaning up frontend code.
  
  Lazy-create
  
the data source needed to show the activity manager once it's needed.
Results in much lighter Pager (at least two items per window and one
item per desktop) with default settings.
  
  - Avoid doing tons of unnecessary calculations during DND.
  
  - Some minor HiDPI scaling fixes.
  
  - Other cleanup: More visualization-agnostic backend, coding style.
  
  Depends on https://phabricator.kde.org/D2674, 
https://phabricator.kde.org/D2675.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2676

AFFECTED FILES
  applets/pager/CMakeLists.txt
  applets/pager/package/contents/ui/configGeneral.qml
  applets/pager/package/contents/ui/main.qml
  applets/pager/package/metadata.desktop
  applets/pager/plugin/model.cpp
  applets/pager/plugin/model.h
  applets/pager/plugin/pager.cpp
  applets/pager/plugin/pager.h
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h
  applets/pager/plugin/pagerplugin.cpp
  applets/pager/plugin/windowmodel.cpp
  applets/pager/plugin/windowmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2675: Add desktop layout rows property.

[hein (Eike Hein)]

hein added a dependent revision: D2676: Improved and optimized Pager and 
Activity Pager.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2674: Add optional filtering by SkipPager window state.

[hein (Eike Hein)]

hein added a dependent revision: D2676: Improved and optimized Pager and 
Activity Pager.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 41 lines] D2675: Add desktop layout rows property.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  For use by Desktop Pagers using libtaskmanager.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  virtd

REVISION DETAIL
  https://phabricator.kde.org/D2675

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 54 lines] D2674: Add optional filtering by SkipPager window state.

[hein (Eike Hein)]

hein updated this revision to Diff 6472.
hein added a comment.


  Remove accidentally committed files.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2674?vs=6471&id=6472

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2674

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 374 lines] D2674: Add optional filtering by SkipPager window state.

[hein (Eike Hein)]

hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  For use by desktop pagers using libtaskmanager.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2674

AFFECTED FILES
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.cpp.orig
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskfilterproxymodel.h.orig
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128819: grid layout for windowdecoration KCM

[Andreas Kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/#review98923
---



somethings to change, or is everything fine?

- Andreas Kainz


On Sept. 4, 2016, 6:37 nachm., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128819/
> ---
> 
> (Updated Sept. 4, 2016, 6:37 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> change the list layout to a grid layout and move the config button to the 
> preview.
> 
> 
> Diffs
> -
> 
>   kcmkwin/kwindecoration/qml/Previews.qml a146f86 
> 
> Diff: https://git.reviewboard.kde.org/r/128819/diff/
> 
> 
> Testing
> ---
> 
> qml file was tested on my system.
> 
> 
> this is my first qml patch so be careful.
> 
> 
> File Attachments
> 
> 
> window decoration kcm update
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

[Differential] [Request, 4 lines] D2673: [AppletConfiguration] Don't call saveConfig() twice

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  root.saveConfig() already calls saveConfig() on the current page, no need to 
explicitly do that in the apply button.

TEST PLAN
  No longer saves twice. Still saves once

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2673

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 309 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/309/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 09:26:48 +
Build duration: 7 min 22 sec

CHANGE SET
Revision 08769ab7e4ca7e8578475da201da5abec4922327 by David Edmundson: (set 
offscreen highlight item to invisible when off screen or not being)
  change: edit containments/desktop/package/contents/ui/main.qml
Revision 0c5a70939aed0113364d9fa4380d8236f5a98bec by David Edmundson: (Fix 
spelling mistake in property name Also mark read only property as)
  change: edit desktoppackage/contents/views/Panel.qml
Revision 3184d34d8d67c5bb7d00d8a5339b414d6a8bf169 by David Edmundson: (Reduce 
duplicated code and document very difficult to parse code.)
  change: edit desktoppackage/contents/views/Panel.qml
Revision cb477299c8a4557005f1fceec7bfcbf6c62e575e by David Edmundson: (Remove 
outdated code)
  change: edit desktoppackage/contents/views/Panel.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Differential] [Closed] D2590: Use new inline revealpassword action

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMANM304ba1978528: Use new inline revealpassword action 
(authored by davidedmundson).

REPOSITORY
  rPLASMANM Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2590?vs=6293&id=6469

REVISION DETAIL
  https://phabricator.kde.org/D2590

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2669: Set offscreen highlight item to invisible when off screen or not being shown

[davidedmundson (David Edmundson)]

davidedmundson closed this revision.
davidedmundson added a comment.


  submitted

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2669

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D2670: Fix spelling mistake in property name Also mark read only property as readonly

[davidedmundson (David Edmundson)]

davidedmundson closed this revision.
davidedmundson added a comment.


  submitted

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2670

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2671: Reduce duplicated code and document very difficult to parse code.

[davidedmundson (David Edmundson)]

davidedmundson closed this revision.
davidedmundson added a comment.


  submitted

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2672: Remove pointless code

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPcb477299c8a4: Remove outdated code (authored by 
davidedmundson).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2672?vs=6465&id=6468

REVISION DETAIL
  https://phabricator.kde.org/D2672

AFFECTED FILES
  desktoppackage/contents/views/Panel.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2672: Remove pointless code

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Good research, thanks. 
  (I think that makes it my fault for removing half of it, and not the other 
half)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2672: Remove pointless code

[mart (Marco Martin)]

mart added a comment.


  removing it makes sense to me
  as that code is weird, here's my research on its history:
  
  looking at why it was inserted:
  commit 
https://phabricator.kde.org/rPLASMADESKTOP0cf01e3d2a5b8a2e23dad50cfdefffdc093c6bee
  "This patch fixes this warning and also some rendering issues in the panel's 
settings dialog, where the buttons would have different sizes when laid out 
vertically."
  
  also in part
  commit 
https://phabricator.kde.org/rPLASMADESKTOPfa8270162d99a9807e2c93c1c52c821a9dd22ad4
  "don't auto resize when the panel controller is open"
  
  for 
https://phabricator.kde.org/rPLASMADESKTOPfa8270162d99a9807e2c93c1c52c821a9dd22ad4,
 this blind emitting of signals doesn't apply anymore, so the patch shoud good 
to go in

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2672: Remove pointless code

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2668: Fix panelView updateEnabledBorders being skipped

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE993983b3c310: Fix panelView 
updateEnabledBorders being skipped (authored by davidedmundson).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2668?vs=6461&id=6467

REVISION DETAIL
  https://phabricator.kde.org/D2668

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Ben Cooksley]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98920
---



>From my perspective using www.kde.org for the browser part of the process is 
>fine. Using it to detect whether or not you are behind a captive portal (which 
>afaik is handled by NetworkManager and the URL for doing that is set by 
>distributions).

Please note that the index of www.kde.org is not static - it is dynamic 
content, generated via PHP.

- Ben Cooksley


On Sept. 6, 2016, 7:37 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Sept. 6, 2016, 7:37 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org"; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

[Differential] [Accepted] D2671: Reduce duplicated code and document very difficult to parse code.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> davidedmundson wrote in Panel.qml:97
> There's a Math.round in the usage below, and FrameMargins can also be real, 
> so it's still needed there.

given that we round the value everywhere actually used, either is fine

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2668: Fix panelView updateEnabledBorders being skipped

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2668

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128707: Add support for captive portals

[Lamarque Souza]

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote:
> > kded/portalmonitor.cpp, line 50
> > 
> >
> > I am wondering how hard this waill affect kde.org web server. This 
> > patch has the potentional to create a DDoS attack-like effect on it. Maybe 
> > someone from sysadmin should evaluate this.
> 
> Jan Grulich wrote:
> I don't think it will affect it, because when you are behind a captive 
> portal you will get redirected immediately so kde.org won't be loaded at all. 
> At least this is my understanding.
> 
> Sebastian Kügler wrote:
> The user-friendlier portals will redirect you to the site you were 
> originally going to, but I agree, kde.org can handle that (it's a static page 
> request, should be cheap enough).
> 
> What could be pretty cool is if the user would be sent to a page that 
> allows donating, kde.org does that, so there may be a net advantage, still.

Looking at that angle it is Ok from my side :-)


- Lamarque


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98901
---


On Sept. 6, 2016, 7:37 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Sept. 6, 2016, 7:37 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org"; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

Re: Review Request 128707: Add support for captive portals

[Sebastian Kügler]

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote:
> > kded/portalmonitor.cpp, line 50
> > 
> >
> > I am wondering how hard this waill affect kde.org web server. This 
> > patch has the potentional to create a DDoS attack-like effect on it. Maybe 
> > someone from sysadmin should evaluate this.
> 
> Jan Grulich wrote:
> I don't think it will affect it, because when you are behind a captive 
> portal you will get redirected immediately so kde.org won't be loaded at all. 
> At least this is my understanding.

The user-friendlier portals will redirect you to the site you were originally 
going to, but I agree, kde.org can handle that (it's a static page request, 
should be cheap enough).

What could be pretty cool is if the user would be sent to a page that allows 
donating, kde.org does that, so there may be a net advantage, still.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128707/#review98901
---


On Sept. 6, 2016, 7:37 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128707/
> ---
> 
> (Updated Sept. 6, 2016, 7:37 a.m.)
> 
> 
> Review request for Network Management, Plasma, KDE Usability, and Lamarque 
> Souza.
> 
> 
> Bugs: 365417
> http://bugs.kde.org/show_bug.cgi?id=365417
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> ---
> 
> Adds portal monitor to our kded module, which checks NetworkManager 
> connectivity. If the value gets changed to NM_CONNECTIVITY_PORTAL (means we 
> are behind a captive portal), then we open a QWebEngineView trying to load 
> "http://kde.org"; page which is supposed to be redirected to the captive 
> portal page. Once user logs in and url changes, we re-check the connectivity 
> again and close the web view if we are no longer behind the captive portal.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt a27c1f2 
>   kded/CMakeLists.txt 1f0613e 
>   kded/portalmonitor.h PRE-CREATION 
>   kded/portalmonitor.cpp PRE-CREATION 
>   kded/service.cpp 18ffd41 
> 
> Diff: https://git.reviewboard.kde.org/r/128707/diff/
> 
> 
> Testing
> ---
> 
> Tested with three different captive portals and it worked perfectly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

[Differential] [Commented On] D2613: Fix some status notifier items not appearing

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in statusnotifieritemsource.cpp:85
> Wrong indentation

There is in Phab, but there isn't on my computer... No idea why.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2613

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 29 lines] D2613: Fix some status notifier items not appearing

[davidedmundson (David Edmundson)]

davidedmundson updated this revision to Diff 6466.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.


  Fixed Kai's comments

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2613?vs=6333&id=6466

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2613

AFFECTED FILES
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 308 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/308/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 06 Sep 2016 08:34:17 +
Build duration: 11 min

CHANGE SET
Revision 29caa940011d94544e3fb8ce33c0f5967f0139d3 by kde: ([Task Manager] 
GroupDialog has no target but visualParent)
  change: edit applets/taskmanager/package/contents/ui/Task.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)