[Differential] [Commented On] D3097: Changed the launcher modification API
ivan added a comment. Just to reiterate - there should be no ABI incompatibilities compared to the previous version of the library. The API I changed was never in master (and thus never released). REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3097 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, hein, #plasma Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3134: Bring back usericon region selection
davidk updated the test plan for this revision. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3134 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 35 lines] D3134: Bring back usericon region selection
davidk created this revision. davidk added a reviewer: Plasma. davidk added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Also, improve error checking. TEST PLAN - selected an new icon, got the region selector - without the resize, saving will fail for high resolution images - When resizing to a bigger size (e.g. 800x800 pixel), icons will be too big - Canceling the region selection will not change the icon REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3134 AFFECTED FILES src/accountinfo.cpp src/createavatarjob.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3071: Port away from KDELibs4Support
This revision was automatically updated to reflect the committed changes. Closed by commit rUSERMANAGER4aafaf4e5fea: Port away from KDELibs4Support (authored by davidk). REPOSITORY rUSERMANAGER User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3071?vs=7421&id=7603 REVISION DETAIL https://phabricator.kde.org/D3071 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/accountinfo.cpp src/accountinfo.h src/createavatarjob.cpp src/lib/modeltest.cpp src/passworddialog.cpp src/passworddialog.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3130: Improve Activity Pager Layout for horizontal and vertical cases
mvourlakos added a comment. updated the diff in order to correspond correctly... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, hein Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 47 lines] D3130: Improve Activity Pager Layout for horizontal and vertical cases
mvourlakos updated the summary for this revision. mvourlakos updated this revision to Diff 7602. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3130?vs=7596&id=7602 REVISION DETAIL https://phabricator.kde.org/D3130 AFFECTED FILES applets/pager/package/contents/config/main.xml applets/pager/package/contents/ui/configGeneral.qml applets/pager/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, hein Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr added a comment. > How many frames do we need to detect the freeze? I think 30 frames is too much by default. It's adding quite some stress on startup (lots of write to config, lots of additional threads started). Assuming we freeze with tripple buffer when trying to get the next buffer 4 frames should be sufficient to trigger the freeze? Yesterday I tried with 20 and 10 frames and it detected the freeze correctly, then tried 5 and got a strange behaviour (the desktop wasn't frozen but the menus were shown displaced and there was no window decoration). I decided I would remove an option I added to the nouveau driver to test if it helped and rebooted the machine to be sure I tested with a clean system. But then I lost the connection to the machine and it seems to have a problem booting up so I can't do more tests until Monday when someone goes to the SUSE offices where the machine is and check what the problem is. In the meantime, I will improve a bit the PreFrame and PostFrame code so it doesn't add so much overhead (reusing the thread and timer, and only write the config option in the lambda function, which wouldn't work to detect a crash, but it should work to detect a freeze, so I'll separate the code of PreFrame/PostFrame from the code in PreInit/PostInit). I'll update this phab later today with those optimizations. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Abandoned] D3127: [platformx/x11] Add a freeze protection against OpenGL
graesslin abandoned this revision. graesslin added a comment. Abandoned for newer revision REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3127 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, davidedmundson, #plasma Cc: antlarr, davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
graesslin added a comment. How many frames do we need to detect the freeze? I think 30 frames is too much by default. It's adding quite some stress on startup (lots of write to config, lots of additional threads started). Assuming we freeze with tripple buffer when trying to get the next buffer 4 frames should be sufficient to trigger the freeze? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
