[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr added a comment. I don't know why, but it seems arc diff doesn't work anymore and I have to use arc diff HEAD~7 to include all 7 commits REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 63 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr updated this revision to Diff 7644. antlarr added a comment. Restricted Application edited projects, added Plasma; removed KWin. Include all 7 commits REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7638&id=7644 BRANCH arcpatch-D3127_1 REVISION DETAIL https://phabricator.kde.org/D3132 AFFECTED FILES composite.cpp composite.h platform.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: breakout: what Qt version will 5.9 require? 5.6 still or 5.7?
On Thursday, October 20, 2016 7:07:29 AM CEST Sebastian Kügler wrote: > On Monday, October 17, 2016 6:06:41 PM UTC Jonathan Riddell wrote: > > no discussion on this on during the meeting, do we need 5.7, are > > distros happy with 5.7? > > We discussed it in the other thread, the conclusion is that we'd like to > depend on 5.7 in Plasma 5.9. > > The question whether that works for distros remains. If we don't hear the > opposite, we assume it does. :) I just asked on the distro mailing list: https://mail.kde.org/pipermail/distributions/2016-October/000137.html If we don't hear anything negative I'd say we start raising the requirement on Nov 1st. I'm happy to do so in KWin by starting requiring QtVirtualKeyboard ;-) Cheers Martin signature.asc Description: This is a digitally signed message part.
[Differential] [Request, 86 lines] D3154: Send a pointer leave when triggering a move resize
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY When triggering a move resize all following pointer events are grabbed by KWin itself. Thus the correct behavior is to informe the client about it and send a pointer leave. This ensures that after the move resize ended the pointer gets a new enter. By sending anew pointer enter the position gets updated to the new position which so far did not happen and the client generated events on the wrong position. BUG: 371573 FIXED-IN: 5.8.3 REPOSITORY rKWIN KWin BRANCH move-resize-pointer-left-5.8 REVISION DETAIL https://phabricator.kde.org/D3154 AFFECTED FILES autotests/integration/move_resize_window_test.cpp pointer_input.cpp pointer_input.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, broulik Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
graesslin added a comment. The latest patch version seems to not include all changes. REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 523 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/523/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 04:12:04 + Build duration: 10 min CHANGE SET Revision 26e5a7bc4c9df555d067ef4c15ef87c4d1fb0781 by yurchor: (Fix translation catalog by Victor) change: edit lookandfeel/contents/lockscreen/LockScreenUi.qml JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.launchertasksmodeltest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 13/13 (100%)FILES 53/73 (73%)CLASSES 53/73 (73%)LINE 2102/5593 (38%)CONDITIONAL 1444/5538 (26%) By packages drkonqi.parser FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 478/616 (78%) drkonqi.tests.backtraceparsertest FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 33/50 (66%) kioslave.desktop FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 101/135 (75%)CONDITIONAL 36/66 (55%) kioslave.desktop.tests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 26/50 (52%) klipper FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 (67%)CONDITIONAL 109/210 (52%) klipper.autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 377/820 (46%) libtaskmanager FILES 6/20 (30%)CLASSES 6/20 (30%)LINE 194/3245 (6%)CONDITIONAL 119/3197 (4%) libtaskmanager.autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 150/150 (100%)CONDITIONAL 85/170 (50%) runners.bookmarks FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 34/96 (35%) runners.bookmarks.browsers FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 84/107 (79%) runners.bookmarks.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 31/62 (50%) shell FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 49/69 (71%)CONDITIONAL 17/64 (27%) shell.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 39/39 (100%)CONDITIONAL 15/30 (50%)
[Differential] [Closed] D3130: Improve Activity Pager Layout for horizontal and vertical cases
hein closed this revision. hein added a comment. Committed: http://commits.kde.org/plasma-desktop/2a5580d486acb1754913b17c19409b66ddec4d84 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: davidedmundson, mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases
mvourlakos marked an inline comment as done. mvourlakos added a comment. In https://phabricator.kde.org/D3130#58614, @hein wrote: > Good showing then :) > > I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out https://phabricator.kde.org/tag/plasma/ on freenode IRC, too! :), thanks a lot Hein! I will send two-three patches more and then apply for dev access... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: davidedmundson, mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3130: Improve Activity Pager Layout for horizontal and vertical cases
hein added a comment. Good showing then :) I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out https://phabricator.kde.org/tag/plasma/ on freenode IRC, too! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: davidedmundson, mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 129255: Fixed unrar version check.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/ --- (Updated Ott. 24, 2016, 9:27 p.m.) Review request for Plasma. Bugs: 341305 https://bugs.kde.org/show_bug.cgi?id=341305 Repository: kio-extras Description --- The parameter "--version" stopped working since unrar 5.2 which was released almost 2 years ago. With this change this now becomes the minimum version required but every distribution that is going to include a version of KDE with this commit has probably been using unrar > 5.2 for quite a while so I don't think there is any need to provide a fallback. This fixes bugs 367626 and 341305 Diffs - thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4 Diff: https://git.reviewboard.kde.org/r/129255/diff/ Testing --- Verified that the previously missing thumbnails for cbr files are now being correctly generated. Thanks, Massimiliano Torromeo
Review Request 129255: Fixed unrar version check.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/ --- Review request for Plasma. Repository: kio-extras Description --- The parameter "--version" stopped working since unrar 5.2 which was released almost 2 years ago. With this change this now becomes the minimum version required but every distribution that is going to include a version of KDE with this commit has probably been using unrar > 5.2 for quite a while so I don't think there is any need to provide a fallback. This fixes bugs 367626 and 341305 Diffs - thumbnail/comiccreator.cpp 4ec0db8c6953e2d9983e4a9d7f542b27404175e4 Diff: https://git.reviewboard.kde.org/r/129255/diff/ Testing --- Verified that the previously missing thumbnails for cbr files are now being correctly generated. Thanks, Massimiliano Torromeo
[Differential] [Changed Subscribers] D3130: Improve Activity Pager Layout for horizontal and vertical cases
davidedmundson added inline comments. INLINE COMMENTS > mvourlakos wrote in main.qml:199 > Hein, is there a way in QML to generate proper enums from config? there is not (currently) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: davidedmundson, mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases
mvourlakos marked 2 inline comments as done. mvourlakos added a comment. In https://phabricator.kde.org/D3130#58604, @hein wrote: > Do you have commit access? unfortunately not yet... this is my first patch for plasma... INLINE COMMENTS > hein wrote in main.qml:199 > Please add comments like /* Horizontal */ into the conditions for readability > (I wish we could generate proper enums from config ...). Hein, is there a way in QML to generate proper enums from config? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3130: Improve Activity Pager Layout for horizontal and vertical cases
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, hein, #plasma Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 46 lines] D3130: Improve Activity Pager Layout for horizontal and vertical cases
mvourlakos updated this revision to Diff 7641. mvourlakos added a comment. updated in needed changes REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3130?vs=7602&id=7641 REVISION DETAIL https://phabricator.kde.org/D3130 AFFECTED FILES applets/pager/package/contents/config/main.xml applets/pager/package/contents/ui/configGeneral.qml applets/pager/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, mart, #plasma, hein Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port
davidedmundson added a comment. Edit: sorry didn't see drosca replied. Wait till the VDG reply before doing any changes (as you don't want it to be wasted) REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, #plasma, #plasma:_design Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port
davidedmundson added a comment.
Do we need to do it programatically? It's should be do-able in a declarative
way with Instantiator
ContextMenu
{
MenuItem {
text: i18n("Mute");
...
}
MenuItem {
text: i18n("Default");
visible: .
}
Instantiator
{
model: PulseObject.ports
delegate: MenuItem {}
}
}
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D2314
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: Zren, #plasma, #plasma:_design
Cc: davidedmundson, drosca, colomar, plasma-devel, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
[Differential] [Accepted] D3141: systemmonitor: Optimise source updates.
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systemmonitor_perf REVISION DETAIL https://phabricator.kde.org/D3141 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: roberts, apol, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Requested Changes To] D3130: Improve Activity Pager Layout for horizontal and vertical cases
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.qml:196
>
> -var columns = Math.floor(pagerModel.count /
> pagerModel.layoutRows);
> +var rows=1;
> +
There's a lot of small coding style nits like no spaces around = here or no
space after 'if' all throughout the patch - please clean that up a little bit.
> main.qml:199
> +///pagerLayout value supports 0-Default, 1-Horizontal, 2-Vertical
> +if(isActivityPager && plasmoid.configuration.pagerLayout !== 0) {
> +if (plasmoid.configuration.pagerLayout === 1){
Please add comments like /* Horizontal */ into the conditions for readability
(I wish we could generate proper enums from config ...).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3130
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mvourlakos, mart, hein, #plasma
Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
[Differential] [Changed Subscribers] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port
drosca added subscribers: colomar, drosca. drosca added a comment. @colomar Can you please comment on this? We have been talking about using a context menu in plasmoid, but I don't remember what was the final decision from the VDG? REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2314 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: Zren, #plasma, #plasma:_design Cc: drosca, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3130: Improve Activity Pager Layout for horizontal and vertical cases
ivan added a reviewer: mart. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, hein, mart Cc: mvourlakos, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Closed] D3083: Mute volume when decreasing volume to zero
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA6366791aaa50: Mute volume when decreasing volume to zero (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3083?vs=7455&id=7639 REVISION DETAIL https://phabricator.kde.org/D3083 AFFECTED FILES applet/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr marked 5 inline comments as done. antlarr added a comment. All issues done REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Updated, 10 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr updated this revision to Diff 7638. antlarr added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Only call PostLastGuardedFrame when OpenGLCompositing is set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7637&id=7638 BRANCH arcpatch-D3127_1 REVISION DETAIL https://phabricator.kde.org/D3132 AFFECTED FILES composite.cpp composite.h plugins/platforms/x11/standalone/x11_platform.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr added inline comments. INLINE COMMENTS > luebking wrote in x11_platform.cpp:206 > PreFrame is (now) effectively "PreFirstGuardedFrame", is it? > And if invoked at some later point would create the timer and hit the config > rewrite every single frame (for the counter is stuck at 0)? > > > rename to avoid bad invocation? > = Not really, it's expected to be called many times and it checks if it's the first time it was called or not (also, when the counter gets to 0 it's never called anymore) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
graesslin added inline comments.
INLINE COMMENTS
> composite.cpp:748
> +m_framesToTestForSafety--;
> + if (m_framesToTestForSafety == 0) {
> +
> kwinApp()->platform()->createOpenGLSafePoint(Platform::OpenGLSafePoint::PostLastGuardedFrame);
this misses the
if (m_scene->compositingType() & OpenGLCompositing)
> x11_platform.cpp:225-227
> +}
> +else
> +{
nitpick: coding style
} else {
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
luebking added inline comments.
INLINE COMMENTS
> graesslin wrote in composite.cpp:748
> this misses the
>
> if (m_scene->compositingType() & OpenGLCompositing)
also indention.
> x11_platform.cpp:206
> +// Deliberately continue with PreFrame
> +case OpenGLSafePoint::PreFrame:
> +if (m_openGLFreezeProtectionThread == nullptr) {
PreFrame is (now) effectively "PreFirstGuardedFrame", is it?
And if invoked at some later point would create the timer and hit the config
rewrite every single frame (for the counter is stuck at 0)?
> rename to avoid bad invocation?
=
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 65 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr updated this revision to Diff 7637. antlarr added a comment. Restricted Application edited projects, added Plasma; removed KWin. Include all 6 commits REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7636&id=7637 BRANCH arcpatch-D3127_1 REVISION DETAIL https://phabricator.kde.org/D3132 AFFECTED FILES composite.cpp composite.h platform.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated, 63 lines] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr updated this revision to Diff 7636. antlarr marked 21 inline comments as done. antlarr added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Use only one timer to detect freezes and other optimizations - Test 3 frames for freezes by default CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3132?vs=7613&id=7636 BRANCH arcpatch-D3127_1 REVISION DETAIL https://phabricator.kde.org/D3132 AFFECTED FILES composite.cpp composite.h platform.h plugins/platforms/x11/standalone/x11_platform.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #9 from Harald Sitter --- If everyone used refind we'd all be happier for it ;) -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #8 from Kai Uwe Broulik --- I must say, Grub is also absurdly slow on my machine, especially with high resolution screens (4K) the menu takes multiple seconds(!) to draw and repaint. I never bothered to complain, though, as I hardly use or see the menu :) -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 Harald Sitter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #7 from Harald Sitter --- Sure if it is laggish then it shouldn't be themed. That too is something that ought to be addressed in GRUB though, as only GRUB knows if rendering is obscenely slow. Now this doesn't seem particularly common given you are the only person who complained. Best I can do is make distributions aware of this. If you think that we should not advise using the theme based on the rendering lag, that is something you want to take up with the VDG. Personally I advise whoever has the problem to simply disable the theme. It's basically having shit UX for everyone (no theme) or shit UX for a select few (laggish rendering). -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #6 from Roman --- Of course somebody else has reported it already: http://savannah.gnu.org/bugs/?46133 There is no mention of a theme as the issue, but one of the links is to the redhat bug, I posted earlier. If this is a common problem, as a workaround until it is solved I would prefer to not use a theme at all per default. An unusable slow GRUB in case of high resolution displays is worse than having a not so nice looking GRUB. But I'm currently the only one complaining here, so as long as there are no other people I'm fine with waiting on a fix by GRUB (which, when I look at their bugtracker could be forever...). I can disable the theme on my PC in the meantime. -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Abandoned] D3078: Add new DBus method for applet de-/activation and in order to fix non-closing launchers on Meta (and also on Active Screenedges)
subdiff abandoned this revision. subdiff added a comment. Abandoned because we now use the other solution in https://git.reviewboard.kde.org/r/129204/ making this diff not necessary anymore. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3078 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, graesslin, davidedmundson Cc: plasma-devel, #plasma, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Accepted] D3152: [Task Manager] Return early if there's no launcherUrl
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3152 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 4 lines] D3152: [Task Manager] Return early if there's no launcherUrl
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it throws "Cannot call method 'toString' of undefined" and the context menu won't open when mapping an application to a launcher (as happens with Gwenview on Wayland) fails. TEST PLAN Started Gwenview on wayland, right-click menu works for it now. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3152 AFFECTED FILES applets/taskmanager/package/contents/ui/main.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 2 lines] D3151: Trigger resize of input window when deco size changes
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Client::updateInputWindow operates with the decoration size. The method gets called from various points when changing the window geometry. If at that moment the decoration has not updated yet, the borders might be at a wrong position. This behavior could be triggered when a window requested to change the state to maximized. During maximization the decoration still had the wrong size when updateInputWindow was called, thus an interactive area inside the window was created. To circumvent this problem updateInputWindow is now also called whenever the window decoration changes. As a note: that a maximized window has resize only borders is wrong. Kwin should be protected against that. BUG: 371284 FIXED-IN: 5.8.3 TEST PLAN Checked xwininfo for the deco extends window REPOSITORY rKWIN KWin BRANCH input-window-maximize-5.8 REVISION DETAIL https://phabricator.kde.org/D3151 AFFECTED FILES client.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
Minutes Monday Plasma Meeting
Plasma meeting (IRC), 24-10-2016 Present: mgraesslin, romangg, bshah, d_ed, Sho, sebas mgraesslin: * move windows in widget style oxygen (D3096) Diff 3096 "[kstyle] Implement window moving on Wayland" [Closed] https:// phabricator.kde.org/D3096 * New KWin internal API to get current cursor image (D3093) Diff 3093 "Add a PlatformCursorImage to Platform and EffectsHandler" [Closed] https://phabricator.kde.org/D3093 * Track cursor shape changes on Wayland (D3095) Diff 3095 "Implement cursor shape tracking on Wayland" [Closed] https:// phabricator.kde.org/D3095 * blur/background contrast effect on multi-screen (D3099, D3100, D3101) Diff 3099 "Fix viewport restore in GLRenderTarget::popRenderTarget" [Closed] https://phabricator.kde.org/D3099 Diff 3100 "Expose GLRenderTarget::virtualScreenGeometry" [Closed] https:// phabricator.kde.org/D3100 Diff 3101 "Adjust blur and contrast for multi-output rendering on Wayland" [Closed] https://phabricator.kde.org/D3101 * Fix Wayland shadow for panel (D3109) * Fix tooltips on Wayland for Systemsettings and KInfocenter (D3112, D3113) Diff 3109 "[shell] Create panelshadow in surfacecreated event instead of show event" [Closed] https://phabricator.kde.org/D3109 Diff 3112 "Pass transient parent window to KToolTipWindow" [Closed] https:// phabricator.kde.org/D3112 Diff 3113 "Pass transient parent window to KToolTipWindow" [Closed] https:// phabricator.kde.org/D3113 things not yet merged/working on: * Support capture cursor image in Screenshot effect (D3118) Diff 3118 "[effects] Support capture cursor image in Screenshot effect" [Needs Review] https://phabricator.kde.org/D3118 * Show/hide cursor through Platform (D3119) Diff 3119 "Add way to hide/show cursor in Platform" [Accepted] https:// phabricator.kde.org/D3119 * ... and use it in zoom effect (D3120) Diff 3120 "[kwineffects] Add hide/show cursor to EffectsHandler" [Needs Review] https://phabricator.kde.org/D3120 * Remove runtime dependency on X11 from StartupFeedbackEffect (D3121) Diff 3121 "Create KSelectionOwner in StartupFeedbackEffect only on X11" [Needs Review] https://phabricator.kde.org/D3121 * Implementation of a clipboard manager protocol for Klipper on Wayland - almost working * ... found possible crashers in selection handling due to that (D3148, D3149, D3150) Diff 3148 "[server] Ensure we have a DataSource on the DataDevice in setSelection" [Needs Review] https://phabricator.kde.org/D3148 Diff 3149 "[server] Fix possible crash on creation of DataDevice" [Needs Review] https://phabricator.kde.org/D3149 Diff 3150 "[server] Fix crash on updating focused keyboard surface" [Needs Review] https://phabricator.kde.org/D3150 * Helped openSUSE workaround release blocking KWin freeze on nouveau resulted in D3132 * Investigated a Krita induced bug in KWin which triggered window movement - bug 371284. Seems to be caused by window decoration in combination with Krita opening maximized in a weird way. Diff 3132 "[platformx/x11] Add a freeze protection against OpenGL" [Needs Review] https://phabricator.kde.org/D3132 KDE bug 371284 in kwin (general) "Kwin hinders brush cursor in krita making the window move while painting" [grave,] https://bugs.kde.org/show_bug.cgi? id=371284 Note: once we use Wayland by default every crash fix in KWayland::Server must get a security advisory in case the crash can be hit from the client Updated Plasma on Wayland TODO board (https://todo.kde.org/? controller=board&action=show&project_id=2 ) And something for discussion Krita disables breeze and switches to fusion. Apparently there are issues, but they are not reported. I don't like workarounds and want the issues to be fixes. Should we override this again in Plasma/5.9 and communicate this to Krita, so that the issues get fixed? We only need to export: KRITA_NO_STYLE_OVERRIDE=1 Alternative would be to really, really override in QPT plugin in ways that Krita cannot hack around by setting a different env variable. romangg: * committed my patch for small qml lockscreen improvements: https:// phabricator.kde.org/D3055 Diff 3055 "Small polishing changes to the lockscreen lookandfeel package" [Closed] https://phabricator.kde.org/D3055 * committed other patch, which makes the launchers close on meta again: https://git.reviewboard.kde.org/r/129204/ https://phabricator.kde.org/D3079 Diff 3079 "Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change" [Closed] https:// phabricator.kde.org/D3079 * looked into the touchpad kcm... -> next task was thinking, what else needs to be done for wayland working as a daily driver... (no crash on logout,... ) for discussion :P bshah: - mainly work on initial boot for plasma mobile - had excellent idea on how to remove need for lxc - doesn't seem to work as it should, investigating Sho: * Worked on widget gallery in App Dash, planning to submit for initial review this week * Yakuake rewrite work d_ed: * I've been doing some SDDM w
[Differential] [Closed] D3102: Do not ask for root permissions when it's unnecessary
antlarr closed this revision. REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3102 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #plasma, davidedmundson Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Jenkins-kde-ci: khotkeys master kf5-qt5 » Linux,gcc - Build # 22 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 24 Oct 2016 09:37:08 + Build duration: 2 min 54 sec CHANGE SET Revision 9eff3e61bb364af5e2dedae298b15fda71bc91f9 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit app/khotkeys.desktop
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #5 from Harald Sitter --- Well, if that is the case then I guess you should be filing a bug with GRUB, not the theme? -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370374] GRUB menu has huge lag due to theme
https://bugs.kde.org/show_bug.cgi?id=370374 Roman changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |UNCONFIRMED --- Comment #4 from Roman --- Status changed back to UNCONFIRMED, since infos have been given. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370981] Can't enter LUKS password
https://bugs.kde.org/show_bug.cgi?id=370981 Viorel-Cătălin Răpițeanu changed: What|Removed |Added CC||rapiteanu.cata...@gmail.com --- Comment #3 from Viorel-Cătălin Răpițeanu --- I'm also experiencing this problem. As a related note, this bug is a clone of Bug 367818 - Password textfield is not visible when using dm-crypt -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370981] Can't enter LUKS password
https://bugs.kde.org/show_bug.cgi?id=370981 Harald Sitter changed: What|Removed |Added Resolution|--- |DOWNSTREAM Status|UNCONFIRMED |RESOLVED --- Comment #2 from Harald Sitter --- Please get in touch with your distribution, this is an integration issue. Password queries are meant to go through a standardized system which is behaving correctly as per our test https://github.com/KDE/breeze-plymouth/blob/master/test/plytest.sh#L59 -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 370981] Can't enter LUKS password
https://bugs.kde.org/show_bug.cgi?id=370981 Martin Kyral changed: What|Removed |Added CC||sine.nom...@centrum.cz --- Comment #1 from Martin Kyral --- I am confirming the bug, experiencing it too. No need to hit [Esc], the password can be typed blindly. But yeah, from plain black screen one can not tell it it is waiting for the password or just hung. -- You are receiving this mail because: You are the assignee for the bug.
[Differential] [Request, 6 lines] D3150: [server] Fix crash on updating focused keyboard surface
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY In case the current selection does not have a DataSourceInterface updating the focused keyboard surface resulted in a crash. The current selection is sent to the DataDeviceInterface of the newly focused client and thus a DataOfferInterface would be created for a null DataSourceInterface. This is a similar fix as https://phabricator.kde.org/D3148 and https://phabricator.kde.org/D3149. TEST PLAN Test case added which used to crash before REPOSITORY rKWAYLAND KWayland BRANCH selection-ddi-keyboard-focus REVISION DETAIL https://phabricator.kde.org/D3150 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/seat_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 96 lines] D3149: [server] Fix possible crash on creation of DataDevice
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is a similar condition as https://phabricator.kde.org/D3148. If a DataDeviceInterface is created for the currently focused keyboard Surface the current selection is sent to the new DataDeviceInterface. If the current selection does not have a DataSourceInterface a DataOfferInterface for a null DataSourceInterface would be created and result in a crash. This change verifies that there is a DataSourcInterface on the current selection prior to sending out the selection. TEST PLAN A test case is added which simulates the condition by using two clients. REPOSITORY rKWAYLAND KWayland BRANCH selection-ddi-creation REVISION DETAIL https://phabricator.kde.org/D3149 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/seat_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 49 lines] D3148: [server] Ensure we have a DataSource on the DataDevice in setSelection
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY SeatInterface provides a way to set the current selection. This method did not verify whether the new DataDeviceInterface actually has a DataSourceInterface. If there is no DataSourceInterface on that DataDeviceInterface the selection should not be sent to the current selection owner. This results in a crash as DataOfferInterface (correctly) doesn't expect the passed in DataSourceInterface to be null. To ensure we don't hit this again the DataOfferInterface ctor gained an Q_ASSERT to validate the DataSourceInterface. REPOSITORY rKWAYLAND KWayland BRANCH set-selection-source REVISION DETAIL https://phabricator.kde.org/D3148 AFFECTED FILES autotests/client/test_wayland_seat.cpp src/server/dataoffer_interface.cpp src/server/seat_interface.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
graesslin added inline comments. INLINE COMMENTS > antlarr wrote in x11_platform.cpp:229-232 > Do you prefer to merge PostInit with PostFrame or with PostLastGuardedFrame? > The difference would be that if it's merged with PostFrame and a user sets > KWIN_MAX_FRAMES_TESTED to 0 (so no freeze detection is done when painting > frames) then the detection thread and timer wouldn't be deleted and if it's > merged with PostLastGuardedFrame, then a new thread and timer will be created > for the frame drawing. I would merge it with PostFrame, since it requires a > user who probably knows what he's doing to interact and is more optimized for > 99.% of cases, and still an idle thread and stopped timer shouldn't > consume any resources in the rare case a user sets that, but I ask just in > case. yep, agree. REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL
antlarr added inline comments. INLINE COMMENTS > graesslin wrote in composite.h:242 > I would just count down the m_maxFramesTestedForSafety till it reaches 0 ok > graesslin wrote in x11_platform.cpp:215 > You can use QMetaObject::invokeMethod with Qt::QueuedConnection. Oh, I thought QueuedConnection needed to get to the event loop to execute the slot method, but I just noticed it's the event loop **of the receiver object**, so it would be fine. I'll change that. > graesslin wrote in x11_platform.cpp:229-232 > I think you can merge the PostFrame with PostInit. So that the init test also > does the freeze testing. That would also solve the conceptual problem I > pointed out above. Do you prefer to merge PostInit with PostFrame or with PostLastGuardedFrame? The difference would be that if it's merged with PostFrame and a user sets KWIN_MAX_FRAMES_TESTED to 0 (so no freeze detection is done when painting frames) then the detection thread and timer wouldn't be deleted and if it's merged with PostLastGuardedFrame, then a new thread and timer will be created for the frame drawing. I would merge it with PostFrame, since it requires a user who probably knows what he's doing to interact and is more optimized for 99.% of cases, and still an idle thread and stopped timer shouldn't consume any resources in the rare case a user sets that, but I ask just in case. REVISION DETAIL https://phabricator.kde.org/D3132 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: antlarr, #kwin, #plasma, davidedmundson Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
