[Differential] [Updated] D3494: Set m_client size in global compositor co-ordinates

2016-12-01 Thread davidedmundson (David Edmundson) 
davidedmundson marked 2 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in scene_qpainter.cpp:311-313
> do you have a test case in another patch for this? If not I suggest to extend 
> the scene qpainter test to verify the rendering is correct with different 
> scaling

I put a test with the QPainter commit which implicitly will also test this 
change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3494

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 15 lines] D3494: Set m_client size in global compositor co-ordinates

2016-12-01 Thread davidedmundson (David Edmundson) 
davidedmundson updated this revision to Diff 8684.
davidedmundson retitled this revision from "Set m_client size in global 
compositor co-ordinates

KWin wants to deal with the post-scaled down client size, not the texture 
size." to "Set m_client size in global compositor co-ordinates".
davidedmundson updated the summary for this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Remove swapped lines

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3494?vs=8502=8684

REVISION DETAIL
  https://phabricator.kde.org/D3494

AFFECTED FILES
  scene_qpainter.cpp
  shell_client.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 56 lines] D3495: Scale QPainter x11 windowed backend

2016-12-01 Thread davidedmundson (David Edmundson) 
davidedmundson updated this revision to Diff 8683.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Add unit test

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3495?vs=8503=8683

REVISION DETAIL
  https://phabricator.kde.org/D3495

AFFECTED FILES
  autotests/integration/scene_qpainter_test.cpp
  plugins/platforms/x11/windowed/scene_qpainter_x11_backend.cpp
  plugins/platforms/x11/windowed/x11windowed_backend.cpp
  scene_qpainter.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, graesslin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 13 lines] D3562: [Task Manager] Create toolTipDelegate on demand

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ToolTipTelegate is quite complex and there's no point in loading it when 
tooltips are disabled.

TEST PLAN
  All the bindings still work and the highlight effect also excludes the 
tooltip just fine.
  
  Might improve startup time and reduced RAM consumption after plasmashell 
startup by ~5 MiB on dual monitor setup

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3562

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 506 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin) 
mart updated this revision to Diff 8680.
mart added a comment.


  - remove some redundant properties

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3561?vs=8679=8680

BRANCH
  phab/listviewrow

REVISION DETAIL
  https://phabricator.kde.org/D3561

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #kirigami
Cc: plasma-devel, apol

[Differential] [Updated, 502 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin) 
mart updated this revision to Diff 8679.
mart added a comment.


  - refactor delegate of ApplicationHeader

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3561?vs=8678=8679

BRANCH
  phab/listviewrow

REVISION DETAIL
  https://phabricator.kde.org/D3561

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #kirigami
Cc: plasma-devel, apol

[Differential] [Request, 294 lines] D3561: make the logic of PageRow a ListView

2016-12-01 Thread mart (Marco Martin) 
mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  it implements internally things like snapping and layouting
  makes the qml code significantly simpler
  it needs the columns stay the same size (as listview doesn't
  correctly supports items of eterogeneous sizes)

TEST PLAN
  tried the widget gallery on different styles, desktop and mobile

REPOSITORY
  R169 Kirigami

BRANCH
  phab/listviewrow

REVISION DETAIL
  https://phabricator.kde.org/D3561

AFFECTED FILES
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #kirigami
Cc: plasma-devel, apol

[Differential] [Request, 25 lines] D3560: [Notifications] Tighten layout

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Our notification popups are huge compared to other platforms, this tightens 
and streamlines the layout a bit.
  
  The button sizes are much more dynamic now, allowing them to become smaller 
but also significantly wider. It always bothered me how, at least in German 
locale, most of the action buttons are elided.

TEST PLAN
  F557954: tighternoti.png 
  Left is old, right is new
  
  The spectacle icon in the notification is also somewhat redundant now that we 
have previews.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3560

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 7 lines] D3559: [Notification Popup] Clear notification data after popup closed

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There's no point in keeping around the notification data until it is replaced 
by a new one.

TEST PLAN
  Verified that e.g. the thumbnail strip is destroyed when the popup closes. 
Also keeps it from doing stupid things (like requesting new thumbnails while 
closing) etc.
  
  Might also reduce teh likeliehood of layout glitches when we always start 
with a "fresh" notification content rather than some old actions and what not 
hanging around. Layouts are quite fragile...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3559

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/notificationshelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

2016-12-01 Thread broulik (Kai Uwe Broulik) 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b34601f0ef1a: [Lock Screen] Add keyboard icon for 
keyboard layout switcher (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3549?vs=8638=8675

REVISION DETAIL
  https://phabricator.kde.org/D3549

AFFECTED FILES
  lookandfeel/contents/components/KeyboardLayoutButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 4 lines] D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2016-12-01 Thread jbraun (Jan-Matthias Braun) 
jbraun removed R104 KScreen as the repository for this revision.
jbraun updated this revision to Diff 8674.
jbraun added a comment.


  Of course, that's easily done. :-)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3552?vs=8646=8674

REVISION DETAIL
  https://phabricator.kde.org/D3552

AFFECTED FILES
  b/console/console.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jbraun, sebas
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

2016-12-01 Thread Raman Gupta 
https://bugs.kde.org/show_bug.cgi?id=357288

Raman Gupta  changed:

   What|Removed |Added

Version|5.7.3   |5.8.4

--- Comment #9 from Raman Gupta  ---
Still the same issue on Plasma 5.8.4, QT 5.6.2 (Fedora 24).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread broulik (Kai Uwe Broulik) 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f78c98068a34: [Notifications] Default initialize 
notificationProperties as empty object (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3557?vs=8665=8673

REVISION DETAIL
  https://phabricator.kde.org/D3557

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3558: Make properties readonly when possible

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:463660b4aadc: Make properties readonly when possible 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3558?vs=8671=8672

REVISION DETAIL
  https://phabricator.kde.org/D3558

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Accepted] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3557

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3558: Make properties readonly when possible

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3558

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 4 lines] D3558: Make properties readonly when possible

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3558

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Closed] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:aabcb7b0d6e1: Drop resize animation when adding pages 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3538?vs=8668=8670

REVISION DETAIL
  https://phabricator.kde.org/D3538

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Requested Changes To] D3552: Remove quoting from kscreen-console json-output (Bug 354534)

2016-12-01 Thread Sebastian Kügler 
sebas requested changes to this revision.
sebas added a comment.
This revision now requires changes to proceed.


  Idea in general looks good, I'd rather use QTextStream than std though. Can 
you change that?

INLINE COMMENTS

> console.cpp:185
>  QJsonDocument doc(KScreen::ConfigSerializer::serializeConfig(m_config));
> -qDebug() << doc.toJson(QJsonDocument::Indented);
> +std::cout << doc.toJson(QJsonDocument::Indented).toStdString();
>  }

In other tools, we use QTextStream for the output, I'd prefer that. See 
libkscreen/src/doctor.cpp for an example.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D3552

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jbraun, sebas
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
apol marked an inline comment as done.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Accepted] D3538: Drop resize animation when adding pages

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3538

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Updated, 29 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 8668.
apol added a comment.


  Fix patch

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3538?vs=8667=8668

BRANCH
  mart/Kirigami2

REVISION DETAIL
  https://phabricator.kde.org/D3538

AFFECTED FILES
  src/controls/templates/private/PageRow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Updated, 3,549 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 8667.
apol added a comment.


  Fix patch

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3538?vs=8666=8667

REVISION DETAIL
  https://phabricator.kde.org/D3538

AFFECTED FILES
  CMakeLists.txt
  KF5Kirigami2Config.cmake.in
  KF5Kirigami2Macros.cmake
  KF5KirigamiConfig.cmake.in
  KF5KirigamiMacros.cmake
  Mainpage.dox
  autotests/CMakeLists.txt
  autotests/tst_pagerow.qml
  examples/CMakeLists.txt
  examples/android/AndroidManifest.xml
  examples/android/CMakeLists.txt
  examples/android/main.cpp
  examples/android/qtquickcontrols2.conf
  examples/android/resources.qrc
  examples/gallery/contents/ui/DesktopExampleApp.qml
  examples/gallery/contents/ui/ExampleApp.qml
  examples/gallery/contents/ui/MainPage.qml
  examples/gallery/contents/ui/gallery/ButtonGallery.qml
  examples/gallery/contents/ui/gallery/CheckBoxGallery.qml
  examples/gallery/contents/ui/gallery/ColorsGallery.qml
  examples/gallery/contents/ui/gallery/ListViewGallery.qml
  examples/gallery/contents/ui/gallery/MiscGallery.qml
  examples/gallery/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/gallery/contents/ui/gallery/NonScrollableGallery.qml
  examples/gallery/contents/ui/gallery/ProgressBarGallery.qml
  examples/gallery/contents/ui/gallery/RadioButtonGallery.qml
  examples/gallery/contents/ui/gallery/SliderGallery.qml
  examples/gallery/contents/ui/gallery/SwitchGallery.qml
  examples/gallery/contents/ui/gallery/TabBarGallery.qml
  examples/gallery/contents/ui/gallery/TextFieldGallery.qml
  examples/gallery/metadata.desktop
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/SplitDrawer.qml
  examples/simpleexamples/TabBarHeader.qml
  examples/simpleexamples/customdrawer.qml
  examples/simpleexamples/minimal.qml
  scripts/gen_qmltypes.sh
  src/CMakeLists.txt
  src/controls/AbstractApplicationHeader.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/ApplicationWindow.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Icon.qml
  src/controls/Label.qml
  src/controls/OverlayDrawer.qml
  src/controls/OverlaySheet.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Separator.qml
  src/controls/SplitDrawer.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/ActionButton.qml
  src/controls/private/CornerShadow.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/private/EdgeShadow.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/SwipeItemEventFilter.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SplitDrawer.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/AbstractDrawer.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PageRow.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Desktop/AbstractApplicationHeader.qml
  src/styles/Desktop/AbstractListItem.qml
  src/styles/Desktop/ApplicationWindow.qml
  src/styles/Desktop/OverlayDrawer.qml
  src/styles/Desktop/SwipeListItem.qml
  src/styles/Material/AbstractListItem.qml
  src/styles/Material/SwipeListItem.qml
  src/styles/Material/Theme.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Updated, 3,388 lines] D3538: Drop resize animation when adding pages

2016-12-01 Thread apol (Aleix Pol Gonzalez) 
apol updated this revision to Diff 8666.
apol added a comment.


  Remove Timer

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3538?vs=8604=8666

BRANCH
  arcpatch-D3538

REVISION DETAIL
  https://phabricator.kde.org/D3538

AFFECTED FILES
  CMakeLists.txt
  KF5KirigamiMacros.cmake
  Mainpage.dox
  examples/CMakeLists.txt
  examples/android/AndroidManifest.xml
  examples/android/CMakeLists.txt
  examples/android/main.cpp
  examples/android/qtquickcontrols2.conf
  examples/android/resources.qrc
  examples/gallery/contents/ui/DesktopExampleApp.qml
  examples/gallery/contents/ui/ExampleApp.qml
  examples/gallery/contents/ui/MainPage.qml
  examples/gallery/contents/ui/gallery/ButtonGallery.qml
  examples/gallery/contents/ui/gallery/CheckBoxGallery.qml
  examples/gallery/contents/ui/gallery/ColorsGallery.qml
  examples/gallery/contents/ui/gallery/ListViewGallery.qml
  examples/gallery/contents/ui/gallery/MiscGallery.qml
  examples/gallery/contents/ui/gallery/MultipleColumnsGallery.qml
  examples/gallery/contents/ui/gallery/NonScrollableGallery.qml
  examples/gallery/contents/ui/gallery/ProgressBarGallery.qml
  examples/gallery/contents/ui/gallery/RadioButtonGallery.qml
  examples/gallery/contents/ui/gallery/SliderGallery.qml
  examples/gallery/contents/ui/gallery/SwitchGallery.qml
  examples/gallery/contents/ui/gallery/TabBarGallery.qml
  examples/gallery/contents/ui/gallery/TextFieldGallery.qml
  examples/gallery/metadata.desktop
  examples/simpleexamples/AbstractApplicationWindow.qml
  examples/simpleexamples/FixedSidebar.qml
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/SplitDrawer.qml
  examples/simpleexamples/TabBarHeader.qml
  examples/simpleexamples/customdrawer.qml
  examples/simpleexamples/minimal.qml
  scripts/gen_qmltypes.sh
  src/CMakeLists.txt
  src/controls/AbstractApplicationHeader.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/ApplicationWindow.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Icon.qml
  src/controls/Label.qml
  src/controls/OverlayDrawer.qml
  src/controls/OverlaySheet.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Separator.qml
  src/controls/SplitDrawer.qml
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/ActionButton.qml
  src/controls/private/CornerShadow.qml
  src/controls/private/DefaultListItemBackground.qml
  src/controls/private/EdgeShadow.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/private/SwipeItemEventFilter.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml
  src/controls/templates/SplitDrawer.qml
  src/controls/templates/SwipeListItem.qml
  src/controls/templates/private/AbstractDrawer.qml
  src/controls/templates/private/BackButton.qml
  src/controls/templates/private/ContextIcon.qml
  src/controls/templates/private/MenuIcon.qml
  src/controls/templates/private/PageRow.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/qmldir
  src/styles/Desktop/AbstractApplicationHeader.qml
  src/styles/Desktop/AbstractListItem.qml
  src/styles/Desktop/ApplicationWindow.qml
  src/styles/Desktop/OverlayDrawer.qml
  src/styles/Desktop/SwipeListItem.qml
  src/styles/Material/AbstractListItem.qml
  src/styles/Material/SwipeListItem.qml
  src/styles/Material/Theme.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: jensreuterberg, colomar, plasma-devel, apol

[Differential] [Request, 15 lines] D3557: [Notifications] Default initialize notificationProperties as empty object

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Avoids accessing the object twice for every property and improves readability.

TEST PLAN
  Notification title, text, icon still work. Configure button also shows up 
properly and so do the thumbnails. No (additional) warnings printed on console

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3557

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129586: [KNotification] Allow annotating notifications with URLs

2016-12-01 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129586/
---

(Updated Dec. 1, 2016, 12:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 0092619e40b922e3c551fc26d225fa1635dd441f by Kai Uwe 
Broulik to branch master.


Repository: knotifications


Description
---

This will allow the notification server to show thumbnails or provide 
additional options (like Sharing or drag and drop) for the given URLs, for 
example when a screenshot was taken or a file was received from a contact.


Diffs
-

  src/knotification.h 649b233 
  src/knotification.cpp b14fa44 
  src/notifybypopup.cpp fe948ce 

Diff: https://git.reviewboard.kde.org/r/129586/diff/


Testing
---


File Attachments


Screenshot_20161129_173410.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/0c01d85e-cae3-4abc-9c79-fb95ee067de5__Screenshot_20161129_173410.png


Thanks,

Kai Uwe Broulik

[Differential] [Closed] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik) 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3c1679ba6468: [Notifications] Show interactive thumbnails 
on notifications (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3539?vs=8663=8664#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3539?vs=8663=8664

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3553: Fix 2 RTL bugs

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3553

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ttv20, #plasma_workspaces, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3549

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 446 lines] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik updated this revision to Diff 8663.
broulik added a comment.


  - "Expire" notification when clicking a URL
  
  This will cause the popup to close properly (previous patch would just hide 
the window but not "free" the dialog) but it will be kept in the history if it 
is a persistent notification

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3539?vs=8662=8663

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Review Request 129586: [KNotification] Allow annotating notifications with URLs

2016-12-01 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129586/#review101193
---


Ship it!




Ship It!

- Marco Martin


On Nov. 29, 2016, 4:42 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129586/
> ---
> 
> (Updated Nov. 29, 2016, 4:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> This will allow the notification server to show thumbnails or provide 
> additional options (like Sharing or drag and drop) for the given URLs, for 
> example when a screenshot was taken or a file was received from a contact.
> 
> 
> Diffs
> -
> 
>   src/knotification.h 649b233 
>   src/knotification.cpp b14fa44 
>   src/notifybypopup.cpp fe948ce 
> 
> Diff: https://git.reviewboard.kde.org/r/129586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot_20161129_173410.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/29/0c01d85e-cae3-4abc-9c79-fb95ee067de5__Screenshot_20161129_173410.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

[Differential] [Updated, 444 lines] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik updated the test plan for this revision.
broulik updated this revision to Diff 8662.
broulik added a comment.


  - Put thumbnail strip behind a Loader
  - Make clicking the thumbnails actually work (horrible hack because of the 
MouseEventListener we have in the popup)
  - Make thumbnails in the notification history work

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3539?vs=8625=8662

REVISION DETAIL
  https://phabricator.kde.org/D3539

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/ThumbnailStrip.qml
  applets/notifications/plugin/CMakeLists.txt
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/thumbnailer.cpp
  applets/notifications/plugin/thumbnailer.h
  dataengines/notifications/notificationsengine.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3539: [Notifications] Show interactive thumbnails on notifications

2016-12-01 Thread broulik (Kai Uwe Broulik) 
broulik marked an inline comment as done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3539

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Request to port plasma for zenfone 2 laser.

2016-12-01 Thread sunil polavarapu 
First of all congratulations to all of your team, You have  made a another
platform called plasma mobile which is based on linux..feeling it's going
to become very popular in future like Android  OS . So i'm requesting your
team to port this plasma mobile to Zenfone 2 laser variants and hope you
people include this device in your list.
Thank you.

How to run plasma mobile

2016-12-01 Thread Andy B 
Hey team,

I wanted to know what I need to do in order to run plasma mobile using
virtualbox. I run it but I get a black screen using the latest x86 image.

Thank you,