[Differential] [Request, 4 lines] D3847: SWT/Eclipse toolbar fix

[jsalatas (John Salatas)]

jsalatas created this revision.
jsalatas added a reviewer: Breeze.
jsalatas set the repository for this revision to R98 Breeze for Gtk.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In eclipse running with  SWT gtk2 the buttons in the toolbar don't behave as 
they should:
  
  1. There is no highlighting when hovering
  2. For toggle buttons there is no active/inactive indication.

TEST PLAN
  Tested in KDE Neon User as of December, 28th
  
  Before
  F1588340: before.png 
  
  After 
  F1588341: after.png 
  
  Besides these two issues the patch seems to (unintentionally) improve some 
real-estates (see for example secondary toolbar buttons in Package Explorer and 
Outline views).

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D3847

AFFECTED FILES
  Breeze-dark-gtk/gtk-2.0/widgets/styles
  Breeze-gtk/gtk-2.0/widgets/styles

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #breeze
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote:
  
  > In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
  >
  > > Could you explain the relationship to global shortcuts? That sounds to me 
like a bug which needs to be fixed in kglobalaccel
  >
  >
  > I don't really sure about this. So basically XlibNotifications uses 
XISelectEvent to monitor certain event. And strangely, the event is not 
received only if it is triggered by global hotkey.
  
  
  Which "event"?
  
  > The Display* used in touchpad kded is already a separated one instead of 
Qt's, so I don't know if there's any interference between them. If someone 
could highlight me about what is the real cause of this I'd appreciated it.
  
  This sounds weird and wrong to me. In none of the applications we use, even 
in the heavily X relying one like KWin or kglobalaccel, we create another 
Display, but use the one Qt provides. From my experience there is no need to 
have a dedicate Display. It can certainly be a source for issues.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3822: use a native event filter to notice the screen was swapped

[pmuralidharan (PrasannaKumar Muralidharan)]

pmuralidharan added inline comments.

INLINE COMMENTS

> screenpool.cpp:203
> +}
> +
> +

Wondering whether returning false always is correct. It feels wrong but I may 
be missing something.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3822

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson, sebas
Cc: pmuralidharan, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 502 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/502/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 29 Dec 2016 00:23:22 +
Build duration: 7 min 28 sec

CHANGE SET
Revision de56e25395ac8835d578d027cf2aac84e78f8a6c by aleixpol: (Fix issues 
pointed out by Kai)
  change: edit applets/kicker/plugin/appentry.cpp

Re: Review Request 129716: Improve installation process of KPackage bundles

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/
---

(Updated Dec. 29, 2016, 12:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit e6d72cb9df6f55b3f463a5acfcad6a7bafe4bd81 by Aleix Pol to 
branch master.


Repository: kpackage


Description
---

When parsing the desktop files, pass together the kpackage-generic.desktop 
service type, so that the parser knows its intrinsic types (most especially 
`X-KPackage-Dependencies` which is in fact added now). This is important 
because otherwise we get warnings when we extract the value when the package is 
a desktop file.

This would be much less of a problem if desktop service types could be 
extended, but it's not the case at the moment.


Diffs
-

  src/kpackage/data/servicetypes/kpackage-generic.desktop 879d3b2 
  src/kpackage/package.cpp c032e6e 
  src/kpackage/private/packagejobthread.cpp 8697341 

Diff: https://git.reviewboard.kde.org/r/129716/diff/


Testing
---

Managed to install llukas's example.


Thanks,

Aleix Pol Gonzalez

Re: Review Request 129697: Figure out software center integration on the menus

[Aleix Pol Gonzalez]

> On Dec. 29, 2016, 12:38 a.m., Kai Uwe Broulik wrote:
> > Sorry for being late to the party, I just saw this now. (I'm all on phab 
> > now)
> > 
> > I think this entry should only be shown when plasmoid.immutability is 
> > SystemImmutable. Yes, system administrator would probably disallow 
> > uninstalling apps (needs root already anway) but we also hide the "Edit 
> > application" entry in this case.

Possibly, it just opens plasma-discover though, so the user can also call it 
himself.


> On Dec. 29, 2016, 12:38 a.m., Kai Uwe Broulik wrote:
> > CMakeLists.txt, line 66
> > 
> >
> > I don't have 0.10.4 on neon dev unstable, just 0.10.3

I'm almost sure that's not the case. Otherwise master wouldn't have compiled 
for months...
FWIW, last version is 0.10.5.


> On Dec. 29, 2016, 12:38 a.m., Kai Uwe Broulik wrote:
> > applets/kicker/package/contents/config/main.xml, line 74
> > 
> >
> > This key is also present in kickerdash (kdeplasma-addons) iirc

Can't find it...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/#review101633
---


On Dec. 28, 2016, 12:21 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129697/
> ---
> 
> (Updated Dec. 28, 2016, 12:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> So far we had a (commented out) entry that was called `Remove  package>` that would open the configured application.
> 
> * Instead of looking up the service files in PackageKit, it does so on 
> AppStream, allowing for a faster and sync approach.
> * Renames the action to `Open `.
> * Uses `appstream://` URI scheme, allowing for the system to decide which 
> application handles it rather than an awkward configuration entry.
> * Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt 
> dependency instead.
> 
> This also means that applications coming from other sources than the 
> packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, 
> as long as it's supported by the package manager.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 90aaa03e 
>   applets/kicker/CMakeLists.txt 2e112e42 
>   applets/kicker/package/contents/config/main.xml bfd0d2db 
>   applets/kicker/plugin/appentry.cpp 5efdb0d0 
>   applets/kicker/plugin/findpackagenamejob.h 9905182c 
>   applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
>   applets/kickoff/package/contents/config/main.xml d7c51624 
>   config-workspace.h.cmake d0b48b94 
> 
> Diff: https://git.reviewboard.kde.org/r/129697/diff/
> 
> 
> Testing
> ---
> 
> Manual testing, opened few applications, all worked fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129697: Figure out software center integration on the menus

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/#review101633
---



Sorry for being late to the party, I just saw this now. (I'm all on phab now)

I think this entry should only be shown when plasmoid.immutability is 
SystemImmutable. Yes, system administrator would probably disallow uninstalling 
apps (needs root already anway) but we also hide the "Edit application" entry 
in this case.


CMakeLists.txt (line 66)


I don't have 0.10.4 on neon dev unstable, just 0.10.3



applets/kicker/package/contents/config/main.xml 


This key is also present in kickerdash (kdeplasma-addons) iirc



applets/kicker/plugin/appentry.cpp (line 147)


Braces



applets/kicker/plugin/appentry.cpp (line 151)


Join with QLatin1String, you lose the advantage of compile-time generated 
QStringLiteral when concatenating; also const &?



applets/kicker/plugin/appentry.cpp (line 156)


QStringLiteral



applets/kicker/plugin/appentry.cpp (line 200)


Braces


- Kai Uwe Broulik


On Dez. 28, 2016, 11:21 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129697/
> ---
> 
> (Updated Dez. 28, 2016, 11:21 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> So far we had a (commented out) entry that was called `Remove  package>` that would open the configured application.
> 
> * Instead of looking up the service files in PackageKit, it does so on 
> AppStream, allowing for a faster and sync approach.
> * Renames the action to `Open `.
> * Uses `appstream://` URI scheme, allowing for the system to decide which 
> application handles it rather than an awkward configuration entry.
> * Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt 
> dependency instead.
> 
> This also means that applications coming from other sources than the 
> packaging system (i.e. Snappy, Flatpak or AppImage) would also be supported, 
> as long as it's supported by the package manager.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 90aaa03e 
>   applets/kicker/CMakeLists.txt 2e112e42 
>   applets/kicker/package/contents/config/main.xml bfd0d2db 
>   applets/kicker/plugin/appentry.cpp 5efdb0d0 
>   applets/kicker/plugin/findpackagenamejob.h 9905182c 
>   applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
>   applets/kickoff/package/contents/config/main.xml d7c51624 
>   config-workspace.h.cmake d0b48b94 
> 
> Diff: https://git.reviewboard.kde.org/r/129697/diff/
> 
> 
> Testing
> ---
> 
> Manual testing, opened few applications, all worked fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

FYI: New calendar project (uses C++14 and C++17).

[Mark Gaiser]

Hi,

I saw some commits from Kai to enhance the calendar code (both C++ and
QML), apparently for performance reasons. It's great to see people
interested in performance optimizations ;)

Some weeks ago i was watching cppcon videos. One video [1] got me
interested in playing with constructing a calendar in code and trying to
use as little code as possible. Just as an exercise to play with C++14 and
C++17 features. I was considering the ranges library, but that seemed
overkill to me so i kept myself to C++ 14, 17 and some custom iterators
from cppitertools [2].

Now i have a small* application [3] that calculates which days are in a
given month along with an offset at the beginning of the month (empty
cells). There are no empty cells to fill to 42 days (a common number of
days to display in a calendar).

The code itself (as it is now) is useless for you folks. It just prints a
whole year in months on the console and that's about it. But it is highly
performant! You can make it very useful by building a new
(QAbstractItemModel derived) model around it. That would basically be a
replacement for DaysModel and a cleanup for the Calendar class (updateData
specifically).

Looking back at the DaysModel that is still being used in the current
calendar. hehe, ohh boy.. I would certainly handle things differently if i
were to make it again. For instance, the concept of DaysModel seemed sound
when i made it, now it seems flawed. Why would anyone make a DaysModel with
"DayData" objects and in there have the day, month and year stored as ints.
Yeah... Go figure why i did that, i even don't know it anymore. If i were
to do that again i would make a "MonthModel" with a fixed rowcount of 42
and deduce every day in there by the column value in the QModelIndex. The
model itself only needs to know the month and year upon model construction
(and when changing months), it doesn't even need to remember
it. Calendar::updateData would be heavily simplified as well ;)

Have a look at [3] and feel free to use it however you like it.
You can make it work under C++14 if you replace the structured binding
usage.

Cheers,
Mark

[1] https://www.youtube.com/watch?v=mFUXNMfaciE
[2] https://github.com/ryanhaining/cppitertools
[3] https://github.com/markg85/cansole_calendar
* = small if you don't count the added files from cppitertools.

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71724, @knambiar wrote:
  
  > Might this change fix this issue? 
https://bugs.kde.org/show_bug.cgi?id=370588
  
  
  Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to 
confirm it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[xuetianweng (Xuetian Weng)]

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#71714, @graesslin wrote:
  
  > Could you explain the relationship to global shortcuts? That sounds to me 
like a bug which needs to be fixed in kglobalaccel
  
  
  I don't really sure about this. So basically XlibNotifications uses 
XISelectEvent to monitor certain event. And strangely, the event is not 
received only if it is triggered by global hotkey. The Display* used in 
touchpad kded is already a separated one instead of Qt's, so I don't know if 
there's any interference between them. If someone could highlight me about what 
is the real cause of this I'd appreciated it.
  
  My guess is that it could be caused by mix Xinput call on the same display 
and there's some interference.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[frameworks-kcmutils] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=366299

Sebastian Kügler  changed:

   What|Removed |Added

  Component|general |general
 CC||se...@kde.org
Version|5.7.2   |5.29.0
   Assignee|plasma-devel@kde.org|kdelibs-b...@kde.org
Product|Powerdevil  |frameworks-kcmutils

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Selecting a Plasma logo

[Sebastian Kügler]

On Thursday, December 22, 2016 11:42:44 AM UTC Marco Martin wrote:
> On Thursday 22 December 2016 09:10:11 Sebastian Kügler wrote:
> > Go for it. And then let's talk where else we have to change things to
> > streamline our branding.
> > 
> > I'm glad we have reached a consensus.
> 
> done, the most visible places use the plasma logo now

Thank you! :)
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org

[Differential] [Commented On] D3832: import kwin deco and button order in l

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3832#71865, @mart wrote:
  
  > In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
  >
  > > I don't think the buttons should be set by a lnf package.
  >
  >
  > the user request was to make possible the l themes to emulate a different 
os (that is actually part of the design reason of l themes) in which button 
order becomes part of the target look
  
  
  the button order is global and not per theme. Given that I think it is wrong 
to change the global button order when changing theme. IIRC the deco can 
override it anyway, so not needed here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3833: export kwin theme to l

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> mart wrote in lnflogic.cpp:163
> would empty string make it use the default?

no, empty string would result in no  buttons at all.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D3833

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Re: Review Request 129716: Improve installation process of KPackage bundles

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/#review101629
---


Ship it!




Ship It!

- Marco Martin


On Dec. 28, 2016, 4:33 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129716/
> ---
> 
> (Updated Dec. 28, 2016, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> When parsing the desktop files, pass together the kpackage-generic.desktop 
> service type, so that the parser knows its intrinsic types (most especially 
> `X-KPackage-Dependencies` which is in fact added now). This is important 
> because otherwise we get warnings when we extract the value when the package 
> is a desktop file.
> 
> This would be much less of a problem if desktop service types could be 
> extended, but it's not the case at the moment.
> 
> 
> Diffs
> -
> 
>   src/kpackage/data/servicetypes/kpackage-generic.desktop 879d3b2 
>   src/kpackage/package.cpp c032e6e 
>   src/kpackage/private/packagejobthread.cpp 8697341 
> 
> Diff: https://git.reviewboard.kde.org/r/129716/diff/
> 
> 
> Testing
> ---
> 
> Managed to install llukas's example.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Commented On] D3832: import kwin deco and button order in l

[Lucas (lucas lucas)]

Lucas added a comment.


  In https://phabricator.kde.org/D3832#71865, @mart wrote:
  
  > In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
  >
  > > I don't think the buttons should be set by a lnf package.
  >
  >
  > the user request was to make possible the l themes to emulate a different 
os (that is actually part of the design reason of l themes) in which button 
order becomes part of the target look
  
  
  To be more precise it was my request. The reason for plasma 5.9 I would like 
to upload to kde store a few look and feel packages, which are mimicking 
certain desktop environments/operating systems like seen in this video 
https://www.youtube.com/watch?v=G4InY_1UhTI  It would fit nicely with our 
upcoming Plasma 5.9 promo video etc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: Lucas, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Review Request 129716: Improve installation process of KPackage bundles

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/
---

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
---

When parsing the desktop files, pass together the kpackage-generic.desktop 
service type, so that the parser knows its intrinsic types (most especially 
`X-KPackage-Dependencies` which is in fact added now). This is important 
because otherwise we get warnings when we extract the value when the package is 
a desktop file.

This would be much less of a problem if desktop service types could be 
extended, but it's not the case at the moment.


Diffs
-

  src/kpackage/data/servicetypes/kpackage-generic.desktop 879d3b2 
  src/kpackage/package.cpp c032e6e 
  src/kpackage/private/packagejobthread.cpp 8697341 

Diff: https://git.reviewboard.kde.org/r/129716/diff/


Testing
---

Managed to install llukas's example.


Thanks,

Aleix Pol Gonzalez

[Differential] [Commented On] D3832: import kwin deco and button order in l

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3832#71855, @graesslin wrote:
  
  > I don't think the buttons should be set by a lnf package.
  
  
  the user request was to make possible the l themes to emulate a different 
os (that is actually part of the design reason of l themes) in which button 
order becomes part of the target look

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3833: export kwin theme to l

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in lnflogic.cpp:163
> like in the other request I don't like this being exported.

would empty string make it use the default?

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D3833

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D3833: export kwin theme to l

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> lnflogic.cpp:160
> +defaultsConfigGroup = KConfigGroup(, 
> "org.kde.kdecoration2");
> +defaultsConfigGroup.writeEntry("library", systemCG.readEntry("library", 
> QStringLiteral("org.kde.breeze")));
> +defaultsConfigGroup.writeEntry("theme", systemCG.readEntry("theme", 
> QString()));

this is not the default used by kwin. KWin determines the default based on the 
optional compile time dep on breeze

> lnflogic.cpp:163
> +
> +defaultsConfigGroup.writeEntry("ButtonsOnLeft", 
> systemCG.readEntry("ButtonsOnLeft", "MS"));
> +defaultsConfigGroup.writeEntry("ButtonsOnRight", 
> systemCG.readEntry("ButtonsOnRight", "HIAX"));

like in the other request I don't like this being exported.

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D3833

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 223 lines] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 9422.
broulik added a comment.


  - Limit number of places shown

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3815?vs=9370=9422

REVISION DETAIL
  https://phabricator.kde.org/D3815

AFFECTED FILES
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  containments/panel/contents/code/LayoutManager.js

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3832: import kwin deco and button order in l

[Martin Gräßlin]

graesslin added a comment.


  I don't think the buttons should be set by a lnf package.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D3834: [Panel Containment] Replace restore order logic by "algorithms"

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3834

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3839: Avoid using deprecated Qt code QAbstractItemModel::reset

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2e944d53a32f: Avoid using deprecated Qt code 
QAbstractItemModel::reset (authored by davidedmundson).

REPOSITORY
  R242 Plasma Frameworks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3839?vs=9420=9421

REVISION DETAIL
  https://phabricator.kde.org/D3839

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3839: Avoid using deprecated Qt code QAbstractItemModel::reset

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3839

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3837: [Calendar] Optimize Backend

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  > Unfortunately did not result in a noticeable speedup of first invocation
  
  You've said this in two requests now. Whare are you using to profile?

INLINE COMMENTS

> calendar.cpp:319-323
> +if (needsModelReset) {
> +m_daysModel->update(DaysModel::UpdateType::ModelReset);
> +} else {
> +m_daysModel->update(DaysModel::UpdateType::DataChanged);
> +}

We can simplify this:

if (needsModelReset) {

  daysModel->setSourceData(m_daysList)

} else {

  daysModel->update();

}

No need to change DaysModel (except maybe to remove the setSourceData) check.

...or create 42 items in the ctor.
...or set DaysModel::rowCount to always return 42 and this always call update()

Currently DaysModel has two update methods, one for changing the list, another 
for updates of the existing list.

This is exlicitly setting it to a list of 0 items, then adding a third way of 
updating to handle the list being actually initialised, and one of those 3 
things is clearly pointless.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3837

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 3 lines] D3839: Avoid using deprecated Qt code QAbstractItemModel::reset

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R242 Plasma Frameworks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3839

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  We could show up to 5 entries and then a "xx more Places" sub menu or an 
entry that expands to reveal the rest. However, this would massively complex 
things, as we then would need to track which items the user uses frequently and 
give priority to them, otherwise this quick access feature would be pointless.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3815

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, #plasma:_design
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 85 lines] D3838: [Calendar] Optimize day delegate

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Use a single global MouseArea and turn delegate into an Item
  - Use a single Rectangle for both "today" and "highlighted" state
  - Add font.pointSize: -1 workaround in the other labels to avoid runtime 
warnings

TEST PLAN
  - Hovering and selecting items still works, updates agenda as needed, also 
"has appointment" overlay still works
  - Switching between months updates the highlight - you can see a brief 
transition from gray to blue and then invisible when you move between the 
current month and others as the single Rectangle will transition from gray to 
blue in response to becoming "not today" and opacity 1 to 0 in response to 
being no longer selected, not too terrible, though.
  - Pinch to zoom still works
  - didn't notice stray highlight when closing popup with mouse still hovering
  
  Unfortunately did not result in a noticeable speedup of first invocation

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3838

AFFECTED FILES
  src/declarativeimports/calendar/qml/DayDelegate.qml
  src/declarativeimports/calendar/qml/DaysCalendar.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 65 lines] D3837: [Calendar] Optimize Backend

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Use QQmlParserStatus to avoid premature initialization
  - Requires the days model to signal a model reset as by the time the Repeater 
in QML read the model for the first time it's empty (avoids boolean trap in 
"update" method signature by using an enum ;)
  - Don't signal weeks"Model" changed if it didn't - emitting a changing 
variant list / json array will cause QML to destroy and re-create all delegates

TEST PLAN
  Calendar still seems to work. Week number column still works.
  
  Unfortunately did not result in a noticeable speedup of first invocation

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3837

AFFECTED FILES
  src/declarativeimports/calendar/calendar.cpp
  src/declarativeimports/calendar/calendar.h
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Breeze] [Bug 374255] New: Notes widget icons not visible depending on Notes background and Plasma Shell Dark/Light variant

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374255

Bug ID: 374255
   Summary: Notes widget icons not visible depending on Notes
background and Plasma Shell Dark/Light variant
   Product: Breeze
   Version: 5.8.5
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: rockonthemoo...@gmail.com
  Target Milestone: ---

I'm pretty sure this bug shouldn't be reported to Breeze - General, but I don't
know where it belongs.
Well, the problem is pretty easy: user cannot see icons in Note widget
depending on the background color of the widget itself and the Dark or Light
variant of Plasma Workspace theme.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D3835: [Calendar] Populate overview models on-demand

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3835

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 42 lines] D3835: [Calendar] Populate overview models on-demand

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We need to call updateYear/DecadeModel anyway, so let's just fill the model 
the first time this is called.

TEST PLAN
  Year and decade overview still work

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3835

AFFECTED FILES
  src/declarativeimports/calendar/qml/MonthView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 37 lines] D3834: [Panel Containment] Replace restore order logic by "algorithms"

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Replace the convoluted make an object with the order of applets by iterating 
them and then add them in order by a sort() and forEach().
  This makes the code much easier to follow.

TEST PLAN
  Verified that my applets are still added in the correct order. Also verified 
that applets not in the appletOrder are added at the end of the panel

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3834

AFFECTED FILES
  containments/panel/contents/code/LayoutManager.js

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3832: import kwin deco and button order in l

[mart (Marco Martin)]

mart updated the summary for this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3833: export kwin theme to l

[mart (Marco Martin)]

mart added a dependency: D3832: import kwin deco and button order in l

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D3833

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3832: import kwin deco and button order in l

[mart (Marco Martin)]

mart added a dependent revision: D3833: export kwin theme to l

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3832

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 11 lines] D3833: export kwin theme to l

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  export also kwin theme to look and feel themes
  including the button order
  tabbox and desktoip switcher are fixed to be taken from the
  proper groups

TEST PLAN
  created a customized lnf theme that is properly applied

REPOSITORY
  R118 Plasma SDK

BRANCH
  phab/kwintheme

REVISION DETAIL
  https://phabricator.kde.org/D3833

AFFECTED FILES
  lookandfeelexplorer/src/lnflogic.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 32 lines] D3832: import kwin deco and button order in l

[mart (Marco Martin)]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  support both button order and decoration theme
  of kwin when applying for a lnf theme. The deco
  theme is composed by library and theme entries.
  c++ themes will only use library, aurorae themes will use
  theme as well.

TEST PLAN
  created some lnf packages that customize this and applied

REPOSITORY
  R119 Plasma Desktop

BRANCH
  phab/kwinlnf

REVISION DETAIL
  https://phabricator.kde.org/D3832

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Kirigami2 issues on static libraries.

[Tomaz Canabrava]

On Tue, Dec 27, 2016 at 6:45 PM, Marco Martin  wrote:

> On Tuesday 27 December 2016, Tomaz Canabrava wrote:
> > Hello good people,
> >
> > I started to port Subsurface to kirigami2 and I found some issues that
> are
> > interesting.
> >
> > If I try to run subsurface while plasma is not running, it works,
> > if I try to run subsurface while plasma is running, it doesnt.
> >
> > It seems that we hit a issue by using kirigami as a Static library while
> > having the KDE library already loaded in memory.
> >
> > Full error:
> >
> > qrc:///qml/main.qml:9 plugin cannot be loaded for module
> > "org.kde.kirigami": Namespace 'org.kde.kirigami' has already been used
> for
> > type registration
>
> just a feeling...
> may be that it tries to *both* use the static library, but for some reason
> still tries to load the normal plugin again? (so, rerun a qqmlregistertype
> or
> the same types)
>

could be, but this raises issues:
If I create an app bundle that has kirigami, but the kirigami library is in
QT_LIBRARY_PATH, both will load.
how one can fix that?


> --
> Marco Martin
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 501 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/501/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:21:25 +
Build duration: 6 min 32 sec

CHANGE SET
Revision 27d71ef5f394f6a53aff3e022ae0145e09e89765 by aleixpol: (Figure out 
software center integration on the menus)
  change: edit applets/kicker/plugin/appentry.cpp
  change: edit CMakeLists.txt
  change: delete applets/kicker/plugin/findpackagenamejob.cpp
  change: edit applets/kickoff/package/contents/config/main.xml
  change: edit applets/kicker/CMakeLists.txt
  change: edit config-workspace.h.cmake
  change: edit applets/kicker/package/contents/config/main.xml
  change: delete applets/kicker/plugin/findpackagenamejob.h

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 96 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:05:48 +
Build duration: 6 min 24 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 
(84%)CONDITIONAL 32/52 (62%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Re: Review Request 129697: Figure out software center integration on the menus

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129697/
---

(Updated Dec. 28, 2016, 11:21 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 27d71ef5f394f6a53aff3e022ae0145e09e89765 by Aleix Pol to 
branch master.


Repository: plasma-desktop


Description
---

So far we had a (commented out) entry that was called `Remove ` that would open the configured application.

* Instead of looking up the service files in PackageKit, it does so on 
AppStream, allowing for a faster and sync approach.
* Renames the action to `Open `.
* Uses `appstream://` URI scheme, allowing for the system to decide which 
application handles it rather than an awkward configuration entry.
* Drops PackageKit-Qt opcional dependency, adds a required AppstreamQt 
dependency instead.

This also means that applications coming from other sources than the packaging 
system (i.e. Snappy, Flatpak or AppImage) would also be supported, as long as 
it's supported by the package manager.


Diffs
-

  CMakeLists.txt 90aaa03e 
  applets/kicker/CMakeLists.txt 2e112e42 
  applets/kicker/package/contents/config/main.xml bfd0d2db 
  applets/kicker/plugin/appentry.cpp 5efdb0d0 
  applets/kicker/plugin/findpackagenamejob.h 9905182c 
  applets/kicker/plugin/findpackagenamejob.cpp aa3fd549 
  applets/kickoff/package/contents/config/main.xml d7c51624 
  config-workspace.h.cmake d0b48b94 

Diff: https://git.reviewboard.kde.org/r/129697/diff/


Testing
---

Manual testing, opened few applications, all worked fine.


Thanks,

Aleix Pol Gonzalez

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 99 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 28 Dec 2016 11:04:23 +
Build duration: 1 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 
(84%)CONDITIONAL 32/52 (62%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

[Differential] [Accepted] D3828: [Plasma ScrollViewStyle] Show scroll bar background only on hover

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3828

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3823: [Lock Screen] Use QtRendering for Clock

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  I think it's correct.
  anyways, you don't need hinting when the font is so huge

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3823

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 89 lines] D3822: use a native event filter to notice the screen was swapped

[mart (Marco Martin)]

mart updated this revision to Diff 9409.
mart added a comment.


  - move in screenpool

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3822?vs=9385=9409

BRANCH
  phab/nativeeventfilt

REVISION DETAIL
  https://phabricator.kde.org/D3822

AFFECTED FILES
  CMakeLists.txt
  shell/CMakeLists.txt
  shell/autotests/CMakeLists.txt
  shell/desktopview.cpp
  shell/desktopview.h
  shell/screenpool.cpp
  shell/screenpool.h
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson, sebas
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3822#71673, @davidedmundson wrote:
  
  > Given the only member variable we use is m_screenPool-> shouldn't this just 
be in ScreenPool?
  >
  > Also I don't understand how this is works:
  >
  > qxcbconnection::handleXcbEvent
  >
  > calls ::filterNativeEvent
  >  before ::handleScreenChange
  >
  > which means this code is running before qGuiApp->primaryScreen has updated.
  
  
  the weird thing is that i'm getting a lot of screen change events, so that's 
probably why it works even if it's called in the wrong order.
  
  putting a bit of debug i get this:
  
  Name of current primary screen "eDP-1" stored name in screenpool "eDP-1"
  Name of current primary screen "eDP-1" stored name in screenpool "eDP-1"
  Name of current primary screen ":0.0" stored name in screenpool "eDP-1"
  Name of current primary screen "HDMI-1" stored name in screenpool ":0.0"
  Name of current primary screen "HDMI-1" stored name in screenpool "HDMI-1"
  
  can be seen going from the internal screen to the fake one, then from the 
fake one to the external one

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3822

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, sebas, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

[knambiar (Rajeesh K Nambiar)]

knambiar added a comment.


  Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas