Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 557 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/557/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 05:56:11 +
Build duration: 3 min 25 sec

CHANGE SET
Revision f5746ff9b77170b1945eae9d378c21baa123e48a by yurchor: (Fix loading of 
translation catalog (thanks to Victor)
  change: edit kcms/touchpad/src/CMakeLists.txt

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas added a comment.


  In https://phabricator.kde.org/D4153#77525, @jgrulich wrote:
  
  > I'm trying to get rid of Plasma QML components so it uses same colors which 
are used by the rest of application.
  
  
  I guess that would be a better approach as it seems that plasma and 
application themes don't always mix well.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4153: Network manager configuration model is unreadable

[Jan Grulich]

jgrulich added a comment.


  I decided to try a different approach before we try to find a color which 
fits to all combinations (plasma theme + application color). I'm trying to get 
rid of Plasma QML components so it uses same colors which are used by the rest 
of application.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 4 lines] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas updated this revision to Diff 10204.
jsalatas added a comment.


  Previous diff was incomplete.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4153?vs=10203=10204

REVISION DETAIL
  https://phabricator.kde.org/D4153

AFFECTED FILES
  kcm/qml/Dialog.qml
  kcm/qml/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas created this revision.
jsalatas added reviewers: Plasma, Plasma: Design, jgrulich.
jsalatas set the repository for this revision to R116 Plasma Network Management 
Applet.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It seems that for some application/plasma theme combinations (bug #374905) 
and also form 3rd party themes (bug #374976), the new network manager 
configuration model is unreadable.
  
  The attached seems to correctly handle all cases of Breeze and Breeze dark 
application/plasma theme combinations, however the result doesn't look (always) 
aesthetically pleasant. Is there a better way yo do it? :\

TEST PLAN
  Breeze dark application scheme, Breeze dark Plasma theme
  F2049636: dd.png 
  
  Breeze dark application scheme, Breeze light Plasma theme
  F2049637: dl.png 
  
  Breeze light application scheme, Breeze light Plasma theme
  F2049641: ll.png 
  
  Breeze light application scheme, Breeze dark Plasma theme
  F2049638: ld.png 

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

AFFECTED FILES
  kcm/qml/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 556 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/556/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 05:10:51 +
Build duration: 14 min

CHANGE SET
Revision c3971bb16e9680a0446831145422f2b4811bc579 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit kcms/colors/colorschemes.knsrc

Re: Plasma Sprint discussion planning

[Martin Gräßlin]

Am 2017-01-13 16:27, schrieb Marco Martin:

3. Maintaining X11 specific code:
Over the last half year exclusively on Wayland I realized that I 
cannot

maintain X11 specific code any more. KWin is mostly no problem as
XWayland windows are used the same way as native X windows. But things
which have a different implementation on Wayland I cannot maintain any
more. This affects mostly kglobalaccel, klipper and partly the
KWin-standalone platform. I want the team to think about plans how we
can continue to maintain the X11 specific parts especially with more 
of

the team (hopefully) moving to Wayland.


This is one of the most important things that have to be discussed at 
the

sprint, yes


Just giving an idea: Some parts where KWin is responsible for on 
Wayland, it could also become responsible on X11 and take over the part 
of whatever component provided it before. E.g. KWin could manage the 
keyboard layout on X11 as it has all the code for Wayland. The glue code 
on X11 would be rather minimal.


That's also what I want to focus on in KWin internally. My aim for 5.10 
is to replace more and more of the X11 specific code through the new 
implementations added for Wayland.


Cheers
Martin

[Differential] [Accepted] D4145: Fix calling KWindowSystem::windowType without fetching the type

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4145

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D4145: Fix calling KWindowSystem::windowType without fetching the type

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4145

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 6:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ivan Čukić and Martin Koller.


Changes
---

Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas 
Sturmlechner to branch master.


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 7:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Ivan Čukić and Martin Koller.


Changes
---

Submitted with commit b1243563fa2f5a07db6b8a26c966874bfd1c27dd by Andreas 
Sturmlechner to branch master.


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Ivan Čukić]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review102051
---


Ship it!




Ship It!

- Ivan Čukić


On Jan. 15, 2017, 1:12 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> ---
> 
> (Updated Jan. 15, 2017, 1:12 p.m.)
> 
> 
> Review request for Plasma, Ivan Čukić and Martin Koller.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> 2 commits:
> 
> - Make activities kioslave optional: Not everyone builds this for a Plasma 
> desktop, Qt5Sql is already only searched for in that subdirectory, so this 
> gives some nice modularity.
> - Make KF5Html dependency optional: only used by man
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 
> 
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

[Differential] [Request, 1 line] D4143: Follow theme in taskmanager tooltip media controls background

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently no colour is set, meaning it's defaulting to white. 
  On Breeze dark this gives white text/icons on a white background
  
  BUG: 375088

TEST PLAN
  Ran with breeze and breeze dark with a media player open

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4143

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 365100] Power button ignored

[Gordan Krešić]

https://bugs.kde.org/show_bug.cgi?id=365100

Gordan Krešić  changed:

   What|Removed |Added

Version|5.6.5   |5.8.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 123131: Port kio_man away from kdelibs4support

[Martin Koller]

> On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote:
> > man/kio_man.cpp, line 242
> > 
> >
> > Not correct, this returns only user configured list of languages, 
> > whereas it previously returned the full list.
> 
> Nick Shaforostoff wrote:
> please see 
> https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp
>  for the ways to get a list of all languages (there is a KDE-way and Qt-way)
> 
> Alex Richardson wrote:
> So if I parse this correctly the KDE way is: 
> `KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, 
> QStandardPaths::GenericDataLocation).groupList()`?
> Should there be something in KI18n or is this sufficiently rare that we 
> can just add "@deprecated use 
> `KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, 
> QStandardPaths::GenericDataLocation).groupList()` instead" to 
> KLocale::languageList()?
> 
> David Faure wrote:
> Sounds to me like it should be a method in ki18n, it's a bit too arcane 
> to be maintainable.
> 
> Alex Richardson wrote:
> Seems like it's not the right replacement:
> 
> No special env vars set:
> ```
> KLocale::global()->languageList()  ("de", "en_US")
> KLocalizedString::availableApplicationTranslations() = ("pt_BR", "nds", 
> "kk", "ga", "mr", "km", "ko", "en_US", "ca", "gl", "is", "it", "el", "nb", 
> "tr", "ro", "pl", "es", "et", "en_GB", "eu", "ja", "ru", "nl", "cs", "nn", 
> "pt", "ar", "ug", "hi", "lt", "da", "lv", "uk", "zh_CN", "zh_TW", "fi", "de", 
> "sk", "hr", "sl", "hu", "bg", "fr", "ca@valencia", "sv")
> QLocale().uiLanguages() = ("de-DE")
> KConfig(kf5_all_languages).groupsList() = ("ca@valencia", "ln", "de", 
> "tw", "lo", "ty", "lt", "lv", "ug", "uk", "pt_BR", "dz", "mg", "mh", "mi", 
> "ur", "mk", "ml", "mn", "mo", "uz", "mr", "ms", "mt", "el", "en", "crh", 
> "eo", "my", "be@latin", "es", "et", "eu", "vi", "na", "nb", "nd", "ne", "vo", 
> "ng", "fa", "nl", "nn", "csb", "nr", "fi", "fj", "sr@ijekavian", "nv", "wa", 
> "fo", "ny", "fr", "oc", "fy", "wo", "ga", "sr@latin", "hne", "om", "gd", 
> "or", "os", "gl", "uz@cyrillic", "gn", "gu", "xh", "gv", "zh_HK", "pa", 
> "nso", "pi", "ha", "pl", "he", "hi", "mai", "ps", "pt", "ho", "hr", "hu", 
> "yi", "hy", "hz", "yo", "ia", "id", "ie", "aa", "ik", "ab", "qu", "ae", "za", 
> "io", "af", "nds", "is", "ven", "it", "iu", "zh", "am", "ar", "as", "ja", 
> "sr@ijekavianlatin", "x-test", "ay", "zu", "az", "rn", "ro", "en_US", "ba", 
> "ru", "be", "rw", "bg", "bh", "bi", "jv", "bn", "sa", "bo", "sc", "sd", "br", 
> "se", "bs", "sg", "si", "ka", "sk", "sl", "zh_CN", "sm", "ast", "sn", "so", 
> "sq", "ki", "sr", 
 "bn_IN", "ca", "ss", "kk", "st", "kl", "su", "km", "sv", "kn", "ce", "sw", 
"ko", "ch", "ks", "rom", "ku", "kv", "kw", "ta", "co", "ky", "zh_TW", "te", 
"cs", "tg", "cu", "th", "cv", "ti", "hsb", "la", "lb", "tk", "cy", "tn", "to", 
"en_GB", "li", "tr", "da", "ts", "tt", "dsb")
> ```
> 
> With LANGUAGE="de_DE"
> 
> ```
> KLocale::global()->languageList()  ("de", "en_US")
> KLocalizedString::availableApplicationTranslations() = ("sv", "pt_BR", 
> "ca@valencia", "kk", "ga", "mr", "km", "ko", "en_US", "nds", "ca", "gl", 
> "is", "it", "el", "nb", "tr", "ro", "en_GB", "pl", "es", "et", "eu", "ja", 
> "ru", "nl", "cs", "nn", "pt", "ar", "ug", "hi", "lt", "da", "zh_CN", "zh_TW", 
> "lv", "uk", "fi", "de", "sk", "hr", "sl", "hu", "bg", "fr")
> QLocale().uiLanguages() = ("de-DE")
> KConfig(kf5_all_languages).groupsList() = (...)
> ```
> 
> With LANGUAGE="en_GB:de_DE"
> ```
> KLocale::global()->languageList()  ("en_GB", "de", "en_US")
> KLocalizedString::availableApplicationTranslations() = ("ga", "nds", 
> "kk", "mr", "km", "ko", "ca", "gl", "pt_BR", "is", "it", "el", "nb", "tr", 
> "ro", "en_US", "pl", "es", "et", "eu", "ja", "ru", "nl", "cs", "nn", "pt", 
> "ar", "en_GB", "ug", "hi", "lt", "da", "lv", "uk", "fi", "de", "sk", "hr", 
> "sl", "hu", "bg", "fr", "ca@valencia", "zh_CN", "zh_TW", "sv")
> QLocale().uiLanguages() = ("en-GB", "de-DE")
> ```
> 
> With LANGUAGE="de_DE:en_GB"
> ```
> KLocale::global()->languageList()  ("en_GB", "de", "en_US")
> KLocalizedString::availableApplicationTranslations() = ("mr", "km", "ko", 
> "nds", "en_GB", "ca", "gl", "is", "it", "el", "nb", "tr", "ro", "pl", "es", 
> "et", "eu", "ja", "ru", "nl", "cs", "nn", "zh_CN", "zh_TW", "pt", "ar", 
> "ca@valencia", "ug", "hi", "lt", "da", "lv", "uk", "fi", "de", "sk", "hr", 
> "sl", "hu", "bg", "pt_BR", "fr", "sv", "en_US", "ga", "kk")
> QLocale().uiLanguages() = ("de-DE", "en-GB")
> KConfig(kf5_all_languages).groupsList() = (...)
> ```
> This one is very confusing, why is en_GB still the highest priority 
> according to KLocale::global()->languageList()? Maybe it is reading some 
> config 

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[Martin Koller]

> On Jan. 15, 2017, 3:29 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 150
> > 
> >
> > I think we want:
> > 
> > connectedSources: sources()
> > 
> > 
> > otherwise if cores doesn't change we don't add all the other important 
> > sources.
> > 
> > Given libksysguard has a tonne of backends, and the main linux one has 
> > this guarded in _SC_NPROCESSORS_ONLN this seems it could happen.

No, what you suggest is what I tried first, but that gives a "property loop" 
warning.
I asked on KDE-devel ML how to solve this and Kevin Krammer suggested to solve 
it similar to this.

AFAI understood, the values are polled, so there is no need that anything 
changes.


> On Jan. 15, 2017, 3:29 p.m., David Edmundson wrote:
> > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml, line 258
> > 
> >
> > this doesn't match anything in the commit description.

This is the "and fix some warnings" part of the summary.
There were warnings like "can not use .value from undefined" or similar


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102043
---


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> ---
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
> http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the 
> tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102043
---



seems mostly fine.


applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 150)


I think we want:

connectedSources: sources()

otherwise if cores doesn't change we don't add all the other important 
sources.

Given libksysguard has a tonne of backends, and the main linux one has this 
guarded in _SC_NPROCESSORS_ONLN this seems it could happen.



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 258)


this doesn't match anything in the commit description.


- David Edmundson


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> ---
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
> http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the 
> tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[Martin Koller]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/
---

Review request for Plasma and Kåre Särs.


Bugs: 373776
http://bugs.kde.org/show_bug.cgi?id=373776


Repository: kdeplasma-addons


Description
---

See bug #373776
The CPU bars do not show a value when using separate bars per CPU, and the 
tooltip never
shows a value per CPU, since the data sources per CPU are not subscribed.

AFAICT this could never have worked.


Diffs
-

  applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 

Diff: https://git.reviewboard.kde.org/r/129838/diff/


Testing
---

yes


Thanks,

Martin Koller

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Martin Koller]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/#review102040
---


Ship it!




Ship It!

- Martin Koller


On Jan. 15, 2017, 1:12 p.m., Andreas Sturmlechner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129783/
> ---
> 
> (Updated Jan. 15, 2017, 1:12 p.m.)
> 
> 
> Review request for Plasma, Ivan Čukić and Martin Koller.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> 2 commits:
> 
> - Make activities kioslave optional: Not everyone builds this for a Plasma 
> desktop, Qt5Sql is already only searched for in that subdirectory, so this 
> gives some nice modularity.
> - Make KF5Html dependency optional: only used by man
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 
> 
> Diff: https://git.reviewboard.kde.org/r/129783/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

[Andreas Sturmlechner]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129783/
---

(Updated Jan. 15, 2017, 1:08 p.m.)


Review request for Plasma.


Changes
---

rebased and added info about KF5KHtml purpose


Repository: kio-extras


Description
---

2 commits:

- Make activities kioslave optional: Not everyone builds this for a Plasma 
desktop, Qt5Sql is already only searched for in that subdirectory, so this 
gives some nice modularity.
- Make KF5Html dependency optional: only used by man


Diffs (updated)
-

  CMakeLists.txt ba41101bb0cb247e55ded79224cd6bbbeb3f6b20 

Diff: https://git.reviewboard.kde.org/r/129783/diff/


Testing
---


Thanks,

Andreas Sturmlechner

[Breeze] [Bug 375005] New scrollbars for Plasma 4.9: slow/precise scrolling is no longer intuitive

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=375005

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #8 from Kai Uwe Broulik  ---
Can you please stop arguing about this. The design change happened in
conjunction with our usability team and you can still enable the arrows if you
want to.

Having them enabled by default clashes with the auto-hiding scroll bar
background as you then wouldn't be able to tell the scroll bar is all the way
at the top because there would be a gab where the arrows should be.

Also, such scroll bars are prevalent on all mobile platforms which are usually
used by more novice users than desktop computers are nowadays so you can't tell
me people wouldn't be able to recognize them as such.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 51 lines] D4140: Rework playing of volume feedback

[David Rosca]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of manually playing feedback immediately on user interaction
  (but with wrong, old volume), connect to volume change of all sinks and
  play the feedback there.
  
  This also means that it will play feedback even if any other application
  changes volume. If this becomes an issue, it can be changed so that the
  feedback is played only when the applet is active.
  
  Also don't cancel already playing feedback sound when playing new one
  (in case of quickly changing volume), as cancelling it produces worse
  sound (with some noise on my machine) than letting them play on top of
  each other.

TEST PLAN
  Feedback is now played with correct volume + quickly changing
  volume produces pleasant feedback sound

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feedback-rework (branched from Plasma/5.9)

REVISION DETAIL
  https://phabricator.kde.org/D4140

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml
  src/qml/volumefeedback.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 129835: [IconDialog] Set proper icons group

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/
---

Review request for Plasma, Christoph Feck and Marco Martin.


Repository: kdeclarative


Description
---

Follow the comment in IconThemes: 
https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00500
iconSize == 0 && group == KIconLoader::NoGroup


Diffs
-

  src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp be54174 

Diff: https://git.reviewboard.kde.org/r/129835/diff/


Testing
---

Change group to Desktop, explicit size will override it.


Thanks,

Anthony Fieroni

[Differential] [Request, 4 lines] D4138: Only update mute state after volume change is signalled from PA

[David Rosca]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There is no difference for normal streams where setVolume and setMute
  are two different API calls, but it fixes issue with setting volume to
  0 for ext-stream-restore streams (notification sounds) where there is
  only one API call to change all stream properties.

TEST PLAN
  Moving volume slider to 0 for Notification sounds in KCM now correctly
  sets the volume to 0 and mute it. Functionality with other streams is 
unchanged.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mute-eventstream

REVISION DETAIL
  https://phabricator.kde.org/D4138

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas