[Differential] [Request, 62 lines] D4168: Move X11 specific KGlobalAccel handling into the x11-standalone platform

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  InputRedirection has a workaround to add a connect on a QAction which
  is used for a global shortcut. This is specific to the X11 platform as
  the xtime needs to be updated.
  
  This change adds a new virtual method to the Platform and moves the
  implementation into the X11 standalone platform. Thus it does no longer
  gets called on Wayland.

REPOSITORY
  R108 KWin

BRANCH
  action-kglobalaccel-to-x11

REVISION DETAIL
  https://phabricator.kde.org/D4168

AFFECTED FILES
  autotests/test_screen_edges.cpp
  autotests/test_virtual_desktops.cpp
  input.cpp
  input.h
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas

Plasma 5.9 voice over text

[Łukasz Sawicki]

Hi,

Here is a script/voice over text for Plasma 5.9 video. It is heavily
based on Plasma 5.9 beta announcement. Please check it for grammar,
typos etc.

https://notes.kde.org/p/Plasma_5.9_script

Cheers,

Łukasz Sawicki

[Differential] [Closed] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:407168327b93: Fix pixel alignment and non-standard height 
in QuickShare delegate (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4166?vs=10259=10260

REVISION DETAIL
  https://phabricator.kde.org/D4166

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4166

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D4166: Fix pixel alignment and non-standard height in QuickShare delegate

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current code had height: button.height * 1.2
  then centered the button within it, which can result in non-pixel
  aligned y values, leading to rendering issues.
  
  We don't need to specify the height explicitly, it's done by ListItem if
  we fix the underlying binding loop. This gives the delegate the correct
  size of button height + margins.
  
  BUG: 375137

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4166

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 43 lines] D4165: Drop KWin's internal global shortcut handling

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: Plasma, KWin.
Restricted Application added a project: KWin.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  During the Wayland porting a KWin internal global shortcut handling got
  implemented prior to the porting of KGlobalAccel. This allowed to trigger
  global shortcuts with a KGlobalAccel still on X11 and unknown to KWin.
  
  Nowadays KWin directly provides KGlobalAccel, thus it's no longer
  required. The code was runtime dead as we always have a KGlobalAccel.

REPOSITORY
  R108 KWin

BRANCH
  drop-internal-global-shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D4165

AFFECTED FILES
  globalshortcuts.cpp
  globalshortcuts.h
  input.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, #kwin
Cc: plasma-devel, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 159 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated this revision to Diff 10253.
broulik added a comment.


  - Don't bail out just because stat job failed, otherwise when user manually 
changes Link to a non-existing file it locks him out of the icon applet so he 
can never correct this mistake
  - Clean up a bit
  
  It will now always show file extension (used to do 
QFileInfo(localUrlString).baseName() before)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10247=10253

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[David Faure]

dfaure added a comment.


  Much nicer indeed. +2 on the KIO part.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D4156: sort alphabetically category list

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> atticaprovider.cpp:137
>  }
> +std::sort(categoryMetadataList.begin(), categoryMetadataList.end(), 
> [](const AtticaProvider::CategoryMetadata , const 
> AtticaProvider::CategoryMetadata ) -> bool {
> +const QString a(i.displayName.isEmpty() ? i.name : i.displayName);

Use QCollator for locale-aware sorting

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4156

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Re: Plasma Sprint discussion planning

[Martin Gräßlin]

Am 2017-01-16 10:48, schrieb Marco Martin:

On Sunday 15 January 2017 21:36:32 Martin Gräßlin wrote:

Just giving an idea: Some parts where KWin is responsible for on
Wayland, it could also become responsible on X11 and take over the 
part

of whatever component provided it before. E.g. KWin could manage the
keyboard layout on X11 as it has all the code for Wayland. The glue 
code

on X11 would be rather minimal.

That's also what I want to focus on in KWin internally. My aim for 
5.10

is to replace more and more of the X11 specific code through the new
implementations added for Wayland.


didn't occur to e that it would be possible.. if it is sounds 
interesting

indeed..
would be the various things like the keyboard layout be independent 
enough to

beadopted by different people?


Yes, so in KWin this will be:
* KeyboardLayout class (review open, platform independent)
* which uses a KeyboardLayoutIndicator (can be taken from existing 
plasma-desktop/kcms/keyboard with all X11 specific code removed - 
platform independent)

* Xkb class from KWin (platform independent)
* An Xkb sub-class in platform/x11/standalone which has the X11 specific 
bits


So I expect for the keyboard layout handling in the end something like 
50 to 100 lines of X11-specific code. Thanks xkbcommon for making 
keyboard layouts sane!


Cheers
Martin

[Differential] [Commented On] D4163: pre-load the first layer of sub menus

[Kai Uwe Broulik]

broulik added a comment.


  Same could be done in decoration appmenu

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4163

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D4163: pre-load the first layer of sub menus

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appmenumodel.cpp:238
> +//cache first layer of sub menus, which we'll be popping up
> +for(QAction *a: m_menu->actions()) {
> +if (a->menu()) {

coding style: for (…) {

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4163

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 146 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated this revision to Diff 10247.
broulik added a comment.


  - Just use setBusy() in the Plasma::Applet we inherit from

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10246=10247

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 561 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 16:37:17 +
Build duration: 21 min

CHANGE SET
Revision a507bb46be07e5ddc409d98c2e2f733c4f1c72b6 by Luigi Toscano: (Fix 
loading of translation catalog (thanks to Victor)
  change: edit kcms/touchpad/src/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Updated] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 170 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

[Kai Uwe Broulik]

broulik retitled this revision from "[Icon Applet] Use KIO::mostLocalUrl 
instead of just replying on isLocalFile" to "[Icon Applet] Use KIO::statJob to 
work with remote URLs".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 10246.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4157?vs=10223=10246

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 16:35:27 +
Build duration: 10 min

CHANGE SET
Revision a507bb46be07e5ddc409d98c2e2f733c4f1c72b6 by Luigi Toscano: (Fix 
loading of translation catalog (thanks to Victor)
  change: edit kcms/touchpad/src/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Accepted] D4161: Signal which menu has updated in libdbusmenu-qt

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  Hilft's nix, schad's nix

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4161

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> iconapplet.cpp:159
>  
> -// TODO use kio stat job which also works for remote stuff
> -QMimeDatabase db;
> -const QMimeType mimeType = db.mimeTypeForUrl(m_url);
> +// TODO use kio stat job which also works for remote stuff
> +QMimeDatabase db;

Isn't this TODO exactly what you implemented now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> iconapplet.cpp:189
> +});
> +statJob->start();
>  }

You don't need to start() KIO jobs, they start automatically.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

[Marco Martin]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 8 lines] D4163: pre-load the first layer of sub menus

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We still call aboutToShow on them inside libdbusmenu-qt and update the
  menu whilst it's showing, but having it pre-populated makes it look a
  bit faster.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4163

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 40 lines] D4161: Signal which menu has updated in libdbusmenu-qt

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Then update appet, SNI, and appmenu appropriately which are only care
  about the root menu.
  
  This fixes some premature showing and re-evaluation.

TEST PLAN
  Ran statusnotifiertest and checked submenu worked
  Ran applet and checked everything was still fine
  Restarted kded and checked window decoration menu

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4161

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp
  appmenu/appmenu.cpp
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp
  libdbusmenuqt/dbusmenuimporter.cpp
  libdbusmenuqt/dbusmenuimporter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:dc6948230f1f: [User Switcher] Just use Row's 
implicitWidth instead of calculating it manually (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4160?vs=10237=10238

REVISION DETAIL
  https://phabricator.kde.org/D4160

AFFECTED FILES
  applets/userswitcher/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4160

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D4160: [User Switcher] Just use Row's implicitWidth instead of calculating it manually

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  I don't know what I was thinking when I implemented this but just use 
implicitWidth which is the correct width.
  
  Fixes the label potentially being wider than the applet swallowing the right 
panel margin when placed at the end of a panel.

TEST PLAN
  Tried in all modes (label only, icon only, label+icon) and the width was 
correct every time.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4160

AFFECTED FILES
  applets/userswitcher/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 13:35:51 +
Build duration: 3 min 12 sec

CHANGE SET
Revision 44d6302f7159445f7f974446efc29731273a7d7d by David Edmundson: 
(Don#039;t load menu when switching window focus to the desktop)
  change: edit applets/appmenu/plugin/appmenumodel.cpp
Revision 68abbe669342a9d701cee8d063f5a6691fd8e47f by David Edmundson: 
(Don#039;t hide applet when it needs configuring)
  change: edit applets/appmenu/package/contents/ui/main.qml

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 13:30:33 +
Build duration: 3 min 47 sec

CHANGE SET
Revision 5937f917b29388e849341c8f1ef03f3bfeba4456 by David Edmundson: (Keep 
AppletMenu as small as possible)
  change: edit applets/appmenu/package/contents/ui/main.qml

[Differential] [Closed] D4159: Don't hide applet when it needs configuring

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:68abbe669342: Don't hide applet when it needs configuring 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4159?vs=10234=10236

REVISION DETAIL
  https://phabricator.kde.org/D4159

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4158: Don't load menu when switching window focus to the desktop

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:44d6302f7159: Don't load menu when switching window focus 
to the desktop (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4158?vs=10229=10235

REVISION DETAIL
  https://phabricator.kde.org/D4158

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4159: Don't hide applet when it needs configuring

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 4 lines] D4159: Don't hide applet when it needs configuring

[David Edmundson]

davidedmundson updated this revision to Diff 10234.
davidedmundson added a comment.


  change logic

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4159?vs=10230=10234

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4159

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4158: Don't load menu when switching window focus to the desktop

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4158

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 12:43:12 +
Build duration: 19 min

CHANGE SET
Revision 2a6bc99857451cadb6aa41e8832f11ea9503a99f by kde: ([Task Manager] 
Vertically center audio indicator for real)
  change: edit applets/taskmanager/package/contents/ui/Task.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 560 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/560/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 13:01:09 +
Build duration: 2 min 23 sec

CHANGE SET
Revision 2a6bc99857451cadb6aa41e8832f11ea9503a99f by kde: ([Task Manager] 
Vertically center audio indicator for real)
  change: edit applets/taskmanager/package/contents/ui/Task.qml

[Differential] [Updated] D4103: Support spring-loading on drag hover and drops into preview popups.

[Kai Uwe Broulik]

broulik added a comment.


  In list view mode I now get glitched out popups appearing (probably shouldn't 
do anything in list view mode, or navigate to the folder like Dolphin, but not 
spawn popups that span the entire screen width) and the index is off by one 
there, too.
  
  Icon mode is marvellous, though.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4103

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, davidedmundson, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D4159: Don't hide applet when it needs configuring

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4159

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 4 lines] D4158: Don't load menu when switching window focus to the desktop

[David Edmundson]

davidedmundson updated this revision to Diff 10229.
davidedmundson added a comment.


  Correct diff

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4158?vs=10228=10229

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4158

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D4158: Don't load menu when switching window focus to the desktop

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes the appmenu plasmoid applet on the desktop work.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4158

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: remember to merge Plasma/5.8 into Plasma/5.9 and master

[Eike Hein]

On 01/16/2017 09:40 PM, Marco Martin wrote:
> On Monday 16 January 2017 12:25:33 Jonathan Riddell wrote:
>> At the meeting today we discussed merging.  Please remember to merge fixes
>> in Plasma/5.8 into Plasma/5.9 branches and into master.
>>
>> I've now scheduled in doing this the day before 5.9.x releases but obviously
>> it's much less error prone if you do it when you first commit.
> 
> and just extra reminder, pay special attention to places where the code is 
> changed a lot since 5.8, so thinking about twice what applies to 5.8 and what 
> don't (easy example, global menu support, probably more subtle edge cases 
> around)

And for a bonus third round of reminders, this is easier if you
merge:
5.8 into 5.9
and then
5.9 into master
... instead of merging 5.8 into both 5.9 and master.


Cheers,
Eike

Re: remember to merge Plasma/5.8 into Plasma/5.9 and master

[Marco Martin]

On Monday 16 January 2017 12:25:33 Jonathan Riddell wrote:
> At the meeting today we discussed merging.  Please remember to merge fixes
> in Plasma/5.8 into Plasma/5.9 branches and into master.
> 
> I've now scheduled in doing this the day before 5.9.x releases but obviously
> it's much less error prone if you do it when you first commit.

and just extra reminder, pay special attention to places where the code is 
changed a lot since 5.8, so thinking about twice what applies to 5.8 and what 
don't (easy example, global menu support, probably more subtle edge cases 
around)

-- 
Marco Martin

Re: Requirement of SSE2

[Marco Martin]

On Saturday 14 January 2017 09:39:10 Martin Gräßlin wrote:
> Should we add this as a minimum requirement to our release announcement
> and also inform distributions about it? SSE2 Got introduced with Intel
> Pentium 4 (2001). AMD added support for it in 2003. This means hardware
> older than 13-14 years are no longer supported.

+1 (tough also mentioning that this is specific to the x86 builds)

-- 
Marco Martin

[Differential] [Request, 110 lines] D4157: [Icon Applet] Use KIO::mostLocalUrl instead of just replying on isLocalFile

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Files in desktop:/ are local files but QUrl doesn't know this.
  
  BUG: 375103
  FIXED-IN: 5.9.0

TEST PLAN
  When I drag a file from desktop:/ into my panel I now get a proper icon 
widget rather than just a generic Link to the file. Most noticeable when I drag 
a .desktop file of an application there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4157

AFFECTED FILES
  applets/icon/iconapplet.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 559 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/559/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 11:53:01 +
Build duration: 23 min

CHANGE SET
Revision 4582554b53c3301f65f5af38e02f47fb86edc2d7 by hein: (Fix 
quot;Pinquot; not working with more than one activity.)
  change: edit applets/taskmanager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 12:05:01 +
Build duration: 7 min 52 sec

CHANGE SET
Revision 4582554b53c3301f65f5af38e02f47fb86edc2d7 by hein: (Fix 
quot;Pinquot; not working with more than one activity.)
  change: edit applets/taskmanager/package/contents/ui/main.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

remember to merge Plasma/5.8 into Plasma/5.9 and master

[Jonathan Riddell]

At the meeting today we discussed merging.  Please remember to merge fixes in 
Plasma/5.8 into Plasma/5.9 branches and into master.

I've now scheduled in doing this the day before 5.9.x releases but obviously 
it's much less error prone if you do it when you first commit.

Jonathan

[Differential] [Request, 6 lines] D4156: sort alphabetically category list

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  sort the category list by their visible name
  prefer sorting by displayName if available,
  fallback to name otherwise

TEST PLAN
  category dropdown still works and is sorted

REPOSITORY
  R304 KNewStuff

BRANCH
  phab/sort

REVISION DETAIL
  https://phabricator.kde.org/D4156

AFFECTED FILES
  src/attica/atticaprovider.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Minutes Monday Plasma Meeting

[Sebastian Kügler]

The minutes of today's meeting.
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 16-01-2017

Present: Sho, d_ed, notmart, bshah, kbroulik, sebas

Sho:
* [General] Was able to clean out my fixes-and-polish queue neatly in 5.9 
freeze week, will now spend more time on Yakuake rewrite again which needs to 
get back on track after falling out of my head during vacation etc.
* [General] Spent time mediating in the CI dispute on k-c-d and privately, 
making a policy proposal and sending some mails around everywhere
** Wiki page for policy: 
https://community.kde.org/Policies/Dependency_Changes_and_CI
* [FV] Implemented spring-loading on drag hover (folder preview popup opens 
when you hover a folder icon with a drag) and dropping into preview popups, 
waiting on Kai's review
* [FV] Fixed a crash during DND
* [TM] Lowered TM text label collapse threshold based on user feedback
* [TM] Working on critical regression breaking pinning with more than one 
activity
* [Dash] Fixed going from "All Applications" to "Widgets" not working
* [Dash] Fixed missing "All Widgets" entry
* [Launchers] Fixed a bug in the pagination code in Kicker::RootModel, now 
everything is ready for a Simple Menu KDE Store release coinciding w/ 5.9
* [Launchers] Reviewing Ivan's KA-based favorites work, other code reviews

d_ed:
* Fixed misc bugs all over the place
* Mostly appmenu
* Improved the way switching containments appears in the config UI - it's more 
seamless
* this week, I think priority will be continued bug fixing, then hopefully 
finishing off that kwin scaling patchset so it can be in 5.10

notmart:
* mostly fixed bugs, in particular:
* fixed bug in kpackagetool https://phabricator.kde.org/D4043 over install of 
packages with stuff in subdirectory
Diff 4043 "fix handling of archives with a folder in them" [Closed] 
https://phabricator.kde.org/D4043
* fixed bug in look and feel kcm: binding loop with freeze
* fixed a binding loop in plasma components tabbar
* fixed applying color schemes from look and feel kcm of schemes automatically 
downloaded from the KDE store
* further work on multiscreen fix: https://phabricator.kde.org/D3981 needs 
review asap, needs to be in the beta
Diff 3981 "better clean up of duplicate containments" [Closed] 
https://phabricator.kde.org/D3981
* kcoreaddons: parse desktop files 2 times as we must know the servicetypes 
*before* the actual parsing https://phabricator.kde.org/D4082 that triggered 
KCoreAddons 5.30.1
Diff 4082 "parse the desktop file 2 times" [Closed] 
https://phabricator.kde.org/D4082
* fixed wallpaper download bug: https://phabricator.kde.org/D4118 triggered 
knewstuuf 5.30.1
Diff 4118 "if is not an archive, always copy" [Needs Review] 
https://phabricator.kde.org/D4118
* further change, that needs review https://phabricator.kde.org/D4118
Diff 4118 "if is not an archive, always copy" [Needs Review] 
https://phabricator.kde.org/D4118
* support for user friendly name for categories in knewstuff/attica 
https://phabricator.kde.org/D4120 and https://phabricator.kde.org/D4121
Diff 4120 "add support for display_name in categories" [Closed] 
https://phabricator.kde.org/D4120
Diff 4121 "add support for display_name in categories" [Closed] 
https://phabricator.kde.org/D4121
* Kirigami 2.0 release 
https://dot.kde.org/2017/01/12/kde-releases-kirigami-ui-20
most reviews should already be closed, except one

bshah:
- AOSP based mobile images up
- working on new rootfs images currently

kbroulik:
* OSD (volume, brightness, etc) can now be disabled in settings for people who 
dislike it
* Renamed open() method in IconApplet to run() due to some MOC bug where it 
will generate a open64() method instead on 32 bit, breaking compilation, 5.9 
beta was respun for this
* Audio indicator in task bar merged, global menu stuff merged \o/ for 5.9 
beta, that is
* Various fixes

sebas:
- disabled logging to kscreen.log by default (in 5.8 and 5.9 / master)
- much unrelated stuff



Full log:

[11:59:49]  meeting!
[11:59:54]  Who's here for it?
[11:59:54]  here
[11:59:56] <-- NicoRod (~nico@190.189.52.104) has quit (Ping timeout: 240 
seconds)
[11:59:56]  KurousagiMK2: yep, reproduces on master
[12:00:09]  here
[12:00:10]  http://whatthecommit.com/ << hilarious
[12:00:44]  tosky: yep, is in 5.8
[12:00:54]  sebas: yes, here!
[12:01:29]  " hahahahis branch is so dirty, even your mom can't clean 
it."
[12:01:57]  sebas: o/
[12:03:17]  alright ... we start with Sho!
[12:03:41]  before I dump my notes: Everybody should keep in mind we have 
three open branches now, suitable fixes need to be put into 5.8 and merged up 
into both 5.9 and master, let's not forget the LTS
[12:03:53]  (But I hope release-team remembers to merge 5.8 into 5.9 
before making tars, because people sometimes get regrettably lazy and don't 
merge up their own stuff)
[12:04:06]  With that out the way ...
[12:04:11]  yesyes
[12:04:15]  * [General] Was able to clean out my fixes-and-polish queue 
neatly in 5.9 freeze week, 

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 11:37:36 +
Build duration: 18 min

CHANGE SET
Revision 0c39f4812449ce306792c9c50f5aef89b3cb62f8 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
Revision 4af59a374bce56ee4be273b8397aff28953d483d by hein: (Silence warning.)
  change: edit containments/desktop/package/contents/ui/FolderView.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

[Differential] [Commented On] D4140: Rework playing of volume feedback

[Kai Uwe Broulik]

broulik added a comment.


  Aren't there applications like Skype that mess with volume settings, wouldn't 
that cause annoying sounds everytime?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 558 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/558/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 11:31:44 +
Build duration: 9 min 17 sec

CHANGE SET
Revision 1534d93d94355870d1c21d852d92d5fb54d42104 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit applets/kicker/package/metadata.desktop
Revision f68644bd4072a9f8e956361e1024e426199fc29f by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/colors/colors.desktop
Revision 65f5b536a27c4257f848f1cb21c35c502ca45ef0 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/colors/colorschemes.knsrc
Revision 0c39f4812449ce306792c9c50f5aef89b3cb62f8 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/kicker/package/metadata.desktop
Revision 39537d10fa6968730b80d5580cc67443aa89030c by David Edmundson: (Follow 
theme in taskmanager tooltip media controls background)
  change: edit applets/taskmanager/package/contents/ui/ToolTipInstance.qml
Revision f37c2ea93dd011c2a2dd6bbd648e60d36fa36a51 by David Edmundson: (Sync 
kicker tooltip icon to config setting)
  change: edit applets/kicker/package/contents/ui/main.qml
Revision 4af59a374bce56ee4be273b8397aff28953d483d by hein: (Silence warning.)
  change: edit containments/desktop/package/contents/ui/FolderView.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1528/3757 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 11 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 11:27:09 +
Build duration: 2 min 50 sec

CHANGE SET
Revision f37c2ea93dd011c2a2dd6bbd648e60d36fa36a51 by David Edmundson: (Sync 
kicker tooltip icon to config setting)
  change: edit applets/kicker/package/contents/ui/main.qml

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 10:49:35 +
Build duration: 20 min

CHANGE SET
Revision 39537d10fa6968730b80d5580cc67443aa89030c by David Edmundson: (Follow 
theme in taskmanager tooltip media controls background)
  change: edit applets/taskmanager/package/contents/ui/ToolTipInstance.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 10:48:26 +
Build duration: 5 min 56 sec

CHANGE SET
Revision 375ce8932ad3efe3c71abbde58e09382b9a120c1 by David Edmundson: (Fix 
calling KWindowSystem::windowType without fetching the type)
  change: edit applets/appmenu/plugin/appmenumodel.cpp

Re: Requirement of SSE2

[Sebastian Kügler]

On zaterdag 14 januari 2017 09:39:10 CET Martin Gräßlin wrote:
> lately I got a few crash reports indicating that QtQuick requires SSE2:
> "This program requires an X86 processor that supports SSE2 extension, at
> least a Pentium 4 or newer"
> 
> (e.g. 374023).
> 
> Should we add this as a minimum requirement to our release announcement
> and also inform distributions about it? SSE2 Got introduced with Intel
> Pentium 4 (2001). AMD added support for it in 2003. This means hardware
> older than 13-14 years are no longer supported.

Sounds fine to me. +1
-- 
sebas

http://www.kde.org | http://vizZzion.org

[Differential] [Abandoned] D4093: Initialise array variable

[David Edmundson]

davidedmundson abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4093

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3992: Sync kicker tooltip icon to config setting

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f37c2ea93dd0: Sync kicker tooltip icon to config setting 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3992?vs=9801=10219

REVISION DETAIL
  https://phabricator.kde.org/D3992

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: hein, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D4143: Follow theme in taskmanager tooltip media controls background

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:39537d10fa69: Follow theme in taskmanager tooltip media 
controls background (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4143?vs=10187=10218

REVISION DETAIL
  https://phabricator.kde.org/D4143

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4145: Fix calling KWindowSystem::windowType without fetching the type

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:375ce8932ad3: Fix calling KWindowSystem::windowType 
without fetching the type (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4145?vs=10192=10217

REVISION DETAIL
  https://phabricator.kde.org/D4145

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Plasma Sprint discussion planning

[Marco Martin]

On Sunday 15 January 2017 21:36:32 Martin Gräßlin wrote:
> Just giving an idea: Some parts where KWin is responsible for on
> Wayland, it could also become responsible on X11 and take over the part
> of whatever component provided it before. E.g. KWin could manage the
> keyboard layout on X11 as it has all the code for Wayland. The glue code
> on X11 would be rather minimal.
> 
> That's also what I want to focus on in KWin internally. My aim for 5.10
> is to replace more and more of the X11 specific code through the new
> implementations added for Wayland.

didn't occur to e that it would be possible.. if it is sounds interesting 
indeed..
would be the various things like the keyboard layout be independent enough to 
beadopted by different people?

-- 
Marco Martin

[Differential] [Abandoned] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas abandoned this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas added a comment.


  BTW: I don't know how I did it but while testing it, at some point 
configuration didn't open at all and plasma produced the following error
  
  "kcmshell5 with modules ' "org.kde.kcmshell_kcm_networkmanagement.desktop" ' 
is already running."
  
  I cannot reproduce it and it may be related to the crash that happens from 
time to time when you close the configuration window :\

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

[John Salatas]

jsalatas added a comment.


  In https://phabricator.kde.org/D4153#77549, @jgrulich wrote:
  
  > Icons problem solved F2049814: kcm.patch 
. Can you please test this patch?
  
  
  Perfect :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

[Jan Grulich]

jgrulich added a comment.


  Icons problem solved F2049814: kcm.patch 
. Can you please test this patch?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4143: Follow theme in taskmanager tooltip media controls background

[Eike Hein]

hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4143

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[Kåre Särs]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102056
---



The current/old version uses "connectSource(source)" to add the CPUs when they 
are added in onSourceAdded, but that is not good if the sources are added 
before SystemLoadViewer.qml (a problem when adding a second SytemLoadViewer)

I'm fine with this change, but it seems indeed strange that you first only 
connect "system/cores"

What happens if you use connectSource(...) in onNewData in stead of setting all 
of connectedSources again?

- Kåre Särs


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> ---
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
> http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the 
> tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

[Differential] [Commented On] D4153: Network manager configuration model is unreadable

[Jan Grulich]

jgrulich added a comment.


  Here  F2049744: kcm.patch  is patch 
using my approach, but there is still problem with icons. Given that icons are 
only available from plasma theme and we don't use colors from plasma theme 
anymore, then icons won't be visible when you use combination of light plasma 
theme and dark application color or vice versa. Any idea how to solve this?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4153

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jsalatas, #plasma, #plasma:_design, jgrulich
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 06:54:06 +
Build duration: 8 min 29 sec

CHANGE SET
Revision 8ec3bed34cc758e46e974f8a99fff974ff789fce by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/appmenu/package/metadata.desktop

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 16 Jan 2017 06:53:35 +
Build duration: 8 min 50 sec

CHANGE SET
Revision 65f5b536a27c4257f848f1cb21c35c502ca45ef0 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/colors/colorschemes.knsrc
  change: edit kcms/lookandfeel/lookandfeel.knsrc
  change: edit applets/kicker/package/metadata.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit kcms/desktoptheme/plasma-themes.knsrc


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.lookandfeel-kcmTest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2273/3414 
(67%)CONDITIONAL 1548/3798 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 274/397 (69%)CONDITIONAL 
93/219 (42%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 80/100 (80%)CONDITIONAL 
38/104 (37%)