Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 07:09:54 +
Build duration: 8 min 10 sec

CHANGE SET
Revision 53cf059ff3d5c85a358921b7e0c3b414ec2821cb by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit dataengines/filebrowser/plasma-dataengine-filebrowser.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 07:09:34 +
Build duration: 7 min 37 sec

CHANGE SET
Revision 2b9bb4fd7400adaf1864913b1aa2e76bb5621aaa by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/desktoppaths/desktoppath.desktop
  change: edit applets/trash/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 719 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/719/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 05:30:36 +
Build duration: 18 min

CHANGE SET
Revision a1cbdfbc79bf44b7438924312c73f5a9e3ae9c2c by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kioslave/desktop/Home.desktop
  change: edit dataengines/filebrowser/plasma-dataengine-filebrowser.desktop
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit applets/appmenu/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 591 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/591/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 05:29:34 +
Build duration: 10 min

CHANGE SET
Revision 85e1fb30571d080f62a2ae54cb6593106cad by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/desktoppaths/desktoppath.desktop
  change: edit 
layout-templates/org.kde.plasma.desktop.appmenubar/metadata.desktop
  change: edit applets/trash/package/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

[Eike Hein]

hein added a comment.


  Gnome-only spec? Why aren't they contributing to fd.o?

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4416

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, apol
Cc: hein, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

[Eike Hein]

hein added a comment.


  I'll review on Monday, I have a weird gut feeling about this (without looking 
at the diff) so I want to double-check, sorry :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4401

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: hein, mart, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Review Request 129917: Add a cache monitor to the System Load Viewer applet

[Pascal VITOUX]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

Review request for kde-workspace and Plasma.


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


Thanks,

Pascal VITOUX

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Fri, Feb 3, 2017 at 11:37 PM, René J.V. Bertin  wrote:
> On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:
>
>>You missed the point. This "bit rot" is not about disk damage but
>>about software incompatibility. ZFS doesn't help with that...
>
> You mean diffs that no longer apply cleanly? In that case you missed our 
> point. Being able to consult intermediate versions of diffs, abandoned diffs 
> etc. is not to be able to apply them "as is". If there were no value in the 
> kind of code those diffs (can) contain we'd not be using git or git wouldn't 
> be preserving every single bit of history.

Rene, we aren't talking about diffs here. Not even close.

What we are talking about is things like silent data corruption caused
by upgrade edge cases, database encoding changes and data storage
format changes. Not to mention changes in the software stack itself,
and our long term ability to keep it running.

>
>
> Oh well. This is just another expression of FOSS's biggest weakness. Every 
> project has this centre-of-the-universe tendency that apparently justifies 
> breaking things for large parts of the user base whenever the project feels 
> it's justified.

I'm not even going to respond to that.

>
> R

Regards,
Ben

Re: Review Request 128429: Fix strings in tooltips

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128429/
---

(Updated Feb. 3, 2017, 8:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Albert Astals Cid, Chusslove Illich, and John 
Tapsell.


Changes
---

Submitted with commit 6c5f127cb3825802ac504be94995f7bcd94da1f5 by Martin T. H. 
Sandsmark to branch master.


Repository: libksysguard


Description
---

Changed the strings to use proper kuit markup.


Diffs
-

  processui/ProcessModel.cpp 8151dfe 

Diff: https://git.reviewboard.kde.org/r/128429/diff/


Testing
---

Viewed all the tooltips.


Thanks,

Martin Tobias Holmedahl Sandsmark

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 590 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/590/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 17:08:22 +
Build duration: 6 min 8 sec

CHANGE SET
Revision 7876865ad938f723e0593de05b83a0a8b300150a by Christophe Giboudeaux: 
(Build with -Werror=missing-include-dirs)
  change: edit applets/kicker/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

[Differential] [Closed] D4410: Fix header content size when sorting is disabled

[Elvis Stansvik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:f6cd73e6d7b4: Fix header content size when sorting is 
disabled (authored by astan).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4410?vs=10857&id=10896

REVISION DETAIL
  https://phabricator.kde.org/D4410

AFFECTED FILES
  kstyle/oxygenstyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze, cfeck
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4410: Fix header content size when sorting is disabled

[Christoph Feck]

cfeck accepted this revision.
cfeck added a reviewer: cfeck.
This revision is now accepted and ready to land.

REPOSITORY
  R113 Oxygen Theme

BRANCH
  fix-unsortable-item-view-header-size

REVISION DETAIL
  https://phabricator.kde.org/D4410

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: astan, #breeze, cfeck
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Phabricator: All repositories registered - upcoming workflow changes

[Luigi Toscano]

René J.V. Bertin ha scritto:
> On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:
> 
>> You missed the point. This "bit rot" is not about disk damage but
>> about software incompatibility. ZFS doesn't help with that...
> 
> You mean diffs that no longer apply cleanly? In that case you missed our 
> point. Being able to consult intermediate versions of diffs, abandoned diffs 
> etc. is not to be able to apply them "as is". If there were no value in the 
> kind of code those diffs (can) contain we'd not be using git or git wouldn't 
> be preserving every single bit of history. 
> 
> 
> Oh well. This is just another expression of FOSS's biggest weakness. Every 
> project has this centre-of-the-universe tendency that apparently justifies 
> breaking things for large parts of the user base whenever the project feels 
> it's justified.

No one is breaking anything. We are working to try to collect the problems and
have them solved, and if you look around in the discussion it seems that a
simple mirroring is working. Also, someone else was checking on IRC how the
Reviewboard API works.

Please let's focus on the way to solve problems.

-- 
Luigi

Re: Phabricator: All repositories registered - upcoming workflow changes

[René J . V . Bertin]

On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote:

>You missed the point. This "bit rot" is not about disk damage but
>about software incompatibility. ZFS doesn't help with that...

You mean diffs that no longer apply cleanly? In that case you missed our point. 
Being able to consult intermediate versions of diffs, abandoned diffs etc. is 
not to be able to apply them "as is". If there were no value in the kind of 
code those diffs (can) contain we'd not be using git or git wouldn't be 
preserving every single bit of history. 


Oh well. This is just another expression of FOSS's biggest weakness. Every 
project has this centre-of-the-universe tendency that apparently justifies 
breaking things for large parts of the user base whenever the project feels 
it's justified.

R

[Differential] [Commented On] D4400: Plasma 5.10 "Cascade" Wallpaper

[Marco Martin]

mart added a comment.


  awesome

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4400

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma, #plasma:_design, fredrik
Cc: mart, broulik, andreaska, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

[Marco Martin]

mart added a comment.


  +1
  I was windering if even space would make sense for this, tough is better is 
used for the input field

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4401

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D4426#82837, @broulik wrote:
  
  > I can't reproduce the issue with Oxygen – does it even have the focus 
underline thingie?
  >
  > It might be missing the fix for QQC I did [1] which caused the line to show 
up because I fixed/changed some offset.
  >
  > [1] 
https://cgit.kde.org/breeze.git/commit/?id=6ecd3cad7448726807213274f66f08af79252f39
  
  
  It has the focus underline thingie (on option), but indeed the problem might 
not be present.
  Forget it then :)
  We'll fix when someone reports the issue
  thanks again !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Kai Uwe Broulik]

broulik added a comment.


  I can't reproduce the issue with Oxygen – does it even have the focus 
underline thingie?
  
  It might be missing the fix for QQC I did [1] which caused the line to show 
up because I fixed/changed some offset.
  
  [1] 
https://cgit.kde.org/breeze.git/commit/?id=6ecd3cad7448726807213274f66f08af79252f39

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:4d272dcbb53e: [KStyle] Don't draw focus indicator on 
ComboBox entries (authored by broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4426?vs=10892&id=10893

REVISION DETAIL
  https://phabricator.kde.org/D4426

AFFECTED FILES
  kstyle/breezestyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks ! 
  Care to do the same with oxygen ? (no need for a review, just push)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Kai Uwe Broulik]

broulik marked an inline comment as done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 5 lines] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Kai Uwe Broulik]

broulik updated this revision to Diff 10892.
broulik added a comment.


  Use inherits() instead of metaObject()->className()

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4426?vs=10891&id=10892

REVISION DETAIL
  https://phabricator.kde.org/D4426

AFFECTED FILES
  kstyle/breezestyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D4415: make services disqualification much stricter

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4415

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezestyle.cpp:3071
> +// no focus indicator on ComboBox list items
> +if (widget && widget->metaObject()->className() == 
> QByteArrayLiteral("QComboBoxListView")) {
> +return true;

I would rather use widget->inherits( "QComboBoxListView"). Would that work ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=375909

Rog131  changed:

   What|Removed |Added

 CC||samrog...@hotmail.com

--- Comment #3 from Rog131  ---
A possible dublicate of the Bug 370521 - [Regresion] SDDM breeze theme unable
to change backgound - https://bugs.kde.org/show_bug.cgi?id=370521

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 5 lines] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
broulik set the repository for this revision to R31 Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This results in the highlight in ComboBox popups being "cut-off" (it renders 
a white line there) at the bottom.

TEST PLAN
  No more white line
  
  Before
  F2409722: Screenshot_20170203_102501.png 

  
  After
  F2409721: Screenshot_20170203_102416.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D4426

AFFECTED FILES
  kstyle/breezestyle.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 03 Feb 2017 07:04:04 +
Build duration: 16 min

CHANGE SET
Revision a465ca396d2dbbc0817ce9f7d24eb4e6430f3804 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit menu/desktop/kf5-more.directory
  change: edit 
containmentactions/applauncher/plasma-containmentactions-applauncher.desktop
  change: edit plasma-windowed/plasma-windowed.desktop
  change: edit runners/services/plasma-runner-services.desktop
  change: edit ktimezoned/ktimezoned.desktop
  change: edit 
dataengines/applicationjobs/plasma-dataengine-applicationjobs.desktop
  change: edit dataengines/notifications/plasma-dataengine-notifications.desktop
  change: edit applets/systemtray/container/package/metadata.desktop
  change: edit runners/kill/plasma-runner-kill.desktop
  change: edit menu/desktop/kf5-system-terminal.directory
  change: edit 
dataengines/statusnotifieritem/plasma-dataengine-statusnotifieritem.desktop
  change: edit runners/kill/plasma-runner-kill_config.desktop
  change: edit dataengines/apps/plasma-dataengine-apps.desktop
  change: edit phonon/platform_kde/phonon.notifyrc
  change: edit appmenu/appmenu.desktop
  change: edit menu/desktop/kf5-internet-terminal.directory


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2300/5947 
(39%)CONDITIONAL 1597/5894 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 195/3298 (6%)CONDITIONAL 
119/3235 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 111/200 (56%)CONDITIONAL 
93/204 (46%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 52/54 (96%)CONDITIONAL 
40/74 (54%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)