D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Normally the xclipboardsyncer should terminate because the socket
  becomes unusable. But we have reports of it not really going down and
  running amok.
  
  In order to prevent such situations this change registers SIGTERM to be
  sent to xclipboardsyncer when the parent process (that is kwin_wayland)
  dies in whatever way. This ensures that xclipboardsyncer cannot become
  an orphan.
  
  BUG: 371862

TEST PLAN
  Only compile tested, no way to get into the problematic situation

REPOSITORY
  R108 KWin

BRANCH
  xclipboardsync-pdeathsig

REVISION DETAIL
  https://phabricator.kde.org/D5589

AFFECTED FILES
  CMakeLists.txt
  config-kwin.h.cmake
  helpers/xclipboardsync/main.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, lukas

D5588: Also list wayland sessions in autostart list

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5588

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5588: Also list wayland sessions in autostart list

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 379223

TEST PLAN
  Opened KCM
  Saw new entry

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5588

AFFECTED FILES
  src/sessionmodel.cpp
  src/sessionmodel.h

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5582: [Media Controller] Support CanPlay/CanPause

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Nice :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5582

To: broulik, #plasma, markg
Cc: markg, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5583: [Lock Screen] Show Previous/Next buttons only if supported

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5583

To: broulik, #plasma, #vdg, graesslin
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5583: [Lock Screen] Show Previous/Next buttons only if supported

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If the user can neither go back nor forward, hide those controls for a 
cleaner look.

TEST PLAN
  If one action (e.g. only "Next" is supported), both buttons are shown with 
the Back button grayed out. But for the case of a simple stream or so where 
really only play/pause is supported, it makes it much cleaner:
  F3734636: Screenshot_20170425_174729.png 

  
  (I initially did this for Task manager but here I found it looked odd with 
the tiny lost play icon F3734638: Screenshot_20170425_174546.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5583

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5573: Don't accept hover events in the DragArea

[Albert Astals Cid]

aacid added a comment.


  What about in the FolderView side?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D5573

To: davidedmundson, #plasma
Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Plasma 5.9.5

[Jonathan Riddell]

https://www.kde.org/announcements/plasma-5.9.5.php

Plasma bugfix out now, highlights include:

- Plastik window decoration now supports global menu. Commit. See bug
#375862. Phabricator Code review D5131
- Media Controller can now properly handle and seek long tracks (> 30
minutes). Commit. Fixes bug #377623
- Sort the themes in decoration KCM. Commit. Phabricator Code review D5407

D5582: [Media Controller] Support CanPlay/CanPause

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This way we disable the play/pause button and context menu entry if player 
claims it cannot.

TEST PLAN
  Cleared my playlist, Play button was disabled. Otherwise works as normal.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5582

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml
  dataengines/mpris2/playercontainer.cpp

To: broulik, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5573: Don't accept hover events in the DragArea

[David Edmundson]

davidedmundson added a comment.


  In https://phabricator.kde.org/D5573#104619, @aacid wrote:
  
  > "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this 
worth adding an auto test somewhere?
  
  
  Maybe, but it'd be testing that an item doesn't do what it had no reason to 
do in the first place.
  There's an infinite number of random things this item shouldn't do, I don't 
see what we'd gain from testing this specific one.
  
  It doesn't even look like it was introduced deliberately: 
https://phabricator.kde.org/R296:438b6485a481e4c11a3e719ff65adb0c631b96ad

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D5573

To: davidedmundson, #plasma
Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5573: Don't accept hover events in the DragArea

[Albert Astals Cid]

aacid added a comment.


  "Setting it enabled broke FolderView nested in a grouping Plasmoid" is this 
worth adding an auto test somewhere?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D5573

To: davidedmundson, #plasma
Cc: aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5581: [TaskGroupingProxyModel] Use LauncherUrlWithoutIcon

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5581

To: broulik, #plasma, hein
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5581: [TaskGroupingProxyModel] Use LauncherUrlWithoutIcon

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We manually remove the query anyway, so the icon can never be a part of the 
URL.

TEST PLAN
  Forcing grouping/ungrouping still works, it also still knows blacklistings I 
added before this change.
  
  Whenever we used LauncherUrl we wither did RemoveQuery and 
TaskTools::launcherUrlsMatch also does that internally.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5581

AFFECTED FILES
  libtaskmanager/taskgroupingproxymodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5262: Animate quick tiling outline

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:eaf41cb6c516: Animate quick tiling outline (authored by 
broulik).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5262?vs=13729=13787

REVISION DETAIL
  https://phabricator.kde.org/D5262

AFFECTED FILES
  geometry.cpp
  outline.cpp
  outline.h
  qml/outline/plasma/outline.qml

To: broulik, #vdg, #plasma, #kwin, graesslin, kvermette
Cc: kvermette, fabianr, graesslin, plasma-devel, kwin, spstarr, progwolff, 
Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5297: [TextFieldStyle] Fix textField is not defined error

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:884f89b9b038: [TextFieldStyle] Fix textField is not 
defined error (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5297?vs=13085=13786

REVISION DETAIL
  https://phabricator.kde.org/D5297

AFFECTED FILES
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

To: davidedmundson, #plasma, broulik
Cc: ltoscano, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 125 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/125/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 12:28:32 +
Build duration: 20 min

CHANGE SET
Revision 2ad36bf12016901dec9a2bc2e50a51dcdb5c8f10 by Jonathan Riddell: (Update 
version number for 5.9.5 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 727 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/727/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 12:42:00 +
Build duration: 8 min 29 sec

CHANGE SET
Revision a40b2dc0bdae869164ea99058a9dd299f9966922 by kde: ([AppletHandle] 
Resize button inside of applet handle must always be)
  change: edit containments/desktop/package/contents/ui/AppletHandle.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5579: Introduce QQuickItem to nest kwin_wayland

[Bhavisha Dhruve]

bdhruve added a comment.


  This patch is follow-up of https://phabricator.kde.org/D1989.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5579

To: bdhruve, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, lukas

D5579: Introduce QQuickItem to nest kwin_wayland

[Bhavisha Dhruve]

bdhruve created this revision.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  This starts Wayland server with some basic interfaces
  
  - shm
  - compositor
  - seat
  - shell
  - output
  
  And starts nested kwin_wayland.
  
  This then uses the QPainter backend of kwin_wayland to
  render the content on QQuickItem and also translates the
  qt quick events into the FakeInput events for kwin_wayland.
  
  Currently mouse and keyboard input events are supported.

TEST PLAN
  testcase attached as part of diff

REPOSITORY
  R108 KWin

BRANCH
  kwinnested

REVISION DETAIL
  https://phabricator.kde.org/D5579

AFFECTED FILES
  config-kwin.h.cmake
  main_wayland.cpp
  plugins/CMakeLists.txt
  plugins/declarative/CMakeLists.txt
  plugins/declarative/kwinnested/CMakeLists.txt
  plugins/declarative/kwinnested/kwinnested.cpp
  plugins/declarative/kwinnested/kwinnested.h
  plugins/declarative/kwinnested/kwinplugin.cpp
  plugins/declarative/kwinnested/kwinplugin.h
  plugins/declarative/kwinnested/qmldir
  plugins/declarative/kwinnested/tests/main.qml

To: bdhruve, #plasma_on_wayland, #kwin
Cc: plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, lukas

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 12:05:13 +
Build duration: 12 min

CHANGE SET
Revision f68f15de070cbfe00397067810366421ab6daa1b by Jonathan Riddell: (Update 
version number for 5.9.5 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 
(39%)CONDITIONAL 1634/5924 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 124 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/124/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 11:55:46 +
Build duration: 19 min

CHANGE SET
Revision 03006fd66ac1c79421a51751fa32dc86bc79bd33 by David Edmundson: (Update 
ungrab mouse hack for Qt5.8)
  change: edit applets/taskmanager/plugin/backend.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1566/3802 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 12:01:57 +
Build duration: 1 min 2 sec

CHANGE SET
Revision bf393665445c130878b2dcf6d8d7dde19030edbb by Jonathan Riddell: (Update 
version number for 5.9.5 GIT_SILENT)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

D1989: Introduce QQuickItem to nest kwin_wayland

[Bhavisha Dhruve]

bdhruve abandoned this revision.
bdhruve added a comment.


  This revision was started last year which had lot of discussions. Had a few 
of unfinished issues to be fixed as well.
  So creating a new one which has fixed the last few issues addressed by  
@graesslin and @davidedmundson. And i am extremely apologetic for such a long 
delay.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1989

To: bdhruve, #plasma_on_wayland, bshah, graesslin
Cc: davidedmundson, bshah, graesslin, plasma-devel, kwin, spstarr, progwolff, 
Zren, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, lukas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 868 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/868/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 11:08:12 +
Build duration: 8 min 1 sec

CHANGE SET
Revision 4421cc3041b9d172378ba5774241f7079f802073 by David Edmundson: 
(Don#039;t remove other applets in SystemTray::cleanupTask)
  change: edit applets/systemtray/systemtray.cpp
Revision 71908e79626b240d1c32ee88d726c227fa7d6a2d by l.lunak: (recognize the WM 
even if given with a full path)
  change: edit ksmserver/startup.cpp
  change: edit ksmserver/server.h
  change: edit ksmserver/legacy.cpp
  change: edit ksmserver/server.cpp
Revision da44dd6eae8b9ef4161680efcb9319a7267fe77e by l.lunak: (launch autostart 
apps in ksmserver using KRun, not QProcess)
  change: edit ksmserver/startup.cpp
Revision c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5 by l.lunak: (use KProcess 
instead of QProcess to launch apps in ksmserver)
  change: edit ksmserver/startup.cpp
Revision 75eeae6b42ccf9d553ccc77c3efcf69470540120 by David Edmundson: (Update 
the ungrab mouse hack for Qt5.8)
  change: edit applets/systemtray/systemtray.cpp
  change: edit applets/appmenu/lib/appmenuapplet.cpp
Revision fdd3e3fc7ad2b8ed8f79f204fc8f33c2a22ee357 by David Edmundson: (Update 
ungrab mouse hack for Qt 5.8)
  change: edit applets/notifications/plugin/thumbnailer.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2304/6016 
(38%)CONDITIONAL 1624/5996 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3341 (6%)CONDITIONAL 
122/3295 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 25 Apr 2017 11:07:07 +
Build duration: 8 min 5 sec

CHANGE SET
Revision 75eeae6b42ccf9d553ccc77c3efcf69470540120 by David Edmundson: (Update 
the ungrab mouse hack for Qt5.8)
  change: edit applets/appmenu/lib/appmenuapplet.cpp
  change: edit applets/systemtray/systemtray.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2333/5967 
(39%)CONDITIONAL 1634/5924 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

D5490: Only follow mouse when moved (Fixes Bug #372635)

[David Edmundson]

davidedmundson added a comment.


  Cool, seems like a solid approach.
  
  Just nitpicks left.

INLINE COMMENTS

> mousehelper.h:41-42
> +
> +Q_INVOKABLE QPointF globalMousePosition() const;
> +Q_INVOKABLE void setGlobalMousePosition(const QPointF );
> +};

You don't need these to be invokable if you're exposing them as a property.

Right now you're exporting two things with the same name, the value of a 
property and a function.

> qmlplugins.cpp:41
>  qmlRegisterType (uri, 0, 2, "DragHelper");
> +qmlRegisterType (uri, 0, 1, "MouseHelper");
>  }

May as well register a singleton, it doesn't have a state.

Instead of having one object created per delegate, we just one have object.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D5490

To: leszeklesner, broulik
Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, 
spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5490: Only follow mouse when moved (Fixes Bug #372635)

[Leszek Lesner]

leszeklesner updated this revision to Diff 13771.
leszeklesner added a comment.


  Updated to solution by qi437103 which implements a mousehelper to get the 
global mouse position so we can distinguish between mouse being inside the 
resultslistview or outside

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5490?vs=13568=13771

REVISION DETAIL
  https://phabricator.kde.org/D5490

AFFECTED FILES
  lib/CMakeLists.txt
  lib/mousehelper.cpp
  lib/mousehelper.h
  lib/qml/ResultDelegate.qml
  lib/qml/ResultsView.qml
  lib/qml/qmlplugins.cpp

To: leszeklesner, broulik
Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, 
spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5515: Update the ungrabMouse hack for Qt 5.8

[Anthony Fieroni]

anthonyfieroni added a comment.


  David, it's sould be done in plasma-framework too.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5515

To: davidedmundson, #plasma, mart
Cc: anthonyfieroni, mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, 
Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5574: Don't set ItemHasContents in DropArea

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5574

To: davidedmundson, #plasma, aacid
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol