D5649: Remove unused dependencies.

2017-04-28 Thread Michael Palimaka
palimaka created this revision.
Restricted Application added a project: Plasma.

TEST PLAN
  Inspected source, builds, tests pass.

REPOSITORY
  R258 Plymouth KCM

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5649

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: palimaka, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


[sysadmin/repo-metadata] projects/kde/workspace/plymouth-kcm: Move plymouth-kcm from KDE Review to Plasma Workspace in the virtual hierarchy after it cleared review last year.

2017-04-28 Thread Ben Cooksley
Git commit c52788ab01cf08b359842a44a3213239533d810a by Ben Cooksley.
Committed on 28/04/2017 at 19:15.
Pushed by bcooksley into branch 'master'.

Move plymouth-kcm from KDE Review to Plasma Workspace in the virtual hierarchy 
after it cleared review last year.
Fixes T5967
CCMAIL: kde-core-de...@kde.org
CCMAIL: plasma-devel@kde.org
CCMAIL: release-t...@kde.org

R  +0-0projects/kde/workspace/plymouth-kcm/i18n.json [from: 
projects/kdereview/plymouth-kcm/i18n.json - 100% similarity]
R  +1-1projects/kde/workspace/plymouth-kcm/metadata.yaml [from: 
projects/kdereview/plymouth-kcm/metadata.yaml - 083% similarity]

https://commits.kde.org/sysadmin/repo-metadata/c52788ab01cf08b359842a44a3213239533d810a

diff --git a/projects/kdereview/plymouth-kcm/i18n.json 
b/projects/kde/workspace/plymouth-kcm/i18n.json
similarity index 100%
rename from projects/kdereview/plymouth-kcm/i18n.json
rename to projects/kde/workspace/plymouth-kcm/i18n.json
diff --git a/projects/kdereview/plymouth-kcm/metadata.yaml 
b/projects/kde/workspace/plymouth-kcm/metadata.yaml
similarity index 83%
rename from projects/kdereview/plymouth-kcm/metadata.yaml
rename to projects/kde/workspace/plymouth-kcm/metadata.yaml
index 9a17b21..10642f2 100644
--- a/projects/kdereview/plymouth-kcm/metadata.yaml
+++ b/projects/kde/workspace/plymouth-kcm/metadata.yaml
@@ -5,7 +5,7 @@ members:
 - displayname: Marco Martin
   username: mart
 name: plymouth-kcm
-projectpath: kdereview/plymouth-kcm
+projectpath: kde/workspace/plymouth-kcm
 repoactive: true
 repopath: plymouth-kcm
 type: project


Re: Plasma 5.10 Frameworks version problem

2017-04-28 Thread Martin Gräßlin

Am 2017-04-28 17:22, schrieb David Edmundson:

What's the minimum version of frameworks we can use in Plasma 5.10?

The schedule currently is:

2017-05-06: Frameworks 5.33 gets tagged
2017-05-11: Plasma 5.10 beta is tagged && released
2017-05-13: Frameworks 5.33 comes out
2017-05-25: Plasma 5.10 is tagged

With the current schedule we can't use frameworks 5.33 in Plasma 5.10
beta as it will have an unreleased dependency.

With frameworks 5.32:

1) Kwin won't compile (the popupDone code)

2) Half of plasma won't load.  New QML api was added in units:
"iconSizeHints"

This is used in icon applet, trash, folderview compact, kicker,
showdesktop, minimizeall

The worst part about the latter is that you can't see the problem when
you compile :/

We can either:

 revert/ifdef those changes

 shuffle something above


I vote for shuffling around as it sounds like lots of efforts for little 
gain. The KWin case is rather trivial, but nevertheless probably half an 
hour of work to ensure it works. The iconSizeHints is even more work.


So maybe just move the release by two days and ship together with 
frameworks?


Cheers
Martin


D5641: Show applet context menu when right clicking on Applet tab in gropuing applet

2017-04-28 Thread Marco Martin
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5641

To: davidedmundson, #plasma, mart
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


Plasma 5.10 Frameworks version problem

2017-04-28 Thread David Edmundson
What's the minimum version of frameworks we can use in Plasma 5.10?

The schedule currently is:
2017-05-06: Frameworks 5.33 gets tagged
2017-05-11: Plasma 5.10 beta is tagged && released
2017-05-13: Frameworks 5.33 comes out
2017-05-25: Plasma 5.10 is tagged

With the current schedule we can't use frameworks 5.33 in Plasma 5.10 beta
as it will have an unreleased dependency.

With frameworks 5.32:

1) Kwin won't compile (the popupDone code)

2) Half of plasma won't load.  New QML api was added in units:
"iconSizeHints"
This is used in icon applet, trash, folderview compact, kicker,
showdesktop, minimizeall

The worst part about the latter is that you can't see the problem when you
compile :/

We can either:
 revert/ifdef those changes
 shuffle something above

Looking forwards, can we try to get the beta release in week 3 of the month
as we always end up in this situation.

David


D5641: Show applet context menu when right clicking on Applet tab in gropuing applet

2017-04-28 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Right clicked on an applet. Used that menu

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5641

AFFECTED FILES
  applets/grouping/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 736 - Still Unstable!

2017-04-28 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/736/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 12:59:32 +
Build duration: 15 min

CHANGE SET
Revision 3189f81aa6f38168f488ab2ffe810d717fcf6204 by aleixpol: (Set up a cache 
for attica)
  change: edit attica-kde/kdeplugin/kdeplatformdependent.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5616: Set up a cache for attica

2017-04-28 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3189f81aa6f3: Set up a cache for attica (authored by 
apol).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5616?vs=13864&id=13918

REVISION DETAIL
  https://phabricator.kde.org/D5616

AFFECTED FILES
  attica-kde/kdeplugin/kdeplatformdependent.cpp

To: apol, #plasma, leinir
Cc: jgrulich, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5616: Set up a cache for attica

2017-04-28 Thread Dan Leinir Turthra Jensen
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Looks good to me! :) i am employing a similar method in an upcoming KNS 
patch, so i will equalise the paths and whatnot in that one, so things are nice 
and clear :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5616

To: apol, #plasma, leinir
Cc: jgrulich, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5635: Sync wayland output scale to KScreen config

2017-04-28 Thread Martin Gräßlin
graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5635

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


D3504: Implment DRM EGL scaling

2017-04-28 Thread Martin Gräßlin
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  @davidedmundson feel free to push the complete series once you think it's 
ready.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3504

To: davidedmundson, #plasma, graesslin
Cc: #kwin, subdiff, graesslin, plasma-devel, kwin, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas


D5636: Fix KScreen KCM screen placement with scaled outputs

2017-04-28 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The QML part of the KCM gets the output size manually as it wants to do
  all translations itself.
  
  We need to divide the mode by the scale as wayland wants everything in
  normalised global co-ordinates.
  
  i.e a screen to the right of a 2x output with a mode of 2000 pixels,
  will have an X of 1000.

TEST PLAN
  Had a scaled output (set using kwin config)
  Moved some about. 
  They appeared exactly where it should have done.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5636

AFFECTED FILES
  kcm/src/declarative/qmloutput.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


D5635: Sync wayland output scale to KScreen config

2017-04-28 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Viewed in kscreen-console

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5635

AFFECTED FILES
  backends/kwayland/waylandoutput.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


D5634: Include output scale in kscreen-console

2017-04-28 Thread David Edmundson
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Ran it. Looked at new line

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5634

AFFECTED FILES
  console/console.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, lukas


D5616: Set up a cache for attica

2017-04-28 Thread Aleix Pol Gonzalez
apol edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5616

To: apol, #plasma, leinir
Cc: jgrulich, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5616: Set up a cache for attica

2017-04-28 Thread Jan Grulich
jgrulich added a comment.


  Looks good to me.
  
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5616

To: apol, #plasma, leinir
Cc: jgrulich, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas


D5507: Don't even try to scale images that we created ad-hoc

2017-04-28 Thread Aleix Pol Gonzalez
apol abandoned this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D5507

To: apol, #kirigami, mart
Cc: plasma-devel, apol


D5490: Only follow mouse when moved (Fixes Bug #372635)

2017-04-28 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R112 Milou

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5490

To: leszeklesner, broulik, davidedmundson
Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, lukas


Plasma Workspace 5.9.5.1 update

2017-04-28 Thread Jonathan Riddell
A bug in ksmserver caused a hang when attempting to load a broken
autostart file.  This affects palsma-workspace 5.9.5 tar.

https://bugs.kde.org/show_bug.cgi?id=379254

The problem code has been reverted and I've uploaded a 5.9.5.1 tar for
plasma-workspace

https://www.kde.org/info/plasma-5.9.5.php

Jonathan


[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-28 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344

--- Comment #19 from Christoph Feck  ---
I can only speak for myself, but I only used sftp:// which is based on ssh.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D3504: Implment DRM EGL scaling

2017-04-28 Thread David Edmundson
davidedmundson updated this revision to Diff 13906.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Also scale the offset, this fixes a bug if a scaled display is not in global 
position 0,0

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3504?vs=12806&id=13906

REVISION DETAIL
  https://phabricator.kde.org/D3504

AFFECTED FILES
  plugins/platforms/drm/egl_gbm_backend.cpp

To: davidedmundson, #plasma, graesslin
Cc: #kwin, subdiff, graesslin, plasma-devel, kwin, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas


Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 121 - Still unstable!

2017-04-28 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 08:28:05 +
Build duration: 14 min

CHANGE SET
Revision 3b305e79f530b816f50304118f96914256fdc604 by Rik Mills: (Add back 
include changes lost in revert and merge)
  change: edit ksmserver/startup.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtestFailed: TestSuite.klipper-testHistory

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2301/5973 
(39%)CONDITIONAL 1610/5930 (27%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 107/141 (76%)CONDITIONAL 
42/72 (58%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 259/390 
(66%)CONDITIONAL 113/216 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 595/693 (86%)CONDITIONAL 
349/820 (43%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3301 (6%)CONDITIONAL 
122/3247 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 735 - Still Unstable!

2017-04-28 Thread no-reply

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/735/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 08:25:25 +
Build duration: 7 min 5 sec

CHANGE SET
Revision ec1f70b3563192abcb6a3ea834ce093819b28504 by Marco Martin: (restore the 
"current" color scheme concept)
  change: edit kcms/colors/colorscm.h
  change: edit kcms/colors/CMakeLists.txt
  change: edit kcms/colors/scmeditordialog.ui
  change: edit kcms/colors/colorscm.cpp
  change: edit kcms/colors/scmeditordialog.h
  change: edit kcms/colors/scmeditordialog.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5411: restore the "current" color scheme concept

2017-04-28 Thread Marco Martin
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ec1f70b35631: restore the "current" color scheme concept 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5411?vs=13640&id=13904

REVISION DETAIL
  https://phabricator.kde.org/D5411

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colorscm.cpp
  kcms/colors/colorscm.h
  kcms/colors/scmeditordialog.cpp
  kcms/colors/scmeditordialog.h
  kcms/colors/scmeditordialog.ui

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas