D5733: Keep all touchpad QActions in the main thread

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Making QActions with the Connection as a parent is dangerous as it gets
  moved to a new thread, moving all child objects to that thread.
  
  KGlobalAccel and QAction aren't thread safe and we shouldn't be using it
  in two threads. This was notably seen when runnng invokeShortcut over
  DBus which then invokes it on the main thread. Something my laptop was
  doing when I closed the lid.
  
  This patch simply moves the code to the Input class, where we set up the
  libinput connection.

TEST PLAN
  Closed lid, kwin_wayland was still there when I resumed
  Set manual shortcut for toggling touchpad, that still worked

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5733

AFFECTED FILES
  input.cpp
  libinput/connection.cpp
  libinput/connection.h

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D5729: #379003: Fix National Geographic POTD provider

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> sebas wrote in natgeoprovider.cpp:96
> Why this change? Moving away from https to http seems backward...

The https redirects to http (HTTP 302 temp move), then redirects to add the 
trailing slash (HTTP 301 Perm Move).

F3744087: 2017-05-06___19-22-22.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

To: vitali, sebas
Cc: Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

[kio-extras] [Bug 379593] New: git master fails to build: plasma_version.h not found

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=379593

Bug ID: 379593
   Summary: git master fails to build: plasma_version.h not found
   Product: kio-extras
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

Using git master:

man/man2html.cpp:146:29: fatal error: plasma_version.h: No such file or
directory
# include 

Most likely needs plasma-framework devel files to be installed, but cmake does
not check for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5731: Fix regression for timestamp handling for Xwayland windows

[Thomas Lübking]

luebking accepted this revision.
luebking added a comment.
This revision is now accepted and ready to land.


  Matter of semantics only (if you would want to use the XCB_CURRENT_TIME 
symbol wrt backend abstraction matters and readability - the invalidity isn't 
implicitly explained, maybe read as bool "if (timestamp && ...") but I'm out of 
position for an informed comment on this.

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-try2-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5731

To: graesslin, #kwin, #plasma, luebking
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, apol, lukas

D5729: #379003: Fix National Geographic POTD provider

[Juri Vitali]

vitali planned changes to this revision.
vitali added inline comments.

INLINE COMMENTS

> natgeoprovider.cpp:61
> +
> +
> re.setPattern("^$");
> +

An alternative regex may be 
`"^$"`, so to match any 
possible future fields before `property`, and between `property` and `content`.

> sebas wrote in natgeoprovider.cpp:96
> Why this change? Moving away from https to http seems backward...

The versions with https or without the trailing slash were not working for me, 
so I changed it to that one, but it could as well be just be my mistake.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

To: vitali, sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5731: Fix regression for timestamp handling for Xwayland windows

[Sebastian Kügler]

sebas added subscribers: luebking, sebas.
sebas added a comment.


  @luebking can you have a look?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5731

To: graesslin, #kwin, #plasma
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, apol, lukas

D5731: Fix regression for timestamp handling for Xwayland windows

[Martin Gräßlin]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  Change 
https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb 
introduced a regrssion
  on Wayland. On Wayland getTimestamp always returns 0, thus the X11
  timestamp gets reset again and again. This results in broken interaction
  for Xwayland windows as the broken unit tests show.
  
  This change addresses the regression by ignoring a value of 0.
  It means the addressed bug is still present on Wayland for X11 windows
  as the timestamp doesn't get updated properly. This requires further
  changes.

TEST PLAN
  TestShade works again, testX11TimestampUpdate still works

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-try2-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5731

AFFECTED FILES
  main.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, lukas

D5726: Fix regression for timestamp handling for Xwayland windows

[Martin Gräßlin]

graesslin added a comment.


  New version at https://phabricator.kde.org/D5731

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5726

To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

Next Gen CI: framework dependencies for KWin

[Martin Flöser]

Am 2017-05-06 11:37, schrieb Ben Cooksley:

This is the second point that requires your attention. If your
development process is dependent on using the latest development
version of something which is located in another product, then we will
need to add that to your Product. If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines of explaination for each.


My requests for KWin:
 * KWindowSystem
 * KWayland
 * (optionally KGlobalAccel)
 * (optionally Plasma)

Reasoning:
KWindowSystem implements the X11 side of the Window Manager. This is 
mostly the NETWM classes. Normally a change in KWindowSystem is always 
triggered by a change in KWin.

Example from changes I implemented:
b7bd5f9a09cb3874532269838b53f03c800d8a44 in KWin and 
e333a13fc52c28aac3c0d28cd5b85e16428fcff7 in KWindowSystem


KWayland implements the server side of a Wayland compositor. Changes in 
KWayland are mostly triggered by the needs of KWin.

Example from changes I implemented:
1193b0da771a5d1042bf2aed0a2727f89ddf488e in KWin and 
6c89a61d2d17e1703b961566133cc5f46516b5a1 in KWayland


On Wayland KWin provides the runtime part of KGlobalAccel and therefore 
needs to interact with the library. As in the other cases changes are 
normally triggered from KWin, but over the last years changes were very 
seldom. Thus I don't think we absolutely need it. Given that it's not 
tier 1 I wouldn't be sad if I get a no here.


Similar for Plasma: it's a library KWin (indirectly) uses and sometimes 
changes are needed. But it's very seldom that a change is triggered by 
KWin.


Cheers
Martin

D5726: Fix regression for timestamp handling for Xwayland windows

[Martin Gräßlin]

graesslin abandoned this revision.
graesslin added a comment.


  Going for Thomas's suggestion to check in setX11Time

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5726

To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D5729: #379003: Fix National Geographic POTD provider

[Sebastian Kügler]

sebas added inline comments.

INLINE COMMENTS

> natgeoprovider.cpp:96
>  {
> -const QUrl url( QLatin1String( 
> "https://www.nationalgeographic.com/photography/photo-of-the-day; ) );
> +const QUrl url( QLatin1String( 
> "http://www.nationalgeographic.com/photography/photo-of-the-day/; ) );
>  KIO::StoredTransferJob *job = KIO::storedGet( url, KIO::NoReload, 
> KIO::HideProgressInfo );

Why this change? Moving away from https to http seems backward...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

To: vitali, sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 742 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/742/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 16:16:50 +
Build duration: 6 min 5 sec

CHANGE SET
Revision 65a42d8a2be1145a9bf29c97a3ed471201419c96 by ivan.cukic: (Adding an 
option to show popular documents/apps for Kickoff)
  change: edit applets/kickoff/package/contents/ui/ConfigButtons.qml
  change: edit applets/kicker/plugin/recentusagemodel.h
  change: add applets/kickoff/package/contents/ui/OftenUsedView.qml
  change: edit applets/kickoff/package/contents/ui/FullRepresentation.qml
  change: edit applets/kickoff/package/contents/config/main.xml
  change: edit applets/kicker/plugin/recentusagemodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2306/3420 
(67%)CONDITIONAL 1546/3761 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 282/398 (71%)CONDITIONAL 
95/219 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 105/105 
(100%)CONDITIONAL 54/108 (50%)

D5620: Adding an option to show popular documents/apps for Kickoff

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:65a42d8a2be1: Adding an option to show popular 
documents/apps for Kickoff (authored by ivan).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5620?vs=13879=14208

REVISION DETAIL
  https://phabricator.kde.org/D5620

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/OftenUsedView.qml

To: ivan, hein, mart, sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5620: Adding an option to show popular documents/apps for Kickoff

[Ivan Čukić]

ivan added a comment.


  Not sure I'd rush it for 5.11. I'll probably have to tweak the formula 
coefficients for the score - how much deterioration over time it should have, 
... (this is the main reason I'm making the graphs - to be able to easier debug 
the stats - having it in a user application is less important.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5620

To: ivan, hein, mart, sebas
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 880 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/880/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 14:20:47 +
Build duration: 6 min 5 sec

CHANGE SET
Revision 16629c8ea8e2caca93d4c8ae22b74a3ec9a6a56e by David Rosca: 
(DBusMenuImporter: Use unique connection for QMenu::aboutToHide)
  change: edit libdbusmenuqt/dbusmenuimporter.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2348/6022 
(39%)CONDITIONAL 1657/6004 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 262/390 
(67%)CONDITIONAL 114/216 (53%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 636/699 (91%)CONDITIONAL 
381/828 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3341 (6%)CONDITIONAL 
122/3295 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

D5706: DBusMenuImporter: Use unique connection for QMenu::aboutToHide

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:16629c8ea8e2: DBusMenuImporter: Use unique connection for 
QMenu::aboutToHide (authored by drosca).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5706?vs=14125=14207

REVISION DETAIL
  https://phabricator.kde.org/D5706

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: drosca, #plasma, davidedmundson
Cc: sebas, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5684: Move all streams when changing default device

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:cb52cc8826d4: Move all streams when changing default 
device (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5684?vs=14067=14204

REVISION DETAIL
  https://phabricator.kde.org/D5684

AFFECTED FILES
  src/context.cpp
  src/context.h

To: drosca, #plasma, sebas
Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5546: Preserve channel balance when changing volume

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:462628981947: Preserve channel balance when changing 
volume (authored by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5546?vs=13711=14205#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5546?vs=13711=14205

REVISION DETAIL
  https://phabricator.kde.org/D5546

AFFECTED FILES
  src/context.h
  src/volumeobject.cpp

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d78689251344: Applet: Automatically raise maximum volume 
when over defined maximum volume (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5695?vs=14109=14203

REVISION DETAIL
  https://phabricator.kde.org/D5695

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> sebas wrote in ListItemBase.qml:282
> Should be "volume", since that's the property. Or perhaps we don't need 
> "volume" or "Volume".

"Volume" is a role from the model, so assigning to the "volume" property 
instead only makes it go through one indirection level. The "volume" property 
should be made readonly as it is there only for property changes.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  auto-raise-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[Sebastian Kügler]

sebas added a comment.


  You're right, forgot to submit the cosmetical comment.

INLINE COMMENTS

> ListItemBase.qml:282
> +if (!slider.forceRaiseMaxVolume && Volume > 
> PulseAudio.NormalVolume) {
> +Volume = PulseAudio.NormalVolume;
> +}

Should be "volume", since that's the property. Or perhaps we don't need 
"volume" or "Volume".

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  auto-raise-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5695: Applet: Automatically raise maximum volume when over defined maximum volume

[David Rosca]

drosca added a comment.


  In https://phabricator.kde.org/D5695#106996, @sebas wrote:
  
  > Cosmetical comment aside, looks good.
  
  
  What's that cosmetical comment? Did you forget to send it?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  auto-raise-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

[Juri Vitali]

https://bugs.kde.org/show_bug.cgi?id=379003

--- Comment #10 from Juri Vitali  ---
(In reply to Sebastian Kügler from comment #9)

Sure thing!

I cleaned the patch up a bit, and posted it on Phabricator.
Here it is: https://phabricator.kde.org/D5729

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5546: Preserve channel balance when changing volume

[Sebastian Kügler]

sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> context.h:97
>  if (channel == -1) { // -1 all channels
> +qint64 diff = newVolume - pa_cvolume_avg();
>  for (int i = 0; i < newCVolume.channels; ++i) {

const

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5546

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

D5684: Move all streams when changing default device

[Sebastian Kügler]

sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5684

To: drosca, #plasma, sebas
Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5726: Fix regression for timestamp handling for Xwayland windows

[Sebastian Kügler]

sebas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  fix-timestamp-regression-5.8

REVISION DETAIL
  https://phabricator.kde.org/D5726

To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas

D5729: #379003: Fix National Geographic POTD provider

[Juri Vitali]

vitali created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current parsing mechanism to obtain the current NatGeo POTD based on XML 
is broken, this patch proposes an alternative mechanism using 
QRegularExpression library.
  For this method to continue working in the future it is supposed that the web 
page will maintain a sane format, namely that the relevant tag will not be 
broken among many lines, the fields inside the tag will maintain the same 
relative order, and obviously that it will not be obfuscated.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

AFFECTED FILES
  dataengines/potd/natgeoprovider.cpp

To: vitali, sebas
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA

[Christoph Feck]

cfeck added a comment.


  In https://phabricator.kde.org/D5723#107203, @davidedmundson wrote:
  
  > add bug mentioned by cfeck
  
  
  Uhm, where did you add it?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5723

To: davidedmundson, #plasma, graesslin
Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5728: Release the wl_registry before QPA shutdown in QStyl

[Martin Gräßlin]

graesslin added a comment.


  I had already investigated the problem, pushed a change and reverted it. I 
think the qstyle gets destroyed too early.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5728: Release the wl_registry before QPA shutdown in QStyl

[David Edmundson]

davidedmundson added a comment.


  I uploaded to make it easier for someone to test a patch. It didn't work. 
That's why I'm closing it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5728: Release the wl_registry before QPA shutdown in QStyl

[Christoph Feck]

cfeck added a reviewer: hpereiradacosta.
cfeck added a comment.


  Probably needs a similar fix in Oxygen. And if "Registry" is related to 
pixmap/tile caches, it might even fix the shutdown crashes we got there, e.g. 
bug 331260.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma, hpereiradacosta
Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5728: Release the wl_registry before QPA shutdown in QStyl

[David Edmundson]

davidedmundson abandoned this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5728

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5728: Release the wl_registry before QPA shutdown in QStyl

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise we get a double release as the QPA releases the wl_display
  which deletes the registry.
  
  BUG:

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5728

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5566: recentdocuments ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:26f76fc64bae: recentdocuments ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5566?vs=13748=14194

REVISION DETAIL
  https://phabricator.kde.org/D5566

AFFECTED FILES
  recentdocuments/CMakeLists.txt
  recentdocuments/recentdocuments.cpp
  recentdocuments/recentdocumentsnotifier.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5562: Fish ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:149d281277df: fish ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5562?vs=13743=14192

REVISION DETAIL
  https://phabricator.kde.org/D5562

AFFECTED FILES
  fish/CMakeLists.txt
  fish/fish.cpp
  fish/fish.h
  fish/tests/CMakeLists.txt

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5568: SFTP ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:11df45b3d216: SFTP ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5568?vs=14036=14196

REVISION DETAIL
  https://phabricator.kde.org/D5568

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5569: thumbnail ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b0b12086e786: Thumbnail ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5569?vs=13752=14197

REVISION DETAIL
  https://phabricator.kde.org/D5569

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/thumbnail.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5564: Man ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:cefa4de62964: Man ioslave: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5564?vs=13744=14191

REVISION DETAIL
  https://phabricator.kde.org/D5564

AFFECTED FILES
  man/CMakeLists.txt
  man/kio_man.cpp
  man/kmanpart.cpp
  man/man2html.cpp
  man/tests/CMakeLists.txt

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5567: Settings ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:117e6235ce81: Settings ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5567?vs=13750=14195

REVISION DETAIL
  https://phabricator.kde.org/D5567

AFFECTED FILES
  settings/CMakeLists.txt
  settings/kio_settings.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5565: Network ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:17effe0d9f73: Network ioslave: Port away from 
KDELibs4Support (authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5565?vs=13746=14193

REVISION DETAIL
  https://phabricator.kde.org/D5565

AFFECTED FILES
  network/ioslave/main.cpp
  network/ioslave/networkinitwatcher.h
  network/ioslave/networkslave.cpp
  network/network/CMakeLists.txt
  network/network/molletnetwork_export.h
  network/network/netdevice.cpp
  network/network/netdevice.h
  network/network/netservice.cpp
  network/network/netservice.h
  network/network/network.cpp
  network/network/network.h

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5560: Archive ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bbd3d8feb250: Archive: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5560?vs=13741=14189

REVISION DETAIL
  https://phabricator.kde.org/D5560

AFFECTED FILES
  archive/CMakeLists.txt
  archive/autotests/CMakeLists.txt
  archive/autotests/testkioarchive.cpp
  archive/kio_archivebase.cpp

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5561: Filter ioslave: Port away from KDELibs4Support

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:c285acd05e32: filter: Port away from KDELibs4Support 
(authored by marten).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5561?vs=13742=14190

REVISION DETAIL
  https://phabricator.kde.org/D5561

AFFECTED FILES
  filter/CMakeLists.txt
  filter/filter.cc

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

[Plasma Workspace Wallpapers] [Bug 379003] Wallpaper "Picture of the Day" from National Geographics only changing after reboot or not at all.

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=379003

Sebastian Kügler  changed:

   What|Removed |Added

 CC||se...@kde.org

--- Comment #9 from Sebastian Kügler  ---
Hi Juri,

Great! From a quick glance at the bugreport and the explanation, I don't see
another easy way around this. Your patch however, will need a bit of cleanup
and proper review. Could you post it to KDE's phabricator, so we can run it
through our review process, get it up to our standards and then merge it?

The address is phabricator.kde.org .

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[Elvis Angelaccio]

On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote:

Hi everyone,

This is going to be quite a long email, my apologies in advance for that.
If you use the CI system regularly as part of your development flow it
is important you read this email in it's entirety as your action will
probably be required. If you are aware of a list I have missed in the
above, please feel free to forward it there.

As some will have been aware of for some time we currently have a
problem where changing the system base is an incredibly disruptive
activity. We also have issues where builds sometimes fail due to files
disappearing mid-build or installations being inconsistent, and
excessive numbers of emails are generated. To top this off, everyone
has to use the same underlying "base" system for performing builds
which sets up conflicts between projects. Oh, and we also only perform
CI for Linux.

To solve these problems we've been working on a Next Generation CI
system which introduces a new concept called 'Products'. In short, a
Product is a release unit, such as Frameworks, Plasma, KDE
Applications, which groups a series of repositories which are
developed and subsequently released together.

A preview of this system can be viewed at https://build-sandbox.kde.org/

Products as part of their definition are able to define a set of
'Platforms' on which they build. At the moment we have three Platforms
available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
Adding additional Platforms to this mix is fairly easy, as long as the
code can be built there. Qt will now be considered as part of the base
system, and is something we will no longer build ourselves.

Each Product / Platform definition is fully independent. This will
allow for different products to build against different versions of Qt
among other things for instance.

This is the first part that requires your action: we'd like
developers, particularly those whose development relies on bleeding
edge system software to assist in creating and maintaining (Linux)
Platform images. If you're interested in this, please let me know.

As part of the shift to the Products paradigm, a number of changes
have been made to how projects are built and dependencies managed.
This particularly affects dependencies on projects which are outside
your Product (Frameworks is outside of Plasma and Applications for
instance). These dependencies will now be satisfied through
"Dependency Build" jobs, which will be executed once a week. As a
result the master version of Frameworks will no longer be available
outside Frameworks itself.

This change is one of the big ones which massively reduces the effort
required to change base systems and thus hugely improves the
maintainability of the CI system. It is therefore quite important and
necessary, and also isolates the rest of the CI system from breakages
lower down in the stack which have happened in the past.

This is the second point that requires your attention. If your
development process is dependent on using the latest development
version of something which is located in another product, then we will
need to add that to your Product. If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines of explaination for each.

Note that requests for the entirety of Frameworks won't be accepted -
each must be requested on an individual basis with an explanation
given for why your development process is dependent on the master
version of that Framework.

With the change to Products as a core concept for driving the CI
system, this does leave Extragear somewhat in a bit of an unusual
situation. At the moment we're planning to deal with this by having
Extragear be a 'Product' with all of them combined together. If anyone
in Extragear has any comments to make on this they're certainly
welcome here.

Which brings me to the third point of attention. We'll only be adding
projects to the Next Gen CI system at their request going forward. For
Frameworks, Applications and Plasma this is something which we're
essentially assuming we're going to receive from their release
managers, so we'll take care of defining the initial Products for
those. For Extragear projects, please respond to this thread if you'd
like CI coverage (to continue) to be provided to you.


What's the role of kde-build-metadata.git in the new CI? If an extragear 
project is already defined there, won't it be automatically built by the 
new CI?




Thanks for all who have reached this point - my apologies again for
it's length.

Note that the Next Gen system isn't finished yet - Notifications are
yet to be setup and there are a few other touches left to be made.

Regards,
Ben Cooksley
KDE Sysadmin


Cheers,
Elvis

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[Ben Cooksley]

On Sat, May 6, 2017 at 10:15 PM, Elvis Angelaccio
 wrote:
> On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote:
>>
>> Hi everyone,
>>
>> This is going to be quite a long email, my apologies in advance for that.
>> If you use the CI system regularly as part of your development flow it
>> is important you read this email in it's entirety as your action will
>> probably be required. If you are aware of a list I have missed in the
>> above, please feel free to forward it there.
>>
>> As some will have been aware of for some time we currently have a
>> problem where changing the system base is an incredibly disruptive
>> activity. We also have issues where builds sometimes fail due to files
>> disappearing mid-build or installations being inconsistent, and
>> excessive numbers of emails are generated. To top this off, everyone
>> has to use the same underlying "base" system for performing builds
>> which sets up conflicts between projects. Oh, and we also only perform
>> CI for Linux.
>>
>> To solve these problems we've been working on a Next Generation CI
>> system which introduces a new concept called 'Products'. In short, a
>> Product is a release unit, such as Frameworks, Plasma, KDE
>> Applications, which groups a series of repositories which are
>> developed and subsequently released together.
>>
>> A preview of this system can be viewed at https://build-sandbox.kde.org/
>>
>> Products as part of their definition are able to define a set of
>> 'Platforms' on which they build. At the moment we have three Platforms
>> available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>> Adding additional Platforms to this mix is fairly easy, as long as the
>> code can be built there. Qt will now be considered as part of the base
>> system, and is something we will no longer build ourselves.
>>
>> Each Product / Platform definition is fully independent. This will
>> allow for different products to build against different versions of Qt
>> among other things for instance.
>>
>> This is the first part that requires your action: we'd like
>> developers, particularly those whose development relies on bleeding
>> edge system software to assist in creating and maintaining (Linux)
>> Platform images. If you're interested in this, please let me know.
>>
>> As part of the shift to the Products paradigm, a number of changes
>> have been made to how projects are built and dependencies managed.
>> This particularly affects dependencies on projects which are outside
>> your Product (Frameworks is outside of Plasma and Applications for
>> instance). These dependencies will now be satisfied through
>> "Dependency Build" jobs, which will be executed once a week. As a
>> result the master version of Frameworks will no longer be available
>> outside Frameworks itself.
>>
>> This change is one of the big ones which massively reduces the effort
>> required to change base systems and thus hugely improves the
>> maintainability of the CI system. It is therefore quite important and
>> necessary, and also isolates the rest of the CI system from breakages
>> lower down in the stack which have happened in the past.
>>
>> This is the second point that requires your attention. If your
>> development process is dependent on using the latest development
>> version of something which is located in another product, then we will
>> need to add that to your Product. If this affects you, please start a
>> new thread (CC'ing sysadmin and kde-core-devel along with your
>> Product's main list) stating which specific repositories you need and
>> providing one to two lines of explaination for each.
>>
>> Note that requests for the entirety of Frameworks won't be accepted -
>> each must be requested on an individual basis with an explanation
>> given for why your development process is dependent on the master
>> version of that Framework.
>>
>> With the change to Products as a core concept for driving the CI
>> system, this does leave Extragear somewhat in a bit of an unusual
>> situation. At the moment we're planning to deal with this by having
>> Extragear be a 'Product' with all of them combined together. If anyone
>> in Extragear has any comments to make on this they're certainly
>> welcome here.
>>
>> Which brings me to the third point of attention. We'll only be adding
>> projects to the Next Gen CI system at their request going forward. For
>> Frameworks, Applications and Plasma this is something which we're
>> essentially assuming we're going to receive from their release
>> managers, so we'll take care of defining the initial Products for
>> those. For Extragear projects, please respond to this thread if you'd
>> like CI coverage (to continue) to be provided to you.
>
>
> What's the role of kde-build-metadata.git in the new CI? If an extragear
> project is already defined there, won't it be automatically built by the new
> CI?

kde-build-metadata continues to be consulted for:

a) Dependencies
b) Branch 

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[René J . V . Bertin]

On Saturday May 06 2017 22:01:58 Ben Cooksley wrote:
>On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin  wrote:
>> On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:
>>
>>>'Platforms' on which they build. At the moment we have three Platforms
>>>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>>>Adding additional Platforms to this mix is fairly easy, as long as the
>>>code can be built there. Qt will now be considered as part of the base
>>>system, and is something we will no longer build ourselves.
>>
>> One remark about this: Qt 5.7 is not the most issue-free version but I 
>> understand why the 5.6 LTS version was not preferred instead. However, there 
>> is 1 thing with using stock Qt that's potentially problematic on a CI. It 
>> lacks a QtDBus patch that Qt cannot at the moment incorporate but that 
>> everyone should be using because it prevents crashing on exit under certain 
>> conditions.
>
>It'll be up to the system distributor in that case to include the
>patch. We shouldn't be including patches the system distributor isn't
>in any case, as that will lead to a different environment compared to
>our users.

That works both ways. It's Qt's intention that distributions and "home 
builders" include the patch, so you can also adopt the position that a CI 
intended to find issues with KDE software shouldn't be vulnerable to issues in 
KDE dependencies that are not supposed to be present on user systems.
Note that I myself wouldn't really know which position to adopt... but I would 
probably avoid ambiguity and provide the dependencies with all known issues 
either explicitly fixed or explicitly NOT fixed (the latter being the easy 
solution). Depending on the decisions of a single "system distributor" chosen 
among the myriad of distributors (for Linux at least) seems ... problematic in 
this aspect.

>Note that for Windows and Mac we shouldn't be doing D-Bus anyway as
>they're alien to that platform

This is not exactly true and IMHO not a decision to be imposed by something 
like a CI. The DBus daemon includes support for both platforms and should be 
seen as a cross-platform desktop IPC solution which is also the only IPC 
interface Qt provides to my knowledge. Interdicting DBus use on Mac and MS 
Windows would make those platforms inaccessible to projects like KDEPIM. I 
don't think they'd appreciate that.
In fact, any application using KWallet will probably run into issues.

>(and the CI Tooling won't launch D-Bus
>as part of it's test environment setup there as a result)

The QtDBus issue itself does *not* depend on whether a DBus daemon is running 
or not, it's purely internal to Qt.

R.

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[Ben Cooksley]

On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin  wrote:
> On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:
>
>>'Platforms' on which they build. At the moment we have three Platforms
>>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>>Adding additional Platforms to this mix is fairly easy, as long as the
>>code can be built there. Qt will now be considered as part of the base
>>system, and is something we will no longer build ourselves.
>
> One remark about this: Qt 5.7 is not the most issue-free version but I 
> understand why the 5.6 LTS version was not preferred instead. However, there 
> is 1 thing with using stock Qt that's potentially problematic on a CI. It 
> lacks a QtDBus patch that Qt cannot at the moment incorporate but that 
> everyone should be using because it prevents crashing on exit under certain 
> conditions.

It'll be up to the system distributor in that case to include the
patch. We shouldn't be including patches the system distributor isn't
in any case, as that will lead to a different environment compared to
our users.

Note that for Windows and Mac we shouldn't be doing D-Bus anyway as
they're alien to that platform (and the CI Tooling won't launch D-Bus
as part of it's test environment setup there as a result)

>
> R.

Cheers,
Ben

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[René J . V . Bertin]

On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:

>'Platforms' on which they build. At the moment we have three Platforms
>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>Adding additional Platforms to this mix is fairly easy, as long as the
>code can be built there. Qt will now be considered as part of the base
>system, and is something we will no longer build ourselves.

One remark about this: Qt 5.7 is not the most issue-free version but I 
understand why the 5.6 LTS version was not preferred instead. However, there is 
1 thing with using stock Qt that's potentially problematic on a CI. It lacks a 
QtDBus patch that Qt cannot at the moment incorporate but that everyone should 
be using because it prevents crashing on exit under certain conditions.

R.

Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

[Ben Cooksley]

Hi everyone,

This is going to be quite a long email, my apologies in advance for that.
If you use the CI system regularly as part of your development flow it
is important you read this email in it's entirety as your action will
probably be required. If you are aware of a list I have missed in the
above, please feel free to forward it there.

As some will have been aware of for some time we currently have a
problem where changing the system base is an incredibly disruptive
activity. We also have issues where builds sometimes fail due to files
disappearing mid-build or installations being inconsistent, and
excessive numbers of emails are generated. To top this off, everyone
has to use the same underlying "base" system for performing builds
which sets up conflicts between projects. Oh, and we also only perform
CI for Linux.

To solve these problems we've been working on a Next Generation CI
system which introduces a new concept called 'Products'. In short, a
Product is a release unit, such as Frameworks, Plasma, KDE
Applications, which groups a series of repositories which are
developed and subsequently released together.

A preview of this system can be viewed at https://build-sandbox.kde.org/

Products as part of their definition are able to define a set of
'Platforms' on which they build. At the moment we have three Platforms
available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
Adding additional Platforms to this mix is fairly easy, as long as the
code can be built there. Qt will now be considered as part of the base
system, and is something we will no longer build ourselves.

Each Product / Platform definition is fully independent. This will
allow for different products to build against different versions of Qt
among other things for instance.

This is the first part that requires your action: we'd like
developers, particularly those whose development relies on bleeding
edge system software to assist in creating and maintaining (Linux)
Platform images. If you're interested in this, please let me know.

As part of the shift to the Products paradigm, a number of changes
have been made to how projects are built and dependencies managed.
This particularly affects dependencies on projects which are outside
your Product (Frameworks is outside of Plasma and Applications for
instance). These dependencies will now be satisfied through
"Dependency Build" jobs, which will be executed once a week. As a
result the master version of Frameworks will no longer be available
outside Frameworks itself.

This change is one of the big ones which massively reduces the effort
required to change base systems and thus hugely improves the
maintainability of the CI system. It is therefore quite important and
necessary, and also isolates the rest of the CI system from breakages
lower down in the stack which have happened in the past.

This is the second point that requires your attention. If your
development process is dependent on using the latest development
version of something which is located in another product, then we will
need to add that to your Product. If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines of explaination for each.

Note that requests for the entirety of Frameworks won't be accepted -
each must be requested on an individual basis with an explanation
given for why your development process is dependent on the master
version of that Framework.

With the change to Products as a core concept for driving the CI
system, this does leave Extragear somewhat in a bit of an unusual
situation. At the moment we're planning to deal with this by having
Extragear be a 'Product' with all of them combined together. If anyone
in Extragear has any comments to make on this they're certainly
welcome here.

Which brings me to the third point of attention. We'll only be adding
projects to the Next Gen CI system at their request going forward. For
Frameworks, Applications and Plasma this is something which we're
essentially assuming we're going to receive from their release
managers, so we'll take care of defining the initial Products for
those. For Extragear projects, please respond to this thread if you'd
like CI coverage (to continue) to be provided to you.

Thanks for all who have reached this point - my apologies again for
it's length.

Note that the Next Gen system isn't finished yet - Notifications are
yet to be setup and there are a few other touches left to be made.

Regards,
Ben Cooksley
KDE Sysadmin

D5620: Adding an option to show popular documents/apps for Kickoff

[Eike Hein]

hein added a comment.


  Sounds good to me ... bit worried about people missing their history though, 
we might get some angry feedback.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5620

To: ivan, hein, mart, sebas
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5649: Remove unused dependencies.

[Michael Palimaka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R258:1d7e4cc7c7be: Remove unused dependencies. (authored by 
palimaka).

REPOSITORY
  R258 Plymouth KCM

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5649?vs=13956=14185

REVISION DETAIL
  https://phabricator.kde.org/D5649

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: palimaka, #plasma, mart
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5620: Adding an option to show popular documents/apps for Kickoff

[Marco Martin]

mart added a comment.


  yes, the idea is to have only the popular documents tab by default in 5.11, 
then the history one can still be manualy enabled by the user

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5620

To: ivan, hein, mart, sebas
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R130:34fc30c4f7ca: Cleanup wayland resources used in 
kwindowsystem before they're deleted by QPA (authored by davidedmundson).

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5723?vs=14180=14184

REVISION DETAIL
  https://phabricator.kde.org/D5723

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: davidedmundson, #plasma, graesslin
Cc: graesslin, cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5726: Fix regression for timestamp handling for Xwayland windows

[Thomas Lübking]

luebking added a comment.


  0L is XCB_CURRENT_TIME iow "kinda invalid", so it's sane to block that in 
setX11Time()
  
  Also: a conditional early return? In a four line function? Really? ;-P

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5726

To: graesslin, #kwin, #plasma
Cc: luebking, plasma-devel, kwin, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas