Jenkins-kde-ci: plasma-workspace Plasma-5.10 stable-kf5-qt5 » Linux,gcc - Build # 3 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.10%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 13 May 2017 04:00:22 +
Build duration: 6.5 sec

CHANGE SET
Revision dcdb9e3323aecd715e08a16d6aa03488d9df6af2 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/appstream/appstreamrunner.desktop

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 888 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/888/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 13 May 2017 02:37:39 +
Build duration: 16 min

CHANGE SET
Revision 5324f52ea789f80bddbf164d2f56ce3a544c4e97 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/appstream/appstreamrunner.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 15/15 (100%)FILES 55/76 (72%)CLASSES 55/76 (72%)LINE 2348/6022 
(39%)CONDITIONAL 1657/6004 (28%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 110/144 (76%)CONDITIONAL 
56/90 (62%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 84/84 (100%)CONDITIONAL 
37/72 (51%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 262/390 
(67%)CONDITIONAL 114/216 (53%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 636/699 (91%)CONDITIONAL 
381/828 (46%)
libtaskmanager
FILES 6/21 (29%)CLASSES 6/21 (29%)LINE 196/3341 (6%)CONDITIONAL 
122/3295 (4%)
libtaskmanager.autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 151/151 
(100%)CONDITIONAL 85/170 (50%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 87/157 (55%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)
runners.services
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 128/201 (64%)CONDITIONAL 
117/206 (57%)
runners.services.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 67/70 (96%)CONDITIONAL 
50/90 (56%)
shell
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 57/90 (63%)CONDITIONAL 
20/76 (26%)
shell.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 40/40 (100%)CONDITIONAL 
15/30 (50%)

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

[David Edmundson]

davidedmundson added a comment.


  > but now that it is all here already, let's just call this a prototype, for 
someone who knows C/kevent/kqueue to fix.
  
  So what doesn't work?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5818: Lift app identification heuristic out of XWindowTasksModel and share it with WaylandTasksModel.

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5818

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

[Tobias C. Berner]

tcberner retitled this revision from "Include signal.h for kill." to "Include 
signal.h for kill(), and prototype kqueue/kevent stuff... ".

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5825: Include signal.h for kill.

[Tobias C. Berner]

tcberner edited the summary of this revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5825

To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5825: Include signal.h for kill.

[Tobias C. Berner]

tcberner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  All there in the title.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5825

AFFECTED FILES
  CMakeLists.txt
  config-kscreenlocker.h.cmake
  greeter/authenticator.cpp
  kcheckpass/kcheckpass.c

To: tcberner, #freebsd, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5818: Lift app identification heuristic out of XWindowTasksModel and share it with WaylandTasksModel.

[Eike Hein]

hein updated this revision to Diff 14447.
hein added a comment.


  Add missing roles to dataChanged on pid changes.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5818?vs=14426=14447

BRANCH
  pid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5818

AFFECTED FILES
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5818: Lift app identification heuristic out of XWindowTasksModel and share it with WaylandTasksModel.

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> waylandtasksmodel.cpp:292
> +appDataCache.remove(window);
> +this->dataChanged(window, AppPid);
> +}

this could also cause the icon to change, who emits a signal for that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5818

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5806: When building menu hyerarchies, parent menus to their containers

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:b5af0296cb2f: When building menu hyerarchies, parent 
menus to their containers (authored by mart).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5806?vs=14384=14446

REVISION DETAIL
  https://phabricator.kde.org/D5806

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5806: When building menu hyerarchies, parent menus to their containers

[Marco Martin]

mart retitled this revision from "[WIP] when building menu hyerarchies, parent 
menus to their containers" to "When building menu hyerarchies, parent menus to 
their containers".

REPOSITORY
  R263 KXmlGui

BRANCH
  phab/reparentmenus

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=1=14445

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5806: [WIP] when building menu hyerarchies, parent menus to their containers

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  *hierarchy
  
  looks sensible. Add a comment in the code as to why we're doing this.

REPOSITORY
  R263 KXmlGui

BRANCH
  phab/reparentmenus

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[David Edmundson]

davidedmundson added a comment.


  don't keep [WIP} in the title though :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5773: [WIP] workarounds for menu positioning

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

mart updated this revision to Diff 1.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - remove duplication

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=14438=1

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

Re: D4997: Support for long running kcheckpass supporting multiple authentications

[Tobias C. Berner]

Hi

We could probably do something with kqueue/EVFILT_SIGNAL:
https://www.freebsd.org/cgi/man.cgi?query=kqueue=2

 EVFILT_SIGNAL Takes the signal number to monitor as the identifier
  and returns when the given signal is
delivered to the
 process.  This coexists with the signal() and
 sigaction() facilities, and has a
lower precedence.
 The filter will record all attempts
to deliver a sig-
 nal to a process, even if the signal
has been marked
 as SIG_IGN, except for the SIGCHLD
signal, which, if
 ignored, won't be recorded by the
filter.  Event
 notification happens after normal
signal delivery
 processing.  data returns the number
of times the
 signal has occurred since the last
call to kevent().
 This filter automatically sets the
EV_CLEAR flag
 internally.


-- kqueue should be supported on all other *BSD and OSX too.



mfg Tobias

On 12 May 2017 at 15:55, Martin Flöser  wrote:
> Am 2017-05-12 09:18, schrieb Tobias C. Berner:
>>
>> Hi there
>>
>> I think this review introduced some Linux-only features: signalfd() is
>> only present on Linux.
>> So this breaks kcheckpass on FreeBSD (and probably everything non-Linux
>> too).
>>
>> Would it be possible to have the long-running auth stuff hidden behind a
>>   check_include_file("sys/signalfd.h" HAVE_SIGNALFD_H)
>> check?
>
>
> Just confirming what David already wrote. The code is built around signalfd
> and without it kcheckpass is broken. Also in the non-long running kcheckpass
> case signalfd is used.
>
> At the moment I do not see a solution. Sorry for creating the problem, I did
> not expect that this is linux specific.
>
> As we are in feature freeze and this is security relevant code I don't
> really have an idea to move forward. Especially as it's pointless to have
> any linux dev work on this as we might just break it again. We are in low
> level c code in kcheckpass which is totally ugly and all designed for the
> case of running as setuid root.
>
> Cheers
> Martin
>
>
>>
>>
>> mfg Tobias
>>
>> On 19 April 2017 at 17:44, Martin Gräßlin 
>> wrote:
>>>
>>> This revision was automatically updated to reflect the committed changes.
>>> Closed by commit R133:07d38ba65adc: Support for long running kcheckpass
>>> supporting multiple authentications (authored by graesslin). View
>>> Revision
>>>
>>> REPOSITORY
>>> R133 KScreenLocker
>>>
>>> CHANGES SINCE LAST UPDATE
>>> https://phabricator.kde.org/D4997?vs=13188=13603
>>>
>>> REVISION DETAIL
>>> https://phabricator.kde.org/D4997
>>>
>>> AFFECTED FILES
>>> greeter/authenticator.cpp
>>> greeter/authenticator.h
>>> greeter/autotests/authenticatortest.cpp
>>> greeter/greeterapp.cpp
>>> kcheckpass/kcheckpass-enums.h
>>> kcheckpass/kcheckpass.c
>>> tests/kcheckpass_test.cpp
>>>
>>> To: graesslin, Plasma
>>> Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
>>> jensreuterberg, abetts, sebas, apol

D5747: add pid to plasma window management protocol

[Sebastian Kügler]

sebas updated this revision to Diff 14442.
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - Update docs: the pid is just set, but doesn't logically change
  - ws--

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5747?vs=14418=14442

BRANCH
  sebas/processid

REVISION DETAIL
  https://phabricator.kde.org/D5747

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
hein, lukas

D5747: add pid to plasma window management protocol

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> plasmawindowmodel.cpp:84
>  
> +
>  QObject::connect(window, ::activeChanged, q,

Unrelated newline

> plasma-window-management.xml:263
> +  
> +This event will be sent when the process id of the application 
> owning the window has changed.
> +The pid will initially be 0, meaning it hasn't been set. As the 
> compositor sets it, the client

The pid will never change.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5747

To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on 
gtk >=3.20 (authored by rikmills).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5128?vs=12678=14441

REVISION DETAIL
  https://phabricator.kde.org/D5128

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: rikmills, #plasma, davidedmundson
Cc: davidedmundson, elvisangelaccio, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> qmenu.cpp:117
> +m_menu->windowHandle()->setTransientParent(item->window());
> +}
>  }

we always do this in ::open()

so why have this chunk?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5773

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

mart updated this revision to Diff 14438.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - more aggressive reparenting in open()

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=14311=14438

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5743: Fix deprecation warnings. setSelection -> setSelectedUrl ui -> uiDelegate

[Martin Flöser]

graesslin accepted this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix_deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5743

To: markg, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

[Martin Flöser]

graesslin added a comment.


  Your tests in plasma window management do not test the new requests.

INLINE COMMENTS

> test_wayland_windowmanagement.cpp:483
> +using namespace KWayland::Server;
> +// this test verifies setting the showing desktop state
> +QVERIFY(!m_window->isKeepAbove());

copy and paste error

> test_wayland_windowmanagement.cpp:505
> +using namespace KWayland::Server;
> +// this test verifies setting the showing desktop state
> +QVERIFY(!m_window->isKeepBelow());

copy and paste error

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5743: Fix deprecation warnings. setSelection -> setSelectedUrl ui -> uiDelegate

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix_deprecations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5743

To: markg, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5742: Replace Q_DECL_OVERRIDE with override.

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  cpp11_override (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5742

To: markg, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5748: workaround for correct wayland positioning

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> view.cpp:237
> +if (!s) {
> +return PlasmaQuick::Dialog::event(event);
>  }

return retval.

otherwise you're processsing it twice.

> view.cpp:248
> +//positionOnScreen tried to position it in the position it 
> already had, so no moveevent happens and we need to manually posiyion the 
> surface
> +m_plasmaShellSurface->setPosition(position());
>  }

When we get here we've already run Dialog::event()

won't that have already done the positioning?

There's a virtual geometry method in dialog to allow krunner and such to be 
different

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5748

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5745: recreate plasmashellsurf on exposed, destoy on hidden

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy 
on hidden (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5745?vs=14435=14436

REVISION DETAIL
  https://phabricator.kde.org/D5745

AFFECTED FILES
  src/declarativeimports/core/tooltipdialog.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5745: recreate plasmashellsurf on exposed, destoy on hidden

[Marco Martin]

mart updated this revision to Diff 14435.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  comments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5745?vs=14247=14435

BRANCH
  arcpatch-D5745

REVISION DETAIL
  https://phabricator.kde.org/D5745

AFFECTED FILES
  src/declarativeimports/core/tooltipdialog.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5745: recreate plasmashellsurf on exposed, destoy on hidden

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  some code comments would be good.
  you can copy update https://phabricator.kde.org/T6064

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/recreateshell

REVISION DETAIL
  https://phabricator.kde.org/D5745

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5747: add pid to plasma window management protocol

[Eike Hein]

hein accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5747

To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5807: Update required KF5 and Kirigami dependencies

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5807

To: heikobecker, #plasma, mart, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Plasma 5.10 branch too. Do you have commit access?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma, davidedmundson
Cc: davidedmundson, elvisangelaccio, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: D4997: Support for long running kcheckpass supporting multiple authentications

[Martin Flöser]

Am 2017-05-12 09:18, schrieb Tobias C. Berner:

Hi there

I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux 
too).


Would it be possible to have the long-running auth stuff hidden behind 
a

  check_include_file("sys/signalfd.h" HAVE_SIGNALFD_H)
check?


Just confirming what David already wrote. The code is built around 
signalfd and without it kcheckpass is broken. Also in the non-long 
running kcheckpass case signalfd is used.


At the moment I do not see a solution. Sorry for creating the problem, I 
did not expect that this is linux specific.


As we are in feature freeze and this is security relevant code I don't 
really have an idea to move forward. Especially as it's pointless to 
have any linux dev work on this as we might just break it again. We are 
in low level c code in kcheckpass which is totally ugly and all designed 
for the case of running as setuid root.


Cheers
Martin




mfg Tobias

On 19 April 2017 at 17:44, Martin Gräßlin  
wrote:
This revision was automatically updated to reflect the committed 
changes.
Closed by commit R133:07d38ba65adc: Support for long running 
kcheckpass
supporting multiple authentications (authored by graesslin). View 
Revision


REPOSITORY
R133 KScreenLocker

CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4997?vs=13188=13603

REVISION DETAIL
https://phabricator.kde.org/D4997

AFFECTED FILES
greeter/authenticator.cpp
greeter/authenticator.h
greeter/autotests/authenticatortest.cpp
greeter/greeterapp.cpp
kcheckpass/kcheckpass-enums.h
kcheckpass/kcheckpass.c
tests/kcheckpass_test.cpp

To: graesslin, Plasma
Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, 
ali-mohamed,

jensreuterberg, abetts, sebas, apol

D5729: #379003: Fix National Geographic POTD provider

[Juri Vitali]

vitali added a comment.


  So, what do we want to do with this patch?
  I've been using it for a week now, and didn't notice any problems. Has anyone 
else been testing it?
  
  As for the link, I am for keeping the http version, as it is the one used by 
NatGeo, so it would be less likely to be broken in the near future. If and when 
they will move to TLS it should be their responsibility to issue the right 
redirect.
  Anyway, any decision will be fine for me, as long as it works.
  
  Lastly, any opinion on the regex?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5729

To: vitali, sebas
Cc: Zren, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

RE: Next Gen CI - frameworks requirements for plasma

[David Edmundson]

Following up from Ben's email where we won't have master of frameworks in
buidling master of Plasma.

> If this affects you, please start a
new thread (CC'ing sysadmin and kde-core-devel along with your
Product's main list) stating which specific repositories you need and
providing one to two lines of explaination for each.

> Note that requests for the entirety of Frameworks won't be accepted -
each must be requested on an individual basis with an explanation
given for why your development process is dependent on the master
version of that Framework.

plasma-desktop will need master of:
 - plasma-framework

plasma-workspace will need master of:
 - plasma-framework
 - kwayland

kdeplasma-addons will need master of:
 - plasma-framework

plasma-sdk will need master of:
 - plasma-framework

plasma-integration will need master of:
 - kwayland

kwayland-integration will need master of:
 - kwayland

Also related: There's a dependency on newish kirigami in discover.

There's an incredibly tight coupling between plasma and plasma-framework.
#ifdef, even ignoring the problems that brings, isn't an option as most the
changes are new properties/classes in QML imports where it's used without
a preprocessor. This really affects anywhere with a Plasma applet (the
first 4)

KWayland is still very much a dynamic area  as it's a high paced area.  It
gets new APIs for every new protocol, and we'll be making a new protocol
because we're using it somewhere.

David

Re: Next Gen CI: framework dependencies for KWin

[Ben Cooksley]

On Sun, May 7, 2017 at 4:55 AM, Martin Flöser  wrote:
> Am 2017-05-06 11:37, schrieb Ben Cooksley:
>>

Hi Martin,

>> This is the second point that requires your attention. If your
>> development process is dependent on using the latest development
>> version of something which is located in another product, then we will
>> need to add that to your Product. If this affects you, please start a
>> new thread (CC'ing sysadmin and kde-core-devel along with your
>> Product's main list) stating which specific repositories you need and
>> providing one to two lines of explaination for each.
>
>
> My requests for KWin:
>  * KWindowSystem
>  * KWayland
>  * (optionally KGlobalAccel)
>  * (optionally Plasma)
>
> Reasoning:
> KWindowSystem implements the X11 side of the Window Manager. This is mostly
> the NETWM classes. Normally a change in KWindowSystem is always triggered by
> a change in KWin.
> Example from changes I implemented:
> b7bd5f9a09cb3874532269838b53f03c800d8a44 in KWin and
> e333a13fc52c28aac3c0d28cd5b85e16428fcff7 in KWindowSystem
>
> KWayland implements the server side of a Wayland compositor. Changes in
> KWayland are mostly triggered by the needs of KWin.
> Example from changes I implemented:
> 1193b0da771a5d1042bf2aed0a2727f89ddf488e in KWin and
> 6c89a61d2d17e1703b961566133cc5f46516b5a1 in KWayland

That sounds fair enough - i've granted both of those now in
https://commits.kde.org/sysadmin/ci-tooling/49c036bb4efb27d9c41b0619b975e1af55c55bd5

>
> On Wayland KWin provides the runtime part of KGlobalAccel and therefore
> needs to interact with the library. As in the other cases changes are
> normally triggered from KWin, but over the last years changes were very
> seldom. Thus I don't think we absolutely need it. Given that it's not tier 1
> I wouldn't be sad if I get a no here.
>
> Similar for Plasma: it's a library KWin (indirectly) uses and sometimes
> changes are needed. But it's very seldom that a change is triggered by KWin.

As these are infrequent items we can trigger rebuilds of the full
"Dependency Build" job where this becomes needed (it doesn't have to
wait for a week to go by). I've therefore not added those to the
Plasma product.

>
> Cheers
> Martin

Cheers,
Ben

Re: D4997: Support for long running kcheckpass supporting multiple authentications

[David Edmundson]

On Fri, May 12, 2017 at 9:18 AM, Tobias C. Berner 
wrote:

> Hi there
>
> I think this review introduced some Linux-only features: signalfd() is
> only present on Linux.
> So this breaks kcheckpass on FreeBSD (and probably everything non-Linux
> too).
>
> Would it be possible to have the long-running auth stuff hidden behind a
>   check_include_file("sys/signalfd.h" HAVE_SIGNALFD_H)
> check?
>
>
> Not  reallly. It'd compile, but then not work, which is almost worse.
Is there no BSD equivalent?

Worst case it looks like we could maybe replace it with classic unix
signals on the process.

David

[Powerdevil] [Bug 379740] Build fails with CLang

[Bhushan Shah]

https://bugs.kde.org/show_bug.cgi?id=379740

Bhushan Shah  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pow
   ||erdevil/3c17ba7612797d5b6ee
   ||86ac023991d5592fbca1a
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Bhushan Shah  ---
Git commit 3c17ba7612797d5b6ee86ac023991d5592fbca1a by Bhushan Shah.
Committed on 12/05/2017 at 08:47.
Pushed by bshah into branch 'Plasma/5.10'.

Use old style connect syntax

Otherwise it breaks build on some compilers like clang

M  +1-1kcmodule/global/GeneralPage.cpp

https://commits.kde.org/powerdevil/3c17ba7612797d5b6ee86ac023991d5592fbca1a

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: D4997: Support for long running kcheckpass supporting multiple authentications

[Tobias C. Berner]

Hi there

I think this review introduced some Linux-only features: signalfd() is
only present on Linux.
So this breaks kcheckpass on FreeBSD (and probably everything non-Linux too).

Would it be possible to have the long-running auth stuff hidden behind a
  check_include_file("sys/signalfd.h" HAVE_SIGNALFD_H)
check?


mfg Tobias

On 19 April 2017 at 17:44, Martin Gräßlin  wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit R133:07d38ba65adc: Support for long running kcheckpass
> supporting multiple authentications (authored by graesslin). View Revision
>
> REPOSITORY
> R133 KScreenLocker
>
> CHANGES SINCE LAST UPDATE
> https://phabricator.kde.org/D4997?vs=13188=13603
>
> REVISION DETAIL
> https://phabricator.kde.org/D4997
>
> AFFECTED FILES
> greeter/authenticator.cpp
> greeter/authenticator.h
> greeter/autotests/authenticatortest.cpp
> greeter/greeterapp.cpp
> kcheckpass/kcheckpass-enums.h
> kcheckpass/kcheckpass.c
> tests/kcheckpass_test.cpp
>
> To: graesslin, Plasma
> Cc: subdiff, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
> jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 379740] Build fails with CLang

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=379740

Christophe Giboudeaux  changed:

   What|Removed |Added

 CC||j...@jriddell.org

--- Comment #1 from Christophe Giboudeaux  ---
Jonathan, this code is also in the plasma release (and  Kai Uwe Broulik is on
vacation)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 379740] New: Build fails with CLang

[Christophe Giboudeaux]

https://bugs.kde.org/show_bug.cgi?id=379740

Bug ID: 379740
   Summary: Build fails with CLang
   Product: Powerdevil
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: christo...@krop.fr
  Target Milestone: ---

/kde/src/5/powerdevil/kcmodule/global/GeneralPage.cpp:127:111: error: 'changed'
is a protected member of 'KCModule'
connect(pausePlayersCheckBox, ::stateChanged, this,
static_cast(::changed));
   
~~^~~
/kde/inst/5/include/KF5/KConfigWidgets/kcmodule.h:375:10: note: must name
member using the type of the current context 'GeneralPage'
void changed();
 ^

-- 
You are receiving this mail because:
You are the assignee for the bug.