D5850: Fix duplicate Discover entry on the Application Menu

2017-05-14 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:13d96d15a177: Fix duplicate Discover entry on the 
Application Menu (authored by arojas).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5850?vs=14504=14528

REVISION DETAIL
  https://phabricator.kde.org/D5850

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/org.kde.discover-flatpak.desktop

To: arojas, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5850: Fix duplicate Discover entry on the Application Menu

2017-05-14 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5850

To: arojas, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Build issue of KWin in TumbleWeed

2017-05-14 Thread Michail Vourlakos 



On 14/05/2017 09:23 μμ, Luca Beltrame wrote:

In data domenica 14 maggio 2017 20:06:37 CEST, Michail Vourlakos ha scritto:


Even though the xkbcommon (0.7.1) packages are installed (and devel
package also) from main repo

You will need libxkbcommon-x11-devel and libxkbcommon-devel installed.  Are
they both present?

yes, they are both present


You can also use "zypper si -d kwin5" and you'll get all the build
dependencies installed.

the command shows:
"Nothing to do."


(For the future, you may want to use opensuse-...@opensuse.org, as this is a
distro-specific issue).


ok, I will forward the issue there...

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-14 Thread Sergey 
https://bugs.kde.org/show_bug.cgi?id=376344

Sergey  changed:

   What|Removed |Added

 CC||rion...@gmail.com

--- Comment #22 from Sergey  ---
Just faced the same bug, but workaround from @tempel.julian does not work well.
I finally have write access to my Windows share (requires auth) but if I create
with dolphin a subdirectory I can't open it. It requires authentication again
but this time the same login/password do not work anymore.

Another glitch. If I don't use *:* for auth but just smb://host/share and login
via popup dialog, then I create a subdirctory in cifs mounted directory for the
same share,  I can open the new subdirectory with Dolphin, but again no write
access inside. But if I write a few files from console (the same mounted cifs)
to the subdirectory I magically obtain the write access from Dolphin.

I also tested with "mount cifs" and it works in all circumstances where dolphin
fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Build issue of KWin in TumbleWeed

2017-05-14 Thread Luca Beltrame 
In data domenica 14 maggio 2017 20:06:37 CEST, Michail Vourlakos ha scritto:

> Even though the xkbcommon (0.7.1) packages are installed (and devel
> package also) from main repo

You will need libxkbcommon-x11-devel and libxkbcommon-devel installed.  Are 
they both present?

You can also use "zypper si -d kwin5" and you'll get all the build 
dependencies installed.

(For the future, you may want to use opensuse-...@opensuse.org, as this is a 
distro-specific issue).

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

Build issue of KWin in TumbleWeed

2017-05-14 Thread Michail Vourlakos 

Hello,

I am trying to build plasma-desktop with kdesrc-build in Tumbleweed. In 
general, most of the dependencies needed was found but I have the 
following issue with KWin.


Even though the xkbcommon (0.7.1) packages are installed (and devel 
package also) from main repo


kwin stops in the cmake step with:


-

-- The following REQUIRED packages have not been found:

 * XKB (required version >= 0.7.0) , XKB API common to servers and 
clients. , 

   Required for building KWin with Wayland support

-

any ideas,
regards,

michail

Plasma Vault

2017-05-14 Thread Jonathan Riddell 
How do I get Plasma Vault to do anything? I've compiled it and the
Plasmoid has a button saying Create a new vault and nothing else.
Clicking it does nothing.  I was told I had to install encfs but
installing that doesn't help


Jonathan

D5851: Fix the PID updated in PlasmaWindowedModel

2017-05-14 Thread Martin Flöser 
graesslin added a comment.


  In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote:
  
  > It makes absolutely no sense to have a pidChanged signal and then say 
clients shouldn't be using it.
  >
  > Either window has no reason to have a pidChanged signal or we should 
connect to it. It has to be one or the other.
  
  
  Right, the signal shouldn't exist. I overlooked that in the other review. 
Sorry. I pointed it out in two cases and missed the third. The signal should be 
removed IMHO.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5851

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-14 Thread Andreas Sturmlechner 
asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  GTK will search /usr/share/themes//gtk- and then earlier
  versions all the way back to 3.0.
  
  See also:
  
https://developer.gnome.org/gtk3/stable/GtkCssProvider.html#GtkCssProvider.description

TEST PLAN
  breeze-gtk installs gtk-3.x dirs to the expected location.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5853

AFFECTED FILES
  Breeze-dark-gtk/CMakeLists.txt
  Breeze-gtk/CMakeLists.txt
  CMakeLists.txt

To: asturmlechner, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

2017-05-14 Thread Alex Bikadorov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129851/#review103212
---



FYI: https://bugs.kde.org/show_bug.cgi?id=379817

- Alex Bikadorov


On Jan. 19, 2017, 1:06 p.m., Alexander Volkov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129851/
> ---
> 
> (Updated Jan. 19, 2017, 1:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> QImageReader::setScaledSize() allows to use fast downscaling
> for jpeg images (by setting jpeg_decompress_struct::scale_denom).
> QImageReader::setQuality(0) sets dct_method to JDCT_IFAST and
> do_fancy_upsampling to FALSE, although these parameters don't
> really influence on decoding speed, also as do_block_smoothing
> which is not used by Qt.
> 
> QImageReader::setAutoTransform() allows to apply the rotation
> from EXIF data. It was introduced in Qt 5.5, so bump the
> required Qt version.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt be305274984321b93e05feeeb6d09490b33a43cc 
>   thumbnail/CMakeLists.txt 92eb3c7ae98660eb00e33fbe608de1580ea75912 
>   thumbnail/jpegcreator.h 5cab30ff6a0881863ec66d739063f6dbfb4a48f7 
>   thumbnail/jpegcreator.cpp 9191fbacd21c65c9fc845fd7c77365005cd8df00 
> 
> Diff: https://git.reviewboard.kde.org/r/129851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Volkov
> 
>

[kio-extras] [Bug 379817] New: Behaviour change: JPEG image preview scaled to widget size

2017-05-14 Thread Alex Bikadorov 
https://bugs.kde.org/show_bug.cgi?id=379817

Bug ID: 379817
   Summary: Behaviour change: JPEG image preview scaled to widget
size
   Product: kio-extras
   Version: unspecified
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: default
  Assignee: plasma-devel@kde.org
  Reporter: alex.bikado...@kdemail.net
  Target Milestone: ---

Created attachment 105528
  --> https://bugs.kde.org/attachment.cgi?id=105528=edit
Dolphin JPEG image preview

Preview images in KImageFilePreview for JPEG files are always scaled to the
widget size - no matter how how small the jpeg is. PNGs are not scaled. Dolphin
and Krusader are affected. See screenshot.

I tracked it down to thumbnail/jpegcreator and its maybe caused by
https://git.reviewboard.kde.org/r/129851/

Version:
KDE Frameworks 5.33.0
kio-extras 17.04.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5851: Fix the PID updated in PlasmaWindowedModel

2017-05-14 Thread David Edmundson 
davidedmundson added a comment.


  It makes absolutely no sense to have a pidChanged signal and then say clients 
shouldn't be using it.
  
  Either window has no reason to have a pidChanged signal or we should connect 
to it. It has to be one or the other.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5851

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5851: Fix the PID updated in PlasmaWindowedModel

2017-05-14 Thread Martin Flöser 
graesslin added inline comments.

INLINE COMMENTS

> plasmawindowmodel.cpp:84
>  
> +QObject::connect(window, ::pidChanged, q,
> +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }

In the original report I critized that we connect to a pid changed signal. That 
doesn't make any sense as a pid cannot change.

I think this is the wrong solution to the problem.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5851

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5851: Fix the PID updated in PlasmaWindowedModel

2017-05-14 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Fixes https://phabricator.kde.org/D5747

TEST PLAN
  Tests now pass

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5851

AFFECTED FILES
  src/client/plasmawindowmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas

D5850: Fix duplicate Discover entry on the Application Menu

2017-05-14 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Only one Discover entry is shown on the menu

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5850

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/org.kde.discover-flatpak.desktop

To: arojas, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5747: add pid to plasma window management protocol

2017-05-14 Thread Eike Hein 
hein added a comment.


  FWIW I did run make test on an earlier revision of the patch during the 
sprint while doing work on top of it; it must have regressed after.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5747

To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
hein, lukas