date:20170516

Re: Plasma 5.10 voice over text

2017-05-16 Thread Martin Gräßlin



Am 16. Mai 2017 23:25:11 MESZ schrieb "Łukasz Sawicki" :
>Hi,
>
>Here is a script/voice over text for Plasma 5.10 video. It is heavily
>based on Plasma 5.10 beta announcement. Please check it for grammar,
>typos etc.
>
>https://notes.kde.org/p/Plasma_5.10_script
>
>If you think that I missed something we should show in our upcoming
>promo video, please also put it there with some quick explanation.

I'm missing all the touch screen improvements like on screen keyboard in lock 
screen. Swipe from left edge for alt+tab etc.

Cheers
Martin

Re: Plasma 5.10 voice over text

2017-05-16 Thread David Edmundson

>Folder View is the default desktop  and allows users to put whatever files
or folders they want easy access to

This explains what it is, it doesn't explain what's changed since the last
release.
"Folder View is now the default desktop ..."

> Software Centre Plasma Search (KRunner) suggests to install non-installed
apps

That's confusing. Maybe try
The Plasma Search, Krunner, can now list non-installed applications in the
software centre.

D5886: Use QFormLayout for sliders

2017-05-16 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  well that's a billion times cleaner.

INLINE COMMENTS

> kgamma.cpp:243
> +form->addRow(gammalabel, gctrl);
> +form->addWidget(new QWidget); // extra spacing
> +form->addRow(redlabel, rgctrl);

look at addItem()

you can add a proper spacer that way.

REPOSITORY
  R100 KGamma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5886

To: volkov, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Plasma 5.10 voice over text

2017-05-16 Thread Łukasz Sawicki

Hi,

Here is a script/voice over text for Plasma 5.10 video. It is heavily
based on Plasma 5.10 beta announcement. Please check it for grammar,
typos etc.

https://notes.kde.org/p/Plasma_5.10_script

If you think that I missed something we should show in our upcoming
promo video, please also put it there with some quick explanation.

Cheers,

Łukasz Sawicki

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:92bf5a9828d1: Keep QIcon::fromTheme in main thread 
(authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5889?vs=14602=14611

REVISION DETAIL
  https://phabricator.kde.org/D5889

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Plasma Vault

2017-05-16 Thread Ivan Čukić

On Sun, May 14, 2017 at 06:28:10PM +0100, Jonathan Riddell wrote:
> How do I get Plasma Vault to do anything? I've compiled it and the
> Plasmoid has a button saying Create a new vault and nothing else.
> Clicking it does nothing.  I was told I had to install encfs but
> installing that doesn't help

Do you have the kded module running?

qdbus org.kde.kded5 /modules/plasmavault

Cheers,
Ivan

D5870: Match subsequences in application runner

2017-05-16 Thread Ronnie Thomas

rthomas updated this revision to Diff 14603.
rthomas added a comment.


  - Splitting the query using splitRef() instead of split()
  - Using QLatin1Char(' ') as the separator to split the query

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5870?vs=14559=14603

REVISION DETAIL
  https://phabricator.kde.org/D5870

AFFECTED FILES
  runners/services/servicerunner.cpp

To: rthomas, #plasma
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5870: Match subsequences in application runner

2017-05-16 Thread David Edmundson

davidedmundson added inline comments.

INLINE COMMENTS

> rthomas wrote in servicerunner.cpp:203
> Could you explain why would we want to use splitRef instead of split? I'm not 
> sure I understand the need for it.

split copies the strings.
splitRef creates references to a location within an exitsting string without 
copying it.

Result is the same but faster.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5870

To: rthomas, #plasma
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5870: Match subsequences in application runner

2017-05-16 Thread Ronnie Thomas

rthomas added inline comments.

INLINE COMMENTS

> apol wrote in servicerunner.cpp:101
> use a foreach

I'm skipping the first string in strList because that string has already been 
accounted for relavace right before the call to increaseMatchRelavance. 
Relevance is incremented by 0.01 only based on the second string onwards.  I 
don't think you can skip iterations based on indices in a foreach loop.

> apol wrote in servicerunner.cpp:203
> `splitRef(QLatin1Char(' '))`?

Could you explain why would we want to use splitRef instead of split? I'm not 
sure I understand the need for it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5870

To: rthomas, #plasma
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, lukas

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson

davidedmundson updated this revision to Diff 14602.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  simplify a line

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5889?vs=14601=14602

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5889

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5889: Keep QIcon::fromTheme in main thread

2017-05-16 Thread David Edmundson

davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  QIcon::fromTheme is not thread safe, we can't have it done in the future 
watcher.
  We can solve this by returning null in the watcher, and doing fromTheme in 
the main thread
  when the watcher finishes if we don't have an icon.
  
  (offtopic, I once made the obvious patch to Qt, but it was rejected with
  the response that QIcon isn't entirely thread safe, and that apparently
  meant none of it should be, which I don't fully agree with but whatever...)

TEST PLAN
  Current unit tests still pass

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5889

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas

[Powerdevil] [Bug 379858] Windows open too small

2017-05-16 Thread bugzilla_noreply

https://bugs.kde.org/show_bug.cgi?id=379858

--- Comment #2 from fr...@hmrt.nl ---
Ok, will do. But are you sure? It is happening with almost all apps in plasma.
Do they really all make the same mistake?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c4caf02a9d4b: Remove pid changedSignal in 
Client::PlasmaWindow (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5887?vs=14597=14599

REVISION DETAIL
  https://phabricator.kde.org/D5887

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread Martin Flöser

graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R127 KWayland

BRANCH
  asdfasdf

REVISION DETAIL
  https://phabricator.kde.org/D5887

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Martin Flöser

graesslin added a comment.


  In https://phabricator.kde.org/D5872#109962, @hein wrote:
  
  > I'm fine with no change signal, but heads-up that libtaskmanager has code 
connecting to it, so if you remove it from kwayland please also adapt 
plasma-workspace or the build breaks.
  
  
  I highly suggest to remove that. That signal doesn't work as there is no 
change going to happen. It's just pointless.
  
  Anyway I want a solution on this broken test ASAP. I don't have the time to 
code a fix for it, but I want KWayland to be green prior to me leaving to 
vacations. Just adding the changed signal to fix the test is not acceptable as 
that would mean we have an incorrect API added which we cannot remove till KF 6.
  
  If it has to be I'm going to revert the changes - even if it makes other 
software break compilation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, hein, lukas

D5888: Get rid of extra margins

2017-05-16 Thread Alexander Volkov

volkov added a reviewer: Plasma.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D5888

To: volkov, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5888: Get rid of extra margins

2017-05-16 Thread Alexander Volkov

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5888

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp

To: volkov
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5887: Remove pid changedSignal in Client::PlasmaWindow

2017-05-16 Thread David Edmundson

davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Verified it it send before the initial_state and adjust tests and docs 
accordingly

TEST PLAN
  All unit tests pass

REPOSITORY
  R127 KWayland

BRANCH
  asdfasdf

REVISION DETAIL
  https://phabricator.kde.org/D5887

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas

D5886: Use QFormLayout for sliders

2017-05-16 Thread Alexander Volkov

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QFormLayout is more natural for label/widget pairs and allows
  to have uniform label alignment in different styles.

REPOSITORY
  R100 KGamma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5886

AFFECTED FILES
  kcmkgamma/kgamma.cpp

To: volkov, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5853: Remove gtk+-3 build dep, install versioned gtk.css dirs unconditionally

2017-05-16 Thread Marco Martin

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D5853

To: asturmlechner, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5748: workaround for correct wayland positioning

2017-05-16 Thread David Edmundson

davidedmundson added a comment.


  Is it tested on X, Qt 5.7 as well as Qt 5.9
  
  If you want me to do any of those, just ask.

INLINE COMMENTS

> view.cpp:250
> +} else if (event->type() == QEvent::Hide) {
> +delete m_plasmaShellSurface;
>  } else if (m_plasmaShellSurface && event->type() == QEvent::Move) {

we need  m_plasmaShellSurface = nullptr;

this leaves a dangling pointer,  which is both dangerous but also means we 
won't re-create it in ExposeEvent, I would have assumed that would mean the 
second show won't work.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5748

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5885: Don't fix a height of sliders

2017-05-16 Thread Alexander Volkov

This revision was automatically updated to reflect the committed changes.
Closed by commit R100:160938ffb3f2: Don't fix a height of sliders (authored by 
volkov).

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5885?vs=14593=14594

REVISION DETAIL
  https://phabricator.kde.org/D5885

AFFECTED FILES
  kcmkgamma/gammactrl.cpp

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5885: Don't fix a height of sliders

2017-05-16 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R100 KGamma

BRANCH
  fix-sliders-height

REVISION DETAIL
  https://phabricator.kde.org/D5885

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5885: Don't fix a height of sliders

2017-05-16 Thread Alexander Volkov

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It's a bad practice to use magic constants in code, rely on a
  style instead.

REPOSITORY
  R100 KGamma

BRANCH
  fix-sliders-height

REVISION DETAIL
  https://phabricator.kde.org/D5885

AFFECTED FILES
  kcmkgamma/gammactrl.cpp

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov

This revision was automatically updated to reflect the committed changes.
Closed by commit R100:df98599155db: Fix spacing in "Select test picture:" row 
(authored by volkov).

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5882?vs=14585=14589

REVISION DETAIL
  https://phabricator.kde.org/D5882

AFFECTED FILES
  kcmkgamma/kgamma.cpp

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"

2017-05-16 Thread Elvis Angelaccio

elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Dolphin, Konqueror, plasma-devel.

REVISION SUMMARY
  This reverts commit 
https://phabricator.kde.org/R318:58c5eae1953bbdcf6d4150b21cb7ffdad07a5257.
  
  Reasons against this change:
  
  1. Scroll is now too fast with devices such as touchpads or trackpoints.
  2. Scroll behavior is now inconsistent between Dolphin and other applications 
(e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms.
  3. Many people complained and this feature is currently not configurable. We 
should introduce a QStyle::SH_Widget_Animation_Duration hint that would allow 
us to not hardcode durations in Dolphin (i.e. respect whatever duration the 
users set in their QStyle).

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/17.04

REVISION DETAIL
  https://phabricator.kde.org/D5883

AFFECTED FILES
  src/kitemviews/private/kitemlistsmoothscroller.cpp

To: elvisangelaccio, #vdg, #plasma, emmanuelp
Cc: plasma-devel, #konqueror, #dolphin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[Powerdevil] [Bug 379858] Windows open too small

2017-05-16 Thread Christoph Feck

https://bugs.kde.org/show_bug.cgi?id=379858

Christoph Feck  changed:

   What|Removed |Added

Version|5.34.0  |unspecified
   Assignee|notm...@gmail.com   |plasma-devel@kde.org
  Component|libplasma   |general
Product|frameworks-plasma   |Powerdevil

--- Comment #1 from Christoph Feck  ---
Please report these issues individually for each application or dialog.

Reassigning to powerdevil developers as per screen shot.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R100 KGamma

BRANCH
  fix-layout-spacing

REVISION DETAIL
  https://phabricator.kde.org/D5882

To: volkov, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov

volkov added a reviewer: Plasma.

REPOSITORY
  R100 KGamma

REVISION DETAIL
  https://phabricator.kde.org/D5882

To: volkov, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5882: Fix spacing in "Select test picture:" row

2017-05-16 Thread Alexander Volkov

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use QBoxLayout::addLayout() instead of QLayout::addItem()
  to add a child layout. It's more preferable and makes Qt use a
  correct spacing for the child layout.

REPOSITORY
  R100 KGamma

BRANCH
  fix-layout-spacing

REVISION DETAIL
  https://phabricator.kde.org/D5882

AFFECTED FILES
  kcmkgamma/kgamma.cpp

To: volkov
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov

This revision was automatically updated to reflect the committed changes.
Closed by commit R100:879e031097bd: Remove .png extension from icon name in the 
desktop file (authored by volkov).

REPOSITORY
  R100 KGamma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5881?vs=14583=14584

REVISION DETAIL
  https://phabricator.kde.org/D5881

AFFECTED FILES
  kcmkgamma/kgamma.desktop

To: volkov, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5527: add resize handles on all corners/sides

2017-05-16 Thread David Edmundson

davidedmundson added a comment.


  I do not appreciate having my major bugs ignored.
  
  I will be reverting this. 
  You can try again for 5.11.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5527

To: mart, #plasma, hein, broulik
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov

volkov added a comment.


  Oh, thanks for fast review.

REPOSITORY
  R100 KGamma

BRANCH
  fix-desktop

REVISION DETAIL
  https://phabricator.kde.org/D5881

To: volkov, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov

volkov added a reviewer: Plasma.

REPOSITORY
  R100 KGamma

BRANCH
  fix-desktop

REVISION DETAIL
  https://phabricator.kde.org/D5881

To: volkov, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread David Edmundson

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R100 KGamma

BRANCH
  fix-desktop

REVISION DETAIL
  https://phabricator.kde.org/D5881

To: volkov, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5881: Remove .png extension from icon name in the desktop file

2017-05-16 Thread Alexander Volkov

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R100 KGamma

BRANCH
  fix-desktop

REVISION DETAIL
  https://phabricator.kde.org/D5881

AFFECTED FILES
  kcmkgamma/kgamma.desktop

To: volkov
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Breeze Grub does not build

2017-05-16 Thread Harald Sitter

breeze-grub doesn't build anything. never did.

On Tue, May 16, 2017 at 11:20 AM, Ben Cooksley  wrote:
> Hi all,
>
> It seems Breeze Grub does not have a build system as such, and is
> therefore not buildable by the CI system.
>
> See 
> https://build-sandbox.kde.org/job/Plasma%20breeze-grub%20kf5-qt5%20SUSEQt5.9/
> for more details.
>
> Should it be marked as an inactive repository?
>
> Cheers,
> Ben

Breeze Grub does not build

2017-05-16 Thread Ben Cooksley

Hi all,

It seems Breeze Grub does not have a build system as such, and is
therefore not buildable by the CI system.

See 
https://build-sandbox.kde.org/job/Plasma%20breeze-grub%20kf5-qt5%20SUSEQt5.9/
for more details.

Should it be marked as an inactive repository?

Cheers,
Ben

Broken dependencies: plasma-vault

2017-05-16 Thread Ben Cooksley

Hi all,

When someone gets a chance can they please correct the dependency
metadata in kde-build-metadata for Plasma Vault?

See 
https://build-sandbox.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20SUSEQt5.9/2/console
for more details.

Thanks,
Ben

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Eike Hein

hein added a comment.


  No, I don't. libtaskmanager doesn't use PlasmaWindowModel, it uses 
PlasmaWindow.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, hein, lukas

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread David Edmundson

davidedmundson added a comment.


  No you don't.
  You connect via QAIM;: dataChanged which is still there.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, hein, lukas

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin

mart updated this revision to Diff 14582.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - fix comment

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5757?vs=14581=14582

BRANCH
  arcpatch-D5757

REVISION DETAIL
  https://phabricator.kde.org/D5757

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin

mart marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

2017-05-16 Thread Marco Martin

mart updated this revision to Diff 14581.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - fix comment

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5757?vs=14320=14581

BRANCH
  arcpatch-D5757

REVISION DETAIL
  https://phabricator.kde.org/D5757

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Eike Hein

hein added a comment.


  I'm fine with no change signal, but heads-up that libtaskmanager has code 
connecting to it, so if you remove it from kwayland please also adapt 
plasma-workspace or the build breaks.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, hein, lukas

D5872: pidChanged also signals dataChanged in WindowModel

2017-05-16 Thread Martin Flöser

graesslin added a comment.


  like David explained: we don't need the change signal and IMHO we shouldn't 
expose "wrong API". I consider having a changed signal for a PID wrong API as 
it indicates that the PID could change. But it won't ever change, so we 
shouldn't expose it. I know that all other attributes have a changed signal, 
but they can change.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, hein, lukas

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

2017-05-16 Thread Martin Flöser

graesslin added a comment.


  In https://phabricator.kde.org/D5756#109957, @hein wrote:
  
  > What was the regression? (I'm aware of a failing unit test, but since the 
unit test itself was new, it was obviously not a regression.)
  
  
  The regression is the fact that kwayland was green and now is yellow on CI. 
To me this is a regression.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5756

To: hein, #plasma, sebas, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

47 matches

Mail list logo