D5914: Add template for Plasma QML Applet with QML extension

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Get created template bundle here: 
https://share.kde.org/index.php/s/eHJGEku7pw7DotV

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5914

To: kossebau, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5914: Add template for Plasma QML Applet with QML extension

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Should help people to kick-off plasmoids which also
  use custom QML classes.

TEST PLAN
  Created new plasmoid from template using kdevelop.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addtemplateforplasmoidwithqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D5914

AFFECTED FILES
  templates/CMakeLists.txt
  templates/qml-plasmoid-with-qml-extension/CMakeLists.txt
  templates/qml-plasmoid-with-qml-extension/Messages.sh
  templates/qml-plasmoid-with-qml-extension/README
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid-with-qml-extension/plugin/CMakeLists.txt
  templates/qml-plasmoid-with-qml-extension/plugin/qmldir
  
templates/qml-plasmoid-with-qml-extension/qml-plasmoid-with-qml-extension.kdevtemplate

To: kossebau, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5913: Fix fifteen puzzle solveability

[Igor Poboiko]

poboiko created this revision.
poboiko added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Thus fixes bug 358940 : fifteen 
puzzle often appears unsolveable.
  There were two issues.
  
  1. Floating point division when determining the row with blank tile (blankRow 
= 2.75 seems weird).
  2. Even after fixing the first issue, applet didn't want to confirm that I've 
solved the puzzle. Seems like corresponding check was wrong: indeed, if one has 
solved 4x4 board (size=16, so pieces[i] = {1,2,...,15,0}), comparison with i=15 
corresponds to 15>0, which is always true.
  
  Clearly, to check if 15 numbers are ordered, one needs 14 (size-2) comparison 
operations.

TEST PLAN
  Played puzzle ~10 times with sizes 2x2, 3x3 and 4x4. 
  Not a single one appeared unsolveable, and after solving it applet confirmed 
I've done it correctly.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D5913

AFFECTED FILES
  applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml

To: poboiko, #plasma
Cc: plasma-devel, davidedmundson, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in dialog.cpp:864
> I don't understand your description of the problem.
> 
> this call both that resizes and moves.
> but if the item hasn't changed yet, it shouldn't actually resize anything.
> 
> you're implying it does. Why?

- setMainItem -> the main item will change, the Layout attached property too 
(or get null, or go from null from something)
- syncToMainItemSize -> resizes the dialog to the main item size, which may or 
may not be currently in a size between the minimum/maximum hints bounds
- updateLayoutParameters finally resizes it into bounds if it wasn't, so, one 
resize too much

actually, seems to still be one too much, down from two too much, as sometimes 
seems the layout will adjust its size hints only a while after the qquickitem 
has been actually drawn, which makes this last one a bit hard to remove

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezeshadowhelper.cpp:177
> +QWidget* widget( static_cast( object ) );
> +if( event->type() == QEvent::Paint && ( 
> !_widgets.contains(widget) || _widgets.value(widget) == 0 ) )
> +{

Also, instead of using first "contains" then .value, one should really use an 
iterator (to avoid parsing the map twice):

auto&& iter = _widgets.find( widget );
if( iter == _widgets.end() || iter.value() == 0 )

Something like that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> dialog.cpp:864
>  if (d->mainItem) {
>  d->syncToMainItemSize();
>  }

I don't understand your description of the problem.

this call both that resizes and moves.
but if the item hasn't changed yet, it shouldn't actually resize anything.

you're implying it does. Why?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  take into account size hints also when adjusting with synctomainitemsize
  which sometimes has to be executed right before adjusting from the layout
  hints, giving one wrong resize
  
  introduce geometryUpdatesBlocked, which stops the dialog
  from syncing which is useful when both visual parent and item
  contents gets updated in one go (the tooltip) it is not
  yet exported to qml and it shouldn't as is dangerous, but
  kicker may make use of it between changing the submenu model and
  the visualparent
  
  alternative implementations may be:
  
  - a method that takes both main item and visual parent
  - delaying with a timer setGeometry (ouch)
  
  this part can also be left behind for now and see if the rest is good enough

TEST PLAN
  no visual glitches visible anymore in wayland when moving the tooltip
  in the taskbar, x11 ok too

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/dialogresize

REVISION DETAIL
  https://phabricator.kde.org/D5912

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialog.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> breezeshadowhelper.cpp:174
>  {
> +if( Helper::isWayland() )
> +{

We make check on every event for what we know what it is, does it better to use 
polymorphic helper?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

[David Edmundson]

davidedmundson added a comment.


  We're going to be leaking both Surface and Shadow objects in 
installWaylandFilter, no?

INLINE COMMENTS

> breezeshadowhelper.cpp:177
> +QWidget* widget( static_cast( object ) );
> +if( event->type() == QEvent::Paint && ( 
> !_widgets.contains(widget) || _widgets.value(widget) == 0 ) )
> +{

we use Expose everywhere else, why not here? It gets called a lot less

> breezeshadowhelper.cpp:185
> +{
> +_widgets.insert( widget, 0 );
> +}

why not just remove the widget from the list?

> breezeshadowhelper.cpp:464
>  using namespace KWayland::Client;
>  auto s = Surface::fromWindow( widget->windowHandle() );
>  if( !s ) return false;

this is currently leaking?

fromWindow constructs a new QObject

> breezeshadowhelper.cpp:467
>  
>  auto shadow = _shadowManager->createShadow( s, widget );
>  if( !shadow->isValid() ) return false;

this is going to be effectively leaking. on a show/hide/show we'll get now have 
two of these in memory, just one not attached to anything.

> breezeshadowhelper.cpp:482
>  shadow->commit();
>  s->commit( Surface::CommitFlag::None );
>  

off topic, but why do we have a commit on the surface? We haven't changed the 
surface, just attaced something to it.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

[Marco Martin]

mart added a reviewer: hpereiradacosta.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

[Marco Martin]

mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  since from Qt 5.8 QtWayland destroys its surfaces every time
  a window gets hidden and recreates them again when is shown
  (that's how the protocol is defined) install the shadows
  every time the window is shown, use the window id in _widgets
  to track creation/destruction of the surface

TEST PLAN
  popup menus have correct shadows on wayland now

REPOSITORY
  R31 Breeze

BRANCH
  phab/waylandshadow

REVISION DETAIL
  https://phabricator.kde.org/D5910

AFFECTED FILES
  kstyle/breezeshadowhelper.cpp

To: mart, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5868: make pagerow test pass

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Tested, it's definitely better.

REPOSITORY
  R169 Kirigami

BRANCH
  phab/pagerowtest

REVISION DETAIL
  https://phabricator.kde.org/D5868

To: mart, #kirigami, apol
Cc: plasma-devel, apol

Re: [wayland] some findings about weird shadows in wayland

[Marco Martin]

On Wednesday 17 May 2017 15:11:05 David Edmundson wrote:
> There was a potentially relevant change in plasma-integration last night.
> Make sure you have that before spending longer on it.
> 
> I don't have this issue on my tooltips hovering over the plasmoids in the
> panel.
> Do you have it reproducible on any of the manual dialog tests in
> plasma-framework?

indeed after that patch in plasma-integration tooltips and popup menus seem to 
have a correct shadow. so the wrong size in toplevel seems to be fixed by that.

positioning of plasma tooltips still seems to be a bit wonky 
(there are still too many intermediate setgeometry indeed, i guess x11 being 
async discarded enough of them to make it look better, that's something to fix 
in dialog regardless)

and shadows in popup menus seems to appear only the first time the popup 
appeared, second time is without shadow

-- 
Marco Martin

kdereview: qqc2-desktop-style

[Marco Martin]

Hi all,
I'm anouncing the QtQuickControls2 desktop style in kdereview, repo name is 
qqc2-desktop-style

It is intended to be a small style written in QML for QtQuickControls2 that is 
intended to be used by default in QQC2-based apps when used in the Plasma 
desktop (it shouldn't have any user-visible message, anywhere), its final 
intended location is kde/workspace to be released together with Plasma 5.11

-- 
Marco Martin

[kio-extras] [Bug 371278] Dolphin crashed when opening smb location

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=371278

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org
  Component|general |default
Product|frameworks-kio  |kio-extras
Version|5.29.0  |unspecified
   Assignee|fa...@kde.org   |plasma-devel@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Plasma 5.10 voice over text

[Eike Hein]

On 05/17/2017 09:03 PM, Łukasz Sawicki wrote:
>> This explains what it is, it doesn't explain what's changed since the last
>> release.
>> "Folder View is now the default desktop ..."
> 
> Changed to "Due to the popular demand we changed to Folder View as the
> default desktop which allows users to put whatever files or folders
> they want easy access to"

I'd communicate it more like this:

"In Plasma 5.10, we've brought back icons to the desktop by default.
Desktop icons were optional in previous releases of Plasma, but based on
your feedback, we know most of you prefer them. Both new and old users
of desktop icons can look forward to many improvements and new features
to them in this version, including spring-loading and ..."

I don't like the "popular demand" phrasing because it gets close to
implying a conflict (demand conjures images of angry pitchforks), and
I'd prefer the release vids to be positive (and confident, that's why I
have tentpole verbs like "know" in there instead of common weasel
phrasings like "we believe").


Cheers,
Eike